[INFO] cloning repository https://github.com/0ro8lu/chip_8_emulator_rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/0ro8lu/chip_8_emulator_rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F0ro8lu%2Fchip_8_emulator_rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F0ro8lu%2Fchip_8_emulator_rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2872127f87008b8a2b470302d0bbb2ef4cab2207 [INFO] linting 0ro8lu/chip_8_emulator_rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F0ro8lu%2Fchip_8_emulator_rust" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/0ro8lu/chip_8_emulator_rust [INFO] finished tweaking git repo https://github.com/0ro8lu/chip_8_emulator_rust [INFO] tweaked toml for git repo https://github.com/0ro8lu/chip_8_emulator_rust written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/0ro8lu/chip_8_emulator_rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/0ro8lu/chip_8_emulator_rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded ncurses v5.101.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e7f1f32a099861f40281824594b45feef108c32e01632fd7aaa4f70464c165de [INFO] running `Command { std: "docker" "start" "-a" "e7f1f32a099861f40281824594b45feef108c32e01632fd7aaa4f70464c165de", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e7f1f32a099861f40281824594b45feef108c32e01632fd7aaa4f70464c165de", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e7f1f32a099861f40281824594b45feef108c32e01632fd7aaa4f70464c165de", kill_on_drop: false }` [INFO] [stdout] e7f1f32a099861f40281824594b45feef108c32e01632fd7aaa4f70464c165de [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7aa49d61518e4b20a4d8126f3cb606a19362263a3311cecf9e111deb18a79b27 [INFO] running `Command { std: "docker" "start" "-a" "7aa49d61518e4b20a4d8126f3cb606a19362263a3311cecf9e111deb18a79b27", kill_on_drop: false }` [INFO] [stderr] Compiling pkg-config v0.3.26 [INFO] [stderr] Compiling cc v1.0.78 [INFO] [stderr] Compiling libc v0.2.139 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Compiling ncurses v5.101.0 [INFO] [stderr] Checking chip_8_emulator v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `client::DebugClient` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use client::DebugClient; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `client::DebugClient` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use client::DebugClient; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set_key` is never used [INFO] [stdout] --> src/cpu.rs:98:12 [INFO] [stdout] | [INFO] [stdout] 25 | impl Cpu { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 98 | pub fn set_key(&mut self, key: u8) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `DebugClient` is never constructed [INFO] [stdout] --> src/client/debug_client.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct DebugClient { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set_key` is never used [INFO] [stdout] --> src/cpu.rs:98:12 [INFO] [stdout] | [INFO] [stdout] 25 | impl Cpu { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 98 | pub fn set_key(&mut self, key: u8) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `DebugClient` is never constructed [INFO] [stdout] --> src/client/debug_client.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct DebugClient { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/client/ncurses_client.rs:31:17 [INFO] [stdout] | [INFO] [stdout] 31 | let pixel; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `pixel` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 31 ~ [INFO] [stdout] 32 ~ let pixel = if screen[x + (y * 64)] == 1 { [INFO] [stdout] 33 ~ char::from_u32(0x2588).unwrap() [INFO] [stdout] 34 | } else { [INFO] [stdout] 35 ~ ' ' [INFO] [stdout] 36 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/client/ncurses_client.rs:31:17 [INFO] [stdout] | [INFO] [stdout] 31 | let pixel; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `pixel` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 31 ~ [INFO] [stdout] 32 ~ let pixel = if screen[x + (y * 64)] == 1 { [INFO] [stdout] 33 ~ char::from_u32(0x2588).unwrap() [INFO] [stdout] 34 | } else { [INFO] [stdout] 35 ~ ' ' [INFO] [stdout] 36 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/client/ncurses_client.rs:226:16 [INFO] [stdout] | [INFO] [stdout] 226 | if (self.single_step && !self.paused && input as u8 == b'n') [INFO] [stdout] | ________________^ [INFO] [stdout] 227 | | || (!self.single_step && !self.paused) [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 226 - if (self.single_step && !self.paused && input as u8 == b'n') [INFO] [stdout] 227 - || (!self.single_step && !self.paused) [INFO] [stdout] 226 + if !(self.paused || self.single_step && input as u8 != b'n') [INFO] [stdout] | [INFO] [stdout] 226 - if (self.single_step && !self.paused && input as u8 == b'n') [INFO] [stdout] 227 - || (!self.single_step && !self.paused) [INFO] [stdout] 226 + if !self.single_step && !self.paused || !self.paused && input as u8 == b'n' [INFO] [stdout] | [INFO] [stdout] 226 - if (self.single_step && !self.paused && input as u8 == b'n') [INFO] [stdout] 227 - || (!self.single_step && !self.paused) [INFO] [stdout] 226 + if (input as u8 == b'n' || !self.single_step) && !self.paused [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/client/ncurses_client.rs:226:16 [INFO] [stdout] | [INFO] [stdout] 226 | if (self.single_step && !self.paused && input as u8 == b'n') [INFO] [stdout] | ________________^ [INFO] [stdout] 227 | | || (!self.single_step && !self.paused) [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 226 - if (self.single_step && !self.paused && input as u8 == b'n') [INFO] [stdout] 227 - || (!self.single_step && !self.paused) [INFO] [stdout] 226 + if !(self.paused || self.single_step && input as u8 != b'n') [INFO] [stdout] | [INFO] [stdout] 226 - if (self.single_step && !self.paused && input as u8 == b'n') [INFO] [stdout] 227 - || (!self.single_step && !self.paused) [INFO] [stdout] 226 + if !self.single_step && !self.paused || !self.paused && input as u8 == b'n' [INFO] [stdout] | [INFO] [stdout] 226 - if (self.single_step && !self.paused && input as u8 == b'n') [INFO] [stdout] 227 - || (!self.single_step && !self.paused) [INFO] [stdout] 226 + if (input as u8 == b'n' || !self.single_step) && !self.paused [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.08s [INFO] running `Command { std: "docker" "inspect" "7aa49d61518e4b20a4d8126f3cb606a19362263a3311cecf9e111deb18a79b27", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7aa49d61518e4b20a4d8126f3cb606a19362263a3311cecf9e111deb18a79b27", kill_on_drop: false }` [INFO] [stdout] 7aa49d61518e4b20a4d8126f3cb606a19362263a3311cecf9e111deb18a79b27