[INFO] cloning repository https://github.com/00000vish/vwallpaper [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/00000vish/vwallpaper" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F00000vish%2Fvwallpaper", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F00000vish%2Fvwallpaper'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c039c83e3728e5e546a9feb92f11ab70cfc0cd38 [INFO] linting 00000vish/vwallpaper against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F00000vish%2Fvwallpaper" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/00000vish/vwallpaper [INFO] finished tweaking git repo https://github.com/00000vish/vwallpaper [INFO] tweaked toml for git repo https://github.com/00000vish/vwallpaper written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/00000vish/vwallpaper on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/00000vish/vwallpaper already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded dirs v3.0.2 [INFO] [stderr] Downloaded toml v0.8.8 [INFO] [stderr] Downloaded toml_edit v0.21.0 [INFO] [stderr] Downloaded winnow v0.5.33 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f692e9fd443909445e5899056d361cc98f56f1e69a70078a790c97c2d7438d91 [INFO] running `Command { std: "docker" "start" "-a" "f692e9fd443909445e5899056d361cc98f56f1e69a70078a790c97c2d7438d91", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f692e9fd443909445e5899056d361cc98f56f1e69a70078a790c97c2d7438d91", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f692e9fd443909445e5899056d361cc98f56f1e69a70078a790c97c2d7438d91", kill_on_drop: false }` [INFO] [stdout] f692e9fd443909445e5899056d361cc98f56f1e69a70078a790c97c2d7438d91 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e3e8ef5850c18fa33648f543afda5a7e1397a6c658863c5c0b724ecfb700bcf7 [INFO] running `Command { std: "docker" "start" "-a" "e3e8ef5850c18fa33648f543afda5a7e1397a6c658863c5c0b724ecfb700bcf7", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking winnow v0.5.33 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking indexmap v2.1.0 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking dirs v3.0.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking toml_edit v0.21.0 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Checking tokio v1.35.1 [INFO] [stderr] Checking toml v0.8.8 [INFO] [stderr] Checking vwallpaper v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/config.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use dirs; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/config.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use dirs; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app.rs:23:58 [INFO] [stdout] | [INFO] [stdout] 23 | let wallpaper = match helpers::get_wallpaper(&display) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `display` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/config.rs:63:8 [INFO] [stdout] | [INFO] [stdout] 63 | if !file.is_ok() && !template.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `file.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/config.rs:63:25 [INFO] [stdout] | [INFO] [stdout] 63 | if !file.is_ok() && !template.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `template.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `file` after checking its variant with `is_ok` [INFO] [stdout] --> src/config.rs:68:45 [INFO] [stdout] | [INFO] [stdout] 67 | if file.is_ok() { [INFO] [stdout] | --------------- help: try: `if let Ok() = file` [INFO] [stdout] 68 | match helpers::read_file(parse_path(file.unwrap().to_string())) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:69:21 [INFO] [stdout] | [INFO] [stdout] 69 | None => return Err("Could not read config file".to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - None => return Err("Could not read config file".to_string()), [INFO] [stdout] 69 + None => Err("Could not read config file".to_string()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:70:28 [INFO] [stdout] | [INFO] [stdout] 70 | Some(value) => return Ok(value), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - Some(value) => return Ok(value), [INFO] [stdout] 70 + Some(value) => Ok(value), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | return Ok(template.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - return Ok(template.unwrap()); [INFO] [stdout] 73 + Ok(template.unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/config.rs:101:8 [INFO] [stdout] | [INFO] [stdout] 101 | if !file.is_ok() && !directory.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `file.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/config.rs:101:25 [INFO] [stdout] | [INFO] [stdout] 101 | if !file.is_ok() && !directory.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `directory.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/config.rs:122:8 [INFO] [stdout] | [INFO] [stdout] 122 | if !home_dir.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `home_dir.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/helpers/mod.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | / match &display.file { [INFO] [stdout] 10 | | Some(value) => return Ok(value.to_string()), [INFO] [stdout] 11 | | None => (), [INFO] [stdout] 12 | | } [INFO] [stdout] | |_____^ help: try: `if let Some(value) = &display.file { return Ok(value.to_string()) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/helpers/mod.rs:35:8 [INFO] [stdout] | [INFO] [stdout] 35 | if valid_files.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `valid_files.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helpers/mod.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return true; [INFO] [stdout] 55 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helpers/mod.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 64 | return Some(file); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return Some(file); [INFO] [stdout] 64 + Some(file) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runner.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return true; [INFO] [stdout] 28 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app.rs:23:58 [INFO] [stdout] | [INFO] [stdout] 23 | let wallpaper = match helpers::get_wallpaper(&display) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `display` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/main.rs:11:16 [INFO] [stdout] | [INFO] [stdout] 11 | async fn main() -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 17.52s [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/config.rs:63:8 [INFO] [stdout] | [INFO] [stdout] 63 | if !file.is_ok() && !template.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `file.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/config.rs:63:25 [INFO] [stdout] | [INFO] [stdout] 63 | if !file.is_ok() && !template.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `template.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `file` after checking its variant with `is_ok` [INFO] [stdout] --> src/config.rs:68:45 [INFO] [stdout] | [INFO] [stdout] 67 | if file.is_ok() { [INFO] [stdout] | --------------- help: try: `if let Ok() = file` [INFO] [stdout] 68 | match helpers::read_file(parse_path(file.unwrap().to_string())) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:69:21 [INFO] [stdout] | [INFO] [stdout] 69 | None => return Err("Could not read config file".to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - None => return Err("Could not read config file".to_string()), [INFO] [stdout] 69 + None => Err("Could not read config file".to_string()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:70:28 [INFO] [stdout] | [INFO] [stdout] 70 | Some(value) => return Ok(value), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - Some(value) => return Ok(value), [INFO] [stdout] 70 + Some(value) => Ok(value), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | return Ok(template.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - return Ok(template.unwrap()); [INFO] [stdout] 73 + Ok(template.unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/config.rs:101:8 [INFO] [stdout] | [INFO] [stdout] 101 | if !file.is_ok() && !directory.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `file.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/config.rs:101:25 [INFO] [stdout] | [INFO] [stdout] 101 | if !file.is_ok() && !directory.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `directory.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/config.rs:122:8 [INFO] [stdout] | [INFO] [stdout] 122 | if !home_dir.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `home_dir.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/helpers/mod.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | / match &display.file { [INFO] [stdout] 10 | | Some(value) => return Ok(value.to_string()), [INFO] [stdout] 11 | | None => (), [INFO] [stdout] 12 | | } [INFO] [stdout] | |_____^ help: try: `if let Some(value) = &display.file { return Ok(value.to_string()) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/helpers/mod.rs:35:8 [INFO] [stdout] | [INFO] [stdout] 35 | if valid_files.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `valid_files.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helpers/mod.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return true; [INFO] [stdout] 55 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helpers/mod.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 64 | return Some(file); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return Some(file); [INFO] [stdout] 64 + Some(file) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runner.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return true; [INFO] [stdout] 28 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/main.rs:11:16 [INFO] [stdout] | [INFO] [stdout] 11 | async fn main() -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "e3e8ef5850c18fa33648f543afda5a7e1397a6c658863c5c0b724ecfb700bcf7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e3e8ef5850c18fa33648f543afda5a7e1397a6c658863c5c0b724ecfb700bcf7", kill_on_drop: false }` [INFO] [stdout] e3e8ef5850c18fa33648f543afda5a7e1397a6c658863c5c0b724ecfb700bcf7