[INFO] fetching crate pipeawesome2 0.1.3... [INFO] testing pipeawesome2-0.1.3 against 1.90.0 for beta-1.91-3 [INFO] extracting crate pipeawesome2 0.1.3 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate pipeawesome2 0.1.3 [INFO] finished tweaking crates.io crate pipeawesome2 0.1.3 [INFO] tweaked toml for crates.io crate pipeawesome2 0.1.3 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate pipeawesome2 0.1.3 on toolchain 1.90.0 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1.90.0" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate pipeawesome2 0.1.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1.90.0" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded itoa v1.0.4 [INFO] [stderr] Downloaded peg v0.7.0 [INFO] [stderr] Downloaded peg-runtime v0.7.0 [INFO] [stderr] Downloaded serde v1.0.145 [INFO] [stderr] Downloaded dot-structures v0.1.0 [INFO] [stderr] Downloaded socket2 v0.4.7 [INFO] [stderr] Downloaded blocking v1.2.0 [INFO] [stderr] Downloaded async-lock v2.5.0 [INFO] [stderr] Downloaded async-executor v1.4.1 [INFO] [stderr] Downloaded wepoll-ffi v0.1.2 [INFO] [stderr] Downloaded ucd-trie v0.1.5 [INFO] [stderr] Downloaded pest_meta v2.4.0 [INFO] [stderr] Downloaded petgraph v0.6.2 [INFO] [stderr] Downloaded wasm-bindgen v0.2.83 [INFO] [stderr] Downloaded serde_json v1.0.86 [INFO] [stderr] Downloaded polling v2.3.0 [INFO] [stderr] Downloaded async-io v1.9.0 [INFO] [stderr] Downloaded js-sys v0.3.60 [INFO] [stderr] Downloaded pest v2.4.0 [INFO] [stderr] Downloaded async-process v1.5.0 [INFO] [stderr] Downloaded crossbeam-utils v0.8.12 [INFO] [stderr] Downloaded wasm-bindgen-backend v0.2.83 [INFO] [stderr] Downloaded libc v0.2.135 [INFO] [stderr] Downloaded once_cell v1.15.0 [INFO] [stderr] Downloaded block-buffer v0.10.3 [INFO] [stderr] Downloaded digest v0.10.5 [INFO] [stderr] Downloaded pest_derive v2.4.0 [INFO] [stderr] Downloaded async-global-executor v2.3.0 [INFO] [stderr] Downloaded cache-padded v1.2.0 [INFO] [stderr] Downloaded async-channel v1.7.1 [INFO] [stderr] Downloaded ctor v0.1.23 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.83 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.83 [INFO] [stderr] Downloaded wasm-bindgen-futures v0.4.33 [INFO] [stderr] Downloaded pest_generator v2.4.0 [INFO] [stderr] Downloaded atomic-waker v1.0.0 [INFO] [stderr] Downloaded web-sys v0.3.60 [INFO] [stderr] Downloaded graphviz-rust v0.1.2 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.83 [INFO] [stderr] Downloaded dot-generator v0.1.0 [INFO] [stderr] Downloaded into-attr-derive v0.1.0 [INFO] [stderr] Downloaded gloo-timers v0.2.4 [INFO] [stderr] Downloaded into-attr v0.1.0 [INFO] [stderr] Downloaded serde_derive v1.0.145 [INFO] [stderr] Downloaded peg-macros v0.7.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+1.90.0" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1dece170b0d37a300539355ad66ace0f0e9d9548f0dd1dbe76cf597e04b124b8 [INFO] running `Command { std: "docker" "start" "-a" "1dece170b0d37a300539355ad66ace0f0e9d9548f0dd1dbe76cf597e04b124b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1dece170b0d37a300539355ad66ace0f0e9d9548f0dd1dbe76cf597e04b124b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1dece170b0d37a300539355ad66ace0f0e9d9548f0dd1dbe76cf597e04b124b8", kill_on_drop: false }` [INFO] [stdout] 1dece170b0d37a300539355ad66ace0f0e9d9548f0dd1dbe76cf597e04b124b8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "RUSTDOCFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+1.90.0" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fe2326777d694b550bbcbfec2e6b59bb729041e0974e7898d2915b6477531ca9 [INFO] running `Command { std: "docker" "start" "-a" "fe2326777d694b550bbcbfec2e6b59bb729041e0974e7898d2915b6477531ca9", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.46 [INFO] [stderr] Compiling syn v1.0.102 [INFO] [stderr] Compiling libc v0.2.135 [INFO] [stderr] Compiling futures-core v0.3.24 [INFO] [stderr] Compiling once_cell v1.15.0 [INFO] [stderr] Compiling pin-project-lite v0.2.9 [INFO] [stderr] Compiling futures-io v0.3.24 [INFO] [stderr] Compiling fastrand v1.8.0 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling cache-padded v1.2.0 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling slab v0.4.7 [INFO] [stderr] Compiling value-bag v1.0.0-alpha.9 [INFO] [stderr] Compiling parking v2.0.0 [INFO] [stderr] Compiling waker-fn v1.1.0 [INFO] [stderr] Compiling polling v2.3.0 [INFO] [stderr] Compiling async-io v1.9.0 [INFO] [stderr] Compiling concurrent-queue v1.2.4 [INFO] [stderr] Compiling serde_derive v1.0.145 [INFO] [stderr] Compiling ucd-trie v0.1.5 [INFO] [stderr] Compiling futures-channel v0.3.24 [INFO] [stderr] Compiling futures-task v0.3.24 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Compiling dot-structures v0.1.0 [INFO] [stderr] Compiling futures-util v0.3.24 [INFO] [stderr] Compiling signal-hook v0.3.14 [INFO] [stderr] Compiling futures-sink v0.3.24 [INFO] [stderr] Compiling async-task v4.3.0 [INFO] [stderr] Compiling serde v1.0.145 [INFO] [stderr] Compiling async-channel v1.7.1 [INFO] [stderr] Compiling async-process v1.5.0 [INFO] [stderr] Compiling atomic-waker v1.0.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.12 [INFO] [stderr] Compiling ppv-lite86 v0.2.16 [INFO] [stderr] Compiling hashbrown v0.12.3 [INFO] [stderr] Compiling into-attr v0.1.0 [INFO] [stderr] Compiling dot-generator v0.1.0 [INFO] [stderr] Compiling async-lock v2.5.0 [INFO] [stderr] Compiling async-trait v0.1.57 [INFO] [stderr] Compiling linked-hash-map v0.5.6 [INFO] [stderr] Compiling remove_dir_all v0.5.3 [INFO] [stderr] Compiling ryu v1.0.11 [INFO] [stderr] Compiling peg-runtime v0.7.0 [INFO] [stderr] Compiling unicode-width v0.1.10 [INFO] [stderr] Compiling serde_json v1.0.86 [INFO] [stderr] Compiling yaml-rust v0.4.5 [INFO] [stderr] Compiling textwrap v0.11.0 [INFO] [stderr] Compiling futures-lite v1.12.0 [INFO] [stderr] Compiling itoa v1.0.4 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Compiling getrandom v0.2.7 [INFO] [stderr] Compiling socket2 v0.4.7 [INFO] [stderr] Compiling signal-hook-registry v1.4.0 [INFO] [stderr] Compiling tempfile v3.3.0 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling petgraph v0.6.2 [INFO] [stderr] Compiling clap v2.34.0 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling peg-macros v0.7.0 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling blocking v1.2.0 [INFO] [stderr] Compiling async-executor v1.4.1 [INFO] [stderr] Compiling peg v0.7.0 [INFO] [stderr] Compiling ctor v0.1.23 [INFO] [stderr] Compiling thiserror-impl v1.0.37 [INFO] [stderr] Compiling futures-macro v0.3.24 [INFO] [stderr] Compiling into-attr-derive v0.1.0 [INFO] [stderr] Compiling thiserror v1.0.37 [INFO] [stderr] Compiling pest v2.4.0 [INFO] [stderr] Compiling kv-log-macro v1.0.7 [INFO] [stderr] Compiling async-global-executor v2.3.0 [INFO] [stderr] Compiling async-std v1.12.0 [INFO] [stderr] Compiling pest_meta v2.4.0 [INFO] [stderr] Compiling pest_generator v2.4.0 [INFO] [stderr] Compiling pest_derive v2.4.0 [INFO] [stderr] Compiling graphviz-rust v0.1.2 [INFO] [stderr] Compiling futures-executor v0.3.24 [INFO] [stderr] Compiling futures v0.3.24 [INFO] [stderr] Compiling serde_yaml v0.8.26 [INFO] [stderr] Compiling pipeawesome2 v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/config.rs:371:26 [INFO] [stdout] | [INFO] [stdout] 371 | .and_modify(|mut lc| lc.command = Some(command.clone())) [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/config.rs:377:26 [INFO] [stdout] | [INFO] [stdout] 377 | .and_modify(|mut lc| lc.path = Some(path.clone())) [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/config.rs:384:26 [INFO] [stdout] | [INFO] [stdout] 384 | .and_modify(|mut lc| lc.arg = std::mem::take(&mut args)) [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/config.rs:391:26 [INFO] [stdout] | [INFO] [stdout] 391 | .and_modify(|mut lc| lc.env = std::mem::take(&mut env)) [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/faucet.rs:130:41 [INFO] [stdout] | [INFO] [stdout] 130 | ... for push in &mut self.stdout { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 130 - for push in &mut self.stdout { [INFO] [stdout] 130 + while let Some(push) = &mut self.stdout { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 130 - for push in &mut self.stdout { [INFO] [stdout] 130 + if let Some(push) = &mut self.stdout { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/regulator.rs:122:41 [INFO] [stdout] | [INFO] [stdout] 122 | ... for push in &mut self.stdout { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 122 - for push in &mut self.stdout { [INFO] [stdout] 122 + while let Some(push) = &mut self.stdout { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 122 - for push in &mut self.stdout { [INFO] [stdout] 122 + if let Some(push) = &mut self.stdout { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 34.31s [INFO] running `Command { std: "docker" "inspect" "fe2326777d694b550bbcbfec2e6b59bb729041e0974e7898d2915b6477531ca9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe2326777d694b550bbcbfec2e6b59bb729041e0974e7898d2915b6477531ca9", kill_on_drop: false }` [INFO] [stdout] fe2326777d694b550bbcbfec2e6b59bb729041e0974e7898d2915b6477531ca9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "RUSTDOCFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+1.90.0" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a0f1ef378479428f7f5418868d8db907c7d0a26b90eae6b87aea4ab896d4a2da [INFO] running `Command { std: "docker" "start" "-a" "a0f1ef378479428f7f5418868d8db907c7d0a26b90eae6b87aea4ab896d4a2da", kill_on_drop: false }` [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/config.rs:371:26 [INFO] [stdout] | [INFO] [stdout] 371 | .and_modify(|mut lc| lc.command = Some(command.clone())) [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/config.rs:377:26 [INFO] [stdout] | [INFO] [stdout] 377 | .and_modify(|mut lc| lc.path = Some(path.clone())) [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling pipeawesome2 v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/config.rs:384:26 [INFO] [stdout] | [INFO] [stdout] 384 | .and_modify(|mut lc| lc.arg = std::mem::take(&mut args)) [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/config.rs:391:26 [INFO] [stdout] | [INFO] [stdout] 391 | .and_modify(|mut lc| lc.env = std::mem::take(&mut env)) [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/faucet.rs:130:41 [INFO] [stdout] | [INFO] [stdout] 130 | ... for push in &mut self.stdout { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 130 - for push in &mut self.stdout { [INFO] [stdout] 130 + while let Some(push) = &mut self.stdout { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 130 - for push in &mut self.stdout { [INFO] [stdout] 130 + if let Some(push) = &mut self.stdout { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/regulator.rs:122:41 [INFO] [stdout] | [INFO] [stdout] 122 | ... for push in &mut self.stdout { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 122 - for push in &mut self.stdout { [INFO] [stdout] 122 + while let Some(push) = &mut self.stdout { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 122 - for push in &mut self.stdout { [INFO] [stdout] 122 + if let Some(push) = &mut self.stdout { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/config.rs:371:26 [INFO] [stdout] | [INFO] [stdout] 371 | .and_modify(|mut lc| lc.command = Some(command.clone())) [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/config.rs:377:26 [INFO] [stdout] | [INFO] [stdout] 377 | .and_modify(|mut lc| lc.path = Some(path.clone())) [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/config.rs:384:26 [INFO] [stdout] | [INFO] [stdout] 384 | .and_modify(|mut lc| lc.arg = std::mem::take(&mut args)) [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/config.rs:391:26 [INFO] [stdout] | [INFO] [stdout] 391 | .and_modify(|mut lc| lc.env = std::mem::take(&mut env)) [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/faucet.rs:130:41 [INFO] [stdout] | [INFO] [stdout] 130 | ... for push in &mut self.stdout { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 130 - for push in &mut self.stdout { [INFO] [stdout] 130 + while let Some(push) = &mut self.stdout { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 130 - for push in &mut self.stdout { [INFO] [stdout] 130 + if let Some(push) = &mut self.stdout { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/regulator.rs:122:41 [INFO] [stdout] | [INFO] [stdout] 122 | ... for push in &mut self.stdout { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 122 - for push in &mut self.stdout { [INFO] [stdout] 122 + while let Some(push) = &mut self.stdout { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 122 - for push in &mut self.stdout { [INFO] [stdout] 122 + if let Some(push) = &mut self.stdout { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 5.41s [INFO] running `Command { std: "docker" "inspect" "a0f1ef378479428f7f5418868d8db907c7d0a26b90eae6b87aea4ab896d4a2da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a0f1ef378479428f7f5418868d8db907c7d0a26b90eae6b87aea4ab896d4a2da", kill_on_drop: false }` [INFO] [stdout] a0f1ef378479428f7f5418868d8db907c7d0a26b90eae6b87aea4ab896d4a2da [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "RUSTDOCFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+1.90.0" "test" "--frozen", kill_on_drop: false }` [INFO] [stdout] d3ff52718385652e533f20e312ef397367c87eaa77e622d6b38f7c7849a49e83 [INFO] running `Command { std: "docker" "start" "-a" "d3ff52718385652e533f20e312ef397367c87eaa77e622d6b38f7c7849a49e83", kill_on_drop: false }` [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/config.rs:371:26 [INFO] [stderr] | [INFO] [stderr] 371 | .and_modify(|mut lc| lc.command = Some(command.clone())) [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/config.rs:377:26 [INFO] [stderr] | [INFO] [stderr] 377 | .and_modify(|mut lc| lc.path = Some(path.clone())) [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/config.rs:384:26 [INFO] [stderr] | [INFO] [stderr] 384 | .and_modify(|mut lc| lc.arg = std::mem::take(&mut args)) [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/config.rs:391:26 [INFO] [stderr] | [INFO] [stderr] 391 | .and_modify(|mut lc| lc.env = std::mem::take(&mut env)) [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stderr] --> src/faucet.rs:130:41 [INFO] [stderr] | [INFO] [stderr] 130 | ... for push in &mut self.stdout { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stderr] help: to check pattern in a loop use `while let` [INFO] [stderr] | [INFO] [stderr] 130 - for push in &mut self.stdout { [INFO] [stderr] 130 + while let Some(push) = &mut self.stdout { [INFO] [stderr] | [INFO] [stderr] help: consider using `if let` to clear intent [INFO] [stderr] | [INFO] [stderr] 130 - for push in &mut self.stdout { [INFO] [stderr] 130 + if let Some(push) = &mut self.stdout { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stderr] --> src/regulator.rs:122:41 [INFO] [stderr] | [INFO] [stderr] 122 | ... for push in &mut self.stdout { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] help: to check pattern in a loop use `while let` [INFO] [stderr] | [INFO] [stderr] 122 - for push in &mut self.stdout { [INFO] [stderr] 122 + while let Some(push) = &mut self.stdout { [INFO] [stderr] | [INFO] [stderr] help: consider using `if let` to clear intent [INFO] [stderr] | [INFO] [stderr] 122 - for push in &mut self.stdout { [INFO] [stderr] 122 + if let Some(push) = &mut self.stdout { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `pipeawesome2` (lib) generated 6 warnings (run `cargo fix --lib -p pipeawesome2` to apply 4 suggestions) [INFO] [stderr] warning: `pipeawesome2` (lib test) generated 6 warnings (6 duplicates) [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 0.20s [INFO] [stderr] Running unittests src/lib.rs (/opt/rustwide/target/debug/deps/pipeawesome2-d2f478bef846386b) [INFO] [stdout] [INFO] [stdout] running 19 tests [INFO] [stdout] test config::test_lint ... ok [INFO] [stdout] test config::config_serde ... ok [INFO] [stdout] test config_manip::test_add_junctions ... ok [INFO] [stdout] test motion::test_is_split ... ok [INFO] [stdout] test config_manip::test_pair_up_connections_folder ... ok [INFO] [stdout] test motion::test_motion_read_buffer ... ok [INFO] [stdout] test junction::do_stuff ... ok [INFO] [stdout] test fake_read::fake_reader_works ... ok [INFO] [stdout] test motion::test_motion_worker_output_closed_breakable ... ok [INFO] [stdout] test motion::test_motion_worker_skipped_input ... ok [INFO] [stdout] test motion::test_motion_worker_output_closed_unbreakable ... ok [INFO] [stdout] test config::test_add_junctions_for_multi_in ... ok [INFO] [stdout] test config::test_load_connection_from_string ... ok [INFO] [stdout] test config::test_quick_add_connection_set ... ok [INFO] [stdout] test utils::test_remove_vec_vec ... ok [INFO] [stdout] test utils::test_remove_vec_vec_index ... ok [INFO] [stdout] test regulator::do_stuff ... ok [INFO] [stdout] test faucet::do_stuff ... ok [INFO] [stdout] test buffer::do_stuff ... ok [INFO] [stderr] Running unittests src/bin/pa2.rs (/opt/rustwide/target/debug/deps/pa2-6e72f3d599b694a5) [INFO] [stdout] [INFO] [stdout] test result: ok. 19 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.12s [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stderr] Doc-tests pipeawesome2 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "d3ff52718385652e533f20e312ef397367c87eaa77e622d6b38f7c7849a49e83", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d3ff52718385652e533f20e312ef397367c87eaa77e622d6b38f7c7849a49e83", kill_on_drop: false }` [INFO] [stdout] d3ff52718385652e533f20e312ef397367c87eaa77e622d6b38f7c7849a49e83