[INFO] cloning repository https://github.com/DarkMatter-999/LC3-vm
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DarkMatter-999/LC3-vm" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDarkMatter-999%2FLC3-vm", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDarkMatter-999%2FLC3-vm'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 217dff8a5a439cafd9d31d9009e04844834f6eb7
[INFO] testing DarkMatter-999/LC3-vm against 1.85.0 for beta-1.86-1
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDarkMatter-999%2FLC3-vm" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'...
[INFO] [stderr] done.
[INFO] validating manifest of git repo https://github.com/DarkMatter-999/LC3-vm on toolchain 1.85.0
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1.85.0" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] started tweaking git repo https://github.com/DarkMatter-999/LC3-vm
[INFO] finished tweaking git repo https://github.com/DarkMatter-999/LC3-vm
[INFO] tweaked toml for git repo https://github.com/DarkMatter-999/LC3-vm written to /workspace/builds/worker-7-tc1/source/Cargo.toml
[INFO] crate git repo https://github.com/DarkMatter-999/LC3-vm already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1.85.0" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3959728d45483eb673ba100a951a6b9f5012970368db2a9e08e0ac9b67c8a5ad" "/opt/rustwide/cargo-home/bin/cargo" "+1.85.0" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 406fb770a5f6f554522e171c0c06ac8de46e874733c99ca6eb433f26a6f1c662
[INFO] running `Command { std: "docker" "start" "-a" "406fb770a5f6f554522e171c0c06ac8de46e874733c99ca6eb433f26a6f1c662", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "406fb770a5f6f554522e171c0c06ac8de46e874733c99ca6eb433f26a6f1c662", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "406fb770a5f6f554522e171c0c06ac8de46e874733c99ca6eb433f26a6f1c662", kill_on_drop: false }`
[INFO] [stdout] 406fb770a5f6f554522e171c0c06ac8de46e874733c99ca6eb433f26a6f1c662
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "RUSTDOCFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3959728d45483eb673ba100a951a6b9f5012970368db2a9e08e0ac9b67c8a5ad" "/opt/rustwide/cargo-home/bin/cargo" "+1.85.0" "build" "--frozen" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] b042ec0ce6e7314d46ca2d889ee891178a7b4f38f3c618f66308cd967f42f91d
[INFO] running `Command { std: "docker" "start" "-a" "b042ec0ce6e7314d46ca2d889ee891178a7b4f38f3c618f66308cd967f42f91d", kill_on_drop: false }`
[INFO] [stderr]    Compiling proc-macro2 v1.0.43
[INFO] [stderr]    Compiling unicode-ident v1.0.3
[INFO] [stderr]    Compiling syn v1.0.99
[INFO] [stderr]    Compiling wasm-bindgen-shared v0.2.82
[INFO] [stderr]    Compiling log v0.4.17
[INFO] [stderr]    Compiling serde_derive v1.0.143
[INFO] [stderr]    Compiling bumpalo v3.10.0
[INFO] [stderr]    Compiling serde v1.0.143
[INFO] [stderr]    Compiling once_cell v1.13.0
[INFO] [stderr]    Compiling serde_json v1.0.83
[INFO] [stderr]    Compiling ryu v1.0.11
[INFO] [stderr]    Compiling wasm-bindgen v0.2.82
[INFO] [stderr]    Compiling itoa v1.0.3
[INFO] [stderr]    Compiling quote v1.0.21
[INFO] [stderr]    Compiling wasm-bindgen-backend v0.2.82
[INFO] [stderr]    Compiling wasm-bindgen-macro-support v0.2.82
[INFO] [stderr]    Compiling wasm-bindgen-macro v0.2.82
[INFO] [stderr]    Compiling lc3_core v0.1.0 (/opt/rustwide/workdir/lc3_core)
[INFO] [stdout] warning: variant `kbsr` should have an upper camel case name
[INFO] [stdout]  --> lc3_core/src/memory.rs:7:5
[INFO] [stdout]   |
[INFO] [stdout] 7 |     kbsr = 0xFE00,
[INFO] [stdout]   |     ^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Kbsr`
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(non_camel_case_types)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant `kbdr` should have an upper camel case name
[INFO] [stdout]   --> lc3_core/src/memory.rs:10:5
[INFO] [stdout]    |
[INFO] [stdout] 10 |     kbdr = 0xFE02,
[INFO] [stdout]    |     ^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Kbdr`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `self`
[INFO] [stdout]  --> lc3_core/src/cpu.rs:5:26
[INFO] [stdout]   |
[INFO] [stdout] 5 | use crate::memory::{Mem, self};
[INFO] [stdout]   |                          ^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `super::*`
[INFO] [stdout]  --> lc3_core/src/cpu.rs:8:5
[INFO] [stdout]   |
[INFO] [stdout] 8 | use super::*;
[INFO] [stdout]   |     ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `while` condition
[INFO] [stdout]   --> lc3_core/src/cpu.rs:50:14
[INFO] [stdout]    |
[INFO] [stdout] 50 |         while(self.running) {
[INFO] [stdout]    |              ^            ^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_parens)]` on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 50 -         while(self.running) {
[INFO] [stdout] 50 +         while self.running {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `match` scrutinee expression
[INFO] [stdout]   --> lc3_core/src/cpu.rs:60:18
[INFO] [stdout]    |
[INFO] [stdout] 60 |             match(OPCodes::from(op)) {
[INFO] [stdout]    |                  ^                 ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 60 -             match(OPCodes::from(op)) {
[INFO] [stdout] 60 +             match OPCodes::from(op) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `while` condition
[INFO] [stdout]   --> lc3_core/src/cpu.rs:96:14
[INFO] [stdout]    |
[INFO] [stdout] 96 |         while(i<image.len()) {
[INFO] [stdout]    |              ^             ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 96 -         while(i<image.len()) {
[INFO] [stdout] 96 +         while i<image.len() {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around assigned value
[INFO] [stdout]    --> lc3_core/src/cpu.rs:112:18
[INFO] [stdout]     |
[INFO] [stdout] 112 |             x |= (0xFFFF << bit_count);
[INFO] [stdout]     |                  ^                   ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 112 -             x |= (0xFFFF << bit_count);
[INFO] [stdout] 112 +             x |= 0xFFFF << bit_count;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> lc3_core/src/cpu.rs:153:12
[INFO] [stdout]     |
[INFO] [stdout] 153 |         if (*self.get_reg(r) == 0) {
[INFO] [stdout]     |            ^                     ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 153 -         if (*self.get_reg(r) == 0) {
[INFO] [stdout] 153 +         if *self.get_reg(r) == 0 {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> lc3_core/src/cpu.rs:155:19
[INFO] [stdout]     |
[INFO] [stdout] 155 |         } else if ((*self.get_reg(r) >> 15) != 0) {
[INFO] [stdout]     |                   ^                             ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 155 -         } else if ((*self.get_reg(r) >> 15) != 0) {
[INFO] [stdout] 155 +         } else if (*self.get_reg(r) >> 15) != 0 {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> lc3_core/src/cpu.rs:167:12
[INFO] [stdout]     |
[INFO] [stdout] 167 |         if ((cond_flag & self.rcond) != 0) {
[INFO] [stdout]     |            ^                             ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 167 -         if ((cond_flag & self.rcond) != 0) {
[INFO] [stdout] 167 +         if (cond_flag & self.rcond) != 0 {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> lc3_core/src/cpu.rs:182:12
[INFO] [stdout]     |
[INFO] [stdout] 182 |         if (imm_flag != 0)
[INFO] [stdout]     |            ^             ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 182 -         if (imm_flag != 0)
[INFO] [stdout] 182 +         if imm_flag != 0
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> lc3_core/src/cpu.rs:222:12
[INFO] [stdout]     |
[INFO] [stdout] 222 |         if (long_flag != 0) {
[INFO] [stdout]     |            ^              ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 222 -         if (long_flag != 0) {
[INFO] [stdout] 222 +         if long_flag != 0 {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> lc3_core/src/cpu.rs:236:12
[INFO] [stdout]     |
[INFO] [stdout] 236 |         if (imm_flag != 0)
[INFO] [stdout]     |            ^             ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 236 -         if (imm_flag != 0)
[INFO] [stdout] 236 +         if imm_flag != 0
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> lc3_core/src/cpu.rs:361:16
[INFO] [stdout]     |
[INFO] [stdout] 361 |             if (chr == 0) {
[INFO] [stdout]     |                ^        ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 361 -             if (chr == 0) {
[INFO] [stdout] 361 +             if chr == 0 {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> lc3_core/src/cpu.rs:393:16
[INFO] [stdout]     |
[INFO] [stdout] 393 |             if (chr == 0) {
[INFO] [stdout]     |                ^        ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 393 -             if (chr == 0) {
[INFO] [stdout] 393 +             if chr == 0 {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around assigned value
[INFO] [stdout]    --> lc3_core/src/cpu.rs:397:22
[INFO] [stdout]     |
[INFO] [stdout] 397 |             let c1 = ((chr & 0xFF) as u8);
[INFO] [stdout]     |                      ^                  ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 397 -             let c1 = ((chr & 0xFF) as u8);
[INFO] [stdout] 397 +             let c1 = (chr & 0xFF) as u8;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around assigned value
[INFO] [stdout]    --> lc3_core/src/cpu.rs:399:22
[INFO] [stdout]     |
[INFO] [stdout] 399 |             let c2 = ((chr >> 8) as u8);
[INFO] [stdout]     |                      ^                ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 399 -             let c2 = ((chr >> 8) as u8);
[INFO] [stdout] 399 +             let c2 = (chr >> 8) as u8;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around assigned value
[INFO] [stdout]   --> lc3_core/src/disassembler.rs:23:14
[INFO] [stdout]    |
[INFO] [stdout] 23 |         x |= (0xFFFF << bit_count);
[INFO] [stdout]    |              ^                   ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 23 -         x |= (0xFFFF << bit_count);
[INFO] [stdout] 23 +         x |= 0xFFFF << bit_count;
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]   --> lc3_core/src/disassembler.rs:67:16
[INFO] [stdout]    |
[INFO] [stdout] 67 |             if (long_flag != 0) {
[INFO] [stdout]    |                ^              ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 67 -             if (long_flag != 0) {
[INFO] [stdout] 67 +             if long_flag != 0 {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `inst`
[INFO] [stdout]    --> lc3_core/src/cpu.rs:277:23
[INFO] [stdout]     |
[INFO] [stdout] 277 |     fn rti(&mut self, inst: u16) {
[INFO] [stdout]     |                       ^^^^ help: if this is intentional, prefix it with an underscore: `_inst`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_variables)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `inst`
[INFO] [stdout]    --> lc3_core/src/cpu.rs:320:23
[INFO] [stdout]     |
[INFO] [stdout] 320 |     fn res(&mut self, inst: u16) {
[INFO] [stdout]     |                       ^^^^ help: if this is intentional, prefix it with an underscore: `_inst`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `memory_max` should have an upper case name
[INFO] [stdout]  --> lc3_core/src/memory.rs:3:7
[INFO] [stdout]   |
[INFO] [stdout] 3 | const memory_max: usize = 1 << 16;
[INFO] [stdout]   |       ^^^^^^^^^^ help: convert the identifier to upper case: `MEMORY_MAX`
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(non_upper_case_globals)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]    Compiling LC3 v0.1.0 (/opt/rustwide/workdir)
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 17.33s
[INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: wasm-bindgen v0.2.82
[INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1`
[INFO] running `Command { std: "docker" "inspect" "b042ec0ce6e7314d46ca2d889ee891178a7b4f38f3c618f66308cd967f42f91d", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "b042ec0ce6e7314d46ca2d889ee891178a7b4f38f3c618f66308cd967f42f91d", kill_on_drop: false }`
[INFO] [stdout] b042ec0ce6e7314d46ca2d889ee891178a7b4f38f3c618f66308cd967f42f91d
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "RUSTDOCFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3959728d45483eb673ba100a951a6b9f5012970368db2a9e08e0ac9b67c8a5ad" "/opt/rustwide/cargo-home/bin/cargo" "+1.85.0" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 5bc4bff515de894e82a4ff89037eaebd18fdef758022287cdae82554923d6717
[INFO] running `Command { std: "docker" "start" "-a" "5bc4bff515de894e82a4ff89037eaebd18fdef758022287cdae82554923d6717", kill_on_drop: false }`
[INFO] [stdout] warning: variant `kbsr` should have an upper camel case name
[INFO] [stdout]  --> lc3_core/src/memory.rs:7:5
[INFO] [stdout]   |
[INFO] [stdout] 7 |     kbsr = 0xFE00,
[INFO] [stdout]   |     ^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Kbsr`
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(non_camel_case_types)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant `kbdr` should have an upper camel case name
[INFO] [stdout]   --> lc3_core/src/memory.rs:10:5
[INFO] [stdout]    |
[INFO] [stdout] 10 |     kbdr = 0xFE02,
[INFO] [stdout]    |     ^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Kbdr`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `self`
[INFO] [stdout]  --> lc3_core/src/cpu.rs:5:26
[INFO] [stdout]   |
[INFO] [stdout] 5 | use crate::memory::{Mem, self};
[INFO] [stdout]   |                          ^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `super::*`
[INFO] [stdout]  --> lc3_core/src/cpu.rs:8:5
[INFO] [stdout]   |
[INFO] [stdout] 8 | use super::*;
[INFO] [stdout]   |     ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `while` condition
[INFO] [stdout]   --> lc3_core/src/cpu.rs:50:14
[INFO] [stdout]    |
[INFO] [stdout] 50 |         while(self.running) {
[INFO] [stdout]    |              ^            ^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_parens)]` on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 50 -         while(self.running) {
[INFO] [stdout] 50 +         while self.running {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `match` scrutinee expression
[INFO] [stdout]   --> lc3_core/src/cpu.rs:60:18
[INFO] [stdout]    |
[INFO] [stdout] 60 |             match(OPCodes::from(op)) {
[INFO] [stdout]    |                  ^                 ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 60 -             match(OPCodes::from(op)) {
[INFO] [stdout] 60 +             match OPCodes::from(op) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `while` condition
[INFO] [stdout]   --> lc3_core/src/cpu.rs:96:14
[INFO] [stdout]    |
[INFO] [stdout] 96 |         while(i<image.len()) {
[INFO] [stdout]    |              ^             ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 96 -         while(i<image.len()) {
[INFO] [stdout] 96 +         while i<image.len() {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around assigned value
[INFO] [stdout]    --> lc3_core/src/cpu.rs:112:18
[INFO] [stdout]     |
[INFO] [stdout] 112 |             x |= (0xFFFF << bit_count);
[INFO] [stdout]     |                  ^                   ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 112 -             x |= (0xFFFF << bit_count);
[INFO] [stdout] 112 +             x |= 0xFFFF << bit_count;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> lc3_core/src/cpu.rs:153:12
[INFO] [stdout]     |
[INFO] [stdout] 153 |         if (*self.get_reg(r) == 0) {
[INFO] [stdout]     |            ^                     ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 153 -         if (*self.get_reg(r) == 0) {
[INFO] [stdout] 153 +         if *self.get_reg(r) == 0 {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]    Compiling LC3 v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> lc3_core/src/cpu.rs:155:19
[INFO] [stdout]     |
[INFO] [stdout] 155 |         } else if ((*self.get_reg(r) >> 15) != 0) {
[INFO] [stdout]     |                   ^                             ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 155 -         } else if ((*self.get_reg(r) >> 15) != 0) {
[INFO] [stdout] 155 +         } else if (*self.get_reg(r) >> 15) != 0 {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> lc3_core/src/cpu.rs:167:12
[INFO] [stdout]     |
[INFO] [stdout] 167 |         if ((cond_flag & self.rcond) != 0) {
[INFO] [stdout]     |            ^                             ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 167 -         if ((cond_flag & self.rcond) != 0) {
[INFO] [stdout] 167 +         if (cond_flag & self.rcond) != 0 {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> lc3_core/src/cpu.rs:182:12
[INFO] [stdout]     |
[INFO] [stdout] 182 |         if (imm_flag != 0)
[INFO] [stdout]     |            ^             ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 182 -         if (imm_flag != 0)
[INFO] [stdout] 182 +         if imm_flag != 0
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> lc3_core/src/cpu.rs:222:12
[INFO] [stdout]     |
[INFO] [stdout] 222 |         if (long_flag != 0) {
[INFO] [stdout]     |            ^              ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 222 -         if (long_flag != 0) {
[INFO] [stdout] 222 +         if long_flag != 0 {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> lc3_core/src/cpu.rs:236:12
[INFO] [stdout]     |
[INFO] [stdout] 236 |         if (imm_flag != 0)
[INFO] [stdout]     |            ^             ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 236 -         if (imm_flag != 0)
[INFO] [stdout] 236 +         if imm_flag != 0
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> lc3_core/src/cpu.rs:361:16
[INFO] [stdout]     |
[INFO] [stdout] 361 |             if (chr == 0) {
[INFO] [stdout]     |                ^        ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 361 -             if (chr == 0) {
[INFO] [stdout] 361 +             if chr == 0 {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> lc3_core/src/cpu.rs:393:16
[INFO] [stdout]     |
[INFO] [stdout] 393 |             if (chr == 0) {
[INFO] [stdout]     |                ^        ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 393 -             if (chr == 0) {
[INFO] [stdout] 393 +             if chr == 0 {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around assigned value
[INFO] [stdout]    --> lc3_core/src/cpu.rs:397:22
[INFO] [stdout]     |
[INFO] [stdout] 397 |             let c1 = ((chr & 0xFF) as u8);
[INFO] [stdout]     |                      ^                  ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 397 -             let c1 = ((chr & 0xFF) as u8);
[INFO] [stdout] 397 +             let c1 = (chr & 0xFF) as u8;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around assigned value
[INFO] [stdout]    --> lc3_core/src/cpu.rs:399:22
[INFO] [stdout]     |
[INFO] [stdout] 399 |             let c2 = ((chr >> 8) as u8);
[INFO] [stdout]     |                      ^                ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 399 -             let c2 = ((chr >> 8) as u8);
[INFO] [stdout] 399 +             let c2 = (chr >> 8) as u8;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around assigned value
[INFO] [stdout]   --> lc3_core/src/disassembler.rs:23:14
[INFO] [stdout]    |
[INFO] [stdout] 23 |         x |= (0xFFFF << bit_count);
[INFO] [stdout]    |              ^                   ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 23 -         x |= (0xFFFF << bit_count);
[INFO] [stdout] 23 +         x |= 0xFFFF << bit_count;
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]   --> lc3_core/src/disassembler.rs:67:16
[INFO] [stdout]    |
[INFO] [stdout] 67 |             if (long_flag != 0) {
[INFO] [stdout]    |                ^              ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 67 -             if (long_flag != 0) {
[INFO] [stdout] 67 +             if long_flag != 0 {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `inst`
[INFO] [stdout]    --> lc3_core/src/cpu.rs:277:23
[INFO] [stdout]     |
[INFO] [stdout] 277 |     fn rti(&mut self, inst: u16) {
[INFO] [stdout]     |                       ^^^^ help: if this is intentional, prefix it with an underscore: `_inst`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_variables)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `inst`
[INFO] [stdout]    --> lc3_core/src/cpu.rs:320:23
[INFO] [stdout]     |
[INFO] [stdout] 320 |     fn res(&mut self, inst: u16) {
[INFO] [stdout]     |                       ^^^^ help: if this is intentional, prefix it with an underscore: `_inst`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `memory_max` should have an upper case name
[INFO] [stdout]  --> lc3_core/src/memory.rs:3:7
[INFO] [stdout]   |
[INFO] [stdout] 3 | const memory_max: usize = 1 << 16;
[INFO] [stdout]   |       ^^^^^^^^^^ help: convert the identifier to upper case: `MEMORY_MAX`
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(non_upper_case_globals)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `test` profile [unoptimized + debuginfo] target(s) in 0.36s
[INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: wasm-bindgen v0.2.82
[INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1`
[INFO] running `Command { std: "docker" "inspect" "5bc4bff515de894e82a4ff89037eaebd18fdef758022287cdae82554923d6717", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "5bc4bff515de894e82a4ff89037eaebd18fdef758022287cdae82554923d6717", kill_on_drop: false }`
[INFO] [stdout] 5bc4bff515de894e82a4ff89037eaebd18fdef758022287cdae82554923d6717
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "RUSTDOCFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3959728d45483eb673ba100a951a6b9f5012970368db2a9e08e0ac9b67c8a5ad" "/opt/rustwide/cargo-home/bin/cargo" "+1.85.0" "test" "--frozen", kill_on_drop: false }`
[INFO] [stdout] eab3f0e4d8790a5090c6ee07ea96a597a36fea3d6080354c3ebdebb6e22d62e0
[INFO] running `Command { std: "docker" "start" "-a" "eab3f0e4d8790a5090c6ee07ea96a597a36fea3d6080354c3ebdebb6e22d62e0", kill_on_drop: false }`
[INFO] [stderr] warning: variant `kbsr` should have an upper camel case name
[INFO] [stderr]  --> lc3_core/src/memory.rs:7:5
[INFO] [stderr]   |
[INFO] [stderr] 7 |     kbsr = 0xFE00,
[INFO] [stderr]   |     ^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Kbsr`
[INFO] [stderr]   |
[INFO] [stderr]   = note: `#[warn(non_camel_case_types)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant `kbdr` should have an upper camel case name
[INFO] [stderr]   --> lc3_core/src/memory.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     kbdr = 0xFE02,
[INFO] [stderr]    |     ^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Kbdr`
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `self`
[INFO] [stderr]  --> lc3_core/src/cpu.rs:5:26
[INFO] [stderr]   |
[INFO] [stderr] 5 | use crate::memory::{Mem, self};
[INFO] [stderr]   |                          ^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: `#[warn(unused_imports)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `super::*`
[INFO] [stderr]  --> lc3_core/src/cpu.rs:8:5
[INFO] [stderr]   |
[INFO] [stderr] 8 | use super::*;
[INFO] [stderr]   |     ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `while` condition
[INFO] [stderr]   --> lc3_core/src/cpu.rs:50:14
[INFO] [stderr]    |
[INFO] [stderr] 50 |         while(self.running) {
[INFO] [stderr]    |              ^            ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: `#[warn(unused_parens)]` on by default
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr] 50 -         while(self.running) {
[INFO] [stderr] 50 +         while self.running {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `match` scrutinee expression
[INFO] [stderr]   --> lc3_core/src/cpu.rs:60:18
[INFO] [stderr]    |
[INFO] [stderr] 60 |             match(OPCodes::from(op)) {
[INFO] [stderr]    |                  ^                 ^
[INFO] [stderr]    |
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr] 60 -             match(OPCodes::from(op)) {
[INFO] [stderr] 60 +             match OPCodes::from(op) {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `while` condition
[INFO] [stderr]   --> lc3_core/src/cpu.rs:96:14
[INFO] [stderr]    |
[INFO] [stderr] 96 |         while(i<image.len()) {
[INFO] [stderr]    |              ^             ^
[INFO] [stderr]    |
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr] 96 -         while(i<image.len()) {
[INFO] [stderr] 96 +         while i<image.len() {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around assigned value
[INFO] [stderr]    --> lc3_core/src/cpu.rs:112:18
[INFO] [stderr]     |
[INFO] [stderr] 112 |             x |= (0xFFFF << bit_count);
[INFO] [stderr]     |                  ^                   ^
[INFO] [stderr]     |
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr] 112 -             x |= (0xFFFF << bit_count);
[INFO] [stderr] 112 +             x |= 0xFFFF << bit_count;
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]    --> lc3_core/src/cpu.rs:153:12
[INFO] [stderr]     |
[INFO] [stderr] 153 |         if (*self.get_reg(r) == 0) {
[INFO] [stderr]     |            ^                     ^
[INFO] [stderr]     |
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr] 153 -         if (*self.get_reg(r) == 0) {
[INFO] [stderr] 153 +         if *self.get_reg(r) == 0 {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]    --> lc3_core/src/cpu.rs:155:19
[INFO] [stderr]     |
[INFO] [stderr] 155 |         } else if ((*self.get_reg(r) >> 15) != 0) {
[INFO] [stderr]     |                   ^                             ^
[INFO] [stderr]     |
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr] 155 -         } else if ((*self.get_reg(r) >> 15) != 0) {
[INFO] [stderr] 155 +         } else if (*self.get_reg(r) >> 15) != 0 {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]    --> lc3_core/src/cpu.rs:167:12
[INFO] [stderr]     |
[INFO] [stderr] 167 |         if ((cond_flag & self.rcond) != 0) {
[INFO] [stderr]     |            ^                             ^
[INFO] [stderr]     |
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr] 167 -         if ((cond_flag & self.rcond) != 0) {
[INFO] [stderr] 167 +         if (cond_flag & self.rcond) != 0 {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]    --> lc3_core/src/cpu.rs:182:12
[INFO] [stderr]     |
[INFO] [stderr] 182 |         if (imm_flag != 0)
[INFO] [stderr]     |            ^             ^
[INFO] [stderr]     |
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr] 182 -         if (imm_flag != 0)
[INFO] [stderr] 182 +         if imm_flag != 0
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]    --> lc3_core/src/cpu.rs:222:12
[INFO] [stderr]     |
[INFO] [stderr] 222 |         if (long_flag != 0) {
[INFO] [stderr]     |            ^              ^
[INFO] [stderr]     |
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr] 222 -         if (long_flag != 0) {
[INFO] [stderr] 222 +         if long_flag != 0 {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]    --> lc3_core/src/cpu.rs:236:12
[INFO] [stderr]     |
[INFO] [stderr] 236 |         if (imm_flag != 0)
[INFO] [stderr]     |            ^             ^
[INFO] [stderr]     |
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr] 236 -         if (imm_flag != 0)
[INFO] [stderr] 236 +         if imm_flag != 0
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]    --> lc3_core/src/cpu.rs:361:16
[INFO] [stderr]     |
[INFO] [stderr] 361 |             if (chr == 0) {
[INFO] [stderr]     |                ^        ^
[INFO] [stderr]     |
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr] 361 -             if (chr == 0) {
[INFO] [stderr] 361 +             if chr == 0 {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]    --> lc3_core/src/cpu.rs:393:16
[INFO] [stderr]     |
[INFO] [stderr] 393 |             if (chr == 0) {
[INFO] [stderr]     |                ^        ^
[INFO] [stderr]     |
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr] 393 -             if (chr == 0) {
[INFO] [stderr] 393 +             if chr == 0 {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around assigned value
[INFO] [stderr]    --> lc3_core/src/cpu.rs:397:22
[INFO] [stderr]     |
[INFO] [stderr] 397 |             let c1 = ((chr & 0xFF) as u8);
[INFO] [stderr]     |                      ^                  ^
[INFO] [stderr]     |
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr] 397 -             let c1 = ((chr & 0xFF) as u8);
[INFO] [stderr] 397 +             let c1 = (chr & 0xFF) as u8;
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around assigned value
[INFO] [stderr]    --> lc3_core/src/cpu.rs:399:22
[INFO] [stderr]     |
[INFO] [stderr] 399 |             let c2 = ((chr >> 8) as u8);
[INFO] [stderr]     |                      ^                ^
[INFO] [stderr]     |
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr] 399 -             let c2 = ((chr >> 8) as u8);
[INFO] [stderr] 399 +             let c2 = (chr >> 8) as u8;
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around assigned value
[INFO] [stderr]   --> lc3_core/src/disassembler.rs:23:14
[INFO] [stderr]    |
[INFO] [stderr] 23 |         x |= (0xFFFF << bit_count);
[INFO] [stderr]    |              ^                   ^
[INFO] [stderr]    |
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr] 23 -         x |= (0xFFFF << bit_count);
[INFO] [stderr] 23 +         x |= 0xFFFF << bit_count;
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> lc3_core/src/disassembler.rs:67:16
[INFO] [stderr]    |
[INFO] [stderr] 67 |             if (long_flag != 0) {
[INFO] [stderr]    |                ^              ^
[INFO] [stderr]    |
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr] 67 -             if (long_flag != 0) {
[INFO] [stderr] 67 +             if long_flag != 0 {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `inst`
[INFO] [stderr]    --> lc3_core/src/cpu.rs:277:23
[INFO] [stderr]     |
[INFO] [stderr] 277 |     fn rti(&mut self, inst: u16) {
[INFO] [stderr]     |                       ^^^^ help: if this is intentional, prefix it with an underscore: `_inst`
[INFO] [stderr]     |
[INFO] [stderr]     = note: `#[warn(unused_variables)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `inst`
[INFO] [stderr]    --> lc3_core/src/cpu.rs:320:23
[INFO] [stderr]     |
[INFO] [stderr] 320 |     fn res(&mut self, inst: u16) {
[INFO] [stderr]     |                       ^^^^ help: if this is intentional, prefix it with an underscore: `_inst`
[INFO] [stderr] 
[INFO] [stderr] warning: constant `memory_max` should have an upper case name
[INFO] [stderr]  --> lc3_core/src/memory.rs:3:7
[INFO] [stderr]   |
[INFO] [stderr] 3 | const memory_max: usize = 1 << 16;
[INFO] [stderr]   |       ^^^^^^^^^^ help: convert the identifier to upper case: `MEMORY_MAX`
[INFO] [stderr]   |
[INFO] [stderr]   = note: `#[warn(non_upper_case_globals)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: `lc3_core` (lib) generated 23 warnings (run `cargo fix --lib -p lc3_core` to apply 18 suggestions)
[INFO] [stderr]     Finished `test` profile [unoptimized + debuginfo] target(s) in 0.03s
[INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: wasm-bindgen v0.2.82
[INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1`
[INFO] [stderr]      Running unittests src/main.rs (/opt/rustwide/target/debug/deps/LC3-e982ec35675a7ebb)
[INFO] [stdout] 
[INFO] [stdout] running 0 tests
[INFO] [stdout] 
[INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
[INFO] [stdout] 
[INFO] running `Command { std: "docker" "inspect" "eab3f0e4d8790a5090c6ee07ea96a597a36fea3d6080354c3ebdebb6e22d62e0", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "eab3f0e4d8790a5090c6ee07ea96a597a36fea3d6080354c3ebdebb6e22d62e0", kill_on_drop: false }`
[INFO] [stdout] eab3f0e4d8790a5090c6ee07ea96a597a36fea3d6080354c3ebdebb6e22d62e0