[INFO] cloning repository https://github.com/0xWOLAND/rust-fmm [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/0xWOLAND/rust-fmm" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F0xWOLAND%2Frust-fmm", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F0xWOLAND%2Frust-fmm'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] dac919bb79e5aaa2eba74dc5e03d6810f2a6dcca [INFO] testing 0xWOLAND/rust-fmm against 1.85.0 for beta-1.86-1 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F0xWOLAND%2Frust-fmm" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/0xWOLAND/rust-fmm on toolchain 1.85.0 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1.85.0" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-3-tc1/source/rust-toolchain [INFO] started tweaking git repo https://github.com/0xWOLAND/rust-fmm [INFO] finished tweaking git repo https://github.com/0xWOLAND/rust-fmm [INFO] tweaked toml for git repo https://github.com/0xWOLAND/rust-fmm written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/0xWOLAND/rust-fmm already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1.85.0" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded crossbeam-deque v0.8.3 [INFO] [stderr] Downloaded memoffset v0.9.0 [INFO] [stderr] Downloaded crossbeam-epoch v0.9.15 [INFO] [stderr] Downloaded crossbeam-utils v0.8.16 [INFO] [stderr] Downloaded toml_datetime v0.6.3 [INFO] [stderr] Downloaded rayon v1.7.0 [INFO] [stderr] Downloaded serde_spanned v0.6.3 [INFO] [stderr] Downloaded toml v0.7.6 [INFO] [stderr] Downloaded rand_distr v0.4.3 [INFO] [stderr] Downloaded indexmap v2.0.0 [INFO] [stderr] Downloaded memchr v2.6.3 [INFO] [stderr] Downloaded itertools v0.11.0 [INFO] [stderr] Downloaded libm v0.2.7 [INFO] [stderr] Downloaded winnow v0.5.15 [INFO] [stderr] Downloaded hashbrown v0.14.0 [INFO] [stderr] Downloaded crossbeam-channel v0.5.8 [INFO] [stderr] Downloaded toml_edit v0.19.14 [INFO] [stderr] Downloaded serde_derive v1.0.188 [INFO] [stderr] Downloaded serde v1.0.188 [INFO] [stderr] Downloaded either v1.9.0 [INFO] [stderr] Downloaded rayon-core v1.11.0 [INFO] [stderr] Downloaded spmc v0.3.0 [INFO] [stderr] Downloaded wasm-bindgen-rayon v1.0.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3959728d45483eb673ba100a951a6b9f5012970368db2a9e08e0ac9b67c8a5ad" "/opt/rustwide/cargo-home/bin/cargo" "+1.85.0" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 13cdc5184e46162c339d1fa57705f08997695650621c800d585e0689c5918cba [INFO] running `Command { std: "docker" "start" "-a" "13cdc5184e46162c339d1fa57705f08997695650621c800d585e0689c5918cba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "13cdc5184e46162c339d1fa57705f08997695650621c800d585e0689c5918cba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "13cdc5184e46162c339d1fa57705f08997695650621c800d585e0689c5918cba", kill_on_drop: false }` [INFO] [stdout] 13cdc5184e46162c339d1fa57705f08997695650621c800d585e0689c5918cba [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "RUSTDOCFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3959728d45483eb673ba100a951a6b9f5012970368db2a9e08e0ac9b67c8a5ad" "/opt/rustwide/cargo-home/bin/cargo" "+1.85.0" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 183a1c5bf44ad279aa7541008105928a6f747cd03b136eb20639d3a9c85d7a1f [INFO] running `Command { std: "docker" "start" "-a" "183a1c5bf44ad279aa7541008105928a6f747cd03b136eb20639d3a9c85d7a1f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.87 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Compiling bumpalo v3.13.0 [INFO] [stderr] Compiling once_cell v1.18.0 [INFO] [stderr] Compiling log v0.4.20 [INFO] [stderr] Compiling libm v0.2.7 [INFO] [stderr] Compiling wasm-bindgen v0.2.87 [INFO] [stderr] Compiling hashbrown v0.14.0 [INFO] [stderr] Compiling winnow v0.5.15 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Compiling either v1.9.0 [INFO] [stderr] Compiling itertools v0.11.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling indexmap v2.0.0 [INFO] [stderr] Compiling getrandom v0.2.10 [INFO] [stderr] Compiling syn v2.0.29 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling rand_distr v0.4.3 [INFO] [stderr] Compiling toml_datetime v0.6.3 [INFO] [stderr] Compiling serde_spanned v0.6.3 [INFO] [stderr] Compiling toml_edit v0.19.14 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.87 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.87 [INFO] [stderr] Compiling toml v0.7.6 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.87 [INFO] [stderr] Compiling console_error_panic_hook v0.1.7 [INFO] [stderr] Compiling js-sys v0.3.64 [INFO] [stderr] Compiling rust-ffm v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `Arc` and `Mutex` [INFO] [stdout] --> src/ic.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | use std::sync::{Arc, Mutex}; [INFO] [stdout] | ^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `config::G_CONSTANT` [INFO] [stdout] --> src/octree.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | config::G_CONSTANT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/sgalic/cmf.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 32 | if (fa != fc && fb != fc) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 32 - if (fa != fc && fb != fc) { [INFO] [stdout] 32 + if fa != fc && fb != fc { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/sgalic/cmf.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 57 | if (fa * fs < 0.) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 57 - if (fa * fs < 0.) { [INFO] [stdout] 57 + if fa * fs < 0. { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/sgalic/cmf.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 65 | if (fa.abs() < fb.abs()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 65 - if (fa.abs() < fb.abs()) { [INFO] [stdout] 65 + if fa.abs() < fb.abs() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fs` [INFO] [stdout] --> src/sgalic/config.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::fs; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `config::AU` and `fmm::Particle` [INFO] [stdout] --> src/utils.rs:5:13 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::{config::AU, fmm::Particle}; [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `fs` is never read [INFO] [stdout] --> src/sgalic/cmf.rs:13:13 [INFO] [stdout] | [INFO] [stdout] 13 | let mut fs = 0.; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/simulation.rs:90:24 [INFO] [stdout] | [INFO] [stdout] 90 | for (pos, vel, mut group) in izip!(positions, velocities, particle_groups) { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `M` should have a snake case name [INFO] [stdout] --> src/ic.rs:15:42 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn plummer(n: usize, a: Option, M: Option) -> Vec { [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `M_bulge` should have a snake case name [INFO] [stdout] --> src/sgalic/bulge.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | let M_bulge = config.bulge.M_bulge; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `m_bulge` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `N_bulge` should have a snake case name [INFO] [stdout] --> src/sgalic/bulge.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | let N_bulge = config.bulge.N_bulge as usize; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `n_bulge` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `bulge_cut_M` should have a snake case name [INFO] [stdout] --> src/sgalic/bulge.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | let bulge_cut_M = dehnen_cmf(bulge_cut_r, M_bulge, a_bulge, gamma_bulge); [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `bulge_cut_m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Mc` should have a snake case name [INFO] [stdout] --> src/sgalic/bulge.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | let Mc = gen_random_array(N_bulge) [INFO] [stdout] | ^^ help: convert the identifier to snake case: `mc` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `MAX_ITER` should have a snake case name [INFO] [stdout] --> src/sgalic/cmf.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | let MAX_ITER = 10000; [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `max_iter` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `M` should have a snake case name [INFO] [stdout] --> src/sgalic/cmf.rs:75:27 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn dehnen_cmf(r: f64, M: f64, a: f64, gamma: i32) -> f64 { [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Mc` should have a snake case name [INFO] [stdout] --> src/sgalic/cmf.rs:80:23 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn dehnen_cmf_inv(Mc: Vec, M: f64, a: f64, gamma: i32) -> Vec { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `mc` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `M` should have a snake case name [INFO] [stdout] --> src/sgalic/cmf.rs:80:37 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn dehnen_cmf_inv(Mc: Vec, M: f64, a: f64, gamma: i32) -> Vec { [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Rd` should have a snake case name [INFO] [stdout] --> src/sgalic/cmf.rs:102:33 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn disk_radial_cmf(r: &f64, Rd: &f64) -> f64 { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `rd` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Rd` should have a snake case name [INFO] [stdout] --> src/sgalic/cmf.rs:106:40 [INFO] [stdout] | [INFO] [stdout] 106 | pub fn disk_radial_cmf_inv(frac: &f64, Rd: &f64) -> f64 { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `rd` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `M_halo` should have a snake case name [INFO] [stdout] --> src/sgalic/config.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | pub M_halo: f64, [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `m_halo` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `N_halo` should have a snake case name [INFO] [stdout] --> src/sgalic/config.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | pub N_halo: i32, [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `n_halo` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `M_disk` should have a snake case name [INFO] [stdout] --> src/sgalic/config.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | pub M_disk: f64, [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `m_disk` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `N_disk` should have a snake case name [INFO] [stdout] --> src/sgalic/config.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | pub N_disk: i32, [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `n_disk` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Rd` should have a snake case name [INFO] [stdout] --> src/sgalic/config.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | pub Rd: f64, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `rd` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `M_bulge` should have a snake case name [INFO] [stdout] --> src/sgalic/config.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | pub M_bulge: f64, [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `m_bulge` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `N_bulge` should have a snake case name [INFO] [stdout] --> src/sgalic/config.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | pub N_bulge: i32, [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `n_bulge` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `N_rho` should have a snake case name [INFO] [stdout] --> src/sgalic/config.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | pub N_rho: f64, [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `n_rho` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Nz` should have a snake case name [INFO] [stdout] --> src/sgalic/config.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | pub Nz: f64, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `nz` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `N` should have a snake case name [INFO] [stdout] --> src/sgalic/disk.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | let N = config.disk.N_disk as usize; [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Rd` should have a snake case name [INFO] [stdout] --> src/sgalic/disk.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | let Rd = config.disk.Rd; [INFO] [stdout] | ^^ help: convert the identifier to snake case: `rd` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `bulge_cut_M` should have a snake case name [INFO] [stdout] --> src/sgalic/generate.rs:12:24 [INFO] [stdout] | [INFO] [stdout] 12 | let (coords_bulge, bulge_cut_M) = set_bulge_positions(&config); [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `bulge_cut_m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `halo_cut_M` should have a snake case name [INFO] [stdout] --> src/sgalic/generate.rs:13:23 [INFO] [stdout] | [INFO] [stdout] 13 | let (coords_halo, halo_cut_M) = set_halo_positions(&config); [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `halo_cut_m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `M_halo` should have a snake case name [INFO] [stdout] --> src/sgalic/halo.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | let M_halo = config.halo.M_halo; [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `m_halo` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `N_halo` should have a snake case name [INFO] [stdout] --> src/sgalic/halo.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | let N_halo = config.halo.N_halo as usize; [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `n_halo` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `halo_cut_M` should have a snake case name [INFO] [stdout] --> src/sgalic/halo.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | let halo_cut_M = dehnen_cmf(halo_cut_r, M_halo, a_halo, gamma_halo); [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `halo_cut_m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Mc` should have a snake case name [INFO] [stdout] --> src/sgalic/halo.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | let Mc = gen_random_array(N_halo) [INFO] [stdout] | ^^ help: convert the identifier to snake case: `mc` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `Helpers` should have a snake case name [INFO] [stdout] --> src/simulation.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | mod Helpers { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `helpers` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `M` should have a snake case name [INFO] [stdout] --> src/simulation.rs:59:34 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn new(n: usize, a: f64, M: f64) -> CosmoSim { [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 19.36s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: wasm-bindgen v0.2.87 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "183a1c5bf44ad279aa7541008105928a6f747cd03b136eb20639d3a9c85d7a1f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "183a1c5bf44ad279aa7541008105928a6f747cd03b136eb20639d3a9c85d7a1f", kill_on_drop: false }` [INFO] [stdout] 183a1c5bf44ad279aa7541008105928a6f747cd03b136eb20639d3a9c85d7a1f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "RUSTDOCFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3959728d45483eb673ba100a951a6b9f5012970368db2a9e08e0ac9b67c8a5ad" "/opt/rustwide/cargo-home/bin/cargo" "+1.85.0" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f96efd3be2946170c843fa9723ddfa87837e9c2119853476b55eb9fb3935fb4e [INFO] running `Command { std: "docker" "start" "-a" "f96efd3be2946170c843fa9723ddfa87837e9c2119853476b55eb9fb3935fb4e", kill_on_drop: false }` [INFO] [stderr] Compiling rust-ffm v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `Arc` and `Mutex` [INFO] [stdout] --> src/ic.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | use std::sync::{Arc, Mutex}; [INFO] [stdout] | ^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::sgalic::halo::*` [INFO] [stdout] --> src/ic.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | use crate::sgalic::halo::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `config::AU` [INFO] [stdout] --> src/ic.rs:84:17 [INFO] [stdout] | [INFO] [stdout] 84 | use crate::{config::AU, ic::plummer}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `config::G_CONSTANT` [INFO] [stdout] --> src/octree.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | config::G_CONSTANT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/sgalic/cmf.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 32 | if (fa != fc && fb != fc) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 32 - if (fa != fc && fb != fc) { [INFO] [stdout] 32 + if fa != fc && fb != fc { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/sgalic/cmf.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 57 | if (fa * fs < 0.) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 57 - if (fa * fs < 0.) { [INFO] [stdout] 57 + if fa * fs < 0. { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/sgalic/cmf.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 65 | if (fa.abs() < fb.abs()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 65 - if (fa.abs() < fb.abs()) { [INFO] [stdout] 65 + if fa.abs() < fb.abs() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fs` [INFO] [stdout] --> src/sgalic/config.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::fs; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `config::AU` and `fmm::Particle` [INFO] [stdout] --> src/utils.rs:5:13 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::{config::AU, fmm::Particle}; [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `fs` is never read [INFO] [stdout] --> src/sgalic/cmf.rs:13:13 [INFO] [stdout] | [INFO] [stdout] 13 | let mut fs = 0.; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/simulation.rs:90:24 [INFO] [stdout] | [INFO] [stdout] 90 | for (pos, vel, mut group) in izip!(positions, velocities, particle_groups) { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `M` should have a snake case name [INFO] [stdout] --> src/ic.rs:15:42 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn plummer(n: usize, a: Option, M: Option) -> Vec { [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `M_bulge` should have a snake case name [INFO] [stdout] --> src/sgalic/bulge.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | let M_bulge = config.bulge.M_bulge; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `m_bulge` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `N_bulge` should have a snake case name [INFO] [stdout] --> src/sgalic/bulge.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | let N_bulge = config.bulge.N_bulge as usize; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `n_bulge` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `bulge_cut_M` should have a snake case name [INFO] [stdout] --> src/sgalic/bulge.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | let bulge_cut_M = dehnen_cmf(bulge_cut_r, M_bulge, a_bulge, gamma_bulge); [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `bulge_cut_m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Mc` should have a snake case name [INFO] [stdout] --> src/sgalic/bulge.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | let Mc = gen_random_array(N_bulge) [INFO] [stdout] | ^^ help: convert the identifier to snake case: `mc` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `MAX_ITER` should have a snake case name [INFO] [stdout] --> src/sgalic/cmf.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | let MAX_ITER = 10000; [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `max_iter` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `M` should have a snake case name [INFO] [stdout] --> src/sgalic/cmf.rs:75:27 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn dehnen_cmf(r: f64, M: f64, a: f64, gamma: i32) -> f64 { [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Mc` should have a snake case name [INFO] [stdout] --> src/sgalic/cmf.rs:80:23 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn dehnen_cmf_inv(Mc: Vec, M: f64, a: f64, gamma: i32) -> Vec { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `mc` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `M` should have a snake case name [INFO] [stdout] --> src/sgalic/cmf.rs:80:37 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn dehnen_cmf_inv(Mc: Vec, M: f64, a: f64, gamma: i32) -> Vec { [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Rd` should have a snake case name [INFO] [stdout] --> src/sgalic/cmf.rs:102:33 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn disk_radial_cmf(r: &f64, Rd: &f64) -> f64 { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `rd` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Rd` should have a snake case name [INFO] [stdout] --> src/sgalic/cmf.rs:106:40 [INFO] [stdout] | [INFO] [stdout] 106 | pub fn disk_radial_cmf_inv(frac: &f64, Rd: &f64) -> f64 { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `rd` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `M_halo` should have a snake case name [INFO] [stdout] --> src/sgalic/config.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | pub M_halo: f64, [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `m_halo` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `N_halo` should have a snake case name [INFO] [stdout] --> src/sgalic/config.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | pub N_halo: i32, [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `n_halo` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `M_disk` should have a snake case name [INFO] [stdout] --> src/sgalic/config.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | pub M_disk: f64, [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `m_disk` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `N_disk` should have a snake case name [INFO] [stdout] --> src/sgalic/config.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | pub N_disk: i32, [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `n_disk` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Rd` should have a snake case name [INFO] [stdout] --> src/sgalic/config.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | pub Rd: f64, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `rd` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `M_bulge` should have a snake case name [INFO] [stdout] --> src/sgalic/config.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | pub M_bulge: f64, [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `m_bulge` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `N_bulge` should have a snake case name [INFO] [stdout] --> src/sgalic/config.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | pub N_bulge: i32, [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `n_bulge` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `N_rho` should have a snake case name [INFO] [stdout] --> src/sgalic/config.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | pub N_rho: f64, [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `n_rho` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Nz` should have a snake case name [INFO] [stdout] --> src/sgalic/config.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | pub Nz: f64, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `nz` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `N` should have a snake case name [INFO] [stdout] --> src/sgalic/disk.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | let N = config.disk.N_disk as usize; [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Rd` should have a snake case name [INFO] [stdout] --> src/sgalic/disk.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | let Rd = config.disk.Rd; [INFO] [stdout] | ^^ help: convert the identifier to snake case: `rd` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `bulge_cut_M` should have a snake case name [INFO] [stdout] --> src/sgalic/generate.rs:12:24 [INFO] [stdout] | [INFO] [stdout] 12 | let (coords_bulge, bulge_cut_M) = set_bulge_positions(&config); [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `bulge_cut_m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `halo_cut_M` should have a snake case name [INFO] [stdout] --> src/sgalic/generate.rs:13:23 [INFO] [stdout] | [INFO] [stdout] 13 | let (coords_halo, halo_cut_M) = set_halo_positions(&config); [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `halo_cut_m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `M_halo` should have a snake case name [INFO] [stdout] --> src/sgalic/halo.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | let M_halo = config.halo.M_halo; [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `m_halo` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `N_halo` should have a snake case name [INFO] [stdout] --> src/sgalic/halo.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | let N_halo = config.halo.N_halo as usize; [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `n_halo` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `halo_cut_M` should have a snake case name [INFO] [stdout] --> src/sgalic/halo.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | let halo_cut_M = dehnen_cmf(halo_cut_r, M_halo, a_halo, gamma_halo); [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `halo_cut_m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Mc` should have a snake case name [INFO] [stdout] --> src/sgalic/halo.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | let Mc = gen_random_array(N_halo) [INFO] [stdout] | ^^ help: convert the identifier to snake case: `mc` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `Helpers` should have a snake case name [INFO] [stdout] --> src/simulation.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | mod Helpers { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `helpers` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `M` should have a snake case name [INFO] [stdout] --> src/simulation.rs:59:34 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn new(n: usize, a: f64, M: f64) -> CosmoSim { [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 2.03s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: wasm-bindgen v0.2.87 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "f96efd3be2946170c843fa9723ddfa87837e9c2119853476b55eb9fb3935fb4e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f96efd3be2946170c843fa9723ddfa87837e9c2119853476b55eb9fb3935fb4e", kill_on_drop: false }` [INFO] [stdout] f96efd3be2946170c843fa9723ddfa87837e9c2119853476b55eb9fb3935fb4e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "RUSTDOCFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3959728d45483eb673ba100a951a6b9f5012970368db2a9e08e0ac9b67c8a5ad" "/opt/rustwide/cargo-home/bin/cargo" "+1.85.0" "test" "--frozen", kill_on_drop: false }` [INFO] [stdout] ff80acce55f523fb01148f551c0c1e0e5fb561571f0dc28a10fef78a7e654ed8 [INFO] running `Command { std: "docker" "start" "-a" "ff80acce55f523fb01148f551c0c1e0e5fb561571f0dc28a10fef78a7e654ed8", kill_on_drop: false }` [INFO] [stderr] warning: unused imports: `Arc` and `Mutex` [INFO] [stderr] --> src/ic.rs:1:17 [INFO] [stderr] | [INFO] [stderr] 1 | use std::sync::{Arc, Mutex}; [INFO] [stderr] | ^^^ ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `crate::sgalic::halo::*` [INFO] [stderr] --> src/ic.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | use crate::sgalic::halo::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `config::AU` [INFO] [stderr] --> src/ic.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | use crate::{config::AU, ic::plummer}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `config::G_CONSTANT` [INFO] [stderr] --> src/octree.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | config::G_CONSTANT, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/sgalic/cmf.rs:32:12 [INFO] [stderr] | [INFO] [stderr] 32 | if (fa != fc && fb != fc) { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 32 - if (fa != fc && fb != fc) { [INFO] [stderr] 32 + if fa != fc && fb != fc { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/sgalic/cmf.rs:57:12 [INFO] [stderr] | [INFO] [stderr] 57 | if (fa * fs < 0.) { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 57 - if (fa * fs < 0.) { [INFO] [stderr] 57 + if fa * fs < 0. { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/sgalic/cmf.rs:65:12 [INFO] [stderr] | [INFO] [stderr] 65 | if (fa.abs() < fb.abs()) { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 65 - if (fa.abs() < fb.abs()) { [INFO] [stderr] 65 + if fa.abs() < fb.abs() { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs` [INFO] [stderr] --> src/sgalic/config.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::fs; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `config::AU` and `fmm::Particle` [INFO] [stderr] --> src/utils.rs:5:13 [INFO] [stderr] | [INFO] [stderr] 5 | use crate::{config::AU, fmm::Particle}; [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `fs` is never read [INFO] [stderr] --> src/sgalic/cmf.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | let mut fs = 0.; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: maybe it is overwritten before being read? [INFO] [stderr] = note: `#[warn(unused_assignments)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/simulation.rs:90:24 [INFO] [stderr] | [INFO] [stderr] 90 | for (pos, vel, mut group) in izip!(positions, velocities, particle_groups) { [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable `M` should have a snake case name [INFO] [stderr] --> src/ic.rs:15:42 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn plummer(n: usize, a: Option, M: Option) -> Vec { [INFO] [stderr] | ^ help: convert the identifier to snake case: `m` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable `M_bulge` should have a snake case name [INFO] [stderr] --> src/sgalic/bulge.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | let M_bulge = config.bulge.M_bulge; [INFO] [stderr] | ^^^^^^^ help: convert the identifier to snake case: `m_bulge` [INFO] [stderr] [INFO] [stderr] warning: variable `N_bulge` should have a snake case name [INFO] [stderr] --> src/sgalic/bulge.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | let N_bulge = config.bulge.N_bulge as usize; [INFO] [stderr] | ^^^^^^^ help: convert the identifier to snake case: `n_bulge` [INFO] [stderr] [INFO] [stderr] warning: variable `bulge_cut_M` should have a snake case name [INFO] [stderr] --> src/sgalic/bulge.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let bulge_cut_M = dehnen_cmf(bulge_cut_r, M_bulge, a_bulge, gamma_bulge); [INFO] [stderr] | ^^^^^^^^^^^ help: convert the identifier to snake case: `bulge_cut_m` [INFO] [stderr] [INFO] [stderr] warning: variable `Mc` should have a snake case name [INFO] [stderr] --> src/sgalic/bulge.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | let Mc = gen_random_array(N_bulge) [INFO] [stderr] | ^^ help: convert the identifier to snake case: `mc` [INFO] [stderr] [INFO] [stderr] warning: variable `MAX_ITER` should have a snake case name [INFO] [stderr] --> src/sgalic/cmf.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | let MAX_ITER = 10000; [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `max_iter` [INFO] [stderr] [INFO] [stderr] warning: variable `M` should have a snake case name [INFO] [stderr] --> src/sgalic/cmf.rs:75:27 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn dehnen_cmf(r: f64, M: f64, a: f64, gamma: i32) -> f64 { [INFO] [stderr] | ^ help: convert the identifier to snake case: `m` [INFO] [stderr] [INFO] [stderr] warning: variable `Mc` should have a snake case name [INFO] [stderr] --> src/sgalic/cmf.rs:80:23 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn dehnen_cmf_inv(Mc: Vec, M: f64, a: f64, gamma: i32) -> Vec { [INFO] [stderr] | ^^ help: convert the identifier to snake case: `mc` [INFO] [stderr] [INFO] [stderr] warning: variable `M` should have a snake case name [INFO] [stderr] --> src/sgalic/cmf.rs:80:37 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn dehnen_cmf_inv(Mc: Vec, M: f64, a: f64, gamma: i32) -> Vec { [INFO] [stderr] | ^ help: convert the identifier to snake case: `m` [INFO] [stderr] [INFO] [stderr] warning: variable `Rd` should have a snake case name [INFO] [stderr] --> src/sgalic/cmf.rs:102:33 [INFO] [stderr] | [INFO] [stderr] 102 | pub fn disk_radial_cmf(r: &f64, Rd: &f64) -> f64 { [INFO] [stderr] | ^^ help: convert the identifier to snake case: `rd` [INFO] [stderr] [INFO] [stderr] warning: variable `Rd` should have a snake case name [INFO] [stderr] --> src/sgalic/cmf.rs:106:40 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn disk_radial_cmf_inv(frac: &f64, Rd: &f64) -> f64 { [INFO] [stderr] | ^^ help: convert the identifier to snake case: `rd` [INFO] [stderr] [INFO] [stderr] warning: structure field `M_halo` should have a snake case name [INFO] [stderr] --> src/sgalic/config.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | pub M_halo: f64, [INFO] [stderr] | ^^^^^^ help: convert the identifier to snake case: `m_halo` [INFO] [stderr] [INFO] [stderr] warning: structure field `N_halo` should have a snake case name [INFO] [stderr] --> src/sgalic/config.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | pub N_halo: i32, [INFO] [stderr] | ^^^^^^ help: convert the identifier to snake case: `n_halo` [INFO] [stderr] [INFO] [stderr] warning: structure field `M_disk` should have a snake case name [INFO] [stderr] --> src/sgalic/config.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | pub M_disk: f64, [INFO] [stderr] | ^^^^^^ help: convert the identifier to snake case: `m_disk` [INFO] [stderr] [INFO] [stderr] warning: structure field `N_disk` should have a snake case name [INFO] [stderr] --> src/sgalic/config.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | pub N_disk: i32, [INFO] [stderr] | ^^^^^^ help: convert the identifier to snake case: `n_disk` [INFO] [stderr] [INFO] [stderr] warning: structure field `Rd` should have a snake case name [INFO] [stderr] --> src/sgalic/config.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | pub Rd: f64, [INFO] [stderr] | ^^ help: convert the identifier to snake case: `rd` [INFO] [stderr] [INFO] [stderr] warning: structure field `M_bulge` should have a snake case name [INFO] [stderr] --> src/sgalic/config.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | pub M_bulge: f64, [INFO] [stderr] | ^^^^^^^ help: convert the identifier to snake case: `m_bulge` [INFO] [stderr] [INFO] [stderr] warning: structure field `N_bulge` should have a snake case name [INFO] [stderr] --> src/sgalic/config.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | pub N_bulge: i32, [INFO] [stderr] | ^^^^^^^ help: convert the identifier to snake case: `n_bulge` [INFO] [stderr] [INFO] [stderr] warning: structure field `N_rho` should have a snake case name [INFO] [stderr] --> src/sgalic/config.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | pub N_rho: f64, [INFO] [stderr] | ^^^^^ help: convert the identifier to snake case: `n_rho` [INFO] [stderr] [INFO] [stderr] warning: structure field `Nz` should have a snake case name [INFO] [stderr] --> src/sgalic/config.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | pub Nz: f64, [INFO] [stderr] | ^^ help: convert the identifier to snake case: `nz` [INFO] [stderr] [INFO] [stderr] warning: variable `N` should have a snake case name [INFO] [stderr] --> src/sgalic/disk.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | let N = config.disk.N_disk as usize; [INFO] [stderr] | ^ help: convert the identifier to snake case: `n` [INFO] [stderr] [INFO] [stderr] warning: variable `Rd` should have a snake case name [INFO] [stderr] --> src/sgalic/disk.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | let Rd = config.disk.Rd; [INFO] [stderr] | ^^ help: convert the identifier to snake case: `rd` [INFO] [stderr] [INFO] [stderr] warning: variable `bulge_cut_M` should have a snake case name [INFO] [stderr] --> src/sgalic/generate.rs:12:24 [INFO] [stderr] | [INFO] [stderr] 12 | let (coords_bulge, bulge_cut_M) = set_bulge_positions(&config); [INFO] [stderr] | ^^^^^^^^^^^ help: convert the identifier to snake case: `bulge_cut_m` [INFO] [stderr] [INFO] [stderr] warning: variable `halo_cut_M` should have a snake case name [INFO] [stderr] --> src/sgalic/generate.rs:13:23 [INFO] [stderr] | [INFO] [stderr] 13 | let (coords_halo, halo_cut_M) = set_halo_positions(&config); [INFO] [stderr] | ^^^^^^^^^^ help: convert the identifier to snake case: `halo_cut_m` [INFO] [stderr] [INFO] [stderr] warning: variable `M_halo` should have a snake case name [INFO] [stderr] --> src/sgalic/halo.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | let M_halo = config.halo.M_halo; [INFO] [stderr] | ^^^^^^ help: convert the identifier to snake case: `m_halo` [INFO] [stderr] [INFO] [stderr] warning: variable `N_halo` should have a snake case name [INFO] [stderr] --> src/sgalic/halo.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | let N_halo = config.halo.N_halo as usize; [INFO] [stderr] | ^^^^^^ help: convert the identifier to snake case: `n_halo` [INFO] [stderr] [INFO] [stderr] warning: variable `halo_cut_M` should have a snake case name [INFO] [stderr] --> src/sgalic/halo.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let halo_cut_M = dehnen_cmf(halo_cut_r, M_halo, a_halo, gamma_halo); [INFO] [stderr] | ^^^^^^^^^^ help: convert the identifier to snake case: `halo_cut_m` [INFO] [stderr] [INFO] [stderr] warning: variable `Mc` should have a snake case name [INFO] [stderr] --> src/sgalic/halo.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | let Mc = gen_random_array(N_halo) [INFO] [stderr] | ^^ help: convert the identifier to snake case: `mc` [INFO] [stderr] [INFO] [stderr] warning: module `Helpers` should have a snake case name [INFO] [stderr] --> src/simulation.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | mod Helpers { [INFO] [stderr] | ^^^^^^^ help: convert the identifier to snake case: `helpers` [INFO] [stderr] [INFO] [stderr] warning: variable `M` should have a snake case name [INFO] [stderr] --> src/simulation.rs:59:34 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn new(n: usize, a: f64, M: f64) -> CosmoSim { [INFO] [stderr] | ^ help: convert the identifier to snake case: `m` [INFO] [stderr] [INFO] [stderr] warning: `rust-ffm` (lib test) generated 41 warnings (run `cargo fix --lib -p rust-ffm --tests` to apply 10 suggestions) [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 0.14s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: wasm-bindgen v0.2.87 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] [stderr] Running unittests src/lib.rs (/opt/rustwide/target/debug/deps/rust_ffm-b20cbc2bdf47e749) [INFO] [stdout] [INFO] [stdout] running 7 tests [INFO] [stdout] test fmm::tests::should_be_in_bounds ... ok [INFO] [stdout] test ic::tests::test_plummer ... ok [INFO] [stdout] test ic::tests::test_random_number_generator ... ok [INFO] [stdout] test sgalic::cmf::tests::test_cubic ... ok [INFO] [stdout] test sgalic::cmf::tests::test_disk_radial_cmv_inf ... ok [INFO] [stdout] test sgalic::generate::tests::test ... ok [INFO] [stdout] test ic::tests::test_spiral_galaxy ... ok [INFO] [stdout] [INFO] [stdout] test result: ok. 7 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.50s [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "ff80acce55f523fb01148f551c0c1e0e5fb561571f0dc28a10fef78a7e654ed8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ff80acce55f523fb01148f551c0c1e0e5fb561571f0dc28a10fef78a7e654ed8", kill_on_drop: false }` [INFO] [stdout] ff80acce55f523fb01148f551c0c1e0e5fb561571f0dc28a10fef78a7e654ed8