[INFO] cloning repository https://github.com/s5003597/rDNS [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/s5003597/rDNS" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fs5003597%2FrDNS", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fs5003597%2FrDNS'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 651ca6e5bb8a4640539d894c7f1a7ee064939cd2 [INFO] testing s5003597/rDNS against 1.84.0 for beta-1.85-1 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fs5003597%2FrDNS" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/s5003597/rDNS on toolchain 1.84.0 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1.84.0" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/s5003597/rDNS [INFO] finished tweaking git repo https://github.com/s5003597/rDNS [INFO] tweaked toml for git repo https://github.com/s5003597/rDNS written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/s5003597/rDNS already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1.84.0" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:86ea7c7af713d31e8cfdb68a6d0db50b5cf7cbeecde3d112f9f257f747318d36" "/opt/rustwide/cargo-home/bin/cargo" "+1.84.0" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b13042e75d8553bc339c0b019e99af998d37f02c2fbfc3c6c752312ce55fdd8a [INFO] running `Command { std: "docker" "start" "-a" "b13042e75d8553bc339c0b019e99af998d37f02c2fbfc3c6c752312ce55fdd8a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b13042e75d8553bc339c0b019e99af998d37f02c2fbfc3c6c752312ce55fdd8a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b13042e75d8553bc339c0b019e99af998d37f02c2fbfc3c6c752312ce55fdd8a", kill_on_drop: false }` [INFO] [stdout] b13042e75d8553bc339c0b019e99af998d37f02c2fbfc3c6c752312ce55fdd8a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "RUSTDOCFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:86ea7c7af713d31e8cfdb68a6d0db50b5cf7cbeecde3d112f9f257f747318d36" "/opt/rustwide/cargo-home/bin/cargo" "+1.84.0" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b2090b0c9da404862436a5db2a1145058f51cd36657316fd9362fdc04f6db398 [INFO] running `Command { std: "docker" "start" "-a" "b2090b0c9da404862436a5db2a1145058f51cd36657316fd9362fdc04f6db398", kill_on_drop: false }` [INFO] [stderr] Compiling rand_core v0.4.0 [INFO] [stderr] Compiling autocfg v0.1.2 [INFO] [stderr] Compiling libc v0.2.51 [INFO] [stderr] Compiling rand_core v0.3.1 [INFO] [stderr] Compiling rand_jitter v0.1.3 [INFO] [stderr] Compiling rand_hc v0.1.0 [INFO] [stderr] Compiling rand_xorshift v0.1.1 [INFO] [stderr] Compiling rand_isaac v0.1.1 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling rand_os v0.1.3 [INFO] [stderr] Compiling rdns v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:36:38 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn read(&mut self) -> Result<(u8), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 36 - pub fn read(&mut self) -> Result<(u8), (Error)> { [INFO] [stdout] 36 + pub fn read(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:36:44 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn read(&mut self) -> Result<(u8), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 36 - pub fn read(&mut self) -> Result<(u8), (Error)> { [INFO] [stdout] 36 + pub fn read(&mut self) -> Result<(u8), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:48:49 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn get(&mut self, pos: usize) -> Result<(u8), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 48 - pub fn get(&mut self, pos: usize) -> Result<(u8), (Error)> { [INFO] [stdout] 48 + pub fn get(&mut self, pos: usize) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:48:55 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn get(&mut self, pos: usize) -> Result<(u8), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 48 - pub fn get(&mut self, pos: usize) -> Result<(u8), (Error)> { [INFO] [stdout] 48 + pub fn get(&mut self, pos: usize) -> Result<(u8), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:55:69 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn get_range(&mut self, start: usize, len: usize) -> Result<(&[u8]), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 55 - pub fn get_range(&mut self, start: usize, len: usize) -> Result<(&[u8]), (Error)> { [INFO] [stdout] 55 + pub fn get_range(&mut self, start: usize, len: usize) -> Result<&[u8], (Error)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:55:78 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn get_range(&mut self, start: usize, len: usize) -> Result<(&[u8]), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 55 - pub fn get_range(&mut self, start: usize, len: usize) -> Result<(&[u8]), (Error)> { [INFO] [stdout] 55 + pub fn get_range(&mut self, start: usize, len: usize) -> Result<(&[u8]), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:63:42 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn read_u16(&mut self) -> Result<(u16), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 63 - pub fn read_u16(&mut self) -> Result<(u16), (Error)> { [INFO] [stdout] 63 + pub fn read_u16(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:63:49 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn read_u16(&mut self) -> Result<(u16), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 63 - pub fn read_u16(&mut self) -> Result<(u16), (Error)> { [INFO] [stdout] 63 + pub fn read_u16(&mut self) -> Result<(u16), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:67:42 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn read_u32(&mut self) -> Result<(u32), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 67 - pub fn read_u32(&mut self) -> Result<(u32), (Error)> { [INFO] [stdout] 67 + pub fn read_u32(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:67:49 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn read_u32(&mut self) -> Result<(u32), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 67 - pub fn read_u32(&mut self) -> Result<(u32), (Error)> { [INFO] [stdout] 67 + pub fn read_u32(&mut self) -> Result<(u32), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:76:69 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn read_qname(&mut self, outstr: &mut String) -> Result<(), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 76 - pub fn read_qname(&mut self, outstr: &mut String) -> Result<(), (Error)> { [INFO] [stdout] 76 + pub fn read_qname(&mut self, outstr: &mut String) -> Result<(), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:129:52 [INFO] [stdout] | [INFO] [stdout] 129 | pub fn write(&mut self, val: u8) -> Result<(), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 129 - pub fn write(&mut self, val: u8) -> Result<(), (Error)> { [INFO] [stdout] 129 + pub fn write(&mut self, val: u8) -> Result<(), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:138:55 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn write_u8(&mut self, val: u8) -> Result<(), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 138 - pub fn write_u8(&mut self, val: u8) -> Result<(), (Error)> { [INFO] [stdout] 138 + pub fn write_u8(&mut self, val: u8) -> Result<(), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:143:57 [INFO] [stdout] | [INFO] [stdout] 143 | pub fn write_u16(&mut self, val: u16) -> Result<(), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 143 - pub fn write_u16(&mut self, val: u16) -> Result<(), (Error)> { [INFO] [stdout] 143 + pub fn write_u16(&mut self, val: u16) -> Result<(), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:150:57 [INFO] [stdout] | [INFO] [stdout] 150 | pub fn write_u32(&mut self, val: u32) -> Result<(), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 150 - pub fn write_u32(&mut self, val: u32) -> Result<(), (Error)> { [INFO] [stdout] 150 + pub fn write_u32(&mut self, val: u32) -> Result<(), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:159:62 [INFO] [stdout] | [INFO] [stdout] 159 | pub fn write_qname(&mut self, qname: &str) -> Result<(), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 159 - pub fn write_qname(&mut self, qname: &str) -> Result<(), (Error)> { [INFO] [stdout] 159 + pub fn write_qname(&mut self, qname: &str) -> Result<(), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/header.rs:49:73 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn read(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 49 - pub fn read(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), (Error)> { [INFO] [stdout] 49 + pub fn read(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/header.rs:76:70 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn write(&self, buffer: &mut BytePacketBuffer) -> Result<(), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 76 - pub fn write(&self, buffer: &mut BytePacketBuffer) -> Result<(), (Error)> { [INFO] [stdout] 76 + pub fn write(&self, buffer: &mut BytePacketBuffer) -> Result<(), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/dns_packet.rs:35:65 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn from_buffer(buffer: &mut BytePacketBuffer) -> Result<(DnsPacket), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 35 - pub fn from_buffer(buffer: &mut BytePacketBuffer) -> Result<(DnsPacket), (Error)> { [INFO] [stdout] 35 + pub fn from_buffer(buffer: &mut BytePacketBuffer) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/dns_packet.rs:35:78 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn from_buffer(buffer: &mut BytePacketBuffer) -> Result<(DnsPacket), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 35 - pub fn from_buffer(buffer: &mut BytePacketBuffer) -> Result<(DnsPacket), (Error)> { [INFO] [stdout] 35 + pub fn from_buffer(buffer: &mut BytePacketBuffer) -> Result<(DnsPacket), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/dns_packet.rs:63:74 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn write(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 63 - pub fn write(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), (Error)> { [INFO] [stdout] 63 + pub fn write(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/questions.rs:19:73 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn read(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 19 - pub fn read(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), (Error)> { [INFO] [stdout] 19 + pub fn read(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/questions.rs:27:74 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn write(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 27 - pub fn write(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), (Error)> { [INFO] [stdout] 27 + pub fn write(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/record.rs:49:58 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn read(buffer: &mut BytePacketBuffer) -> Result<(DnsRecord), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 49 - pub fn read(buffer: &mut BytePacketBuffer) -> Result<(DnsRecord), (Error)> { [INFO] [stdout] 49 + pub fn read(buffer: &mut BytePacketBuffer) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/record.rs:49:71 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn read(buffer: &mut BytePacketBuffer) -> Result<(DnsRecord), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 49 - pub fn read(buffer: &mut BytePacketBuffer) -> Result<(DnsRecord), (Error)> { [INFO] [stdout] 49 + pub fn read(buffer: &mut BytePacketBuffer) -> Result<(DnsRecord), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/record.rs:141:66 [INFO] [stdout] | [INFO] [stdout] 141 | pub fn write(&self, buffer: &mut BytePacketBuffer) -> Result<(usize), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 141 - pub fn write(&self, buffer: &mut BytePacketBuffer) -> Result<(usize), (Error)> { [INFO] [stdout] 141 + pub fn write(&self, buffer: &mut BytePacketBuffer) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/record.rs:141:75 [INFO] [stdout] | [INFO] [stdout] 141 | pub fn write(&self, buffer: &mut BytePacketBuffer) -> Result<(usize), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 141 - pub fn write(&self, buffer: &mut BytePacketBuffer) -> Result<(usize), (Error)> { [INFO] [stdout] 141 + pub fn write(&self, buffer: &mut BytePacketBuffer) -> Result<(usize), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/main.rs:25:73 [INFO] [stdout] | [INFO] [stdout] 25 | fn lookup(qname: &str, qtype: QueryType, server: (&str, u16)) -> Result<(DnsPacket), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 25 - fn lookup(qname: &str, qtype: QueryType, server: (&str, u16)) -> Result<(DnsPacket), (Error)> { [INFO] [stdout] 25 + fn lookup(qname: &str, qtype: QueryType, server: (&str, u16)) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/main.rs:25:86 [INFO] [stdout] | [INFO] [stdout] 25 | fn lookup(qname: &str, qtype: QueryType, server: (&str, u16)) -> Result<(DnsPacket), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 25 - fn lookup(qname: &str, qtype: QueryType, server: (&str, u16)) -> Result<(DnsPacket), (Error)> { [INFO] [stdout] 25 + fn lookup(qname: &str, qtype: QueryType, server: (&str, u16)) -> Result<(DnsPacket), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/main.rs:105:62 [INFO] [stdout] | [INFO] [stdout] 105 | fn recursive_lookup(qname: &str, qtype: QueryType) -> Result<(DnsPacket), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 105 - fn recursive_lookup(qname: &str, qtype: QueryType) -> Result<(DnsPacket), (Error)> { [INFO] [stdout] 105 + fn recursive_lookup(qname: &str, qtype: QueryType) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/main.rs:105:75 [INFO] [stdout] | [INFO] [stdout] 105 | fn recursive_lookup(qname: &str, qtype: QueryType) -> Result<(DnsPacket), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 105 - fn recursive_lookup(qname: &str, qtype: QueryType) -> Result<(DnsPacket), (Error)> { [INFO] [stdout] 105 + fn recursive_lookup(qname: &str, qtype: QueryType) -> Result<(DnsPacket), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_2` is never used [INFO] [stdout] --> src/main.rs:71:4 [INFO] [stdout] | [INFO] [stdout] 71 | fn test_2() { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.02s [INFO] running `Command { std: "docker" "inspect" "b2090b0c9da404862436a5db2a1145058f51cd36657316fd9362fdc04f6db398", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b2090b0c9da404862436a5db2a1145058f51cd36657316fd9362fdc04f6db398", kill_on_drop: false }` [INFO] [stdout] b2090b0c9da404862436a5db2a1145058f51cd36657316fd9362fdc04f6db398 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "RUSTDOCFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:86ea7c7af713d31e8cfdb68a6d0db50b5cf7cbeecde3d112f9f257f747318d36" "/opt/rustwide/cargo-home/bin/cargo" "+1.84.0" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 59a7d09f0a5c90f8f9074d2c2e72876c66b1cd2cf1cc8e0e37d4661e5838f76f [INFO] running `Command { std: "docker" "start" "-a" "59a7d09f0a5c90f8f9074d2c2e72876c66b1cd2cf1cc8e0e37d4661e5838f76f", kill_on_drop: false }` [INFO] [stderr] Compiling rdns v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:36:38 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn read(&mut self) -> Result<(u8), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 36 - pub fn read(&mut self) -> Result<(u8), (Error)> { [INFO] [stdout] 36 + pub fn read(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:36:44 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn read(&mut self) -> Result<(u8), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 36 - pub fn read(&mut self) -> Result<(u8), (Error)> { [INFO] [stdout] 36 + pub fn read(&mut self) -> Result<(u8), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:48:49 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn get(&mut self, pos: usize) -> Result<(u8), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 48 - pub fn get(&mut self, pos: usize) -> Result<(u8), (Error)> { [INFO] [stdout] 48 + pub fn get(&mut self, pos: usize) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:48:55 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn get(&mut self, pos: usize) -> Result<(u8), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 48 - pub fn get(&mut self, pos: usize) -> Result<(u8), (Error)> { [INFO] [stdout] 48 + pub fn get(&mut self, pos: usize) -> Result<(u8), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:55:69 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn get_range(&mut self, start: usize, len: usize) -> Result<(&[u8]), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 55 - pub fn get_range(&mut self, start: usize, len: usize) -> Result<(&[u8]), (Error)> { [INFO] [stdout] 55 + pub fn get_range(&mut self, start: usize, len: usize) -> Result<&[u8], (Error)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:55:78 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn get_range(&mut self, start: usize, len: usize) -> Result<(&[u8]), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 55 - pub fn get_range(&mut self, start: usize, len: usize) -> Result<(&[u8]), (Error)> { [INFO] [stdout] 55 + pub fn get_range(&mut self, start: usize, len: usize) -> Result<(&[u8]), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:63:42 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn read_u16(&mut self) -> Result<(u16), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 63 - pub fn read_u16(&mut self) -> Result<(u16), (Error)> { [INFO] [stdout] 63 + pub fn read_u16(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:63:49 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn read_u16(&mut self) -> Result<(u16), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 63 - pub fn read_u16(&mut self) -> Result<(u16), (Error)> { [INFO] [stdout] 63 + pub fn read_u16(&mut self) -> Result<(u16), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:67:42 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn read_u32(&mut self) -> Result<(u32), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 67 - pub fn read_u32(&mut self) -> Result<(u32), (Error)> { [INFO] [stdout] 67 + pub fn read_u32(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:67:49 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn read_u32(&mut self) -> Result<(u32), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 67 - pub fn read_u32(&mut self) -> Result<(u32), (Error)> { [INFO] [stdout] 67 + pub fn read_u32(&mut self) -> Result<(u32), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:76:69 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn read_qname(&mut self, outstr: &mut String) -> Result<(), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 76 - pub fn read_qname(&mut self, outstr: &mut String) -> Result<(), (Error)> { [INFO] [stdout] 76 + pub fn read_qname(&mut self, outstr: &mut String) -> Result<(), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:129:52 [INFO] [stdout] | [INFO] [stdout] 129 | pub fn write(&mut self, val: u8) -> Result<(), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 129 - pub fn write(&mut self, val: u8) -> Result<(), (Error)> { [INFO] [stdout] 129 + pub fn write(&mut self, val: u8) -> Result<(), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:138:55 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn write_u8(&mut self, val: u8) -> Result<(), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 138 - pub fn write_u8(&mut self, val: u8) -> Result<(), (Error)> { [INFO] [stdout] 138 + pub fn write_u8(&mut self, val: u8) -> Result<(), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:143:57 [INFO] [stdout] | [INFO] [stdout] 143 | pub fn write_u16(&mut self, val: u16) -> Result<(), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 143 - pub fn write_u16(&mut self, val: u16) -> Result<(), (Error)> { [INFO] [stdout] 143 + pub fn write_u16(&mut self, val: u16) -> Result<(), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:150:57 [INFO] [stdout] | [INFO] [stdout] 150 | pub fn write_u32(&mut self, val: u32) -> Result<(), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 150 - pub fn write_u32(&mut self, val: u32) -> Result<(), (Error)> { [INFO] [stdout] 150 + pub fn write_u32(&mut self, val: u32) -> Result<(), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bytepacketbuffer.rs:159:62 [INFO] [stdout] | [INFO] [stdout] 159 | pub fn write_qname(&mut self, qname: &str) -> Result<(), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 159 - pub fn write_qname(&mut self, qname: &str) -> Result<(), (Error)> { [INFO] [stdout] 159 + pub fn write_qname(&mut self, qname: &str) -> Result<(), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/header.rs:49:73 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn read(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 49 - pub fn read(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), (Error)> { [INFO] [stdout] 49 + pub fn read(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/header.rs:76:70 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn write(&self, buffer: &mut BytePacketBuffer) -> Result<(), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 76 - pub fn write(&self, buffer: &mut BytePacketBuffer) -> Result<(), (Error)> { [INFO] [stdout] 76 + pub fn write(&self, buffer: &mut BytePacketBuffer) -> Result<(), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/dns_packet.rs:35:65 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn from_buffer(buffer: &mut BytePacketBuffer) -> Result<(DnsPacket), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 35 - pub fn from_buffer(buffer: &mut BytePacketBuffer) -> Result<(DnsPacket), (Error)> { [INFO] [stdout] 35 + pub fn from_buffer(buffer: &mut BytePacketBuffer) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/dns_packet.rs:35:78 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn from_buffer(buffer: &mut BytePacketBuffer) -> Result<(DnsPacket), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 35 - pub fn from_buffer(buffer: &mut BytePacketBuffer) -> Result<(DnsPacket), (Error)> { [INFO] [stdout] 35 + pub fn from_buffer(buffer: &mut BytePacketBuffer) -> Result<(DnsPacket), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/dns_packet.rs:63:74 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn write(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 63 - pub fn write(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), (Error)> { [INFO] [stdout] 63 + pub fn write(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/questions.rs:19:73 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn read(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 19 - pub fn read(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), (Error)> { [INFO] [stdout] 19 + pub fn read(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/questions.rs:27:74 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn write(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 27 - pub fn write(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), (Error)> { [INFO] [stdout] 27 + pub fn write(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/record.rs:49:58 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn read(buffer: &mut BytePacketBuffer) -> Result<(DnsRecord), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 49 - pub fn read(buffer: &mut BytePacketBuffer) -> Result<(DnsRecord), (Error)> { [INFO] [stdout] 49 + pub fn read(buffer: &mut BytePacketBuffer) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/record.rs:49:71 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn read(buffer: &mut BytePacketBuffer) -> Result<(DnsRecord), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 49 - pub fn read(buffer: &mut BytePacketBuffer) -> Result<(DnsRecord), (Error)> { [INFO] [stdout] 49 + pub fn read(buffer: &mut BytePacketBuffer) -> Result<(DnsRecord), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/record.rs:141:66 [INFO] [stdout] | [INFO] [stdout] 141 | pub fn write(&self, buffer: &mut BytePacketBuffer) -> Result<(usize), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 141 - pub fn write(&self, buffer: &mut BytePacketBuffer) -> Result<(usize), (Error)> { [INFO] [stdout] 141 + pub fn write(&self, buffer: &mut BytePacketBuffer) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/record.rs:141:75 [INFO] [stdout] | [INFO] [stdout] 141 | pub fn write(&self, buffer: &mut BytePacketBuffer) -> Result<(usize), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 141 - pub fn write(&self, buffer: &mut BytePacketBuffer) -> Result<(usize), (Error)> { [INFO] [stdout] 141 + pub fn write(&self, buffer: &mut BytePacketBuffer) -> Result<(usize), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/main.rs:25:73 [INFO] [stdout] | [INFO] [stdout] 25 | fn lookup(qname: &str, qtype: QueryType, server: (&str, u16)) -> Result<(DnsPacket), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 25 - fn lookup(qname: &str, qtype: QueryType, server: (&str, u16)) -> Result<(DnsPacket), (Error)> { [INFO] [stdout] 25 + fn lookup(qname: &str, qtype: QueryType, server: (&str, u16)) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/main.rs:25:86 [INFO] [stdout] | [INFO] [stdout] 25 | fn lookup(qname: &str, qtype: QueryType, server: (&str, u16)) -> Result<(DnsPacket), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 25 - fn lookup(qname: &str, qtype: QueryType, server: (&str, u16)) -> Result<(DnsPacket), (Error)> { [INFO] [stdout] 25 + fn lookup(qname: &str, qtype: QueryType, server: (&str, u16)) -> Result<(DnsPacket), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/main.rs:105:62 [INFO] [stdout] | [INFO] [stdout] 105 | fn recursive_lookup(qname: &str, qtype: QueryType) -> Result<(DnsPacket), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 105 - fn recursive_lookup(qname: &str, qtype: QueryType) -> Result<(DnsPacket), (Error)> { [INFO] [stdout] 105 + fn recursive_lookup(qname: &str, qtype: QueryType) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/main.rs:105:75 [INFO] [stdout] | [INFO] [stdout] 105 | fn recursive_lookup(qname: &str, qtype: QueryType) -> Result<(DnsPacket), (Error)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 105 - fn recursive_lookup(qname: &str, qtype: QueryType) -> Result<(DnsPacket), (Error)> { [INFO] [stdout] 105 + fn recursive_lookup(qname: &str, qtype: QueryType) -> Result<(DnsPacket), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_2` is never used [INFO] [stdout] --> src/main.rs:71:4 [INFO] [stdout] | [INFO] [stdout] 71 | fn test_2() { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 0.56s [INFO] running `Command { std: "docker" "inspect" "59a7d09f0a5c90f8f9074d2c2e72876c66b1cd2cf1cc8e0e37d4661e5838f76f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "59a7d09f0a5c90f8f9074d2c2e72876c66b1cd2cf1cc8e0e37d4661e5838f76f", kill_on_drop: false }` [INFO] [stdout] 59a7d09f0a5c90f8f9074d2c2e72876c66b1cd2cf1cc8e0e37d4661e5838f76f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "RUSTDOCFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:86ea7c7af713d31e8cfdb68a6d0db50b5cf7cbeecde3d112f9f257f747318d36" "/opt/rustwide/cargo-home/bin/cargo" "+1.84.0" "test" "--frozen", kill_on_drop: false }` [INFO] [stdout] efd7cd8e99f8c28ec46fbcce54bbb3b8c0cab1a856df6148b77f5dcf0d23741e [INFO] running `Command { std: "docker" "start" "-a" "efd7cd8e99f8c28ec46fbcce54bbb3b8c0cab1a856df6148b77f5dcf0d23741e", kill_on_drop: false }` [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/bytepacketbuffer.rs:36:38 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn read(&mut self) -> Result<(u8), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 36 - pub fn read(&mut self) -> Result<(u8), (Error)> { [INFO] [stderr] 36 + pub fn read(&mut self) -> Result { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/bytepacketbuffer.rs:36:44 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn read(&mut self) -> Result<(u8), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 36 - pub fn read(&mut self) -> Result<(u8), (Error)> { [INFO] [stderr] 36 + pub fn read(&mut self) -> Result<(u8), Error> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/bytepacketbuffer.rs:48:49 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn get(&mut self, pos: usize) -> Result<(u8), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 48 - pub fn get(&mut self, pos: usize) -> Result<(u8), (Error)> { [INFO] [stderr] 48 + pub fn get(&mut self, pos: usize) -> Result { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/bytepacketbuffer.rs:48:55 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn get(&mut self, pos: usize) -> Result<(u8), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 48 - pub fn get(&mut self, pos: usize) -> Result<(u8), (Error)> { [INFO] [stderr] 48 + pub fn get(&mut self, pos: usize) -> Result<(u8), Error> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/bytepacketbuffer.rs:55:69 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn get_range(&mut self, start: usize, len: usize) -> Result<(&[u8]), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 55 - pub fn get_range(&mut self, start: usize, len: usize) -> Result<(&[u8]), (Error)> { [INFO] [stderr] 55 + pub fn get_range(&mut self, start: usize, len: usize) -> Result<&[u8], (Error)> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/bytepacketbuffer.rs:55:78 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn get_range(&mut self, start: usize, len: usize) -> Result<(&[u8]), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 55 - pub fn get_range(&mut self, start: usize, len: usize) -> Result<(&[u8]), (Error)> { [INFO] [stderr] 55 + pub fn get_range(&mut self, start: usize, len: usize) -> Result<(&[u8]), Error> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/bytepacketbuffer.rs:63:42 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn read_u16(&mut self) -> Result<(u16), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 63 - pub fn read_u16(&mut self) -> Result<(u16), (Error)> { [INFO] [stderr] 63 + pub fn read_u16(&mut self) -> Result { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/bytepacketbuffer.rs:63:49 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn read_u16(&mut self) -> Result<(u16), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 63 - pub fn read_u16(&mut self) -> Result<(u16), (Error)> { [INFO] [stderr] 63 + pub fn read_u16(&mut self) -> Result<(u16), Error> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/bytepacketbuffer.rs:67:42 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn read_u32(&mut self) -> Result<(u32), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 67 - pub fn read_u32(&mut self) -> Result<(u32), (Error)> { [INFO] [stderr] 67 + pub fn read_u32(&mut self) -> Result { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/bytepacketbuffer.rs:67:49 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn read_u32(&mut self) -> Result<(u32), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 67 - pub fn read_u32(&mut self) -> Result<(u32), (Error)> { [INFO] [stderr] 67 + pub fn read_u32(&mut self) -> Result<(u32), Error> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/bytepacketbuffer.rs:76:69 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn read_qname(&mut self, outstr: &mut String) -> Result<(), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 76 - pub fn read_qname(&mut self, outstr: &mut String) -> Result<(), (Error)> { [INFO] [stderr] 76 + pub fn read_qname(&mut self, outstr: &mut String) -> Result<(), Error> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/bytepacketbuffer.rs:129:52 [INFO] [stderr] | [INFO] [stderr] 129 | pub fn write(&mut self, val: u8) -> Result<(), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 129 - pub fn write(&mut self, val: u8) -> Result<(), (Error)> { [INFO] [stderr] 129 + pub fn write(&mut self, val: u8) -> Result<(), Error> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/bytepacketbuffer.rs:138:55 [INFO] [stderr] | [INFO] [stderr] 138 | pub fn write_u8(&mut self, val: u8) -> Result<(), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 138 - pub fn write_u8(&mut self, val: u8) -> Result<(), (Error)> { [INFO] [stderr] 138 + pub fn write_u8(&mut self, val: u8) -> Result<(), Error> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/bytepacketbuffer.rs:143:57 [INFO] [stderr] | [INFO] [stderr] 143 | pub fn write_u16(&mut self, val: u16) -> Result<(), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 143 - pub fn write_u16(&mut self, val: u16) -> Result<(), (Error)> { [INFO] [stderr] 143 + pub fn write_u16(&mut self, val: u16) -> Result<(), Error> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/bytepacketbuffer.rs:150:57 [INFO] [stderr] | [INFO] [stderr] 150 | pub fn write_u32(&mut self, val: u32) -> Result<(), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 150 - pub fn write_u32(&mut self, val: u32) -> Result<(), (Error)> { [INFO] [stderr] 150 + pub fn write_u32(&mut self, val: u32) -> Result<(), Error> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/bytepacketbuffer.rs:159:62 [INFO] [stderr] | [INFO] [stderr] 159 | pub fn write_qname(&mut self, qname: &str) -> Result<(), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 159 - pub fn write_qname(&mut self, qname: &str) -> Result<(), (Error)> { [INFO] [stderr] 159 + pub fn write_qname(&mut self, qname: &str) -> Result<(), Error> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/header.rs:49:73 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn read(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 49 - pub fn read(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), (Error)> { [INFO] [stderr] 49 + pub fn read(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), Error> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/header.rs:76:70 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn write(&self, buffer: &mut BytePacketBuffer) -> Result<(), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 76 - pub fn write(&self, buffer: &mut BytePacketBuffer) -> Result<(), (Error)> { [INFO] [stderr] 76 + pub fn write(&self, buffer: &mut BytePacketBuffer) -> Result<(), Error> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/dns_packet.rs:35:65 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn from_buffer(buffer: &mut BytePacketBuffer) -> Result<(DnsPacket), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 35 - pub fn from_buffer(buffer: &mut BytePacketBuffer) -> Result<(DnsPacket), (Error)> { [INFO] [stderr] 35 + pub fn from_buffer(buffer: &mut BytePacketBuffer) -> Result { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/dns_packet.rs:35:78 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn from_buffer(buffer: &mut BytePacketBuffer) -> Result<(DnsPacket), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 35 - pub fn from_buffer(buffer: &mut BytePacketBuffer) -> Result<(DnsPacket), (Error)> { [INFO] [stderr] 35 + pub fn from_buffer(buffer: &mut BytePacketBuffer) -> Result<(DnsPacket), Error> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/dns_packet.rs:63:74 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn write(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 63 - pub fn write(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), (Error)> { [INFO] [stderr] 63 + pub fn write(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), Error> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/questions.rs:19:73 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn read(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 19 - pub fn read(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), (Error)> { [INFO] [stderr] 19 + pub fn read(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), Error> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/questions.rs:27:74 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn write(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 27 - pub fn write(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), (Error)> { [INFO] [stderr] 27 + pub fn write(&mut self, buffer: &mut BytePacketBuffer) -> Result<(), Error> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/record.rs:49:58 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn read(buffer: &mut BytePacketBuffer) -> Result<(DnsRecord), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 49 - pub fn read(buffer: &mut BytePacketBuffer) -> Result<(DnsRecord), (Error)> { [INFO] [stderr] 49 + pub fn read(buffer: &mut BytePacketBuffer) -> Result { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/record.rs:49:71 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn read(buffer: &mut BytePacketBuffer) -> Result<(DnsRecord), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 49 - pub fn read(buffer: &mut BytePacketBuffer) -> Result<(DnsRecord), (Error)> { [INFO] [stderr] 49 + pub fn read(buffer: &mut BytePacketBuffer) -> Result<(DnsRecord), Error> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/record.rs:141:66 [INFO] [stderr] | [INFO] [stderr] 141 | pub fn write(&self, buffer: &mut BytePacketBuffer) -> Result<(usize), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 141 - pub fn write(&self, buffer: &mut BytePacketBuffer) -> Result<(usize), (Error)> { [INFO] [stderr] 141 + pub fn write(&self, buffer: &mut BytePacketBuffer) -> Result { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/record.rs:141:75 [INFO] [stderr] | [INFO] [stderr] 141 | pub fn write(&self, buffer: &mut BytePacketBuffer) -> Result<(usize), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 141 - pub fn write(&self, buffer: &mut BytePacketBuffer) -> Result<(usize), (Error)> { [INFO] [stderr] 141 + pub fn write(&self, buffer: &mut BytePacketBuffer) -> Result<(usize), Error> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/main.rs:25:73 [INFO] [stderr] | [INFO] [stderr] 25 | fn lookup(qname: &str, qtype: QueryType, server: (&str, u16)) -> Result<(DnsPacket), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 25 - fn lookup(qname: &str, qtype: QueryType, server: (&str, u16)) -> Result<(DnsPacket), (Error)> { [INFO] [stderr] 25 + fn lookup(qname: &str, qtype: QueryType, server: (&str, u16)) -> Result { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/main.rs:25:86 [INFO] [stderr] | [INFO] [stderr] 25 | fn lookup(qname: &str, qtype: QueryType, server: (&str, u16)) -> Result<(DnsPacket), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 25 - fn lookup(qname: &str, qtype: QueryType, server: (&str, u16)) -> Result<(DnsPacket), (Error)> { [INFO] [stderr] 25 + fn lookup(qname: &str, qtype: QueryType, server: (&str, u16)) -> Result<(DnsPacket), Error> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/main.rs:105:62 [INFO] [stderr] | [INFO] [stderr] 105 | fn recursive_lookup(qname: &str, qtype: QueryType) -> Result<(DnsPacket), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 105 - fn recursive_lookup(qname: &str, qtype: QueryType) -> Result<(DnsPacket), (Error)> { [INFO] [stderr] 105 + fn recursive_lookup(qname: &str, qtype: QueryType) -> Result { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/main.rs:105:75 [INFO] [stderr] | [INFO] [stderr] 105 | fn recursive_lookup(qname: &str, qtype: QueryType) -> Result<(DnsPacket), (Error)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 105 - fn recursive_lookup(qname: &str, qtype: QueryType) -> Result<(DnsPacket), (Error)> { [INFO] [stderr] 105 + fn recursive_lookup(qname: &str, qtype: QueryType) -> Result<(DnsPacket), Error> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: function `test_2` is never used [INFO] [stderr] --> src/main.rs:71:4 [INFO] [stderr] | [INFO] [stderr] 71 | fn test_2() { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: `rdns` (bin "rdns" test) generated 32 warnings (run `cargo fix --bin "rdns" --tests` to apply 31 suggestions) [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 0.03s [INFO] [stderr] Running unittests src/main.rs (/opt/rustwide/target/debug/deps/rdns-0300b9c3c76377a4) [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "efd7cd8e99f8c28ec46fbcce54bbb3b8c0cab1a856df6148b77f5dcf0d23741e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "efd7cd8e99f8c28ec46fbcce54bbb3b8c0cab1a856df6148b77f5dcf0d23741e", kill_on_drop: false }` [INFO] [stdout] efd7cd8e99f8c28ec46fbcce54bbb3b8c0cab1a856df6148b77f5dcf0d23741e