[INFO] cloning repository https://github.com/jcaesar/ftp2mfs
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jcaesar/ftp2mfs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjcaesar%2Fftp2mfs", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjcaesar%2Fftp2mfs'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] d7b9c4a3691437902f974f2fb448ecd1dbb06bac
[INFO] testing jcaesar/ftp2mfs against 1.73.0 for beta-1.74-1
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjcaesar%2Fftp2mfs" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'...
[INFO] [stderr] done.
[INFO] validating manifest of git repo https://github.com/jcaesar/ftp2mfs on toolchain 1.73.0
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1.73.0" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] started tweaking git repo https://github.com/jcaesar/ftp2mfs
[INFO] finished tweaking git repo https://github.com/jcaesar/ftp2mfs
[INFO] tweaked toml for git repo https://github.com/jcaesar/ftp2mfs written to /workspace/builds/worker-4-tc1/source/Cargo.toml
[INFO] crate git repo https://github.com/jcaesar/ftp2mfs already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1.73.0" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded custom_debug_derive v0.5.0
[INFO] [stderr]   Downloaded custom_debug v0.5.0
[INFO] [stderr]   Downloaded hexdump v0.1.1
[INFO] [stderr]   Downloaded proxy-protocol v0.3.0
[INFO] [stderr]   Downloaded libsystemd v0.3.1
[INFO] [stderr]   Downloaded protobuf v2.24.1
[INFO] [stderr]   Downloaded ipfs-api v0.11.0
[INFO] [stderr]   Downloaded cht v0.4.1
[INFO] [stderr]   Downloaded atomic-shim v0.1.0
[INFO] [stderr]   Downloaded libunftp v0.17.4
[INFO] [stderr]   Downloaded serde-humantime v0.1.1
[INFO] [stderr]   Downloaded hyper-multipart-rfc7578 v0.5.0
[INFO] [stderr]   Downloaded common-multipart-rfc7578 v0.2.0-rc
[INFO] [stderr]   Downloaded common-multipart-rfc7578 v0.3.0
[INFO] [stderr]   Downloaded unix_mode v0.1.1
[INFO] [stderr]   Downloaded raw-cpuid v9.1.1
[INFO] [stderr]   Downloaded hyper-multipart-rfc7578 v0.4.0-rc
[INFO] [stderr]   Downloaded quanta v0.7.2
[INFO] [stderr]   Downloaded async_ftp v5.0.0
[INFO] [stderr]   Downloaded systemd-journal-logger v0.3.1
[INFO] [stderr]   Downloaded priority-queue v1.1.1
[INFO] [stderr]   Downloaded clap_derive v3.0.0
[INFO] [stderr]   Downloaded moka v0.3.1
[INFO] [stderr]   Downloaded arc-swap v1.3.0
[INFO] [stderr]   Downloaded clap v3.0.0
[INFO] [stderr]   Downloaded ipfs-api v0.8.0-rc.2
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4f8da3c744d2da974e54ce020a79f4ad54313e914ebeaab8fc086f07e8d8b066" "/opt/rustwide/cargo-home/bin/cargo" "+1.73.0" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] d9f998f0e0820a44eff2e1e1df75a5bcf4617added702de6d62fa14eefd6314e
[INFO] running `Command { std: "docker" "start" "-a" "d9f998f0e0820a44eff2e1e1df75a5bcf4617added702de6d62fa14eefd6314e", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "d9f998f0e0820a44eff2e1e1df75a5bcf4617added702de6d62fa14eefd6314e", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "d9f998f0e0820a44eff2e1e1df75a5bcf4617added702de6d62fa14eefd6314e", kill_on_drop: false }`
[INFO] [stdout] d9f998f0e0820a44eff2e1e1df75a5bcf4617added702de6d62fa14eefd6314e
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "RUSTDOCFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4f8da3c744d2da974e54ce020a79f4ad54313e914ebeaab8fc086f07e8d8b066" "/opt/rustwide/cargo-home/bin/cargo" "+1.73.0" "build" "--frozen" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 24dc8550a0bec52af213d424cc53a4473340921dd1e92c989d84bb9727143bbe
[INFO] running `Command { std: "docker" "start" "-a" "24dc8550a0bec52af213d424cc53a4473340921dd1e92c989d84bb9727143bbe", kill_on_drop: false }`
[INFO] [stderr]    Compiling proc-macro2 v1.0.28
[INFO] [stderr]    Compiling unicode-xid v0.2.2
[INFO] [stderr]    Compiling syn v1.0.74
[INFO] [stderr]    Compiling version_check v0.9.3
[INFO] [stderr]    Compiling cfg-if v1.0.0
[INFO] [stderr]    Compiling autocfg v1.0.1
[INFO] [stderr]    Compiling libc v0.2.104
[INFO] [stderr]    Compiling memchr v2.4.0
[INFO] [stderr]    Compiling log v0.4.14
[INFO] [stderr]    Compiling serde_derive v1.0.126
[INFO] [stderr]    Compiling serde v1.0.126
[INFO] [stderr]    Compiling pin-project-lite v0.2.7
[INFO] [stderr]    Compiling ppv-lite86 v0.2.10
[INFO] [stderr]    Compiling cc v1.0.69
[INFO] [stderr]    Compiling futures-core v0.3.16
[INFO] [stderr]    Compiling bytes v1.0.1
[INFO] [stderr]    Compiling typenum v1.13.0
[INFO] [stderr]    Compiling getrandom v0.1.16
[INFO] [stderr]    Compiling proc-macro-hack v0.5.19
[INFO] [stderr]    Compiling futures-sink v0.3.16
[INFO] [stderr]    Compiling siphasher v0.3.5
[INFO] [stderr]    Compiling futures-io v0.3.16
[INFO] [stderr]    Compiling futures-channel v0.3.16
[INFO] [stderr]    Compiling tokio v1.9.0
[INFO] [stderr]    Compiling futures-macro v0.3.16
[INFO] [stderr]    Compiling proc-macro-nested v0.1.7
[INFO] [stderr]    Compiling futures-task v0.3.16
[INFO] [stderr]    Compiling value-bag v1.0.0-alpha.7
[INFO] [stderr]    Compiling generic-array v0.14.4
[INFO] [stderr]    Compiling phf_shared v0.8.0
[INFO] [stderr]    Compiling futures-util v0.3.16
[INFO] [stderr]    Compiling quote v1.0.9
[INFO] [stderr]    Compiling pkg-config v0.3.19
[INFO] [stderr]    Compiling itoa v0.4.7
[INFO] [stderr]    Compiling fnv v1.0.7
[INFO] [stderr]    Compiling slab v0.4.3
[INFO] [stderr]    Compiling pin-utils v0.1.0
[INFO] [stderr]    Compiling proc-macro-error-attr v1.0.4
[INFO] [stderr]    Compiling indexmap v1.7.0
[INFO] [stderr]    Compiling matches v0.1.8
[INFO] [stderr]    Compiling http v0.2.4
[INFO] [stderr]    Compiling proc-macro-error v1.0.4
[INFO] [stderr]    Compiling unicase v2.6.0
[INFO] [stderr]    Compiling miniz_oxide v0.4.4
[INFO] [stderr]    Compiling tinyvec_macros v0.1.0
[INFO] [stderr]    Compiling rand_core v0.5.1
[INFO] [stderr]    Compiling hashbrown v0.11.2
[INFO] [stderr]    Compiling once_cell v1.8.0
[INFO] [stderr]    Compiling tinyvec v1.3.1
[INFO] [stderr]    Compiling tracing-core v0.1.18
[INFO] [stderr]    Compiling openssl v0.10.35
[INFO] [stderr]    Compiling rand_pcg v0.2.1
[INFO] [stderr]    Compiling openssl-sys v0.9.65
[INFO] [stderr]    Compiling rand_chacha v0.2.2
[INFO] [stderr]    Compiling foreign-types-shared v0.1.1
[INFO] [stderr]    Compiling new_debug_unreachable v1.0.4
[INFO] [stderr]    Compiling percent-encoding v2.1.0
[INFO] [stderr]    Compiling adler v1.0.2
[INFO] [stderr]    Compiling httparse v1.4.1
[INFO] [stderr]    Compiling form_urlencoded v1.0.1
[INFO] [stderr]    Compiling rand v0.7.3
[INFO] [stderr]    Compiling foreign-types v0.3.2
[INFO] [stderr]    Compiling getrandom v0.2.3
[INFO] [stderr]    Compiling unicode-bidi v0.3.5
[INFO] [stderr]    Compiling try-lock v0.2.3
[INFO] [stderr]    Compiling ryu v1.0.5
[INFO] [stderr]    Compiling native-tls v0.2.7
[INFO] [stderr]    Compiling mac v0.1.1
[INFO] [stderr]    Compiling rand_core v0.6.3
[INFO] [stderr]    Compiling futf v0.1.4
[INFO] [stderr]    Compiling mime_guess v2.0.3
[INFO] [stderr]    Compiling time v0.1.44
[INFO] [stderr]    Compiling socket2 v0.4.0
[INFO] [stderr]    Compiling num-traits v0.2.14
[INFO] [stderr]    Compiling memoffset v0.6.4
[INFO] [stderr]    Compiling rand_chacha v0.3.1
[INFO] [stderr]    Compiling openssl-probe v0.1.4
[INFO] [stderr]    Compiling precomputed-hash v0.1.1
[INFO] [stderr]    Compiling tower-service v0.3.1
[INFO] [stderr]    Compiling httpdate v1.0.1
[INFO] [stderr]    Compiling utf-8 v0.7.6
[INFO] [stderr]    Compiling subtle v2.4.1
[INFO] [stderr]    Compiling mime v0.3.16
[INFO] [stderr]    Compiling unicode-normalization v0.1.19
[INFO] [stderr]    Compiling tendril v0.4.2
[INFO] [stderr]    Compiling rand v0.8.4
[INFO] [stderr]    Compiling digest v0.9.0
[INFO] [stderr]    Compiling backtrace v0.3.60
[INFO] [stderr]    Compiling aho-corasick v0.7.18
[INFO] [stderr]    Compiling phf v0.8.0
[INFO] [stderr]    Compiling phf_generator v0.8.0
[INFO] [stderr]    Compiling num-integer v0.1.44
[INFO] [stderr]    Compiling crc32fast v1.2.1
[INFO] [stderr]    Compiling string_cache_codegen v0.5.1
[INFO] [stderr]    Compiling phf_codegen v0.8.0
[INFO] [stderr]    Compiling gimli v0.24.0
[INFO] [stderr]    Compiling failure_derive v0.1.8
[INFO] [stderr]    Compiling alloc-no-stdlib v2.0.1
[INFO] [stderr]    Compiling regex-syntax v0.6.25
[INFO] [stderr]    Compiling alloc-stdlib v0.2.1
[INFO] [stderr]    Compiling http-body v0.4.2
[INFO] [stderr]    Compiling object v0.25.3
[INFO] [stderr]    Compiling serde_json v1.0.64
[INFO] [stderr]    Compiling crossbeam-utils v0.8.5
[INFO] [stderr]    Compiling same-file v1.0.6
[INFO] [stderr]    Compiling idna v0.2.3
[INFO] [stderr]    Compiling markup5ever v0.10.1
[INFO] [stderr]    Compiling rustc-demangle v0.1.20
[INFO] [stderr]    Compiling arrayref v0.3.6
[INFO] [stderr]    Compiling unsigned-varint v0.5.1
[INFO] [stderr]    Compiling walkdir v2.3.2
[INFO] [stderr]    Compiling brotli-decompressor v2.3.1
[INFO] [stderr]    Compiling crypto-mac v0.11.1
[INFO] [stderr]    Compiling block-buffer v0.9.0
[INFO] [stderr]    Compiling dirs-sys v0.3.6
[INFO] [stderr]    Compiling unicode-segmentation v1.8.0
[INFO] [stderr]    Compiling data-encoding v2.3.2
[INFO] [stderr]    Compiling async-trait v0.1.50
[INFO] [stderr]    Compiling cpufeatures v0.1.5
[INFO] [stderr]    Compiling static_assertions v1.1.0
[INFO] [stderr]    Compiling opaque-debug v0.3.0
[INFO] [stderr]    Compiling byteorder v1.4.3
[INFO] [stderr]    Compiling anyhow v1.0.42
[INFO] [stderr]    Compiling unsigned-varint v0.7.0
[INFO] [stderr]    Compiling bs58 v0.4.0
[INFO] [stderr]    Compiling arrayvec v0.5.2
[INFO] [stderr]    Compiling encoding_rs v0.8.28
[INFO] [stderr]    Compiling sha2 v0.9.5
[INFO] [stderr]    Compiling heck v0.3.3
[INFO] [stderr]    Compiling dirs v3.0.2
[INFO] [stderr]    Compiling addr2line v0.15.2
[INFO] [stderr]    Compiling hmac v0.11.0
[INFO] [stderr]    Compiling flate2 v1.0.20
[INFO] [stderr]    Compiling nix v0.22.2
[INFO] [stderr]    Compiling atty v0.2.14
[INFO] [stderr]    Compiling brotli v3.3.0
[INFO] [stderr]    Compiling blake3 v0.3.8
[INFO] [stderr]    Compiling regex v1.5.4
[INFO] [stderr]    Compiling bstr v0.2.16
[INFO] [stderr]    Compiling quick-error v1.2.3
[INFO] [stderr]    Compiling bit-vec v0.6.3
[INFO] [stderr]    Compiling termcolor v1.1.2
[INFO] [stderr]    Compiling linked-hash-map v0.5.4
[INFO] [stderr]    Compiling itertools v0.4.19
[INFO] [stderr]    Compiling bit-set v0.5.2
[INFO] [stderr]    Compiling yaml-rust v0.4.5
[INFO] [stderr]    Compiling toml v0.5.8
[INFO] [stderr]    Compiling humantime v1.3.0
[INFO] [stderr]    Compiling nix v0.21.2
[INFO] [stderr]    Compiling hexdump v0.1.1
[INFO] [stderr]    Compiling crypto-mac v0.8.0
[INFO] [stderr]    Compiling thread_local v1.1.3
[INFO] [stderr]    Compiling os_str_bytes v6.0.0
[INFO] [stderr]    Compiling dtoa v0.4.8
[INFO] [stderr]    Compiling base64 v0.13.0
[INFO] [stderr]    Compiling strsim v0.10.0
[INFO] [stderr]    Compiling textwrap v0.14.2
[INFO] [stderr]    Compiling match_cfg v0.1.0
[INFO] [stderr]    Compiling ipnet v2.3.1
[INFO] [stderr]    Compiling humantime v2.1.0
[INFO] [stderr]    Compiling constant_time_eq v0.1.5
[INFO] [stderr]    Compiling unix_mode v0.1.1
[INFO] [stderr]    Compiling synstructure v0.12.5
[INFO] [stderr]    Compiling hostname v0.3.1
[INFO] [stderr]    Compiling crossbeam-channel v0.5.1
[INFO] [stderr]    Compiling nanoid v0.4.0
[INFO] [stderr]    Compiling pathdiff v0.2.0
[INFO] [stderr]    Compiling bytesize v1.0.1
[INFO] [stderr]    Compiling ctor v0.1.20
[INFO] [stderr]    Compiling tokio-macros v1.3.0
[INFO] [stderr]    Compiling thiserror-impl v1.0.26
[INFO] [stderr]    Compiling tracing-attributes v0.1.15
[INFO] [stderr]    Compiling html5ever v0.25.1
[INFO] [stderr]    Compiling async-stream-impl v0.3.2
[INFO] [stderr]    Compiling pin-project-internal v1.0.8
[INFO] [stderr]    Compiling typed-builder v0.9.0
[INFO] [stderr]    Compiling custom_debug_derive v0.5.0
[INFO] [stderr]    Compiling clap_derive v3.0.0
[INFO] [stderr]    Compiling failure v0.1.8
[INFO] [stderr]    Compiling async-stream v0.3.2
[INFO] [stderr]    Compiling custom_debug v0.5.0
[INFO] [stderr]    Compiling async-recursion v0.3.2
[INFO] [stderr]    Compiling mio v0.7.13
[INFO] [stderr]    Compiling thiserror v1.0.26
[INFO] [stderr]    Compiling want v0.3.0
[INFO] [stderr]    Compiling proc-macro-crate v1.0.0
[INFO] [stderr]    Compiling globset v0.4.8
[INFO] [stderr]    Compiling env_logger v0.8.4
[INFO] [stderr]    Compiling tracing v0.1.26
[INFO] [stderr]    Compiling multihash-derive v0.7.2
[INFO] [stderr]    Compiling ignore v0.4.18
[INFO] [stderr]    Compiling pin-project v1.0.8
[INFO] [stderr]    Compiling clap v3.0.0
[INFO] [stderr]    Compiling multihash v0.13.2
[INFO] [stderr]    Compiling futures-executor v0.3.16
[INFO] [stderr]    Compiling futures v0.3.16
[INFO] [stderr]    Compiling common-multipart-rfc7578 v0.3.0
[INFO] [stderr]    Compiling tokio-util v0.6.7
[INFO] [stderr]    Compiling tokio-native-tls v0.3.0
[INFO] [stderr]    Compiling async-compression v0.3.8
[INFO] [stderr]    Compiling h2 v0.3.3
[INFO] [stderr]    Compiling url v2.2.2
[INFO] [stderr]    Compiling string_cache v0.8.1
[INFO] [stderr]    Compiling serde_urlencoded v0.7.0
[INFO] [stderr]    Compiling chrono v0.4.19
[INFO] [stderr]    Compiling uuid v0.8.2
[INFO] [stderr]    Compiling serde_yaml v0.8.17
[INFO] [stderr]    Compiling serde-humantime v0.1.1
[INFO] [stderr]    Compiling libsystemd v0.3.1
[INFO] [stderr]    Compiling systemd-journal-logger v0.3.1
[INFO] [stderr]    Compiling parity-multiaddr v0.11.2
[INFO] [stderr]    Compiling arrsync v0.2.1 (/opt/rustwide/workdir/crates/arrsync)
[INFO] [stderr]    Compiling async_ftp v5.0.0
[INFO] [stderr]    Compiling xml5ever v0.16.1
[INFO] [stderr]    Compiling markup5ever_rcdom v0.1.0
[INFO] [stderr]    Compiling select v0.5.0
[INFO] [stderr]    Compiling hyper v0.14.11
[INFO] [stderr]    Compiling hyper-tls v0.5.0
[INFO] [stderr]    Compiling hyper-multipart-rfc7578 v0.5.0
[INFO] [stderr]    Compiling ipfs-api v0.11.0
[INFO] [stderr]    Compiling reqwest v0.11.4
[INFO] [stderr]    Compiling ipfs-mfs v0.3.0 (/opt/rustwide/workdir/crates/mfs)
[INFO] [stderr]    Compiling ftp2mfs v0.3.1 (/opt/rustwide/workdir)
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]   --> src/synlink.rs:46:32
[INFO] [stdout]    |
[INFO] [stdout] 46 |                 .map(move |dependee| (child.clone(), dependee.clone()))
[INFO] [stdout]    |                                            ^^^^^^^^ help: remove this redundant call
[INFO] [stdout]    |
[INFO] [stdout]    = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed
[INFO] [stdout]    = note: `#[warn(noop_method_call)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&PathBuf` instead of cloning the inner type
[INFO] [stdout]   --> src/synlink.rs:46:50
[INFO] [stdout]    |
[INFO] [stdout] 46 |                 .map(move |dependee| (child.clone(), dependee.clone()))
[INFO] [stdout]    |                                                              ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(suspicious_double_ref_op)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement
[INFO] [stdout]    --> src/synlink.rs:101:14
[INFO] [stdout]     |
[INFO] [stdout] 101 |             for es in mrev.get(&er.to_path_buf()) {
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(for_loops_over_fallibles)]` on by default
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]     |
[INFO] [stdout] 101 |             while let Some(es) = mrev.get(&er.to_path_buf()) {
[INFO] [stdout]     |             ~~~~~~~~~~~~~~~  ~~~
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]     |
[INFO] [stdout] 101 |             if let Some(es) = mrev.get(&er.to_path_buf()) {
[INFO] [stdout]     |             ~~~~~~~~~~~~  ~~~
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: 3 warnings emitted
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 37.19s
[INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: html5ever v0.25.1, xml5ever v0.16.1
[INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1`
[INFO] running `Command { std: "docker" "inspect" "24dc8550a0bec52af213d424cc53a4473340921dd1e92c989d84bb9727143bbe", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "24dc8550a0bec52af213d424cc53a4473340921dd1e92c989d84bb9727143bbe", kill_on_drop: false }`
[INFO] [stdout] 24dc8550a0bec52af213d424cc53a4473340921dd1e92c989d84bb9727143bbe
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "RUSTDOCFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4f8da3c744d2da974e54ce020a79f4ad54313e914ebeaab8fc086f07e8d8b066" "/opt/rustwide/cargo-home/bin/cargo" "+1.73.0" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 98cf1bc6dffb492368e233b7f1fd0d49ca9ca532f0385a5f3958b3f1684c662f
[INFO] running `Command { std: "docker" "start" "-a" "98cf1bc6dffb492368e233b7f1fd0d49ca9ca532f0385a5f3958b3f1684c662f", kill_on_drop: false }`
[INFO] [stderr]    Compiling scopeguard v1.1.0
[INFO] [stderr]    Compiling instant v0.1.10
[INFO] [stderr]    Compiling smallvec v1.6.1
[INFO] [stderr]    Compiling tokio v1.9.0
[INFO] [stderr]    Compiling num_cpus v1.13.0
[INFO] [stderr]    Compiling signal-hook-registry v1.4.0
[INFO] [stderr]    Compiling futures-task v0.3.16
[INFO] [stderr]    Compiling crunchy v0.2.2
[INFO] [stderr]    Compiling tiny-keccak v2.0.2
[INFO] [stderr]    Compiling ring v0.16.20
[INFO] [stderr]    Compiling getrandom v0.2.3
[INFO] [stderr]    Compiling memoffset v0.5.6
[INFO] [stderr]    Compiling crossbeam-utils v0.7.2
[INFO] [stderr]    Compiling untrusted v0.7.1
[INFO] [stderr]    Compiling maybe-uninit v2.0.0
[INFO] [stderr]    Compiling spin v0.5.2
[INFO] [stderr]    Compiling lock_api v0.4.4
[INFO] [stderr]    Compiling crossbeam-epoch v0.8.2
[INFO] [stderr]    Compiling slog v2.7.0
[INFO] [stderr]    Compiling protobuf v2.24.1
[INFO] [stderr]    Compiling parking_lot_core v0.8.3
[INFO] [stderr]    Compiling gcc v0.3.55
[INFO] [stderr]    Compiling uuid v0.8.2
[INFO] [stderr]    Compiling raw-cpuid v9.1.1
[INFO] [stderr]    Compiling parking_lot v0.11.1
[INFO] [stderr]    Compiling rand v0.4.6
[INFO] [stderr]    Compiling prometheus v0.12.0
[INFO] [stderr]    Compiling futures-util v0.3.16
[INFO] [stderr]    Compiling moka v0.3.1
[INFO] [stderr]    Compiling arc-swap v1.3.0
[INFO] [stderr]    Compiling atomic-shim v0.1.0
[INFO] [stderr]    Compiling scheduled-thread-pool v0.2.5
[INFO] [stderr]    Compiling rustc-serialize v0.3.24
[INFO] [stderr]    Compiling const-random-macro v0.1.13
[INFO] [stderr]    Compiling either v1.6.1
[INFO] [stderr]    Compiling convert_case v0.4.0
[INFO] [stderr]    Compiling slog-scope v4.4.0
[INFO] [stderr]    Compiling itertools v0.10.1
[INFO] [stderr]    Compiling proxy-protocol v0.3.0
[INFO] [stderr]    Compiling libsystemd v0.3.1
[INFO] [stderr]    Compiling rust-crypto v0.2.36
[INFO] [stderr]    Compiling rand v0.3.23
[INFO] [stderr]    Compiling quanta v0.7.2
[INFO] [stderr]    Compiling derive_more v0.99.16
[INFO] [stderr]    Compiling slog-stdlog v4.1.0
[INFO] [stderr]    Compiling systemd-journal-logger v0.3.1
[INFO] [stderr]    Compiling const-random v0.1.13
[INFO] [stderr]    Compiling ahash v0.3.8
[INFO] [stderr]    Compiling cht v0.4.1
[INFO] [stderr]    Compiling futures-executor v0.3.16
[INFO] [stderr]    Compiling futures v0.3.16
[INFO] [stderr]    Compiling common-multipart-rfc7578 v0.3.0
[INFO] [stderr]    Compiling tracing-futures v0.2.5
[INFO] [stderr]    Compiling webpki v0.21.4
[INFO] [stderr]    Compiling sct v0.6.1
[INFO] [stderr]    Compiling rustls v0.19.1
[INFO] [stderr]    Compiling tokio-util v0.6.7
[INFO] [stderr]    Compiling tokio-native-tls v0.3.0
[INFO] [stderr]    Compiling tokio-stream v0.1.7
[INFO] [stderr]    Compiling async-compression v0.3.8
[INFO] [stderr]    Compiling async_ftp v5.0.0
[INFO] [stderr]    Compiling h2 v0.3.3
[INFO] [stderr]    Compiling arrsync v0.2.1 (/opt/rustwide/workdir/crates/arrsync)
[INFO] [stderr]    Compiling tokio-rustls v0.22.0
[INFO] [stderr]    Compiling libunftp v0.17.4
[INFO] [stderr]    Compiling hyper v0.14.11
[INFO] [stderr]    Compiling unmemftp v0.1.0 (/opt/rustwide/workdir/crates/unmemftp)
[INFO] [stderr]    Compiling hyper-tls v0.5.0
[INFO] [stderr]    Compiling hyper-multipart-rfc7578 v0.5.0
[INFO] [stderr]    Compiling ipfs-api v0.11.0
[INFO] [stderr]    Compiling reqwest v0.11.4
[INFO] [stderr]    Compiling ipfs-mfs v0.3.0 (/opt/rustwide/workdir/crates/mfs)
[INFO] [stderr]    Compiling ftp2mfs v0.3.1 (/opt/rustwide/workdir)
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]   --> src/synlink.rs:46:32
[INFO] [stdout]    |
[INFO] [stdout] 46 |                 .map(move |dependee| (child.clone(), dependee.clone()))
[INFO] [stdout]    |                                            ^^^^^^^^ help: remove this redundant call
[INFO] [stdout]    |
[INFO] [stdout]    = note: the type `std::path::Path` does not implement `Clone`, so calling `clone` on `&std::path::Path` copies the reference, which does not do anything and can be removed
[INFO] [stdout]    = note: `#[warn(noop_method_call)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&std::path::PathBuf` instead of cloning the inner type
[INFO] [stdout]   --> src/synlink.rs:46:50
[INFO] [stdout]    |
[INFO] [stdout] 46 |                 .map(move |dependee| (child.clone(), dependee.clone()))
[INFO] [stdout]    |                                                              ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(suspicious_double_ref_op)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement
[INFO] [stdout]    --> src/synlink.rs:101:14
[INFO] [stdout]     |
[INFO] [stdout] 101 |             for es in mrev.get(&er.to_path_buf()) {
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(for_loops_over_fallibles)]` on by default
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]     |
[INFO] [stdout] 101 |             while let Some(es) = mrev.get(&er.to_path_buf()) {
[INFO] [stdout]     |             ~~~~~~~~~~~~~~~  ~~~
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]     |
[INFO] [stdout] 101 |             if let Some(es) = mrev.get(&er.to_path_buf()) {
[INFO] [stdout]     |             ~~~~~~~~~~~~  ~~~
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: 3 warnings emitted
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished test [unoptimized + debuginfo] target(s) in 21.94s
[INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: html5ever v0.25.1, rustc-serialize v0.3.24, xml5ever v0.16.1
[INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2`
[INFO] running `Command { std: "docker" "inspect" "98cf1bc6dffb492368e233b7f1fd0d49ca9ca532f0385a5f3958b3f1684c662f", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "98cf1bc6dffb492368e233b7f1fd0d49ca9ca532f0385a5f3958b3f1684c662f", kill_on_drop: false }`
[INFO] [stdout] 98cf1bc6dffb492368e233b7f1fd0d49ca9ca532f0385a5f3958b3f1684c662f
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "RUSTDOCFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4f8da3c744d2da974e54ce020a79f4ad54313e914ebeaab8fc086f07e8d8b066" "/opt/rustwide/cargo-home/bin/cargo" "+1.73.0" "test" "--frozen", kill_on_drop: false }`
[INFO] [stdout] b4ed937670147e179fa646f8eb8c41e98f3c916ef6d0849866f9efb0323b0c1e
[INFO] running `Command { std: "docker" "start" "-a" "b4ed937670147e179fa646f8eb8c41e98f3c916ef6d0849866f9efb0323b0c1e", kill_on_drop: false }`
[INFO] [stderr] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stderr]   --> src/synlink.rs:46:32
[INFO] [stderr]    |
[INFO] [stderr] 46 |                 .map(move |dependee| (child.clone(), dependee.clone()))
[INFO] [stderr]    |                                            ^^^^^^^^ help: remove this redundant call
[INFO] [stderr]    |
[INFO] [stderr]    = note: the type `std::path::Path` does not implement `Clone`, so calling `clone` on `&std::path::Path` copies the reference, which does not do anything and can be removed
[INFO] [stderr]    = note: `#[warn(noop_method_call)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: using `.clone()` on a double reference, which returns `&std::path::PathBuf` instead of cloning the inner type
[INFO] [stderr]   --> src/synlink.rs:46:50
[INFO] [stderr]    |
[INFO] [stderr] 46 |                 .map(move |dependee| (child.clone(), dependee.clone()))
[INFO] [stderr]    |                                                              ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: `#[warn(suspicious_double_ref_op)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: for loop over an `Option`. This is more readably written as an `if let` statement
[INFO] [stderr]    --> src/synlink.rs:101:14
[INFO] [stderr]     |
[INFO] [stderr] 101 |             for es in mrev.get(&er.to_path_buf()) {
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: `#[warn(for_loops_over_fallibles)]` on by default
[INFO] [stderr] help: to check pattern in a loop use `while let`
[INFO] [stderr]     |
[INFO] [stderr] 101 |             while let Some(es) = mrev.get(&er.to_path_buf()) {
[INFO] [stderr]     |             ~~~~~~~~~~~~~~~  ~~~
[INFO] [stderr] help: consider using `if let` to clear intent
[INFO] [stderr]     |
[INFO] [stderr] 101 |             if let Some(es) = mrev.get(&er.to_path_buf()) {
[INFO] [stderr]     |             ~~~~~~~~~~~~  ~~~
[INFO] [stderr] 
[INFO] [stderr] warning: `ftp2mfs` (bin "ftp2mfs" test) generated 3 warnings (run `cargo fix --bin "ftp2mfs" --tests` to apply 1 suggestion)
[INFO] [stderr]     Finished test [unoptimized + debuginfo] target(s) in 0.50s
[INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: html5ever v0.25.1, rustc-serialize v0.3.24, xml5ever v0.16.1
[INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2`
[INFO] [stderr]      Running unittests src/main.rs (/opt/rustwide/target/debug/deps/ftp2mfs-59dbfaac91d2d2fc)
[INFO] [stdout] 
[INFO] [stdout] running 32 tests
[INFO] [stdout] test nabla::test::allgone_alldelete ... ok
[INFO] [stdout] test globtest::over ... ok
[INFO] [stdout] test nabla::test::all_quiet_in_the_west ... ok
[INFO] [stdout] test nabla::test::changed_symlinks ... ok
[INFO] [stdout] test nabla::test::keep ... ok
[INFO] [stdout] test nabla::test::honor_reprieve_on_recovery ... ok
[INFO] [stdout] test globtest::unignore_subdir ... ok
[INFO] [stdout] test nabla::test::allnew_allsync ... ok
[INFO] [stdout] test globtest::unignore_subdir_only ... ok
[INFO] [stdout] test globtest::basic ... ok
[INFO] [stdout] test nabla::test::info_changed ... ok
[INFO] [stdout] test globtest::ignore_unrecursively ... ok
[INFO] [stdout] test globtest::globs ... ok
[INFO] [stdout] test globtest::negations ... ok
[INFO] [stdout] test globtest::unignore_recursively ... ok
[INFO] [stdout] test nabla::test::then_delete ... ok
[INFO] [stdout] test synlink::test::chain ... ok
[INFO] [stdout] test synlink::test::resresres ... ok
[INFO] [stdout] test synlink::test::oneoftwo ... ok
[INFO] [stdout] test nabla::test::no_new_is_good_new ... ok
[INFO] [stdout] test nabla::test::optidelete_knows_symlinks ... ok
[INFO] [stdout] test synlink::test::feight ... ok
[INFO] [stdout] test synlink::test::undefineddirectorybehavior ... ok
[INFO] [stdout] test synlink::test::circdelink ... ok
[INFO] [stdout] test synlink::test::aaaa ... ok
[INFO] [stdout] test synlink::test::dropweirds ... ok
[INFO] [stdout] test synlink::test::sub ... ok
[INFO] [stdout] test fromftp::provider::test::get_bc ... ok
[INFO] [stdout] test fromftp::provider::test::cant_get_d ... ok
[INFO] [stdout] test fromftp::provider::test::get_bc_absdir ... ok
[INFO] [stdout] test fromftp::provider::test::get_a ... ok
[INFO] [stdout] test fromftp::recursor::test::main ... ok
[INFO] [stdout] 
[INFO] [stdout] test result: ok. 32 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.27s
[INFO] [stdout] 
[INFO] running `Command { std: "docker" "inspect" "b4ed937670147e179fa646f8eb8c41e98f3c916ef6d0849866f9efb0323b0c1e", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "b4ed937670147e179fa646f8eb8c41e98f3c916ef6d0849866f9efb0323b0c1e", kill_on_drop: false }`
[INFO] [stdout] b4ed937670147e179fa646f8eb8c41e98f3c916ef6d0849866f9efb0323b0c1e