[INFO] cloning repository https://github.com/Hugobros3/nes [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Hugobros3/nes" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHugobros3%2Fnes", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHugobros3%2Fnes'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ca1cf64e5a9475f6b38edd63f229550f149aa003 [INFO] documenting Hugobros3/nes against beta-2023-05-30 for beta-1.71-rustdoc-1 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHugobros3%2Fnes" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Hugobros3/nes on toolchain beta-2023-05-30 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+beta-2023-05-30" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Hugobros3/nes [INFO] finished tweaking git repo https://github.com/Hugobros3/nes [INFO] tweaked toml for git repo https://github.com/Hugobros3/nes written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Hugobros3/nes already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+beta-2023-05-30" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:19e73879b68f455e41552ea35293514db52ea292d993f571636dbffedb77a1ee" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2023-05-30" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3b3974c766d6e3c81fe21cd8e436dd87874782aee1b796ef3439144c21620a12 [INFO] running `Command { std: "docker" "start" "-a" "3b3974c766d6e3c81fe21cd8e436dd87874782aee1b796ef3439144c21620a12", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3b3974c766d6e3c81fe21cd8e436dd87874782aee1b796ef3439144c21620a12", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3b3974c766d6e3c81fe21cd8e436dd87874782aee1b796ef3439144c21620a12", kill_on_drop: false }` [INFO] [stdout] 3b3974c766d6e3c81fe21cd8e436dd87874782aee1b796ef3439144c21620a12 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "RUSTDOCFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:19e73879b68f455e41552ea35293514db52ea292d993f571636dbffedb77a1ee" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2023-05-30" "doc" "--frozen" "--no-deps" "--document-private-items" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3801b394ab61fe7453ff268c005ceea19f39da95399a3f176acfc04fb4a5ca41 [INFO] running `Command { std: "docker" "start" "-a" "3801b394ab61fe7453ff268c005ceea19f39da95399a3f176acfc04fb4a5ca41", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Compiling cc v1.0.45 [INFO] [stderr] Compiling pkg-config v0.3.16 [INFO] [stderr] Compiling proc-macro2 v1.0.5 [INFO] [stderr] Compiling syn v1.0.5 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling getrandom v0.1.12 [INFO] [stderr] Compiling autocfg v0.1.6 [INFO] [stderr] Compiling failure_derive v0.1.6 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking ppv-lite86 v0.2.5 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Compiling cpal v0.10.0 [INFO] [stderr] Checking cast v0.2.2 [INFO] [stderr] Checking spin_sleep v0.3.7 [INFO] [stderr] Checking hex v0.3.2 [INFO] [stderr] Checking c2-chacha v0.2.2 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Compiling alsa-sys v0.1.2 [INFO] [stderr] Compiling x11-dl v2.18.4 [INFO] [stderr] Compiling backtrace-sys v0.1.31 [INFO] [stderr] Compiling minifb v0.13.0 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rand v0.7.2 [INFO] [stderr] Checking backtrace v0.3.38 [INFO] [stderr] Compiling bf-impl v1.0.0 [INFO] [stderr] Compiling synstructure v0.12.1 [INFO] [stderr] Checking bitutils v3.0.0 [INFO] [stderr] Checking failure v0.1.6 [INFO] [stderr] Documenting nes v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/cpu/addressing_modes.rs:110:31 [INFO] [stdout] | [INFO] [stdout] 110 | let additional_cycles = if(og_page != offseted_page) { 1 } else { 0 }; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 110 - let additional_cycles = if(og_page != offseted_page) { 1 } else { 0 }; [INFO] [stdout] 110 + let additional_cycles = if og_page != offseted_page { 1 } else { 0 }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/cpu/addressing_modes.rs:127:31 [INFO] [stdout] | [INFO] [stdout] 127 | let additional_cycles = if(og_page != offseted_page) { 1 } else { 0 }; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 127 - let additional_cycles = if(og_page != offseted_page) { 1 } else { 0 }; [INFO] [stdout] 127 + let additional_cycles = if og_page != offseted_page { 1 } else { 0 }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/cpu/addressing_modes.rs:143:24 [INFO] [stdout] | [INFO] [stdout] 143 | let address_hi = if(ptr_low == 0xFFu8) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 143 - let address_hi = if(ptr_low == 0xFFu8) { [INFO] [stdout] 143 + let address_hi = if ptr_low == 0xFFu8 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around method argument [INFO] [stdout] --> src/cpu/addressing_modes.rs:144:23 [INFO] [stdout] | [INFO] [stdout] 144 | bus.cpu_read((ptr & 0xFF00), false) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 144 - bus.cpu_read((ptr & 0xFF00), false) [INFO] [stdout] 144 + bus.cpu_read(ptr & 0xFF00, false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/ppu/main_window.rs:38:29 [INFO] [stdout] | [INFO] [stdout] 38 | self.buffer[(y as usize * width + x as usize)] = pack(rgb.0, rgb.1, rgb.2); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 38 - self.buffer[(y as usize * width + x as usize)] = pack(rgb.0, rgb.1, rgb.2); [INFO] [stdout] 38 + self.buffer[y as usize * width + x as usize] = pack(rgb.0, rgb.1, rgb.2); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/ppu/patterns_debug_viewer.rs:59:29 [INFO] [stdout] | [INFO] [stdout] 59 | self.buffer[(y as usize * width + x as usize)] = pack(palette_rgb.0, palette_rgb.1, palette_rgb.2); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 59 - self.buffer[(y as usize * width + x as usize)] = pack(palette_rgb.0, palette_rgb.1, palette_rgb.2); [INFO] [stdout] 59 + self.buffer[y as usize * width + x as usize] = pack(palette_rgb.0, palette_rgb.1, palette_rgb.2); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/ppu/nametables_debug_viewer.rs:57:45 [INFO] [stdout] | [INFO] [stdout] 57 | ... self.buffer[((y) as usize * (2 * 256) + (x) as usize)] = pack(palette_rgb.0, palette_rgb.1, palette_rgb.2); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 57 - self.buffer[((y) as usize * (2 * 256) + (x) as usize)] = pack(palette_rgb.0, palette_rgb.1, palette_rgb.2); [INFO] [stdout] 57 + self.buffer[(y) as usize * (2 * 256) + (x) as usize] = pack(palette_rgb.0, palette_rgb.1, palette_rgb.2); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/ppu/window_common.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | (r << 16 | g << 8 | b << 0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 14 - (r << 16 | g << 8 | b << 0) [INFO] [stdout] 14 + r << 16 | g << 8 | b << 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around method argument [INFO] [stdout] --> src/ppu.rs:227:49 [INFO] [stdout] | [INFO] [stdout] 227 | self.tram_addr.set_coarse_x(((data >> 3) as u16)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 227 - self.tram_addr.set_coarse_x(((data >> 3) as u16)); [INFO] [stdout] 227 + self.tram_addr.set_coarse_x((data >> 3) as u16); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around method argument [INFO] [stdout] --> src/ppu.rs:231:49 [INFO] [stdout] | [INFO] [stdout] 231 | self.tram_addr.set_coarse_y(((data >> 3) as u16)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 231 - self.tram_addr.set_coarse_y(((data >> 3) as u16)); [INFO] [stdout] 231 + self.tram_addr.set_coarse_y((data >> 3) as u16); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/ppu.rs:247:39 [INFO] [stdout] | [INFO] [stdout] 247 | self.vram_addr.val += (if self.control.increment_mode() == 1 { 32 } else { 1 }); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 247 - self.vram_addr.val += (if self.control.increment_mode() == 1 { 32 } else { 1 }); [INFO] [stdout] 247 + self.vram_addr.val += if self.control.increment_mode() == 1 { 32 } else { 1 }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/apu/pulse_voice.rs:128:34 [INFO] [stdout] | [INFO] [stdout] 128 | self.register3 = ((shifter_result & 0xFF) as u8); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 128 - self.register3 = ((shifter_result & 0xFF) as u8); [INFO] [stdout] 128 + self.register3 = (shifter_result & 0xFF) as u8; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around method argument [INFO] [stdout] --> src/apu/apu_device.rs:91:47 [INFO] [stdout] | [INFO] [stdout] 91 | self.square_voice1.write_register(((address & 0x03) as u8), data); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 91 - self.square_voice1.write_register(((address & 0x03) as u8), data); [INFO] [stdout] 91 + self.square_voice1.write_register((address & 0x03) as u8, data); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around method argument [INFO] [stdout] --> src/apu/apu_device.rs:93:47 [INFO] [stdout] | [INFO] [stdout] 93 | self.square_voice2.write_register(((address & 0x03) as u8), data); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 93 - self.square_voice2.write_register(((address & 0x03) as u8), data); [INFO] [stdout] 93 + self.square_voice2.write_register((address & 0x03) as u8, data); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around method argument [INFO] [stdout] --> src/apu/apu_device.rs:95:48 [INFO] [stdout] | [INFO] [stdout] 95 | self.triangle_voice.write_register(((address & 0x03) as u8), data); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 95 - self.triangle_voice.write_register(((address & 0x03) as u8), data); [INFO] [stdout] 95 + self.triangle_voice.write_register((address & 0x03) as u8, data); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around method argument [INFO] [stdout] --> src/apu/apu_device.rs:97:45 [INFO] [stdout] | [INFO] [stdout] 97 | self.noise_voice.write_register(((address & 0x03) as u8), data); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 97 - self.noise_voice.write_register(((address & 0x03) as u8), data); [INFO] [stdout] 97 + self.noise_voice.write_register((address & 0x03) as u8, data); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/apu/apu_device.rs:224:29 [INFO] [stdout] | [INFO] [stdout] 224 | let mut start = (((sample_length as f32 / bytes_req as f32) * (i as f32)) as usize); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 224 - let mut start = (((sample_length as f32 / bytes_req as f32) * (i as f32)) as usize); [INFO] [stdout] 224 + let mut start = ((sample_length as f32 / bytes_req as f32) * (i as f32)) as usize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/apu/apu_device.rs:225:27 [INFO] [stdout] | [INFO] [stdout] 225 | let mut end = (((sample_length as f32 / bytes_req as f32) * (next as f32)) as usize); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 225 - let mut end = (((sample_length as f32 / bytes_req as f32) * (next as f32)) as usize); [INFO] [stdout] 225 + let mut end = ((sample_length as f32 / bytes_req as f32) * (next as f32)) as usize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/ines_loader.rs:38:28 [INFO] [stdout] | [INFO] [stdout] 38 | let mirroring_mode = if(mirroring4s) { MirroringMode::FourScreen } else { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 38 - let mirroring_mode = if(mirroring4s) { MirroringMode::FourScreen } else { [INFO] [stdout] 38 + let mirroring_mode = if mirroring4s { MirroringMode::FourScreen } else { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/ines_loader.rs:39:11 [INFO] [stdout] | [INFO] [stdout] 39 | if(mirroring_hv) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 39 - if(mirroring_hv) { [INFO] [stdout] 39 + if mirroring_hv { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 20 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.98s [INFO] running `Command { std: "docker" "inspect" "3801b394ab61fe7453ff268c005ceea19f39da95399a3f176acfc04fb4a5ca41", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3801b394ab61fe7453ff268c005ceea19f39da95399a3f176acfc04fb4a5ca41", kill_on_drop: false }` [INFO] [stdout] 3801b394ab61fe7453ff268c005ceea19f39da95399a3f176acfc04fb4a5ca41