[INFO] fetching crate diffmetrik 0.3.0...
[INFO] testing diffmetrik-0.3.0 against 1.69.0 for beta-1.70-1
[INFO] extracting crate diffmetrik 0.3.0 into /workspace/builds/worker-2-tc1/source
[INFO] validating manifest of crates.io crate diffmetrik 0.3.0 on toolchain 1.69.0
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1.69.0" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] started tweaking crates.io crate diffmetrik 0.3.0
[INFO] finished tweaking crates.io crate diffmetrik 0.3.0
[INFO] tweaked toml for crates.io crate diffmetrik 0.3.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml
[INFO] crate crates.io crate diffmetrik 0.3.0 already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1.69.0" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded proc-macro-error v0.4.4
[INFO] [stderr]   Downloaded structopt v0.3.7
[INFO] [stderr]   Downloaded human_format v1.0.3
[INFO] [stderr]   Downloaded proc-macro-error-attr v0.4.3
[INFO] [stderr]   Downloaded cc v1.0.50
[INFO] [stderr]   Downloaded rustversion v1.0.1
[INFO] [stderr]   Downloaded proc-macro2 v1.0.7
[INFO] [stderr]   Downloaded serde_derive v1.0.104
[INFO] [stderr]   Downloaded backtrace v0.3.41
[INFO] [stderr]   Downloaded serde v1.0.104
[INFO] [stderr]   Downloaded syn v1.0.13
[INFO] [stderr]   Downloaded winapi-util v0.1.3
[INFO] [stderr]   Downloaded structopt-derive v0.4.0
[INFO] [stderr]   Downloaded sysctl v0.4.0
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:5ff2268d62e97bff2cde7d5815dd6ed5b47097566f13b8d0ca110b04b60e07ed" "/opt/rustwide/cargo-home/bin/cargo" "+1.69.0" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 27e8025235ff2dda3796cbbf867a5f3d23a92ea616a68b1072a6f9d4b5722522
[INFO] running `Command { std: "docker" "start" "-a" "27e8025235ff2dda3796cbbf867a5f3d23a92ea616a68b1072a6f9d4b5722522", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "27e8025235ff2dda3796cbbf867a5f3d23a92ea616a68b1072a6f9d4b5722522", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "27e8025235ff2dda3796cbbf867a5f3d23a92ea616a68b1072a6f9d4b5722522", kill_on_drop: false }`
[INFO] [stdout] 27e8025235ff2dda3796cbbf867a5f3d23a92ea616a68b1072a6f9d4b5722522
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "RUSTDOCFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:5ff2268d62e97bff2cde7d5815dd6ed5b47097566f13b8d0ca110b04b60e07ed" "/opt/rustwide/cargo-home/bin/cargo" "+1.69.0" "build" "--frozen" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 154f860e7f09d842b0d766de98b3144b3eb3cfd07b002b6f7b0f9100db908898
[INFO] running `Command { std: "docker" "start" "-a" "154f860e7f09d842b0d766de98b3144b3eb3cfd07b002b6f7b0f9100db908898", kill_on_drop: false }`
[INFO] [stderr]    Compiling proc-macro2 v1.0.7
[INFO] [stderr]    Compiling syn v1.0.13
[INFO] [stderr]    Compiling cc v1.0.50
[INFO] [stderr]    Compiling failure_derive v0.1.6
[INFO] [stderr]    Compiling byteorder v1.3.2
[INFO] [stderr]    Compiling serde v1.0.104
[INFO] [stderr]    Compiling rustc-demangle v0.1.16
[INFO] [stderr]    Compiling ryu v1.0.2
[INFO] [stderr]    Compiling walkdir v2.3.1
[INFO] [stderr]    Compiling itoa v0.4.4
[INFO] [stderr]    Compiling human_format v1.0.3
[INFO] [stderr]    Compiling fs2 v0.4.3
[INFO] [stderr]    Compiling backtrace-sys v0.1.32
[INFO] [stderr]    Compiling quote v1.0.2
[INFO] [stderr]    Compiling backtrace v0.3.41
[INFO] [stderr]    Compiling syn-mid v0.4.0
[INFO] [stderr]    Compiling synstructure v0.12.3
[INFO] [stderr]    Compiling rustversion v1.0.1
[INFO] [stderr]    Compiling serde_derive v1.0.104
[INFO] [stderr]    Compiling failure v0.1.6
[INFO] [stderr]    Compiling proc-macro-error v0.4.4
[INFO] [stderr]    Compiling proc-macro-error-attr v0.4.3
[INFO] [stderr]    Compiling sysctl v0.4.0
[INFO] [stderr]    Compiling structopt-derive v0.4.0
[INFO] [stderr]    Compiling structopt v0.3.7
[INFO] [stderr]    Compiling serde_json v1.0.44
[INFO] [stderr]    Compiling diffmetrik v0.3.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unnecessary braces around method argument
[INFO] [stdout]    --> src/metrics/network.rs:260:14
[INFO] [stdout]     |
[INFO] [stdout] 260 |         .map({ |line| LinuxProcNetDevLine::new(line) })
[INFO] [stdout]     |              ^^                                     ^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_braces)]` on by default
[INFO] [stdout] help: remove these braces
[INFO] [stdout]     |
[INFO] [stdout] 260 -         .map({ |line| LinuxProcNetDevLine::new(line) })
[INFO] [stdout] 260 +         .map(|line| LinuxProcNetDevLine::new(line))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary braces around method argument
[INFO] [stdout]    --> src/metrics/network.rs:259:17
[INFO] [stdout]     |
[INFO] [stdout] 259 |         .filter({ |line| line.starts_with("eth") })
[INFO] [stdout]     |                 ^^                              ^^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these braces
[INFO] [stdout]     |
[INFO] [stdout] 259 -         .filter({ |line| line.starts_with("eth") })
[INFO] [stdout] 259 +         .filter(|line| line.starts_with("eth"))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary braces around method argument
[INFO] [stdout]    --> src/metrics/network.rs:258:14
[INFO] [stdout]     |
[INFO] [stdout] 258 |         .map({ |line| line.trim() })
[INFO] [stdout]     |              ^^                  ^^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these braces
[INFO] [stdout]     |
[INFO] [stdout] 258 -         .map({ |line| line.trim() })
[INFO] [stdout] 258 +         .map(|line| line.trim())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary braces around method argument
[INFO] [stdout]   --> src/metrics/mod.rs:63:38
[INFO] [stdout]    |
[INFO] [stdout] 63 |         metrics.sort_unstable_by_key({ |a| a.time });
[INFO] [stdout]    |                                      ^^          ^^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these braces
[INFO] [stdout]    |
[INFO] [stdout] 63 -         metrics.sort_unstable_by_key({ |a| a.time });
[INFO] [stdout] 63 +         metrics.sort_unstable_by_key(|a| a.time);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: multiple fields are never read
[INFO] [stdout]    --> src/metrics/network.rs:201:5
[INFO] [stdout]     |
[INFO] [stdout] 200 | struct LinuxProcNetDevLine {
[INFO] [stdout]     |        ------------------- fields in this struct
[INFO] [stdout] 201 |     iface: String,
[INFO] [stdout]     |     ^^^^^
[INFO] [stdout] 202 |     rx_bytes: u64,
[INFO] [stdout] 203 |     rx_packets: u64,
[INFO] [stdout]     |     ^^^^^^^^^^
[INFO] [stdout] 204 |     rx_errors: u64,
[INFO] [stdout]     |     ^^^^^^^^^
[INFO] [stdout] 205 |     rx_dropped_missed: u64,
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^
[INFO] [stdout] 206 |     rx_fifo_errors: u64,
[INFO] [stdout]     |     ^^^^^^^^^^^^^^
[INFO] [stdout] 207 |     rx_length_over_ctc_frame_errors: u64,
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 208 |     rx_compressed: u64,
[INFO] [stdout]     |     ^^^^^^^^^^^^^
[INFO] [stdout] 209 |     multicast: u64,
[INFO] [stdout]     |     ^^^^^^^^^
[INFO] [stdout] 210 |     tx_bytes: u64,
[INFO] [stdout] 211 |     tx_packets: u64,
[INFO] [stdout]     |     ^^^^^^^^^^
[INFO] [stdout] 212 |     tx_errors: u64,
[INFO] [stdout]     |     ^^^^^^^^^
[INFO] [stdout] 213 |     tx_dropped: u64,
[INFO] [stdout]     |     ^^^^^^^^^^
[INFO] [stdout] 214 |     tx_fifo_errors: u64,
[INFO] [stdout]     |     ^^^^^^^^^^^^^^
[INFO] [stdout] 215 |     collisions: u64,
[INFO] [stdout]     |     ^^^^^^^^^^
[INFO] [stdout] 216 |     tx_carrier_aborted_window_heartbeat_errors: u64,
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 217 |     tx_compressed: u64,
[INFO] [stdout]     |     ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `LinuxProcNetDevLine` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout]     = note: `#[warn(dead_code)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: 5 warnings emitted
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 13.37s
[INFO] running `Command { std: "docker" "inspect" "154f860e7f09d842b0d766de98b3144b3eb3cfd07b002b6f7b0f9100db908898", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "154f860e7f09d842b0d766de98b3144b3eb3cfd07b002b6f7b0f9100db908898", kill_on_drop: false }`
[INFO] [stdout] 154f860e7f09d842b0d766de98b3144b3eb3cfd07b002b6f7b0f9100db908898
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "RUSTDOCFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:5ff2268d62e97bff2cde7d5815dd6ed5b47097566f13b8d0ca110b04b60e07ed" "/opt/rustwide/cargo-home/bin/cargo" "+1.69.0" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 65d395845eb3d0629f6c6a5c5d27e730add2194971b638e16599b240d26b9aeb
[INFO] running `Command { std: "docker" "start" "-a" "65d395845eb3d0629f6c6a5c5d27e730add2194971b638e16599b240d26b9aeb", kill_on_drop: false }`
[INFO] [stderr]    Compiling diffmetrik v0.3.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unnecessary braces around method argument
[INFO] [stdout]    --> src/metrics/network.rs:260:14
[INFO] [stdout]     |
[INFO] [stdout] 260 |         .map({ |line| LinuxProcNetDevLine::new(line) })
[INFO] [stdout]     |              ^^                                     ^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_braces)]` on by default
[INFO] [stdout] help: remove these braces
[INFO] [stdout]     |
[INFO] [stdout] 260 -         .map({ |line| LinuxProcNetDevLine::new(line) })
[INFO] [stdout] 260 +         .map(|line| LinuxProcNetDevLine::new(line))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary braces around method argument
[INFO] [stdout]    --> src/metrics/network.rs:259:17
[INFO] [stdout]     |
[INFO] [stdout] 259 |         .filter({ |line| line.starts_with("eth") })
[INFO] [stdout]     |                 ^^                              ^^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these braces
[INFO] [stdout]     |
[INFO] [stdout] 259 -         .filter({ |line| line.starts_with("eth") })
[INFO] [stdout] 259 +         .filter(|line| line.starts_with("eth"))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary braces around method argument
[INFO] [stdout]    --> src/metrics/network.rs:258:14
[INFO] [stdout]     |
[INFO] [stdout] 258 |         .map({ |line| line.trim() })
[INFO] [stdout]     |              ^^                  ^^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these braces
[INFO] [stdout]     |
[INFO] [stdout] 258 -         .map({ |line| line.trim() })
[INFO] [stdout] 258 +         .map(|line| line.trim())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary braces around method argument
[INFO] [stdout]   --> src/metrics/mod.rs:63:38
[INFO] [stdout]    |
[INFO] [stdout] 63 |         metrics.sort_unstable_by_key({ |a| a.time });
[INFO] [stdout]    |                                      ^^          ^^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these braces
[INFO] [stdout]    |
[INFO] [stdout] 63 -         metrics.sort_unstable_by_key({ |a| a.time });
[INFO] [stdout] 63 +         metrics.sort_unstable_by_key(|a| a.time);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: multiple fields are never read
[INFO] [stdout]    --> src/metrics/network.rs:201:5
[INFO] [stdout]     |
[INFO] [stdout] 200 | struct LinuxProcNetDevLine {
[INFO] [stdout]     |        ------------------- fields in this struct
[INFO] [stdout] 201 |     iface: String,
[INFO] [stdout]     |     ^^^^^
[INFO] [stdout] 202 |     rx_bytes: u64,
[INFO] [stdout] 203 |     rx_packets: u64,
[INFO] [stdout]     |     ^^^^^^^^^^
[INFO] [stdout] 204 |     rx_errors: u64,
[INFO] [stdout]     |     ^^^^^^^^^
[INFO] [stdout] 205 |     rx_dropped_missed: u64,
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^
[INFO] [stdout] 206 |     rx_fifo_errors: u64,
[INFO] [stdout]     |     ^^^^^^^^^^^^^^
[INFO] [stdout] 207 |     rx_length_over_ctc_frame_errors: u64,
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 208 |     rx_compressed: u64,
[INFO] [stdout]     |     ^^^^^^^^^^^^^
[INFO] [stdout] 209 |     multicast: u64,
[INFO] [stdout]     |     ^^^^^^^^^
[INFO] [stdout] 210 |     tx_bytes: u64,
[INFO] [stdout] 211 |     tx_packets: u64,
[INFO] [stdout]     |     ^^^^^^^^^^
[INFO] [stdout] 212 |     tx_errors: u64,
[INFO] [stdout]     |     ^^^^^^^^^
[INFO] [stdout] 213 |     tx_dropped: u64,
[INFO] [stdout]     |     ^^^^^^^^^^
[INFO] [stdout] 214 |     tx_fifo_errors: u64,
[INFO] [stdout]     |     ^^^^^^^^^^^^^^
[INFO] [stdout] 215 |     collisions: u64,
[INFO] [stdout]     |     ^^^^^^^^^^
[INFO] [stdout] 216 |     tx_carrier_aborted_window_heartbeat_errors: u64,
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 217 |     tx_compressed: u64,
[INFO] [stdout]     |     ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `LinuxProcNetDevLine` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout]     = note: `#[warn(dead_code)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: panic message is not a string literal
[INFO] [stdout]    --> src/storage/mod.rs:226:38
[INFO] [stdout]     |
[INFO] [stdout] 226 |             Err(e) => assert!(false, format!("error resetting file: {}", e)),
[INFO] [stdout]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021
[INFO] [stdout]     = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
[INFO] [stdout]     = note: the `assert!()` macro supports formatting, so there's no need for the `format!()` macro here
[INFO] [stdout]     = note: `#[warn(non_fmt_panics)]` on by default
[INFO] [stdout] help: remove the `format!(..)` macro call
[INFO] [stdout]     |
[INFO] [stdout] 226 -             Err(e) => assert!(false, format!("error resetting file: {}", e)),
[INFO] [stdout] 226 +             Err(e) => assert!(false, "error resetting file: {}", e),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: panic message is not a string literal
[INFO] [stdout]    --> src/storage/mod.rs:249:38
[INFO] [stdout]     |
[INFO] [stdout] 249 |             Err(e) => assert!(false, format!("writing failed with {}", e)),
[INFO] [stdout]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021
[INFO] [stdout]     = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
[INFO] [stdout]     = note: the `assert!()` macro supports formatting, so there's no need for the `format!()` macro here
[INFO] [stdout] help: remove the `format!(..)` macro call
[INFO] [stdout]     |
[INFO] [stdout] 249 -             Err(e) => assert!(false, format!("writing failed with {}", e)),
[INFO] [stdout] 249 +             Err(e) => assert!(false, "writing failed with {}", e),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: panic message is not a string literal
[INFO] [stdout]    --> src/storage/mod.rs:296:38
[INFO] [stdout]     |
[INFO] [stdout] 296 |             Err(e) => assert!(false, format!("error reading: {}", e)),
[INFO] [stdout]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021
[INFO] [stdout]     = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
[INFO] [stdout]     = note: the `assert!()` macro supports formatting, so there's no need for the `format!()` macro here
[INFO] [stdout] help: remove the `format!(..)` macro call
[INFO] [stdout]     |
[INFO] [stdout] 296 -             Err(e) => assert!(false, format!("error reading: {}", e)),
[INFO] [stdout] 296 +             Err(e) => assert!(false, "error reading: {}", e),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: 8 warnings emitted
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished test [unoptimized + debuginfo] target(s) in 1.01s
[INFO] running `Command { std: "docker" "inspect" "65d395845eb3d0629f6c6a5c5d27e730add2194971b638e16599b240d26b9aeb", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "65d395845eb3d0629f6c6a5c5d27e730add2194971b638e16599b240d26b9aeb", kill_on_drop: false }`
[INFO] [stdout] 65d395845eb3d0629f6c6a5c5d27e730add2194971b638e16599b240d26b9aeb
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "RUSTDOCFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:5ff2268d62e97bff2cde7d5815dd6ed5b47097566f13b8d0ca110b04b60e07ed" "/opt/rustwide/cargo-home/bin/cargo" "+1.69.0" "test" "--frozen", kill_on_drop: false }`
[INFO] [stdout] de2d316321c2c461d3ed263651ac82c758da54d14b0cb7151ce24732694f1a46
[INFO] running `Command { std: "docker" "start" "-a" "de2d316321c2c461d3ed263651ac82c758da54d14b0cb7151ce24732694f1a46", kill_on_drop: false }`
[INFO] [stderr] warning: unnecessary braces around method argument
[INFO] [stderr]    --> src/metrics/network.rs:260:14
[INFO] [stderr]     |
[INFO] [stderr] 260 |         .map({ |line| LinuxProcNetDevLine::new(line) })
[INFO] [stderr]     |              ^^                                     ^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: `#[warn(unused_braces)]` on by default
[INFO] [stderr] help: remove these braces
[INFO] [stderr]     |
[INFO] [stderr] 260 -         .map({ |line| LinuxProcNetDevLine::new(line) })
[INFO] [stderr] 260 +         .map(|line| LinuxProcNetDevLine::new(line))
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary braces around method argument
[INFO] [stderr]    --> src/metrics/network.rs:259:17
[INFO] [stderr]     |
[INFO] [stderr] 259 |         .filter({ |line| line.starts_with("eth") })
[INFO] [stderr]     |                 ^^                              ^^
[INFO] [stderr]     |
[INFO] [stderr] help: remove these braces
[INFO] [stderr]     |
[INFO] [stderr] 259 -         .filter({ |line| line.starts_with("eth") })
[INFO] [stderr] 259 +         .filter(|line| line.starts_with("eth"))
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary braces around method argument
[INFO] [stderr]    --> src/metrics/network.rs:258:14
[INFO] [stderr]     |
[INFO] [stderr] 258 |         .map({ |line| line.trim() })
[INFO] [stderr]     |              ^^                  ^^
[INFO] [stderr]     |
[INFO] [stderr] help: remove these braces
[INFO] [stderr]     |
[INFO] [stderr] 258 -         .map({ |line| line.trim() })
[INFO] [stderr] 258 +         .map(|line| line.trim())
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary braces around method argument
[INFO] [stderr]   --> src/metrics/mod.rs:63:38
[INFO] [stderr]    |
[INFO] [stderr] 63 |         metrics.sort_unstable_by_key({ |a| a.time });
[INFO] [stderr]    |                                      ^^          ^^
[INFO] [stderr]    |
[INFO] [stderr] help: remove these braces
[INFO] [stderr]    |
[INFO] [stderr] 63 -         metrics.sort_unstable_by_key({ |a| a.time });
[INFO] [stderr] 63 +         metrics.sort_unstable_by_key(|a| a.time);
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: multiple fields are never read
[INFO] [stderr]    --> src/metrics/network.rs:201:5
[INFO] [stderr]     |
[INFO] [stderr] 200 | struct LinuxProcNetDevLine {
[INFO] [stderr]     |        ------------------- fields in this struct
[INFO] [stderr] 201 |     iface: String,
[INFO] [stderr]     |     ^^^^^
[INFO] [stderr] 202 |     rx_bytes: u64,
[INFO] [stderr] 203 |     rx_packets: u64,
[INFO] [stderr]     |     ^^^^^^^^^^
[INFO] [stderr] 204 |     rx_errors: u64,
[INFO] [stderr]     |     ^^^^^^^^^
[INFO] [stderr] 205 |     rx_dropped_missed: u64,
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 206 |     rx_fifo_errors: u64,
[INFO] [stderr]     |     ^^^^^^^^^^^^^^
[INFO] [stderr] 207 |     rx_length_over_ctc_frame_errors: u64,
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 208 |     rx_compressed: u64,
[INFO] [stderr]     |     ^^^^^^^^^^^^^
[INFO] [stderr] 209 |     multicast: u64,
[INFO] [stderr]     |     ^^^^^^^^^
[INFO] [stderr] 210 |     tx_bytes: u64,
[INFO] [stderr] 211 |     tx_packets: u64,
[INFO] [stderr]     |     ^^^^^^^^^^
[INFO] [stderr] 212 |     tx_errors: u64,
[INFO] [stderr]     |     ^^^^^^^^^
[INFO] [stderr] 213 |     tx_dropped: u64,
[INFO] [stderr]     |     ^^^^^^^^^^
[INFO] [stderr] 214 |     tx_fifo_errors: u64,
[INFO] [stderr]     |     ^^^^^^^^^^^^^^
[INFO] [stderr] 215 |     collisions: u64,
[INFO] [stderr]     |     ^^^^^^^^^^
[INFO] [stderr] 216 |     tx_carrier_aborted_window_heartbeat_errors: u64,
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 217 |     tx_compressed: u64,
[INFO] [stderr]     |     ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: `LinuxProcNetDevLine` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stderr]     = note: `#[warn(dead_code)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: panic message is not a string literal
[INFO] [stderr]    --> src/storage/mod.rs:226:38
[INFO] [stderr]     |
[INFO] [stderr] 226 |             Err(e) => assert!(false, format!("error resetting file: {}", e)),
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021
[INFO] [stderr]     = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
[INFO] [stderr]     = note: the `assert!()` macro supports formatting, so there's no need for the `format!()` macro here
[INFO] [stderr]     = note: `#[warn(non_fmt_panics)]` on by default
[INFO] [stderr] help: remove the `format!(..)` macro call
[INFO] [stderr]     |
[INFO] [stderr] 226 -             Err(e) => assert!(false, format!("error resetting file: {}", e)),
[INFO] [stderr] 226 +             Err(e) => assert!(false, "error resetting file: {}", e),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: panic message is not a string literal
[INFO] [stderr]    --> src/storage/mod.rs:249:38
[INFO] [stderr]     |
[INFO] [stderr] 249 |             Err(e) => assert!(false, format!("writing failed with {}", e)),
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021
[INFO] [stderr]     = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
[INFO] [stderr]     = note: the `assert!()` macro supports formatting, so there's no need for the `format!()` macro here
[INFO] [stderr] help: remove the `format!(..)` macro call
[INFO] [stderr]     |
[INFO] [stderr] 249 -             Err(e) => assert!(false, format!("writing failed with {}", e)),
[INFO] [stderr] 249 +             Err(e) => assert!(false, "writing failed with {}", e),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: panic message is not a string literal
[INFO] [stderr]    --> src/storage/mod.rs:296:38
[INFO] [stderr]     |
[INFO] [stderr] 296 |             Err(e) => assert!(false, format!("error reading: {}", e)),
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021
[INFO] [stderr]     = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
[INFO] [stderr]     = note: the `assert!()` macro supports formatting, so there's no need for the `format!()` macro here
[INFO] [stderr] help: remove the `format!(..)` macro call
[INFO] [stderr]     |
[INFO] [stderr] 296 -             Err(e) => assert!(false, format!("error reading: {}", e)),
[INFO] [stderr] 296 +             Err(e) => assert!(false, "error reading: {}", e),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: `diffmetrik` (bin "diffmetrik" test) generated 8 warnings (run `cargo fix --bin "diffmetrik" --tests` to apply 7 suggestions)
[INFO] [stderr]     Finished test [unoptimized + debuginfo] target(s) in 0.03s
[INFO] [stderr]      Running unittests src/main.rs (/opt/rustwide/target/debug/deps/diffmetrik-53c19a752247e9e7)
[INFO] [stdout] 
[INFO] [stdout] running 7 tests
[INFO] [stdout] test metrics::network::tests::test_formatter ... ok
[INFO] [stdout] test metrics::network::tests::test_linux ... ok
[INFO] [stdout] test storage::tests::file_reset ... ok
[INFO] [stdout] test storage::tests::file_read ... ok
[INFO] [stdout] test storage::tests::file_write_len ... ok
[INFO] [stdout] test storage::tests::file_write ... ok
[INFO] [stdout] test storage::tests::path_set_correctly ... ok
[INFO] [stdout] 
[INFO] [stdout] test result: ok. 7 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
[INFO] [stdout] 
[INFO] running `Command { std: "docker" "inspect" "de2d316321c2c461d3ed263651ac82c758da54d14b0cb7151ce24732694f1a46", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "de2d316321c2c461d3ed263651ac82c758da54d14b0cb7151ce24732694f1a46", kill_on_drop: false }`
[INFO] [stdout] de2d316321c2c461d3ed263651ac82c758da54d14b0cb7151ce24732694f1a46
