[INFO] fetching crate raster-retrace 0.1.2... [INFO] testing raster-retrace-0.1.2 against beta-2022-04-10 for beta-1.61-1 [INFO] extracting crate raster-retrace 0.1.2 into /workspace/builds/worker-8/source [INFO] validating manifest of crates.io crate raster-retrace 0.1.2 on toolchain beta-2022-04-10 [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+beta-2022-04-10" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate raster-retrace 0.1.2 [INFO] finished tweaking crates.io crate raster-retrace 0.1.2 [INFO] tweaked toml for crates.io crate raster-retrace 0.1.2 written to /workspace/builds/worker-8/source/Cargo.toml [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+beta-2022-04-10" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update", kill_on_drop: false }` [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+beta-2022-04-10" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:b0c94ce3c1162fcb8e57cac5b65ec2f72eabb1eebea4fcc35e269e823f681646" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2022-04-10" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9a6422130e6294817299ce3d5ff45f9b263b37dab36c0191f17257855ae81165 [INFO] running `Command { std: "docker" "start" "-a" "9a6422130e6294817299ce3d5ff45f9b263b37dab36c0191f17257855ae81165", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9a6422130e6294817299ce3d5ff45f9b263b37dab36c0191f17257855ae81165", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9a6422130e6294817299ce3d5ff45f9b263b37dab36c0191f17257855ae81165", kill_on_drop: false }` [INFO] [stdout] 9a6422130e6294817299ce3d5ff45f9b263b37dab36c0191f17257855ae81165 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:b0c94ce3c1162fcb8e57cac5b65ec2f72eabb1eebea4fcc35e269e823f681646" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2022-04-10" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6d1a660833e35305594ba5798a9d3a2a57d72696dea670a27f2ed864345b1e8d [INFO] running `Command { std: "docker" "start" "-a" "6d1a660833e35305594ba5798a9d3a2a57d72696dea670a27f2ed864345b1e8d", kill_on_drop: false }` [INFO] [stderr] Compiling raster-retrace v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/intern/argparse/mod.rs:5:34 [INFO] [stdout] | [INFO] [stdout] 5 | pub const ARGDEF_REQUIRED: u32 = (1 << 0); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 5 - pub const ARGDEF_REQUIRED: u32 = (1 << 0); [INFO] [stdout] 5 + pub const ARGDEF_REQUIRED: u32 = 1 << 0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/intern/argparse/mod.rs:6:34 [INFO] [stdout] | [INFO] [stdout] 6 | pub const ARGDEF_VARARGS: u32 = (1 << 1); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 6 - pub const ARGDEF_VARARGS: u32 = (1 << 1); [INFO] [stdout] 6 + pub const ARGDEF_VARARGS: u32 = 1 << 1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/intern/min_heap/mod.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | ((i - 1) >> 1) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 76 - ((i - 1) >> 1) [INFO] [stdout] 76 + (i - 1) >> 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/intern/min_heap/mod.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | ((i << 1) + 1) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 79 - ((i << 1) + 1) [INFO] [stdout] 79 + (i << 1) + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/intern/min_heap/mod.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | ((i << 1) + 2) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 82 - ((i << 1) + 2) [INFO] [stdout] 82 + (i << 1) + 2 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/intern/min_heap/mod.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | (a.value < b.value) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 96 - (a.value < b.value) [INFO] [stdout] 96 + a.value < b.value [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_outline.rs:45:27 [INFO] [stdout] | [INFO] [stdout] 45 | pub const L: u8 = (1 << 0); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 45 - pub const L: u8 = (1 << 0); [INFO] [stdout] 45 + pub const L: u8 = 1 << 0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_outline.rs:46:27 [INFO] [stdout] | [INFO] [stdout] 46 | pub const R: u8 = (1 << 1); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 46 - pub const R: u8 = (1 << 1); [INFO] [stdout] 46 + pub const R: u8 = 1 << 1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_outline.rs:47:27 [INFO] [stdout] | [INFO] [stdout] 47 | pub const D: u8 = (1 << 2); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 47 - pub const D: u8 = (1 << 2); [INFO] [stdout] 47 + pub const D: u8 = 1 << 2; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_outline.rs:48:27 [INFO] [stdout] | [INFO] [stdout] 48 | pub const U: u8 = (1 << 3); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 48 - pub const U: u8 = (1 << 3); [INFO] [stdout] 48 + pub const U: u8 = 1 << 3; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/polys_from_raster_outline.rs:149:29 [INFO] [stdout] | [INFO] [stdout] 149 | ... ((x == xy_a[0] && x == xy_b[0]) || [INFO] [stdout] | ^ [INFO] [stdout] 150 | ... (y == xy_a[1] && y == xy_b[1])) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 149 ~ (x == xy_a[0] && x == xy_b[0]) || [INFO] [stdout] 150 ~ (y == xy_a[1] && y == xy_b[1]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:21:27 [INFO] [stdout] | [INFO] [stdout] 21 | pub const L: u8 = (1 << 0); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 21 - pub const L: u8 = (1 << 0); [INFO] [stdout] 21 + pub const L: u8 = 1 << 0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:22:27 [INFO] [stdout] | [INFO] [stdout] 22 | pub const R: u8 = (1 << 1); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 22 - pub const R: u8 = (1 << 1); [INFO] [stdout] 22 + pub const R: u8 = 1 << 1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:23:27 [INFO] [stdout] | [INFO] [stdout] 23 | pub const D: u8 = (1 << 2); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 23 - pub const D: u8 = (1 << 2); [INFO] [stdout] 23 + pub const D: u8 = 1 << 2; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:24:27 [INFO] [stdout] | [INFO] [stdout] 24 | pub const U: u8 = (1 << 3); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 24 - pub const U: u8 = (1 << 3); [INFO] [stdout] 24 + pub const U: u8 = 1 << 3; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:26:28 [INFO] [stdout] | [INFO] [stdout] 26 | pub const LD: u8 = (1 << 4); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 26 - pub const LD: u8 = (1 << 4); [INFO] [stdout] 26 + pub const LD: u8 = 1 << 4; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:27:28 [INFO] [stdout] | [INFO] [stdout] 27 | pub const LU: u8 = (1 << 5); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 27 - pub const LU: u8 = (1 << 5); [INFO] [stdout] 27 + pub const LU: u8 = 1 << 5; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:28:28 [INFO] [stdout] | [INFO] [stdout] 28 | pub const RD: u8 = (1 << 6); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 28 - pub const RD: u8 = (1 << 6); [INFO] [stdout] 28 + pub const RD: u8 = 1 << 6; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:29:28 [INFO] [stdout] | [INFO] [stdout] 29 | pub const RU: u8 = (1 << 7); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 29 - pub const RU: u8 = (1 << 7); [INFO] [stdout] 29 + pub const RU: u8 = 1 << 7; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:192:29 [INFO] [stdout] | [INFO] [stdout] 192 | / ... ( [INFO] [stdout] 193 | | ... // axis aligned [INFO] [stdout] 194 | | ... (x == xy_a[0] && x == xy_b[0]) || [INFO] [stdout] | |__________________________^ [INFO] [stdout] ... [INFO] [stdout] 212 | ... } [INFO] [stdout] | ____________________________^ [INFO] [stdout] 213 | | ... ) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 192 ~ (x == xy_a[0] && x == xy_b[0]) || [INFO] [stdout] 193 | (y == xy_a[1] && y == xy_b[1]) || [INFO] [stdout] 194 | // diagonal [INFO] [stdout] 195 | { [INFO] [stdout] 196 | let x_a_delta = xy_a[0] - xy_b[0]; [INFO] [stdout] 197 | let y_a_delta = xy_a[1] - xy_b[1]; [INFO] [stdout] ... [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:203:37 [INFO] [stdout] | [INFO] [stdout] 203 | ... (x_a_delta != 0 && y_a_delta != 0 && [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 211 | ... y_a_delta.signum() == y_b_delta.signum()) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 203 ~ x_a_delta != 0 && y_a_delta != 0 && [INFO] [stdout] 204 | // no need to check 'b', signum accounts for that case. [INFO] [stdout] 205 | [INFO] [stdout] 206 | x_a_delta.abs() == y_a_delta.abs() && [INFO] [stdout] 207 | x_b_delta.abs() == y_b_delta.abs() && [INFO] [stdout] 208 | [INFO] [stdout] ... [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:218:37 [INFO] [stdout] | [INFO] [stdout] 218 | if neighbors & DIR_S != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 218 - if neighbors & DIR_S != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] 218 + if neighbors & DIR_S != 0 { 1 << 4 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:219:37 [INFO] [stdout] | [INFO] [stdout] 219 | if neighbors & DIR_E != 0 { (1 << 1) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 219 - if neighbors & DIR_E != 0 { (1 << 1) } else { 0 } | [INFO] [stdout] 219 + if neighbors & DIR_E != 0 { 1 << 1 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:226:37 [INFO] [stdout] | [INFO] [stdout] 226 | if neighbors & DIR_W != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 226 - if neighbors & DIR_W != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] 226 + if neighbors & DIR_W != 0 { 1 << 4 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:227:37 [INFO] [stdout] | [INFO] [stdout] 227 | if neighbors & DIR_S != 0 { (1 << 2) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 227 - if neighbors & DIR_S != 0 { (1 << 2) } else { 0 } | [INFO] [stdout] 227 + if neighbors & DIR_S != 0 { 1 << 2 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:234:37 [INFO] [stdout] | [INFO] [stdout] 234 | if neighbors & DIR_N != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 234 - if neighbors & DIR_N != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] 234 + if neighbors & DIR_N != 0 { 1 << 4 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:235:37 [INFO] [stdout] | [INFO] [stdout] 235 | if neighbors & DIR_E != 0 { (1 << 1) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 235 - if neighbors & DIR_E != 0 { (1 << 1) } else { 0 } | [INFO] [stdout] 235 + if neighbors & DIR_E != 0 { 1 << 1 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:242:37 [INFO] [stdout] | [INFO] [stdout] 242 | if neighbors & DIR_N != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 242 - if neighbors & DIR_N != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] 242 + if neighbors & DIR_N != 0 { 1 << 4 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:243:37 [INFO] [stdout] | [INFO] [stdout] 243 | if neighbors & DIR_W != 0 { (1 << 2) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 243 - if neighbors & DIR_W != 0 { (1 << 2) } else { 0 } | [INFO] [stdout] 243 + if neighbors & DIR_W != 0 { 1 << 2 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Write` is imported redundantly [INFO] [stdout] --> src/curve_write.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 14 | use std::io::prelude::Write; [INFO] [stdout] | ----------------------- the item `Write` is already imported here [INFO] [stdout] ... [INFO] [stdout] 45 | use std::io::prelude::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Write` is imported redundantly [INFO] [stdout] --> src/curve_write.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 14 | use std::io::prelude::Write; [INFO] [stdout] | ----------------------- the item `Write` is already imported here [INFO] [stdout] ... [INFO] [stdout] 83 | use std::io::prelude::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Write` is imported redundantly [INFO] [stdout] --> src/curve_write.rs:192:13 [INFO] [stdout] | [INFO] [stdout] 14 | use std::io::prelude::Write; [INFO] [stdout] | ----------------------- the item `Write` is already imported here [INFO] [stdout] ... [INFO] [stdout] 192 | use std::io::prelude::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Write` is imported redundantly [INFO] [stdout] --> src/curve_write.rs:256:13 [INFO] [stdout] | [INFO] [stdout] 14 | use std::io::prelude::Write; [INFO] [stdout] | ----------------------- the item `Write` is already imported here [INFO] [stdout] ... [INFO] [stdout] 256 | use std::io::prelude::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Write` is imported redundantly [INFO] [stdout] --> src/curve_write.rs:355:13 [INFO] [stdout] | [INFO] [stdout] 14 | use std::io::prelude::Write; [INFO] [stdout] | ----------------------- the item `Write` is already imported here [INFO] [stdout] ... [INFO] [stdout] 355 | use std::io::prelude::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `polys_from_raster_centerline` is imported redundantly [INFO] [stdout] --> src/main.rs:96:21 [INFO] [stdout] | [INFO] [stdout] 13 | mod polys_from_raster_centerline; [INFO] [stdout] | --------------------------------- the item `polys_from_raster_centerline` is already defined here [INFO] [stdout] ... [INFO] [stdout] 96 | use polys_from_raster_centerline; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `image_skeletonize` is imported redundantly [INFO] [stdout] --> src/main.rs:541:21 [INFO] [stdout] | [INFO] [stdout] 17 | mod image_skeletonize; [INFO] [stdout] | ---------------------- the item `image_skeletonize` is already defined here [INFO] [stdout] ... [INFO] [stdout] 541 | use image_skeletonize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/intern/argparse/mod.rs:29:19 [INFO] [stdout] | [INFO] [stdout] 29 | callback: Box Result>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 29 - callback: Box Result>, [INFO] [stdout] 29 + callback: Box Result>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/intern/argparse/mod.rs:87:23 [INFO] [stdout] | [INFO] [stdout] 87 | callback: Box Result>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 87 - callback: Box Result>, [INFO] [stdout] 87 + callback: Box Result>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 38 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.43s [INFO] running `Command { std: "docker" "inspect" "6d1a660833e35305594ba5798a9d3a2a57d72696dea670a27f2ed864345b1e8d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6d1a660833e35305594ba5798a9d3a2a57d72696dea670a27f2ed864345b1e8d", kill_on_drop: false }` [INFO] [stdout] 6d1a660833e35305594ba5798a9d3a2a57d72696dea670a27f2ed864345b1e8d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:b0c94ce3c1162fcb8e57cac5b65ec2f72eabb1eebea4fcc35e269e823f681646" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2022-04-10" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f74e4f6d64b607cd619387d1c04544c87350e3afe9a255770f56e71b6338bbe8 [INFO] running `Command { std: "docker" "start" "-a" "f74e4f6d64b607cd619387d1c04544c87350e3afe9a255770f56e71b6338bbe8", kill_on_drop: false }` [INFO] [stderr] Compiling raster-retrace v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/intern/argparse/mod.rs:5:34 [INFO] [stdout] | [INFO] [stdout] 5 | pub const ARGDEF_REQUIRED: u32 = (1 << 0); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 5 - pub const ARGDEF_REQUIRED: u32 = (1 << 0); [INFO] [stdout] 5 + pub const ARGDEF_REQUIRED: u32 = 1 << 0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/intern/argparse/mod.rs:6:34 [INFO] [stdout] | [INFO] [stdout] 6 | pub const ARGDEF_VARARGS: u32 = (1 << 1); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 6 - pub const ARGDEF_VARARGS: u32 = (1 << 1); [INFO] [stdout] 6 + pub const ARGDEF_VARARGS: u32 = 1 << 1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/intern/min_heap/mod.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | ((i - 1) >> 1) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 76 - ((i - 1) >> 1) [INFO] [stdout] 76 + (i - 1) >> 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/intern/min_heap/mod.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | ((i << 1) + 1) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 79 - ((i << 1) + 1) [INFO] [stdout] 79 + (i << 1) + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/intern/min_heap/mod.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | ((i << 1) + 2) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 82 - ((i << 1) + 2) [INFO] [stdout] 82 + (i << 1) + 2 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/intern/min_heap/mod.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | (a.value < b.value) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 96 - (a.value < b.value) [INFO] [stdout] 96 + a.value < b.value [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_outline.rs:45:27 [INFO] [stdout] | [INFO] [stdout] 45 | pub const L: u8 = (1 << 0); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 45 - pub const L: u8 = (1 << 0); [INFO] [stdout] 45 + pub const L: u8 = 1 << 0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_outline.rs:46:27 [INFO] [stdout] | [INFO] [stdout] 46 | pub const R: u8 = (1 << 1); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 46 - pub const R: u8 = (1 << 1); [INFO] [stdout] 46 + pub const R: u8 = 1 << 1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_outline.rs:47:27 [INFO] [stdout] | [INFO] [stdout] 47 | pub const D: u8 = (1 << 2); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 47 - pub const D: u8 = (1 << 2); [INFO] [stdout] 47 + pub const D: u8 = 1 << 2; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_outline.rs:48:27 [INFO] [stdout] | [INFO] [stdout] 48 | pub const U: u8 = (1 << 3); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 48 - pub const U: u8 = (1 << 3); [INFO] [stdout] 48 + pub const U: u8 = 1 << 3; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/polys_from_raster_outline.rs:149:29 [INFO] [stdout] | [INFO] [stdout] 149 | ... ((x == xy_a[0] && x == xy_b[0]) || [INFO] [stdout] | ^ [INFO] [stdout] 150 | ... (y == xy_a[1] && y == xy_b[1])) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 149 ~ (x == xy_a[0] && x == xy_b[0]) || [INFO] [stdout] 150 ~ (y == xy_a[1] && y == xy_b[1]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:21:27 [INFO] [stdout] | [INFO] [stdout] 21 | pub const L: u8 = (1 << 0); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 21 - pub const L: u8 = (1 << 0); [INFO] [stdout] 21 + pub const L: u8 = 1 << 0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:22:27 [INFO] [stdout] | [INFO] [stdout] 22 | pub const R: u8 = (1 << 1); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 22 - pub const R: u8 = (1 << 1); [INFO] [stdout] 22 + pub const R: u8 = 1 << 1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:23:27 [INFO] [stdout] | [INFO] [stdout] 23 | pub const D: u8 = (1 << 2); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 23 - pub const D: u8 = (1 << 2); [INFO] [stdout] 23 + pub const D: u8 = 1 << 2; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:24:27 [INFO] [stdout] | [INFO] [stdout] 24 | pub const U: u8 = (1 << 3); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 24 - pub const U: u8 = (1 << 3); [INFO] [stdout] 24 + pub const U: u8 = 1 << 3; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:26:28 [INFO] [stdout] | [INFO] [stdout] 26 | pub const LD: u8 = (1 << 4); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 26 - pub const LD: u8 = (1 << 4); [INFO] [stdout] 26 + pub const LD: u8 = 1 << 4; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:27:28 [INFO] [stdout] | [INFO] [stdout] 27 | pub const LU: u8 = (1 << 5); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 27 - pub const LU: u8 = (1 << 5); [INFO] [stdout] 27 + pub const LU: u8 = 1 << 5; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:28:28 [INFO] [stdout] | [INFO] [stdout] 28 | pub const RD: u8 = (1 << 6); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 28 - pub const RD: u8 = (1 << 6); [INFO] [stdout] 28 + pub const RD: u8 = 1 << 6; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:29:28 [INFO] [stdout] | [INFO] [stdout] 29 | pub const RU: u8 = (1 << 7); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 29 - pub const RU: u8 = (1 << 7); [INFO] [stdout] 29 + pub const RU: u8 = 1 << 7; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:192:29 [INFO] [stdout] | [INFO] [stdout] 192 | / ... ( [INFO] [stdout] 193 | | ... // axis aligned [INFO] [stdout] 194 | | ... (x == xy_a[0] && x == xy_b[0]) || [INFO] [stdout] | |__________________________^ [INFO] [stdout] ... [INFO] [stdout] 212 | ... } [INFO] [stdout] | ____________________________^ [INFO] [stdout] 213 | | ... ) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 192 ~ (x == xy_a[0] && x == xy_b[0]) || [INFO] [stdout] 193 | (y == xy_a[1] && y == xy_b[1]) || [INFO] [stdout] 194 | // diagonal [INFO] [stdout] 195 | { [INFO] [stdout] 196 | let x_a_delta = xy_a[0] - xy_b[0]; [INFO] [stdout] 197 | let y_a_delta = xy_a[1] - xy_b[1]; [INFO] [stdout] ... [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:203:37 [INFO] [stdout] | [INFO] [stdout] 203 | ... (x_a_delta != 0 && y_a_delta != 0 && [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 211 | ... y_a_delta.signum() == y_b_delta.signum()) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 203 ~ x_a_delta != 0 && y_a_delta != 0 && [INFO] [stdout] 204 | // no need to check 'b', signum accounts for that case. [INFO] [stdout] 205 | [INFO] [stdout] 206 | x_a_delta.abs() == y_a_delta.abs() && [INFO] [stdout] 207 | x_b_delta.abs() == y_b_delta.abs() && [INFO] [stdout] 208 | [INFO] [stdout] ... [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:218:37 [INFO] [stdout] | [INFO] [stdout] 218 | if neighbors & DIR_S != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 218 - if neighbors & DIR_S != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] 218 + if neighbors & DIR_S != 0 { 1 << 4 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:219:37 [INFO] [stdout] | [INFO] [stdout] 219 | if neighbors & DIR_E != 0 { (1 << 1) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 219 - if neighbors & DIR_E != 0 { (1 << 1) } else { 0 } | [INFO] [stdout] 219 + if neighbors & DIR_E != 0 { 1 << 1 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:226:37 [INFO] [stdout] | [INFO] [stdout] 226 | if neighbors & DIR_W != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 226 - if neighbors & DIR_W != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] 226 + if neighbors & DIR_W != 0 { 1 << 4 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:227:37 [INFO] [stdout] | [INFO] [stdout] 227 | if neighbors & DIR_S != 0 { (1 << 2) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 227 - if neighbors & DIR_S != 0 { (1 << 2) } else { 0 } | [INFO] [stdout] 227 + if neighbors & DIR_S != 0 { 1 << 2 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:234:37 [INFO] [stdout] | [INFO] [stdout] 234 | if neighbors & DIR_N != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 234 - if neighbors & DIR_N != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] 234 + if neighbors & DIR_N != 0 { 1 << 4 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:235:37 [INFO] [stdout] | [INFO] [stdout] 235 | if neighbors & DIR_E != 0 { (1 << 1) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 235 - if neighbors & DIR_E != 0 { (1 << 1) } else { 0 } | [INFO] [stdout] 235 + if neighbors & DIR_E != 0 { 1 << 1 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:242:37 [INFO] [stdout] | [INFO] [stdout] 242 | if neighbors & DIR_N != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 242 - if neighbors & DIR_N != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] 242 + if neighbors & DIR_N != 0 { 1 << 4 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:243:37 [INFO] [stdout] | [INFO] [stdout] 243 | if neighbors & DIR_W != 0 { (1 << 2) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 243 - if neighbors & DIR_W != 0 { (1 << 2) } else { 0 } | [INFO] [stdout] 243 + if neighbors & DIR_W != 0 { 1 << 2 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Write` is imported redundantly [INFO] [stdout] --> src/curve_write.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 14 | use std::io::prelude::Write; [INFO] [stdout] | ----------------------- the item `Write` is already imported here [INFO] [stdout] ... [INFO] [stdout] 45 | use std::io::prelude::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Write` is imported redundantly [INFO] [stdout] --> src/curve_write.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 14 | use std::io::prelude::Write; [INFO] [stdout] | ----------------------- the item `Write` is already imported here [INFO] [stdout] ... [INFO] [stdout] 83 | use std::io::prelude::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Write` is imported redundantly [INFO] [stdout] --> src/curve_write.rs:192:13 [INFO] [stdout] | [INFO] [stdout] 14 | use std::io::prelude::Write; [INFO] [stdout] | ----------------------- the item `Write` is already imported here [INFO] [stdout] ... [INFO] [stdout] 192 | use std::io::prelude::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Write` is imported redundantly [INFO] [stdout] --> src/curve_write.rs:256:13 [INFO] [stdout] | [INFO] [stdout] 14 | use std::io::prelude::Write; [INFO] [stdout] | ----------------------- the item `Write` is already imported here [INFO] [stdout] ... [INFO] [stdout] 256 | use std::io::prelude::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Write` is imported redundantly [INFO] [stdout] --> src/curve_write.rs:355:13 [INFO] [stdout] | [INFO] [stdout] 14 | use std::io::prelude::Write; [INFO] [stdout] | ----------------------- the item `Write` is already imported here [INFO] [stdout] ... [INFO] [stdout] 355 | use std::io::prelude::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `polys_from_raster_centerline` is imported redundantly [INFO] [stdout] --> src/main.rs:96:21 [INFO] [stdout] | [INFO] [stdout] 13 | mod polys_from_raster_centerline; [INFO] [stdout] | --------------------------------- the item `polys_from_raster_centerline` is already defined here [INFO] [stdout] ... [INFO] [stdout] 96 | use polys_from_raster_centerline; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `image_skeletonize` is imported redundantly [INFO] [stdout] --> src/main.rs:541:21 [INFO] [stdout] | [INFO] [stdout] 17 | mod image_skeletonize; [INFO] [stdout] | ---------------------- the item `image_skeletonize` is already defined here [INFO] [stdout] ... [INFO] [stdout] 541 | use image_skeletonize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/intern/argparse/mod.rs:29:19 [INFO] [stdout] | [INFO] [stdout] 29 | callback: Box Result>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 29 - callback: Box Result>, [INFO] [stdout] 29 + callback: Box Result>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/intern/argparse/mod.rs:87:23 [INFO] [stdout] | [INFO] [stdout] 87 | callback: Box Result>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 87 - callback: Box Result>, [INFO] [stdout] 87 + callback: Box Result>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 38 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 2.15s [INFO] [stderr] Executable unittests src/main.rs (/opt/rustwide/target/debug/deps/raster_retrace-47292730943f1f15) [INFO] running `Command { std: "docker" "inspect" "f74e4f6d64b607cd619387d1c04544c87350e3afe9a255770f56e71b6338bbe8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f74e4f6d64b607cd619387d1c04544c87350e3afe9a255770f56e71b6338bbe8", kill_on_drop: false }` [INFO] [stdout] f74e4f6d64b607cd619387d1c04544c87350e3afe9a255770f56e71b6338bbe8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:b0c94ce3c1162fcb8e57cac5b65ec2f72eabb1eebea4fcc35e269e823f681646" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2022-04-10" "test" "--frozen", kill_on_drop: false }` [INFO] [stdout] b8c2b23d6a55688579920e9ac964e6791e228874b3d863970428fdec0ae13aee [INFO] running `Command { std: "docker" "start" "-a" "b8c2b23d6a55688579920e9ac964e6791e228874b3d863970428fdec0ae13aee", kill_on_drop: false }` [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/intern/argparse/mod.rs:5:34 [INFO] [stderr] | [INFO] [stderr] 5 | pub const ARGDEF_REQUIRED: u32 = (1 << 0); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 5 - pub const ARGDEF_REQUIRED: u32 = (1 << 0); [INFO] [stderr] 5 + pub const ARGDEF_REQUIRED: u32 = 1 << 0; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/intern/argparse/mod.rs:6:34 [INFO] [stderr] | [INFO] [stderr] 6 | pub const ARGDEF_VARARGS: u32 = (1 << 1); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 6 - pub const ARGDEF_VARARGS: u32 = (1 << 1); [INFO] [stderr] 6 + pub const ARGDEF_VARARGS: u32 = 1 << 1; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around block return value [INFO] [stderr] --> src/intern/min_heap/mod.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | ((i - 1) >> 1) [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 76 - ((i - 1) >> 1) [INFO] [stderr] 76 + (i - 1) >> 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around block return value [INFO] [stderr] --> src/intern/min_heap/mod.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | ((i << 1) + 1) [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 79 - ((i << 1) + 1) [INFO] [stderr] 79 + (i << 1) + 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around block return value [INFO] [stderr] --> src/intern/min_heap/mod.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | ((i << 1) + 2) [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 82 - ((i << 1) + 2) [INFO] [stderr] 82 + (i << 1) + 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around block return value [INFO] [stderr] --> src/intern/min_heap/mod.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | (a.value < b.value) [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 96 - (a.value < b.value) [INFO] [stderr] 96 + a.value < b.value [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/polys_from_raster_outline.rs:45:27 [INFO] [stderr] | [INFO] [stderr] 45 | pub const L: u8 = (1 << 0); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 45 - pub const L: u8 = (1 << 0); [INFO] [stderr] 45 + pub const L: u8 = 1 << 0; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/polys_from_raster_outline.rs:46:27 [INFO] [stderr] | [INFO] [stderr] 46 | pub const R: u8 = (1 << 1); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 46 - pub const R: u8 = (1 << 1); [INFO] [stderr] 46 + pub const R: u8 = 1 << 1; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/polys_from_raster_outline.rs:47:27 [INFO] [stderr] | [INFO] [stderr] 47 | pub const D: u8 = (1 << 2); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 47 - pub const D: u8 = (1 << 2); [INFO] [stderr] 47 + pub const D: u8 = 1 << 2; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/polys_from_raster_outline.rs:48:27 [INFO] [stderr] | [INFO] [stderr] 48 | pub const U: u8 = (1 << 3); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 48 - pub const U: u8 = (1 << 3); [INFO] [stderr] 48 + pub const U: u8 = 1 << 3; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around block return value [INFO] [stderr] --> src/polys_from_raster_outline.rs:149:29 [INFO] [stderr] | [INFO] [stderr] 149 | ... ((x == xy_a[0] && x == xy_b[0]) || [INFO] [stderr] | ^ [INFO] [stderr] 150 | ... (y == xy_a[1] && y == xy_b[1])) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 149 ~ (x == xy_a[0] && x == xy_b[0]) || [INFO] [stderr] 150 ~ (y == xy_a[1] && y == xy_b[1]) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/polys_from_raster_centerline.rs:21:27 [INFO] [stderr] | [INFO] [stderr] 21 | pub const L: u8 = (1 << 0); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 21 - pub const L: u8 = (1 << 0); [INFO] [stderr] 21 + pub const L: u8 = 1 << 0; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/polys_from_raster_centerline.rs:22:27 [INFO] [stderr] | [INFO] [stderr] 22 | pub const R: u8 = (1 << 1); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 22 - pub const R: u8 = (1 << 1); [INFO] [stderr] 22 + pub const R: u8 = 1 << 1; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/polys_from_raster_centerline.rs:23:27 [INFO] [stderr] | [INFO] [stderr] 23 | pub const D: u8 = (1 << 2); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 23 - pub const D: u8 = (1 << 2); [INFO] [stderr] 23 + pub const D: u8 = 1 << 2; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/polys_from_raster_centerline.rs:24:27 [INFO] [stderr] | [INFO] [stderr] 24 | pub const U: u8 = (1 << 3); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 24 - pub const U: u8 = (1 << 3); [INFO] [stderr] 24 + pub const U: u8 = 1 << 3; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/polys_from_raster_centerline.rs:26:28 [INFO] [stderr] | [INFO] [stderr] 26 | pub const LD: u8 = (1 << 4); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 26 - pub const LD: u8 = (1 << 4); [INFO] [stderr] 26 + pub const LD: u8 = 1 << 4; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/polys_from_raster_centerline.rs:27:28 [INFO] [stderr] | [INFO] [stderr] 27 | pub const LU: u8 = (1 << 5); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 27 - pub const LU: u8 = (1 << 5); [INFO] [stderr] 27 + pub const LU: u8 = 1 << 5; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/polys_from_raster_centerline.rs:28:28 [INFO] [stderr] | [INFO] [stderr] 28 | pub const RD: u8 = (1 << 6); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 28 - pub const RD: u8 = (1 << 6); [INFO] [stderr] 28 + pub const RD: u8 = 1 << 6; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/polys_from_raster_centerline.rs:29:28 [INFO] [stderr] | [INFO] [stderr] 29 | pub const RU: u8 = (1 << 7); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 29 - pub const RU: u8 = (1 << 7); [INFO] [stderr] 29 + pub const RU: u8 = 1 << 7; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around block return value [INFO] [stderr] --> src/polys_from_raster_centerline.rs:192:29 [INFO] [stderr] | [INFO] [stderr] 192 | / ... ( [INFO] [stderr] 193 | | ... // axis aligned [INFO] [stderr] 194 | | ... (x == xy_a[0] && x == xy_b[0]) || [INFO] [stderr] | |__________________________^ [INFO] [stderr] ... [INFO] [stderr] 212 | ... } [INFO] [stderr] | ____________________________^ [INFO] [stderr] 213 | | ... ) [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 192 ~ (x == xy_a[0] && x == xy_b[0]) || [INFO] [stderr] 193 | (y == xy_a[1] && y == xy_b[1]) || [INFO] [stderr] 194 | // diagonal [INFO] [stderr] 195 | { [INFO] [stderr] 196 | let x_a_delta = xy_a[0] - xy_b[0]; [INFO] [stderr] 197 | let y_a_delta = xy_a[1] - xy_b[1]; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around block return value [INFO] [stderr] --> src/polys_from_raster_centerline.rs:203:37 [INFO] [stderr] | [INFO] [stderr] 203 | ... (x_a_delta != 0 && y_a_delta != 0 && [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 211 | ... y_a_delta.signum() == y_b_delta.signum()) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 203 ~ x_a_delta != 0 && y_a_delta != 0 && [INFO] [stderr] 204 | // no need to check 'b', signum accounts for that case. [INFO] [stderr] 205 | [INFO] [stderr] 206 | x_a_delta.abs() == y_a_delta.abs() && [INFO] [stderr] 207 | x_b_delta.abs() == y_b_delta.abs() && [INFO] [stderr] 208 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around block return value [INFO] [stderr] --> src/image_skeletonize.rs:218:37 [INFO] [stderr] | [INFO] [stderr] 218 | if neighbors & DIR_S != 0 { (1 << 4) } else { 0 } | [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 218 - if neighbors & DIR_S != 0 { (1 << 4) } else { 0 } | [INFO] [stderr] 218 + if neighbors & DIR_S != 0 { 1 << 4 } else { 0 } | [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around block return value [INFO] [stderr] --> src/image_skeletonize.rs:219:37 [INFO] [stderr] | [INFO] [stderr] 219 | if neighbors & DIR_E != 0 { (1 << 1) } else { 0 } | [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 219 - if neighbors & DIR_E != 0 { (1 << 1) } else { 0 } | [INFO] [stderr] 219 + if neighbors & DIR_E != 0 { 1 << 1 } else { 0 } | [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around block return value [INFO] [stderr] --> src/image_skeletonize.rs:226:37 [INFO] [stderr] | [INFO] [stderr] 226 | if neighbors & DIR_W != 0 { (1 << 4) } else { 0 } | [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 226 - if neighbors & DIR_W != 0 { (1 << 4) } else { 0 } | [INFO] [stderr] 226 + if neighbors & DIR_W != 0 { 1 << 4 } else { 0 } | [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around block return value [INFO] [stderr] --> src/image_skeletonize.rs:227:37 [INFO] [stderr] | [INFO] [stderr] 227 | if neighbors & DIR_S != 0 { (1 << 2) } else { 0 } | [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 227 - if neighbors & DIR_S != 0 { (1 << 2) } else { 0 } | [INFO] [stderr] 227 + if neighbors & DIR_S != 0 { 1 << 2 } else { 0 } | [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around block return value [INFO] [stderr] --> src/image_skeletonize.rs:234:37 [INFO] [stderr] | [INFO] [stderr] 234 | if neighbors & DIR_N != 0 { (1 << 4) } else { 0 } | [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 234 - if neighbors & DIR_N != 0 { (1 << 4) } else { 0 } | [INFO] [stderr] 234 + if neighbors & DIR_N != 0 { 1 << 4 } else { 0 } | [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around block return value [INFO] [stderr] --> src/image_skeletonize.rs:235:37 [INFO] [stderr] | [INFO] [stderr] 235 | if neighbors & DIR_E != 0 { (1 << 1) } else { 0 } | [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 235 - if neighbors & DIR_E != 0 { (1 << 1) } else { 0 } | [INFO] [stderr] 235 + if neighbors & DIR_E != 0 { 1 << 1 } else { 0 } | [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around block return value [INFO] [stderr] --> src/image_skeletonize.rs:242:37 [INFO] [stderr] | [INFO] [stderr] 242 | if neighbors & DIR_N != 0 { (1 << 4) } else { 0 } | [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 242 - if neighbors & DIR_N != 0 { (1 << 4) } else { 0 } | [INFO] [stderr] 242 + if neighbors & DIR_N != 0 { 1 << 4 } else { 0 } | [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around block return value [INFO] [stderr] --> src/image_skeletonize.rs:243:37 [INFO] [stderr] | [INFO] [stderr] 243 | if neighbors & DIR_W != 0 { (1 << 2) } else { 0 } | [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 243 - if neighbors & DIR_W != 0 { (1 << 2) } else { 0 } | [INFO] [stderr] 243 + if neighbors & DIR_W != 0 { 1 << 2 } else { 0 } | [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the item `Write` is imported redundantly [INFO] [stderr] --> src/curve_write.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 14 | use std::io::prelude::Write; [INFO] [stderr] | ----------------------- the item `Write` is already imported here [INFO] [stderr] ... [INFO] [stderr] 45 | use std::io::prelude::Write; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: the item `Write` is imported redundantly [INFO] [stderr] --> src/curve_write.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 14 | use std::io::prelude::Write; [INFO] [stderr] | ----------------------- the item `Write` is already imported here [INFO] [stderr] ... [INFO] [stderr] 83 | use std::io::prelude::Write; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the item `Write` is imported redundantly [INFO] [stderr] --> src/curve_write.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 14 | use std::io::prelude::Write; [INFO] [stderr] | ----------------------- the item `Write` is already imported here [INFO] [stderr] ... [INFO] [stderr] 192 | use std::io::prelude::Write; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the item `Write` is imported redundantly [INFO] [stderr] --> src/curve_write.rs:256:13 [INFO] [stderr] | [INFO] [stderr] 14 | use std::io::prelude::Write; [INFO] [stderr] | ----------------------- the item `Write` is already imported here [INFO] [stderr] ... [INFO] [stderr] 256 | use std::io::prelude::Write; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the item `Write` is imported redundantly [INFO] [stderr] --> src/curve_write.rs:355:13 [INFO] [stderr] | [INFO] [stderr] 14 | use std::io::prelude::Write; [INFO] [stderr] | ----------------------- the item `Write` is already imported here [INFO] [stderr] ... [INFO] [stderr] 355 | use std::io::prelude::Write; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the item `polys_from_raster_centerline` is imported redundantly [INFO] [stderr] --> src/main.rs:96:21 [INFO] [stderr] | [INFO] [stderr] 13 | mod polys_from_raster_centerline; [INFO] [stderr] | --------------------------------- the item `polys_from_raster_centerline` is already defined here [INFO] [stderr] ... [INFO] [stderr] 96 | use polys_from_raster_centerline; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the item `image_skeletonize` is imported redundantly [INFO] [stderr] --> src/main.rs:541:21 [INFO] [stderr] | [INFO] [stderr] 17 | mod image_skeletonize; [INFO] [stderr] | ---------------------- the item `image_skeletonize` is already defined here [INFO] [stderr] ... [INFO] [stderr] 541 | use image_skeletonize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/intern/argparse/mod.rs:29:19 [INFO] [stderr] | [INFO] [stderr] 29 | callback: Box Result>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] help: use `dyn` [INFO] [stderr] | [INFO] [stderr] 29 - callback: Box Result>, [INFO] [stderr] 29 + callback: Box Result>, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/intern/argparse/mod.rs:87:23 [INFO] [stderr] | [INFO] [stderr] 87 | callback: Box Result>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] help: use `dyn` [INFO] [stderr] | [INFO] [stderr] 87 - callback: Box Result>, [INFO] [stderr] 87 + callback: Box Result>, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `raster-retrace` (bin "raster-retrace" test) generated 38 warnings [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 0.00s [INFO] [stderr] Running unittests src/main.rs (/opt/rustwide/target/debug/deps/raster_retrace-47292730943f1f15) [INFO] [stdout] [INFO] [stdout] running 1 test [INFO] [stdout] test test::test_image_small ... FAILED [INFO] [stdout] [INFO] [stdout] failures: [INFO] [stdout] [INFO] [stdout] ---- test::test_image_small stdout ---- [INFO] [stdout] 12 -> 3 [INFO] [stdout] 68 -> 14 [INFO] [stdout] Total points: 17 [INFO] [stdout] [INFO] [stdout] thread 'test::test_image_small' panicked at 'Create output file: Os { code: 30, kind: ReadOnlyFilesystem, message: "Read-only file system" }', src/main.rs:151:54 [INFO] [stdout] stack backtrace: [INFO] [stdout] 0: 0x55eae948b14d - std::backtrace_rs::backtrace::libunwind::trace::ha359b7f0090e2792 [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/std/src/../../backtrace/src/backtrace/libunwind.rs:93:5 [INFO] [stdout] 1: 0x55eae948b14d - std::backtrace_rs::backtrace::trace_unsynchronized::h0584631f25c1d70e [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5 [INFO] [stdout] 2: 0x55eae948b14d - std::sys_common::backtrace::_print_fmt::hdadffd97d279ff14 [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/std/src/sys_common/backtrace.rs:66:5 [INFO] [stdout] 3: 0x55eae948b14d - ::fmt::h26f189e611080a74 [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/std/src/sys_common/backtrace.rs:45:22 [INFO] [stdout] 4: 0x55eae94adaac - core::fmt::write::hfb5d11dfe037e8b7 [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/core/src/fmt/mod.rs:1194:17 [INFO] [stdout] 5: 0x55eae9487b11 - std::io::Write::write_fmt::h6a24ec64406df9e2 [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/std/src/io/mod.rs:1655:15 [INFO] [stdout] 6: 0x55eae948ce95 - std::sys_common::backtrace::_print::h7a0e44402913ba60 [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/std/src/sys_common/backtrace.rs:48:5 [INFO] [stdout] 7: 0x55eae948ce95 - std::sys_common::backtrace::print::h9767dc455a84e728 [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/std/src/sys_common/backtrace.rs:35:9 [INFO] [stdout] 8: 0x55eae948ce95 - std::panicking::default_hook::{{closure}}::h60afd6c8b12988ad [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/std/src/panicking.rs:295:22 [INFO] [stdout] 9: 0x55eae948cb84 - std::panicking::default_hook::ha7b9bac6813f9d21 [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/std/src/panicking.rs:311:9 [INFO] [stdout] 10: 0x55eae948d3e2 - std::panicking::rust_panic_with_hook::h7b117a162a6f8664 [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/std/src/panicking.rs:698:17 [INFO] [stdout] 11: 0x55eae948d2c7 - std::panicking::begin_panic_handler::{{closure}}::h346750923c608600 [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/std/src/panicking.rs:588:13 [INFO] [stdout] 12: 0x55eae948b604 - std::sys_common::backtrace::__rust_end_short_backtrace::h768c56c6a0c055c0 [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/std/src/sys_common/backtrace.rs:138:18 [INFO] [stdout] 13: 0x55eae948cff9 - rust_begin_unwind [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/std/src/panicking.rs:584:5 [INFO] [stdout] 14: 0x55eae93e1463 - core::panicking::panic_fmt::h5c41cb2fa118fdbc [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/core/src/panicking.rs:143:14 [INFO] [stdout] 15: 0x55eae93e1553 - core::result::unwrap_failed::h6bc7b183ec719494 [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/core/src/result.rs:1785:5 [INFO] [stdout] 16: 0x55eae9425a62 - core::result::Result::expect::h629115bfabecf45c [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/core/src/result.rs:1035:23 [INFO] [stdout] 17: 0x55eae93f6a80 - raster_retrace::trace_image::hcbb2760b2c60b15c [INFO] [stdout] at /opt/rustwide/workdir/src/main.rs:151:13 [INFO] [stdout] 18: 0x55eae9419392 - raster_retrace::test::test_image_small::h58be7aaf0fe1703d [INFO] [stdout] at /opt/rustwide/workdir/src/tests.rs:12:19 [INFO] [stdout] 19: 0x55eae941927a - raster_retrace::test::test_image_small::{{closure}}::hc61590462b59ab3e [INFO] [stdout] at /opt/rustwide/workdir/src/tests.rs:8:9 [INFO] [stdout] 20: 0x55eae93fcc5e - core::ops::function::FnOnce::call_once::h8833904a71733880 [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/core/src/ops/function.rs:227:5 [INFO] [stdout] 21: 0x55eae9466df3 - core::ops::function::FnOnce::call_once::h018fc248431ce8de [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/core/src/ops/function.rs:227:5 [INFO] [stdout] 22: 0x55eae9466df3 - test::__rust_begin_short_backtrace::h293b982b6069d6e3 [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/test/src/lib.rs:574:5 [INFO] [stdout] 23: 0x55eae9465ba9 - as core::ops::function::FnOnce>::call_once::h4fc1be1a762c7a46 [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/alloc/src/boxed.rs:1861:9 [INFO] [stdout] 24: 0x55eae9465ba9 - as core::ops::function::FnOnce<()>>::call_once::hd44623ec51b9e897 [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/core/src/panic/unwind_safe.rs:271:9 [INFO] [stdout] 25: 0x55eae9465ba9 - std::panicking::try::do_call::ha8cfa4b025f5b832 [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/std/src/panicking.rs:492:40 [INFO] [stdout] 26: 0x55eae9465ba9 - std::panicking::try::h664f75e41c112145 [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/std/src/panicking.rs:456:19 [INFO] [stdout] 27: 0x55eae9465ba9 - std::panic::catch_unwind::h4932ec05cd60558e [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/std/src/panic.rs:137:14 [INFO] [stdout] 28: 0x55eae9465ba9 - test::run_test_in_process::ha14a47756671755c [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/test/src/lib.rs:597:18 [INFO] [stdout] 29: 0x55eae9465ba9 - test::run_test::run_test_inner::{{closure}}::h0ec9e37c8f67b62d [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/test/src/lib.rs:491:39 [INFO] [stdout] 30: 0x55eae9431d5e - test::run_test::run_test_inner::{{closure}}::hd9d2e7f26d4f59e6 [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/test/src/lib.rs:518:37 [INFO] [stdout] 31: 0x55eae9431d5e - std::sys_common::backtrace::__rust_begin_short_backtrace::h41c0a39fac5123f8 [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/std/src/sys_common/backtrace.rs:122:18 [INFO] [stdout] 32: 0x55eae94372c8 - std::thread::Builder::spawn_unchecked_::{{closure}}::{{closure}}::h69a02ca0bebb6eeb [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/std/src/thread/mod.rs:498:17 [INFO] [stdout] 33: 0x55eae94372c8 - as core::ops::function::FnOnce<()>>::call_once::hdd05632920ce689b [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/core/src/panic/unwind_safe.rs:271:9 [INFO] [stdout] 34: 0x55eae94372c8 - std::panicking::try::do_call::hb4947142729b90fd [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/std/src/panicking.rs:492:40 [INFO] [stdout] 35: 0x55eae94372c8 - std::panicking::try::h15a7e9b8394e6878 [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/std/src/panicking.rs:456:19 [INFO] [stdout] 36: 0x55eae94372c8 - std::panic::catch_unwind::hbd3f4a3f9df49b85 [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/std/src/panic.rs:137:14 [INFO] [stdout] 37: 0x55eae94372c8 - std::thread::Builder::spawn_unchecked_::{{closure}}::h880b5d5f1b9799f4 [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/std/src/thread/mod.rs:497:30 [INFO] [stdout] 38: 0x55eae94372c8 - core::ops::function::FnOnce::call_once{{vtable.shim}}::h304d5eaf401f5061 [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/core/src/ops/function.rs:227:5 [INFO] [stdout] 39: 0x55eae9491bf3 - as core::ops::function::FnOnce>::call_once::hdba7f2afed0c35b3 [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/alloc/src/boxed.rs:1861:9 [INFO] [stdout] 40: 0x55eae9491bf3 - as core::ops::function::FnOnce>::call_once::h38b0832765bf7961 [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/alloc/src/boxed.rs:1861:9 [INFO] [stdout] 41: 0x55eae9491bf3 - std::sys::unix::thread::Thread::new::thread_start::h70236dc17753425e [INFO] [stdout] at /rustc/7c13df853721b60a03e7c0bb084d2eb1e27a9caa/library/std/src/sys/unix/thread.rs:108:17 [INFO] [stdout] 42: 0x7f5bfa13f609 - start_thread [INFO] [stdout] 43: 0x7f5bf9f0f163 - clone [INFO] [stdout] 44: 0x0 - [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] failures: [INFO] [stdout] test::test_image_small [INFO] [stdout] [INFO] [stdout] test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.04s [INFO] [stdout] [INFO] [stderr] error: test failed, to rerun pass '--bin raster-retrace' [INFO] running `Command { std: "docker" "inspect" "b8c2b23d6a55688579920e9ac964e6791e228874b3d863970428fdec0ae13aee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b8c2b23d6a55688579920e9ac964e6791e228874b3d863970428fdec0ae13aee", kill_on_drop: false }` [INFO] [stdout] b8c2b23d6a55688579920e9ac964e6791e228874b3d863970428fdec0ae13aee