[INFO] cloning repository https://github.com/saterus/gilded-rose-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/saterus/gilded-rose-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsaterus%2Fgilded-rose-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsaterus%2Fgilded-rose-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8a8ec0b54b71eb6cfc764dda770b60843d95b73e [INFO] testing saterus/gilded-rose-rust against beta-2022-04-10 for beta-1.61-1 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsaterus%2Fgilded-rose-rust" "/workspace/builds/worker-10/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-10/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/saterus/gilded-rose-rust on toolchain beta-2022-04-10 [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+beta-2022-04-10" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/saterus/gilded-rose-rust [INFO] finished tweaking git repo https://github.com/saterus/gilded-rose-rust [INFO] tweaked toml for git repo https://github.com/saterus/gilded-rose-rust written to /workspace/builds/worker-10/source/Cargo.toml [INFO] crate git repo https://github.com/saterus/gilded-rose-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+beta-2022-04-10" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-10/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-10/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:eaef2f80f755933c374d2ae5edccceec0c1312ceb8a4e0b6404e8ab76561e1e5" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2022-04-10" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] [stdout] 1694945389a037636980af5ee0a67a7bffd7d9ec6aa0434bd43aba403953fa32 [INFO] running `Command { std: "docker" "start" "-a" "1694945389a037636980af5ee0a67a7bffd7d9ec6aa0434bd43aba403953fa32", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1694945389a037636980af5ee0a67a7bffd7d9ec6aa0434bd43aba403953fa32", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1694945389a037636980af5ee0a67a7bffd7d9ec6aa0434bd43aba403953fa32", kill_on_drop: false }` [INFO] [stdout] 1694945389a037636980af5ee0a67a7bffd7d9ec6aa0434bd43aba403953fa32 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-10/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-10/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:eaef2f80f755933c374d2ae5edccceec0c1312ceb8a4e0b6404e8ab76561e1e5" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2022-04-10" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 87df629b43ac3cd84ed810e7ed55633a99f12d77225acac4665872d1cd8ffd16 [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] running `Command { std: "docker" "start" "-a" "87df629b43ac3cd84ed810e7ed55633a99f12d77225acac4665872d1cd8ffd16", kill_on_drop: false }` [INFO] [stderr] Compiling gilded_rose v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 32 - if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stdout] 32 + if items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:34:16 [INFO] [stdout] | [INFO] [stdout] 34 | if (items[i].quality > 0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 34 - if (items[i].quality > 0) [INFO] [stdout] 34 + if items[i].quality > 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:36:20 [INFO] [stdout] | [INFO] [stdout] 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 36 - if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stdout] 36 + if items[i].name != "Sulfuras, Hand of Ragnaros" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:44:16 [INFO] [stdout] | [INFO] [stdout] 44 | if (items[i].quality < 50) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 44 - if (items[i].quality < 50) [INFO] [stdout] 44 + if items[i].quality < 50 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:48:20 [INFO] [stdout] | [INFO] [stdout] 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 48 - if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") [INFO] [stdout] 48 + if items[i].name == "Backstage passes to a TAFKAL80ETC concert" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:50:24 [INFO] [stdout] | [INFO] [stdout] 50 | if (items[i].sell_in < 11) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 50 - if (items[i].sell_in < 11) [INFO] [stdout] 50 + if items[i].sell_in < 11 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:52:28 [INFO] [stdout] | [INFO] [stdout] 52 | if (items[i].quality < 50) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 52 - if (items[i].quality < 50) [INFO] [stdout] 52 + if items[i].quality < 50 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:58:24 [INFO] [stdout] | [INFO] [stdout] 58 | if (items[i].sell_in < 6) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 58 - if (items[i].sell_in < 6) [INFO] [stdout] 58 + if items[i].sell_in < 6 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:60:28 [INFO] [stdout] | [INFO] [stdout] 60 | if (items[i].quality < 50) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 60 - if (items[i].quality < 50) [INFO] [stdout] 60 + if items[i].quality < 50 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 69 - if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stdout] 69 + if items[i].name != "Sulfuras, Hand of Ragnaros" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 74 | if (items[i].sell_in < 0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 74 - if (items[i].sell_in < 0) [INFO] [stdout] 74 + if items[i].sell_in < 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:76:16 [INFO] [stdout] | [INFO] [stdout] 76 | if (items[i].name != "Aged Brie") [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 76 - if (items[i].name != "Aged Brie") [INFO] [stdout] 76 + if items[i].name != "Aged Brie" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:78:20 [INFO] [stdout] | [INFO] [stdout] 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 78 - if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stdout] 78 + if items[i].name != "Backstage passes to a TAFKAL80ETC concert" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:80:24 [INFO] [stdout] | [INFO] [stdout] 80 | if (items[i].quality > 0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 80 - if (items[i].quality > 0) [INFO] [stdout] 80 + if items[i].quality > 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:82:28 [INFO] [stdout] | [INFO] [stdout] 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 82 - if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stdout] 82 + if items[i].name != "Sulfuras, Hand of Ragnaros" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:95:20 [INFO] [stdout] | [INFO] [stdout] 95 | if (items[i].quality < 50) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 95 - if (items[i].quality < 50) [INFO] [stdout] 95 + if items[i].quality < 50 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `UpdateQuality` should have a snake case name [INFO] [stdout] --> src/main.rs:28:4 [INFO] [stdout] | [INFO] [stdout] 28 | fn UpdateQuality(items: &mut [Item]) [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `update_quality` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.31s [INFO] running `Command { std: "docker" "inspect" "87df629b43ac3cd84ed810e7ed55633a99f12d77225acac4665872d1cd8ffd16", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "87df629b43ac3cd84ed810e7ed55633a99f12d77225acac4665872d1cd8ffd16", kill_on_drop: false }` [INFO] [stdout] 87df629b43ac3cd84ed810e7ed55633a99f12d77225acac4665872d1cd8ffd16 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-10/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-10/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:eaef2f80f755933c374d2ae5edccceec0c1312ceb8a4e0b6404e8ab76561e1e5" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2022-04-10" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] [stdout] 53911caa74374e97d8c743b041dfb1e5733b4f57b36b51ac395d337b2ae4a57b [INFO] running `Command { std: "docker" "start" "-a" "53911caa74374e97d8c743b041dfb1e5733b4f57b36b51ac395d337b2ae4a57b", kill_on_drop: false }` [INFO] [stderr] Compiling gilded_rose v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 32 - if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stdout] 32 + if items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:34:16 [INFO] [stdout] | [INFO] [stdout] 34 | if (items[i].quality > 0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 34 - if (items[i].quality > 0) [INFO] [stdout] 34 + if items[i].quality > 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:36:20 [INFO] [stdout] | [INFO] [stdout] 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 36 - if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stdout] 36 + if items[i].name != "Sulfuras, Hand of Ragnaros" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:44:16 [INFO] [stdout] | [INFO] [stdout] 44 | if (items[i].quality < 50) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 44 - if (items[i].quality < 50) [INFO] [stdout] 44 + if items[i].quality < 50 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:48:20 [INFO] [stdout] | [INFO] [stdout] 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 48 - if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") [INFO] [stdout] 48 + if items[i].name == "Backstage passes to a TAFKAL80ETC concert" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:50:24 [INFO] [stdout] | [INFO] [stdout] 50 | if (items[i].sell_in < 11) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 50 - if (items[i].sell_in < 11) [INFO] [stdout] 50 + if items[i].sell_in < 11 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:52:28 [INFO] [stdout] | [INFO] [stdout] 52 | if (items[i].quality < 50) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 52 - if (items[i].quality < 50) [INFO] [stdout] 52 + if items[i].quality < 50 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:58:24 [INFO] [stdout] | [INFO] [stdout] 58 | if (items[i].sell_in < 6) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 58 - if (items[i].sell_in < 6) [INFO] [stdout] 58 + if items[i].sell_in < 6 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:60:28 [INFO] [stdout] | [INFO] [stdout] 60 | if (items[i].quality < 50) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 60 - if (items[i].quality < 50) [INFO] [stdout] 60 + if items[i].quality < 50 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 69 - if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stdout] 69 + if items[i].name != "Sulfuras, Hand of Ragnaros" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 74 | if (items[i].sell_in < 0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 74 - if (items[i].sell_in < 0) [INFO] [stdout] 74 + if items[i].sell_in < 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:76:16 [INFO] [stdout] | [INFO] [stdout] 76 | if (items[i].name != "Aged Brie") [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 76 - if (items[i].name != "Aged Brie") [INFO] [stdout] 76 + if items[i].name != "Aged Brie" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:78:20 [INFO] [stdout] | [INFO] [stdout] 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 78 - if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stdout] 78 + if items[i].name != "Backstage passes to a TAFKAL80ETC concert" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:80:24 [INFO] [stdout] | [INFO] [stdout] 80 | if (items[i].quality > 0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 80 - if (items[i].quality > 0) [INFO] [stdout] 80 + if items[i].quality > 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:82:28 [INFO] [stdout] | [INFO] [stdout] 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 82 - if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stdout] 82 + if items[i].name != "Sulfuras, Hand of Ragnaros" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:95:20 [INFO] [stdout] | [INFO] [stdout] 95 | if (items[i].quality < 50) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 95 - if (items[i].quality < 50) [INFO] [stdout] 95 + if items[i].quality < 50 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `UpdateQuality` should have a snake case name [INFO] [stdout] --> src/main.rs:28:4 [INFO] [stdout] | [INFO] [stdout] 28 | fn UpdateQuality(items: &mut [Item]) [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `update_quality` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 1.57s [INFO] [stderr] Executable unittests src/lib.rs (/opt/rustwide/target/debug/deps/gilded_rose-fb26e6d0197e4427) [INFO] [stderr] Executable unittests src/main.rs (/opt/rustwide/target/debug/deps/gilded_rose-f4fa6e1978f91d53) [INFO] running `Command { std: "docker" "inspect" "53911caa74374e97d8c743b041dfb1e5733b4f57b36b51ac395d337b2ae4a57b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "53911caa74374e97d8c743b041dfb1e5733b4f57b36b51ac395d337b2ae4a57b", kill_on_drop: false }` [INFO] [stdout] 53911caa74374e97d8c743b041dfb1e5733b4f57b36b51ac395d337b2ae4a57b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-10/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-10/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:eaef2f80f755933c374d2ae5edccceec0c1312ceb8a4e0b6404e8ab76561e1e5" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2022-04-10" "test" "--frozen", kill_on_drop: false }` [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] [stdout] 9b1ad03c5dd49ef1ed4890325b9c0a1a50ab7928b307bf2bbf2f1553f593b2b6 [INFO] running `Command { std: "docker" "start" "-a" "9b1ad03c5dd49ef1ed4890325b9c0a1a50ab7928b307bf2bbf2f1553f593b2b6", kill_on_drop: false }` [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:32:12 [INFO] [stderr] | [INFO] [stderr] 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 32 - if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stderr] 32 + if items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:34:16 [INFO] [stderr] | [INFO] [stderr] 34 | if (items[i].quality > 0) [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 34 - if (items[i].quality > 0) [INFO] [stderr] 34 + if items[i].quality > 0 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:36:20 [INFO] [stderr] | [INFO] [stderr] 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 36 - if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stderr] 36 + if items[i].name != "Sulfuras, Hand of Ragnaros" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:44:16 [INFO] [stderr] | [INFO] [stderr] 44 | if (items[i].quality < 50) [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 44 - if (items[i].quality < 50) [INFO] [stderr] 44 + if items[i].quality < 50 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:48:20 [INFO] [stderr] | [INFO] [stderr] 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 48 - if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") [INFO] [stderr] 48 + if items[i].name == "Backstage passes to a TAFKAL80ETC concert" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:50:24 [INFO] [stderr] | [INFO] [stderr] 50 | if (items[i].sell_in < 11) [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 50 - if (items[i].sell_in < 11) [INFO] [stderr] 50 + if items[i].sell_in < 11 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:52:28 [INFO] [stderr] | [INFO] [stderr] 52 | if (items[i].quality < 50) [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 52 - if (items[i].quality < 50) [INFO] [stderr] 52 + if items[i].quality < 50 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:58:24 [INFO] [stderr] | [INFO] [stderr] 58 | if (items[i].sell_in < 6) [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 58 - if (items[i].sell_in < 6) [INFO] [stderr] 58 + if items[i].sell_in < 6 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:60:28 [INFO] [stderr] | [INFO] [stderr] 60 | if (items[i].quality < 50) [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 60 - if (items[i].quality < 50) [INFO] [stderr] 60 + if items[i].quality < 50 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:69:12 [INFO] [stderr] | [INFO] [stderr] 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 69 - if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stderr] 69 + if items[i].name != "Sulfuras, Hand of Ragnaros" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:74:12 [INFO] [stderr] | [INFO] [stderr] 74 | if (items[i].sell_in < 0) [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 74 - if (items[i].sell_in < 0) [INFO] [stderr] 74 + if items[i].sell_in < 0 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:76:16 [INFO] [stderr] | [INFO] [stderr] 76 | if (items[i].name != "Aged Brie") [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 76 - if (items[i].name != "Aged Brie") [INFO] [stderr] 76 + if items[i].name != "Aged Brie" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:78:20 [INFO] [stderr] | [INFO] [stderr] 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 78 - if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stderr] 78 + if items[i].name != "Backstage passes to a TAFKAL80ETC concert" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:80:24 [INFO] [stderr] | [INFO] [stderr] 80 | if (items[i].quality > 0) [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 80 - if (items[i].quality > 0) [INFO] [stderr] 80 + if items[i].quality > 0 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:82:28 [INFO] [stderr] | [INFO] [stderr] 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 82 - if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stderr] 82 + if items[i].name != "Sulfuras, Hand of Ragnaros" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:95:20 [INFO] [stderr] | [INFO] [stderr] 95 | if (items[i].quality < 50) [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 95 - if (items[i].quality < 50) [INFO] [stderr] 95 + if items[i].quality < 50 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: function `UpdateQuality` should have a snake case name [INFO] [stderr] --> src/main.rs:28:4 [INFO] [stderr] | [INFO] [stderr] 28 | fn UpdateQuality(items: &mut [Item]) [INFO] [stderr] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `update_quality` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] [INFO] [stderr] warning: `gilded_rose` (bin "gilded_rose" test) generated 17 warnings [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 0.02s [INFO] [stderr] Running unittests src/lib.rs (/opt/rustwide/target/debug/deps/gilded_rose-fb26e6d0197e4427) [INFO] [stderr] Running unittests src/main.rs (/opt/rustwide/target/debug/deps/gilded_rose-f4fa6e1978f91d53) [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] running 1 test [INFO] [stderr] Doc-tests gilded_rose [INFO] [stdout] test normal_items_decrease_quality ... ok [INFO] [stdout] [INFO] [stdout] test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "9b1ad03c5dd49ef1ed4890325b9c0a1a50ab7928b307bf2bbf2f1553f593b2b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9b1ad03c5dd49ef1ed4890325b9c0a1a50ab7928b307bf2bbf2f1553f593b2b6", kill_on_drop: false }` [INFO] [stdout] 9b1ad03c5dd49ef1ed4890325b9c0a1a50ab7928b307bf2bbf2f1553f593b2b6