[INFO] cloning repository https://github.com/aep000/myvm-LC3 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/aep000/myvm-LC3" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faep000%2Fmyvm-LC3", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faep000%2Fmyvm-LC3'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3428c8ff1af1990250b6b1f776f71b3f85b7e6a3 [INFO] testing aep000/myvm-LC3 against beta-2022-04-10 for beta-1.61-1 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faep000%2Fmyvm-LC3" "/workspace/builds/worker-40/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-40/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/aep000/myvm-LC3 on toolchain beta-2022-04-10 [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+beta-2022-04-10" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/aep000/myvm-LC3 [INFO] finished tweaking git repo https://github.com/aep000/myvm-LC3 [INFO] tweaked toml for git repo https://github.com/aep000/myvm-LC3 written to /workspace/builds/worker-40/source/Cargo.toml [INFO] crate git repo https://github.com/aep000/myvm-LC3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+beta-2022-04-10" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-40/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-40/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:b0c94ce3c1162fcb8e57cac5b65ec2f72eabb1eebea4fcc35e269e823f681646" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2022-04-10" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 730100ef1e7407e4d4c335ae67436472b141f8ccb3a0e82d2bcc6ed255c914f2 [INFO] running `Command { std: "docker" "start" "-a" "730100ef1e7407e4d4c335ae67436472b141f8ccb3a0e82d2bcc6ed255c914f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "730100ef1e7407e4d4c335ae67436472b141f8ccb3a0e82d2bcc6ed255c914f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "730100ef1e7407e4d4c335ae67436472b141f8ccb3a0e82d2bcc6ed255c914f2", kill_on_drop: false }` [INFO] [stdout] 730100ef1e7407e4d4c335ae67436472b141f8ccb3a0e82d2bcc6ed255c914f2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-40/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-40/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:b0c94ce3c1162fcb8e57cac5b65ec2f72eabb1eebea4fcc35e269e823f681646" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2022-04-10" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a06a0546ad16755d63a9f4a2c634b6de14cb4ba6f9e0bc04abd7917268a2b431 [INFO] running `Command { std: "docker" "start" "-a" "a06a0546ad16755d63a9f4a2c634b6de14cb4ba6f9e0bc04abd7917268a2b431", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Compiling myvm v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/instructions.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | if (((x >> (bit_count - 1)) & 1)==0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 11 - if (((x >> (bit_count - 1)) & 1)==0) { [INFO] [stdout] 11 + if ((x >> (bit_count - 1)) & 1)==0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/instructions.rs:19:8 [INFO] [stdout] | [INFO] [stdout] 19 | if (context.Reg[r] == 0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 19 - if (context.Reg[r] == 0) [INFO] [stdout] 19 + if context.Reg[r] == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/instructions.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | else if (context.Reg[r] >> 15 == 1) /* a 1 in the left-most bit indicates negative */ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 23 - else if (context.Reg[r] >> 15 == 1) /* a 1 in the left-most bit indicates negative */ [INFO] [stdout] 23 + else if context.Reg[r] >> 15 == 1 /* a 1 in the left-most bit indicates negative */ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `FL_POS` should have an upper camel case name [INFO] [stdout] --> src/instructions.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | FL_POS = 1 << 0, /* P */ [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case: `FlPos` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `FL_ZRO` should have an upper camel case name [INFO] [stdout] --> src/instructions.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | FL_ZRO = 1 << 1, /* Z */ [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case: `FlZro` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `FL_NEG` should have an upper camel case name [INFO] [stdout] --> src/instructions.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | FL_NEG = 1 << 2, /* N */ [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case: `FlNeg` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/instructions.rs:70:22 [INFO] [stdout] | [INFO] [stdout] 70 | while(context.Memory[c as usize]!=0){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 70 - while(context.Memory[c as usize]!=0){ [INFO] [stdout] 70 + while context.Memory[c as usize]!=0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/instructions.rs:122:19 [INFO] [stdout] | [INFO] [stdout] 122 | if(conds & context.Reg[RNum!(Registers::RCOND)] == conds){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 122 - if(conds & context.Reg[RNum!(Registers::RCOND)] == conds){ [INFO] [stdout] 122 + if conds & context.Reg[RNum!(Registers::RCOND)] == conds { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/instructions.rs:134:20 [INFO] [stdout] | [INFO] [stdout] 134 | if (immediatMode == 1) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 134 - if (immediatMode == 1) [INFO] [stdout] 134 + if immediatMode == 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/instructions.rs:167:19 [INFO] [stdout] | [INFO] [stdout] 167 | if(flag == 0){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 167 - if(flag == 0){ [INFO] [stdout] 167 + if flag == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/instructions.rs:182:20 [INFO] [stdout] | [INFO] [stdout] 182 | if (immediatMode == 1) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 182 - if (immediatMode == 1) [INFO] [stdout] 182 + if immediatMode == 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:56:11 [INFO] [stdout] | [INFO] [stdout] 56 | if(op< Instruction::ICOUNT as u16){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 56 - if(op< Instruction::ICOUNT as u16){ [INFO] [stdout] 56 + if op< Instruction::ICOUNT as u16 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `extended` [INFO] [stdout] --> src/instructions.rs:12:13 [INFO] [stdout] | [INFO] [stdout] 12 | let extended = x | (0xFFFF << bit_count); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_extended` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `instr` [INFO] [stdout] --> src/instructions.rs:59:46 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn run(&self, context: &mut Context, instr: &usize){ [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_instr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `offset` [INFO] [stdout] --> src/instructions.rs:224:21 [INFO] [stdout] | [INFO] [stdout] 224 | ... let offset = sign_extend((instr & 0x1ff) as u16, 9); //Location in memory at Offset + PC contains the location we are loading from [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_offset` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | let mut running = true; [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `R1` [INFO] [stdout] --> src/memory.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | R1=1, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] note: `Registers` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] --> src/memory.rs:1:16 [INFO] [stdout] | [INFO] [stdout] 1 | #[derive(Copy, Clone)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] = note: this warning originates in the derive macro `Clone` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `R2` [INFO] [stdout] --> src/memory.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | R2=2, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] note: `Registers` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] --> src/memory.rs:1:16 [INFO] [stdout] | [INFO] [stdout] 1 | #[derive(Copy, Clone)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] = note: this warning originates in the derive macro `Clone` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `R3` [INFO] [stdout] --> src/memory.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | R3=3, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] note: `Registers` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] --> src/memory.rs:1:16 [INFO] [stdout] | [INFO] [stdout] 1 | #[derive(Copy, Clone)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] = note: this warning originates in the derive macro `Clone` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `R4` [INFO] [stdout] --> src/memory.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | R4=4, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] note: `Registers` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] --> src/memory.rs:1:16 [INFO] [stdout] | [INFO] [stdout] 1 | #[derive(Copy, Clone)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] = note: this warning originates in the derive macro `Clone` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `R5` [INFO] [stdout] --> src/memory.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | R5=5, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] note: `Registers` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] --> src/memory.rs:1:16 [INFO] [stdout] | [INFO] [stdout] 1 | #[derive(Copy, Clone)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] = note: this warning originates in the derive macro `Clone` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `R6` [INFO] [stdout] --> src/memory.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | R6=6, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] note: `Registers` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] --> src/memory.rs:1:16 [INFO] [stdout] | [INFO] [stdout] 1 | #[derive(Copy, Clone)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] = note: this warning originates in the derive macro `Clone` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `GETC` [INFO] [stdout] --> src/instructions.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | GETC = 0x20, /* get character from keyboard, not echoed onto the terminal */ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `OUT` [INFO] [stdout] --> src/instructions.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | OUT = 0x21, /* output a character */ [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `PUTS` [INFO] [stdout] --> src/instructions.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | PUTS = 0x22, /* output a word string */ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `IN` [INFO] [stdout] --> src/instructions.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | IN = 0x23, /* get character from keyboard, echoed onto the terminal */ [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `PUTSP` [INFO] [stdout] --> src/instructions.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | PUTSP = 0x24, /* output a byte string */ [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `HALT` [INFO] [stdout] --> src/instructions.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | HALT = 0x25 /* halt the program */ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Memory` should have a snake case name [INFO] [stdout] --> src/memory.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | pub Memory: [u16; 65535], [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `memory` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Reg` should have a snake case name [INFO] [stdout] --> src/memory.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub Reg: [u16; RNum!(Registers::RCOUNT)], [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `reg` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `Run` should have a snake case name [INFO] [stdout] --> src/instructions.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn Run(&self, context: &mut Context, instr: &u16){ [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `run` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `immediatMode` should have a snake case name [INFO] [stdout] --> src/instructions.rs:132:21 [INFO] [stdout] | [INFO] [stdout] 132 | let immediatMode = (instr >> 5) & 0x1; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `immediat_mode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `immediatMode` should have a snake case name [INFO] [stdout] --> src/instructions.rs:180:21 [INFO] [stdout] | [INFO] [stdout] 180 | let immediatMode = (instr >> 5) & 0x1; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `immediat_mode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `baseR` should have a snake case name [INFO] [stdout] --> src/instructions.rs:198:21 [INFO] [stdout] | [INFO] [stdout] 198 | let baseR = (instr >> 6) & 0x7; [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `base_r` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 34 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.74s [INFO] running `Command { std: "docker" "inspect" "a06a0546ad16755d63a9f4a2c634b6de14cb4ba6f9e0bc04abd7917268a2b431", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a06a0546ad16755d63a9f4a2c634b6de14cb4ba6f9e0bc04abd7917268a2b431", kill_on_drop: false }` [INFO] [stdout] a06a0546ad16755d63a9f4a2c634b6de14cb4ba6f9e0bc04abd7917268a2b431 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-40/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-40/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:b0c94ce3c1162fcb8e57cac5b65ec2f72eabb1eebea4fcc35e269e823f681646" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2022-04-10" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] be0fb9a439ff48a6e8eea76be6b2396b7958c0c06997c9dd4072dc89f0a465b1 [INFO] running `Command { std: "docker" "start" "-a" "be0fb9a439ff48a6e8eea76be6b2396b7958c0c06997c9dd4072dc89f0a465b1", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Compiling myvm v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/instructions.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | if (((x >> (bit_count - 1)) & 1)==0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 11 - if (((x >> (bit_count - 1)) & 1)==0) { [INFO] [stdout] 11 + if ((x >> (bit_count - 1)) & 1)==0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/instructions.rs:19:8 [INFO] [stdout] | [INFO] [stdout] 19 | if (context.Reg[r] == 0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 19 - if (context.Reg[r] == 0) [INFO] [stdout] 19 + if context.Reg[r] == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/instructions.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | else if (context.Reg[r] >> 15 == 1) /* a 1 in the left-most bit indicates negative */ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 23 - else if (context.Reg[r] >> 15 == 1) /* a 1 in the left-most bit indicates negative */ [INFO] [stdout] 23 + else if context.Reg[r] >> 15 == 1 /* a 1 in the left-most bit indicates negative */ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `FL_POS` should have an upper camel case name [INFO] [stdout] --> src/instructions.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | FL_POS = 1 << 0, /* P */ [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case: `FlPos` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `FL_ZRO` should have an upper camel case name [INFO] [stdout] --> src/instructions.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | FL_ZRO = 1 << 1, /* Z */ [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case: `FlZro` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `FL_NEG` should have an upper camel case name [INFO] [stdout] --> src/instructions.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | FL_NEG = 1 << 2, /* N */ [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case: `FlNeg` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/instructions.rs:70:22 [INFO] [stdout] | [INFO] [stdout] 70 | while(context.Memory[c as usize]!=0){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 70 - while(context.Memory[c as usize]!=0){ [INFO] [stdout] 70 + while context.Memory[c as usize]!=0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/instructions.rs:122:19 [INFO] [stdout] | [INFO] [stdout] 122 | if(conds & context.Reg[RNum!(Registers::RCOND)] == conds){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 122 - if(conds & context.Reg[RNum!(Registers::RCOND)] == conds){ [INFO] [stdout] 122 + if conds & context.Reg[RNum!(Registers::RCOND)] == conds { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/instructions.rs:134:20 [INFO] [stdout] | [INFO] [stdout] 134 | if (immediatMode == 1) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 134 - if (immediatMode == 1) [INFO] [stdout] 134 + if immediatMode == 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/instructions.rs:167:19 [INFO] [stdout] | [INFO] [stdout] 167 | if(flag == 0){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 167 - if(flag == 0){ [INFO] [stdout] 167 + if flag == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/instructions.rs:182:20 [INFO] [stdout] | [INFO] [stdout] 182 | if (immediatMode == 1) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 182 - if (immediatMode == 1) [INFO] [stdout] 182 + if immediatMode == 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:56:11 [INFO] [stdout] | [INFO] [stdout] 56 | if(op< Instruction::ICOUNT as u16){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 56 - if(op< Instruction::ICOUNT as u16){ [INFO] [stdout] 56 + if op< Instruction::ICOUNT as u16 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `extended` [INFO] [stdout] --> src/instructions.rs:12:13 [INFO] [stdout] | [INFO] [stdout] 12 | let extended = x | (0xFFFF << bit_count); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_extended` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `instr` [INFO] [stdout] --> src/instructions.rs:59:46 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn run(&self, context: &mut Context, instr: &usize){ [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_instr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `offset` [INFO] [stdout] --> src/instructions.rs:224:21 [INFO] [stdout] | [INFO] [stdout] 224 | ... let offset = sign_extend((instr & 0x1ff) as u16, 9); //Location in memory at Offset + PC contains the location we are loading from [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_offset` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | let mut running = true; [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `R1` [INFO] [stdout] --> src/memory.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | R1=1, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] note: `Registers` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] --> src/memory.rs:1:16 [INFO] [stdout] | [INFO] [stdout] 1 | #[derive(Copy, Clone)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] = note: this warning originates in the derive macro `Clone` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `R2` [INFO] [stdout] --> src/memory.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | R2=2, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] note: `Registers` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] --> src/memory.rs:1:16 [INFO] [stdout] | [INFO] [stdout] 1 | #[derive(Copy, Clone)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] = note: this warning originates in the derive macro `Clone` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `R3` [INFO] [stdout] --> src/memory.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | R3=3, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] note: `Registers` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] --> src/memory.rs:1:16 [INFO] [stdout] | [INFO] [stdout] 1 | #[derive(Copy, Clone)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] = note: this warning originates in the derive macro `Clone` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `R4` [INFO] [stdout] --> src/memory.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | R4=4, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] note: `Registers` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] --> src/memory.rs:1:16 [INFO] [stdout] | [INFO] [stdout] 1 | #[derive(Copy, Clone)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] = note: this warning originates in the derive macro `Clone` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `R5` [INFO] [stdout] --> src/memory.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | R5=5, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] note: `Registers` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] --> src/memory.rs:1:16 [INFO] [stdout] | [INFO] [stdout] 1 | #[derive(Copy, Clone)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] = note: this warning originates in the derive macro `Clone` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `R6` [INFO] [stdout] --> src/memory.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | R6=6, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] note: `Registers` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] --> src/memory.rs:1:16 [INFO] [stdout] | [INFO] [stdout] 1 | #[derive(Copy, Clone)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] = note: this warning originates in the derive macro `Clone` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `GETC` [INFO] [stdout] --> src/instructions.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | GETC = 0x20, /* get character from keyboard, not echoed onto the terminal */ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `OUT` [INFO] [stdout] --> src/instructions.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | OUT = 0x21, /* output a character */ [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `PUTS` [INFO] [stdout] --> src/instructions.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | PUTS = 0x22, /* output a word string */ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `IN` [INFO] [stdout] --> src/instructions.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | IN = 0x23, /* get character from keyboard, echoed onto the terminal */ [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `PUTSP` [INFO] [stdout] --> src/instructions.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | PUTSP = 0x24, /* output a byte string */ [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `HALT` [INFO] [stdout] --> src/instructions.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | HALT = 0x25 /* halt the program */ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Memory` should have a snake case name [INFO] [stdout] --> src/memory.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | pub Memory: [u16; 65535], [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `memory` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Reg` should have a snake case name [INFO] [stdout] --> src/memory.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub Reg: [u16; RNum!(Registers::RCOUNT)], [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `reg` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `Run` should have a snake case name [INFO] [stdout] --> src/instructions.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn Run(&self, context: &mut Context, instr: &u16){ [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `run` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `immediatMode` should have a snake case name [INFO] [stdout] --> src/instructions.rs:132:21 [INFO] [stdout] | [INFO] [stdout] 132 | let immediatMode = (instr >> 5) & 0x1; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `immediat_mode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `immediatMode` should have a snake case name [INFO] [stdout] --> src/instructions.rs:180:21 [INFO] [stdout] | [INFO] [stdout] 180 | let immediatMode = (instr >> 5) & 0x1; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `immediat_mode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `baseR` should have a snake case name [INFO] [stdout] --> src/instructions.rs:198:21 [INFO] [stdout] | [INFO] [stdout] 198 | let baseR = (instr >> 6) & 0x7; [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `base_r` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 34 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 13.90s [INFO] [stderr] Executable unittests src/main.rs (/opt/rustwide/target/debug/deps/myvm-02e16ed2310e1aea) [INFO] running `Command { std: "docker" "inspect" "be0fb9a439ff48a6e8eea76be6b2396b7958c0c06997c9dd4072dc89f0a465b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "be0fb9a439ff48a6e8eea76be6b2396b7958c0c06997c9dd4072dc89f0a465b1", kill_on_drop: false }` [INFO] [stdout] be0fb9a439ff48a6e8eea76be6b2396b7958c0c06997c9dd4072dc89f0a465b1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-40/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-40/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:b0c94ce3c1162fcb8e57cac5b65ec2f72eabb1eebea4fcc35e269e823f681646" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2022-04-10" "test" "--frozen", kill_on_drop: false }` [INFO] [stdout] e9a6745204c72811abe87af02e4d83917cc600246a935c8ff103d1effc5d3a55 [INFO] running `Command { std: "docker" "start" "-a" "e9a6745204c72811abe87af02e4d83917cc600246a935c8ff103d1effc5d3a55", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/instructions.rs:11:8 [INFO] [stderr] | [INFO] [stderr] 11 | if (((x >> (bit_count - 1)) & 1)==0) { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 11 - if (((x >> (bit_count - 1)) & 1)==0) { [INFO] [stderr] 11 + if ((x >> (bit_count - 1)) & 1)==0 { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/instructions.rs:19:8 [INFO] [stderr] | [INFO] [stderr] 19 | if (context.Reg[r] == 0) [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 19 - if (context.Reg[r] == 0) [INFO] [stderr] 19 + if context.Reg[r] == 0 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/instructions.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | else if (context.Reg[r] >> 15 == 1) /* a 1 in the left-most bit indicates negative */ [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 23 - else if (context.Reg[r] >> 15 == 1) /* a 1 in the left-most bit indicates negative */ [INFO] [stderr] 23 + else if context.Reg[r] >> 15 == 1 /* a 1 in the left-most bit indicates negative */ [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variant `FL_POS` should have an upper camel case name [INFO] [stderr] --> src/instructions.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | FL_POS = 1 << 0, /* P */ [INFO] [stderr] | ^^^^^^ help: convert the identifier to upper camel case: `FlPos` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variant `FL_ZRO` should have an upper camel case name [INFO] [stderr] --> src/instructions.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | FL_ZRO = 1 << 1, /* Z */ [INFO] [stderr] | ^^^^^^ help: convert the identifier to upper camel case: `FlZro` [INFO] [stderr] [INFO] [stderr] warning: variant `FL_NEG` should have an upper camel case name [INFO] [stderr] --> src/instructions.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | FL_NEG = 1 << 2, /* N */ [INFO] [stderr] | ^^^^^^ help: convert the identifier to upper camel case: `FlNeg` [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `while` condition [INFO] [stderr] --> src/instructions.rs:70:22 [INFO] [stderr] | [INFO] [stderr] 70 | while(context.Memory[c as usize]!=0){ [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 70 - while(context.Memory[c as usize]!=0){ [INFO] [stderr] 70 + while context.Memory[c as usize]!=0 { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/instructions.rs:122:19 [INFO] [stderr] | [INFO] [stderr] 122 | if(conds & context.Reg[RNum!(Registers::RCOND)] == conds){ [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 122 - if(conds & context.Reg[RNum!(Registers::RCOND)] == conds){ [INFO] [stderr] 122 + if conds & context.Reg[RNum!(Registers::RCOND)] == conds { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/instructions.rs:134:20 [INFO] [stderr] | [INFO] [stderr] 134 | if (immediatMode == 1) [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 134 - if (immediatMode == 1) [INFO] [stderr] 134 + if immediatMode == 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/instructions.rs:167:19 [INFO] [stderr] | [INFO] [stderr] 167 | if(flag == 0){ [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 167 - if(flag == 0){ [INFO] [stderr] 167 + if flag == 0 { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/instructions.rs:182:20 [INFO] [stderr] | [INFO] [stderr] 182 | if (immediatMode == 1) [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 182 - if (immediatMode == 1) [INFO] [stderr] 182 + if immediatMode == 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:56:11 [INFO] [stderr] | [INFO] [stderr] 56 | if(op< Instruction::ICOUNT as u16){ [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 56 - if(op< Instruction::ICOUNT as u16){ [INFO] [stderr] 56 + if op< Instruction::ICOUNT as u16 { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `extended` [INFO] [stderr] --> src/instructions.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | let extended = x | (0xFFFF << bit_count); [INFO] [stderr] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_extended` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `instr` [INFO] [stderr] --> src/instructions.rs:59:46 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn run(&self, context: &mut Context, instr: &usize){ [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_instr` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `offset` [INFO] [stderr] --> src/instructions.rs:224:21 [INFO] [stderr] | [INFO] [stderr] 224 | ... let offset = sign_extend((instr & 0x1ff) as u16, 9); //Location in memory at Offset + PC contains the location we are loading from [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_offset` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | let mut running = true; [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `R1` [INFO] [stderr] --> src/memory.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | R1=1, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] note: `Registers` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stderr] --> src/memory.rs:1:16 [INFO] [stderr] | [INFO] [stderr] 1 | #[derive(Copy, Clone)] [INFO] [stderr] | ^^^^^ [INFO] [stderr] = note: this warning originates in the derive macro `Clone` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `R2` [INFO] [stderr] --> src/memory.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | R2=2, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: `Registers` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stderr] --> src/memory.rs:1:16 [INFO] [stderr] | [INFO] [stderr] 1 | #[derive(Copy, Clone)] [INFO] [stderr] | ^^^^^ [INFO] [stderr] = note: this warning originates in the derive macro `Clone` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `R3` [INFO] [stderr] --> src/memory.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | R3=3, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: `Registers` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stderr] --> src/memory.rs:1:16 [INFO] [stderr] | [INFO] [stderr] 1 | #[derive(Copy, Clone)] [INFO] [stderr] | ^^^^^ [INFO] [stderr] = note: this warning originates in the derive macro `Clone` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `R4` [INFO] [stderr] --> src/memory.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | R4=4, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: `Registers` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stderr] --> src/memory.rs:1:16 [INFO] [stderr] | [INFO] [stderr] 1 | #[derive(Copy, Clone)] [INFO] [stderr] | ^^^^^ [INFO] [stderr] = note: this warning originates in the derive macro `Clone` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `R5` [INFO] [stderr] --> src/memory.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | R5=5, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: `Registers` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stderr] --> src/memory.rs:1:16 [INFO] [stderr] | [INFO] [stderr] 1 | #[derive(Copy, Clone)] [INFO] [stderr] | ^^^^^ [INFO] [stderr] = note: this warning originates in the derive macro `Clone` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `R6` [INFO] [stderr] --> src/memory.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | R6=6, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: `Registers` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stderr] --> src/memory.rs:1:16 [INFO] [stderr] | [INFO] [stderr] 1 | #[derive(Copy, Clone)] [INFO] [stderr] | ^^^^^ [INFO] [stderr] = note: this warning originates in the derive macro `Clone` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GETC` [INFO] [stderr] --> src/instructions.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | GETC = 0x20, /* get character from keyboard, not echoed onto the terminal */ [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `OUT` [INFO] [stderr] --> src/instructions.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | OUT = 0x21, /* output a character */ [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `PUTS` [INFO] [stderr] --> src/instructions.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | PUTS = 0x22, /* output a word string */ [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `IN` [INFO] [stderr] --> src/instructions.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | IN = 0x23, /* get character from keyboard, echoed onto the terminal */ [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `PUTSP` [INFO] [stderr] --> src/instructions.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | PUTSP = 0x24, /* output a byte string */ [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `HALT` [INFO] [stderr] --> src/instructions.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | HALT = 0x25 /* halt the program */ [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `Memory` should have a snake case name [INFO] [stderr] --> src/memory.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | pub Memory: [u16; 65535], [INFO] [stderr] | ^^^^^^ help: convert the identifier to snake case: `memory` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `Reg` should have a snake case name [INFO] [stderr] --> src/memory.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | pub Reg: [u16; RNum!(Registers::RCOUNT)], [INFO] [stderr] | ^^^ help: convert the identifier to snake case: `reg` [INFO] [stderr] [INFO] [stderr] warning: method `Run` should have a snake case name [INFO] [stderr] --> src/instructions.rs:114:12 [INFO] [stderr] | [INFO] [stderr] 114 | pub fn Run(&self, context: &mut Context, instr: &u16){ [INFO] [stderr] | ^^^ help: convert the identifier to snake case: `run` [INFO] [stderr] [INFO] [stderr] warning: variable `immediatMode` should have a snake case name [INFO] [stderr] --> src/instructions.rs:132:21 [INFO] [stderr] | [INFO] [stderr] 132 | let immediatMode = (instr >> 5) & 0x1; [INFO] [stderr] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `immediat_mode` [INFO] [stderr] [INFO] [stderr] warning: variable `immediatMode` should have a snake case name [INFO] [stderr] --> src/instructions.rs:180:21 [INFO] [stderr] | [INFO] [stderr] 180 | let immediatMode = (instr >> 5) & 0x1; [INFO] [stderr] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `immediat_mode` [INFO] [stderr] [INFO] [stderr] warning: variable `baseR` should have a snake case name [INFO] [stderr] --> src/instructions.rs:198:21 [INFO] [stderr] | [INFO] [stderr] 198 | let baseR = (instr >> 6) & 0x7; [INFO] [stderr] | ^^^^^ help: convert the identifier to snake case: `base_r` [INFO] [stderr] [INFO] [stderr] warning: `myvm` (bin "myvm" test) generated 34 warnings [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 2.73s [INFO] [stderr] Running unittests src/main.rs (/opt/rustwide/target/debug/deps/myvm-02e16ed2310e1aea) [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "e9a6745204c72811abe87af02e4d83917cc600246a935c8ff103d1effc5d3a55", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e9a6745204c72811abe87af02e4d83917cc600246a935c8ff103d1effc5d3a55", kill_on_drop: false }` [INFO] [stdout] e9a6745204c72811abe87af02e4d83917cc600246a935c8ff103d1effc5d3a55