[INFO] cloning repository https://github.com/EleanorWhite/goFish [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/EleanorWhite/goFish" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEleanorWhite%2FgoFish", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEleanorWhite%2FgoFish'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cc95edb4e675f768bcfa0cd6288e0e9faca9639d [INFO] testing EleanorWhite/goFish against beta-2022-04-10 for beta-1.61-1 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEleanorWhite%2FgoFish" "/workspace/builds/worker-27/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-27/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/EleanorWhite/goFish on toolchain beta-2022-04-10 [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+beta-2022-04-10" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/EleanorWhite/goFish [INFO] finished tweaking git repo https://github.com/EleanorWhite/goFish [INFO] tweaked toml for git repo https://github.com/EleanorWhite/goFish written to /workspace/builds/worker-27/source/Cargo.toml [INFO] crate git repo https://github.com/EleanorWhite/goFish already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+beta-2022-04-10" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-27/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-27/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:b0c94ce3c1162fcb8e57cac5b65ec2f72eabb1eebea4fcc35e269e823f681646" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2022-04-10" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 09cd17e547c7f0109698943f5963860676d9c9d2edfc05a6b670d87883999e68 [INFO] running `Command { std: "docker" "start" "-a" "09cd17e547c7f0109698943f5963860676d9c9d2edfc05a6b670d87883999e68", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "09cd17e547c7f0109698943f5963860676d9c9d2edfc05a6b670d87883999e68", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "09cd17e547c7f0109698943f5963860676d9c9d2edfc05a6b670d87883999e68", kill_on_drop: false }` [INFO] [stdout] 09cd17e547c7f0109698943f5963860676d9c9d2edfc05a6b670d87883999e68 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-27/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-27/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:b0c94ce3c1162fcb8e57cac5b65ec2f72eabb1eebea4fcc35e269e823f681646" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2022-04-10" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e4921680b4887a40c1669c451b1fb5ed88e430a97db6185de3373954e216c8d8 [INFO] running `Command { std: "docker" "start" "-a" "e4921680b4887a40c1669c451b1fb5ed88e430a97db6185de3373954e216c8d8", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.53 [INFO] [stderr] Compiling numtoa v0.1.0 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_os v0.1.3 [INFO] [stderr] Compiling termion v1.5.2 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling new_rust_project v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `Write`, `stdin`, `stdout` [INFO] [stdout] --> src/main.rs:7:15 [INFO] [stdout] | [INFO] [stdout] 7 | use std::io::{Write, stdout, stdin}; [INFO] [stdout] | ^^^^^ ^^^^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:59:6 [INFO] [stdout] | [INFO] [stdout] 59 | if (ranks[i] == card) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 59 - if (ranks[i] == card) { [INFO] [stdout] 59 + if ranks[i] == card { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:80:7 [INFO] [stdout] | [INFO] [stdout] 80 | if (new < min_val) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 80 - if (new < min_val) { [INFO] [stdout] 80 + if new < min_val { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 123 | if (playing_hand.is_empty()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 123 - if (playing_hand.is_empty()) { [INFO] [stdout] 123 + if playing_hand.is_empty() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:124:6 [INFO] [stdout] | [INFO] [stdout] 124 | if (deck.is_empty()) { // game is over [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 124 - if (deck.is_empty()) { // game is over [INFO] [stdout] 124 + if deck.is_empty() { // game is over [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/main.rs:137:8 [INFO] [stdout] | [INFO] [stdout] 137 | while (!card_in(playing_hand, &guess)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 137 - while (!card_in(playing_hand, &guess)) { [INFO] [stdout] 137 + while !card_in(playing_hand, &guess) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:148:5 [INFO] [stdout] | [INFO] [stdout] 148 | if (correct) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 148 - if (correct) { [INFO] [stdout] 148 + if correct { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:157:5 [INFO] [stdout] | [INFO] [stdout] 157 | if (comp_hand.is_empty()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 157 - if (comp_hand.is_empty()) { [INFO] [stdout] 157 + if comp_hand.is_empty() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:158:6 [INFO] [stdout] | [INFO] [stdout] 158 | if (deck.is_empty()) { // game is over [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 158 - if (deck.is_empty()) { // game is over [INFO] [stdout] 158 + if deck.is_empty() { // game is over [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:183:5 [INFO] [stdout] | [INFO] [stdout] 183 | if (correct) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 183 - if (correct) { [INFO] [stdout] 183 + if correct { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:191:6 [INFO] [stdout] | [INFO] [stdout] 191 | if (c == card) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 191 - if (c == card) { [INFO] [stdout] 191 + if c == card { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:202:5 [INFO] [stdout] | [INFO] [stdout] 202 | if (card_in(other_hand, &guess)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 202 - if (card_in(other_hand, &guess)) { [INFO] [stdout] 202 + if card_in(other_hand, &guess) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:208:7 [INFO] [stdout] | [INFO] [stdout] 208 | if (c == &guess) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 208 - if (c == &guess) { [INFO] [stdout] 208 + if c == &guess { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:230:10 [INFO] [stdout] | [INFO] [stdout] 230 | if (is_player) { println!("Drew {}", &x); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 230 - if (is_player) { println!("Drew {}", &x); } [INFO] [stdout] 230 + if is_player { println!("Drew {}", &x); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:239:7 [INFO] [stdout] | [INFO] [stdout] 239 | if (c == guess) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 239 - if (c == guess) { [INFO] [stdout] 239 + if c == guess { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:243:6 [INFO] [stdout] | [INFO] [stdout] 243 | if (count == 4) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 243 - if (count == 4) { [INFO] [stdout] 243 + if count == 4 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:250:5 [INFO] [stdout] | [INFO] [stdout] 250 | if (comp_finished.len() > player_finished.len()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 250 - if (comp_finished.len() > player_finished.len()) { [INFO] [stdout] 250 + if comp_finished.len() > player_finished.len() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: denote infinite loops with `loop { ... }` [INFO] [stdout] --> src/main.rs:271:2 [INFO] [stdout] | [INFO] [stdout] 271 | while true { [INFO] [stdout] | ^^^^^^^^^^ help: use `loop` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(while_true)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:272:6 [INFO] [stdout] | [INFO] [stdout] 272 | if (deck.is_empty() && player_hand.is_empty()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 272 - if (deck.is_empty() && player_hand.is_empty()) { [INFO] [stdout] 272 + if deck.is_empty() && player_hand.is_empty() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `core::str::::trim_right`: superseded by `trim_end` [INFO] [stdout] --> src/main.rs:135:25 [INFO] [stdout] | [INFO] [stdout] 135 | let mut guess = buffer.trim_right().to_string(); [INFO] [stdout] | ^^^^^^^^^^ help: replace the use of the deprecated associated function: `trim_end` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `core::str::::trim_right`: superseded by `trim_end` [INFO] [stdout] --> src/main.rs:143:18 [INFO] [stdout] | [INFO] [stdout] 143 | guess = buffer.trim_right().to_string(); [INFO] [stdout] | ^^^^^^^^^^ help: replace the use of the deprecated associated function: `trim_end` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `core::str::::trim_right`: superseded by `trim_end` [INFO] [stdout] --> src/main.rs:146:21 [INFO] [stdout] | [INFO] [stdout] 146 | &mut deck, guess.trim_right().to_string(), true); [INFO] [stdout] | ^^^^^^^^^^ help: replace the use of the deprecated associated function: `trim_end` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `core::str::::trim_right`: superseded by `trim_end` [INFO] [stdout] --> src/main.rs:181:21 [INFO] [stdout] | [INFO] [stdout] 181 | &mut deck, guess.trim_right().to_string(), false); [INFO] [stdout] | ^^^^^^^^^^ help: replace the use of the deprecated associated function: `trim_end` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `suite` [INFO] [stdout] --> src/main.rs:50:7 [INFO] [stdout] | [INFO] [stdout] 50 | for suite in 0..NUM_SUITES { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_suite` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/main.rs:95:6 [INFO] [stdout] | [INFO] [stdout] 95 | for i in 0..NUM_HAND { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 35 | fn shuffle(mut cards: &mut Vec) { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:133:6 [INFO] [stdout] | [INFO] [stdout] 133 | let mut buffer = &mut String::new(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:199:2 [INFO] [stdout] | [INFO] [stdout] 199 | mut other_hand: &mut Vec, mut deck: &mut Vec, guess: String, is_player: bool) -> bool { [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `ranks` should have an upper case name [INFO] [stdout] --> src/main.rs:28:7 [INFO] [stdout] | [INFO] [stdout] 28 | const ranks: [&'static str; NUM_RANKS as usize] = ["ace", "one", "two", "three", "four", "five", "six", [INFO] [stdout] | ^^^^^ help: convert the identifier to upper case: `RANKS` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:134:2 [INFO] [stdout] | [INFO] [stdout] 134 | std::io::stdin().read_line(buffer); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:142:6 [INFO] [stdout] | [INFO] [stdout] 142 | std::io::stdin().read_line(buffer); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 31 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.19s [INFO] running `Command { std: "docker" "inspect" "e4921680b4887a40c1669c451b1fb5ed88e430a97db6185de3373954e216c8d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e4921680b4887a40c1669c451b1fb5ed88e430a97db6185de3373954e216c8d8", kill_on_drop: false }` [INFO] [stdout] e4921680b4887a40c1669c451b1fb5ed88e430a97db6185de3373954e216c8d8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-27/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-27/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:b0c94ce3c1162fcb8e57cac5b65ec2f72eabb1eebea4fcc35e269e823f681646" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2022-04-10" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c23230f3481d0aa71aef610ded655d18dbe7a358ddc8b96c8550349dd561c681 [INFO] running `Command { std: "docker" "start" "-a" "c23230f3481d0aa71aef610ded655d18dbe7a358ddc8b96c8550349dd561c681", kill_on_drop: false }` [INFO] [stderr] Compiling new_rust_project v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `Write`, `stdin`, `stdout` [INFO] [stdout] --> src/main.rs:7:15 [INFO] [stdout] | [INFO] [stdout] 7 | use std::io::{Write, stdout, stdin}; [INFO] [stdout] | ^^^^^ ^^^^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:59:6 [INFO] [stdout] | [INFO] [stdout] 59 | if (ranks[i] == card) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 59 - if (ranks[i] == card) { [INFO] [stdout] 59 + if ranks[i] == card { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:80:7 [INFO] [stdout] | [INFO] [stdout] 80 | if (new < min_val) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 80 - if (new < min_val) { [INFO] [stdout] 80 + if new < min_val { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 123 | if (playing_hand.is_empty()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 123 - if (playing_hand.is_empty()) { [INFO] [stdout] 123 + if playing_hand.is_empty() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:124:6 [INFO] [stdout] | [INFO] [stdout] 124 | if (deck.is_empty()) { // game is over [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 124 - if (deck.is_empty()) { // game is over [INFO] [stdout] 124 + if deck.is_empty() { // game is over [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/main.rs:137:8 [INFO] [stdout] | [INFO] [stdout] 137 | while (!card_in(playing_hand, &guess)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 137 - while (!card_in(playing_hand, &guess)) { [INFO] [stdout] 137 + while !card_in(playing_hand, &guess) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:148:5 [INFO] [stdout] | [INFO] [stdout] 148 | if (correct) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 148 - if (correct) { [INFO] [stdout] 148 + if correct { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:157:5 [INFO] [stdout] | [INFO] [stdout] 157 | if (comp_hand.is_empty()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 157 - if (comp_hand.is_empty()) { [INFO] [stdout] 157 + if comp_hand.is_empty() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:158:6 [INFO] [stdout] | [INFO] [stdout] 158 | if (deck.is_empty()) { // game is over [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 158 - if (deck.is_empty()) { // game is over [INFO] [stdout] 158 + if deck.is_empty() { // game is over [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:183:5 [INFO] [stdout] | [INFO] [stdout] 183 | if (correct) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 183 - if (correct) { [INFO] [stdout] 183 + if correct { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:191:6 [INFO] [stdout] | [INFO] [stdout] 191 | if (c == card) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 191 - if (c == card) { [INFO] [stdout] 191 + if c == card { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:202:5 [INFO] [stdout] | [INFO] [stdout] 202 | if (card_in(other_hand, &guess)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 202 - if (card_in(other_hand, &guess)) { [INFO] [stdout] 202 + if card_in(other_hand, &guess) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:208:7 [INFO] [stdout] | [INFO] [stdout] 208 | if (c == &guess) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 208 - if (c == &guess) { [INFO] [stdout] 208 + if c == &guess { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:230:10 [INFO] [stdout] | [INFO] [stdout] 230 | if (is_player) { println!("Drew {}", &x); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 230 - if (is_player) { println!("Drew {}", &x); } [INFO] [stdout] 230 + if is_player { println!("Drew {}", &x); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:239:7 [INFO] [stdout] | [INFO] [stdout] 239 | if (c == guess) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 239 - if (c == guess) { [INFO] [stdout] 239 + if c == guess { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:243:6 [INFO] [stdout] | [INFO] [stdout] 243 | if (count == 4) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 243 - if (count == 4) { [INFO] [stdout] 243 + if count == 4 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:250:5 [INFO] [stdout] | [INFO] [stdout] 250 | if (comp_finished.len() > player_finished.len()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 250 - if (comp_finished.len() > player_finished.len()) { [INFO] [stdout] 250 + if comp_finished.len() > player_finished.len() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: denote infinite loops with `loop { ... }` [INFO] [stdout] --> src/main.rs:271:2 [INFO] [stdout] | [INFO] [stdout] 271 | while true { [INFO] [stdout] | ^^^^^^^^^^ help: use `loop` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(while_true)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:272:6 [INFO] [stdout] | [INFO] [stdout] 272 | if (deck.is_empty() && player_hand.is_empty()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 272 - if (deck.is_empty() && player_hand.is_empty()) { [INFO] [stdout] 272 + if deck.is_empty() && player_hand.is_empty() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `core::str::::trim_right`: superseded by `trim_end` [INFO] [stdout] --> src/main.rs:135:25 [INFO] [stdout] | [INFO] [stdout] 135 | let mut guess = buffer.trim_right().to_string(); [INFO] [stdout] | ^^^^^^^^^^ help: replace the use of the deprecated associated function: `trim_end` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `core::str::::trim_right`: superseded by `trim_end` [INFO] [stdout] --> src/main.rs:143:18 [INFO] [stdout] | [INFO] [stdout] 143 | guess = buffer.trim_right().to_string(); [INFO] [stdout] | ^^^^^^^^^^ help: replace the use of the deprecated associated function: `trim_end` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `core::str::::trim_right`: superseded by `trim_end` [INFO] [stdout] --> src/main.rs:146:21 [INFO] [stdout] | [INFO] [stdout] 146 | &mut deck, guess.trim_right().to_string(), true); [INFO] [stdout] | ^^^^^^^^^^ help: replace the use of the deprecated associated function: `trim_end` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `core::str::::trim_right`: superseded by `trim_end` [INFO] [stdout] --> src/main.rs:181:21 [INFO] [stdout] | [INFO] [stdout] 181 | &mut deck, guess.trim_right().to_string(), false); [INFO] [stdout] | ^^^^^^^^^^ help: replace the use of the deprecated associated function: `trim_end` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `suite` [INFO] [stdout] --> src/main.rs:50:7 [INFO] [stdout] | [INFO] [stdout] 50 | for suite in 0..NUM_SUITES { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_suite` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/main.rs:95:6 [INFO] [stdout] | [INFO] [stdout] 95 | for i in 0..NUM_HAND { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 35 | fn shuffle(mut cards: &mut Vec) { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:133:6 [INFO] [stdout] | [INFO] [stdout] 133 | let mut buffer = &mut String::new(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:199:2 [INFO] [stdout] | [INFO] [stdout] 199 | mut other_hand: &mut Vec, mut deck: &mut Vec, guess: String, is_player: bool) -> bool { [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `ranks` should have an upper case name [INFO] [stdout] --> src/main.rs:28:7 [INFO] [stdout] | [INFO] [stdout] 28 | const ranks: [&'static str; NUM_RANKS as usize] = ["ace", "one", "two", "three", "four", "five", "six", [INFO] [stdout] | ^^^^^ help: convert the identifier to upper case: `RANKS` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:134:2 [INFO] [stdout] | [INFO] [stdout] 134 | std::io::stdin().read_line(buffer); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:142:6 [INFO] [stdout] | [INFO] [stdout] 142 | std::io::stdin().read_line(buffer); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 31 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 0.46s [INFO] [stderr] Executable unittests src/lib.rs (/opt/rustwide/target/debug/deps/new_rust_project-02471451f7887cc5) [INFO] [stderr] Executable unittests src/main.rs (/opt/rustwide/target/debug/deps/new_rust_project-2f896ab28dde21ee) [INFO] running `Command { std: "docker" "inspect" "c23230f3481d0aa71aef610ded655d18dbe7a358ddc8b96c8550349dd561c681", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c23230f3481d0aa71aef610ded655d18dbe7a358ddc8b96c8550349dd561c681", kill_on_drop: false }` [INFO] [stdout] c23230f3481d0aa71aef610ded655d18dbe7a358ddc8b96c8550349dd561c681 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-27/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-27/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:b0c94ce3c1162fcb8e57cac5b65ec2f72eabb1eebea4fcc35e269e823f681646" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2022-04-10" "test" "--frozen", kill_on_drop: false }` [INFO] [stdout] 94b79d63b4f33b87d6ea72200e5965c6721341dacb7230256ac2fbb4fd888d94 [INFO] running `Command { std: "docker" "start" "-a" "94b79d63b4f33b87d6ea72200e5965c6721341dacb7230256ac2fbb4fd888d94", kill_on_drop: false }` [INFO] [stderr] warning: unused imports: `Write`, `stdin`, `stdout` [INFO] [stderr] --> src/main.rs:7:15 [INFO] [stderr] | [INFO] [stderr] 7 | use std::io::{Write, stdout, stdin}; [INFO] [stderr] | ^^^^^ ^^^^^^ ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:59:6 [INFO] [stderr] | [INFO] [stderr] 59 | if (ranks[i] == card) { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 59 - if (ranks[i] == card) { [INFO] [stderr] 59 + if ranks[i] == card { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:80:7 [INFO] [stderr] | [INFO] [stderr] 80 | if (new < min_val) { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 80 - if (new < min_val) { [INFO] [stderr] 80 + if new < min_val { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | if (playing_hand.is_empty()) { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 123 - if (playing_hand.is_empty()) { [INFO] [stderr] 123 + if playing_hand.is_empty() { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:124:6 [INFO] [stderr] | [INFO] [stderr] 124 | if (deck.is_empty()) { // game is over [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 124 - if (deck.is_empty()) { // game is over [INFO] [stderr] 124 + if deck.is_empty() { // game is over [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `while` condition [INFO] [stderr] --> src/main.rs:137:8 [INFO] [stderr] | [INFO] [stderr] 137 | while (!card_in(playing_hand, &guess)) { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 137 - while (!card_in(playing_hand, &guess)) { [INFO] [stderr] 137 + while !card_in(playing_hand, &guess) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | if (correct) { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 148 - if (correct) { [INFO] [stderr] 148 + if correct { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:157:5 [INFO] [stderr] | [INFO] [stderr] 157 | if (comp_hand.is_empty()) { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 157 - if (comp_hand.is_empty()) { [INFO] [stderr] 157 + if comp_hand.is_empty() { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:158:6 [INFO] [stderr] | [INFO] [stderr] 158 | if (deck.is_empty()) { // game is over [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 158 - if (deck.is_empty()) { // game is over [INFO] [stderr] 158 + if deck.is_empty() { // game is over [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:183:5 [INFO] [stderr] | [INFO] [stderr] 183 | if (correct) { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 183 - if (correct) { [INFO] [stderr] 183 + if correct { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:191:6 [INFO] [stderr] | [INFO] [stderr] 191 | if (c == card) { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 191 - if (c == card) { [INFO] [stderr] 191 + if c == card { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:202:5 [INFO] [stderr] | [INFO] [stderr] 202 | if (card_in(other_hand, &guess)) { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 202 - if (card_in(other_hand, &guess)) { [INFO] [stderr] 202 + if card_in(other_hand, &guess) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:208:7 [INFO] [stderr] | [INFO] [stderr] 208 | if (c == &guess) { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 208 - if (c == &guess) { [INFO] [stderr] 208 + if c == &guess { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:230:10 [INFO] [stderr] | [INFO] [stderr] 230 | if (is_player) { println!("Drew {}", &x); } [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 230 - if (is_player) { println!("Drew {}", &x); } [INFO] [stderr] 230 + if is_player { println!("Drew {}", &x); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:239:7 [INFO] [stderr] | [INFO] [stderr] 239 | if (c == guess) { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 239 - if (c == guess) { [INFO] [stderr] 239 + if c == guess { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:243:6 [INFO] [stderr] | [INFO] [stderr] 243 | if (count == 4) { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 243 - if (count == 4) { [INFO] [stderr] 243 + if count == 4 { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:250:5 [INFO] [stderr] | [INFO] [stderr] 250 | if (comp_finished.len() > player_finished.len()) { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 250 - if (comp_finished.len() > player_finished.len()) { [INFO] [stderr] 250 + if comp_finished.len() > player_finished.len() { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: denote infinite loops with `loop { ... }` [INFO] [stderr] --> src/main.rs:271:2 [INFO] [stderr] | [INFO] [stderr] 271 | while true { [INFO] [stderr] | ^^^^^^^^^^ help: use `loop` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(while_true)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:272:6 [INFO] [stderr] | [INFO] [stderr] 272 | if (deck.is_empty() && player_hand.is_empty()) { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 272 - if (deck.is_empty() && player_hand.is_empty()) { [INFO] [stderr] 272 + if deck.is_empty() && player_hand.is_empty() { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of deprecated associated function `core::str::::trim_right`: superseded by `trim_end` [INFO] [stderr] --> src/main.rs:135:25 [INFO] [stderr] | [INFO] [stderr] 135 | let mut guess = buffer.trim_right().to_string(); [INFO] [stderr] | ^^^^^^^^^^ help: replace the use of the deprecated associated function: `trim_end` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(deprecated)]` on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated associated function `core::str::::trim_right`: superseded by `trim_end` [INFO] [stderr] --> src/main.rs:143:18 [INFO] [stderr] | [INFO] [stderr] 143 | guess = buffer.trim_right().to_string(); [INFO] [stderr] | ^^^^^^^^^^ help: replace the use of the deprecated associated function: `trim_end` [INFO] [stderr] [INFO] [stderr] warning: use of deprecated associated function `core::str::::trim_right`: superseded by `trim_end` [INFO] [stderr] --> src/main.rs:146:21 [INFO] [stderr] | [INFO] [stderr] 146 | &mut deck, guess.trim_right().to_string(), true); [INFO] [stderr] | ^^^^^^^^^^ help: replace the use of the deprecated associated function: `trim_end` [INFO] [stderr] [INFO] [stderr] warning: use of deprecated associated function `core::str::::trim_right`: superseded by `trim_end` [INFO] [stderr] --> src/main.rs:181:21 [INFO] [stderr] | [INFO] [stderr] 181 | &mut deck, guess.trim_right().to_string(), false); [INFO] [stderr] | ^^^^^^^^^^ help: replace the use of the deprecated associated function: `trim_end` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `suite` [INFO] [stderr] --> src/main.rs:50:7 [INFO] [stderr] | [INFO] [stderr] 50 | for suite in 0..NUM_SUITES { [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_suite` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/main.rs:95:6 [INFO] [stderr] | [INFO] [stderr] 95 | for i in 0..NUM_HAND { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:35:12 [INFO] [stderr] | [INFO] [stderr] 35 | fn shuffle(mut cards: &mut Vec) { [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:133:6 [INFO] [stderr] | [INFO] [stderr] 133 | let mut buffer = &mut String::new(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:199:2 [INFO] [stderr] | [INFO] [stderr] 199 | mut other_hand: &mut Vec, mut deck: &mut Vec, guess: String, is_player: bool) -> bool { [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: constant `ranks` should have an upper case name [INFO] [stderr] --> src/main.rs:28:7 [INFO] [stderr] | [INFO] [stderr] 28 | const ranks: [&'static str; NUM_RANKS as usize] = ["ace", "one", "two", "three", "four", "five", "six", [INFO] [stderr] | ^^^^^ help: convert the identifier to upper case: `RANKS` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/main.rs:134:2 [INFO] [stderr] | [INFO] [stderr] 134 | std::io::stdin().read_line(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_must_use)]` on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/main.rs:142:6 [INFO] [stderr] | [INFO] [stderr] 142 | std::io::stdin().read_line(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: `new_rust_project` (bin "new_rust_project" test) generated 31 warnings [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 0.02s [INFO] [stderr] Running unittests src/lib.rs (/opt/rustwide/target/debug/deps/new_rust_project-02471451f7887cc5) [INFO] [stdout] [INFO] [stderr] Running unittests src/main.rs (/opt/rustwide/target/debug/deps/new_rust_project-2f896ab28dde21ee) [INFO] [stdout] running 0 tests [INFO] [stderr] Doc-tests new_rust_project [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "94b79d63b4f33b87d6ea72200e5965c6721341dacb7230256ac2fbb4fd888d94", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "94b79d63b4f33b87d6ea72200e5965c6721341dacb7230256ac2fbb4fd888d94", kill_on_drop: false }` [INFO] [stdout] 94b79d63b4f33b87d6ea72200e5965c6721341dacb7230256ac2fbb4fd888d94