[INFO] cloning repository https://github.com/DaanMiddelkoop/RealisticCircles [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DaanMiddelkoop/RealisticCircles" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDaanMiddelkoop%2FRealisticCircles", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDaanMiddelkoop%2FRealisticCircles'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 418efa2f5d5a1eea0cbbe574096e90787e8c5dc1 [INFO] testing DaanMiddelkoop/RealisticCircles against beta-2022-04-10 for beta-1.61-1 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDaanMiddelkoop%2FRealisticCircles" "/workspace/builds/worker-5/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5/source'... [INFO] [stderr] done. [INFO] [stderr] Updating files: 32% (213/665) Updating files: 33% (220/665) Updating files: 34% (227/665) Updating files: 35% (233/665) Updating files: 36% (240/665) Updating files: 37% (247/665) Updating files: 38% (253/665) Updating files: 39% (260/665) Updating files: 40% (266/665) Updating files: 41% (273/665) Updating files: 42% (280/665) Updating files: 43% (286/665) Updating files: 44% (293/665) Updating files: 45% (300/665) Updating files: 46% (306/665) Updating files: 47% (313/665) Updating files: 48% (320/665) Updating files: 49% (326/665) Updating files: 50% (333/665) Updating files: 51% (340/665) Updating files: 52% (346/665) Updating files: 53% (353/665) Updating files: 54% (360/665) Updating files: 55% (366/665) Updating files: 56% (373/665) Updating files: 57% (380/665) Updating files: 58% (386/665) Updating files: 59% (393/665) Updating files: 60% (399/665) Updating files: 61% (406/665) Updating files: 62% (413/665) Updating files: 63% (419/665) Updating files: 64% (426/665) Updating files: 65% (433/665) Updating files: 66% (439/665) Updating files: 67% (446/665) Updating files: 68% (453/665) Updating files: 69% (459/665) Updating files: 70% (466/665) Updating files: 71% (473/665) Updating files: 72% (479/665) Updating files: 73% (486/665) Updating files: 74% (493/665) Updating files: 75% (499/665) Updating files: 76% (506/665) Updating files: 77% (513/665) Updating files: 78% (519/665) Updating files: 79% (526/665) Updating files: 80% (532/665) Updating files: 81% (539/665) Updating files: 82% (546/665) Updating files: 83% (552/665) Updating files: 84% (559/665) Updating files: 85% (566/665) Updating files: 86% (572/665) Updating files: 87% (579/665) Updating files: 88% (586/665) Updating files: 89% (592/665) Updating files: 90% (599/665) Updating files: 91% (606/665) Updating files: 92% (612/665) Updating files: 93% (619/665) Updating files: 94% (626/665) Updating files: 95% (632/665) Updating files: 96% (639/665) Updating files: 97% (646/665) Updating files: 98% (652/665) Updating files: 99% (659/665) Updating files: 100% (665/665) Updating files: 100% (665/665), done. [INFO] validating manifest of git repo https://github.com/DaanMiddelkoop/RealisticCircles on toolchain beta-2022-04-10 [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+beta-2022-04-10" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/DaanMiddelkoop/RealisticCircles [INFO] finished tweaking git repo https://github.com/DaanMiddelkoop/RealisticCircles [INFO] tweaked toml for git repo https://github.com/DaanMiddelkoop/RealisticCircles written to /workspace/builds/worker-5/source/Cargo.toml [INFO] crate git repo https://github.com/DaanMiddelkoop/RealisticCircles already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+beta-2022-04-10" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:b0c94ce3c1162fcb8e57cac5b65ec2f72eabb1eebea4fcc35e269e823f681646" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2022-04-10" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6dcb3c47efed81885a7dee04381cb999636ddee80f845393c2dc76df6d0dde20 [INFO] running `Command { std: "docker" "start" "-a" "6dcb3c47efed81885a7dee04381cb999636ddee80f845393c2dc76df6d0dde20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6dcb3c47efed81885a7dee04381cb999636ddee80f845393c2dc76df6d0dde20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6dcb3c47efed81885a7dee04381cb999636ddee80f845393c2dc76df6d0dde20", kill_on_drop: false }` [INFO] [stdout] 6dcb3c47efed81885a7dee04381cb999636ddee80f845393c2dc76df6d0dde20 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:b0c94ce3c1162fcb8e57cac5b65ec2f72eabb1eebea4fcc35e269e823f681646" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2022-04-10" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 771a54b4c7d6a328bd0169d373b33b05131bb4741481949e7c4b891af1dc869f [INFO] running `Command { std: "docker" "start" "-a" "771a54b4c7d6a328bd0169d373b33b05131bb4741481949e7c4b891af1dc869f", kill_on_drop: false }` [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling void v1.0.2 [INFO] [stderr] Compiling version_check v0.1.4 [INFO] [stderr] Compiling libc v0.2.43 [INFO] [stderr] Compiling scopeguard v0.3.3 [INFO] [stderr] Compiling stable_deref_trait v1.1.1 [INFO] [stderr] Compiling rand_core v0.2.1 [INFO] [stderr] Compiling nodrop v0.1.12 [INFO] [stderr] Compiling memoffset v0.2.1 [INFO] [stderr] Compiling cfg-if v0.1.5 [INFO] [stderr] Compiling crossbeam-utils v0.5.0 [INFO] [stderr] Compiling byteorder v1.2.6 [INFO] [stderr] Compiling owning_ref v0.3.3 [INFO] [stderr] Compiling unreachable v1.0.0 [INFO] [stderr] Compiling arrayvec v0.4.7 [INFO] [stderr] Compiling bmp v0.4.0 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling smallvec v0.6.5 [INFO] [stderr] Compiling lazy_static v1.1.0 [INFO] [stderr] Compiling lock_api v0.1.3 [INFO] [stderr] Compiling rand v0.5.5 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling parking_lot_core v0.3.1 [INFO] [stderr] Compiling crossbeam-epoch v0.5.2 [INFO] [stderr] Compiling parking_lot v0.6.4 [INFO] [stderr] Compiling crossbeam-channel v0.2.4 [INFO] [stderr] Compiling threads_pool v0.1.7 [INFO] [stderr] Compiling RealisticCircles v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/vector.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 34 | if (self.length < 0.0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 34 - if (self.length < 0.0) { [INFO] [stdout] 34 + if self.length < 0.0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:107:8 [INFO] [stdout] | [INFO] [stdout] 107 | if (result.hit) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 107 - if (result.hit) { [INFO] [stdout] 107 + if result.hit { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:130:12 [INFO] [stdout] | [INFO] [stdout] 130 | if (result.hit && result.distance < closest_dist) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 130 - if (result.hit && result.distance < closest_dist) { [INFO] [stdout] 130 + if result.hit && result.distance < closest_dist { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:148:8 [INFO] [stdout] | [INFO] [stdout] 148 | if (b >= sphere.radius || angle > f32::consts::PI / 2.0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 148 - if (b >= sphere.radius || angle > f32::consts::PI / 2.0) { [INFO] [stdout] 148 + if b >= sphere.radius || angle > f32::consts::PI / 2.0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:170:8 [INFO] [stdout] | [INFO] [stdout] 170 | if (bounces > 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 170 - if (bounces > 0) { [INFO] [stdout] 170 + if bounces > 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:188:12 [INFO] [stdout] | [INFO] [stdout] 188 | if (new_result.hit && new_result.distance < new_direction.length()&& new_result.distance > 0.01) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 188 - if (new_result.hit && new_result.distance < new_direction.length()&& new_result.distance > 0.01) { [INFO] [stdout] 188 + if new_result.hit && new_result.distance < new_direction.length()&& new_result.distance > 0.01 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:215:12 [INFO] [stdout] | [INFO] [stdout] 215 | if (new_result.hit) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 215 - if (new_result.hit) { [INFO] [stdout] 215 + if new_result.hit { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/main.rs:243:11 [INFO] [stdout] | [INFO] [stdout] 243 | while ((random.x * random.x) + (random.y * random.y) + (random.z * random.z) > 1.0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 243 - while ((random.x * random.x) + (random.y * random.y) + (random.z * random.z) > 1.0) { [INFO] [stdout] 243 + while (random.x * random.x) + (random.y * random.y) + (random.z * random.z) > 1.0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `width` [INFO] [stdout] --> src/main.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | let width = bitmap.get_width(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_width` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `worker_id` [INFO] [stdout] --> src/main.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | let mut worker_id = pool.get_first_worker_id().unwrap() as u32; [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_worker_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `poollock` [INFO] [stdout] --> src/main.rs:48:17 [INFO] [stdout] | [INFO] [stdout] 48 | let poollock = c.clone(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_poollock` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `total_color` [INFO] [stdout] --> src/main.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 178 | let mut total_color = Vector::new(1.0, 1.0, 1.0); [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_total_color` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `hit_something` [INFO] [stdout] --> src/main.rs:180:13 [INFO] [stdout] | [INFO] [stdout] 180 | let mut hit_something = false; [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_hit_something` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | let mut bitmap = bmp::open("2000x2000.bmp").unwrap(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | let mut worker_id = pool.get_first_worker_id().unwrap() as u32; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | let mut result = trace_ray(position, trace_direction, world, 2); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 178 | let mut total_color = Vector::new(1.0, 1.0, 1.0); [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | let mut hit_something = false; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:268:9 [INFO] [stdout] | [INFO] [stdout] 268 | let mut result = direction.add(&term); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: crate `RealisticCircles` should have a snake case name [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] = help: convert the identifier to snake case: `realistic_circles` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `crossProduct` should have a snake case name [INFO] [stdout] --> src/vector.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn crossProduct(&self, other: &Vector) -> Vector { [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `cross_product` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 21 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.65s [INFO] running `Command { std: "docker" "inspect" "771a54b4c7d6a328bd0169d373b33b05131bb4741481949e7c4b891af1dc869f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "771a54b4c7d6a328bd0169d373b33b05131bb4741481949e7c4b891af1dc869f", kill_on_drop: false }` [INFO] [stdout] 771a54b4c7d6a328bd0169d373b33b05131bb4741481949e7c4b891af1dc869f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:b0c94ce3c1162fcb8e57cac5b65ec2f72eabb1eebea4fcc35e269e823f681646" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2022-04-10" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 07d524b1ac89deb08b4e565a21cb94423d78d58244b910d7141942ad4d0b2255 [INFO] running `Command { std: "docker" "start" "-a" "07d524b1ac89deb08b4e565a21cb94423d78d58244b910d7141942ad4d0b2255", kill_on_drop: false }` [INFO] [stderr] Compiling RealisticCircles v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/vector.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 34 | if (self.length < 0.0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 34 - if (self.length < 0.0) { [INFO] [stdout] 34 + if self.length < 0.0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:107:8 [INFO] [stdout] | [INFO] [stdout] 107 | if (result.hit) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 107 - if (result.hit) { [INFO] [stdout] 107 + if result.hit { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:130:12 [INFO] [stdout] | [INFO] [stdout] 130 | if (result.hit && result.distance < closest_dist) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 130 - if (result.hit && result.distance < closest_dist) { [INFO] [stdout] 130 + if result.hit && result.distance < closest_dist { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:148:8 [INFO] [stdout] | [INFO] [stdout] 148 | if (b >= sphere.radius || angle > f32::consts::PI / 2.0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 148 - if (b >= sphere.radius || angle > f32::consts::PI / 2.0) { [INFO] [stdout] 148 + if b >= sphere.radius || angle > f32::consts::PI / 2.0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:170:8 [INFO] [stdout] | [INFO] [stdout] 170 | if (bounces > 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 170 - if (bounces > 0) { [INFO] [stdout] 170 + if bounces > 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:188:12 [INFO] [stdout] | [INFO] [stdout] 188 | if (new_result.hit && new_result.distance < new_direction.length()&& new_result.distance > 0.01) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 188 - if (new_result.hit && new_result.distance < new_direction.length()&& new_result.distance > 0.01) { [INFO] [stdout] 188 + if new_result.hit && new_result.distance < new_direction.length()&& new_result.distance > 0.01 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:215:12 [INFO] [stdout] | [INFO] [stdout] 215 | if (new_result.hit) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 215 - if (new_result.hit) { [INFO] [stdout] 215 + if new_result.hit { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/main.rs:243:11 [INFO] [stdout] | [INFO] [stdout] 243 | while ((random.x * random.x) + (random.y * random.y) + (random.z * random.z) > 1.0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 243 - while ((random.x * random.x) + (random.y * random.y) + (random.z * random.z) > 1.0) { [INFO] [stdout] 243 + while (random.x * random.x) + (random.y * random.y) + (random.z * random.z) > 1.0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `width` [INFO] [stdout] --> src/main.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | let width = bitmap.get_width(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_width` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `worker_id` [INFO] [stdout] --> src/main.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | let mut worker_id = pool.get_first_worker_id().unwrap() as u32; [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_worker_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `poollock` [INFO] [stdout] --> src/main.rs:48:17 [INFO] [stdout] | [INFO] [stdout] 48 | let poollock = c.clone(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_poollock` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `total_color` [INFO] [stdout] --> src/main.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 178 | let mut total_color = Vector::new(1.0, 1.0, 1.0); [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_total_color` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `hit_something` [INFO] [stdout] --> src/main.rs:180:13 [INFO] [stdout] | [INFO] [stdout] 180 | let mut hit_something = false; [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_hit_something` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | let mut bitmap = bmp::open("2000x2000.bmp").unwrap(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | let mut worker_id = pool.get_first_worker_id().unwrap() as u32; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | let mut result = trace_ray(position, trace_direction, world, 2); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 178 | let mut total_color = Vector::new(1.0, 1.0, 1.0); [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | let mut hit_something = false; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:268:9 [INFO] [stdout] | [INFO] [stdout] 268 | let mut result = direction.add(&term); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: crate `RealisticCircles` should have a snake case name [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] = help: convert the identifier to snake case: `realistic_circles` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `crossProduct` should have a snake case name [INFO] [stdout] --> src/vector.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn crossProduct(&self, other: &Vector) -> Vector { [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `cross_product` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 21 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 0.81s [INFO] [stderr] Executable unittests src/main.rs (/opt/rustwide/target/debug/deps/RealisticCircles-db0b84bf9c3b3cf3) [INFO] running `Command { std: "docker" "inspect" "07d524b1ac89deb08b4e565a21cb94423d78d58244b910d7141942ad4d0b2255", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "07d524b1ac89deb08b4e565a21cb94423d78d58244b910d7141942ad4d0b2255", kill_on_drop: false }` [INFO] [stdout] 07d524b1ac89deb08b4e565a21cb94423d78d58244b910d7141942ad4d0b2255 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:b0c94ce3c1162fcb8e57cac5b65ec2f72eabb1eebea4fcc35e269e823f681646" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2022-04-10" "test" "--frozen", kill_on_drop: false }` [INFO] [stdout] b585a9d90e7c7010541610afa9711633d57834f8164cb54ba8f273f979eb9fc2 [INFO] running `Command { std: "docker" "start" "-a" "b585a9d90e7c7010541610afa9711633d57834f8164cb54ba8f273f979eb9fc2", kill_on_drop: false }` [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/vector.rs:34:12 [INFO] [stderr] | [INFO] [stderr] 34 | if (self.length < 0.0) { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 34 - if (self.length < 0.0) { [INFO] [stderr] 34 + if self.length < 0.0 { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:107:8 [INFO] [stderr] | [INFO] [stderr] 107 | if (result.hit) { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 107 - if (result.hit) { [INFO] [stderr] 107 + if result.hit { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:130:12 [INFO] [stderr] | [INFO] [stderr] 130 | if (result.hit && result.distance < closest_dist) { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 130 - if (result.hit && result.distance < closest_dist) { [INFO] [stderr] 130 + if result.hit && result.distance < closest_dist { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:148:8 [INFO] [stderr] | [INFO] [stderr] 148 | if (b >= sphere.radius || angle > f32::consts::PI / 2.0) { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 148 - if (b >= sphere.radius || angle > f32::consts::PI / 2.0) { [INFO] [stderr] 148 + if b >= sphere.radius || angle > f32::consts::PI / 2.0 { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:170:8 [INFO] [stderr] | [INFO] [stderr] 170 | if (bounces > 0) { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 170 - if (bounces > 0) { [INFO] [stderr] 170 + if bounces > 0 { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:188:12 [INFO] [stderr] | [INFO] [stderr] 188 | if (new_result.hit && new_result.distance < new_direction.length()&& new_result.distance > 0.01) { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 188 - if (new_result.hit && new_result.distance < new_direction.length()&& new_result.distance > 0.01) { [INFO] [stderr] 188 + if new_result.hit && new_result.distance < new_direction.length()&& new_result.distance > 0.01 { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:215:12 [INFO] [stderr] | [INFO] [stderr] 215 | if (new_result.hit) { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 215 - if (new_result.hit) { [INFO] [stderr] 215 + if new_result.hit { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `while` condition [INFO] [stderr] --> src/main.rs:243:11 [INFO] [stderr] | [INFO] [stderr] 243 | while ((random.x * random.x) + (random.y * random.y) + (random.z * random.z) > 1.0) { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 243 - while ((random.x * random.x) + (random.y * random.y) + (random.z * random.z) > 1.0) { [INFO] [stderr] 243 + while (random.x * random.x) + (random.y * random.y) + (random.z * random.z) > 1.0 { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `width` [INFO] [stderr] --> src/main.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | let width = bitmap.get_width(); [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_width` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `worker_id` [INFO] [stderr] --> src/main.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | let mut worker_id = pool.get_first_worker_id().unwrap() as u32; [INFO] [stderr] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_worker_id` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `poollock` [INFO] [stderr] --> src/main.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | let poollock = c.clone(); [INFO] [stderr] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_poollock` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `total_color` [INFO] [stderr] --> src/main.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | let mut total_color = Vector::new(1.0, 1.0, 1.0); [INFO] [stderr] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_total_color` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `hit_something` [INFO] [stderr] --> src/main.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | let mut hit_something = false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_hit_something` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | let mut bitmap = bmp::open("2000x2000.bmp").unwrap(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | let mut worker_id = pool.get_first_worker_id().unwrap() as u32; [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | let mut result = trace_ray(position, trace_direction, world, 2); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | let mut total_color = Vector::new(1.0, 1.0, 1.0); [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | let mut hit_something = false; [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:268:9 [INFO] [stderr] | [INFO] [stderr] 268 | let mut result = direction.add(&term); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: crate `RealisticCircles` should have a snake case name [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] = help: convert the identifier to snake case: `realistic_circles` [INFO] [stderr] [INFO] [stderr] warning: method `crossProduct` should have a snake case name [INFO] [stderr] --> src/vector.rs:23:12 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn crossProduct(&self, other: &Vector) -> Vector { [INFO] [stderr] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `cross_product` [INFO] [stderr] [INFO] [stderr] warning: `RealisticCircles` (bin "RealisticCircles" test) generated 21 warnings [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 0.06s [INFO] [stderr] Running unittests src/main.rs (/opt/rustwide/target/debug/deps/RealisticCircles-db0b84bf9c3b3cf3) [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "b585a9d90e7c7010541610afa9711633d57834f8164cb54ba8f273f979eb9fc2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b585a9d90e7c7010541610afa9711633d57834f8164cb54ba8f273f979eb9fc2", kill_on_drop: false }` [INFO] [stdout] b585a9d90e7c7010541610afa9711633d57834f8164cb54ba8f273f979eb9fc2