[INFO] fetching crate jab 0.0.1... [INFO] testing jab-0.0.1 against beta-2022-02-22 for beta-1.60-1 [INFO] extracting crate jab 0.0.1 into /workspace/builds/worker-44/source [INFO] validating manifest of crates.io crate jab 0.0.1 on toolchain beta-2022-02-22 [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+beta-2022-02-22" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate jab 0.0.1 [INFO] finished tweaking crates.io crate jab 0.0.1 [INFO] tweaked toml for crates.io crate jab 0.0.1 written to /workspace/builds/worker-44/source/Cargo.toml [INFO] crate crates.io crate jab 0.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+beta-2022-02-22" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-44/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-44/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:0cd99ca24d8e8c98e67c542213511d985b8778b5bdcbb160e038429496686047" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2022-02-22" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 93f037ed2a58161af91cf7385ee870eca8bea6c29025c16f75ef3e3ed4fd8294 [INFO] running `Command { std: "docker" "start" "-a" "93f037ed2a58161af91cf7385ee870eca8bea6c29025c16f75ef3e3ed4fd8294", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "93f037ed2a58161af91cf7385ee870eca8bea6c29025c16f75ef3e3ed4fd8294", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "93f037ed2a58161af91cf7385ee870eca8bea6c29025c16f75ef3e3ed4fd8294", kill_on_drop: false }` [INFO] [stdout] 93f037ed2a58161af91cf7385ee870eca8bea6c29025c16f75ef3e3ed4fd8294 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-44/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-44/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:0cd99ca24d8e8c98e67c542213511d985b8778b5bdcbb160e038429496686047" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2022-02-22" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e084e79217057c77ab051b78375c1419f119e74fc22f10301bb858908aae9e1d [INFO] running `Command { std: "docker" "start" "-a" "e084e79217057c77ab051b78375c1419f119e74fc22f10301bb858908aae9e1d", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling proc-macro2 v1.0.8 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.13 [INFO] [stderr] Compiling pkg-config v0.3.17 [INFO] [stderr] Compiling serde v1.0.104 [INFO] [stderr] Compiling smallvec v1.1.0 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling memchr v2.3.0 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling failure_derive v0.1.6 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Compiling regex-syntax v0.6.13 [INFO] [stderr] Compiling rustc-demangle v0.1.16 [INFO] [stderr] Compiling unicode-width v0.1.7 [INFO] [stderr] Compiling itoa v0.4.4 [INFO] [stderr] Compiling termcolor v1.1.0 [INFO] [stderr] Compiling vec_map v0.8.1 [INFO] [stderr] Compiling openssl-probe v0.1.2 [INFO] [stderr] Compiling unicode-bidi v0.3.4 [INFO] [stderr] Compiling thread_local v1.0.1 [INFO] [stderr] Compiling humantime v1.3.0 [INFO] [stderr] Compiling unicode-normalization v0.1.11 [INFO] [stderr] Compiling textwrap v0.11.0 [INFO] [stderr] Compiling aho-corasick v0.7.6 [INFO] [stderr] Compiling idna v0.2.0 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Compiling jobserver v0.1.19 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling dirs-sys v0.3.4 [INFO] [stderr] Compiling errno v0.2.4 [INFO] [stderr] Compiling url v2.1.1 [INFO] [stderr] Compiling clap v2.33.0 [INFO] [stderr] Compiling pager v0.15.0 [INFO] [stderr] Compiling dirs v2.0.2 [INFO] [stderr] Compiling cc v1.0.50 [INFO] [stderr] Compiling regex v1.3.3 [INFO] [stderr] Compiling openssl-sys v0.9.53 [INFO] [stderr] Compiling libz-sys v1.0.25 [INFO] [stderr] Compiling libssh2-sys v0.2.14 [INFO] [stderr] Compiling backtrace-sys v0.1.32 [INFO] [stderr] Compiling libgit2-sys v0.10.0 [INFO] [stderr] Compiling env_logger v0.7.1 [INFO] [stderr] Compiling backtrace v0.3.43 [INFO] [stderr] Compiling synstructure v0.12.3 [INFO] [stderr] Compiling serde_derive v1.0.104 [INFO] [stderr] Compiling git2 v0.11.0 [INFO] [stderr] Compiling failure v0.1.6 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling toml v0.5.6 [INFO] [stderr] Compiling serde_json v1.0.46 [INFO] [stderr] Compiling cargo-lock v4.0.1 [INFO] [stderr] Compiling built v0.4.0 [INFO] [stderr] Compiling jab v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:119:14 [INFO] [stdout] | [INFO] [stdout] 119 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::DbName, None) })?; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_braces)]` on by default [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 119 - .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::DbName, None) })?; [INFO] [stdout] 119 + .ok_or(DbError::parse_error(db_uri, DbUriParsingStep::DbName, None))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:129:16 [INFO] [stdout] | [INFO] [stdout] 129 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::Credential, None) })?, [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 129 - .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::Credential, None) })?, [INFO] [stdout] 129 + .ok_or(DbError::parse_error(db_uri, DbUriParsingStep::Credential, None))?, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:133:14 [INFO] [stdout] | [INFO] [stdout] 133 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::HostAndPort, None) })?; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 133 - .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::HostAndPort, None) })?; [INFO] [stdout] 133 + .ok_or(DbError::parse_error(db_uri, DbUriParsingStep::HostAndPort, None))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:138:14 [INFO] [stdout] | [INFO] [stdout] 138 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::Host, None) })?; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 138 - .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::Host, None) })?; [INFO] [stdout] 138 + .ok_or(DbError::parse_error(db_uri, DbUriParsingStep::Host, None))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:144:14 [INFO] [stdout] | [INFO] [stdout] 144 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::CredentialUsername, None) })?; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 144 - .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::CredentialUsername, None) })?; [INFO] [stdout] 144 + .ok_or(DbError::parse_error(db_uri, DbUriParsingStep::CredentialUsername, None))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:175:9 [INFO] [stdout] | [INFO] [stdout] 175 | .or({ Some("".into()) }) [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 175 - .or({ Some("".into()) }) [INFO] [stdout] 175 + .or(Some("".into())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:177:43 [INFO] [stdout] | [INFO] [stdout] 177 | let port = db_connection_config.port.or({ Some("".into()) }).unwrap(); [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 177 - let port = db_connection_config.port.or({ Some("".into()) }).unwrap(); [INFO] [stdout] 177 + let port = db_connection_config.port.or(Some("".into())).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `show_cli` [INFO] [stdout] --> src/bin/jab.rs:159:22 [INFO] [stdout] | [INFO] [stdout] 159 | } else if let Some(show_cli) = cli.subcommand_matches("show") { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_show_cli` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 30.64s [INFO] running `Command { std: "docker" "inspect" "e084e79217057c77ab051b78375c1419f119e74fc22f10301bb858908aae9e1d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e084e79217057c77ab051b78375c1419f119e74fc22f10301bb858908aae9e1d", kill_on_drop: false }` [INFO] [stdout] e084e79217057c77ab051b78375c1419f119e74fc22f10301bb858908aae9e1d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-44/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-44/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:0cd99ca24d8e8c98e67c542213511d985b8778b5bdcbb160e038429496686047" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2022-02-22" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f7109dcfb08e24bbcf4876946fab5c00a980016a2e2daec21bf67f3c11d0b528 [INFO] running `Command { std: "docker" "start" "-a" "f7109dcfb08e24bbcf4876946fab5c00a980016a2e2daec21bf67f3c11d0b528", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling predicates-core v1.0.0 [INFO] [stderr] Compiling difference v2.0.0 [INFO] [stderr] Compiling normalize-line-endings v0.2.2 [INFO] [stderr] Compiling treeline v0.1.0 [INFO] [stderr] Compiling fragile v0.3.0 [INFO] [stderr] Compiling downcast v0.10.0 [INFO] [stderr] Compiling mockall_derive v0.6.0 [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:119:14 [INFO] [stdout] | [INFO] [stdout] 119 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::DbName, None) })?; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_braces)]` on by default [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 119 - .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::DbName, None) })?; [INFO] [stdout] 119 + .ok_or(DbError::parse_error(db_uri, DbUriParsingStep::DbName, None))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:129:16 [INFO] [stdout] | [INFO] [stdout] 129 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::Credential, None) })?, [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 129 - .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::Credential, None) })?, [INFO] [stdout] 129 + .ok_or(DbError::parse_error(db_uri, DbUriParsingStep::Credential, None))?, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:133:14 [INFO] [stdout] | [INFO] [stdout] 133 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::HostAndPort, None) })?; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 133 - .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::HostAndPort, None) })?; [INFO] [stdout] 133 + .ok_or(DbError::parse_error(db_uri, DbUriParsingStep::HostAndPort, None))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:138:14 [INFO] [stdout] | [INFO] [stdout] 138 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::Host, None) })?; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 138 - .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::Host, None) })?; [INFO] [stdout] 138 + .ok_or(DbError::parse_error(db_uri, DbUriParsingStep::Host, None))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:144:14 [INFO] [stdout] | [INFO] [stdout] 144 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::CredentialUsername, None) })?; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 144 - .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::CredentialUsername, None) })?; [INFO] [stdout] 144 + .ok_or(DbError::parse_error(db_uri, DbUriParsingStep::CredentialUsername, None))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:175:9 [INFO] [stdout] | [INFO] [stdout] 175 | .or({ Some("".into()) }) [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 175 - .or({ Some("".into()) }) [INFO] [stdout] 175 + .or(Some("".into())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:177:43 [INFO] [stdout] | [INFO] [stdout] 177 | let port = db_connection_config.port.or({ Some("".into()) }).unwrap(); [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 177 - let port = db_connection_config.port.or({ Some("".into()) }).unwrap(); [INFO] [stdout] 177 + let port = db_connection_config.port.or(Some("".into())).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling predicates-tree v1.0.0 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling float-cmp v0.5.3 [INFO] [stderr] Compiling predicates v1.0.2 [INFO] [stderr] Compiling mockall v0.6.0 [INFO] [stderr] Compiling jab v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `show_cli` [INFO] [stdout] --> src/bin/jab.rs:159:22 [INFO] [stdout] | [INFO] [stdout] 159 | } else if let Some(show_cli) = cli.subcommand_matches("show") { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_show_cli` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:119:14 [INFO] [stdout] | [INFO] [stdout] 119 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::DbName, None) })?; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_braces)]` on by default [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 119 - .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::DbName, None) })?; [INFO] [stdout] 119 + .ok_or(DbError::parse_error(db_uri, DbUriParsingStep::DbName, None))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:129:16 [INFO] [stdout] | [INFO] [stdout] 129 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::Credential, None) })?, [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 129 - .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::Credential, None) })?, [INFO] [stdout] 129 + .ok_or(DbError::parse_error(db_uri, DbUriParsingStep::Credential, None))?, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:133:14 [INFO] [stdout] | [INFO] [stdout] 133 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::HostAndPort, None) })?; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 133 - .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::HostAndPort, None) })?; [INFO] [stdout] 133 + .ok_or(DbError::parse_error(db_uri, DbUriParsingStep::HostAndPort, None))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:138:14 [INFO] [stdout] | [INFO] [stdout] 138 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::Host, None) })?; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 138 - .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::Host, None) })?; [INFO] [stdout] 138 + .ok_or(DbError::parse_error(db_uri, DbUriParsingStep::Host, None))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:144:14 [INFO] [stdout] | [INFO] [stdout] 144 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::CredentialUsername, None) })?; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 144 - .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::CredentialUsername, None) })?; [INFO] [stdout] 144 + .ok_or(DbError::parse_error(db_uri, DbUriParsingStep::CredentialUsername, None))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:175:9 [INFO] [stdout] | [INFO] [stdout] 175 | .or({ Some("".into()) }) [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 175 - .or({ Some("".into()) }) [INFO] [stdout] 175 + .or(Some("".into())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:177:43 [INFO] [stdout] | [INFO] [stdout] 177 | let port = db_connection_config.port.or({ Some("".into()) }).unwrap(); [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 177 - let port = db_connection_config.port.or({ Some("".into()) }).unwrap(); [INFO] [stdout] 177 + let port = db_connection_config.port.or(Some("".into())).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/lib/git.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 241 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `DbConnectionConfigTest` should have a snake case name [INFO] [stdout] --> src/lib/db/postgresql/client.rs:271:7 [INFO] [stdout] | [INFO] [stdout] 271 | mod DbConnectionConfigTest { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `db_connection_config_test` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 10.42s [INFO] running `Command { std: "docker" "inspect" "f7109dcfb08e24bbcf4876946fab5c00a980016a2e2daec21bf67f3c11d0b528", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f7109dcfb08e24bbcf4876946fab5c00a980016a2e2daec21bf67f3c11d0b528", kill_on_drop: false }` [INFO] [stdout] f7109dcfb08e24bbcf4876946fab5c00a980016a2e2daec21bf67f3c11d0b528 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-44/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-44/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:0cd99ca24d8e8c98e67c542213511d985b8778b5bdcbb160e038429496686047" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2022-02-22" "test" "--frozen", kill_on_drop: false }` [INFO] [stdout] 0c91170e3a73b178e8eb4cf78256ed13eccad779b4fd1d532a55fbd0f629d09c [INFO] running `Command { std: "docker" "start" "-a" "0c91170e3a73b178e8eb4cf78256ed13eccad779b4fd1d532a55fbd0f629d09c", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] [stderr] warning: unnecessary braces around method argument [INFO] [stderr] --> src/lib/db/postgresql/client.rs:119:14 [INFO] [stderr] | [INFO] [stderr] 119 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::DbName, None) })?; [INFO] [stderr] | ^^ ^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_braces)]` on by default [INFO] [stderr] help: remove these braces [INFO] [stderr] | [INFO] [stderr] 119 - .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::DbName, None) })?; [INFO] [stderr] 119 + .ok_or(DbError::parse_error(db_uri, DbUriParsingStep::DbName, None))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary braces around method argument [INFO] [stderr] --> src/lib/db/postgresql/client.rs:129:16 [INFO] [stderr] | [INFO] [stderr] 129 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::Credential, None) })?, [INFO] [stderr] | ^^ ^^ [INFO] [stderr] | [INFO] [stderr] help: remove these braces [INFO] [stderr] | [INFO] [stderr] 129 - .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::Credential, None) })?, [INFO] [stderr] 129 + .ok_or(DbError::parse_error(db_uri, DbUriParsingStep::Credential, None))?, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary braces around method argument [INFO] [stderr] --> src/lib/db/postgresql/client.rs:133:14 [INFO] [stderr] | [INFO] [stderr] 133 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::HostAndPort, None) })?; [INFO] [stderr] | ^^ ^^ [INFO] [stderr] | [INFO] [stderr] help: remove these braces [INFO] [stderr] | [INFO] [stderr] 133 - .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::HostAndPort, None) })?; [INFO] [stderr] 133 + .ok_or(DbError::parse_error(db_uri, DbUriParsingStep::HostAndPort, None))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary braces around method argument [INFO] [stderr] --> src/lib/db/postgresql/client.rs:138:14 [INFO] [stderr] | [INFO] [stderr] 138 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::Host, None) })?; [INFO] [stderr] | ^^ ^^ [INFO] [stderr] | [INFO] [stderr] help: remove these braces [INFO] [stderr] | [INFO] [stderr] 138 - .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::Host, None) })?; [INFO] [stderr] 138 + .ok_or(DbError::parse_error(db_uri, DbUriParsingStep::Host, None))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary braces around method argument [INFO] [stderr] --> src/lib/db/postgresql/client.rs:144:14 [INFO] [stderr] | [INFO] [stderr] 144 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::CredentialUsername, None) })?; [INFO] [stderr] | ^^ ^^ [INFO] [stderr] | [INFO] [stderr] help: remove these braces [INFO] [stderr] | [INFO] [stderr] 144 - .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::CredentialUsername, None) })?; [INFO] [stderr] 144 + .ok_or(DbError::parse_error(db_uri, DbUriParsingStep::CredentialUsername, None))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary braces around method argument [INFO] [stderr] --> src/lib/db/postgresql/client.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | .or({ Some("".into()) }) [INFO] [stderr] | ^^ ^^ [INFO] [stderr] | [INFO] [stderr] help: remove these braces [INFO] [stderr] | [INFO] [stderr] 175 - .or({ Some("".into()) }) [INFO] [stderr] 175 + .or(Some("".into())) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary braces around method argument [INFO] [stderr] --> src/lib/db/postgresql/client.rs:177:43 [INFO] [stderr] | [INFO] [stderr] 177 | let port = db_connection_config.port.or({ Some("".into()) }).unwrap(); [INFO] [stderr] | ^^ ^^ [INFO] [stderr] | [INFO] [stderr] help: remove these braces [INFO] [stderr] | [INFO] [stderr] 177 - let port = db_connection_config.port.or({ Some("".into()) }).unwrap(); [INFO] [stderr] 177 + let port = db_connection_config.port.or(Some("".into())).unwrap(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::*` [INFO] [stderr] --> src/lib/git.rs:241:9 [INFO] [stderr] | [INFO] [stderr] 241 | use super::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: module `DbConnectionConfigTest` should have a snake case name [INFO] [stderr] --> src/lib/db/postgresql/client.rs:271:7 [INFO] [stderr] | [INFO] [stderr] 271 | mod DbConnectionConfigTest { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `db_connection_config_test` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] [INFO] [stderr] warning: `jab` (lib) generated 7 warnings [INFO] [stderr] warning: `jab` (lib test) generated 9 warnings (7 duplicates) [INFO] [stderr] warning: unused variable: `show_cli` [INFO] [stderr] --> src/bin/jab.rs:159:22 [INFO] [stderr] | [INFO] [stderr] 159 | } else if let Some(show_cli) = cli.subcommand_matches("show") { [INFO] [stderr] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_show_cli` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: `jab` (bin "jab" test) generated 1 warning [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 0.13s [INFO] [stderr] Running unittests (/opt/rustwide/target/debug/deps/lib-3d1bfa606d3cd5bc) [INFO] [stdout] [INFO] [stdout] running 5 tests [INFO] [stdout] test db::postgresql::client::test::DbConnectionConfigTest::from::it_should_return_valid_db_config_with_complete_uri ... ok [INFO] [stdout] test db::postgresql::client::test::DbConnectionConfigTest::from::it_should_return_valid_db_config_with_password ... ok [INFO] [stdout] test git::test::commit::it_should_create_initial_commit_on_bare_repo ... ok [INFO] [stdout] test db::postgresql::client::test::DbConnectionConfigTest::from::it_should_return_valid_db_config_without_password ... ok [INFO] [stderr] Running unittests (/opt/rustwide/target/debug/deps/jab-953ea1e797f5d36b) [INFO] [stdout] test git::test::upsert::it_should_create_repo_when_repo_does_not_exist ... ok [INFO] [stdout] [INFO] [stdout] test result: ok. 5 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.06s [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] [stderr] Doc-tests lib [INFO] [stderr] warning: unnecessary braces around method argument [INFO] [stderr] --> /opt/rustwide/workdir/src/lib/db/postgresql/client.rs:119:14 [INFO] [stderr] | [INFO] [stderr] 119 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::DbName, None) })?; [INFO] [stderr] | ^^ ^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_braces)]` on by default [INFO] [stderr] help: remove these braces [INFO] [stderr] | [INFO] [stderr] 119 - .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::DbName, None) })?; [INFO] [stderr] 119 + .ok_or(DbError::parse_error(db_uri, DbUriParsingStep::DbName, None))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary braces around method argument [INFO] [stderr] --> /opt/rustwide/workdir/src/lib/db/postgresql/client.rs:129:16 [INFO] [stderr] | [INFO] [stderr] 129 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::Credential, None) })?, [INFO] [stderr] | ^^ ^^ [INFO] [stderr] | [INFO] [stderr] help: remove these braces [INFO] [stderr] | [INFO] [stderr] 129 - .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::Credential, None) })?, [INFO] [stderr] 129 + .ok_or(DbError::parse_error(db_uri, DbUriParsingStep::Credential, None))?, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary braces around method argument [INFO] [stderr] --> /opt/rustwide/workdir/src/lib/db/postgresql/client.rs:133:14 [INFO] [stderr] | [INFO] [stderr] 133 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::HostAndPort, None) })?; [INFO] [stderr] | ^^ ^^ [INFO] [stderr] | [INFO] [stderr] help: remove these braces [INFO] [stderr] | [INFO] [stderr] 133 - .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::HostAndPort, None) })?; [INFO] [stderr] 133 + .ok_or(DbError::parse_error(db_uri, DbUriParsingStep::HostAndPort, None))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary braces around method argument [INFO] [stderr] --> /opt/rustwide/workdir/src/lib/db/postgresql/client.rs:138:14 [INFO] [stderr] | [INFO] [stderr] 138 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::Host, None) })?; [INFO] [stderr] | ^^ ^^ [INFO] [stderr] | [INFO] [stderr] help: remove these braces [INFO] [stderr] | [INFO] [stderr] 138 - .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::Host, None) })?; [INFO] [stderr] 138 + .ok_or(DbError::parse_error(db_uri, DbUriParsingStep::Host, None))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary braces around method argument [INFO] [stderr] --> /opt/rustwide/workdir/src/lib/db/postgresql/client.rs:144:14 [INFO] [stderr] | [INFO] [stderr] 144 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::CredentialUsername, None) })?; [INFO] [stderr] | ^^ ^^ [INFO] [stderr] | [INFO] [stderr] help: remove these braces [INFO] [stderr] | [INFO] [stderr] 144 - .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::CredentialUsername, None) })?; [INFO] [stderr] 144 + .ok_or(DbError::parse_error(db_uri, DbUriParsingStep::CredentialUsername, None))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary braces around method argument [INFO] [stderr] --> /opt/rustwide/workdir/src/lib/db/postgresql/client.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | .or({ Some("".into()) }) [INFO] [stderr] | ^^ ^^ [INFO] [stderr] | [INFO] [stderr] help: remove these braces [INFO] [stderr] | [INFO] [stderr] 175 - .or({ Some("".into()) }) [INFO] [stderr] 175 + .or(Some("".into())) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary braces around method argument [INFO] [stderr] --> /opt/rustwide/workdir/src/lib/db/postgresql/client.rs:177:43 [INFO] [stderr] | [INFO] [stderr] 177 | let port = db_connection_config.port.or({ Some("".into()) }).unwrap(); [INFO] [stderr] | ^^ ^^ [INFO] [stderr] | [INFO] [stderr] help: remove these braces [INFO] [stderr] | [INFO] [stderr] 177 - let port = db_connection_config.port.or({ Some("".into()) }).unwrap(); [INFO] [stderr] 177 + let port = db_connection_config.port.or(Some("".into())).unwrap(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: 7 warnings emitted [INFO] [stderr] [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "0c91170e3a73b178e8eb4cf78256ed13eccad779b4fd1d532a55fbd0f629d09c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0c91170e3a73b178e8eb4cf78256ed13eccad779b4fd1d532a55fbd0f629d09c", kill_on_drop: false }` [INFO] [stdout] 0c91170e3a73b178e8eb4cf78256ed13eccad779b4fd1d532a55fbd0f629d09c