[INFO] cloning repository https://github.com/theonly112/rsgb [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/theonly112/rsgb" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftheonly112%2Frsgb", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftheonly112%2Frsgb'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4007f54dad15eef80ddfbb22f8fad724ced578a8 [INFO] testing theonly112/rsgb against beta-2022-02-22 for beta-1.60-1 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftheonly112%2Frsgb" "/workspace/builds/worker-8/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-8/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/theonly112/rsgb on toolchain beta-2022-02-22 [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+beta-2022-02-22" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/theonly112/rsgb [INFO] finished tweaking git repo https://github.com/theonly112/rsgb [INFO] tweaked toml for git repo https://github.com/theonly112/rsgb written to /workspace/builds/worker-8/source/Cargo.toml [INFO] crate git repo https://github.com/theonly112/rsgb already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+beta-2022-02-22" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded num v0.1.36 [INFO] [stderr] Downloaded sdl2 v0.27.3 [INFO] [stderr] Downloaded sdl2-sys v0.27.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:0cd99ca24d8e8c98e67c542213511d985b8778b5bdcbb160e038429496686047" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2022-02-22" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 867cd3eed67611fb9b33892e1063e3494e47c3ca59a9046777ac8d0c6967aff4 [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] running `Command { std: "docker" "start" "-a" "867cd3eed67611fb9b33892e1063e3494e47c3ca59a9046777ac8d0c6967aff4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "867cd3eed67611fb9b33892e1063e3494e47c3ca59a9046777ac8d0c6967aff4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "867cd3eed67611fb9b33892e1063e3494e47c3ca59a9046777ac8d0c6967aff4", kill_on_drop: false }` [INFO] [stdout] 867cd3eed67611fb9b33892e1063e3494e47c3ca59a9046777ac8d0c6967aff4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:0cd99ca24d8e8c98e67c542213511d985b8778b5bdcbb160e038429496686047" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2022-02-22" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 27f869ad71f0dd8ad4bd19928f5cfea52afd8f4ff7b9685219e888b69fe18829 [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] running `Command { std: "docker" "start" "-a" "27f869ad71f0dd8ad4bd19928f5cfea52afd8f4ff7b9685219e888b69fe18829", kill_on_drop: false }` [INFO] [stderr] Compiling sdl2-sys v0.27.2 [INFO] [stderr] Compiling num-integer v0.1.32 [INFO] [stderr] Compiling num-iter v0.1.32 [INFO] [stderr] Compiling num v0.1.36 [INFO] [stderr] Compiling sdl2 v0.27.3 [INFO] [stderr] Compiling rsgb v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/gb/catridge.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | try!(file.read_to_end(&mut buff)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/gb/catridge.rs:16:24 [INFO] [stdout] | [INFO] [stdout] 16 | let mut file = try!(File::open(path)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around method argument [INFO] [stdout] --> src/gb/cpu.rs:1586:27 [INFO] [stdout] | [INFO] [stdout] 1586 | self.zero_flag_u8((value & bit)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 1586 - self.zero_flag_u8((value & bit)); [INFO] [stdout] 1586 + self.zero_flag_u8(value & bit); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around method argument [INFO] [stdout] --> src/gb/cpu.rs:1614:18 [INFO] [stdout] | [INFO] [stdout] 1614 | self.bit((1 << bit), val); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 1614 - self.bit((1 << bit), val); [INFO] [stdout] 1614 + self.bit(1 << bit, val); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:130:19 [INFO] [stdout] | [INFO] [stdout] 130 | 0x0000...0x7FFF => self.mbc.read_u8(addr), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:131:19 [INFO] [stdout] | [INFO] [stdout] 131 | 0xA000...0xBFFF => self.mbc.read_u8(addr), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:132:19 [INFO] [stdout] | [INFO] [stdout] 132 | 0x8000...0x9FFF => self.vram[(addr - 0x8000) as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:133:19 [INFO] [stdout] | [INFO] [stdout] 133 | 0xC000...0xDFFF => self.wram[(addr - 0xC000) as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:134:19 [INFO] [stdout] | [INFO] [stdout] 134 | 0xE000...0xFDFF => self.wram[(addr - 0xE000) as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:135:19 [INFO] [stdout] | [INFO] [stdout] 135 | 0xFE00...0xFEFF => self.oam[(addr - 0xFE00) as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:144:19 [INFO] [stdout] | [INFO] [stdout] 144 | 0xFF80...0xFFFE => self.hram[(addr - 0xff80) as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:145:19 [INFO] [stdout] | [INFO] [stdout] 145 | 0xFF00...0xFF7F => self.io[(addr - 0xff00) as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:156:19 [INFO] [stdout] | [INFO] [stdout] 156 | 0x0000...0x7FFF => self.mbc.write_u8(addr, val), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:157:19 [INFO] [stdout] | [INFO] [stdout] 157 | 0x8000...0x9FFF => self.vram_write(addr, val), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:158:19 [INFO] [stdout] | [INFO] [stdout] 158 | 0xA000...0xBFFF => self.mbc.write_u8(addr, val), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:159:19 [INFO] [stdout] | [INFO] [stdout] 159 | 0xC000...0xDFFF => self.wram[(addr - 0xC000) as usize] = val, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:160:19 [INFO] [stdout] | [INFO] [stdout] 160 | 0xE000...0xFDFF => self.wram[(addr - 0xE000) as usize] = val, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:161:19 [INFO] [stdout] | [INFO] [stdout] 161 | 0xFE00...0xFEFF => self.oam[(addr - 0xfe00) as usize] = val, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:162:19 [INFO] [stdout] | [INFO] [stdout] 162 | 0xFF80...0xFFFE => self.hram[(addr - 0xff80) as usize] = val, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:172:19 [INFO] [stdout] | [INFO] [stdout] 172 | 0xFF00...0xFF7F => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:204:19 [INFO] [stdout] | [INFO] [stdout] 204 | 0x0000...0x3fff => self.cart.rom[addr as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:205:19 [INFO] [stdout] | [INFO] [stdout] 205 | 0x4000...0x7fff => self.cart.rom[((addr - 0x4000) as usize + 0x4000 * self.rom_bank)], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:206:19 [INFO] [stdout] | [INFO] [stdout] 206 | 0xA000...0xbfff => self.ram[self.ram_bank][(addr - 0xa000) as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:212:19 [INFO] [stdout] | [INFO] [stdout] 212 | 0x2000...0x3fff => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:215:19 [INFO] [stdout] | [INFO] [stdout] 215 | 0x4000...0x5fff => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:223:19 [INFO] [stdout] | [INFO] [stdout] 223 | 0x6000...0x7fff => self.ram_mode = value == 1, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:224:19 [INFO] [stdout] | [INFO] [stdout] 224 | 0xa000...0xbfff => self.ram[self.ram_bank][(addr - 0xa000) as usize] = value, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:249:19 [INFO] [stdout] | [INFO] [stdout] 249 | 0x0000...0x7fff => self.cart.rom[addr as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:250:19 [INFO] [stdout] | [INFO] [stdout] 250 | 0xa000...0xbfff => self.ram[(addr - 0xa000) as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:256:19 [INFO] [stdout] | [INFO] [stdout] 256 | 0xA000...0xBFFF => self.ram[(addr - 0xA000) as usize] = value, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/gb/interrupts.rs:20:24 [INFO] [stdout] | [INFO] [stdout] 20 | pub const VBLANK: u8 = (1 << 0); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 20 - pub const VBLANK: u8 = (1 << 0); [INFO] [stdout] 20 + pub const VBLANK: u8 = 1 << 0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/gb/interrupts.rs:21:21 [INFO] [stdout] | [INFO] [stdout] 21 | const LCDSTAT: u8 = (1 << 1); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 21 - const LCDSTAT: u8 = (1 << 1); [INFO] [stdout] 21 + const LCDSTAT: u8 = 1 << 1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/gb/interrupts.rs:22:19 [INFO] [stdout] | [INFO] [stdout] 22 | const TIMER: u8 = (1 << 2); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 22 - const TIMER: u8 = (1 << 2); [INFO] [stdout] 22 + const TIMER: u8 = 1 << 2; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/gb/interrupts.rs:23:20 [INFO] [stdout] | [INFO] [stdout] 23 | const SERIAL: u8 = (1 << 3); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 23 - const SERIAL: u8 = (1 << 3); [INFO] [stdout] 23 + const SERIAL: u8 = 1 << 3; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/gb/interrupts.rs:24:20 [INFO] [stdout] | [INFO] [stdout] 24 | const JOYPAD: u8 = (1 << 4); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 24 - const JOYPAD: u8 = (1 << 4); [INFO] [stdout] 24 + const JOYPAD: u8 = 1 << 4; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/gb/mmu.rs:22:14 [INFO] [stdout] | [INFO] [stdout] 22 | mbc: Box, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 22 - mbc: Box, [INFO] [stdout] 22 + mbc: Box, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/gb/mmu.rs:27:22 [INFO] [stdout] | [INFO] [stdout] 27 | let mbc: Box = match cart.cartirge_type { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 27 - let mbc: Box = match cart.cartirge_type { [INFO] [stdout] 27 + let mbc: Box = match cart.cartirge_type { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/gb/cpu.rs:294:13 [INFO] [stdout] | [INFO] [stdout] 294 | _ => { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/gb/cpu.rs:1554:13 [INFO] [stdout] | [INFO] [stdout] 1554 | _ => { [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/gb/mmu.rs:146:13 [INFO] [stdout] | [INFO] [stdout] 146 | _ => panic!("invalid addr"), [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/gb/mmu.rs:179:13 [INFO] [stdout] | [INFO] [stdout] 179 | _ => panic!("Not implemented"), [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mmu` [INFO] [stdout] --> src/gb/gpu.rs:219:17 [INFO] [stdout] | [INFO] [stdout] 219 | let ref mmu = self.mmu.as_ref().unwrap().borrow_mut(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_mmu` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tiles` [INFO] [stdout] --> src/gb/gpu.rs:220:13 [INFO] [stdout] | [INFO] [stdout] 220 | let tiles = self.status.window_tilemap(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_tiles` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `map` [INFO] [stdout] --> src/gb/gpu.rs:221:13 [INFO] [stdout] | [INFO] [stdout] 221 | let map = self.status.bg_tilemap(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tileY` [INFO] [stdout] --> src/gb/gpu.rs:223:13 [INFO] [stdout] | [INFO] [stdout] 223 | let tileY = self.status.wy / 8; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_tileY` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tileYOffset` [INFO] [stdout] --> src/gb/gpu.rs:224:13 [INFO] [stdout] | [INFO] [stdout] 224 | let tileYOffset = self.status.wy % 8; [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_tileYOffset` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `tile` is never read [INFO] [stdout] --> src/gb/gpu.rs:318:17 [INFO] [stdout] | [INFO] [stdout] 318 | let mut tile: u8 = 0; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/gb/interrupts.rs:100:37 [INFO] [stdout] | [INFO] [stdout] 100 | pub fn handle_vblank(&mut self, mut display: &mut SdlDisplay) { [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `tileY` should have a snake case name [INFO] [stdout] --> src/gb/gpu.rs:223:13 [INFO] [stdout] | [INFO] [stdout] 223 | let tileY = self.status.wy / 8; [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `tile_y` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `tileYOffset` should have a snake case name [INFO] [stdout] --> src/gb/gpu.rs:224:13 [INFO] [stdout] | [INFO] [stdout] 224 | let tileYOffset = self.status.wy % 8; [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `tile_yoffset` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 50 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.93s [INFO] running `Command { std: "docker" "inspect" "27f869ad71f0dd8ad4bd19928f5cfea52afd8f4ff7b9685219e888b69fe18829", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "27f869ad71f0dd8ad4bd19928f5cfea52afd8f4ff7b9685219e888b69fe18829", kill_on_drop: false }` [INFO] [stdout] 27f869ad71f0dd8ad4bd19928f5cfea52afd8f4ff7b9685219e888b69fe18829 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:0cd99ca24d8e8c98e67c542213511d985b8778b5bdcbb160e038429496686047" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2022-02-22" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 547cdebf1232d001c7d56d1640590b8af8346ad613560e038989df48b1391149 [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] running `Command { std: "docker" "start" "-a" "547cdebf1232d001c7d56d1640590b8af8346ad613560e038989df48b1391149", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Compiling rsgb v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/gb/catridge.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | try!(file.read_to_end(&mut buff)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/gb/catridge.rs:16:24 [INFO] [stdout] | [INFO] [stdout] 16 | let mut file = try!(File::open(path)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around method argument [INFO] [stdout] --> src/gb/cpu.rs:1586:27 [INFO] [stdout] | [INFO] [stdout] 1586 | self.zero_flag_u8((value & bit)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 1586 - self.zero_flag_u8((value & bit)); [INFO] [stdout] 1586 + self.zero_flag_u8(value & bit); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around method argument [INFO] [stdout] --> src/gb/cpu.rs:1614:18 [INFO] [stdout] | [INFO] [stdout] 1614 | self.bit((1 << bit), val); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 1614 - self.bit((1 << bit), val); [INFO] [stdout] 1614 + self.bit(1 << bit, val); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:130:19 [INFO] [stdout] | [INFO] [stdout] 130 | 0x0000...0x7FFF => self.mbc.read_u8(addr), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:131:19 [INFO] [stdout] | [INFO] [stdout] 131 | 0xA000...0xBFFF => self.mbc.read_u8(addr), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:132:19 [INFO] [stdout] | [INFO] [stdout] 132 | 0x8000...0x9FFF => self.vram[(addr - 0x8000) as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:133:19 [INFO] [stdout] | [INFO] [stdout] 133 | 0xC000...0xDFFF => self.wram[(addr - 0xC000) as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:134:19 [INFO] [stdout] | [INFO] [stdout] 134 | 0xE000...0xFDFF => self.wram[(addr - 0xE000) as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:135:19 [INFO] [stdout] | [INFO] [stdout] 135 | 0xFE00...0xFEFF => self.oam[(addr - 0xFE00) as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:144:19 [INFO] [stdout] | [INFO] [stdout] 144 | 0xFF80...0xFFFE => self.hram[(addr - 0xff80) as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:145:19 [INFO] [stdout] | [INFO] [stdout] 145 | 0xFF00...0xFF7F => self.io[(addr - 0xff00) as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:156:19 [INFO] [stdout] | [INFO] [stdout] 156 | 0x0000...0x7FFF => self.mbc.write_u8(addr, val), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:157:19 [INFO] [stdout] | [INFO] [stdout] 157 | 0x8000...0x9FFF => self.vram_write(addr, val), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:158:19 [INFO] [stdout] | [INFO] [stdout] 158 | 0xA000...0xBFFF => self.mbc.write_u8(addr, val), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:159:19 [INFO] [stdout] | [INFO] [stdout] 159 | 0xC000...0xDFFF => self.wram[(addr - 0xC000) as usize] = val, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:160:19 [INFO] [stdout] | [INFO] [stdout] 160 | 0xE000...0xFDFF => self.wram[(addr - 0xE000) as usize] = val, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:161:19 [INFO] [stdout] | [INFO] [stdout] 161 | 0xFE00...0xFEFF => self.oam[(addr - 0xfe00) as usize] = val, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:162:19 [INFO] [stdout] | [INFO] [stdout] 162 | 0xFF80...0xFFFE => self.hram[(addr - 0xff80) as usize] = val, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:172:19 [INFO] [stdout] | [INFO] [stdout] 172 | 0xFF00...0xFF7F => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:204:19 [INFO] [stdout] | [INFO] [stdout] 204 | 0x0000...0x3fff => self.cart.rom[addr as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:205:19 [INFO] [stdout] | [INFO] [stdout] 205 | 0x4000...0x7fff => self.cart.rom[((addr - 0x4000) as usize + 0x4000 * self.rom_bank)], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:206:19 [INFO] [stdout] | [INFO] [stdout] 206 | 0xA000...0xbfff => self.ram[self.ram_bank][(addr - 0xa000) as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:212:19 [INFO] [stdout] | [INFO] [stdout] 212 | 0x2000...0x3fff => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:215:19 [INFO] [stdout] | [INFO] [stdout] 215 | 0x4000...0x5fff => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:223:19 [INFO] [stdout] | [INFO] [stdout] 223 | 0x6000...0x7fff => self.ram_mode = value == 1, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:224:19 [INFO] [stdout] | [INFO] [stdout] 224 | 0xa000...0xbfff => self.ram[self.ram_bank][(addr - 0xa000) as usize] = value, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:249:19 [INFO] [stdout] | [INFO] [stdout] 249 | 0x0000...0x7fff => self.cart.rom[addr as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:250:19 [INFO] [stdout] | [INFO] [stdout] 250 | 0xa000...0xbfff => self.ram[(addr - 0xa000) as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/gb/mmu.rs:256:19 [INFO] [stdout] | [INFO] [stdout] 256 | 0xA000...0xBFFF => self.ram[(addr - 0xA000) as usize] = value, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/gb/interrupts.rs:20:24 [INFO] [stdout] | [INFO] [stdout] 20 | pub const VBLANK: u8 = (1 << 0); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 20 - pub const VBLANK: u8 = (1 << 0); [INFO] [stdout] 20 + pub const VBLANK: u8 = 1 << 0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/gb/interrupts.rs:21:21 [INFO] [stdout] | [INFO] [stdout] 21 | const LCDSTAT: u8 = (1 << 1); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 21 - const LCDSTAT: u8 = (1 << 1); [INFO] [stdout] 21 + const LCDSTAT: u8 = 1 << 1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/gb/interrupts.rs:22:19 [INFO] [stdout] | [INFO] [stdout] 22 | const TIMER: u8 = (1 << 2); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 22 - const TIMER: u8 = (1 << 2); [INFO] [stdout] 22 + const TIMER: u8 = 1 << 2; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/gb/interrupts.rs:23:20 [INFO] [stdout] | [INFO] [stdout] 23 | const SERIAL: u8 = (1 << 3); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 23 - const SERIAL: u8 = (1 << 3); [INFO] [stdout] 23 + const SERIAL: u8 = 1 << 3; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/gb/interrupts.rs:24:20 [INFO] [stdout] | [INFO] [stdout] 24 | const JOYPAD: u8 = (1 << 4); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 24 - const JOYPAD: u8 = (1 << 4); [INFO] [stdout] 24 + const JOYPAD: u8 = 1 << 4; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/gb/mmu.rs:22:14 [INFO] [stdout] | [INFO] [stdout] 22 | mbc: Box, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 22 - mbc: Box, [INFO] [stdout] 22 + mbc: Box, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/gb/mmu.rs:27:22 [INFO] [stdout] | [INFO] [stdout] 27 | let mbc: Box = match cart.cartirge_type { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 27 - let mbc: Box = match cart.cartirge_type { [INFO] [stdout] 27 + let mbc: Box = match cart.cartirge_type { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/gb/cpu.rs:294:13 [INFO] [stdout] | [INFO] [stdout] 294 | _ => { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/gb/cpu.rs:1554:13 [INFO] [stdout] | [INFO] [stdout] 1554 | _ => { [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/gb/mmu.rs:146:13 [INFO] [stdout] | [INFO] [stdout] 146 | _ => panic!("invalid addr"), [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/gb/mmu.rs:179:13 [INFO] [stdout] | [INFO] [stdout] 179 | _ => panic!("Not implemented"), [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mmu` [INFO] [stdout] --> src/gb/gpu.rs:219:17 [INFO] [stdout] | [INFO] [stdout] 219 | let ref mmu = self.mmu.as_ref().unwrap().borrow_mut(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_mmu` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tiles` [INFO] [stdout] --> src/gb/gpu.rs:220:13 [INFO] [stdout] | [INFO] [stdout] 220 | let tiles = self.status.window_tilemap(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_tiles` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `map` [INFO] [stdout] --> src/gb/gpu.rs:221:13 [INFO] [stdout] | [INFO] [stdout] 221 | let map = self.status.bg_tilemap(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tileY` [INFO] [stdout] --> src/gb/gpu.rs:223:13 [INFO] [stdout] | [INFO] [stdout] 223 | let tileY = self.status.wy / 8; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_tileY` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tileYOffset` [INFO] [stdout] --> src/gb/gpu.rs:224:13 [INFO] [stdout] | [INFO] [stdout] 224 | let tileYOffset = self.status.wy % 8; [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_tileYOffset` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `tile` is never read [INFO] [stdout] --> src/gb/gpu.rs:318:17 [INFO] [stdout] | [INFO] [stdout] 318 | let mut tile: u8 = 0; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/gb/interrupts.rs:100:37 [INFO] [stdout] | [INFO] [stdout] 100 | pub fn handle_vblank(&mut self, mut display: &mut SdlDisplay) { [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `tileY` should have a snake case name [INFO] [stdout] --> src/gb/gpu.rs:223:13 [INFO] [stdout] | [INFO] [stdout] 223 | let tileY = self.status.wy / 8; [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `tile_y` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `tileYOffset` should have a snake case name [INFO] [stdout] --> src/gb/gpu.rs:224:13 [INFO] [stdout] | [INFO] [stdout] 224 | let tileYOffset = self.status.wy % 8; [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `tile_yoffset` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 50 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 4.26s [INFO] running `Command { std: "docker" "inspect" "547cdebf1232d001c7d56d1640590b8af8346ad613560e038989df48b1391149", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "547cdebf1232d001c7d56d1640590b8af8346ad613560e038989df48b1391149", kill_on_drop: false }` [INFO] [stdout] 547cdebf1232d001c7d56d1640590b8af8346ad613560e038989df48b1391149 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:0cd99ca24d8e8c98e67c542213511d985b8778b5bdcbb160e038429496686047" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2022-02-22" "test" "--frozen", kill_on_drop: false }` [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] [stdout] 255c90c37a53d4b4a8f012e36dec6ef3cbac3c43a78a5b34d6f79316eeb0928f [INFO] running `Command { std: "docker" "start" "-a" "255c90c37a53d4b4a8f012e36dec6ef3cbac3c43a78a5b34d6f79316eeb0928f", kill_on_drop: false }` [INFO] [stderr] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stderr] --> src/gb/catridge.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | try!(file.read_to_end(&mut buff)); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(deprecated)]` on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stderr] --> src/gb/catridge.rs:16:24 [INFO] [stderr] | [INFO] [stderr] 16 | let mut file = try!(File::open(path)); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/gb/cpu.rs:1586:27 [INFO] [stderr] | [INFO] [stderr] 1586 | self.zero_flag_u8((value & bit)); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 1586 - self.zero_flag_u8((value & bit)); [INFO] [stderr] 1586 + self.zero_flag_u8(value & bit); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/gb/cpu.rs:1614:18 [INFO] [stderr] | [INFO] [stderr] 1614 | self.bit((1 << bit), val); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 1614 - self.bit((1 << bit), val); [INFO] [stderr] 1614 + self.bit(1 << bit, val); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:130:19 [INFO] [stderr] | [INFO] [stderr] 130 | 0x0000...0x7FFF => self.mbc.read_u8(addr), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:131:19 [INFO] [stderr] | [INFO] [stderr] 131 | 0xA000...0xBFFF => self.mbc.read_u8(addr), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:132:19 [INFO] [stderr] | [INFO] [stderr] 132 | 0x8000...0x9FFF => self.vram[(addr - 0x8000) as usize], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:133:19 [INFO] [stderr] | [INFO] [stderr] 133 | 0xC000...0xDFFF => self.wram[(addr - 0xC000) as usize], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:134:19 [INFO] [stderr] | [INFO] [stderr] 134 | 0xE000...0xFDFF => self.wram[(addr - 0xE000) as usize], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:135:19 [INFO] [stderr] | [INFO] [stderr] 135 | 0xFE00...0xFEFF => self.oam[(addr - 0xFE00) as usize], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:144:19 [INFO] [stderr] | [INFO] [stderr] 144 | 0xFF80...0xFFFE => self.hram[(addr - 0xff80) as usize], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:145:19 [INFO] [stderr] | [INFO] [stderr] 145 | 0xFF00...0xFF7F => self.io[(addr - 0xff00) as usize], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:156:19 [INFO] [stderr] | [INFO] [stderr] 156 | 0x0000...0x7FFF => self.mbc.write_u8(addr, val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:157:19 [INFO] [stderr] | [INFO] [stderr] 157 | 0x8000...0x9FFF => self.vram_write(addr, val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:158:19 [INFO] [stderr] | [INFO] [stderr] 158 | 0xA000...0xBFFF => self.mbc.write_u8(addr, val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:159:19 [INFO] [stderr] | [INFO] [stderr] 159 | 0xC000...0xDFFF => self.wram[(addr - 0xC000) as usize] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:160:19 [INFO] [stderr] | [INFO] [stderr] 160 | 0xE000...0xFDFF => self.wram[(addr - 0xE000) as usize] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:161:19 [INFO] [stderr] | [INFO] [stderr] 161 | 0xFE00...0xFEFF => self.oam[(addr - 0xfe00) as usize] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:162:19 [INFO] [stderr] | [INFO] [stderr] 162 | 0xFF80...0xFFFE => self.hram[(addr - 0xff80) as usize] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:172:19 [INFO] [stderr] | [INFO] [stderr] 172 | 0xFF00...0xFF7F => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:204:19 [INFO] [stderr] | [INFO] [stderr] 204 | 0x0000...0x3fff => self.cart.rom[addr as usize], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:205:19 [INFO] [stderr] | [INFO] [stderr] 205 | 0x4000...0x7fff => self.cart.rom[((addr - 0x4000) as usize + 0x4000 * self.rom_bank)], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:206:19 [INFO] [stderr] | [INFO] [stderr] 206 | 0xA000...0xbfff => self.ram[self.ram_bank][(addr - 0xa000) as usize], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:212:19 [INFO] [stderr] | [INFO] [stderr] 212 | 0x2000...0x3fff => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:215:19 [INFO] [stderr] | [INFO] [stderr] 215 | 0x4000...0x5fff => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:223:19 [INFO] [stderr] | [INFO] [stderr] 223 | 0x6000...0x7fff => self.ram_mode = value == 1, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:224:19 [INFO] [stderr] | [INFO] [stderr] 224 | 0xa000...0xbfff => self.ram[self.ram_bank][(addr - 0xa000) as usize] = value, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:249:19 [INFO] [stderr] | [INFO] [stderr] 249 | 0x0000...0x7fff => self.cart.rom[addr as usize], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:250:19 [INFO] [stderr] | [INFO] [stderr] 250 | 0xa000...0xbfff => self.ram[(addr - 0xa000) as usize], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:256:19 [INFO] [stderr] | [INFO] [stderr] 256 | 0xA000...0xBFFF => self.ram[(addr - 0xA000) as usize] = value, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/gb/interrupts.rs:20:24 [INFO] [stderr] | [INFO] [stderr] 20 | pub const VBLANK: u8 = (1 << 0); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 20 - pub const VBLANK: u8 = (1 << 0); [INFO] [stderr] 20 + pub const VBLANK: u8 = 1 << 0; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/gb/interrupts.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | const LCDSTAT: u8 = (1 << 1); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 21 - const LCDSTAT: u8 = (1 << 1); [INFO] [stderr] 21 + const LCDSTAT: u8 = 1 << 1; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/gb/interrupts.rs:22:19 [INFO] [stderr] | [INFO] [stderr] 22 | const TIMER: u8 = (1 << 2); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 22 - const TIMER: u8 = (1 << 2); [INFO] [stderr] 22 + const TIMER: u8 = 1 << 2; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/gb/interrupts.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | const SERIAL: u8 = (1 << 3); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 23 - const SERIAL: u8 = (1 << 3); [INFO] [stderr] 23 + const SERIAL: u8 = 1 << 3; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/gb/interrupts.rs:24:20 [INFO] [stderr] | [INFO] [stderr] 24 | const JOYPAD: u8 = (1 << 4); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 24 - const JOYPAD: u8 = (1 << 4); [INFO] [stderr] 24 + const JOYPAD: u8 = 1 << 4; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/gb/mmu.rs:22:14 [INFO] [stderr] | [INFO] [stderr] 22 | mbc: Box, [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] help: use `dyn` [INFO] [stderr] | [INFO] [stderr] 22 - mbc: Box, [INFO] [stderr] 22 + mbc: Box, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/gb/mmu.rs:27:22 [INFO] [stderr] | [INFO] [stderr] 27 | let mbc: Box = match cart.cartirge_type { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] help: use `dyn` [INFO] [stderr] | [INFO] [stderr] 27 - let mbc: Box = match cart.cartirge_type { [INFO] [stderr] 27 + let mbc: Box = match cart.cartirge_type { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gb/cpu.rs:294:13 [INFO] [stderr] | [INFO] [stderr] 294 | _ => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gb/cpu.rs:1554:13 [INFO] [stderr] | [INFO] [stderr] 1554 | _ => { [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gb/mmu.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | _ => panic!("invalid addr"), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gb/mmu.rs:179:13 [INFO] [stderr] | [INFO] [stderr] 179 | _ => panic!("Not implemented"), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `mmu` [INFO] [stderr] --> src/gb/gpu.rs:219:17 [INFO] [stderr] | [INFO] [stderr] 219 | let ref mmu = self.mmu.as_ref().unwrap().borrow_mut(); [INFO] [stderr] | ^^^ help: if this is intentional, prefix it with an underscore: `_mmu` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tiles` [INFO] [stderr] --> src/gb/gpu.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | let tiles = self.status.window_tilemap(); [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_tiles` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `map` [INFO] [stderr] --> src/gb/gpu.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | let map = self.status.bg_tilemap(); [INFO] [stderr] | ^^^ help: if this is intentional, prefix it with an underscore: `_map` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tileY` [INFO] [stderr] --> src/gb/gpu.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | let tileY = self.status.wy / 8; [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_tileY` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tileYOffset` [INFO] [stderr] --> src/gb/gpu.rs:224:13 [INFO] [stderr] | [INFO] [stderr] 224 | let tileYOffset = self.status.wy % 8; [INFO] [stderr] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_tileYOffset` [INFO] [stderr] [INFO] [stderr] warning: value assigned to `tile` is never read [INFO] [stderr] --> src/gb/gpu.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | let mut tile: u8 = 0; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_assignments)]` on by default [INFO] [stderr] = help: maybe it is overwritten before being read? [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gb/interrupts.rs:100:37 [INFO] [stderr] | [INFO] [stderr] 100 | pub fn handle_vblank(&mut self, mut display: &mut SdlDisplay) { [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable `tileY` should have a snake case name [INFO] [stderr] --> src/gb/gpu.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | let tileY = self.status.wy / 8; [INFO] [stderr] | ^^^^^ help: convert the identifier to snake case: `tile_y` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable `tileYOffset` should have a snake case name [INFO] [stderr] --> src/gb/gpu.rs:224:13 [INFO] [stderr] | [INFO] [stderr] 224 | let tileYOffset = self.status.wy % 8; [INFO] [stderr] | ^^^^^^^^^^^ help: convert the identifier to snake case: `tile_yoffset` [INFO] [stderr] [INFO] [stderr] warning: `rsgb` (bin "rsgb" test) generated 50 warnings [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 0.05s [INFO] [stdout] [INFO] [stderr] Running unittests (/opt/rustwide/target/debug/deps/rsgb-143ce656aca0d1d6) [INFO] [stdout] running 1 test [INFO] [stdout] test gb::catridge::cartrige_from_u8 ... ok [INFO] [stdout] [INFO] [stdout] test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "255c90c37a53d4b4a8f012e36dec6ef3cbac3c43a78a5b34d6f79316eeb0928f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "255c90c37a53d4b4a8f012e36dec6ef3cbac3c43a78a5b34d6f79316eeb0928f", kill_on_drop: false }` [INFO] [stdout] 255c90c37a53d4b4a8f012e36dec6ef3cbac3c43a78a5b34d6f79316eeb0928f