[INFO] fetching crate raster-retrace 0.1.2... [INFO] testing raster-retrace-0.1.2 against 1.59.0 for beta-1.60-1 [INFO] extracting crate raster-retrace 0.1.2 into /workspace/builds/worker-20/source [INFO] validating manifest of crates.io crate raster-retrace 0.1.2 on toolchain 1.59.0 [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+1.59.0" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate raster-retrace 0.1.2 [INFO] finished tweaking crates.io crate raster-retrace 0.1.2 [INFO] tweaked toml for crates.io crate raster-retrace 0.1.2 written to /workspace/builds/worker-20/source/Cargo.toml [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+1.59.0" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+1.59.0" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-20/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-20/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:0cd99ca24d8e8c98e67c542213511d985b8778b5bdcbb160e038429496686047" "/opt/rustwide/cargo-home/bin/cargo" "+1.59.0" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fd022fb24fac451d2c9ed9b21cc391572eab1d04ff4d34d95f538ed25f90a150 [INFO] running `Command { std: "docker" "start" "-a" "fd022fb24fac451d2c9ed9b21cc391572eab1d04ff4d34d95f538ed25f90a150", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fd022fb24fac451d2c9ed9b21cc391572eab1d04ff4d34d95f538ed25f90a150", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fd022fb24fac451d2c9ed9b21cc391572eab1d04ff4d34d95f538ed25f90a150", kill_on_drop: false }` [INFO] [stdout] fd022fb24fac451d2c9ed9b21cc391572eab1d04ff4d34d95f538ed25f90a150 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-20/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-20/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:0cd99ca24d8e8c98e67c542213511d985b8778b5bdcbb160e038429496686047" "/opt/rustwide/cargo-home/bin/cargo" "+1.59.0" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 759e07cc1f8e8e78a02f595bb09e8013788d48965dc176a6746eb679a8a53b91 [INFO] running `Command { std: "docker" "start" "-a" "759e07cc1f8e8e78a02f595bb09e8013788d48965dc176a6746eb679a8a53b91", kill_on_drop: false }` [INFO] [stderr] Compiling raster-retrace v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/intern/argparse/mod.rs:5:34 [INFO] [stdout] | [INFO] [stdout] 5 | pub const ARGDEF_REQUIRED: u32 = (1 << 0); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 5 - pub const ARGDEF_REQUIRED: u32 = (1 << 0); [INFO] [stdout] 5 + pub const ARGDEF_REQUIRED: u32 = 1 << 0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/intern/argparse/mod.rs:6:34 [INFO] [stdout] | [INFO] [stdout] 6 | pub const ARGDEF_VARARGS: u32 = (1 << 1); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 6 - pub const ARGDEF_VARARGS: u32 = (1 << 1); [INFO] [stdout] 6 + pub const ARGDEF_VARARGS: u32 = 1 << 1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/intern/min_heap/mod.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | ((i - 1) >> 1) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 76 - ((i - 1) >> 1) [INFO] [stdout] 76 + (i - 1) >> 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/intern/min_heap/mod.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | ((i << 1) + 1) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 79 - ((i << 1) + 1) [INFO] [stdout] 79 + (i << 1) + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/intern/min_heap/mod.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | ((i << 1) + 2) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 82 - ((i << 1) + 2) [INFO] [stdout] 82 + (i << 1) + 2 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/intern/min_heap/mod.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | (a.value < b.value) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 96 - (a.value < b.value) [INFO] [stdout] 96 + a.value < b.value [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_outline.rs:45:27 [INFO] [stdout] | [INFO] [stdout] 45 | pub const L: u8 = (1 << 0); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 45 - pub const L: u8 = (1 << 0); [INFO] [stdout] 45 + pub const L: u8 = 1 << 0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_outline.rs:46:27 [INFO] [stdout] | [INFO] [stdout] 46 | pub const R: u8 = (1 << 1); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 46 - pub const R: u8 = (1 << 1); [INFO] [stdout] 46 + pub const R: u8 = 1 << 1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_outline.rs:47:27 [INFO] [stdout] | [INFO] [stdout] 47 | pub const D: u8 = (1 << 2); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 47 - pub const D: u8 = (1 << 2); [INFO] [stdout] 47 + pub const D: u8 = 1 << 2; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_outline.rs:48:27 [INFO] [stdout] | [INFO] [stdout] 48 | pub const U: u8 = (1 << 3); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 48 - pub const U: u8 = (1 << 3); [INFO] [stdout] 48 + pub const U: u8 = 1 << 3; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/polys_from_raster_outline.rs:149:29 [INFO] [stdout] | [INFO] [stdout] 149 | ... ((x == xy_a[0] && x == xy_b[0]) || [INFO] [stdout] | ^ [INFO] [stdout] 150 | ... (y == xy_a[1] && y == xy_b[1])) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 149 ~ (x == xy_a[0] && x == xy_b[0]) || [INFO] [stdout] 150 ~ (y == xy_a[1] && y == xy_b[1]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:21:27 [INFO] [stdout] | [INFO] [stdout] 21 | pub const L: u8 = (1 << 0); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 21 - pub const L: u8 = (1 << 0); [INFO] [stdout] 21 + pub const L: u8 = 1 << 0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:22:27 [INFO] [stdout] | [INFO] [stdout] 22 | pub const R: u8 = (1 << 1); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 22 - pub const R: u8 = (1 << 1); [INFO] [stdout] 22 + pub const R: u8 = 1 << 1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:23:27 [INFO] [stdout] | [INFO] [stdout] 23 | pub const D: u8 = (1 << 2); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 23 - pub const D: u8 = (1 << 2); [INFO] [stdout] 23 + pub const D: u8 = 1 << 2; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:24:27 [INFO] [stdout] | [INFO] [stdout] 24 | pub const U: u8 = (1 << 3); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 24 - pub const U: u8 = (1 << 3); [INFO] [stdout] 24 + pub const U: u8 = 1 << 3; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:26:28 [INFO] [stdout] | [INFO] [stdout] 26 | pub const LD: u8 = (1 << 4); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 26 - pub const LD: u8 = (1 << 4); [INFO] [stdout] 26 + pub const LD: u8 = 1 << 4; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:27:28 [INFO] [stdout] | [INFO] [stdout] 27 | pub const LU: u8 = (1 << 5); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 27 - pub const LU: u8 = (1 << 5); [INFO] [stdout] 27 + pub const LU: u8 = 1 << 5; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:28:28 [INFO] [stdout] | [INFO] [stdout] 28 | pub const RD: u8 = (1 << 6); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 28 - pub const RD: u8 = (1 << 6); [INFO] [stdout] 28 + pub const RD: u8 = 1 << 6; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:29:28 [INFO] [stdout] | [INFO] [stdout] 29 | pub const RU: u8 = (1 << 7); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 29 - pub const RU: u8 = (1 << 7); [INFO] [stdout] 29 + pub const RU: u8 = 1 << 7; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:192:29 [INFO] [stdout] | [INFO] [stdout] 192 | / ... ( [INFO] [stdout] 193 | | ... // axis aligned [INFO] [stdout] 194 | | ... (x == xy_a[0] && x == xy_b[0]) || [INFO] [stdout] | |__________________________^ [INFO] [stdout] ... [INFO] [stdout] 212 | ... } [INFO] [stdout] | ____________________________^ [INFO] [stdout] 213 | | ... ) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 192 ~ (x == xy_a[0] && x == xy_b[0]) || [INFO] [stdout] 193 | (y == xy_a[1] && y == xy_b[1]) || [INFO] [stdout] 194 | // diagonal [INFO] [stdout] 195 | { [INFO] [stdout] 196 | let x_a_delta = xy_a[0] - xy_b[0]; [INFO] [stdout] 197 | let y_a_delta = xy_a[1] - xy_b[1]; [INFO] [stdout] ... [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:203:37 [INFO] [stdout] | [INFO] [stdout] 203 | ... (x_a_delta != 0 && y_a_delta != 0 && [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 211 | ... y_a_delta.signum() == y_b_delta.signum()) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 203 ~ x_a_delta != 0 && y_a_delta != 0 && [INFO] [stdout] 204 | // no need to check 'b', signum accounts for that case. [INFO] [stdout] 205 | [INFO] [stdout] 206 | x_a_delta.abs() == y_a_delta.abs() && [INFO] [stdout] 207 | x_b_delta.abs() == y_b_delta.abs() && [INFO] [stdout] 208 | [INFO] [stdout] ... [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:218:37 [INFO] [stdout] | [INFO] [stdout] 218 | if neighbors & DIR_S != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 218 - if neighbors & DIR_S != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] 218 + if neighbors & DIR_S != 0 { 1 << 4 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:219:37 [INFO] [stdout] | [INFO] [stdout] 219 | if neighbors & DIR_E != 0 { (1 << 1) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 219 - if neighbors & DIR_E != 0 { (1 << 1) } else { 0 } | [INFO] [stdout] 219 + if neighbors & DIR_E != 0 { 1 << 1 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:226:37 [INFO] [stdout] | [INFO] [stdout] 226 | if neighbors & DIR_W != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 226 - if neighbors & DIR_W != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] 226 + if neighbors & DIR_W != 0 { 1 << 4 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:227:37 [INFO] [stdout] | [INFO] [stdout] 227 | if neighbors & DIR_S != 0 { (1 << 2) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 227 - if neighbors & DIR_S != 0 { (1 << 2) } else { 0 } | [INFO] [stdout] 227 + if neighbors & DIR_S != 0 { 1 << 2 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:234:37 [INFO] [stdout] | [INFO] [stdout] 234 | if neighbors & DIR_N != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 234 - if neighbors & DIR_N != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] 234 + if neighbors & DIR_N != 0 { 1 << 4 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:235:37 [INFO] [stdout] | [INFO] [stdout] 235 | if neighbors & DIR_E != 0 { (1 << 1) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 235 - if neighbors & DIR_E != 0 { (1 << 1) } else { 0 } | [INFO] [stdout] 235 + if neighbors & DIR_E != 0 { 1 << 1 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:242:37 [INFO] [stdout] | [INFO] [stdout] 242 | if neighbors & DIR_N != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 242 - if neighbors & DIR_N != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] 242 + if neighbors & DIR_N != 0 { 1 << 4 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:243:37 [INFO] [stdout] | [INFO] [stdout] 243 | if neighbors & DIR_W != 0 { (1 << 2) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 243 - if neighbors & DIR_W != 0 { (1 << 2) } else { 0 } | [INFO] [stdout] 243 + if neighbors & DIR_W != 0 { 1 << 2 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Write` is imported redundantly [INFO] [stdout] --> src/curve_write.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 14 | use std::io::prelude::Write; [INFO] [stdout] | ----------------------- the item `Write` is already imported here [INFO] [stdout] ... [INFO] [stdout] 45 | use std::io::prelude::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Write` is imported redundantly [INFO] [stdout] --> src/curve_write.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 14 | use std::io::prelude::Write; [INFO] [stdout] | ----------------------- the item `Write` is already imported here [INFO] [stdout] ... [INFO] [stdout] 83 | use std::io::prelude::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Write` is imported redundantly [INFO] [stdout] --> src/curve_write.rs:192:13 [INFO] [stdout] | [INFO] [stdout] 14 | use std::io::prelude::Write; [INFO] [stdout] | ----------------------- the item `Write` is already imported here [INFO] [stdout] ... [INFO] [stdout] 192 | use std::io::prelude::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Write` is imported redundantly [INFO] [stdout] --> src/curve_write.rs:256:13 [INFO] [stdout] | [INFO] [stdout] 14 | use std::io::prelude::Write; [INFO] [stdout] | ----------------------- the item `Write` is already imported here [INFO] [stdout] ... [INFO] [stdout] 256 | use std::io::prelude::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Write` is imported redundantly [INFO] [stdout] --> src/curve_write.rs:355:13 [INFO] [stdout] | [INFO] [stdout] 14 | use std::io::prelude::Write; [INFO] [stdout] | ----------------------- the item `Write` is already imported here [INFO] [stdout] ... [INFO] [stdout] 355 | use std::io::prelude::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `polys_from_raster_centerline` is imported redundantly [INFO] [stdout] --> src/main.rs:96:21 [INFO] [stdout] | [INFO] [stdout] 13 | mod polys_from_raster_centerline; [INFO] [stdout] | --------------------------------- the item `polys_from_raster_centerline` is already defined here [INFO] [stdout] ... [INFO] [stdout] 96 | use polys_from_raster_centerline; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `image_skeletonize` is imported redundantly [INFO] [stdout] --> src/main.rs:541:21 [INFO] [stdout] | [INFO] [stdout] 17 | mod image_skeletonize; [INFO] [stdout] | ---------------------- the item `image_skeletonize` is already defined here [INFO] [stdout] ... [INFO] [stdout] 541 | use image_skeletonize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/intern/argparse/mod.rs:29:19 [INFO] [stdout] | [INFO] [stdout] 29 | callback: Box Result>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 29 - callback: Box Result>, [INFO] [stdout] 29 + callback: Box Result>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/intern/argparse/mod.rs:87:23 [INFO] [stdout] | [INFO] [stdout] 87 | callback: Box Result>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 87 - callback: Box Result>, [INFO] [stdout] 87 + callback: Box Result>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 38 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.36s [INFO] running `Command { std: "docker" "inspect" "759e07cc1f8e8e78a02f595bb09e8013788d48965dc176a6746eb679a8a53b91", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "759e07cc1f8e8e78a02f595bb09e8013788d48965dc176a6746eb679a8a53b91", kill_on_drop: false }` [INFO] [stdout] 759e07cc1f8e8e78a02f595bb09e8013788d48965dc176a6746eb679a8a53b91 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-20/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-20/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:0cd99ca24d8e8c98e67c542213511d985b8778b5bdcbb160e038429496686047" "/opt/rustwide/cargo-home/bin/cargo" "+1.59.0" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a27bcb711ef4a0eaeb10ff9e20e94240b6e37353a3b4bbf88160ca8c3a9518ca [INFO] running `Command { std: "docker" "start" "-a" "a27bcb711ef4a0eaeb10ff9e20e94240b6e37353a3b4bbf88160ca8c3a9518ca", kill_on_drop: false }` [INFO] [stderr] Compiling raster-retrace v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/intern/argparse/mod.rs:5:34 [INFO] [stdout] | [INFO] [stdout] 5 | pub const ARGDEF_REQUIRED: u32 = (1 << 0); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 5 - pub const ARGDEF_REQUIRED: u32 = (1 << 0); [INFO] [stdout] 5 + pub const ARGDEF_REQUIRED: u32 = 1 << 0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/intern/argparse/mod.rs:6:34 [INFO] [stdout] | [INFO] [stdout] 6 | pub const ARGDEF_VARARGS: u32 = (1 << 1); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 6 - pub const ARGDEF_VARARGS: u32 = (1 << 1); [INFO] [stdout] 6 + pub const ARGDEF_VARARGS: u32 = 1 << 1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/intern/min_heap/mod.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | ((i - 1) >> 1) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 76 - ((i - 1) >> 1) [INFO] [stdout] 76 + (i - 1) >> 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/intern/min_heap/mod.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | ((i << 1) + 1) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 79 - ((i << 1) + 1) [INFO] [stdout] 79 + (i << 1) + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/intern/min_heap/mod.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | ((i << 1) + 2) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 82 - ((i << 1) + 2) [INFO] [stdout] 82 + (i << 1) + 2 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/intern/min_heap/mod.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | (a.value < b.value) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 96 - (a.value < b.value) [INFO] [stdout] 96 + a.value < b.value [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_outline.rs:45:27 [INFO] [stdout] | [INFO] [stdout] 45 | pub const L: u8 = (1 << 0); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 45 - pub const L: u8 = (1 << 0); [INFO] [stdout] 45 + pub const L: u8 = 1 << 0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_outline.rs:46:27 [INFO] [stdout] | [INFO] [stdout] 46 | pub const R: u8 = (1 << 1); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 46 - pub const R: u8 = (1 << 1); [INFO] [stdout] 46 + pub const R: u8 = 1 << 1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_outline.rs:47:27 [INFO] [stdout] | [INFO] [stdout] 47 | pub const D: u8 = (1 << 2); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 47 - pub const D: u8 = (1 << 2); [INFO] [stdout] 47 + pub const D: u8 = 1 << 2; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_outline.rs:48:27 [INFO] [stdout] | [INFO] [stdout] 48 | pub const U: u8 = (1 << 3); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 48 - pub const U: u8 = (1 << 3); [INFO] [stdout] 48 + pub const U: u8 = 1 << 3; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/polys_from_raster_outline.rs:149:29 [INFO] [stdout] | [INFO] [stdout] 149 | ... ((x == xy_a[0] && x == xy_b[0]) || [INFO] [stdout] | ^ [INFO] [stdout] 150 | ... (y == xy_a[1] && y == xy_b[1])) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 149 ~ (x == xy_a[0] && x == xy_b[0]) || [INFO] [stdout] 150 ~ (y == xy_a[1] && y == xy_b[1]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:21:27 [INFO] [stdout] | [INFO] [stdout] 21 | pub const L: u8 = (1 << 0); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 21 - pub const L: u8 = (1 << 0); [INFO] [stdout] 21 + pub const L: u8 = 1 << 0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:22:27 [INFO] [stdout] | [INFO] [stdout] 22 | pub const R: u8 = (1 << 1); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 22 - pub const R: u8 = (1 << 1); [INFO] [stdout] 22 + pub const R: u8 = 1 << 1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:23:27 [INFO] [stdout] | [INFO] [stdout] 23 | pub const D: u8 = (1 << 2); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 23 - pub const D: u8 = (1 << 2); [INFO] [stdout] 23 + pub const D: u8 = 1 << 2; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:24:27 [INFO] [stdout] | [INFO] [stdout] 24 | pub const U: u8 = (1 << 3); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 24 - pub const U: u8 = (1 << 3); [INFO] [stdout] 24 + pub const U: u8 = 1 << 3; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:26:28 [INFO] [stdout] | [INFO] [stdout] 26 | pub const LD: u8 = (1 << 4); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 26 - pub const LD: u8 = (1 << 4); [INFO] [stdout] 26 + pub const LD: u8 = 1 << 4; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:27:28 [INFO] [stdout] | [INFO] [stdout] 27 | pub const LU: u8 = (1 << 5); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 27 - pub const LU: u8 = (1 << 5); [INFO] [stdout] 27 + pub const LU: u8 = 1 << 5; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:28:28 [INFO] [stdout] | [INFO] [stdout] 28 | pub const RD: u8 = (1 << 6); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 28 - pub const RD: u8 = (1 << 6); [INFO] [stdout] 28 + pub const RD: u8 = 1 << 6; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:29:28 [INFO] [stdout] | [INFO] [stdout] 29 | pub const RU: u8 = (1 << 7); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 29 - pub const RU: u8 = (1 << 7); [INFO] [stdout] 29 + pub const RU: u8 = 1 << 7; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:192:29 [INFO] [stdout] | [INFO] [stdout] 192 | / ... ( [INFO] [stdout] 193 | | ... // axis aligned [INFO] [stdout] 194 | | ... (x == xy_a[0] && x == xy_b[0]) || [INFO] [stdout] | |__________________________^ [INFO] [stdout] ... [INFO] [stdout] 212 | ... } [INFO] [stdout] | ____________________________^ [INFO] [stdout] 213 | | ... ) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 192 ~ (x == xy_a[0] && x == xy_b[0]) || [INFO] [stdout] 193 | (y == xy_a[1] && y == xy_b[1]) || [INFO] [stdout] 194 | // diagonal [INFO] [stdout] 195 | { [INFO] [stdout] 196 | let x_a_delta = xy_a[0] - xy_b[0]; [INFO] [stdout] 197 | let y_a_delta = xy_a[1] - xy_b[1]; [INFO] [stdout] ... [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/polys_from_raster_centerline.rs:203:37 [INFO] [stdout] | [INFO] [stdout] 203 | ... (x_a_delta != 0 && y_a_delta != 0 && [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 211 | ... y_a_delta.signum() == y_b_delta.signum()) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 203 ~ x_a_delta != 0 && y_a_delta != 0 && [INFO] [stdout] 204 | // no need to check 'b', signum accounts for that case. [INFO] [stdout] 205 | [INFO] [stdout] 206 | x_a_delta.abs() == y_a_delta.abs() && [INFO] [stdout] 207 | x_b_delta.abs() == y_b_delta.abs() && [INFO] [stdout] 208 | [INFO] [stdout] ... [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:218:37 [INFO] [stdout] | [INFO] [stdout] 218 | if neighbors & DIR_S != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 218 - if neighbors & DIR_S != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] 218 + if neighbors & DIR_S != 0 { 1 << 4 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:219:37 [INFO] [stdout] | [INFO] [stdout] 219 | if neighbors & DIR_E != 0 { (1 << 1) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 219 - if neighbors & DIR_E != 0 { (1 << 1) } else { 0 } | [INFO] [stdout] 219 + if neighbors & DIR_E != 0 { 1 << 1 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:226:37 [INFO] [stdout] | [INFO] [stdout] 226 | if neighbors & DIR_W != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 226 - if neighbors & DIR_W != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] 226 + if neighbors & DIR_W != 0 { 1 << 4 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:227:37 [INFO] [stdout] | [INFO] [stdout] 227 | if neighbors & DIR_S != 0 { (1 << 2) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 227 - if neighbors & DIR_S != 0 { (1 << 2) } else { 0 } | [INFO] [stdout] 227 + if neighbors & DIR_S != 0 { 1 << 2 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:234:37 [INFO] [stdout] | [INFO] [stdout] 234 | if neighbors & DIR_N != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 234 - if neighbors & DIR_N != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] 234 + if neighbors & DIR_N != 0 { 1 << 4 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:235:37 [INFO] [stdout] | [INFO] [stdout] 235 | if neighbors & DIR_E != 0 { (1 << 1) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 235 - if neighbors & DIR_E != 0 { (1 << 1) } else { 0 } | [INFO] [stdout] 235 + if neighbors & DIR_E != 0 { 1 << 1 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:242:37 [INFO] [stdout] | [INFO] [stdout] 242 | if neighbors & DIR_N != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 242 - if neighbors & DIR_N != 0 { (1 << 4) } else { 0 } | [INFO] [stdout] 242 + if neighbors & DIR_N != 0 { 1 << 4 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/image_skeletonize.rs:243:37 [INFO] [stdout] | [INFO] [stdout] 243 | if neighbors & DIR_W != 0 { (1 << 2) } else { 0 } | [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 243 - if neighbors & DIR_W != 0 { (1 << 2) } else { 0 } | [INFO] [stdout] 243 + if neighbors & DIR_W != 0 { 1 << 2 } else { 0 } | [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Write` is imported redundantly [INFO] [stdout] --> src/curve_write.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 14 | use std::io::prelude::Write; [INFO] [stdout] | ----------------------- the item `Write` is already imported here [INFO] [stdout] ... [INFO] [stdout] 45 | use std::io::prelude::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Write` is imported redundantly [INFO] [stdout] --> src/curve_write.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 14 | use std::io::prelude::Write; [INFO] [stdout] | ----------------------- the item `Write` is already imported here [INFO] [stdout] ... [INFO] [stdout] 83 | use std::io::prelude::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Write` is imported redundantly [INFO] [stdout] --> src/curve_write.rs:192:13 [INFO] [stdout] | [INFO] [stdout] 14 | use std::io::prelude::Write; [INFO] [stdout] | ----------------------- the item `Write` is already imported here [INFO] [stdout] ... [INFO] [stdout] 192 | use std::io::prelude::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Write` is imported redundantly [INFO] [stdout] --> src/curve_write.rs:256:13 [INFO] [stdout] | [INFO] [stdout] 14 | use std::io::prelude::Write; [INFO] [stdout] | ----------------------- the item `Write` is already imported here [INFO] [stdout] ... [INFO] [stdout] 256 | use std::io::prelude::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Write` is imported redundantly [INFO] [stdout] --> src/curve_write.rs:355:13 [INFO] [stdout] | [INFO] [stdout] 14 | use std::io::prelude::Write; [INFO] [stdout] | ----------------------- the item `Write` is already imported here [INFO] [stdout] ... [INFO] [stdout] 355 | use std::io::prelude::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `polys_from_raster_centerline` is imported redundantly [INFO] [stdout] --> src/main.rs:96:21 [INFO] [stdout] | [INFO] [stdout] 13 | mod polys_from_raster_centerline; [INFO] [stdout] | --------------------------------- the item `polys_from_raster_centerline` is already defined here [INFO] [stdout] ... [INFO] [stdout] 96 | use polys_from_raster_centerline; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `image_skeletonize` is imported redundantly [INFO] [stdout] --> src/main.rs:541:21 [INFO] [stdout] | [INFO] [stdout] 17 | mod image_skeletonize; [INFO] [stdout] | ---------------------- the item `image_skeletonize` is already defined here [INFO] [stdout] ... [INFO] [stdout] 541 | use image_skeletonize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/intern/argparse/mod.rs:29:19 [INFO] [stdout] | [INFO] [stdout] 29 | callback: Box Result>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 29 - callback: Box Result>, [INFO] [stdout] 29 + callback: Box Result>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/intern/argparse/mod.rs:87:23 [INFO] [stdout] | [INFO] [stdout] 87 | callback: Box Result>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 87 - callback: Box Result>, [INFO] [stdout] 87 + callback: Box Result>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 38 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 2.19s [INFO] running `Command { std: "docker" "inspect" "a27bcb711ef4a0eaeb10ff9e20e94240b6e37353a3b4bbf88160ca8c3a9518ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a27bcb711ef4a0eaeb10ff9e20e94240b6e37353a3b4bbf88160ca8c3a9518ca", kill_on_drop: false }` [INFO] [stdout] a27bcb711ef4a0eaeb10ff9e20e94240b6e37353a3b4bbf88160ca8c3a9518ca [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-20/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-20/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:0cd99ca24d8e8c98e67c542213511d985b8778b5bdcbb160e038429496686047" "/opt/rustwide/cargo-home/bin/cargo" "+1.59.0" "test" "--frozen", kill_on_drop: false }` [INFO] [stdout] 1f94f0701b1a6e431027a0049d2dff85e03a9d86ba18fac44ba05d94fe2c4bd6 [INFO] running `Command { std: "docker" "start" "-a" "1f94f0701b1a6e431027a0049d2dff85e03a9d86ba18fac44ba05d94fe2c4bd6", kill_on_drop: false }` [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/intern/argparse/mod.rs:5:34 [INFO] [stderr] | [INFO] [stderr] 5 | pub const ARGDEF_REQUIRED: u32 = (1 << 0); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 5 - pub const ARGDEF_REQUIRED: u32 = (1 << 0); [INFO] [stderr] 5 + pub const ARGDEF_REQUIRED: u32 = 1 << 0; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/intern/argparse/mod.rs:6:34 [INFO] [stderr] | [INFO] [stderr] 6 | pub const ARGDEF_VARARGS: u32 = (1 << 1); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 6 - pub const ARGDEF_VARARGS: u32 = (1 << 1); [INFO] [stderr] 6 + pub const ARGDEF_VARARGS: u32 = 1 << 1; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around block return value [INFO] [stderr] --> src/intern/min_heap/mod.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | ((i - 1) >> 1) [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 76 - ((i - 1) >> 1) [INFO] [stderr] 76 + (i - 1) >> 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around block return value [INFO] [stderr] --> src/intern/min_heap/mod.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | ((i << 1) + 1) [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 79 - ((i << 1) + 1) [INFO] [stderr] 79 + (i << 1) + 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around block return value [INFO] [stderr] --> src/intern/min_heap/mod.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | ((i << 1) + 2) [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 82 - ((i << 1) + 2) [INFO] [stderr] 82 + (i << 1) + 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around block return value [INFO] [stderr] --> src/intern/min_heap/mod.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | (a.value < b.value) [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 96 - (a.value < b.value) [INFO] [stderr] 96 + a.value < b.value [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/polys_from_raster_outline.rs:45:27 [INFO] [stderr] | [INFO] [stderr] 45 | pub const L: u8 = (1 << 0); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 45 - pub const L: u8 = (1 << 0); [INFO] [stderr] 45 + pub const L: u8 = 1 << 0; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/polys_from_raster_outline.rs:46:27 [INFO] [stderr] | [INFO] [stderr] 46 | pub const R: u8 = (1 << 1); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 46 - pub const R: u8 = (1 << 1); [INFO] [stderr] 46 + pub const R: u8 = 1 << 1; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/polys_from_raster_outline.rs:47:27 [INFO] [stderr] | [INFO] [stderr] 47 | pub const D: u8 = (1 << 2); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 47 - pub const D: u8 = (1 << 2); [INFO] [stderr] 47 + pub const D: u8 = 1 << 2; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/polys_from_raster_outline.rs:48:27 [INFO] [stderr] | [INFO] [stderr] 48 | pub const U: u8 = (1 << 3); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 48 - pub const U: u8 = (1 << 3); [INFO] [stderr] 48 + pub const U: u8 = 1 << 3; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around block return value [INFO] [stderr] --> src/polys_from_raster_outline.rs:149:29 [INFO] [stderr] | [INFO] [stderr] 149 | ... ((x == xy_a[0] && x == xy_b[0]) || [INFO] [stderr] | ^ [INFO] [stderr] 150 | ... (y == xy_a[1] && y == xy_b[1])) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 149 ~ (x == xy_a[0] && x == xy_b[0]) || [INFO] [stderr] 150 ~ (y == xy_a[1] && y == xy_b[1]) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/polys_from_raster_centerline.rs:21:27 [INFO] [stderr] | [INFO] [stderr] 21 | pub const L: u8 = (1 << 0); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 21 - pub const L: u8 = (1 << 0); [INFO] [stderr] 21 + pub const L: u8 = 1 << 0; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/polys_from_raster_centerline.rs:22:27 [INFO] [stderr] | [INFO] [stderr] 22 | pub const R: u8 = (1 << 1); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 22 - pub const R: u8 = (1 << 1); [INFO] [stderr] 22 + pub const R: u8 = 1 << 1; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/polys_from_raster_centerline.rs:23:27 [INFO] [stderr] | [INFO] [stderr] 23 | pub const D: u8 = (1 << 2); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 23 - pub const D: u8 = (1 << 2); [INFO] [stderr] 23 + pub const D: u8 = 1 << 2; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/polys_from_raster_centerline.rs:24:27 [INFO] [stderr] | [INFO] [stderr] 24 | pub const U: u8 = (1 << 3); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 24 - pub const U: u8 = (1 << 3); [INFO] [stderr] 24 + pub const U: u8 = 1 << 3; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/polys_from_raster_centerline.rs:26:28 [INFO] [stderr] | [INFO] [stderr] 26 | pub const LD: u8 = (1 << 4); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 26 - pub const LD: u8 = (1 << 4); [INFO] [stderr] 26 + pub const LD: u8 = 1 << 4; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/polys_from_raster_centerline.rs:27:28 [INFO] [stderr] | [INFO] [stderr] 27 | pub const LU: u8 = (1 << 5); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 27 - pub const LU: u8 = (1 << 5); [INFO] [stderr] 27 + pub const LU: u8 = 1 << 5; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/polys_from_raster_centerline.rs:28:28 [INFO] [stderr] | [INFO] [stderr] 28 | pub const RD: u8 = (1 << 6); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 28 - pub const RD: u8 = (1 << 6); [INFO] [stderr] 28 + pub const RD: u8 = 1 << 6; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/polys_from_raster_centerline.rs:29:28 [INFO] [stderr] | [INFO] [stderr] 29 | pub const RU: u8 = (1 << 7); [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 29 - pub const RU: u8 = (1 << 7); [INFO] [stderr] 29 + pub const RU: u8 = 1 << 7; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around block return value [INFO] [stderr] --> src/polys_from_raster_centerline.rs:192:29 [INFO] [stderr] | [INFO] [stderr] 192 | / ... ( [INFO] [stderr] 193 | | ... // axis aligned [INFO] [stderr] 194 | | ... (x == xy_a[0] && x == xy_b[0]) || [INFO] [stderr] | |__________________________^ [INFO] [stderr] ... [INFO] [stderr] 212 | ... } [INFO] [stderr] | ____________________________^ [INFO] [stderr] 213 | | ... ) [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 192 ~ (x == xy_a[0] && x == xy_b[0]) || [INFO] [stderr] 193 | (y == xy_a[1] && y == xy_b[1]) || [INFO] [stderr] 194 | // diagonal [INFO] [stderr] 195 | { [INFO] [stderr] 196 | let x_a_delta = xy_a[0] - xy_b[0]; [INFO] [stderr] 197 | let y_a_delta = xy_a[1] - xy_b[1]; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around block return value [INFO] [stderr] --> src/polys_from_raster_centerline.rs:203:37 [INFO] [stderr] | [INFO] [stderr] 203 | ... (x_a_delta != 0 && y_a_delta != 0 && [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 211 | ... y_a_delta.signum() == y_b_delta.signum()) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 203 ~ x_a_delta != 0 && y_a_delta != 0 && [INFO] [stderr] 204 | // no need to check 'b', signum accounts for that case. [INFO] [stderr] 205 | [INFO] [stderr] 206 | x_a_delta.abs() == y_a_delta.abs() && [INFO] [stderr] 207 | x_b_delta.abs() == y_b_delta.abs() && [INFO] [stderr] 208 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around block return value [INFO] [stderr] --> src/image_skeletonize.rs:218:37 [INFO] [stderr] | [INFO] [stderr] 218 | if neighbors & DIR_S != 0 { (1 << 4) } else { 0 } | [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 218 - if neighbors & DIR_S != 0 { (1 << 4) } else { 0 } | [INFO] [stderr] 218 + if neighbors & DIR_S != 0 { 1 << 4 } else { 0 } | [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around block return value [INFO] [stderr] --> src/image_skeletonize.rs:219:37 [INFO] [stderr] | [INFO] [stderr] 219 | if neighbors & DIR_E != 0 { (1 << 1) } else { 0 } | [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 219 - if neighbors & DIR_E != 0 { (1 << 1) } else { 0 } | [INFO] [stderr] 219 + if neighbors & DIR_E != 0 { 1 << 1 } else { 0 } | [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around block return value [INFO] [stderr] --> src/image_skeletonize.rs:226:37 [INFO] [stderr] | [INFO] [stderr] 226 | if neighbors & DIR_W != 0 { (1 << 4) } else { 0 } | [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 226 - if neighbors & DIR_W != 0 { (1 << 4) } else { 0 } | [INFO] [stderr] 226 + if neighbors & DIR_W != 0 { 1 << 4 } else { 0 } | [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around block return value [INFO] [stderr] --> src/image_skeletonize.rs:227:37 [INFO] [stderr] | [INFO] [stderr] 227 | if neighbors & DIR_S != 0 { (1 << 2) } else { 0 } | [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 227 - if neighbors & DIR_S != 0 { (1 << 2) } else { 0 } | [INFO] [stderr] 227 + if neighbors & DIR_S != 0 { 1 << 2 } else { 0 } | [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around block return value [INFO] [stderr] --> src/image_skeletonize.rs:234:37 [INFO] [stderr] | [INFO] [stderr] 234 | if neighbors & DIR_N != 0 { (1 << 4) } else { 0 } | [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 234 - if neighbors & DIR_N != 0 { (1 << 4) } else { 0 } | [INFO] [stderr] 234 + if neighbors & DIR_N != 0 { 1 << 4 } else { 0 } | [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around block return value [INFO] [stderr] --> src/image_skeletonize.rs:235:37 [INFO] [stderr] | [INFO] [stderr] 235 | if neighbors & DIR_E != 0 { (1 << 1) } else { 0 } | [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 235 - if neighbors & DIR_E != 0 { (1 << 1) } else { 0 } | [INFO] [stderr] 235 + if neighbors & DIR_E != 0 { 1 << 1 } else { 0 } | [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around block return value [INFO] [stderr] --> src/image_skeletonize.rs:242:37 [INFO] [stderr] | [INFO] [stderr] 242 | if neighbors & DIR_N != 0 { (1 << 4) } else { 0 } | [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 242 - if neighbors & DIR_N != 0 { (1 << 4) } else { 0 } | [INFO] [stderr] 242 + if neighbors & DIR_N != 0 { 1 << 4 } else { 0 } | [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around block return value [INFO] [stderr] --> src/image_skeletonize.rs:243:37 [INFO] [stderr] | [INFO] [stderr] 243 | if neighbors & DIR_W != 0 { (1 << 2) } else { 0 } | [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 243 - if neighbors & DIR_W != 0 { (1 << 2) } else { 0 } | [INFO] [stderr] 243 + if neighbors & DIR_W != 0 { 1 << 2 } else { 0 } | [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the item `Write` is imported redundantly [INFO] [stderr] --> src/curve_write.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 14 | use std::io::prelude::Write; [INFO] [stderr] | ----------------------- the item `Write` is already imported here [INFO] [stderr] ... [INFO] [stderr] 45 | use std::io::prelude::Write; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: the item `Write` is imported redundantly [INFO] [stderr] --> src/curve_write.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 14 | use std::io::prelude::Write; [INFO] [stderr] | ----------------------- the item `Write` is already imported here [INFO] [stderr] ... [INFO] [stderr] 83 | use std::io::prelude::Write; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the item `Write` is imported redundantly [INFO] [stderr] --> src/curve_write.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 14 | use std::io::prelude::Write; [INFO] [stderr] | ----------------------- the item `Write` is already imported here [INFO] [stderr] ... [INFO] [stderr] 192 | use std::io::prelude::Write; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the item `Write` is imported redundantly [INFO] [stderr] --> src/curve_write.rs:256:13 [INFO] [stderr] | [INFO] [stderr] 14 | use std::io::prelude::Write; [INFO] [stderr] | ----------------------- the item `Write` is already imported here [INFO] [stderr] ... [INFO] [stderr] 256 | use std::io::prelude::Write; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the item `Write` is imported redundantly [INFO] [stderr] --> src/curve_write.rs:355:13 [INFO] [stderr] | [INFO] [stderr] 14 | use std::io::prelude::Write; [INFO] [stderr] | ----------------------- the item `Write` is already imported here [INFO] [stderr] ... [INFO] [stderr] 355 | use std::io::prelude::Write; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the item `polys_from_raster_centerline` is imported redundantly [INFO] [stderr] --> src/main.rs:96:21 [INFO] [stderr] | [INFO] [stderr] 13 | mod polys_from_raster_centerline; [INFO] [stderr] | --------------------------------- the item `polys_from_raster_centerline` is already defined here [INFO] [stderr] ... [INFO] [stderr] 96 | use polys_from_raster_centerline; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the item `image_skeletonize` is imported redundantly [INFO] [stderr] --> src/main.rs:541:21 [INFO] [stderr] | [INFO] [stderr] 17 | mod image_skeletonize; [INFO] [stderr] | ---------------------- the item `image_skeletonize` is already defined here [INFO] [stderr] ... [INFO] [stderr] 541 | use image_skeletonize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/intern/argparse/mod.rs:29:19 [INFO] [stderr] | [INFO] [stderr] 29 | callback: Box Result>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] help: use `dyn` [INFO] [stderr] | [INFO] [stderr] 29 - callback: Box Result>, [INFO] [stderr] 29 + callback: Box Result>, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/intern/argparse/mod.rs:87:23 [INFO] [stderr] | [INFO] [stderr] 87 | callback: Box Result>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] help: use `dyn` [INFO] [stderr] | [INFO] [stderr] 87 - callback: Box Result>, [INFO] [stderr] 87 + callback: Box Result>, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `raster-retrace` (bin "raster-retrace" test) generated 38 warnings [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 0.10s [INFO] [stderr] Running unittests (/opt/rustwide/target/debug/deps/raster_retrace-68f889e50d00a5ec) [INFO] [stdout] [INFO] [stdout] running 1 test [INFO] [stdout] test test::test_image_small ... FAILED [INFO] [stdout] [INFO] [stdout] failures: [INFO] [stdout] [INFO] [stdout] ---- test::test_image_small stdout ---- [INFO] [stdout] 12 -> 3 [INFO] [stdout] 68 -> 14 [INFO] [stdout] Total points: 17 [INFO] [stdout] [INFO] [stdout] thread 'test::test_image_small' panicked at 'Create output file: Os { code: 30, kind: ReadOnlyFilesystem, message: "Read-only file system" }', src/main.rs:151:54 [INFO] [stdout] stack backtrace: [INFO] [stdout] 0: 0x55e9a1c8c7ac - std::backtrace_rs::backtrace::libunwind::trace::h91c465e73bf6c785 [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/std/src/../../backtrace/src/backtrace/libunwind.rs:93:5 [INFO] [stdout] 1: 0x55e9a1c8c7ac - std::backtrace_rs::backtrace::trace_unsynchronized::hae9da36f5d58b5f3 [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5 [INFO] [stdout] 2: 0x55e9a1c8c7ac - std::sys_common::backtrace::_print_fmt::h7f499fa126a7effb [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/std/src/sys_common/backtrace.rs:67:5 [INFO] [stdout] 3: 0x55e9a1c8c7ac - ::fmt::h3e2b509ce2ce6007 [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/std/src/sys_common/backtrace.rs:46:22 [INFO] [stdout] 4: 0x55e9a1cb20ec - core::fmt::write::h753c7571fa063ecb [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/fmt/mod.rs:1168:17 [INFO] [stdout] 5: 0x55e9a1c87a13 - std::io::Write::write_fmt::hb649ab67f71b6655 [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/std/src/io/mod.rs:1660:15 [INFO] [stdout] 6: 0x55e9a1c8ee82 - std::sys_common::backtrace::_print::h64941a6fc8b0ed9b [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/std/src/sys_common/backtrace.rs:49:5 [INFO] [stdout] 7: 0x55e9a1c8ee82 - std::sys_common::backtrace::print::hcf25e43e1a9b0766 [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/std/src/sys_common/backtrace.rs:36:9 [INFO] [stdout] 8: 0x55e9a1c8ee82 - std::panicking::default_hook::{{closure}}::h78d3e6cf97fc623d [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/std/src/panicking.rs:211:50 [INFO] [stdout] 9: 0x55e9a1c8ead1 - std::panicking::default_hook::hda898f8d3ad1a5ae [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/std/src/panicking.rs:225:9 [INFO] [stdout] 10: 0x55e9a1c8f4d3 - std::panicking::rust_panic_with_hook::h1a5ea2d6c23051aa [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/std/src/panicking.rs:606:17 [INFO] [stdout] 11: 0x55e9a1c8f1f0 - std::panicking::begin_panic_handler::{{closure}}::h07f549390938b73f [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/std/src/panicking.rs:502:13 [INFO] [stdout] 12: 0x55e9a1c8cc54 - std::sys_common::backtrace::__rust_end_short_backtrace::h5ec3758a92cfb00d [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/std/src/sys_common/backtrace.rs:139:18 [INFO] [stdout] 13: 0x55e9a1c8ef29 - rust_begin_unwind [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/std/src/panicking.rs:498:5 [INFO] [stdout] 14: 0x55e9a1be6e51 - core::panicking::panic_fmt::h3a79a6a99affe1d5 [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/panicking.rs:116:14 [INFO] [stdout] 15: 0x55e9a1be6f43 - core::result::unwrap_failed::ha0327e3803285d6e [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/result.rs:1690:5 [INFO] [stdout] 16: 0x55e9a1c259ef - core::result::Result::expect::h32b3a7679fc637da [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/result.rs:975:23 [INFO] [stdout] 17: 0x55e9a1c2a258 - raster_retrace::trace_image::h8ab6ff7243332649 [INFO] [stdout] at /opt/rustwide/workdir/src/main.rs:151:13 [INFO] [stdout] 18: 0x55e9a1c15422 - raster_retrace::test::test_image_small::hdbcc276ae661599a [INFO] [stdout] at /opt/rustwide/workdir/src/tests.rs:12:19 [INFO] [stdout] 19: 0x55e9a1c1530a - raster_retrace::test::test_image_small::{{closure}}::h3d1f255875fed60d [INFO] [stdout] at /opt/rustwide/workdir/src/tests.rs:8:9 [INFO] [stdout] 20: 0x55e9a1bf706e - core::ops::function::FnOnce::call_once::hc6a469fae78567c3 [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/ops/function.rs:227:5 [INFO] [stdout] 21: 0x55e9a1c626a3 - core::ops::function::FnOnce::call_once::h1845a80638abc06e [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/ops/function.rs:227:5 [INFO] [stdout] 22: 0x55e9a1c626a3 - test::__rust_begin_short_backtrace::h4f56ccea01b9889f [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/test/src/lib.rs:574:5 [INFO] [stdout] 23: 0x55e9a1c6138f - as core::ops::function::FnOnce>::call_once::h5afedf14a39ffa74 [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/alloc/src/boxed.rs:1854:9 [INFO] [stdout] 24: 0x55e9a1c6138f - as core::ops::function::FnOnce<()>>::call_once::hd5aaa1b551e9ce71 [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/panic/unwind_safe.rs:271:9 [INFO] [stdout] 25: 0x55e9a1c6138f - std::panicking::try::do_call::h316eebee63f96d32 [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/std/src/panicking.rs:406:40 [INFO] [stdout] 26: 0x55e9a1c6138f - std::panicking::try::h662e31e84dd7ce52 [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/std/src/panicking.rs:370:19 [INFO] [stdout] 27: 0x55e9a1c6138f - std::panic::catch_unwind::h129c1b23f076663f [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/std/src/panic.rs:133:14 [INFO] [stdout] 28: 0x55e9a1c6138f - test::run_test_in_process::h51d800d572f878ef [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/test/src/lib.rs:597:18 [INFO] [stdout] 29: 0x55e9a1c6138f - test::run_test::run_test_inner::{{closure}}::h71a47db430260854 [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/test/src/lib.rs:491:39 [INFO] [stdout] 30: 0x55e9a1c6a751 - test::run_test::run_test_inner::{{closure}}::h02edd5b3e2dab52a [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/test/src/lib.rs:518:37 [INFO] [stdout] 31: 0x55e9a1c6a751 - std::sys_common::backtrace::__rust_begin_short_backtrace::h0838cfc8b0e995ec [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/std/src/sys_common/backtrace.rs:123:18 [INFO] [stdout] 32: 0x55e9a1c371df - std::thread::Builder::spawn_unchecked::{{closure}}::{{closure}}::h4c2725d7078043cd [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/std/src/thread/mod.rs:477:17 [INFO] [stdout] 33: 0x55e9a1c371df - as core::ops::function::FnOnce<()>>::call_once::hdf1aa612eed87270 [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/panic/unwind_safe.rs:271:9 [INFO] [stdout] 34: 0x55e9a1c371df - std::panicking::try::do_call::hc72f8de3706d18d6 [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/std/src/panicking.rs:406:40 [INFO] [stdout] 35: 0x55e9a1c371df - std::panicking::try::h63f01f54dbd0fb87 [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/std/src/panicking.rs:370:19 [INFO] [stdout] 36: 0x55e9a1c371df - std::panic::catch_unwind::h58bc464ae9b26453 [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/std/src/panic.rs:133:14 [INFO] [stdout] 37: 0x55e9a1c371df - std::thread::Builder::spawn_unchecked::{{closure}}::h6c065e19513e33e3 [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/std/src/thread/mod.rs:476:30 [INFO] [stdout] 38: 0x55e9a1c371df - core::ops::function::FnOnce::call_once{{vtable.shim}}::hd143450c74f35c32 [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/ops/function.rs:227:5 [INFO] [stdout] 39: 0x55e9a1c95053 - as core::ops::function::FnOnce>::call_once::h49b6c7c5155a2296 [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/alloc/src/boxed.rs:1854:9 [INFO] [stdout] 40: 0x55e9a1c95053 - as core::ops::function::FnOnce>::call_once::ha8b5234bfeb15105 [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/alloc/src/boxed.rs:1854:9 [INFO] [stdout] 41: 0x55e9a1c95053 - std::sys::unix::thread::Thread::new::thread_start::h6f207dd842d64859 [INFO] [stdout] at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/std/src/sys/unix/thread.rs:108:17 [INFO] [stdout] 42: 0x7f4716c8d609 - start_thread [INFO] [stdout] 43: 0x7f4716a5f293 - clone [INFO] [stdout] 44: 0x0 - [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] failures: [INFO] [stdout] test::test_image_small [INFO] [stdout] [INFO] [stdout] test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.08s [INFO] [stdout] [INFO] [stderr] error: test failed, to rerun pass '--bin raster-retrace' [INFO] running `Command { std: "docker" "inspect" "1f94f0701b1a6e431027a0049d2dff85e03a9d86ba18fac44ba05d94fe2c4bd6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1f94f0701b1a6e431027a0049d2dff85e03a9d86ba18fac44ba05d94fe2c4bd6", kill_on_drop: false }` [INFO] [stdout] 1f94f0701b1a6e431027a0049d2dff85e03a9d86ba18fac44ba05d94fe2c4bd6