[INFO] cloning repository https://github.com/leah3393/invaders_emulator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/leah3393/invaders_emulator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fleah3393%2Finvaders_emulator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fleah3393%2Finvaders_emulator'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e9561718c80030476ea821d56237ea62bc93b98a [INFO] testing leah3393/invaders_emulator against 1.59.0 for beta-1.60-1 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fleah3393%2Finvaders_emulator" "/workspace/builds/worker-3/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/leah3393/invaders_emulator on toolchain 1.59.0 [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+1.59.0" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/leah3393/invaders_emulator [INFO] finished tweaking git repo https://github.com/leah3393/invaders_emulator [INFO] tweaked toml for git repo https://github.com/leah3393/invaders_emulator written to /workspace/builds/worker-3/source/Cargo.toml [INFO] crate git repo https://github.com/leah3393/invaders_emulator already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+1.59.0" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:0cd99ca24d8e8c98e67c542213511d985b8778b5bdcbb160e038429496686047" "/opt/rustwide/cargo-home/bin/cargo" "+1.59.0" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b835ecedd14f06b1d94f0310d1819e779b777356d5e28c6100a1d41f12a4b3a0 [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] running `Command { std: "docker" "start" "-a" "b835ecedd14f06b1d94f0310d1819e779b777356d5e28c6100a1d41f12a4b3a0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b835ecedd14f06b1d94f0310d1819e779b777356d5e28c6100a1d41f12a4b3a0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b835ecedd14f06b1d94f0310d1819e779b777356d5e28c6100a1d41f12a4b3a0", kill_on_drop: false }` [INFO] [stdout] b835ecedd14f06b1d94f0310d1819e779b777356d5e28c6100a1d41f12a4b3a0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:0cd99ca24d8e8c98e67c542213511d985b8778b5bdcbb160e038429496686047" "/opt/rustwide/cargo-home/bin/cargo" "+1.59.0" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dbacd39c0d87100b5e65410d5e794224ad0443265dc0eb68c0148b0e3ca9ad73 [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] running `Command { std: "docker" "start" "-a" "dbacd39c0d87100b5e65410d5e794224ad0443265dc0eb68c0148b0e3ca9ad73", kill_on_drop: false }` [INFO] [stderr] Compiling syn v0.15.39 [INFO] [stderr] Compiling strum v0.15.0 [INFO] [stderr] Compiling strum_macros v0.15.0 [INFO] [stderr] Compiling intel_8080_emulator v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/disassembler/parser.rs:5:61 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn parse(filename: &str, mem_size: usize) -> io::Result<(Vec)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 5 - pub fn parse(filename: &str, mem_size: usize) -> io::Result<(Vec)> { [INFO] [stdout] 5 + pub fn parse(filename: &str, mem_size: usize) -> io::Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/architecture/units/io_unit.rs:6:54 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn get_output_handler(device_id: u8) -> &'static OutputHandler { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 6 - pub fn get_output_handler(device_id: u8) -> &'static OutputHandler { [INFO] [stdout] 6 + pub fn get_output_handler(device_id: u8) -> &'static dyn OutputHandler { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/architecture/units/io_unit.rs:10:53 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn get_input_handler(device_id: u8) -> &'static InputHandler { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 10 - pub fn get_input_handler(device_id: u8) -> &'static InputHandler { [INFO] [stdout] 10 + pub fn get_input_handler(device_id: u8) -> &'static dyn InputHandler { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `device_id` [INFO] [stdout] --> src/architecture/units/io_unit.rs:6:27 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn get_output_handler(device_id: u8) -> &'static OutputHandler { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_device_id` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `device_id` [INFO] [stdout] --> src/architecture/units/io_unit.rs:10:26 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn get_input_handler(device_id: u8) -> &'static InputHandler { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_device_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `state` [INFO] [stdout] --> src/architecture/devices/output_handler.rs:11:22 [INFO] [stdout] | [INFO] [stdout] 11 | fn handle(&self, state: &mut State, signal: IoSignal){ [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_state` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `state` [INFO] [stdout] --> src/architecture/devices/input_handler.rs:11:27 [INFO] [stdout] | [INFO] [stdout] 11 | fn next_signal(&self, state: &mut State) -> IoSignal { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_state` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cpu` [INFO] [stdout] --> src/main.rs:12:13 [INFO] [stdout] | [INFO] [stdout] 12 | let mut cpu = CpuContext::load_program(program, 65536); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_cpu` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | let mut cpu = CpuContext::load_program(program, 65536); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.91s [INFO] running `Command { std: "docker" "inspect" "dbacd39c0d87100b5e65410d5e794224ad0443265dc0eb68c0148b0e3ca9ad73", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dbacd39c0d87100b5e65410d5e794224ad0443265dc0eb68c0148b0e3ca9ad73", kill_on_drop: false }` [INFO] [stdout] dbacd39c0d87100b5e65410d5e794224ad0443265dc0eb68c0148b0e3ca9ad73 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:0cd99ca24d8e8c98e67c542213511d985b8778b5bdcbb160e038429496686047" "/opt/rustwide/cargo-home/bin/cargo" "+1.59.0" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 75d34f0c1cedcfa42654a2f35404e47037cdc24d1c10fc2a20cfecfefc3ad483 [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] running `Command { std: "docker" "start" "-a" "75d34f0c1cedcfa42654a2f35404e47037cdc24d1c10fc2a20cfecfefc3ad483", kill_on_drop: false }` [INFO] [stderr] Compiling intel_8080_emulator v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/disassembler/parser.rs:5:61 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn parse(filename: &str, mem_size: usize) -> io::Result<(Vec)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 5 - pub fn parse(filename: &str, mem_size: usize) -> io::Result<(Vec)> { [INFO] [stdout] 5 + pub fn parse(filename: &str, mem_size: usize) -> io::Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/architecture/units/io_unit.rs:6:54 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn get_output_handler(device_id: u8) -> &'static OutputHandler { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 6 - pub fn get_output_handler(device_id: u8) -> &'static OutputHandler { [INFO] [stdout] 6 + pub fn get_output_handler(device_id: u8) -> &'static dyn OutputHandler { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/architecture/units/io_unit.rs:10:53 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn get_input_handler(device_id: u8) -> &'static InputHandler { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 10 - pub fn get_input_handler(device_id: u8) -> &'static InputHandler { [INFO] [stdout] 10 + pub fn get_input_handler(device_id: u8) -> &'static dyn InputHandler { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `device_id` [INFO] [stdout] --> src/architecture/units/io_unit.rs:6:27 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn get_output_handler(device_id: u8) -> &'static OutputHandler { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_device_id` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `device_id` [INFO] [stdout] --> src/architecture/units/io_unit.rs:10:26 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn get_input_handler(device_id: u8) -> &'static InputHandler { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_device_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `state` [INFO] [stdout] --> src/architecture/devices/output_handler.rs:11:22 [INFO] [stdout] | [INFO] [stdout] 11 | fn handle(&self, state: &mut State, signal: IoSignal){ [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_state` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `state` [INFO] [stdout] --> src/architecture/devices/input_handler.rs:11:27 [INFO] [stdout] | [INFO] [stdout] 11 | fn next_signal(&self, state: &mut State) -> IoSignal { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_state` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cpu` [INFO] [stdout] --> src/main.rs:12:13 [INFO] [stdout] | [INFO] [stdout] 12 | let mut cpu = CpuContext::load_program(program, 65536); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_cpu` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | let mut cpu = CpuContext::load_program(program, 65536); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/disassembler/parser.rs:5:61 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn parse(filename: &str, mem_size: usize) -> io::Result<(Vec)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 5 - pub fn parse(filename: &str, mem_size: usize) -> io::Result<(Vec)> { [INFO] [stdout] 5 + pub fn parse(filename: &str, mem_size: usize) -> io::Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/architecture/units/io_unit.rs:6:54 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn get_output_handler(device_id: u8) -> &'static OutputHandler { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 6 - pub fn get_output_handler(device_id: u8) -> &'static OutputHandler { [INFO] [stdout] 6 + pub fn get_output_handler(device_id: u8) -> &'static dyn OutputHandler { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/architecture/units/io_unit.rs:10:53 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn get_input_handler(device_id: u8) -> &'static InputHandler { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 10 - pub fn get_input_handler(device_id: u8) -> &'static InputHandler { [INFO] [stdout] 10 + pub fn get_input_handler(device_id: u8) -> &'static dyn InputHandler { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `device_id` [INFO] [stdout] --> src/architecture/units/io_unit.rs:6:27 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn get_output_handler(device_id: u8) -> &'static OutputHandler { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_device_id` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `device_id` [INFO] [stdout] --> src/architecture/units/io_unit.rs:10:26 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn get_input_handler(device_id: u8) -> &'static InputHandler { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_device_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `state` [INFO] [stdout] --> src/architecture/devices/output_handler.rs:11:22 [INFO] [stdout] | [INFO] [stdout] 11 | fn handle(&self, state: &mut State, signal: IoSignal){ [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_state` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `state` [INFO] [stdout] --> src/architecture/devices/input_handler.rs:11:27 [INFO] [stdout] | [INFO] [stdout] 11 | fn next_signal(&self, state: &mut State) -> IoSignal { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_state` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/architecture/instructions/data_transfer.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | let mut memory: Vec = vec![0;100]; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/architecture/instructions/data_transfer.rs:121:13 [INFO] [stdout] | [INFO] [stdout] 121 | let mut memory: Vec = vec![0;100]; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/architecture/instructions/data_transfer.rs:137:13 [INFO] [stdout] | [INFO] [stdout] 137 | let mut memory: Vec = vec![0;100]; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/architecture/instructions/direct_addressing.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | let mut memory: Vec = vec![0;100]; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/architecture/instructions/direct_addressing.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 86 | let mut memory: Vec = vec![0;100]; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/architecture/instructions/immediate.rs:207:13 [INFO] [stdout] | [INFO] [stdout] 207 | let mut memory: Vec = vec![0;100]; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 2.28s [INFO] running `Command { std: "docker" "inspect" "75d34f0c1cedcfa42654a2f35404e47037cdc24d1c10fc2a20cfecfefc3ad483", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "75d34f0c1cedcfa42654a2f35404e47037cdc24d1c10fc2a20cfecfefc3ad483", kill_on_drop: false }` [INFO] [stdout] 75d34f0c1cedcfa42654a2f35404e47037cdc24d1c10fc2a20cfecfefc3ad483 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:0cd99ca24d8e8c98e67c542213511d985b8778b5bdcbb160e038429496686047" "/opt/rustwide/cargo-home/bin/cargo" "+1.59.0" "test" "--frozen", kill_on_drop: false }` [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] [stdout] 3c16a426960d72686d8aeb884a2c03f050344d05faf693cfeab08b4795d0e44e [INFO] running `Command { std: "docker" "start" "-a" "3c16a426960d72686d8aeb884a2c03f050344d05faf693cfeab08b4795d0e44e", kill_on_drop: false }` [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/disassembler/parser.rs:5:61 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn parse(filename: &str, mem_size: usize) -> io::Result<(Vec)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 5 - pub fn parse(filename: &str, mem_size: usize) -> io::Result<(Vec)> { [INFO] [stderr] 5 + pub fn parse(filename: &str, mem_size: usize) -> io::Result> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/architecture/units/io_unit.rs:6:54 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn get_output_handler(device_id: u8) -> &'static OutputHandler { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] help: use `dyn` [INFO] [stderr] | [INFO] [stderr] 6 - pub fn get_output_handler(device_id: u8) -> &'static OutputHandler { [INFO] [stderr] 6 + pub fn get_output_handler(device_id: u8) -> &'static dyn OutputHandler { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/architecture/units/io_unit.rs:10:53 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn get_input_handler(device_id: u8) -> &'static InputHandler { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] help: use `dyn` [INFO] [stderr] | [INFO] [stderr] 10 - pub fn get_input_handler(device_id: u8) -> &'static InputHandler { [INFO] [stderr] 10 + pub fn get_input_handler(device_id: u8) -> &'static dyn InputHandler { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `device_id` [INFO] [stderr] --> src/architecture/units/io_unit.rs:6:27 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn get_output_handler(device_id: u8) -> &'static OutputHandler { [INFO] [stderr] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_device_id` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `device_id` [INFO] [stderr] --> src/architecture/units/io_unit.rs:10:26 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn get_input_handler(device_id: u8) -> &'static InputHandler { [INFO] [stderr] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_device_id` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/architecture/devices/output_handler.rs:11:22 [INFO] [stderr] | [INFO] [stderr] 11 | fn handle(&self, state: &mut State, signal: IoSignal){ [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_state` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/architecture/devices/input_handler.rs:11:27 [INFO] [stderr] | [INFO] [stderr] 11 | fn next_signal(&self, state: &mut State) -> IoSignal { [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_state` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/architecture/instructions/data_transfer.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | let mut memory: Vec = vec![0;100]; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/architecture/instructions/data_transfer.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | let mut memory: Vec = vec![0;100]; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/architecture/instructions/data_transfer.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | let mut memory: Vec = vec![0;100]; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/architecture/instructions/direct_addressing.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | let mut memory: Vec = vec![0;100]; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/architecture/instructions/direct_addressing.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | let mut memory: Vec = vec![0;100]; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/architecture/instructions/immediate.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | let mut memory: Vec = vec![0;100]; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: `intel_8080_emulator` (lib) generated 7 warnings [INFO] [stderr] warning: `intel_8080_emulator` (lib test) generated 13 warnings (7 duplicates) [INFO] [stderr] warning: unused variable: `cpu` [INFO] [stderr] --> src/main.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | let mut cpu = CpuContext::load_program(program, 65536); [INFO] [stderr] | ^^^ help: if this is intentional, prefix it with an underscore: `_cpu` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | let mut cpu = CpuContext::load_program(program, 65536); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: `intel_8080_emulator` (bin "intel_8080_emulator" test) generated 2 warnings [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 0.02s [INFO] [stderr] Running unittests (/opt/rustwide/target/debug/deps/intel_8080_emulator-1f361c0034215ff9) [INFO] [stdout] [INFO] [stdout] running 57 tests [INFO] [stdout] test architecture::instructions::carry_bit::tests::test_complement ... ok [INFO] [stdout] test architecture::instructions::carry_bit::tests::test_set ... ok [INFO] [stdout] test architecture::instructions::data_transfer::tests::test_load_acc_from_bc ... ok [INFO] [stdout] test architecture::instructions::data_transfer::tests::test_load_acc_from_de ... ok [INFO] [stdout] test architecture::instructions::data_transfer::tests::test_move_mem_to_reg ... ok [INFO] [stdout] test architecture::instructions::data_transfer::tests::test_store_acc_to_bc ... ok [INFO] [stdout] test architecture::instructions::data_transfer::tests::test_store_acc_to_de ... ok [INFO] [stdout] test architecture::instructions::direct_addressing::tests::test_load_accumulator ... ok [INFO] [stdout] test architecture::instructions::direct_addressing::tests::test_load_hl ... ok [INFO] [stdout] test architecture::instructions::direct_addressing::tests::test_store_accumulator ... ok [INFO] [stdout] test architecture::instructions::direct_addressing::tests::test_store_hl ... ok [INFO] [stdout] test architecture::instructions::hlt::tests::test_halt ... ok [INFO] [stdout] test architecture::instructions::immediate::tests::test_add ... ok [INFO] [stdout] test architecture::instructions::immediate::tests::test_add_carry_not_set ... ok [INFO] [stdout] test architecture::instructions::immediate::tests::test_add_carry_set ... ok [INFO] [stdout] test architecture::instructions::immediate::tests::test_load_reg_pair ... ok [INFO] [stdout] test architecture::instructions::immediate::tests::test_load_sp ... ok [INFO] [stdout] test architecture::instructions::immediate::tests::test_move_data_mem ... ok [INFO] [stdout] test architecture::instructions::interrupt::tests::test_disable ... ok [INFO] [stdout] test architecture::instructions::immediate::tests::test_move_data_reg ... ok [INFO] [stdout] test architecture::instructions::interrupt::tests::test_enable ... ok [INFO] [stdout] test architecture::instructions::io::tests::test_input ... ok [INFO] [stdout] test architecture::instructions::io::tests::test_output ... ok [INFO] [stdout] test architecture::instructions::rotate_accumulator::tests::test_rotate_left_w_carry ... ok [INFO] [stdout] test architecture::instructions::rotate_accumulator::tests::test_rotate_right_through_carry ... ok [INFO] [stdout] test architecture::model::condition_codes::tests::test_all_conditions_false ... ok [INFO] [stdout] test architecture::model::condition_codes::tests::test_all_conditions_true ... ok [INFO] [stdout] test architecture::model::condition_codes::tests::test_some_conditions_true ... ok [INFO] [stdout] test architecture::model::condition_codes::tests::test_update_all_conditions_false ... ok [INFO] [stdout] test architecture::model::condition_codes::tests::test_update_all_conditions_true ... ok [INFO] [stdout] test architecture::units::arithmetic_logic_unit::tests::test_add_carry_max ... ok [INFO] [stdout] test architecture::instructions::data_transfer::tests::test_move_reg_to_mem ... ok [INFO] [stdout] test architecture::instructions::data_transfer::tests::test_move_reg_to_reg ... ok [INFO] [stdout] test architecture::units::arithmetic_logic_unit::tests::test_ones_complement ... ok [INFO] [stdout] test architecture::instructions::rotate_accumulator::tests::test_rotate_right_w_carry ... ok [INFO] [stdout] test architecture::instructions::carry_bit::tests::test_complement_while_already_set ... ok [INFO] [stdout] test architecture::units::arithmetic_logic_unit::tests::test_negatives ... ok [INFO] [stdout] test architecture::units::arithmetic_logic_unit::tests::test_sub_from_neg ... ok [INFO] [stdout] test architecture::units::arithmetic_logic_unit::tests::test_twos_complement ... ok [INFO] [stdout] test architecture::units::arithmetic_logic_unit::tests::test_with_example_in_manual ... ok [INFO] [stdout] test architecture::units::stack::tests::test_pop ... ok [INFO] [stdout] test architecture::units::stack::tests::test_push ... ok [INFO] [stdout] test architecture::instructions::carry_bit::tests::test_set_while_already_set ... ok [INFO] [stdout] test architecture::instructions::rotate_accumulator::tests::test_rotate_left_through_carry ... ok [INFO] [stdout] test architecture::units::arithmetic_logic_unit::tests::test_sub_neg ... ok [INFO] [stdout] test architecture::units::arithmetic_logic_unit::tests::test_sub_both_positive ... ok [INFO] [stdout] test architecture::instructions::rotate_accumulator::tests::test_rotate_right ... ok [INFO] [stdout] test architecture::units::arithmetic_logic_unit::tests::test_add_carry_min ... ok [INFO] [stdout] test architecture::units::arithmetic_logic_unit::tests::test_add_zero ... ok [INFO] [stdout] test architecture::units::arithmetic_logic_unit::tests::test_sub_with_example_in_manual ... ok [INFO] [stdout] test architecture::units::arithmetic_logic_unit::tests::test_compare_with_example_in_manual ... ok [INFO] [stdout] test architecture::units::arithmetic_logic_unit::tests::test_add_non_zero ... ok [INFO] [stdout] test architecture::units::arithmetic_logic_unit::tests::test_parity_even ... ok [INFO] [stdout] test architecture::model::condition_codes::tests::test_update_some_conditions_true ... ok [INFO] [stdout] test architecture::instructions::rotate_accumulator::tests::test_rotate_left ... ok [INFO] [stdout] test architecture::instructions::nop::tests::test_nop ... ok [INFO] [stderr] Running unittests (/opt/rustwide/target/debug/deps/intel_8080_emulator-9d89ac5e883b17c9) [INFO] [stdout] test architecture::units::arithmetic_logic_unit::tests::test_parity_odd ... ok [INFO] [stdout] [INFO] [stdout] test result: ok. 57 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.02s [INFO] [stdout] [INFO] [stderr] Doc-tests intel_8080_emulator [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> /opt/rustwide/workdir/./src/disassembler/parser.rs:5:61 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn parse(filename: &str, mem_size: usize) -> io::Result<(Vec)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 5 - pub fn parse(filename: &str, mem_size: usize) -> io::Result<(Vec)> { [INFO] [stderr] 5 + pub fn parse(filename: &str, mem_size: usize) -> io::Result> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: 1 warning emitted [INFO] [stderr] [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "3c16a426960d72686d8aeb884a2c03f050344d05faf693cfeab08b4795d0e44e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3c16a426960d72686d8aeb884a2c03f050344d05faf693cfeab08b4795d0e44e", kill_on_drop: false }` [INFO] [stdout] 3c16a426960d72686d8aeb884a2c03f050344d05faf693cfeab08b4795d0e44e