[INFO] cloning repository https://github.com/elauffenburger/nes
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/elauffenburger/nes" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Felauffenburger%2Fnes", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Felauffenburger%2Fnes'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 292d8d2944794d21d9630c764e23796d718624af
[INFO] testing elauffenburger/nes against beta-2021-08-01 for beta-1.55-1
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Felauffenburger%2Fnes" "/workspace/builds/worker-9/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-9/source'...
[INFO] [stderr] done.
[INFO] validating manifest of git repo https://github.com/elauffenburger/nes on toolchain beta-2021-08-01
[INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+beta-2021-08-01" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] started tweaking git repo https://github.com/elauffenburger/nes
[INFO] finished tweaking git repo https://github.com/elauffenburger/nes
[INFO] tweaked toml for git repo https://github.com/elauffenburger/nes written to /workspace/builds/worker-9/source/Cargo.toml
[INFO] crate git repo https://github.com/elauffenburger/nes already has a lockfile, it will not be regenerated
[INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+beta-2021-08-01" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded wayland-scanner v0.21.12
[INFO] [stderr]   Downloaded downcast-rs v1.0.4
[INFO] [stderr]   Downloaded piston v0.42.0
[INFO] [stderr]   Downloaded piston2d-graphics v0.30.0
[INFO] [stderr]   Downloaded libflate v0.1.19
[INFO] [stderr]   Downloaded hyper v0.12.24
[INFO] [stderr]   Downloaded image v0.21.1
[INFO] [stderr]   Downloaded wayland-commons v0.21.12
[INFO] [stderr]   Downloaded wayland-protocols v0.21.12
[INFO] [stderr]   Downloaded wayland-sys v0.21.12
[INFO] [stderr]   Downloaded wayland-client v0.21.12
[INFO] [stderr]   Downloaded serde v1.0.88
[INFO] [stderr]   Downloaded pistoncore-window v0.37.0
[INFO] [stderr]   Downloaded pistoncore-glutin_window v0.54.0
[INFO] [stderr]   Downloaded pistoncore-input v0.24.0
[INFO] [stderr]   Downloaded pistoncore-event_loop v0.42.0
[INFO] [stderr]   Downloaded reqwest v0.9.9
[INFO] [stderr]   Downloaded piston2d-opengl_graphics v0.59.0
[INFO] [stderr]   Downloaded gleam v0.6.17
[INFO] [stderr]   Downloaded rusttype v0.7.6
[INFO] [stderr]   Downloaded smithay-client-toolkit v0.4.5
[INFO] [stderr]   Downloaded winit v0.18.1
[INFO] [stderr]   Downloaded encoding_rs v0.8.16
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-9/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-9/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2021-08-01" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 68f9eb1113a2dd48dbc0dc87b9baba9d59920b4fa5aed3477d5e0b3cb367bef1
[INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap.
[INFO] running `Command { std: "docker" "start" "-a" "68f9eb1113a2dd48dbc0dc87b9baba9d59920b4fa5aed3477d5e0b3cb367bef1", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "68f9eb1113a2dd48dbc0dc87b9baba9d59920b4fa5aed3477d5e0b3cb367bef1", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "68f9eb1113a2dd48dbc0dc87b9baba9d59920b4fa5aed3477d5e0b3cb367bef1", kill_on_drop: false }`
[INFO] [stdout] 68f9eb1113a2dd48dbc0dc87b9baba9d59920b4fa5aed3477d5e0b3cb367bef1
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-9/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-9/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2021-08-01" "build" "--frozen" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 18e95633609ac0dc4ff41cdb94d96fa27487e2c075786e3931e2e88160fd6438
[INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap.
[INFO] running `Command { std: "docker" "start" "-a" "18e95633609ac0dc4ff41cdb94d96fa27487e2c075786e3931e2e88160fd6438", kill_on_drop: false }`
[INFO] [stderr]    Compiling cc v1.0.29
[INFO] [stderr]    Compiling serde v1.0.88
[INFO] [stderr]    Compiling syn v0.15.33
[INFO] [stderr]    Compiling either v1.5.1
[INFO] [stderr]    Compiling encoding_rs v0.8.16
[INFO] [stderr]    Compiling crossbeam-utils v0.6.5
[INFO] [stderr]    Compiling piston-viewport v0.5.0
[INFO] [stderr]    Compiling num_cpus v1.10.0
[INFO] [stderr]    Compiling nix v0.13.0
[INFO] [stderr]    Compiling memmap v0.7.0
[INFO] [stderr]    Compiling shared_library v0.1.9
[INFO] [stderr]    Compiling approx v0.3.2
[INFO] [stderr]    Compiling crossbeam-epoch v0.3.1
[INFO] [stderr]    Compiling gl_generator v0.10.0
[INFO] [stderr]    Compiling x11-dl v2.18.3
[INFO] [stderr]    Compiling clap v2.33.0
[INFO] [stderr]    Compiling wayland-scanner v0.21.12
[INFO] [stderr]    Compiling itertools v0.8.0
[INFO] [stderr]    Compiling osmesa-sys v0.1.2
[INFO] [stderr]    Compiling futures-cpupool v0.1.8
[INFO] [stderr]    Compiling rusttype v0.7.6
[INFO] [stderr]    Compiling parking_lot_core v0.4.0
[INFO] [stderr]    Compiling phf_generator v0.7.24
[INFO] [stderr]    Compiling uuid v0.7.2
[INFO] [stderr]    Compiling crossbeam-deque v0.2.0
[INFO] [stderr]    Compiling tokio-executor v0.1.6
[INFO] [stderr]    Compiling crossbeam-epoch v0.7.1
[INFO] [stderr]    Compiling crossbeam-channel v0.3.8
[INFO] [stderr]    Compiling parking_lot v0.7.1
[INFO] [stderr]    Compiling phf_codegen v0.7.24
[INFO] [stderr]    Compiling rayon-core v1.4.1
[INFO] [stderr]    Compiling andrew v0.2.1
[INFO] [stderr]    Compiling piston2d-graphics v0.30.0
[INFO] [stderr]    Compiling tokio-current-thread v0.1.4
[INFO] [stderr]    Compiling tokio-timer v0.2.10
[INFO] [stderr]    Compiling crossbeam-deque v0.6.3
[INFO] [stderr]    Compiling mime_guess v2.0.0-alpha.6
[INFO] [stderr]    Compiling tokio-reactor v0.1.8
[INFO] [stderr]    Compiling rayon v1.0.3
[INFO] [stderr]    Compiling gl v0.11.0
[INFO] [stderr]    Compiling glutin v0.19.0
[INFO] [stderr]    Compiling openssl-sys v0.9.40
[INFO] [stderr]    Compiling libloading v0.5.0
[INFO] [stderr]    Compiling crossbeam v0.6.0
[INFO] [stderr]    Compiling tokio-tcp v0.1.3
[INFO] [stderr]    Compiling tokio-threadpool v0.1.11
[INFO] [stderr]    Compiling openssl v0.10.16
[INFO] [stderr]    Compiling native-tls v0.2.2
[INFO] [stderr]    Compiling wayland-client v0.21.12
[INFO] [stderr]    Compiling wayland-protocols v0.21.12
[INFO] [stderr]    Compiling dlib v0.4.1
[INFO] [stderr]    Compiling tokio v0.1.15
[INFO] [stderr]    Compiling wayland-sys v0.21.12
[INFO] [stderr]    Compiling jpeg-decoder v0.1.15
[INFO] [stderr]    Compiling wayland-commons v0.21.12
[INFO] [stderr]    Compiling hyper v0.12.24
[INFO] [stderr]    Compiling serde_derive v1.0.90
[INFO] [stderr]    Compiling num-derive v0.2.5
[INFO] [stderr]    Compiling serde_urlencoded v0.5.4
[INFO] [stderr]    Compiling serde_json v1.0.38
[INFO] [stderr]    Compiling hyper-tls v0.3.1
[INFO] [stderr]    Compiling reqwest v0.9.9
[INFO] [stderr]    Compiling tiff v0.2.2
[INFO] [stderr]    Compiling image v0.21.1
[INFO] [stderr]    Compiling piston2d-opengl_graphics v0.59.0
[INFO] [stderr]    Compiling libnes v0.1.0 (/opt/rustwide/workdir/libnes)
[INFO] [stdout] warning: unused import: `self`
[INFO] [stdout]  --> libnes/build.rs:3:33
[INFO] [stdout]   |
[INFO] [stdout] 3 | use std::fs::{File, DirBuilder, self};
[INFO] [stdout]   |                                 ^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::io::Write`
[INFO] [stdout]  --> libnes/build.rs:4:5
[INFO] [stdout]   |
[INFO] [stdout] 4 | use std::io::Write;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `klaus_functional_tests_url` should have an upper case name
[INFO] [stdout]  --> libnes/build.rs:7:7
[INFO] [stdout]   |
[INFO] [stdout] 7 | const klaus_functional_tests_url: &'static str = "https://github.com/Klaus2m5/6502_65C02_functional_tests/blob/master/bin_files/6502_func...
[INFO] [stdout]   |       ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `KLAUS_FUNCTIONAL_TESTS_URL`
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(non_upper_case_globals)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `nestest_url` should have an upper case name
[INFO] [stdout]  --> libnes/build.rs:8:7
[INFO] [stdout]   |
[INFO] [stdout] 8 | const nestest_url: &'static str = "http://nickmass.com/images/nestest.nes";
[INFO] [stdout]   |       ^^^^^^^^^^^ help: convert the identifier to upper case: `NESTEST_URL`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]    Compiling pistoncore-input v0.24.0
[INFO] [stderr]    Compiling pistoncore-window v0.37.0
[INFO] [stderr]    Compiling pistoncore-event_loop v0.42.0
[INFO] [stderr]    Compiling piston v0.42.0
[INFO] [stdout] warning: 4 warnings emitted
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused `#[macro_use]` import
[INFO] [stdout]  --> libnes/src/lib.rs:3:1
[INFO] [stdout]   |
[INFO] [stdout] 3 | #[macro_use]
[INFO] [stdout]   | ^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: type `iNESLoader` should have an upper camel case name
[INFO] [stdout]   --> libnes/src/cart/ines.rs:16:12
[INFO] [stdout]    |
[INFO] [stdout] 16 | pub struct iNESLoader {}
[INFO] [stdout]    |            ^^^^^^^^^^ help: convert the identifier to upper camel case: `INesloader`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(non_camel_case_types)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: type `iNESHeader` should have an upper camel case name
[INFO] [stdout]    --> libnes/src/cart/ines.rs:127:8
[INFO] [stdout]     |
[INFO] [stdout] 127 | struct iNESHeader {
[INFO] [stdout]     |        ^^^^^^^^^^ help: convert the identifier to upper camel case: `INesheader`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cart/mappers/nrom.rs:16:35
[INFO] [stdout]    |
[INFO] [stdout] 16 |     fn map(&self, nes: Rc<RefCell<Nes>>, options: MapperOptions) -> Result<(), String> {
[INFO] [stdout]    |                                   ^^^ help: use `dyn`: `dyn Nes`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(bare_trait_objects)]` on by default
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cart/mappers/mod.rs:11:35
[INFO] [stdout]    |
[INFO] [stdout] 11 |     fn map(&self, nes: Rc<RefCell<Nes>>, options: MapperOptions) -> Result<(), String>;
[INFO] [stdout]    |                                   ^^^ help: use `dyn`: `dyn Nes`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant `iNes` should have an upper camel case name
[INFO] [stdout]   --> libnes/src/cart/mod.rs:28:5
[INFO] [stdout]    |
[INFO] [stdout] 28 |     iNes,
[INFO] [stdout]    |     ^^^^ help: convert the identifier to upper camel case (notice the capitalization): `INes`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `Observer`
[INFO] [stdout]  --> libnes/src/cpu/cpu.rs:9:29
[INFO] [stdout]   |
[INFO] [stdout] 9 | use crate::ev::{Observable, Observer};
[INFO] [stdout]   |                             ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/cpu.rs:30:37
[INFO] [stdout]    |
[INFO] [stdout] 30 |     fn load_mem(&mut self, mem: Box<CpuMemoryMap>);
[INFO] [stdout]    |                                     ^^^^^^^^^^^^ help: use `dyn`: `dyn CpuMemoryMap`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/cpu.rs:31:46
[INFO] [stdout]    |
[INFO] [stdout] 31 |     fn subscribe_mem(&mut self, handler: Box<FnMut(&CpuMemoryAccessEvent)>);
[INFO] [stdout]    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&CpuMemoryAccessEvent)`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/cpu.rs:50:16
[INFO] [stdout]    |
[INFO] [stdout] 50 | impl Debug for Cpu {
[INFO] [stdout]    |                ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/cpu.rs:63:21
[INFO] [stdout]    |
[INFO] [stdout] 63 |     pub memory: Box<CpuMemoryMap>,
[INFO] [stdout]    |                     ^^^^^^^^^^^^ help: use `dyn`: `dyn CpuMemoryMap`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/cpu.rs:72:19
[INFO] [stdout]    |
[INFO] [stdout] 72 |         (self as &Cpu).fmt(f)
[INFO] [stdout]    |                   ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]    --> libnes/src/cpu/cpu.rs:204:52
[INFO] [stdout]     |
[INFO] [stdout] 204 |             println!("cpu pre: {:?}", self as &mut Cpu);
[INFO] [stdout]     |                                                    ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]     |
[INFO] [stdout]     = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]     = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]    --> libnes/src/cpu/cpu.rs:216:53
[INFO] [stdout]     |
[INFO] [stdout] 216 |             println!("cpu post: {:?}", self as &mut Cpu);
[INFO] [stdout]     |                                                     ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]     |
[INFO] [stdout]     = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]     = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]    --> libnes/src/cpu/cpu.rs:224:37
[INFO] [stdout]     |
[INFO] [stdout] 224 |     fn load_mem(&mut self, mem: Box<CpuMemoryMap>) {
[INFO] [stdout]     |                                     ^^^^^^^^^^^^ help: use `dyn`: `dyn CpuMemoryMap`
[INFO] [stdout]     |
[INFO] [stdout]     = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]     = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]    --> libnes/src/cpu/cpu.rs:228:46
[INFO] [stdout]     |
[INFO] [stdout] 228 |     fn subscribe_mem(&mut self, handler: Box<FnMut(&CpuMemoryAccessEvent)>) {
[INFO] [stdout]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&CpuMemoryAccessEvent)`
[INFO] [stdout]     |
[INFO] [stdout]     = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]     = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/instr/instructions/helpers.rs:19:42
[INFO] [stdout]    |
[INFO] [stdout] 19 |     pub fn resolve_value(self, cpu: &mut Cpu) -> i8 {
[INFO] [stdout]    |                                          ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/instr/instructions/helpers.rs:34:30
[INFO] [stdout]    |
[INFO] [stdout] 34 | pub fn get_operand(cpu: &mut Cpu, addr_mode: &AddressingMode) -> GetOperandResult {
[INFO] [stdout]    |                              ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/instr/instructions/mod.rs:16:18
[INFO] [stdout]    |
[INFO] [stdout] 16 |     do_run: &'op Fn(&'cpu mut T, AddressingMode),
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Fn(&'cpu mut T, AddressingMode)`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/instr/instructions/mod.rs:37:22
[INFO] [stdout]    |
[INFO] [stdout] 37 |         do_run: &'op Fn(&'cpu mut T, AddressingMode),
[INFO] [stdout]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Fn(&'cpu mut T, AddressingMode)`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/cpu/mem/address.rs:17:19
[INFO] [stdout]    |
[INFO] [stdout] 17 |             0x0000...0x07ff => Address::Address(addr),
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/cpu/mem/address.rs:18:19
[INFO] [stdout]    |
[INFO] [stdout] 18 |             0x0800...0x1fff => Address::Mirror {
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/cpu/mem/address.rs:23:19
[INFO] [stdout]    |
[INFO] [stdout] 23 |             0x2000...0x2007 => Address::Address(addr),
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/cpu/mem/address.rs:24:19
[INFO] [stdout]    |
[INFO] [stdout] 24 |             0x2008...0x3fff => Address::Mirror {
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/cpu/mem/address.rs:29:19
[INFO] [stdout]    |
[INFO] [stdout] 29 |             0x4000...0xffff => Address::Address(addr),
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `Observer`
[INFO] [stdout]  --> libnes/src/cpu/mem/mod.rs:3:29
[INFO] [stdout]   |
[INFO] [stdout] 3 | use crate::ev::{Observable, Observer, Subject};
[INFO] [stdout]   |                             ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/mem/mod.rs:10:42
[INFO] [stdout]    |
[INFO] [stdout] 10 |     fn subscribe(&mut self, handler: Box<FnMut(&CpuMemoryAccessEvent)>);
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&CpuMemoryAccessEvent)`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/mem/mod.rs:55:42
[INFO] [stdout]    |
[INFO] [stdout] 55 |     fn subscribe(&mut self, handler: Box<FnMut(&CpuMemoryAccessEvent)>) {
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&CpuMemoryAccessEvent)`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/nes/mod.rs:13:41
[INFO] [stdout]    |
[INFO] [stdout] 13 |     fn get_cpu(&mut self) -> Rc<RefCell<Cpu>>;
[INFO] [stdout]    |                                         ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/nes/mod.rs:14:41
[INFO] [stdout]    |
[INFO] [stdout] 14 |     fn get_ppu(&mut self) -> Rc<RefCell<Ppu>>;
[INFO] [stdout]    |                                         ^^^ help: use `dyn`: `dyn Ppu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/nes/mod.rs:18:21
[INFO] [stdout]    |
[INFO] [stdout] 18 |     cpu: Rc<RefCell<Cpu>>,
[INFO] [stdout]    |                     ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/nes/mod.rs:19:21
[INFO] [stdout]    |
[INFO] [stdout] 19 |     ppu: Rc<RefCell<Ppu>>,
[INFO] [stdout]    |                     ^^^ help: use `dyn`: `dyn Ppu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/nes/mod.rs:38:41
[INFO] [stdout]    |
[INFO] [stdout] 38 |     fn get_cpu(&mut self) -> Rc<RefCell<Cpu>> {
[INFO] [stdout]    |                                         ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/nes/mod.rs:42:41
[INFO] [stdout]    |
[INFO] [stdout] 42 |     fn get_ppu(&mut self) -> Rc<RefCell<Ppu>> {
[INFO] [stdout]    |                                         ^^^ help: use `dyn`: `dyn Ppu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/nes/mod.rs:48:32
[INFO] [stdout]    |
[INFO] [stdout] 48 |     pub fn new(cpu: Rc<RefCell<Cpu>>, ppu: Rc<RefCell<Ppu>>) -> Self {
[INFO] [stdout]    |                                ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/nes/mod.rs:48:55
[INFO] [stdout]    |
[INFO] [stdout] 48 |     pub fn new(cpu: Rc<RefCell<Cpu>>, ppu: Rc<RefCell<Ppu>>) -> Self {
[INFO] [stdout]    |                                                       ^^^ help: use `dyn`: `dyn Ppu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/ppu/attr_table.rs:73:14
[INFO] [stdout]    |
[INFO] [stdout] 73 |         i @ 0...3 => ATTRIBUTE_TABLE_ADDRESSES[i as usize],
[INFO] [stdout]    |              ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/ppu/mem/mod.rs:18:19
[INFO] [stdout]    |
[INFO] [stdout] 18 |             0x0000...0x2fff => Address::Address(addr),
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/ppu/mem/mod.rs:19:19
[INFO] [stdout]    |
[INFO] [stdout] 19 |             0x3000...0x3eff => Address::Mirror {
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/ppu/mem/mod.rs:24:19
[INFO] [stdout]    |
[INFO] [stdout] 24 |             0x3f00...0x3f1f => Address::Address(addr),
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/ppu/mem/mod.rs:25:19
[INFO] [stdout]    |
[INFO] [stdout] 25 |             0x3f20...0x3fff => Address::Mirror {
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/ppu/mem/mod.rs:30:19
[INFO] [stdout]    |
[INFO] [stdout] 30 |             0x4000...0x9fff => Address::Mirror {
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]    --> libnes/src/ppu/nametable.rs:105:14
[INFO] [stdout]     |
[INFO] [stdout] 105 |         i @ 0...3 => NAMETABLE_ADDRESSES[i as usize],
[INFO] [stdout]     |              ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]     |
[INFO] [stdout]     = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]     = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]    --> libnes/src/ppu/pattern_table.rs:103:22
[INFO] [stdout]     |
[INFO] [stdout] 103 |                     0...3 => color_val,
[INFO] [stdout]     |                      ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]     |
[INFO] [stdout]     = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]     = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/ppu/mod.rs:55:14
[INFO] [stdout]    |
[INFO] [stdout] 55 |     mem: Box<PpuMemoryMap>,
[INFO] [stdout]    |              ^^^^^^^^^^^^ help: use `dyn`: `dyn PpuMemoryMap`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]  --> libnes/src/ev/mod.rs:7:42
[INFO] [stdout]   |
[INFO] [stdout] 7 |     fn subscribe(&mut self, handler: Box<FnMut(&TEvent)>) -> Rc<RefCell<Subject<TEvent>>>;
[INFO] [stdout]   |                                          ^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&TEvent)`
[INFO] [stdout]   |
[INFO] [stdout]   = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]   = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/ev/mod.rs:14:20
[INFO] [stdout]    |
[INFO] [stdout] 14 |     cb: Option<Box<FnMut(&TEvent)>>,
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&TEvent)`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/ev/mod.rs:20:42
[INFO] [stdout]    |
[INFO] [stdout] 20 |     fn subscribe(&mut self, handler: Box<FnMut(&TEvent)>) -> Rc<RefCell<Subject<TEvent>>> {
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&TEvent)`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `crate::cpu::Cpu`
[INFO] [stdout]  --> libnes/src/cart/ines.rs:7:5
[INFO] [stdout]   |
[INFO] [stdout] 7 | use crate::cpu::Cpu;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `Observable`
[INFO] [stdout]  --> libnes/src/cpu/cpu.rs:9:17
[INFO] [stdout]   |
[INFO] [stdout] 9 | use crate::ev::{Observable, Observer};
[INFO] [stdout]   |                 ^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unreachable pattern
[INFO] [stdout]   --> libnes/src/cart/ines.rs:79:9
[INFO] [stdout]    |
[INFO] [stdout] 79 |         _ => return Err(format!("Unexpected non-ASCII sequence in header ID")),
[INFO] [stdout]    |         ^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unreachable_patterns)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unreachable pattern
[INFO] [stdout]   --> libnes/src/cpu/mem/address.rs:30:13
[INFO] [stdout]    |
[INFO] [stdout] 30 |             _ => panic!(format!(
[INFO] [stdout]    |             ^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `num_ram_banks`
[INFO] [stdout]    --> libnes/src/cart/ines.rs:102:9
[INFO] [stdout]     |
[INFO] [stdout] 102 |     let num_ram_banks = match take_elems(cart_data, 8, 1) {
[INFO] [stdout]     |         ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_num_ram_banks`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_variables)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `data`
[INFO] [stdout]    --> libnes/src/cart/ines.rs:110:9
[INFO] [stdout]     |
[INFO] [stdout] 110 |         data @ _ => {}
[INFO] [stdout]     |         ^^^^ help: if this is intentional, prefix it with an underscore: `_data`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `cpu`
[INFO] [stdout]    --> libnes/src/cpu/instr/instructions/instrs.rs:426:12
[INFO] [stdout]     |
[INFO] [stdout] 426 | pub fn nop(cpu: &mut impl Cpu, addr_mode: AddressingMode) {
[INFO] [stdout]     |            ^^^ help: if this is intentional, prefix it with an underscore: `_cpu`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `addr_mode`
[INFO] [stdout]    --> libnes/src/cpu/instr/instructions/instrs.rs:426:32
[INFO] [stdout]     |
[INFO] [stdout] 426 | pub fn nop(cpu: &mut impl Cpu, addr_mode: AddressingMode) {
[INFO] [stdout]     |                                ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `addr_mode`
[INFO] [stdout]    --> libnes/src/cpu/instr/instructions/instrs.rs:442:32
[INFO] [stdout]     |
[INFO] [stdout] 442 | pub fn pha(cpu: &mut impl Cpu, addr_mode: AddressingMode) {
[INFO] [stdout]     |                                ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `addr_mode`
[INFO] [stdout]    --> libnes/src/cpu/instr/instructions/instrs.rs:448:32
[INFO] [stdout]     |
[INFO] [stdout] 448 | pub fn php(cpu: &mut impl Cpu, addr_mode: AddressingMode) {
[INFO] [stdout]     |                                ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `addr_mode`
[INFO] [stdout]    --> libnes/src/cpu/instr/instructions/instrs.rs:454:32
[INFO] [stdout]     |
[INFO] [stdout] 454 | pub fn pla(cpu: &mut impl Cpu, addr_mode: AddressingMode) {
[INFO] [stdout]     |                                ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `addr_mode`
[INFO] [stdout]    --> libnes/src/cpu/instr/instructions/instrs.rs:465:32
[INFO] [stdout]     |
[INFO] [stdout] 465 | pub fn plp(cpu: &mut impl Cpu, addr_mode: AddressingMode) {
[INFO] [stdout]     |                                ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `addr_mode`
[INFO] [stdout]    --> libnes/src/cpu/instr/instructions/instrs.rs:543:32
[INFO] [stdout]     |
[INFO] [stdout] 543 | pub fn rts(cpu: &mut impl Cpu, addr_mode: AddressingMode) {
[INFO] [stdout]     |                                ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: panic message is not a string literal
[INFO] [stdout]    --> libnes/src/cpu/cpu.rs:124:28
[INFO] [stdout]     |
[INFO] [stdout] 124 |                     panic!(err);
[INFO] [stdout]     |                            ^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(non_fmt_panics)]` on by default
[INFO] [stdout]     = note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021
[INFO] [stdout]     = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
[INFO] [stdout] help: add a "{}" format string to Display the message
[INFO] [stdout]     |
[INFO] [stdout] 124 |                     panic!("{}", err);
[INFO] [stdout]     |                            ^^^^^
[INFO] [stdout] help: or use std::panic::panic_any instead
[INFO] [stdout]     |
[INFO] [stdout] 124 |                     std::panic::panic_any(err);
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: panic message is not a string literal
[INFO] [stdout]   --> libnes/src/cpu/mem/address.rs:30:25
[INFO] [stdout]    |
[INFO] [stdout] 30 |               _ => panic!(format!(
[INFO] [stdout]    |  _________________________^
[INFO] [stdout] 31 | |                 "Bad address '{:#06x}' while converting from u16 to Address",
[INFO] [stdout] 32 | |                 addr
[INFO] [stdout] 33 | |             )),
[INFO] [stdout]    | |_____________^
[INFO] [stdout]    |
[INFO] [stdout]    = note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021
[INFO] [stdout]    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
[INFO] [stdout]    = note: the panic!() macro supports formatting, so there's no need for the format!() macro here
[INFO] [stdout] help: remove the `format!(..)` macro call
[INFO] [stdout]    |
[INFO] [stdout] 30 |             _ => panic!(
[INFO] [stdout] 31 |                 "Bad address '{:#06x}' while converting from u16 to Address",
[INFO] [stdout] 32 |                 addr
[INFO] [stdout] 33 |             ),
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: panic message is not a string literal
[INFO] [stdout]   --> libnes/src/ppu/mem/mod.rs:35:25
[INFO] [stdout]    |
[INFO] [stdout] 35 |               _ => panic!(format!(
[INFO] [stdout]    |  _________________________^
[INFO] [stdout] 36 | |                 "Bad address '{:#06x}' while converting from u16 to Address",
[INFO] [stdout] 37 | |                 addr
[INFO] [stdout] 38 | |             )),
[INFO] [stdout]    | |_____________^
[INFO] [stdout]    |
[INFO] [stdout]    = note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021
[INFO] [stdout]    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
[INFO] [stdout]    = note: the panic!() macro supports formatting, so there's no need for the format!() macro here
[INFO] [stdout] help: remove the `format!(..)` macro call
[INFO] [stdout]    |
[INFO] [stdout] 35 |             _ => panic!(
[INFO] [stdout] 36 |                 "Bad address '{:#06x}' while converting from u16 to Address",
[INFO] [stdout] 37 |                 addr
[INFO] [stdout] 38 |             ),
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this method call resolves to `<&[T; N] as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to <[T; N] as IntoIterator>::into_iter in Rust 2021.
[INFO] [stdout]   --> libnes/src/ppu/nametable.rs:42:14
[INFO] [stdout]    |
[INFO] [stdout] 42 |             .into_iter()
[INFO] [stdout]    |              ^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(array_into_iter)]` on by default
[INFO] [stdout]    = warning: this changes meaning in Rust 2021
[INFO] [stdout]    = note: for more information, see issue #66145 <https://github.com/rust-lang/rust/issues/66145>
[INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity
[INFO] [stdout]    |
[INFO] [stdout] 42 |             .iter()
[INFO] [stdout]    |              ^^^^
[INFO] [stdout] help: or use `IntoIterator::into_iter(..)` instead of `.into_iter()` to explicitly iterate by value
[INFO] [stdout]    |
[INFO] [stdout] 40 |         let colors = IntoIterator::into_iter(pattern_table_tile
[INFO] [stdout] 41 |             .get_color_indices())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison is useless due to type limits
[INFO] [stdout]   --> libnes/src/bits/mod.rs:76:8
[INFO] [stdout]    |
[INFO] [stdout] 76 |     if bit_num < 0 || bit_num > 7 {
[INFO] [stdout]    |        ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_comparisons)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: 66 warnings emitted
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]    Compiling smithay-client-toolkit v0.4.5
[INFO] [stderr]    Compiling winit v0.18.1
[INFO] [stderr]    Compiling pistoncore-glutin_window v0.54.0
[INFO] [stderr]    Compiling nes v0.1.0 (/opt/rustwide/workdir/nes)
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]  --> nes/bin/debugger.rs:9:47
[INFO] [stdout]   |
[INFO] [stdout] 9 | pub fn start_debugger<'a>(cpu_ref: Rc<RefCell<Cpu>>)
[INFO] [stdout]   |                                               ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(bare_trait_objects)]` on by default
[INFO] [stdout]   = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]   = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> nes/bin/gui.rs:20:21
[INFO] [stdout]    |
[INFO] [stdout] 20 |     nes: Rc<RefCell<Nes>>,
[INFO] [stdout]    |                     ^^^ help: use `dyn`: `dyn Nes`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> nes/bin/gui.rs:93:34
[INFO] [stdout]    |
[INFO] [stdout] 93 | pub fn start_gui(nes: Rc<RefCell<Nes>>) {
[INFO] [stdout]    |                                  ^^^ help: use `dyn`: `dyn Nes`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `libnes::cpu::mem::CpuMemoryAccessEvent`
[INFO] [stdout]   --> nes/bin/mod.rs:12:5
[INFO] [stdout]    |
[INFO] [stdout] 12 | use libnes::cpu::mem::CpuMemoryAccessEvent;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]    --> nes/bin/mod.rs:102:25
[INFO] [stdout]     |
[INFO] [stdout] 102 |     let cpu: Rc<RefCell<Cpu>> = nes.clone().borrow_mut().get_cpu().clone();
[INFO] [stdout]     |                         ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]     |
[INFO] [stdout]     = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]     = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `Ppu`
[INFO] [stdout]   --> nes/bin/mod.rs:23:31
[INFO] [stdout]    |
[INFO] [stdout] 23 | use libnes::ppu::{DefaultPpu, Ppu};
[INFO] [stdout]    |                               ^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable `index` is assigned to, but never used
[INFO] [stdout]   --> nes/bin/gui.rs:48:21
[INFO] [stdout]    |
[INFO] [stdout] 48 |             let mut index = 0;
[INFO] [stdout]    |                     ^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_variables)]` on by default
[INFO] [stdout]    = note: consider using `_index` instead
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `nametable_draw_tile_index`
[INFO] [stdout]   --> nes/bin/gui.rs:35:13
[INFO] [stdout]    |
[INFO] [stdout] 35 |         let nametable_draw_tile_index = self.debug.nametable_tile_index;
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_nametable_draw_tile_index`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `args`
[INFO] [stdout]   --> nes/bin/gui.rs:87:26
[INFO] [stdout]    |
[INFO] [stdout] 87 |     fn update(&mut self, args: &UpdateArgs) {
[INFO] [stdout]    |                          ^^^^ help: if this is intentional, prefix it with an underscore: `_args`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]   --> nes/bin/gui.rs:33:13
[INFO] [stdout]    |
[INFO] [stdout] 33 |         let mut ppu = nes.get_ppu();
[INFO] [stdout]    |             ----^^^
[INFO] [stdout]    |             |
[INFO] [stdout]    |             help: remove this `mut`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_mut)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: panic message is not a string literal
[INFO] [stdout]   --> nes/bin/mod.rs:79:21
[INFO] [stdout]    |
[INFO] [stdout] 79 |         _ => panic!(format!("Unsupported rom format '{}'", rom_format_str)),
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(non_fmt_panics)]` on by default
[INFO] [stdout]    = note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021
[INFO] [stdout]    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
[INFO] [stdout]    = note: the panic!() macro supports formatting, so there's no need for the format!() macro here
[INFO] [stdout] help: remove the `format!(..)` macro call
[INFO] [stdout]    |
[INFO] [stdout] 79 |         _ => panic!("Unsupported rom format '{}'", rom_format_str),
[INFO] [stdout]    |                    --                                           --
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: 11 warnings emitted
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3m 27s
[INFO] running `Command { std: "docker" "inspect" "18e95633609ac0dc4ff41cdb94d96fa27487e2c075786e3931e2e88160fd6438", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "18e95633609ac0dc4ff41cdb94d96fa27487e2c075786e3931e2e88160fd6438", kill_on_drop: false }`
[INFO] [stdout] 18e95633609ac0dc4ff41cdb94d96fa27487e2c075786e3931e2e88160fd6438
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-9/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-9/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2021-08-01" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 35205f82451019eea8908f5134b52af45bf1a53fec3d24be8b6751cdaca7140b
[INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap.
[INFO] running `Command { std: "docker" "start" "-a" "35205f82451019eea8908f5134b52af45bf1a53fec3d24be8b6751cdaca7140b", kill_on_drop: false }`
[INFO] [stdout] warning: unused import: `self`
[INFO] [stdout]  --> libnes/build.rs:3:33
[INFO] [stdout]   |
[INFO] [stdout] 3 | use std::fs::{File, DirBuilder, self};
[INFO] [stdout]   |                                 ^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::io::Write`
[INFO] [stdout]  --> libnes/build.rs:4:5
[INFO] [stdout]   |
[INFO] [stdout] 4 | use std::io::Write;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `klaus_functional_tests_url` should have an upper case name
[INFO] [stdout]  --> libnes/build.rs:7:7
[INFO] [stdout]   |
[INFO] [stdout] 7 | const klaus_functional_tests_url: &'static str = "https://github.com/Klaus2m5/6502_65C02_functional_tests/blob/master/bin_files/6502_func...
[INFO] [stdout]   |       ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `KLAUS_FUNCTIONAL_TESTS_URL`
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(non_upper_case_globals)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `nestest_url` should have an upper case name
[INFO] [stdout]  --> libnes/build.rs:8:7
[INFO] [stdout]   |
[INFO] [stdout] 8 | const nestest_url: &'static str = "http://nickmass.com/images/nestest.nes";
[INFO] [stdout]   |       ^^^^^^^^^^^ help: convert the identifier to upper case: `NESTEST_URL`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: 4 warnings emitted
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused `#[macro_use]` import
[INFO] [stdout]  --> libnes/src/lib.rs:3:1
[INFO] [stdout]   |
[INFO] [stdout] 3 | #[macro_use]
[INFO] [stdout]   | ^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: type `iNESLoader` should have an upper camel case name
[INFO] [stdout]   --> libnes/src/cart/ines.rs:16:12
[INFO] [stdout]    |
[INFO] [stdout] 16 | pub struct iNESLoader {}
[INFO] [stdout]    |            ^^^^^^^^^^ help: convert the identifier to upper camel case: `INesloader`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(non_camel_case_types)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: type `iNESHeader` should have an upper camel case name
[INFO] [stdout]    --> libnes/src/cart/ines.rs:127:8
[INFO] [stdout]     |
[INFO] [stdout] 127 | struct iNESHeader {
[INFO] [stdout]     |        ^^^^^^^^^^ help: convert the identifier to upper camel case: `INesheader`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cart/mappers/nrom.rs:16:35
[INFO] [stdout]    |
[INFO] [stdout] 16 |     fn map(&self, nes: Rc<RefCell<Nes>>, options: MapperOptions) -> Result<(), String> {
[INFO] [stdout]    |                                   ^^^ help: use `dyn`: `dyn Nes`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(bare_trait_objects)]` on by default
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cart/mappers/mod.rs:11:35
[INFO] [stdout]    |
[INFO] [stdout] 11 |     fn map(&self, nes: Rc<RefCell<Nes>>, options: MapperOptions) -> Result<(), String>;
[INFO] [stdout]    |                                   ^^^ help: use `dyn`: `dyn Nes`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant `iNes` should have an upper camel case name
[INFO] [stdout]   --> libnes/src/cart/mod.rs:28:5
[INFO] [stdout]    |
[INFO] [stdout] 28 |     iNes,
[INFO] [stdout]    |     ^^^^ help: convert the identifier to upper camel case (notice the capitalization): `INes`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `Observer`
[INFO] [stdout]  --> libnes/src/cpu/cpu.rs:9:29
[INFO] [stdout]   |
[INFO] [stdout] 9 | use crate::ev::{Observable, Observer};
[INFO] [stdout]   |                             ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/cpu.rs:30:37
[INFO] [stdout]    |
[INFO] [stdout] 30 |     fn load_mem(&mut self, mem: Box<CpuMemoryMap>);
[INFO] [stdout]    |                                     ^^^^^^^^^^^^ help: use `dyn`: `dyn CpuMemoryMap`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/cpu.rs:31:46
[INFO] [stdout]    |
[INFO] [stdout] 31 |     fn subscribe_mem(&mut self, handler: Box<FnMut(&CpuMemoryAccessEvent)>);
[INFO] [stdout]    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&CpuMemoryAccessEvent)`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/cpu.rs:50:16
[INFO] [stdout]    |
[INFO] [stdout] 50 | impl Debug for Cpu {
[INFO] [stdout]    |                ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/cpu.rs:63:21
[INFO] [stdout]    |
[INFO] [stdout] 63 |     pub memory: Box<CpuMemoryMap>,
[INFO] [stdout]    |                     ^^^^^^^^^^^^ help: use `dyn`: `dyn CpuMemoryMap`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/cpu.rs:72:19
[INFO] [stdout]    |
[INFO] [stdout] 72 |         (self as &Cpu).fmt(f)
[INFO] [stdout]    |                   ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]    --> libnes/src/cpu/cpu.rs:204:52
[INFO] [stdout]     |
[INFO] [stdout] 204 |             println!("cpu pre: {:?}", self as &mut Cpu);
[INFO] [stdout]     |                                                    ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]     |
[INFO] [stdout]     = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]     = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]    --> libnes/src/cpu/cpu.rs:216:53
[INFO] [stdout]     |
[INFO] [stdout] 216 |             println!("cpu post: {:?}", self as &mut Cpu);
[INFO] [stdout]     |                                                     ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]     |
[INFO] [stdout]     = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]     = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]    --> libnes/src/cpu/cpu.rs:224:37
[INFO] [stdout]     |
[INFO] [stdout] 224 |     fn load_mem(&mut self, mem: Box<CpuMemoryMap>) {
[INFO] [stdout]     |                                     ^^^^^^^^^^^^ help: use `dyn`: `dyn CpuMemoryMap`
[INFO] [stdout]     |
[INFO] [stdout]     = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]     = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]    --> libnes/src/cpu/cpu.rs:228:46
[INFO] [stdout]     |
[INFO] [stdout] 228 |     fn subscribe_mem(&mut self, handler: Box<FnMut(&CpuMemoryAccessEvent)>) {
[INFO] [stdout]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&CpuMemoryAccessEvent)`
[INFO] [stdout]     |
[INFO] [stdout]     = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]     = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/instr/instructions/helpers.rs:19:42
[INFO] [stdout]    |
[INFO] [stdout] 19 |     pub fn resolve_value(self, cpu: &mut Cpu) -> i8 {
[INFO] [stdout]    |                                          ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/instr/instructions/helpers.rs:34:30
[INFO] [stdout]    |
[INFO] [stdout] 34 | pub fn get_operand(cpu: &mut Cpu, addr_mode: &AddressingMode) -> GetOperandResult {
[INFO] [stdout]    |                              ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/instr/instructions/mod.rs:16:18
[INFO] [stdout]    |
[INFO] [stdout] 16 |     do_run: &'op Fn(&'cpu mut T, AddressingMode),
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Fn(&'cpu mut T, AddressingMode)`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/instr/instructions/mod.rs:37:22
[INFO] [stdout]    |
[INFO] [stdout] 37 |         do_run: &'op Fn(&'cpu mut T, AddressingMode),
[INFO] [stdout]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Fn(&'cpu mut T, AddressingMode)`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/cpu/mem/address.rs:17:19
[INFO] [stdout]    |
[INFO] [stdout] 17 |             0x0000...0x07ff => Address::Address(addr),
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/cpu/mem/address.rs:18:19
[INFO] [stdout]    |
[INFO] [stdout] 18 |             0x0800...0x1fff => Address::Mirror {
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/cpu/mem/address.rs:23:19
[INFO] [stdout]    |
[INFO] [stdout] 23 |             0x2000...0x2007 => Address::Address(addr),
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/cpu/mem/address.rs:24:19
[INFO] [stdout]    |
[INFO] [stdout] 24 |             0x2008...0x3fff => Address::Mirror {
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/cpu/mem/address.rs:29:19
[INFO] [stdout]    |
[INFO] [stdout] 29 |             0x4000...0xffff => Address::Address(addr),
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `Observer`
[INFO] [stdout]  --> libnes/src/cpu/mem/mod.rs:3:29
[INFO] [stdout]   |
[INFO] [stdout] 3 | use crate::ev::{Observable, Observer, Subject};
[INFO] [stdout]   |                             ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/mem/mod.rs:10:42
[INFO] [stdout]    |
[INFO] [stdout] 10 |     fn subscribe(&mut self, handler: Box<FnMut(&CpuMemoryAccessEvent)>);
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&CpuMemoryAccessEvent)`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/mem/mod.rs:55:42
[INFO] [stdout]    |
[INFO] [stdout] 55 |     fn subscribe(&mut self, handler: Box<FnMut(&CpuMemoryAccessEvent)>) {
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&CpuMemoryAccessEvent)`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/nes/mod.rs:13:41
[INFO] [stdout]    |
[INFO] [stdout] 13 |     fn get_cpu(&mut self) -> Rc<RefCell<Cpu>>;
[INFO] [stdout]    |                                         ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/nes/mod.rs:14:41
[INFO] [stdout]    |
[INFO] [stdout] 14 |     fn get_ppu(&mut self) -> Rc<RefCell<Ppu>>;
[INFO] [stdout]    |                                         ^^^ help: use `dyn`: `dyn Ppu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/nes/mod.rs:18:21
[INFO] [stdout]    |
[INFO] [stdout] 18 |     cpu: Rc<RefCell<Cpu>>,
[INFO] [stdout]    |                     ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/nes/mod.rs:19:21
[INFO] [stdout]    |
[INFO] [stdout] 19 |     ppu: Rc<RefCell<Ppu>>,
[INFO] [stdout]    |                     ^^^ help: use `dyn`: `dyn Ppu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/nes/mod.rs:38:41
[INFO] [stdout]    |
[INFO] [stdout] 38 |     fn get_cpu(&mut self) -> Rc<RefCell<Cpu>> {
[INFO] [stdout]    |                                         ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/nes/mod.rs:42:41
[INFO] [stdout]    |
[INFO] [stdout] 42 |     fn get_ppu(&mut self) -> Rc<RefCell<Ppu>> {
[INFO] [stdout]    |                                         ^^^ help: use `dyn`: `dyn Ppu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/nes/mod.rs:48:32
[INFO] [stdout]    |
[INFO] [stdout] 48 |     pub fn new(cpu: Rc<RefCell<Cpu>>, ppu: Rc<RefCell<Ppu>>) -> Self {
[INFO] [stdout]    |                                ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/nes/mod.rs:48:55
[INFO] [stdout]    |
[INFO] [stdout] 48 |     pub fn new(cpu: Rc<RefCell<Cpu>>, ppu: Rc<RefCell<Ppu>>) -> Self {
[INFO] [stdout]    |                                                       ^^^ help: use `dyn`: `dyn Ppu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/ppu/attr_table.rs:73:14
[INFO] [stdout]    |
[INFO] [stdout] 73 |         i @ 0...3 => ATTRIBUTE_TABLE_ADDRESSES[i as usize],
[INFO] [stdout]    |              ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/ppu/mem/mod.rs:18:19
[INFO] [stdout]    |
[INFO] [stdout] 18 |             0x0000...0x2fff => Address::Address(addr),
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/ppu/mem/mod.rs:19:19
[INFO] [stdout]    |
[INFO] [stdout] 19 |             0x3000...0x3eff => Address::Mirror {
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/ppu/mem/mod.rs:24:19
[INFO] [stdout]    |
[INFO] [stdout] 24 |             0x3f00...0x3f1f => Address::Address(addr),
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/ppu/mem/mod.rs:25:19
[INFO] [stdout]    |
[INFO] [stdout] 25 |             0x3f20...0x3fff => Address::Mirror {
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/ppu/mem/mod.rs:30:19
[INFO] [stdout]    |
[INFO] [stdout] 30 |             0x4000...0x9fff => Address::Mirror {
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]    --> libnes/src/ppu/nametable.rs:105:14
[INFO] [stdout]     |
[INFO] [stdout] 105 |         i @ 0...3 => NAMETABLE_ADDRESSES[i as usize],
[INFO] [stdout]     |              ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]     |
[INFO] [stdout]     = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]     = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]    --> libnes/src/ppu/pattern_table.rs:103:22
[INFO] [stdout]     |
[INFO] [stdout] 103 |                     0...3 => color_val,
[INFO] [stdout]     |                      ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]     |
[INFO] [stdout]     = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]     = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/ppu/mod.rs:55:14
[INFO] [stdout]    |
[INFO] [stdout] 55 |     mem: Box<PpuMemoryMap>,
[INFO] [stdout]    |              ^^^^^^^^^^^^ help: use `dyn`: `dyn PpuMemoryMap`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]  --> libnes/src/ev/mod.rs:7:42
[INFO] [stdout]   |
[INFO] [stdout] 7 |     fn subscribe(&mut self, handler: Box<FnMut(&TEvent)>) -> Rc<RefCell<Subject<TEvent>>>;
[INFO] [stdout]   |                                          ^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&TEvent)`
[INFO] [stdout]   |
[INFO] [stdout]   = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]   = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]    Compiling libnes v0.1.0 (/opt/rustwide/workdir/libnes)
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/ev/mod.rs:14:20
[INFO] [stdout]    |
[INFO] [stdout] 14 |     cb: Option<Box<FnMut(&TEvent)>>,
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&TEvent)`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]    Compiling nes v0.1.0 (/opt/rustwide/workdir/nes)
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/ev/mod.rs:20:42
[INFO] [stdout]    |
[INFO] [stdout] 20 |     fn subscribe(&mut self, handler: Box<FnMut(&TEvent)>) -> Rc<RefCell<Subject<TEvent>>> {
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&TEvent)`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `crate::cpu::Cpu`
[INFO] [stdout]  --> libnes/src/cart/ines.rs:7:5
[INFO] [stdout]   |
[INFO] [stdout] 7 | use crate::cpu::Cpu;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `Observable`
[INFO] [stdout]  --> libnes/src/cpu/cpu.rs:9:17
[INFO] [stdout]   |
[INFO] [stdout] 9 | use crate::ev::{Observable, Observer};
[INFO] [stdout]   |                 ^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unreachable pattern
[INFO] [stdout]   --> libnes/src/cart/ines.rs:79:9
[INFO] [stdout]    |
[INFO] [stdout] 79 |         _ => return Err(format!("Unexpected non-ASCII sequence in header ID")),
[INFO] [stdout]    |         ^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unreachable_patterns)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unreachable pattern
[INFO] [stdout]   --> libnes/src/cpu/mem/address.rs:30:13
[INFO] [stdout]    |
[INFO] [stdout] 30 |             _ => panic!(format!(
[INFO] [stdout]    |             ^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `num_ram_banks`
[INFO] [stdout]    --> libnes/src/cart/ines.rs:102:9
[INFO] [stdout]     |
[INFO] [stdout] 102 |     let num_ram_banks = match take_elems(cart_data, 8, 1) {
[INFO] [stdout]     |         ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_num_ram_banks`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_variables)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `data`
[INFO] [stdout]    --> libnes/src/cart/ines.rs:110:9
[INFO] [stdout]     |
[INFO] [stdout] 110 |         data @ _ => {}
[INFO] [stdout]     |         ^^^^ help: if this is intentional, prefix it with an underscore: `_data`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `cpu`
[INFO] [stdout]    --> libnes/src/cpu/instr/instructions/instrs.rs:426:12
[INFO] [stdout]     |
[INFO] [stdout] 426 | pub fn nop(cpu: &mut impl Cpu, addr_mode: AddressingMode) {
[INFO] [stdout]     |            ^^^ help: if this is intentional, prefix it with an underscore: `_cpu`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `addr_mode`
[INFO] [stdout]    --> libnes/src/cpu/instr/instructions/instrs.rs:426:32
[INFO] [stdout]     |
[INFO] [stdout] 426 | pub fn nop(cpu: &mut impl Cpu, addr_mode: AddressingMode) {
[INFO] [stdout]     |                                ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `addr_mode`
[INFO] [stdout]    --> libnes/src/cpu/instr/instructions/instrs.rs:442:32
[INFO] [stdout]     |
[INFO] [stdout] 442 | pub fn pha(cpu: &mut impl Cpu, addr_mode: AddressingMode) {
[INFO] [stdout]     |                                ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `addr_mode`
[INFO] [stdout]    --> libnes/src/cpu/instr/instructions/instrs.rs:448:32
[INFO] [stdout]     |
[INFO] [stdout] 448 | pub fn php(cpu: &mut impl Cpu, addr_mode: AddressingMode) {
[INFO] [stdout]     |                                ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `addr_mode`
[INFO] [stdout]    --> libnes/src/cpu/instr/instructions/instrs.rs:454:32
[INFO] [stdout]     |
[INFO] [stdout] 454 | pub fn pla(cpu: &mut impl Cpu, addr_mode: AddressingMode) {
[INFO] [stdout]     |                                ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `addr_mode`
[INFO] [stdout]    --> libnes/src/cpu/instr/instructions/instrs.rs:465:32
[INFO] [stdout]     |
[INFO] [stdout] 465 | pub fn plp(cpu: &mut impl Cpu, addr_mode: AddressingMode) {
[INFO] [stdout]     |                                ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `addr_mode`
[INFO] [stdout]    --> libnes/src/cpu/instr/instructions/instrs.rs:543:32
[INFO] [stdout]     |
[INFO] [stdout] 543 | pub fn rts(cpu: &mut impl Cpu, addr_mode: AddressingMode) {
[INFO] [stdout]     |                                ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: panic message is not a string literal
[INFO] [stdout]    --> libnes/src/cpu/cpu.rs:124:28
[INFO] [stdout]     |
[INFO] [stdout] 124 |                     panic!(err);
[INFO] [stdout]     |                            ^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(non_fmt_panics)]` on by default
[INFO] [stdout]     = note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021
[INFO] [stdout]     = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
[INFO] [stdout] help: add a "{}" format string to Display the message
[INFO] [stdout]     |
[INFO] [stdout] 124 |                     panic!("{}", err);
[INFO] [stdout]     |                            ^^^^^
[INFO] [stdout] help: or use std::panic::panic_any instead
[INFO] [stdout]     |
[INFO] [stdout] 124 |                     std::panic::panic_any(err);
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: panic message is not a string literal
[INFO] [stdout]   --> libnes/src/cpu/mem/address.rs:30:25
[INFO] [stdout]    |
[INFO] [stdout] 30 |               _ => panic!(format!(
[INFO] [stdout]    |  _________________________^
[INFO] [stdout] 31 | |                 "Bad address '{:#06x}' while converting from u16 to Address",
[INFO] [stdout] 32 | |                 addr
[INFO] [stdout] 33 | |             )),
[INFO] [stdout]    | |_____________^
[INFO] [stdout]    |
[INFO] [stdout]    = note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021
[INFO] [stdout]    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
[INFO] [stdout]    = note: the panic!() macro supports formatting, so there's no need for the format!() macro here
[INFO] [stdout] help: remove the `format!(..)` macro call
[INFO] [stdout]    |
[INFO] [stdout] 30 |             _ => panic!(
[INFO] [stdout] 31 |                 "Bad address '{:#06x}' while converting from u16 to Address",
[INFO] [stdout] 32 |                 addr
[INFO] [stdout] 33 |             ),
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: panic message is not a string literal
[INFO] [stdout]   --> libnes/src/ppu/mem/mod.rs:35:25
[INFO] [stdout]    |
[INFO] [stdout] 35 |               _ => panic!(format!(
[INFO] [stdout]    |  _________________________^
[INFO] [stdout] 36 | |                 "Bad address '{:#06x}' while converting from u16 to Address",
[INFO] [stdout] 37 | |                 addr
[INFO] [stdout] 38 | |             )),
[INFO] [stdout]    | |_____________^
[INFO] [stdout]    |
[INFO] [stdout]    = note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021
[INFO] [stdout]    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
[INFO] [stdout]    = note: the panic!() macro supports formatting, so there's no need for the format!() macro here
[INFO] [stdout] help: remove the `format!(..)` macro call
[INFO] [stdout]    |
[INFO] [stdout] 35 |             _ => panic!(
[INFO] [stdout] 36 |                 "Bad address '{:#06x}' while converting from u16 to Address",
[INFO] [stdout] 37 |                 addr
[INFO] [stdout] 38 |             ),
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this method call resolves to `<&[T; N] as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to <[T; N] as IntoIterator>::into_iter in Rust 2021.
[INFO] [stdout]   --> libnes/src/ppu/nametable.rs:42:14
[INFO] [stdout]    |
[INFO] [stdout] 42 |             .into_iter()
[INFO] [stdout]    |              ^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(array_into_iter)]` on by default
[INFO] [stdout]    = warning: this changes meaning in Rust 2021
[INFO] [stdout]    = note: for more information, see issue #66145 <https://github.com/rust-lang/rust/issues/66145>
[INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity
[INFO] [stdout]    |
[INFO] [stdout] 42 |             .iter()
[INFO] [stdout]    |              ^^^^
[INFO] [stdout] help: or use `IntoIterator::into_iter(..)` instead of `.into_iter()` to explicitly iterate by value
[INFO] [stdout]    |
[INFO] [stdout] 40 |         let colors = IntoIterator::into_iter(pattern_table_tile
[INFO] [stdout] 41 |             .get_color_indices())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison is useless due to type limits
[INFO] [stdout]   --> libnes/src/bits/mod.rs:76:8
[INFO] [stdout]    |
[INFO] [stdout] 76 |     if bit_num < 0 || bit_num > 7 {
[INFO] [stdout]    |        ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_comparisons)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: 66 warnings emitted
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused `#[macro_use]` import
[INFO] [stdout]  --> libnes/src/lib.rs:3:1
[INFO] [stdout]   |
[INFO] [stdout] 3 | #[macro_use]
[INFO] [stdout]   | ^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: type `iNESLoader` should have an upper camel case name
[INFO] [stdout]   --> libnes/src/cart/ines.rs:16:12
[INFO] [stdout]    |
[INFO] [stdout] 16 | pub struct iNESLoader {}
[INFO] [stdout]    |            ^^^^^^^^^^ help: convert the identifier to upper camel case: `INesloader`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(non_camel_case_types)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: type `iNESHeader` should have an upper camel case name
[INFO] [stdout]    --> libnes/src/cart/ines.rs:127:8
[INFO] [stdout]     |
[INFO] [stdout] 127 | struct iNESHeader {
[INFO] [stdout]     |        ^^^^^^^^^^ help: convert the identifier to upper camel case: `INesheader`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cart/mappers/nrom.rs:16:35
[INFO] [stdout]    |
[INFO] [stdout] 16 |     fn map(&self, nes: Rc<RefCell<Nes>>, options: MapperOptions) -> Result<(), String> {
[INFO] [stdout]    |                                   ^^^ help: use `dyn`: `dyn Nes`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(bare_trait_objects)]` on by default
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cart/mappers/mod.rs:11:35
[INFO] [stdout]    |
[INFO] [stdout] 11 |     fn map(&self, nes: Rc<RefCell<Nes>>, options: MapperOptions) -> Result<(), String>;
[INFO] [stdout]    |                                   ^^^ help: use `dyn`: `dyn Nes`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant `iNes` should have an upper camel case name
[INFO] [stdout]   --> libnes/src/cart/mod.rs:28:5
[INFO] [stdout]    |
[INFO] [stdout] 28 |     iNes,
[INFO] [stdout]    |     ^^^^ help: convert the identifier to upper camel case (notice the capitalization): `INes`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `Observer`
[INFO] [stdout]  --> libnes/src/cpu/cpu.rs:9:29
[INFO] [stdout]   |
[INFO] [stdout] 9 | use crate::ev::{Observable, Observer};
[INFO] [stdout]   |                             ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/cpu.rs:30:37
[INFO] [stdout]    |
[INFO] [stdout] 30 |     fn load_mem(&mut self, mem: Box<CpuMemoryMap>);
[INFO] [stdout]    |                                     ^^^^^^^^^^^^ help: use `dyn`: `dyn CpuMemoryMap`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/cpu.rs:31:46
[INFO] [stdout]    |
[INFO] [stdout] 31 |     fn subscribe_mem(&mut self, handler: Box<FnMut(&CpuMemoryAccessEvent)>);
[INFO] [stdout]    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&CpuMemoryAccessEvent)`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/cpu.rs:50:16
[INFO] [stdout]    |
[INFO] [stdout] 50 | impl Debug for Cpu {
[INFO] [stdout]    |                ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/cpu.rs:63:21
[INFO] [stdout]    |
[INFO] [stdout] 63 |     pub memory: Box<CpuMemoryMap>,
[INFO] [stdout]    |                     ^^^^^^^^^^^^ help: use `dyn`: `dyn CpuMemoryMap`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/cpu.rs:72:19
[INFO] [stdout]    |
[INFO] [stdout] 72 |         (self as &Cpu).fmt(f)
[INFO] [stdout]    |                   ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]    --> libnes/src/cpu/cpu.rs:204:52
[INFO] [stdout]     |
[INFO] [stdout] 204 |             println!("cpu pre: {:?}", self as &mut Cpu);
[INFO] [stdout]     |                                                    ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]     |
[INFO] [stdout]     = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]     = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]    --> libnes/src/cpu/cpu.rs:216:53
[INFO] [stdout]     |
[INFO] [stdout] 216 |             println!("cpu post: {:?}", self as &mut Cpu);
[INFO] [stdout]     |                                                     ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]     |
[INFO] [stdout]     = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]     = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]    --> libnes/src/cpu/cpu.rs:224:37
[INFO] [stdout]     |
[INFO] [stdout] 224 |     fn load_mem(&mut self, mem: Box<CpuMemoryMap>) {
[INFO] [stdout]     |                                     ^^^^^^^^^^^^ help: use `dyn`: `dyn CpuMemoryMap`
[INFO] [stdout]     |
[INFO] [stdout]     = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]     = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]    --> libnes/src/cpu/cpu.rs:228:46
[INFO] [stdout]     |
[INFO] [stdout] 228 |     fn subscribe_mem(&mut self, handler: Box<FnMut(&CpuMemoryAccessEvent)>) {
[INFO] [stdout]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&CpuMemoryAccessEvent)`
[INFO] [stdout]     |
[INFO] [stdout]     = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]     = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/instr/instructions/helpers.rs:19:42
[INFO] [stdout]    |
[INFO] [stdout] 19 |     pub fn resolve_value(self, cpu: &mut Cpu) -> i8 {
[INFO] [stdout]    |                                          ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/instr/instructions/helpers.rs:34:30
[INFO] [stdout]    |
[INFO] [stdout] 34 | pub fn get_operand(cpu: &mut Cpu, addr_mode: &AddressingMode) -> GetOperandResult {
[INFO] [stdout]    |                              ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/instr/instructions/mod.rs:16:18
[INFO] [stdout]    |
[INFO] [stdout] 16 |     do_run: &'op Fn(&'cpu mut T, AddressingMode),
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Fn(&'cpu mut T, AddressingMode)`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/instr/instructions/mod.rs:37:22
[INFO] [stdout]    |
[INFO] [stdout] 37 |         do_run: &'op Fn(&'cpu mut T, AddressingMode),
[INFO] [stdout]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Fn(&'cpu mut T, AddressingMode)`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/cpu/mem/address.rs:17:19
[INFO] [stdout]    |
[INFO] [stdout] 17 |             0x0000...0x07ff => Address::Address(addr),
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/cpu/mem/address.rs:18:19
[INFO] [stdout]    |
[INFO] [stdout] 18 |             0x0800...0x1fff => Address::Mirror {
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/cpu/mem/address.rs:23:19
[INFO] [stdout]    |
[INFO] [stdout] 23 |             0x2000...0x2007 => Address::Address(addr),
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/cpu/mem/address.rs:24:19
[INFO] [stdout]    |
[INFO] [stdout] 24 |             0x2008...0x3fff => Address::Mirror {
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/cpu/mem/address.rs:29:19
[INFO] [stdout]    |
[INFO] [stdout] 29 |             0x4000...0xffff => Address::Address(addr),
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `Observer`
[INFO] [stdout]  --> libnes/src/cpu/mem/mod.rs:3:29
[INFO] [stdout]   |
[INFO] [stdout] 3 | use crate::ev::{Observable, Observer, Subject};
[INFO] [stdout]   |                             ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/mem/mod.rs:10:42
[INFO] [stdout]    |
[INFO] [stdout] 10 |     fn subscribe(&mut self, handler: Box<FnMut(&CpuMemoryAccessEvent)>);
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&CpuMemoryAccessEvent)`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/cpu/mem/mod.rs:55:42
[INFO] [stdout]    |
[INFO] [stdout] 55 |     fn subscribe(&mut self, handler: Box<FnMut(&CpuMemoryAccessEvent)>) {
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&CpuMemoryAccessEvent)`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/nes/mod.rs:13:41
[INFO] [stdout]    |
[INFO] [stdout] 13 |     fn get_cpu(&mut self) -> Rc<RefCell<Cpu>>;
[INFO] [stdout]    |                                         ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/nes/mod.rs:14:41
[INFO] [stdout]    |
[INFO] [stdout] 14 |     fn get_ppu(&mut self) -> Rc<RefCell<Ppu>>;
[INFO] [stdout]    |                                         ^^^ help: use `dyn`: `dyn Ppu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/nes/mod.rs:18:21
[INFO] [stdout]    |
[INFO] [stdout] 18 |     cpu: Rc<RefCell<Cpu>>,
[INFO] [stdout]    |                     ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/nes/mod.rs:19:21
[INFO] [stdout]    |
[INFO] [stdout] 19 |     ppu: Rc<RefCell<Ppu>>,
[INFO] [stdout]    |                     ^^^ help: use `dyn`: `dyn Ppu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/nes/mod.rs:38:41
[INFO] [stdout]    |
[INFO] [stdout] 38 |     fn get_cpu(&mut self) -> Rc<RefCell<Cpu>> {
[INFO] [stdout]    |                                         ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/nes/mod.rs:42:41
[INFO] [stdout]    |
[INFO] [stdout] 42 |     fn get_ppu(&mut self) -> Rc<RefCell<Ppu>> {
[INFO] [stdout]    |                                         ^^^ help: use `dyn`: `dyn Ppu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/nes/mod.rs:48:32
[INFO] [stdout]    |
[INFO] [stdout] 48 |     pub fn new(cpu: Rc<RefCell<Cpu>>, ppu: Rc<RefCell<Ppu>>) -> Self {
[INFO] [stdout]    |                                ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/nes/mod.rs:48:55
[INFO] [stdout]    |
[INFO] [stdout] 48 |     pub fn new(cpu: Rc<RefCell<Cpu>>, ppu: Rc<RefCell<Ppu>>) -> Self {
[INFO] [stdout]    |                                                       ^^^ help: use `dyn`: `dyn Ppu`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/ppu/attr_table.rs:73:14
[INFO] [stdout]    |
[INFO] [stdout] 73 |         i @ 0...3 => ATTRIBUTE_TABLE_ADDRESSES[i as usize],
[INFO] [stdout]    |              ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/ppu/mem/mod.rs:18:19
[INFO] [stdout]    |
[INFO] [stdout] 18 |             0x0000...0x2fff => Address::Address(addr),
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/ppu/mem/mod.rs:19:19
[INFO] [stdout]    |
[INFO] [stdout] 19 |             0x3000...0x3eff => Address::Mirror {
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/ppu/mem/mod.rs:24:19
[INFO] [stdout]    |
[INFO] [stdout] 24 |             0x3f00...0x3f1f => Address::Address(addr),
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/ppu/mem/mod.rs:25:19
[INFO] [stdout]    |
[INFO] [stdout] 25 |             0x3f20...0x3fff => Address::Mirror {
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> libnes/src/ppu/mem/mod.rs:30:19
[INFO] [stdout]    |
[INFO] [stdout] 30 |             0x4000...0x9fff => Address::Mirror {
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]    --> libnes/src/ppu/nametable.rs:105:14
[INFO] [stdout]     |
[INFO] [stdout] 105 |         i @ 0...3 => NAMETABLE_ADDRESSES[i as usize],
[INFO] [stdout]     |              ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]     |
[INFO] [stdout]     = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]     = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]    --> libnes/src/ppu/pattern_table.rs:103:22
[INFO] [stdout]     |
[INFO] [stdout] 103 |                     0...3 => color_val,
[INFO] [stdout]     |                      ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]     |
[INFO] [stdout]     = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]     = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/ppu/mod.rs:55:14
[INFO] [stdout]    |
[INFO] [stdout] 55 |     mem: Box<PpuMemoryMap>,
[INFO] [stdout]    |              ^^^^^^^^^^^^ help: use `dyn`: `dyn PpuMemoryMap`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]  --> libnes/src/ev/mod.rs:7:42
[INFO] [stdout]   |
[INFO] [stdout] 7 |     fn subscribe(&mut self, handler: Box<FnMut(&TEvent)>) -> Rc<RefCell<Subject<TEvent>>>;
[INFO] [stdout]   |                                          ^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&TEvent)`
[INFO] [stdout]   |
[INFO] [stdout]   = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]   = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/ev/mod.rs:14:20
[INFO] [stdout]    |
[INFO] [stdout] 14 |     cb: Option<Box<FnMut(&TEvent)>>,
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&TEvent)`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> libnes/src/ev/mod.rs:20:42
[INFO] [stdout]    |
[INFO] [stdout] 20 |     fn subscribe(&mut self, handler: Box<FnMut(&TEvent)>) -> Rc<RefCell<Subject<TEvent>>> {
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&TEvent)`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]  --> nes/bin/debugger.rs:9:47
[INFO] [stdout]   |
[INFO] [stdout] 9 | pub fn start_debugger<'a>(cpu_ref: Rc<RefCell<Cpu>>)
[INFO] [stdout]   |                                               ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(bare_trait_objects)]` on by default
[INFO] [stdout]   = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]   = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> nes/bin/gui.rs:20:21
[INFO] [stdout]    |
[INFO] [stdout] 20 |     nes: Rc<RefCell<Nes>>,
[INFO] [stdout]    |                     ^^^ help: use `dyn`: `dyn Nes`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]   --> nes/bin/gui.rs:93:34
[INFO] [stdout]    |
[INFO] [stdout] 93 | pub fn start_gui(nes: Rc<RefCell<Nes>>) {
[INFO] [stdout]    |                                  ^^^ help: use `dyn`: `dyn Nes`
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `libnes::cpu::mem::CpuMemoryAccessEvent`
[INFO] [stdout]   --> nes/bin/mod.rs:12:5
[INFO] [stdout]    |
[INFO] [stdout] 12 | use libnes::cpu::mem::CpuMemoryAccessEvent;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stdout]    --> nes/bin/mod.rs:102:25
[INFO] [stdout]     |
[INFO] [stdout] 102 |     let cpu: Rc<RefCell<Cpu>> = nes.clone().borrow_mut().get_cpu().clone();
[INFO] [stdout]     |                         ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stdout]     |
[INFO] [stdout]     = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]     = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `Ppu`
[INFO] [stdout]   --> nes/bin/mod.rs:23:31
[INFO] [stdout]    |
[INFO] [stdout] 23 | use libnes::ppu::{DefaultPpu, Ppu};
[INFO] [stdout]    |                               ^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable `index` is assigned to, but never used
[INFO] [stdout]   --> nes/bin/gui.rs:48:21
[INFO] [stdout]    |
[INFO] [stdout] 48 |             let mut index = 0;
[INFO] [stdout]    |                     ^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_variables)]` on by default
[INFO] [stdout]    = note: consider using `_index` instead
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `nametable_draw_tile_index`
[INFO] [stdout]   --> nes/bin/gui.rs:35:13
[INFO] [stdout]    |
[INFO] [stdout] 35 |         let nametable_draw_tile_index = self.debug.nametable_tile_index;
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_nametable_draw_tile_index`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `args`
[INFO] [stdout]   --> nes/bin/gui.rs:87:26
[INFO] [stdout]    |
[INFO] [stdout] 87 |     fn update(&mut self, args: &UpdateArgs) {
[INFO] [stdout]    |                          ^^^^ help: if this is intentional, prefix it with an underscore: `_args`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]   --> nes/bin/gui.rs:33:13
[INFO] [stdout]    |
[INFO] [stdout] 33 |         let mut ppu = nes.get_ppu();
[INFO] [stdout]    |             ----^^^
[INFO] [stdout]    |             |
[INFO] [stdout]    |             help: remove this `mut`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_mut)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: panic message is not a string literal
[INFO] [stdout]   --> nes/bin/mod.rs:79:21
[INFO] [stdout]    |
[INFO] [stdout] 79 |         _ => panic!(format!("Unsupported rom format '{}'", rom_format_str)),
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(non_fmt_panics)]` on by default
[INFO] [stdout]    = note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021
[INFO] [stdout]    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
[INFO] [stdout]    = note: the panic!() macro supports formatting, so there's no need for the format!() macro here
[INFO] [stdout] help: remove the `format!(..)` macro call
[INFO] [stdout]    |
[INFO] [stdout] 79 |         _ => panic!("Unsupported rom format '{}'", rom_format_str),
[INFO] [stdout]    |                    --                                           --
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `crate::cpu::Cpu`
[INFO] [stdout]  --> libnes/src/cart/ines.rs:7:5
[INFO] [stdout]   |
[INFO] [stdout] 7 | use crate::cpu::Cpu;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `Observable`
[INFO] [stdout]  --> libnes/src/cpu/cpu.rs:9:17
[INFO] [stdout]   |
[INFO] [stdout] 9 | use crate::ev::{Observable, Observer};
[INFO] [stdout]   |                 ^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unreachable pattern
[INFO] [stdout]   --> libnes/src/cart/ines.rs:79:9
[INFO] [stdout]    |
[INFO] [stdout] 79 |         _ => return Err(format!("Unexpected non-ASCII sequence in header ID")),
[INFO] [stdout]    |         ^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unreachable_patterns)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unreachable pattern
[INFO] [stdout]   --> libnes/src/cpu/mem/address.rs:30:13
[INFO] [stdout]    |
[INFO] [stdout] 30 |             _ => panic!(format!(
[INFO] [stdout]    |             ^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `num_ram_banks`
[INFO] [stdout]    --> libnes/src/cart/ines.rs:102:9
[INFO] [stdout]     |
[INFO] [stdout] 102 |     let num_ram_banks = match take_elems(cart_data, 8, 1) {
[INFO] [stdout]     |         ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_num_ram_banks`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_variables)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `data`
[INFO] [stdout]    --> libnes/src/cart/ines.rs:110:9
[INFO] [stdout]     |
[INFO] [stdout] 110 |         data @ _ => {}
[INFO] [stdout]     |         ^^^^ help: if this is intentional, prefix it with an underscore: `_data`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `cpu`
[INFO] [stdout]    --> libnes/src/cpu/instr/instructions/instrs.rs:426:12
[INFO] [stdout]     |
[INFO] [stdout] 426 | pub fn nop(cpu: &mut impl Cpu, addr_mode: AddressingMode) {
[INFO] [stdout]     |            ^^^ help: if this is intentional, prefix it with an underscore: `_cpu`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `addr_mode`
[INFO] [stdout]    --> libnes/src/cpu/instr/instructions/instrs.rs:426:32
[INFO] [stdout]     |
[INFO] [stdout] 426 | pub fn nop(cpu: &mut impl Cpu, addr_mode: AddressingMode) {
[INFO] [stdout]     |                                ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `addr_mode`
[INFO] [stdout]    --> libnes/src/cpu/instr/instructions/instrs.rs:442:32
[INFO] [stdout]     |
[INFO] [stdout] 442 | pub fn pha(cpu: &mut impl Cpu, addr_mode: AddressingMode) {
[INFO] [stdout]     |                                ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `addr_mode`
[INFO] [stdout]    --> libnes/src/cpu/instr/instructions/instrs.rs:448:32
[INFO] [stdout]     |
[INFO] [stdout] 448 | pub fn php(cpu: &mut impl Cpu, addr_mode: AddressingMode) {
[INFO] [stdout]     |                                ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `addr_mode`
[INFO] [stdout]    --> libnes/src/cpu/instr/instructions/instrs.rs:454:32
[INFO] [stdout]     |
[INFO] [stdout] 454 | pub fn pla(cpu: &mut impl Cpu, addr_mode: AddressingMode) {
[INFO] [stdout]     |                                ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `addr_mode`
[INFO] [stdout]    --> libnes/src/cpu/instr/instructions/instrs.rs:465:32
[INFO] [stdout]     |
[INFO] [stdout] 465 | pub fn plp(cpu: &mut impl Cpu, addr_mode: AddressingMode) {
[INFO] [stdout]     |                                ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `addr_mode`
[INFO] [stdout]    --> libnes/src/cpu/instr/instructions/instrs.rs:543:32
[INFO] [stdout]     |
[INFO] [stdout] 543 | pub fn rts(cpu: &mut impl Cpu, addr_mode: AddressingMode) {
[INFO] [stdout]     |                                ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: panic message is not a string literal
[INFO] [stdout]    --> libnes/src/cpu/cpu.rs:124:28
[INFO] [stdout]     |
[INFO] [stdout] 124 |                     panic!(err);
[INFO] [stdout]     |                            ^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(non_fmt_panics)]` on by default
[INFO] [stdout]     = note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021
[INFO] [stdout]     = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
[INFO] [stdout] help: add a "{}" format string to Display the message
[INFO] [stdout]     |
[INFO] [stdout] 124 |                     panic!("{}", err);
[INFO] [stdout]     |                            ^^^^^
[INFO] [stdout] help: or use std::panic::panic_any instead
[INFO] [stdout]     |
[INFO] [stdout] 124 |                     std::panic::panic_any(err);
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: panic message is not a string literal
[INFO] [stdout]   --> libnes/src/cpu/mem/address.rs:30:25
[INFO] [stdout]    |
[INFO] [stdout] 30 |               _ => panic!(format!(
[INFO] [stdout]    |  _________________________^
[INFO] [stdout] 31 | |                 "Bad address '{:#06x}' while converting from u16 to Address",
[INFO] [stdout] 32 | |                 addr
[INFO] [stdout] 33 | |             )),
[INFO] [stdout]    | |_____________^
[INFO] [stdout]    |
[INFO] [stdout]    = note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021
[INFO] [stdout]    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
[INFO] [stdout]    = note: the panic!() macro supports formatting, so there's no need for the format!() macro here
[INFO] [stdout] help: remove the `format!(..)` macro call
[INFO] [stdout]    |
[INFO] [stdout] 30 |             _ => panic!(
[INFO] [stdout] 31 |                 "Bad address '{:#06x}' while converting from u16 to Address",
[INFO] [stdout] 32 |                 addr
[INFO] [stdout] 33 |             ),
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: panic message is not a string literal
[INFO] [stdout]   --> libnes/src/ppu/mem/mod.rs:35:25
[INFO] [stdout]    |
[INFO] [stdout] 35 |               _ => panic!(format!(
[INFO] [stdout]    |  _________________________^
[INFO] [stdout] 36 | |                 "Bad address '{:#06x}' while converting from u16 to Address",
[INFO] [stdout] 37 | |                 addr
[INFO] [stdout] 38 | |             )),
[INFO] [stdout]    | |_____________^
[INFO] [stdout]    |
[INFO] [stdout]    = note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021
[INFO] [stdout]    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
[INFO] [stdout]    = note: the panic!() macro supports formatting, so there's no need for the format!() macro here
[INFO] [stdout] help: remove the `format!(..)` macro call
[INFO] [stdout]    |
[INFO] [stdout] 35 |             _ => panic!(
[INFO] [stdout] 36 |                 "Bad address '{:#06x}' while converting from u16 to Address",
[INFO] [stdout] 37 |                 addr
[INFO] [stdout] 38 |             ),
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this method call resolves to `<&[T; N] as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to <[T; N] as IntoIterator>::into_iter in Rust 2021.
[INFO] [stdout]   --> libnes/src/ppu/nametable.rs:42:14
[INFO] [stdout]    |
[INFO] [stdout] 42 |             .into_iter()
[INFO] [stdout]    |              ^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(array_into_iter)]` on by default
[INFO] [stdout]    = warning: this changes meaning in Rust 2021
[INFO] [stdout]    = note: for more information, see issue #66145 <https://github.com/rust-lang/rust/issues/66145>
[INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity
[INFO] [stdout]    |
[INFO] [stdout] 42 |             .iter()
[INFO] [stdout]    |              ^^^^
[INFO] [stdout] help: or use `IntoIterator::into_iter(..)` instead of `.into_iter()` to explicitly iterate by value
[INFO] [stdout]    |
[INFO] [stdout] 40 |         let colors = IntoIterator::into_iter(pattern_table_tile
[INFO] [stdout] 41 |             .get_color_indices())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison is useless due to type limits
[INFO] [stdout]   --> libnes/src/bits/mod.rs:76:8
[INFO] [stdout]    |
[INFO] [stdout] 76 |     if bit_num < 0 || bit_num > 7 {
[INFO] [stdout]    |        ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_comparisons)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: 11 warnings emitted
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: 66 warnings emitted
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished test [unoptimized + debuginfo] target(s) in 4.60s
[INFO] running `Command { std: "docker" "inspect" "35205f82451019eea8908f5134b52af45bf1a53fec3d24be8b6751cdaca7140b", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "35205f82451019eea8908f5134b52af45bf1a53fec3d24be8b6751cdaca7140b", kill_on_drop: false }`
[INFO] [stdout] 35205f82451019eea8908f5134b52af45bf1a53fec3d24be8b6751cdaca7140b
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-9/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-9/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2021-08-01" "test" "--frozen", kill_on_drop: false }`
[INFO] [stdout] f76afde61252b36fd68622c848e47fdbe22b1536e39ee656973297c189621033
[INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap.
[INFO] running `Command { std: "docker" "start" "-a" "f76afde61252b36fd68622c848e47fdbe22b1536e39ee656973297c189621033", kill_on_drop: false }`
[INFO] [stderr] warning: unused import: `self`
[INFO] [stderr]  --> libnes/build.rs:3:33
[INFO] [stderr]   |
[INFO] [stderr] 3 | use std::fs::{File, DirBuilder, self};
[INFO] [stderr]   |                                 ^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: `#[warn(unused_imports)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::io::Write`
[INFO] [stderr]  --> libnes/build.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 | use std::io::Write;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: constant `klaus_functional_tests_url` should have an upper case name
[INFO] [stderr]  --> libnes/build.rs:7:7
[INFO] [stderr]   |
[INFO] [stderr] 7 | const klaus_functional_tests_url: &'static str = "https://github.com/Klaus2m5/6502_65C02_functional_tests/blob/master/bin_files/6502_func...
[INFO] [stderr]   |       ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `KLAUS_FUNCTIONAL_TESTS_URL`
[INFO] [stderr]   |
[INFO] [stderr]   = note: `#[warn(non_upper_case_globals)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: constant `nestest_url` should have an upper case name
[INFO] [stderr]  --> libnes/build.rs:8:7
[INFO] [stderr]   |
[INFO] [stderr] 8 | const nestest_url: &'static str = "http://nickmass.com/images/nestest.nes";
[INFO] [stderr]   |       ^^^^^^^^^^^ help: convert the identifier to upper case: `NESTEST_URL`
[INFO] [stderr] 
[INFO] [stderr] warning: `libnes` (build script) generated 4 warnings
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> libnes/src/lib.rs:3:1
[INFO] [stderr]   |
[INFO] [stderr] 3 | #[macro_use]
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: `#[warn(unused_imports)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: type `iNESLoader` should have an upper camel case name
[INFO] [stderr]   --> libnes/src/cart/ines.rs:16:12
[INFO] [stderr]    |
[INFO] [stderr] 16 | pub struct iNESLoader {}
[INFO] [stderr]    |            ^^^^^^^^^^ help: convert the identifier to upper camel case: `INesloader`
[INFO] [stderr]    |
[INFO] [stderr]    = note: `#[warn(non_camel_case_types)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: type `iNESHeader` should have an upper camel case name
[INFO] [stderr]    --> libnes/src/cart/ines.rs:127:8
[INFO] [stderr]     |
[INFO] [stderr] 127 | struct iNESHeader {
[INFO] [stderr]     |        ^^^^^^^^^^ help: convert the identifier to upper camel case: `INesheader`
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> libnes/src/cart/mappers/nrom.rs:16:35
[INFO] [stderr]    |
[INFO] [stderr] 16 |     fn map(&self, nes: Rc<RefCell<Nes>>, options: MapperOptions) -> Result<(), String> {
[INFO] [stderr]    |                                   ^^^ help: use `dyn`: `dyn Nes`
[INFO] [stderr]    |
[INFO] [stderr]    = note: `#[warn(bare_trait_objects)]` on by default
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> libnes/src/cart/mappers/mod.rs:11:35
[INFO] [stderr]    |
[INFO] [stderr] 11 |     fn map(&self, nes: Rc<RefCell<Nes>>, options: MapperOptions) -> Result<(), String>;
[INFO] [stderr]    |                                   ^^^ help: use `dyn`: `dyn Nes`
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: variant `iNes` should have an upper camel case name
[INFO] [stderr]   --> libnes/src/cart/mod.rs:28:5
[INFO] [stderr]    |
[INFO] [stderr] 28 |     iNes,
[INFO] [stderr]    |     ^^^^ help: convert the identifier to upper camel case (notice the capitalization): `INes`
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Observer`
[INFO] [stderr]  --> libnes/src/cpu/cpu.rs:9:29
[INFO] [stderr]   |
[INFO] [stderr] 9 | use crate::ev::{Observable, Observer};
[INFO] [stderr]   |                             ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> libnes/src/cpu/cpu.rs:30:37
[INFO] [stderr]    |
[INFO] [stderr] 30 |     fn load_mem(&mut self, mem: Box<CpuMemoryMap>);
[INFO] [stderr]    |                                     ^^^^^^^^^^^^ help: use `dyn`: `dyn CpuMemoryMap`
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> libnes/src/cpu/cpu.rs:31:46
[INFO] [stderr]    |
[INFO] [stderr] 31 |     fn subscribe_mem(&mut self, handler: Box<FnMut(&CpuMemoryAccessEvent)>);
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&CpuMemoryAccessEvent)`
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> libnes/src/cpu/cpu.rs:50:16
[INFO] [stderr]    |
[INFO] [stderr] 50 | impl Debug for Cpu {
[INFO] [stderr]    |                ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> libnes/src/cpu/cpu.rs:63:21
[INFO] [stderr]    |
[INFO] [stderr] 63 |     pub memory: Box<CpuMemoryMap>,
[INFO] [stderr]    |                     ^^^^^^^^^^^^ help: use `dyn`: `dyn CpuMemoryMap`
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> libnes/src/cpu/cpu.rs:72:19
[INFO] [stderr]    |
[INFO] [stderr] 72 |         (self as &Cpu).fmt(f)
[INFO] [stderr]    |                   ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]    --> libnes/src/cpu/cpu.rs:204:52
[INFO] [stderr]     |
[INFO] [stderr] 204 |             println!("cpu pre: {:?}", self as &mut Cpu);
[INFO] [stderr]     |                                                    ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stderr]     |
[INFO] [stderr]     = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]     = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]    --> libnes/src/cpu/cpu.rs:216:53
[INFO] [stderr]     |
[INFO] [stderr] 216 |             println!("cpu post: {:?}", self as &mut Cpu);
[INFO] [stderr]     |                                                     ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stderr]     |
[INFO] [stderr]     = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]     = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]    --> libnes/src/cpu/cpu.rs:224:37
[INFO] [stderr]     |
[INFO] [stderr] 224 |     fn load_mem(&mut self, mem: Box<CpuMemoryMap>) {
[INFO] [stderr]     |                                     ^^^^^^^^^^^^ help: use `dyn`: `dyn CpuMemoryMap`
[INFO] [stderr]     |
[INFO] [stderr]     = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]     = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]    --> libnes/src/cpu/cpu.rs:228:46
[INFO] [stderr]     |
[INFO] [stderr] 228 |     fn subscribe_mem(&mut self, handler: Box<FnMut(&CpuMemoryAccessEvent)>) {
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&CpuMemoryAccessEvent)`
[INFO] [stderr]     |
[INFO] [stderr]     = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]     = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> libnes/src/cpu/instr/instructions/helpers.rs:19:42
[INFO] [stderr]    |
[INFO] [stderr] 19 |     pub fn resolve_value(self, cpu: &mut Cpu) -> i8 {
[INFO] [stderr]    |                                          ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> libnes/src/cpu/instr/instructions/helpers.rs:34:30
[INFO] [stderr]    |
[INFO] [stderr] 34 | pub fn get_operand(cpu: &mut Cpu, addr_mode: &AddressingMode) -> GetOperandResult {
[INFO] [stderr]    |                              ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> libnes/src/cpu/instr/instructions/mod.rs:16:18
[INFO] [stderr]    |
[INFO] [stderr] 16 |     do_run: &'op Fn(&'cpu mut T, AddressingMode),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Fn(&'cpu mut T, AddressingMode)`
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> libnes/src/cpu/instr/instructions/mod.rs:37:22
[INFO] [stderr]    |
[INFO] [stderr] 37 |         do_run: &'op Fn(&'cpu mut T, AddressingMode),
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Fn(&'cpu mut T, AddressingMode)`
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> libnes/src/cpu/mem/address.rs:17:19
[INFO] [stderr]    |
[INFO] [stderr] 17 |             0x0000...0x07ff => Address::Address(addr),
[INFO] [stderr]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr]    |
[INFO] [stderr]    = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> libnes/src/cpu/mem/address.rs:18:19
[INFO] [stderr]    |
[INFO] [stderr] 18 |             0x0800...0x1fff => Address::Mirror {
[INFO] [stderr]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> libnes/src/cpu/mem/address.rs:23:19
[INFO] [stderr]    |
[INFO] [stderr] 23 |             0x2000...0x2007 => Address::Address(addr),
[INFO] [stderr]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> libnes/src/cpu/mem/address.rs:24:19
[INFO] [stderr]    |
[INFO] [stderr] 24 |             0x2008...0x3fff => Address::Mirror {
[INFO] [stderr]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> libnes/src/cpu/mem/address.rs:29:19
[INFO] [stderr]    |
[INFO] [stderr] 29 |             0x4000...0xffff => Address::Address(addr),
[INFO] [stderr]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Observer`
[INFO] [stderr]  --> libnes/src/cpu/mem/mod.rs:3:29
[INFO] [stderr]   |
[INFO] [stderr] 3 | use crate::ev::{Observable, Observer, Subject};
[INFO] [stderr]   |                             ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> libnes/src/cpu/mem/mod.rs:10:42
[INFO] [stderr]    |
[INFO] [stderr] 10 |     fn subscribe(&mut self, handler: Box<FnMut(&CpuMemoryAccessEvent)>);
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&CpuMemoryAccessEvent)`
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> libnes/src/cpu/mem/mod.rs:55:42
[INFO] [stderr]    |
[INFO] [stderr] 55 |     fn subscribe(&mut self, handler: Box<FnMut(&CpuMemoryAccessEvent)>) {
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&CpuMemoryAccessEvent)`
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> libnes/src/nes/mod.rs:13:41
[INFO] [stderr]    |
[INFO] [stderr] 13 |     fn get_cpu(&mut self) -> Rc<RefCell<Cpu>>;
[INFO] [stderr]    |                                         ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> libnes/src/nes/mod.rs:14:41
[INFO] [stderr]    |
[INFO] [stderr] 14 |     fn get_ppu(&mut self) -> Rc<RefCell<Ppu>>;
[INFO] [stderr]    |                                         ^^^ help: use `dyn`: `dyn Ppu`
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> libnes/src/nes/mod.rs:18:21
[INFO] [stderr]    |
[INFO] [stderr] 18 |     cpu: Rc<RefCell<Cpu>>,
[INFO] [stderr]    |                     ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> libnes/src/nes/mod.rs:19:21
[INFO] [stderr]    |
[INFO] [stderr] 19 |     ppu: Rc<RefCell<Ppu>>,
[INFO] [stderr]    |                     ^^^ help: use `dyn`: `dyn Ppu`
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> libnes/src/nes/mod.rs:38:41
[INFO] [stderr]    |
[INFO] [stderr] 38 |     fn get_cpu(&mut self) -> Rc<RefCell<Cpu>> {
[INFO] [stderr]    |                                         ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> libnes/src/nes/mod.rs:42:41
[INFO] [stderr]    |
[INFO] [stderr] 42 |     fn get_ppu(&mut self) -> Rc<RefCell<Ppu>> {
[INFO] [stderr]    |                                         ^^^ help: use `dyn`: `dyn Ppu`
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> libnes/src/nes/mod.rs:48:32
[INFO] [stderr]    |
[INFO] [stderr] 48 |     pub fn new(cpu: Rc<RefCell<Cpu>>, ppu: Rc<RefCell<Ppu>>) -> Self {
[INFO] [stderr]    |                                ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> libnes/src/nes/mod.rs:48:55
[INFO] [stderr]    |
[INFO] [stderr] 48 |     pub fn new(cpu: Rc<RefCell<Cpu>>, ppu: Rc<RefCell<Ppu>>) -> Self {
[INFO] [stderr]    |                                                       ^^^ help: use `dyn`: `dyn Ppu`
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> libnes/src/ppu/attr_table.rs:73:14
[INFO] [stderr]    |
[INFO] [stderr] 73 |         i @ 0...3 => ATTRIBUTE_TABLE_ADDRESSES[i as usize],
[INFO] [stderr]    |              ^^^ help: use `..=` for an inclusive range
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> libnes/src/ppu/mem/mod.rs:18:19
[INFO] [stderr]    |
[INFO] [stderr] 18 |             0x0000...0x2fff => Address::Address(addr),
[INFO] [stderr]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> libnes/src/ppu/mem/mod.rs:19:19
[INFO] [stderr]    |
[INFO] [stderr] 19 |             0x3000...0x3eff => Address::Mirror {
[INFO] [stderr]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> libnes/src/ppu/mem/mod.rs:24:19
[INFO] [stderr]    |
[INFO] [stderr] 24 |             0x3f00...0x3f1f => Address::Address(addr),
[INFO] [stderr]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> libnes/src/ppu/mem/mod.rs:25:19
[INFO] [stderr]    |
[INFO] [stderr] 25 |             0x3f20...0x3fff => Address::Mirror {
[INFO] [stderr]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> libnes/src/ppu/mem/mod.rs:30:19
[INFO] [stderr]    |
[INFO] [stderr] 30 |             0x4000...0x9fff => Address::Mirror {
[INFO] [stderr]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> libnes/src/ppu/nametable.rs:105:14
[INFO] [stderr]     |
[INFO] [stderr] 105 |         i @ 0...3 => NAMETABLE_ADDRESSES[i as usize],
[INFO] [stderr]     |              ^^^ help: use `..=` for an inclusive range
[INFO] [stderr]     |
[INFO] [stderr]     = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]     = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> libnes/src/ppu/pattern_table.rs:103:22
[INFO] [stderr]     |
[INFO] [stderr] 103 |                     0...3 => color_val,
[INFO] [stderr]     |                      ^^^ help: use `..=` for an inclusive range
[INFO] [stderr]     |
[INFO] [stderr]     = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]     = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> libnes/src/ppu/mod.rs:55:14
[INFO] [stderr]    |
[INFO] [stderr] 55 |     mem: Box<PpuMemoryMap>,
[INFO] [stderr]    |              ^^^^^^^^^^^^ help: use `dyn`: `dyn PpuMemoryMap`
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]  --> libnes/src/ev/mod.rs:7:42
[INFO] [stderr]   |
[INFO] [stderr] 7 |     fn subscribe(&mut self, handler: Box<FnMut(&TEvent)>) -> Rc<RefCell<Subject<TEvent>>>;
[INFO] [stderr]   |                                          ^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&TEvent)`
[INFO] [stderr]   |
[INFO] [stderr]   = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]   = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> libnes/src/ev/mod.rs:14:20
[INFO] [stderr]    |
[INFO] [stderr] 14 |     cb: Option<Box<FnMut(&TEvent)>>,
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&TEvent)`
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> libnes/src/ev/mod.rs:20:42
[INFO] [stderr]    |
[INFO] [stderr] 20 |     fn subscribe(&mut self, handler: Box<FnMut(&TEvent)>) -> Rc<RefCell<Subject<TEvent>>> {
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&TEvent)`
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `crate::cpu::Cpu`
[INFO] [stderr]  --> libnes/src/cart/ines.rs:7:5
[INFO] [stderr]   |
[INFO] [stderr] 7 | use crate::cpu::Cpu;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Observable`
[INFO] [stderr]  --> libnes/src/cpu/cpu.rs:9:17
[INFO] [stderr]   |
[INFO] [stderr] 9 | use crate::ev::{Observable, Observer};
[INFO] [stderr]   |                 ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable pattern
[INFO] [stderr]   --> libnes/src/cart/ines.rs:79:9
[INFO] [stderr]    |
[INFO] [stderr] 79 |         _ => return Err(format!("Unexpected non-ASCII sequence in header ID")),
[INFO] [stderr]    |         ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: `#[warn(unreachable_patterns)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable pattern
[INFO] [stderr]   --> libnes/src/cpu/mem/address.rs:30:13
[INFO] [stderr]    |
[INFO] [stderr] 30 |             _ => panic!(format!(
[INFO] [stderr]    |             ^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `num_ram_banks`
[INFO] [stderr]    --> libnes/src/cart/ines.rs:102:9
[INFO] [stderr]     |
[INFO] [stderr] 102 |     let num_ram_banks = match take_elems(cart_data, 8, 1) {
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_num_ram_banks`
[INFO] [stderr]     |
[INFO] [stderr]     = note: `#[warn(unused_variables)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `data`
[INFO] [stderr]    --> libnes/src/cart/ines.rs:110:9
[INFO] [stderr]     |
[INFO] [stderr] 110 |         data @ _ => {}
[INFO] [stderr]     |         ^^^^ help: if this is intentional, prefix it with an underscore: `_data`
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `cpu`
[INFO] [stderr]    --> libnes/src/cpu/instr/instructions/instrs.rs:426:12
[INFO] [stderr]     |
[INFO] [stderr] 426 | pub fn nop(cpu: &mut impl Cpu, addr_mode: AddressingMode) {
[INFO] [stderr]     |            ^^^ help: if this is intentional, prefix it with an underscore: `_cpu`
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `addr_mode`
[INFO] [stderr]    --> libnes/src/cpu/instr/instructions/instrs.rs:426:32
[INFO] [stderr]     |
[INFO] [stderr] 426 | pub fn nop(cpu: &mut impl Cpu, addr_mode: AddressingMode) {
[INFO] [stderr]     |                                ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode`
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `addr_mode`
[INFO] [stderr]    --> libnes/src/cpu/instr/instructions/instrs.rs:442:32
[INFO] [stderr]     |
[INFO] [stderr] 442 | pub fn pha(cpu: &mut impl Cpu, addr_mode: AddressingMode) {
[INFO] [stderr]     |                                ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode`
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `addr_mode`
[INFO] [stderr]    --> libnes/src/cpu/instr/instructions/instrs.rs:448:32
[INFO] [stderr]     |
[INFO] [stderr] 448 | pub fn php(cpu: &mut impl Cpu, addr_mode: AddressingMode) {
[INFO] [stderr]     |                                ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode`
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `addr_mode`
[INFO] [stderr]    --> libnes/src/cpu/instr/instructions/instrs.rs:454:32
[INFO] [stderr]     |
[INFO] [stderr] 454 | pub fn pla(cpu: &mut impl Cpu, addr_mode: AddressingMode) {
[INFO] [stderr]     |                                ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode`
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `addr_mode`
[INFO] [stderr]    --> libnes/src/cpu/instr/instructions/instrs.rs:465:32
[INFO] [stderr]     |
[INFO] [stderr] 465 | pub fn plp(cpu: &mut impl Cpu, addr_mode: AddressingMode) {
[INFO] [stderr]     |                                ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode`
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `addr_mode`
[INFO] [stderr]    --> libnes/src/cpu/instr/instructions/instrs.rs:543:32
[INFO] [stderr]     |
[INFO] [stderr] 543 | pub fn rts(cpu: &mut impl Cpu, addr_mode: AddressingMode) {
[INFO] [stderr]     |                                ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode`
[INFO] [stderr] 
[INFO] [stderr] warning: panic message is not a string literal
[INFO] [stderr]    --> libnes/src/cpu/cpu.rs:124:28
[INFO] [stderr]     |
[INFO] [stderr] 124 |                     panic!(err);
[INFO] [stderr]     |                            ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: `#[warn(non_fmt_panics)]` on by default
[INFO] [stderr]     = note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021
[INFO] [stderr]     = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
[INFO] [stderr] help: add a "{}" format string to Display the message
[INFO] [stderr]     |
[INFO] [stderr] 124 |                     panic!("{}", err);
[INFO] [stderr]     |                            ^^^^^
[INFO] [stderr] help: or use std::panic::panic_any instead
[INFO] [stderr]     |
[INFO] [stderr] 124 |                     std::panic::panic_any(err);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: panic message is not a string literal
[INFO] [stderr]   --> libnes/src/cpu/mem/address.rs:30:25
[INFO] [stderr]    |
[INFO] [stderr] 30 |               _ => panic!(format!(
[INFO] [stderr]    |  _________________________^
[INFO] [stderr] 31 | |                 "Bad address '{:#06x}' while converting from u16 to Address",
[INFO] [stderr] 32 | |                 addr
[INFO] [stderr] 33 | |             )),
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021
[INFO] [stderr]    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
[INFO] [stderr]    = note: the panic!() macro supports formatting, so there's no need for the format!() macro here
[INFO] [stderr] help: remove the `format!(..)` macro call
[INFO] [stderr]    |
[INFO] [stderr] 30 |             _ => panic!(
[INFO] [stderr] 31 |                 "Bad address '{:#06x}' while converting from u16 to Address",
[INFO] [stderr] 32 |                 addr
[INFO] [stderr] 33 |             ),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: panic message is not a string literal
[INFO] [stderr]   --> libnes/src/ppu/mem/mod.rs:35:25
[INFO] [stderr]    |
[INFO] [stderr] 35 |               _ => panic!(format!(
[INFO] [stderr]    |  _________________________^
[INFO] [stderr] 36 | |                 "Bad address '{:#06x}' while converting from u16 to Address",
[INFO] [stderr] 37 | |                 addr
[INFO] [stderr] 38 | |             )),
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021
[INFO] [stderr]    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
[INFO] [stderr]    = note: the panic!() macro supports formatting, so there's no need for the format!() macro here
[INFO] [stderr] help: remove the `format!(..)` macro call
[INFO] [stderr]    |
[INFO] [stderr] 35 |             _ => panic!(
[INFO] [stderr] 36 |                 "Bad address '{:#06x}' while converting from u16 to Address",
[INFO] [stderr] 37 |                 addr
[INFO] [stderr] 38 |             ),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this method call resolves to `<&[T; N] as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to <[T; N] as IntoIterator>::into_iter in Rust 2021.
[INFO] [stderr]   --> libnes/src/ppu/nametable.rs:42:14
[INFO] [stderr]    |
[INFO] [stderr] 42 |             .into_iter()
[INFO] [stderr]    |              ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: `#[warn(array_into_iter)]` on by default
[INFO] [stderr]    = warning: this changes meaning in Rust 2021
[INFO] [stderr]    = note: for more information, see issue #66145 <https://github.com/rust-lang/rust/issues/66145>
[INFO] [stderr] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity
[INFO] [stderr]    |
[INFO] [stderr] 42 |             .iter()
[INFO] [stderr]    |              ^^^^
[INFO] [stderr] help: or use `IntoIterator::into_iter(..)` instead of `.into_iter()` to explicitly iterate by value
[INFO] [stderr]    |
[INFO] [stderr] 40 |         let colors = IntoIterator::into_iter(pattern_table_tile
[INFO] [stderr] 41 |             .get_color_indices())
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: comparison is useless due to type limits
[INFO] [stderr]   --> libnes/src/bits/mod.rs:76:8
[INFO] [stderr]    |
[INFO] [stderr] 76 |     if bit_num < 0 || bit_num > 7 {
[INFO] [stderr]    |        ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: `#[warn(unused_comparisons)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: `libnes` (lib) generated 66 warnings
[INFO] [stderr] warning: `libnes` (lib test) generated 66 warnings (66 duplicates)
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]  --> nes/bin/debugger.rs:9:47
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub fn start_debugger<'a>(cpu_ref: Rc<RefCell<Cpu>>)
[INFO] [stderr]   |                                               ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stderr]   |
[INFO] [stderr]   = note: `#[warn(bare_trait_objects)]` on by default
[INFO] [stderr]   = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]   = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> nes/bin/gui.rs:20:21
[INFO] [stderr]    |
[INFO] [stderr] 20 |     nes: Rc<RefCell<Nes>>,
[INFO] [stderr]    |                     ^^^ help: use `dyn`: `dyn Nes`
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> nes/bin/gui.rs:93:34
[INFO] [stderr]    |
[INFO] [stderr] 93 | pub fn start_gui(nes: Rc<RefCell<Nes>>) {
[INFO] [stderr]    |                                  ^^^ help: use `dyn`: `dyn Nes`
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `libnes::cpu::mem::CpuMemoryAccessEvent`
[INFO] [stderr]   --> nes/bin/mod.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 | use libnes::cpu::mem::CpuMemoryAccessEvent;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: `#[warn(unused_imports)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]    --> nes/bin/mod.rs:102:25
[INFO] [stderr]     |
[INFO] [stderr] 102 |     let cpu: Rc<RefCell<Cpu>> = nes.clone().borrow_mut().get_cpu().clone();
[INFO] [stderr]     |                         ^^^ help: use `dyn`: `dyn Cpu`
[INFO] [stderr]     |
[INFO] [stderr]     = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]     = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Ppu`
[INFO] [stderr]   --> nes/bin/mod.rs:23:31
[INFO] [stderr]    |
[INFO] [stderr] 23 | use libnes::ppu::{DefaultPpu, Ppu};
[INFO] [stderr]    |                               ^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variable `index` is assigned to, but never used
[INFO] [stderr]   --> nes/bin/gui.rs:48:21
[INFO] [stderr]    |
[INFO] [stderr] 48 |             let mut index = 0;
[INFO] [stderr]    |                     ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: `#[warn(unused_variables)]` on by default
[INFO] [stderr]    = note: consider using `_index` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `nametable_draw_tile_index`
[INFO] [stderr]   --> nes/bin/gui.rs:35:13
[INFO] [stderr]    |
[INFO] [stderr] 35 |         let nametable_draw_tile_index = self.debug.nametable_tile_index;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_nametable_draw_tile_index`
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `args`
[INFO] [stderr]   --> nes/bin/gui.rs:87:26
[INFO] [stderr]    |
[INFO] [stderr] 87 |     fn update(&mut self, args: &UpdateArgs) {
[INFO] [stderr]    |                          ^^^^ help: if this is intentional, prefix it with an underscore: `_args`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> nes/bin/gui.rs:33:13
[INFO] [stderr]    |
[INFO] [stderr] 33 |         let mut ppu = nes.get_ppu();
[INFO] [stderr]    |             ----^^^
[INFO] [stderr]    |             |
[INFO] [stderr]    |             help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: `#[warn(unused_mut)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: panic message is not a string literal
[INFO] [stderr]   --> nes/bin/mod.rs:79:21
[INFO] [stderr]    |
[INFO] [stderr] 79 |         _ => panic!(format!("Unsupported rom format '{}'", rom_format_str)),
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: `#[warn(non_fmt_panics)]` on by default
[INFO] [stderr]    = note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021
[INFO] [stderr]    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
[INFO] [stderr]    = note: the panic!() macro supports formatting, so there's no need for the format!() macro here
[INFO] [stderr] help: remove the `format!(..)` macro call
[INFO] [stderr]    |
[INFO] [stderr] 79 |         _ => panic!("Unsupported rom format '{}'", rom_format_str),
[INFO] [stderr]    |                    --                                           --
[INFO] [stderr] 
[INFO] [stderr] warning: `nes` (bin "nes" test) generated 11 warnings
[INFO] [stderr]     Finished test [unoptimized + debuginfo] target(s) in 0.24s
[INFO] [stdout] 
[INFO] [stderr]      Running unittests (/opt/rustwide/target/debug/deps/libnes-590a595ab3b84f8e)
[INFO] [stdout] running 18 tests
[INFO] [stdout] test bits::test::can_get_bit ... ok
[INFO] [stdout] test bits::test::can_rotate_left ... ok
[INFO] [stdout] test cpu::tests::klaus ... ignored
[INFO] [stdout] test cpu::tests::jsr_lda_rts ... ok
[INFO] [stderr]      Running unittests (/opt/rustwide/target/debug/deps/nes-6392f4945ba0dc07)
[INFO] [stdout] test cpu::tests::ldx_dex_stx_cpx_bnx ... ok
[INFO] [stdout] test cpu::tests::lda_tax_inx_adc ... ok
[INFO] [stdout] test cpu::tests::lda_sta_lda_sta_jmp ... ok
[INFO] [stdout] test bits::test::can_set_bit ... ok
[INFO] [stdout] test bits::test::can_rotate_right ... ok
[INFO] [stdout] test cpu::tests::basic_program ... ok
[INFO] [stdout] test cpu::tests::snake ... ignored
[INFO] [stdout] test ev::test::can_subscribe ... ok
[INFO] [stdout] test cpu::tests::rol_acc ... ok
[INFO] [stdout] test cpu::tests::ror_mem ... ok
[INFO] [stdout] test ev::test::can_subscribe_mult ... ok
[INFO] [stdout] test cpu::tests::ror_acc ... ok
[INFO] [stdout] test cpu::tests::lda_cmp_bne_sta_brk ... ok
[INFO] [stdout] test cpu::tests::rol_mem ... ok
[INFO] [stdout] 
[INFO] [stdout] test result: ok. 16 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out; finished in 0.01s
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] running 0 tests
[INFO] [stdout] 
[INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
[INFO] [stdout] 
[INFO] [stderr]    Doc-tests libnes
[INFO] [stderr] warning: type `iNESLoader` should have an upper camel case name
[INFO] [stderr]   --> /opt/rustwide/workdir/libnes/src/cart/ines.rs:16:12
[INFO] [stderr]    |
[INFO] [stderr] 16 | pub struct iNESLoader {}
[INFO] [stderr]    |            ^^^^^^^^^^ help: convert the identifier to upper camel case: `INesloader`
[INFO] [stderr]    |
[INFO] [stderr]    = note: `#[warn(non_camel_case_types)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: type `iNESHeader` should have an upper camel case name
[INFO] [stderr]    --> /opt/rustwide/workdir/libnes/src/cart/ines.rs:127:8
[INFO] [stderr]     |
[INFO] [stderr] 127 | struct iNESHeader {
[INFO] [stderr]     |        ^^^^^^^^^^ help: convert the identifier to upper camel case: `INesheader`
[INFO] [stderr] 
[INFO] [stderr] warning: variant `iNes` should have an upper camel case name
[INFO] [stderr]   --> /opt/rustwide/workdir/libnes/src/cart/mod.rs:28:5
[INFO] [stderr]    |
[INFO] [stderr] 28 |     iNes,
[INFO] [stderr]    |     ^^^^ help: convert the identifier to upper camel case (notice the capitalization): `INes`
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> /opt/rustwide/workdir/libnes/src/cpu/mem/address.rs:17:19
[INFO] [stderr]    |
[INFO] [stderr] 17 |             0x0000...0x07ff => Address::Address(addr),
[INFO] [stderr]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr]    |
[INFO] [stderr]    = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> /opt/rustwide/workdir/libnes/src/cpu/mem/address.rs:18:19
[INFO] [stderr]    |
[INFO] [stderr] 18 |             0x0800...0x1fff => Address::Mirror {
[INFO] [stderr]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> /opt/rustwide/workdir/libnes/src/cpu/mem/address.rs:23:19
[INFO] [stderr]    |
[INFO] [stderr] 23 |             0x2000...0x2007 => Address::Address(addr),
[INFO] [stderr]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> /opt/rustwide/workdir/libnes/src/cpu/mem/address.rs:24:19
[INFO] [stderr]    |
[INFO] [stderr] 24 |             0x2008...0x3fff => Address::Mirror {
[INFO] [stderr]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> /opt/rustwide/workdir/libnes/src/cpu/mem/address.rs:29:19
[INFO] [stderr]    |
[INFO] [stderr] 29 |             0x4000...0xffff => Address::Address(addr),
[INFO] [stderr]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> /opt/rustwide/workdir/libnes/src/ppu/attr_table.rs:73:14
[INFO] [stderr]    |
[INFO] [stderr] 73 |         i @ 0...3 => ATTRIBUTE_TABLE_ADDRESSES[i as usize],
[INFO] [stderr]    |              ^^^ help: use `..=` for an inclusive range
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> /opt/rustwide/workdir/libnes/src/ppu/mem/mod.rs:18:19
[INFO] [stderr]    |
[INFO] [stderr] 18 |             0x0000...0x2fff => Address::Address(addr),
[INFO] [stderr]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> /opt/rustwide/workdir/libnes/src/ppu/mem/mod.rs:19:19
[INFO] [stderr]    |
[INFO] [stderr] 19 |             0x3000...0x3eff => Address::Mirror {
[INFO] [stderr]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> /opt/rustwide/workdir/libnes/src/ppu/mem/mod.rs:24:19
[INFO] [stderr]    |
[INFO] [stderr] 24 |             0x3f00...0x3f1f => Address::Address(addr),
[INFO] [stderr]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> /opt/rustwide/workdir/libnes/src/ppu/mem/mod.rs:25:19
[INFO] [stderr]    |
[INFO] [stderr] 25 |             0x3f20...0x3fff => Address::Mirror {
[INFO] [stderr]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> /opt/rustwide/workdir/libnes/src/ppu/mem/mod.rs:30:19
[INFO] [stderr]    |
[INFO] [stderr] 30 |             0x4000...0x9fff => Address::Mirror {
[INFO] [stderr]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]    = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> /opt/rustwide/workdir/libnes/src/ppu/nametable.rs:105:14
[INFO] [stderr]     |
[INFO] [stderr] 105 |         i @ 0...3 => NAMETABLE_ADDRESSES[i as usize],
[INFO] [stderr]     |              ^^^ help: use `..=` for an inclusive range
[INFO] [stderr]     |
[INFO] [stderr]     = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]     = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> /opt/rustwide/workdir/libnes/src/ppu/pattern_table.rs:103:22
[INFO] [stderr]     |
[INFO] [stderr] 103 |                     0...3 => color_val,
[INFO] [stderr]     |                      ^^^ help: use `..=` for an inclusive range
[INFO] [stderr]     |
[INFO] [stderr]     = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stderr]     = note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165>
[INFO] [stderr] 
[INFO] [stderr] warning: 16 warnings emitted
[INFO] [stderr] 
[INFO] [stdout] 
[INFO] [stdout] running 0 tests
[INFO] [stdout] 
[INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
[INFO] [stdout] 
[INFO] running `Command { std: "docker" "inspect" "f76afde61252b36fd68622c848e47fdbe22b1536e39ee656973297c189621033", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "f76afde61252b36fd68622c848e47fdbe22b1536e39ee656973297c189621033", kill_on_drop: false }`
[INFO] [stdout] f76afde61252b36fd68622c848e47fdbe22b1536e39ee656973297c189621033
