[INFO] updating cached repository https://github.com/christopherjmedlin/hackman [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune", kill_on_drop: false }` [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 116a625552d35f2f8a7bd06f69005ef7283238b0 [INFO] testing christopherjmedlin/hackman against beta-2020-07-24 for beta-1.46-1 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchristopherjmedlin%2Fhackman" "/workspace/builds/worker-13/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-13/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/christopherjmedlin/hackman on toolchain beta-2020-07-24 [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+beta-2020-07-24" "read-manifest" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/christopherjmedlin/hackman [INFO] finished tweaking git repo https://github.com/christopherjmedlin/hackman [INFO] tweaked toml for git repo https://github.com/christopherjmedlin/hackman written to /workspace/builds/worker-13/source/Cargo.toml [INFO] crate git repo https://github.com/christopherjmedlin/hackman already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+beta-2020-07-24" "fetch" "--locked" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-13/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-13/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "MAP_USER_ID=0" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--network" "none" "rustops/crates-build-env@sha256:a636fd89d022f18117e1dc8fb37a0a009933cdbbe082814857f0e2024962d47c" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2020-07-24" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8d59e9488a670e4bba6b242cd0ea2fb1a78e1c61924c54daadea500d7dd48d18 [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] running `Command { std: "docker" "start" "-a" "8d59e9488a670e4bba6b242cd0ea2fb1a78e1c61924c54daadea500d7dd48d18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8d59e9488a670e4bba6b242cd0ea2fb1a78e1c61924c54daadea500d7dd48d18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8d59e9488a670e4bba6b242cd0ea2fb1a78e1c61924c54daadea500d7dd48d18", kill_on_drop: false }` [INFO] [stdout] 8d59e9488a670e4bba6b242cd0ea2fb1a78e1c61924c54daadea500d7dd48d18 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-13/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-13/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "MAP_USER_ID=0" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--network" "none" "rustops/crates-build-env@sha256:a636fd89d022f18117e1dc8fb37a0a009933cdbbe082814857f0e2024962d47c" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2020-07-24" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bee1b1250ec4ca46d7a6b6177306226967212e9151716919108c23c0d8988409 [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] running `Command { std: "docker" "start" "-a" "bee1b1250ec4ca46d7a6b6177306226967212e9151716919108c23c0d8988409", kill_on_drop: false }` [INFO] [stderr] Compiling rand v0.4.6 [INFO] [stderr] Compiling rand v0.3.23 [INFO] [stderr] Compiling sdl2 v0.31.0 [INFO] [stderr] Compiling pacman v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:49:22 [INFO] [stdout] | [INFO] [stdout] 49 | memory: &mut Memory, [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:50:18 [INFO] [stdout] | [INFO] [stdout] 50 | io: &mut InputOutput, [INFO] [stdout] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:73:22 [INFO] [stdout] | [INFO] [stdout] 73 | memory: &mut Memory, [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:74:18 [INFO] [stdout] | [INFO] [stdout] 74 | io: &mut InputOutput, [INFO] [stdout] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/cpu/mod.rs:134:18 [INFO] [stdout] | [INFO] [stdout] 134 | (0, 4...7, 0) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:539:46 [INFO] [stdout] | [INFO] [stdout] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:539:63 [INFO] [stdout] | [INFO] [stdout] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stdout] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:626:58 [INFO] [stdout] | [INFO] [stdout] 626 | fn run_ed_opcode(&mut self, opcode: u8, memory: &mut Memory, io: &mut InputOutput) -> usize { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:626:75 [INFO] [stdout] | [INFO] [stdout] 626 | fn run_ed_opcode(&mut self, opcode: u8, memory: &mut Memory, io: &mut InputOutput) -> usize { [INFO] [stdout] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/cpu/mod.rs:782:21 [INFO] [stdout] | [INFO] [stdout] 782 | (2, _, 0...3) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:792:42 [INFO] [stdout] | [INFO] [stdout] 792 | fn r(&mut self, index: u8, mem: &mut Memory) -> u8 { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:800:58 [INFO] [stdout] | [INFO] [stdout] 800 | fn write_r(&mut self, index: u8, byte: u8, mem: &mut Memory) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:808:47 [INFO] [stdout] | [INFO] [stdout] 808 | fn bli(&mut self, a: u8, b: u8, mem: &mut Memory, io: &mut InputOutput) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:808:64 [INFO] [stdout] | [INFO] [stdout] 808 | fn bli(&mut self, a: u8, b: u8, mem: &mut Memory, io: &mut InputOutput) { [INFO] [stdout] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:952:42 [INFO] [stdout] | [INFO] [stdout] 952 | fn load_inc_dec(&mut self, mem: &mut Memory, inc: bool) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:974:42 [INFO] [stdout] | [INFO] [stdout] 974 | fn comp_inc_dec(&mut self, mem: &mut Memory, inc: bool) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1274:42 [INFO] [stdout] | [INFO] [stdout] 1274 | fn dec_8(&mut self, y: u8, mem: &mut Memory) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1288:42 [INFO] [stdout] | [INFO] [stdout] 1288 | fn inc_8(&mut self, y: u8, mem: &mut Memory) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1303:34 [INFO] [stdout] | [INFO] [stdout] 1303 | fn call(&mut self, mem: &mut Memory, addr: u16) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1310:33 [INFO] [stdout] | [INFO] [stdout] 1310 | fn ret(&mut self, mem: &mut Memory) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1316:39 [INFO] [stdout] | [INFO] [stdout] 1316 | fn pop_stack(&mut self, mem: &mut Memory) -> u8 { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1324:40 [INFO] [stdout] | [INFO] [stdout] 1324 | fn push_stack(&mut self, mem: &mut Memory, byte: u8) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1333:43 [INFO] [stdout] | [INFO] [stdout] 1333 | fn push_stack_16(&mut self, mem: &mut Memory, word: u16) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1338:42 [INFO] [stdout] | [INFO] [stdout] 1338 | fn pop_stack_16(&mut self, mem: &mut Memory) -> u16 { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:74:24 [INFO] [stdout] | [INFO] [stdout] 74 | (GAME_ROM_START...GAME_ROM_END, false) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:78:24 [INFO] [stdout] | [INFO] [stdout] 78 | (GAME_ROM_START...GAME_ROM_END, true) => Err("Cannot write to ROM."), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:80:26 [INFO] [stdout] | [INFO] [stdout] 80 | (VRAM_TILES_START...VRAM_TILES_END, _) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:84:29 [INFO] [stdout] | [INFO] [stdout] 84 | (VRAM_PALETTES_START...VRAM_PALETTES_END, _) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:88:19 [INFO] [stdout] | [INFO] [stdout] 88 | (RAM_START...RAM_END, _) => Ok(Address::Ram((addr - RAM_START) as usize)), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:90:28 [INFO] [stdout] | [INFO] [stdout] 90 | (VRAM_SPRITES_START...VRAM_SPRITES_END, _) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:94:28 [INFO] [stdout] | [INFO] [stdout] 94 | (IN0_REGISTER_START...IN0_REGISTER_END, false) => Ok(Address::IN0Register), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:105:28 [INFO] [stdout] | [INFO] [stdout] 105 | (IN1_REGISTER_START...IN1_REGISTER_END, false) => Ok(Address::IN1Register), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:107:21 [INFO] [stdout] | [INFO] [stdout] 107 | (SOUND_START...SOUND_END, true) => Ok(Address::Sound((addr - SOUND_START) as usize)), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:109:25 [INFO] [stdout] | [INFO] [stdout] 109 | (SPRITE_XY_START...SPRITE_XY_END, true) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:113:26 [INFO] [stdout] | [INFO] [stdout] 113 | (DIP_SWITCH_START...DIP_SWITCH_END, _) => Ok(Address::DipSwitchRegister), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:115:24 [INFO] [stdout] | [INFO] [stdout] 115 | (WATCHDOG_START...WATCHDOG_END, _) => Ok(Address::WatchdogTimerReset), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/memory_mapper.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::boxed::Box` [INFO] [stdout] --> src/memory_mapper.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | use std::boxed::Box; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: denote infinite loops with `loop { ... }` [INFO] [stdout] --> src/pacman.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | while true { [INFO] [stdout] | ^^^^^^^^^^ help: use `loop` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(while_true)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/main.rs:9:13 [INFO] [stdout] | [INFO] [stdout] 9 | #[macro_use(matches)] [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/cpu/mod.rs:912:13 [INFO] [stdout] | [INFO] [stdout] 912 | (5, 2) => { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/cpu/mod.rs:919:13 [INFO] [stdout] | [INFO] [stdout] 919 | (6, 2) => { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/cpu/mod.rs:933:13 [INFO] [stdout] | [INFO] [stdout] 933 | (7, 2) => { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/cpu/mod.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | for i in 0..iters { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `io` [INFO] [stdout] --> src/cpu/mod.rs:539:54 [INFO] [stdout] | [INFO] [stdout] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_io` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `number_of_ones` is assigned to, but never used [INFO] [stdout] --> src/cpu/mod.rs:1381:13 [INFO] [stdout] | [INFO] [stdout] 1381 | let mut number_of_ones = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_number_of_ones` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/cpu/io.rs:21:21 [INFO] [stdout] | [INFO] [stdout] 21 | fn input(&self, port: u8) -> u8 { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/cpu/io.rs:25:26 [INFO] [stdout] | [INFO] [stdout] 25 | fn output(&mut self, port: u8, byte: u8) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/display.rs:49:21 [INFO] [stdout] | [INFO] [stdout] 49 | let result = canvas.fill_rect(Rect::new(x_coord, y_coord, 2, 2)); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x_flip` [INFO] [stdout] --> src/display.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | x_flip: bool, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_x_flip` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y_flip` [INFO] [stdout] --> src/display.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | y_flip: bool, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_y_flip` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/interrupt_vector.rs:14:21 [INFO] [stdout] | [INFO] [stdout] 14 | fn input(&self, port: u8) -> u8 { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/interrupt_vector.rs:18:26 [INFO] [stdout] | [INFO] [stdout] 18 | fn output(&mut self, port: u8, byte: u8) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `color` [INFO] [stdout] --> src/rom.rs:104:17 [INFO] [stdout] | [INFO] [stdout] 104 | let color = self.color_rom[*byte as usize]; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_color` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `why` [INFO] [stdout] --> src/rom.rs:137:17 [INFO] [stdout] | [INFO] [stdout] 137 | Err(why) => panic!("Missing ROMs"), [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_why` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `why` [INFO] [stdout] --> src/rom.rs:142:17 [INFO] [stdout] | [INFO] [stdout] 142 | Err(why) => panic!("Error reading ROM"), [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_why` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/mod.rs:1145:13 [INFO] [stdout] | [INFO] [stdout] 1145 | let mut result = left.wrapping_sub(right); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/mod.rs:1347:13 [INFO] [stdout] | [INFO] [stdout] 1347 | let mut left = left + (carry as u8); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/mod.rs:1354:13 [INFO] [stdout] | [INFO] [stdout] 1354 | let mut left = left - (carry as u8); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `new` [INFO] [stdout] --> src/cpu/io.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `new` [INFO] [stdout] --> src/cpu/mem.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `draw_sprite` [INFO] [stdout] --> src/display.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn draw_sprite(&mut self, x: usize, y: usize, sprite: usize, palette: usize) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `VramPalettes` [INFO] [stdout] --> src/memory_map.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | VramPalettes(usize), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `roms` [INFO] [stdout] --> src/pacman.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | roms: &'a Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 64 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.74s [INFO] running `Command { std: "docker" "inspect" "bee1b1250ec4ca46d7a6b6177306226967212e9151716919108c23c0d8988409", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bee1b1250ec4ca46d7a6b6177306226967212e9151716919108c23c0d8988409", kill_on_drop: false }` [INFO] [stdout] bee1b1250ec4ca46d7a6b6177306226967212e9151716919108c23c0d8988409 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-13/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-13/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "MAP_USER_ID=0" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--network" "none" "rustops/crates-build-env@sha256:a636fd89d022f18117e1dc8fb37a0a009933cdbbe082814857f0e2024962d47c" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2020-07-24" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f6cb7fdb9948c196c1096177e85c913c62a155b3aaae0499dc5073c6c6b2504a [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] running `Command { std: "docker" "start" "-a" "f6cb7fdb9948c196c1096177e85c913c62a155b3aaae0499dc5073c6c6b2504a", kill_on_drop: false }` [INFO] [stderr] Compiling pacman v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:49:22 [INFO] [stdout] | [INFO] [stdout] 49 | memory: &mut Memory, [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:50:18 [INFO] [stdout] | [INFO] [stdout] 50 | io: &mut InputOutput, [INFO] [stdout] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:73:22 [INFO] [stdout] | [INFO] [stdout] 73 | memory: &mut Memory, [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:74:18 [INFO] [stdout] | [INFO] [stdout] 74 | io: &mut InputOutput, [INFO] [stdout] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/cpu/mod.rs:134:18 [INFO] [stdout] | [INFO] [stdout] 134 | (0, 4...7, 0) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:539:46 [INFO] [stdout] | [INFO] [stdout] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:539:63 [INFO] [stdout] | [INFO] [stdout] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stdout] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:626:58 [INFO] [stdout] | [INFO] [stdout] 626 | fn run_ed_opcode(&mut self, opcode: u8, memory: &mut Memory, io: &mut InputOutput) -> usize { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:626:75 [INFO] [stdout] | [INFO] [stdout] 626 | fn run_ed_opcode(&mut self, opcode: u8, memory: &mut Memory, io: &mut InputOutput) -> usize { [INFO] [stdout] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/cpu/mod.rs:782:21 [INFO] [stdout] | [INFO] [stdout] 782 | (2, _, 0...3) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:792:42 [INFO] [stdout] | [INFO] [stdout] 792 | fn r(&mut self, index: u8, mem: &mut Memory) -> u8 { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:800:58 [INFO] [stdout] | [INFO] [stdout] 800 | fn write_r(&mut self, index: u8, byte: u8, mem: &mut Memory) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:808:47 [INFO] [stdout] | [INFO] [stdout] 808 | fn bli(&mut self, a: u8, b: u8, mem: &mut Memory, io: &mut InputOutput) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:808:64 [INFO] [stdout] | [INFO] [stdout] 808 | fn bli(&mut self, a: u8, b: u8, mem: &mut Memory, io: &mut InputOutput) { [INFO] [stdout] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:952:42 [INFO] [stdout] | [INFO] [stdout] 952 | fn load_inc_dec(&mut self, mem: &mut Memory, inc: bool) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:974:42 [INFO] [stdout] | [INFO] [stdout] 974 | fn comp_inc_dec(&mut self, mem: &mut Memory, inc: bool) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1274:42 [INFO] [stdout] | [INFO] [stdout] 1274 | fn dec_8(&mut self, y: u8, mem: &mut Memory) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1288:42 [INFO] [stdout] | [INFO] [stdout] 1288 | fn inc_8(&mut self, y: u8, mem: &mut Memory) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1303:34 [INFO] [stdout] | [INFO] [stdout] 1303 | fn call(&mut self, mem: &mut Memory, addr: u16) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1310:33 [INFO] [stdout] | [INFO] [stdout] 1310 | fn ret(&mut self, mem: &mut Memory) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1316:39 [INFO] [stdout] | [INFO] [stdout] 1316 | fn pop_stack(&mut self, mem: &mut Memory) -> u8 { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1324:40 [INFO] [stdout] | [INFO] [stdout] 1324 | fn push_stack(&mut self, mem: &mut Memory, byte: u8) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1333:43 [INFO] [stdout] | [INFO] [stdout] 1333 | fn push_stack_16(&mut self, mem: &mut Memory, word: u16) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1338:42 [INFO] [stdout] | [INFO] [stdout] 1338 | fn pop_stack_16(&mut self, mem: &mut Memory) -> u16 { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/cpu/tests.rs:258:22 [INFO] [stdout] | [INFO] [stdout] 258 | cpu.reg.sp = 100;; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:74:24 [INFO] [stdout] | [INFO] [stdout] 74 | (GAME_ROM_START...GAME_ROM_END, false) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:78:24 [INFO] [stdout] | [INFO] [stdout] 78 | (GAME_ROM_START...GAME_ROM_END, true) => Err("Cannot write to ROM."), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:80:26 [INFO] [stdout] | [INFO] [stdout] 80 | (VRAM_TILES_START...VRAM_TILES_END, _) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:84:29 [INFO] [stdout] | [INFO] [stdout] 84 | (VRAM_PALETTES_START...VRAM_PALETTES_END, _) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:88:19 [INFO] [stdout] | [INFO] [stdout] 88 | (RAM_START...RAM_END, _) => Ok(Address::Ram((addr - RAM_START) as usize)), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:90:28 [INFO] [stdout] | [INFO] [stdout] 90 | (VRAM_SPRITES_START...VRAM_SPRITES_END, _) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:94:28 [INFO] [stdout] | [INFO] [stdout] 94 | (IN0_REGISTER_START...IN0_REGISTER_END, false) => Ok(Address::IN0Register), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:105:28 [INFO] [stdout] | [INFO] [stdout] 105 | (IN1_REGISTER_START...IN1_REGISTER_END, false) => Ok(Address::IN1Register), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:107:21 [INFO] [stdout] | [INFO] [stdout] 107 | (SOUND_START...SOUND_END, true) => Ok(Address::Sound((addr - SOUND_START) as usize)), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:109:25 [INFO] [stdout] | [INFO] [stdout] 109 | (SPRITE_XY_START...SPRITE_XY_END, true) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:113:26 [INFO] [stdout] | [INFO] [stdout] 113 | (DIP_SWITCH_START...DIP_SWITCH_END, _) => Ok(Address::DipSwitchRegister), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:115:24 [INFO] [stdout] | [INFO] [stdout] 115 | (WATCHDOG_START...WATCHDOG_END, _) => Ok(Address::WatchdogTimerReset), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: denote infinite loops with `loop { ... }` [INFO] [stdout] --> src/pacman.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | while true { [INFO] [stdout] | ^^^^^^^^^^ help: use `loop` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(while_true)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/cpu/mod.rs:912:13 [INFO] [stdout] | [INFO] [stdout] 912 | (5, 2) => { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/cpu/mod.rs:919:13 [INFO] [stdout] | [INFO] [stdout] 919 | (6, 2) => { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/cpu/mod.rs:933:13 [INFO] [stdout] | [INFO] [stdout] 933 | (7, 2) => { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/cpu/mod.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | for i in 0..iters { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `io` [INFO] [stdout] --> src/cpu/mod.rs:539:54 [INFO] [stdout] | [INFO] [stdout] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_io` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `number_of_ones` is assigned to, but never used [INFO] [stdout] --> src/cpu/mod.rs:1381:13 [INFO] [stdout] | [INFO] [stdout] 1381 | let mut number_of_ones = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_number_of_ones` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/cpu/io.rs:21:21 [INFO] [stdout] | [INFO] [stdout] 21 | fn input(&self, port: u8) -> u8 { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/cpu/io.rs:25:26 [INFO] [stdout] | [INFO] [stdout] 25 | fn output(&mut self, port: u8, byte: u8) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mem` [INFO] [stdout] --> src/cpu/tests.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | let mut mem = &mut TestMemory::new(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_mem` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/display.rs:49:21 [INFO] [stdout] | [INFO] [stdout] 49 | let result = canvas.fill_rect(Rect::new(x_coord, y_coord, 2, 2)); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x_flip` [INFO] [stdout] --> src/display.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | x_flip: bool, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_x_flip` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y_flip` [INFO] [stdout] --> src/display.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | y_flip: bool, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_y_flip` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/interrupt_vector.rs:14:21 [INFO] [stdout] | [INFO] [stdout] 14 | fn input(&self, port: u8) -> u8 { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/interrupt_vector.rs:18:26 [INFO] [stdout] | [INFO] [stdout] 18 | fn output(&mut self, port: u8, byte: u8) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `color` [INFO] [stdout] --> src/rom.rs:104:17 [INFO] [stdout] | [INFO] [stdout] 104 | let color = self.color_rom[*byte as usize]; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_color` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `why` [INFO] [stdout] --> src/rom.rs:137:17 [INFO] [stdout] | [INFO] [stdout] 137 | Err(why) => panic!("Missing ROMs"), [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_why` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `why` [INFO] [stdout] --> src/rom.rs:142:17 [INFO] [stdout] | [INFO] [stdout] 142 | Err(why) => panic!("Error reading ROM"), [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_why` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/mod.rs:1145:13 [INFO] [stdout] | [INFO] [stdout] 1145 | let mut result = left.wrapping_sub(right); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/mod.rs:1347:13 [INFO] [stdout] | [INFO] [stdout] 1347 | let mut left = left + (carry as u8); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/mod.rs:1354:13 [INFO] [stdout] | [INFO] [stdout] 1354 | let mut left = left - (carry as u8); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/tests.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | let mut mem = &mut TestMemory::new(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `draw_sprite` [INFO] [stdout] --> src/display.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn draw_sprite(&mut self, x: usize, y: usize, sprite: usize, palette: usize) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `VramPalettes` [INFO] [stdout] --> src/memory_map.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | VramPalettes(usize), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `roms` [INFO] [stdout] --> src/pacman.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | roms: &'a Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 62 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 2.16s [INFO] running `Command { std: "docker" "inspect" "f6cb7fdb9948c196c1096177e85c913c62a155b3aaae0499dc5073c6c6b2504a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f6cb7fdb9948c196c1096177e85c913c62a155b3aaae0499dc5073c6c6b2504a", kill_on_drop: false }` [INFO] [stdout] f6cb7fdb9948c196c1096177e85c913c62a155b3aaae0499dc5073c6c6b2504a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-13/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-13/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "MAP_USER_ID=0" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--network" "none" "rustops/crates-build-env@sha256:a636fd89d022f18117e1dc8fb37a0a009933cdbbe082814857f0e2024962d47c" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2020-07-24" "test" "--frozen", kill_on_drop: false }` [INFO] [stdout] 5e946f0f65ed25439c8bb242fa698d1b575adcbb3dd1ef02807064b36042100e [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] running `Command { std: "docker" "start" "-a" "5e946f0f65ed25439c8bb242fa698d1b575adcbb3dd1ef02807064b36042100e", kill_on_drop: false }` [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:49:22 [INFO] [stderr] | [INFO] [stderr] 49 | memory: &mut Memory, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:50:18 [INFO] [stderr] | [INFO] [stderr] 50 | io: &mut InputOutput, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:73:22 [INFO] [stderr] | [INFO] [stderr] 73 | memory: &mut Memory, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:74:18 [INFO] [stderr] | [INFO] [stderr] 74 | io: &mut InputOutput, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mod.rs:134:18 [INFO] [stderr] | [INFO] [stderr] 134 | (0, 4...7, 0) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:539:46 [INFO] [stderr] | [INFO] [stderr] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:539:63 [INFO] [stderr] | [INFO] [stderr] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:626:58 [INFO] [stderr] | [INFO] [stderr] 626 | fn run_ed_opcode(&mut self, opcode: u8, memory: &mut Memory, io: &mut InputOutput) -> usize { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:626:75 [INFO] [stderr] | [INFO] [stderr] 626 | fn run_ed_opcode(&mut self, opcode: u8, memory: &mut Memory, io: &mut InputOutput) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mod.rs:782:21 [INFO] [stderr] | [INFO] [stderr] 782 | (2, _, 0...3) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:792:42 [INFO] [stderr] | [INFO] [stderr] 792 | fn r(&mut self, index: u8, mem: &mut Memory) -> u8 { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:800:58 [INFO] [stderr] | [INFO] [stderr] 800 | fn write_r(&mut self, index: u8, byte: u8, mem: &mut Memory) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:808:47 [INFO] [stderr] | [INFO] [stderr] 808 | fn bli(&mut self, a: u8, b: u8, mem: &mut Memory, io: &mut InputOutput) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:808:64 [INFO] [stderr] | [INFO] [stderr] 808 | fn bli(&mut self, a: u8, b: u8, mem: &mut Memory, io: &mut InputOutput) { [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:952:42 [INFO] [stderr] | [INFO] [stderr] 952 | fn load_inc_dec(&mut self, mem: &mut Memory, inc: bool) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:974:42 [INFO] [stderr] | [INFO] [stderr] 974 | fn comp_inc_dec(&mut self, mem: &mut Memory, inc: bool) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1274:42 [INFO] [stderr] | [INFO] [stderr] 1274 | fn dec_8(&mut self, y: u8, mem: &mut Memory) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1288:42 [INFO] [stderr] | [INFO] [stderr] 1288 | fn inc_8(&mut self, y: u8, mem: &mut Memory) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1303:34 [INFO] [stderr] | [INFO] [stderr] 1303 | fn call(&mut self, mem: &mut Memory, addr: u16) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1310:33 [INFO] [stderr] | [INFO] [stderr] 1310 | fn ret(&mut self, mem: &mut Memory) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1316:39 [INFO] [stderr] | [INFO] [stderr] 1316 | fn pop_stack(&mut self, mem: &mut Memory) -> u8 { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1324:40 [INFO] [stderr] | [INFO] [stderr] 1324 | fn push_stack(&mut self, mem: &mut Memory, byte: u8) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1333:43 [INFO] [stderr] | [INFO] [stderr] 1333 | fn push_stack_16(&mut self, mem: &mut Memory, word: u16) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1338:42 [INFO] [stderr] | [INFO] [stderr] 1338 | fn pop_stack_16(&mut self, mem: &mut Memory) -> u16 { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: unnecessary trailing semicolon [INFO] [stderr] --> src/cpu/tests.rs:258:22 [INFO] [stderr] | [INFO] [stderr] 258 | cpu.reg.sp = 100;; [INFO] [stderr] | ^ help: remove this semicolon [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:74:24 [INFO] [stderr] | [INFO] [stderr] 74 | (GAME_ROM_START...GAME_ROM_END, false) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:78:24 [INFO] [stderr] | [INFO] [stderr] 78 | (GAME_ROM_START...GAME_ROM_END, true) => Err("Cannot write to ROM."), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:80:26 [INFO] [stderr] | [INFO] [stderr] 80 | (VRAM_TILES_START...VRAM_TILES_END, _) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:84:29 [INFO] [stderr] | [INFO] [stderr] 84 | (VRAM_PALETTES_START...VRAM_PALETTES_END, _) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:88:19 [INFO] [stderr] | [INFO] [stderr] 88 | (RAM_START...RAM_END, _) => Ok(Address::Ram((addr - RAM_START) as usize)), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:90:28 [INFO] [stderr] | [INFO] [stderr] 90 | (VRAM_SPRITES_START...VRAM_SPRITES_END, _) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:94:28 [INFO] [stderr] | [INFO] [stderr] 94 | (IN0_REGISTER_START...IN0_REGISTER_END, false) => Ok(Address::IN0Register), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:105:28 [INFO] [stderr] | [INFO] [stderr] 105 | (IN1_REGISTER_START...IN1_REGISTER_END, false) => Ok(Address::IN1Register), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:107:21 [INFO] [stderr] | [INFO] [stderr] 107 | (SOUND_START...SOUND_END, true) => Ok(Address::Sound((addr - SOUND_START) as usize)), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:109:25 [INFO] [stderr] | [INFO] [stderr] 109 | (SPRITE_XY_START...SPRITE_XY_END, true) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:113:26 [INFO] [stderr] | [INFO] [stderr] 113 | (DIP_SWITCH_START...DIP_SWITCH_END, _) => Ok(Address::DipSwitchRegister), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:115:24 [INFO] [stderr] | [INFO] [stderr] 115 | (WATCHDOG_START...WATCHDOG_END, _) => Ok(Address::WatchdogTimerReset), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: denote infinite loops with `loop { ... }` [INFO] [stderr] --> src/pacman.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | while true { [INFO] [stderr] | ^^^^^^^^^^ help: use `loop` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(while_true)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/cpu/mod.rs:912:13 [INFO] [stderr] | [INFO] [stderr] 912 | (5, 2) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/cpu/mod.rs:919:13 [INFO] [stderr] | [INFO] [stderr] 919 | (6, 2) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/cpu/mod.rs:933:13 [INFO] [stderr] | [INFO] [stderr] 933 | (7, 2) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/cpu/mod.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | for i in 0..iters { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `io` [INFO] [stderr] --> src/cpu/mod.rs:539:54 [INFO] [stderr] | [INFO] [stderr] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stderr] | ^^ help: if this is intentional, prefix it with an underscore: `_io` [INFO] [stderr] [INFO] [stderr] warning: variable `number_of_ones` is assigned to, but never used [INFO] [stderr] --> src/cpu/mod.rs:1381:13 [INFO] [stderr] | [INFO] [stderr] 1381 | let mut number_of_ones = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_number_of_ones` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `port` [INFO] [stderr] --> src/cpu/io.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | fn input(&self, port: u8) -> u8 { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `port` [INFO] [stderr] --> src/cpu/io.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | fn output(&mut self, port: u8, byte: u8) { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `mem` [INFO] [stderr] --> src/cpu/tests.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | let mut mem = &mut TestMemory::new(); [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_mem` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `result` [INFO] [stderr] --> src/display.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | let result = canvas.fill_rect(Rect::new(x_coord, y_coord, 2, 2)); [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x_flip` [INFO] [stderr] --> src/display.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | x_flip: bool, [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_x_flip` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y_flip` [INFO] [stderr] --> src/display.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | y_flip: bool, [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_y_flip` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `port` [INFO] [stderr] --> src/interrupt_vector.rs:14:21 [INFO] [stderr] | [INFO] [stderr] 14 | fn input(&self, port: u8) -> u8 { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `port` [INFO] [stderr] --> src/interrupt_vector.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | fn output(&mut self, port: u8, byte: u8) { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `color` [INFO] [stderr] --> src/rom.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | let color = self.color_rom[*byte as usize]; [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_color` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `why` [INFO] [stderr] --> src/rom.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | Err(why) => panic!("Missing ROMs"), [INFO] [stderr] | ^^^ help: if this is intentional, prefix it with an underscore: `_why` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `why` [INFO] [stderr] --> src/rom.rs:142:17 [INFO] [stderr] | [INFO] [stderr] 142 | Err(why) => panic!("Error reading ROM"), [INFO] [stderr] | ^^^ help: if this is intentional, prefix it with an underscore: `_why` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu/mod.rs:1145:13 [INFO] [stderr] | [INFO] [stderr] 1145 | let mut result = left.wrapping_sub(right); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu/mod.rs:1347:13 [INFO] [stderr] | [INFO] [stderr] 1347 | let mut left = left + (carry as u8); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu/mod.rs:1354:13 [INFO] [stderr] | [INFO] [stderr] 1354 | let mut left = left - (carry as u8); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu/tests.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | let mut mem = &mut TestMemory::new(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: associated function is never used: `draw_sprite` [INFO] [stderr] --> src/display.rs:30:12 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn draw_sprite(&mut self, x: usize, y: usize, sprite: usize, palette: usize) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `VramPalettes` [INFO] [stderr] --> src/memory_map.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | VramPalettes(usize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `roms` [INFO] [stderr] --> src/pacman.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | roms: &'a Box, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: 62 warnings emitted [INFO] [stderr] [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 0.12s [INFO] [stderr] Running /opt/rustwide/target/debug/deps/pacman-90e720eb9d9c87ef [INFO] [stdout] [INFO] [stdout] running 28 tests [INFO] [stdout] test cpu::reg::tests::test_write_16bit_r ... ok [INFO] [stdout] test cpu::reg::tests::test_16bit_registers ... ok [INFO] [stdout] test cpu::tests::test_indirect_loads ... ok [INFO] [stdout] test cpu::tests::test_8bit_loading ... ok [INFO] [stdout] test cpu::tests::test_bit_test ... ok [INFO] [stdout] test cpu::tests::test_16bit_ld ... ok [INFO] [stdout] test cpu::tests::test_ix_iy_bit_operations ... ok [INFO] [stdout] test cpu::tests::test_ix_operations ... ok [INFO] [stdout] test cpu::reg::tests::test_cc ... ok [INFO] [stdout] test cpu::tests::test_detect_overflow ... ok [INFO] [stdout] test cpu::tests::test_interrupt ... ok [INFO] [stdout] test cpu::tests::test_sub ... ok [INFO] [stdout] test cpu::tests::test_neg ... ok [INFO] [stdout] test cpu::tests::test_16bit_inc_dec ... ok [INFO] [stdout] test cpu::tests::test_add ... ok [INFO] [stdout] test memory_mapper::tests::test_read ... ok [INFO] [stdout] test cpu::tests::test_run_opcodes ... ok [INFO] [stdout] test cpu::tests::test_shift ... ok [INFO] [stdout] test cpu::tests::test_stack ... ok [INFO] [stdout] test memory_map::tests::test_memory_map ... ok [INFO] [stdout] test cpu::tests::test_return ... ok [INFO] [stdout] test cpu::tests::test_8bit_inc_dec ... ok [INFO] [stdout] test cpu::tests::test_jr ... ok [INFO] [stdout] test memory_mapper::tests::test_inital_state ... ok [INFO] [stdout] test cpu::tests::test_io ... ok [INFO] [stdout] test memory_mapper::tests::test_valid_write ... ok [INFO] [stderr] error: test failed, to rerun pass '--bin pacman' [INFO] [stdout] test cpu::tests::test_halt ... FAILED [INFO] [stdout] test memory_mapper::tests::test_invalid_write ... ok [INFO] [stdout] [INFO] [stdout] failures: [INFO] [stdout] [INFO] [stdout] ---- cpu::tests::test_halt stdout ---- [INFO] [stdout] thread 'cpu::tests::test_halt' panicked at 'assertion failed: `(left == right)` [INFO] [stdout] left: `4`, [INFO] [stdout] right: `0`', src/cpu/tests.rs:123:5 [INFO] [stdout] stack backtrace: [INFO] [stdout] 0: 0x5612cba7fc65 - backtrace::backtrace::libunwind::trace::h5e2646fa3eddf2ea [INFO] [stdout] at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/libunwind.rs:86 [INFO] [stdout] 1: 0x5612cba7fc65 - backtrace::backtrace::trace_unsynchronized::hb95dd7f77ce47877 [INFO] [stdout] at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/mod.rs:66 [INFO] [stdout] 2: 0x5612cba7fc65 - std::sys_common::backtrace::_print_fmt::h5e71b67af43fd70d [INFO] [stdout] at src/libstd/sys_common/backtrace.rs:78 [INFO] [stdout] 3: 0x5612cba7fc65 - ::fmt::hdb4a83d2b61107e5 [INFO] [stdout] at src/libstd/sys_common/backtrace.rs:59 [INFO] [stdout] 4: 0x5612cbaa78cc - core::fmt::write::ha20e7262fa3e8a7a [INFO] [stdout] at src/libcore/fmt/mod.rs:1076 [INFO] [stdout] 5: 0x5612cba32b55 - std::io::Write::write_fmt::hd8ff364c7845d2d0 [INFO] [stdout] at /rustc/6f959902b3103c49ca981fbc01871589c3498489/src/libstd/io/mod.rs:1537 [INFO] [stdout] 6: 0x5612cba7a331 - std::io::impls::>::write_fmt::h1c057ef6e8762996 [INFO] [stdout] at src/libstd/io/impls.rs:176 [INFO] [stdout] 7: 0x5612cba823c0 - std::sys_common::backtrace::_print::h9c07314cc66ba539 [INFO] [stdout] at src/libstd/sys_common/backtrace.rs:62 [INFO] [stdout] 8: 0x5612cba823c0 - std::sys_common::backtrace::print::hd1fd65f49a2d8544 [INFO] [stdout] at src/libstd/sys_common/backtrace.rs:49 [INFO] [stdout] 9: 0x5612cba823c0 - std::panicking::default_hook::{{closure}}::h222da46485ab36fc [INFO] [stdout] at src/libstd/panicking.rs:198 [INFO] [stdout] 10: 0x5612cba820ba - std::panicking::default_hook::hc5868949d129ed00 [INFO] [stdout] at src/libstd/panicking.rs:214 [INFO] [stdout] 11: 0x5612cba82a03 - std::panicking::rust_panic_with_hook::h26a6ab8b0993c0c8 [INFO] [stdout] at src/libstd/panicking.rs:526 [INFO] [stdout] 12: 0x5612cba825fb - rust_begin_unwind [INFO] [stdout] at src/libstd/panicking.rs:437 [INFO] [stdout] 13: 0x5612cba8256b - std::panicking::begin_panic_fmt::h2ff295231415d4a6 [INFO] [stdout] at src/libstd/panicking.rs:391 [INFO] [stdout] 14: 0x5612cba210cf - pacman::cpu::tests::test_halt::h14da336a17a332ab [INFO] [stdout] at src/cpu/tests.rs:123 [INFO] [stdout] 15: 0x5612cba20e4a - pacman::cpu::tests::test_halt::{{closure}}::h70d11183f5ce7422 [INFO] [stdout] at src/cpu/tests.rs:117 [INFO] [stdout] 16: 0x5612cba2c03e - core::ops::function::FnOnce::call_once::h043ab1429f10ee67 [INFO] [stdout] at /rustc/6f959902b3103c49ca981fbc01871589c3498489/src/libcore/ops/function.rs:233 [INFO] [stdout] 17: 0x5612cba5a0cc - as core::ops::function::FnOnce>::call_once::h42148c33ed88c979 [INFO] [stdout] at /rustc/6f959902b3103c49ca981fbc01871589c3498489/src/liballoc/boxed.rs:1081 [INFO] [stdout] 18: 0x5612cba5a0cc - as core::ops::function::FnOnce<()>>::call_once::h759dc0b09d774665 [INFO] [stdout] at /rustc/6f959902b3103c49ca981fbc01871589c3498489/src/libstd/panic.rs:318 [INFO] [stdout] 19: 0x5612cba5a0cc - std::panicking::try::do_call::h676ad1fc9e9badea [INFO] [stdout] at /rustc/6f959902b3103c49ca981fbc01871589c3498489/src/libstd/panicking.rs:348 [INFO] [stdout] 20: 0x5612cba5a0cc - std::panicking::try::hee36a8727a3050b0 [INFO] [stdout] at /rustc/6f959902b3103c49ca981fbc01871589c3498489/src/libstd/panicking.rs:325 [INFO] [stdout] 21: 0x5612cba5a0cc - std::panic::catch_unwind::hd5d426ebd89b2542 [INFO] [stdout] at /rustc/6f959902b3103c49ca981fbc01871589c3498489/src/libstd/panic.rs:394 [INFO] [stdout] 22: 0x5612cba5a0cc - test::run_test_in_process::h8dacdba4dc4cbaa5 [INFO] [stdout] at src/libtest/lib.rs:541 [INFO] [stdout] 23: 0x5612cba5a0cc - test::run_test::run_test_inner::{{closure}}::hf93754afad6be40f [INFO] [stdout] at src/libtest/lib.rs:450 [INFO] [stdout] 24: 0x5612cba32046 - std::sys_common::backtrace::__rust_begin_short_backtrace::h2c69fab544a90730 [INFO] [stdout] at /rustc/6f959902b3103c49ca981fbc01871589c3498489/src/libstd/sys_common/backtrace.rs:130 [INFO] [stdout] 25: 0x5612cba370d5 - std::thread::Builder::spawn_unchecked::{{closure}}::{{closure}}::hcf302fafa60d80f2 [INFO] [stdout] at /rustc/6f959902b3103c49ca981fbc01871589c3498489/src/libstd/thread/mod.rs:475 [INFO] [stdout] 26: 0x5612cba370d5 - as core::ops::function::FnOnce<()>>::call_once::h39ede710608e817e [INFO] [stdout] at /rustc/6f959902b3103c49ca981fbc01871589c3498489/src/libstd/panic.rs:318 [INFO] [stdout] 27: 0x5612cba370d5 - std::panicking::try::do_call::hec0b4d2faa46fbf7 [INFO] [stdout] at /rustc/6f959902b3103c49ca981fbc01871589c3498489/src/libstd/panicking.rs:348 [INFO] [stdout] 28: 0x5612cba370d5 - std::panicking::try::h0144ba3f2539803d [INFO] [stdout] at /rustc/6f959902b3103c49ca981fbc01871589c3498489/src/libstd/panicking.rs:325 [INFO] [stdout] 29: 0x5612cba370d5 - std::panic::catch_unwind::ha03e59eb589f857b [INFO] [stdout] at /rustc/6f959902b3103c49ca981fbc01871589c3498489/src/libstd/panic.rs:394 [INFO] [stdout] 30: 0x5612cba370d5 - std::thread::Builder::spawn_unchecked::{{closure}}::hdeba34620a4a7a44 [INFO] [stdout] at /rustc/6f959902b3103c49ca981fbc01871589c3498489/src/libstd/thread/mod.rs:474 [INFO] [stdout] 31: 0x5612cba370d5 - core::ops::function::FnOnce::call_once{{vtable.shim}}::h552693dbb801eadd [INFO] [stdout] at /rustc/6f959902b3103c49ca981fbc01871589c3498489/src/libcore/ops/function.rs:233 [INFO] [stdout] 32: 0x5612cba88bca - as core::ops::function::FnOnce>::call_once::h61c24496ae624ac5 [INFO] [stdout] at /rustc/6f959902b3103c49ca981fbc01871589c3498489/src/liballoc/boxed.rs:1081 [INFO] [stdout] 33: 0x5612cba88bca - as core::ops::function::FnOnce>::call_once::h89548957afa14049 [INFO] [stdout] at /rustc/6f959902b3103c49ca981fbc01871589c3498489/src/liballoc/boxed.rs:1081 [INFO] [stdout] 34: 0x5612cba88bca - std::sys::unix::thread::Thread::new::thread_start::h73903fbbff5b990e [INFO] [stdout] at src/libstd/sys/unix/thread.rs:87 [INFO] [stdout] 35: 0x7ffa4313e609 - start_thread [INFO] [stdout] 36: 0x7ffa4304a103 - __clone [INFO] [stdout] 37: 0x0 - [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] failures: [INFO] [stdout] cpu::tests::test_halt [INFO] [stdout] [INFO] [stdout] test result: FAILED. 27 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "5e946f0f65ed25439c8bb242fa698d1b575adcbb3dd1ef02807064b36042100e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e946f0f65ed25439c8bb242fa698d1b575adcbb3dd1ef02807064b36042100e", kill_on_drop: false }` [INFO] [stdout] 5e946f0f65ed25439c8bb242fa698d1b575adcbb3dd1ef02807064b36042100e