[INFO] updating cached repository https://github.com/simon-whitehead/chemboy [INFO] running `"git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune"` [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c25a60152172a397a0a3cf8fb5cb27ce84e66320 [INFO] testing simon-whitehead/chemboy against beta-2020-06-03 for beta-1.45-1 [INFO] running `"git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsimon-whitehead%2Fchemboy" "/workspace/builds/worker-3/source"` [INFO] [stderr] Cloning into '/workspace/builds/worker-3/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/simon-whitehead/chemboy on toolchain beta-2020-06-03 [INFO] running `"/workspace/cargo-home/bin/cargo" "+beta-2020-06-03" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started tweaking git repo https://github.com/simon-whitehead/chemboy [INFO] finished tweaking git repo https://github.com/simon-whitehead/chemboy [INFO] tweaked toml for git repo https://github.com/simon-whitehead/chemboy written to /workspace/builds/worker-3/source/Cargo.toml [INFO] crate git repo https://github.com/simon-whitehead/chemboy already has a lockfile, it will not be regenerated [INFO] running `"/workspace/cargo-home/bin/cargo" "+beta-2020-06-03" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "MAP_USER_ID=0" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--network" "none" "rustops/crates-build-env" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2020-06-03" "build" "--frozen"` [INFO] [stdout] 7b5c674770a5acf8c20f045138048ea2bd981095d91ff69c92ce53df9aa26570 [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] running `"docker" "start" "-a" "7b5c674770a5acf8c20f045138048ea2bd981095d91ff69c92ce53df9aa26570"` [INFO] [stderr] sudo: setrlimit(RLIMIT_CORE): Operation not permitted [INFO] [stderr] Compiling bitflags v1.0.3 [INFO] [stderr] Compiling libc v0.2.42 [INFO] [stderr] Compiling cfg-if v0.1.3 [INFO] [stderr] Compiling num-traits v0.2.4 [INFO] [stderr] Compiling lazy_static v1.0.1 [INFO] [stderr] Compiling khronos_api v2.2.0 [INFO] [stderr] Compiling nodrop v0.1.12 [INFO] [stderr] Compiling piston-float v0.3.0 [INFO] [stderr] Compiling cc v1.0.17 [INFO] [stderr] Compiling num-integer v0.1.38 [INFO] [stderr] Compiling byteorder v1.2.3 [INFO] [stderr] Compiling either v1.5.0 [INFO] [stderr] Compiling memoffset v0.2.1 [INFO] [stderr] Compiling scopeguard v0.3.3 [INFO] [stderr] Compiling rustc-serialize v0.3.24 [INFO] [stderr] Compiling num-iter v0.1.37 [INFO] [stderr] Compiling serde v1.0.66 [INFO] [stderr] Compiling rayon-core v1.4.0 [INFO] [stderr] Compiling void v1.0.2 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Compiling token_store v0.1.2 [INFO] [stderr] Compiling adler32 v1.0.3 [INFO] [stderr] Compiling piston-texture v0.6.0 [INFO] [stderr] Compiling pkg-config v0.3.11 [INFO] [stderr] Compiling shader_version v0.3.0 [INFO] [stderr] Compiling color_quant v1.0.1 [INFO] [stderr] Compiling interpolation v0.1.0 [INFO] [stderr] Compiling remove_dir_all v0.5.1 [INFO] [stderr] Compiling read_color v1.0.0 [INFO] [stderr] Compiling scoped_threadpool v0.1.9 [INFO] [stderr] Compiling fixedbitset v0.1.9 [INFO] [stderr] Compiling piston-shaders_graphics2d v0.3.1 [INFO] [stderr] Compiling linked-hash-map v0.5.1 [INFO] [stderr] Compiling approx v0.1.1 [INFO] [stderr] Compiling unicode-width v0.1.5 [INFO] [stderr] Compiling read_color v0.1.0 [INFO] [stderr] Compiling rand_core v0.2.1 [INFO] [stderr] Compiling ansi_term v0.11.0 [INFO] [stderr] Compiling strsim v0.7.0 [INFO] [stderr] Compiling vec_map v0.8.1 [INFO] [stderr] Compiling find_folder v0.3.0 [INFO] [stderr] Compiling proc-macro2 v0.4.6 [INFO] [stderr] Compiling proc-macro2 v0.3.8 [INFO] [stderr] Compiling xml-rs v0.7.0 [INFO] [stderr] Compiling draw_state v0.8.0 [INFO] [stderr] Compiling log v0.4.2 [INFO] [stderr] Compiling crossbeam-utils v0.2.2 [INFO] [stderr] Compiling arrayvec v0.4.7 [INFO] [stderr] Compiling piston-viewport v0.3.0 [INFO] [stderr] Compiling vecmath v0.3.1 [INFO] [stderr] Compiling itertools v0.5.10 [INFO] [stderr] Compiling unreachable v0.1.1 [INFO] [stderr] Compiling inflate v0.4.2 [INFO] [stderr] Compiling syn v0.10.8 [INFO] [stderr] Compiling stb_truetype v0.2.2 [INFO] [stderr] Compiling deflate v0.7.18 [INFO] [stderr] Compiling gif v0.10.0 [INFO] [stderr] Compiling textwrap v0.9.0 [INFO] [stderr] Compiling petgraph v0.4.12 [INFO] [stderr] Compiling rand v0.4.2 [INFO] [stderr] Compiling num_cpus v1.8.0 [INFO] [stderr] Compiling memmap v0.6.2 [INFO] [stderr] Compiling shared_library v0.1.8 [INFO] [stderr] Compiling atty v0.2.10 [INFO] [stderr] Compiling rand v0.5.1 [INFO] [stderr] Compiling crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling x11-dl v2.18.0 [INFO] [stderr] Compiling quote v0.6.3 [INFO] [stderr] Compiling piston2d-graphics v0.23.0 [INFO] [stderr] Compiling quote v0.5.2 [INFO] [stderr] Compiling wayland-scanner v0.12.5 [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Compiling clap v2.31.2 [INFO] [stderr] Compiling osmesa-sys v0.1.2 [INFO] [stderr] Compiling crossbeam-deque v0.2.0 [INFO] [stderr] Compiling syn v0.14.2 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Compiling tempfile v3.0.2 [INFO] [stderr] Compiling syn v0.13.11 [INFO] [stderr] Compiling daggy v0.5.0 [INFO] [stderr] Compiling num-traits v0.1.43 [INFO] [stderr] Compiling num-complex v0.1.43 [INFO] [stderr] Compiling ordered-float v0.5.0 [INFO] [stderr] Compiling dlib v0.4.1 [INFO] [stderr] Compiling wayland-client v0.12.5 [INFO] [stderr] Compiling wayland-protocols v0.12.5 [INFO] [stderr] Compiling num-bigint v0.1.44 [INFO] [stderr] Compiling wayland-sys v0.12.5 [INFO] [stderr] Compiling rayon v1.0.1 [INFO] [stderr] Compiling rusttype v0.4.3 [INFO] [stderr] Compiling rusttype v0.5.2 [INFO] [stderr] Compiling png v0.12.0 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Compiling glutin v0.14.0 [INFO] [stderr] Compiling piston2d-graphics v0.26.0 [INFO] [stderr] Compiling num-rational v0.1.42 [INFO] [stderr] Compiling num v0.1.42 [INFO] [stderr] Compiling jpeg-decoder v0.1.15 [INFO] [stderr] Compiling wayland-kbd v0.13.1 [INFO] [stderr] Compiling serde_derive v1.0.66 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Compiling derivative v1.0.0 [INFO] [stderr] Compiling image v0.19.0 [INFO] [stderr] Compiling wayland-window v0.13.3 [INFO] [stderr] Compiling winit v0.12.0 [INFO] [stderr] Compiling gfx_core v0.8.2 [INFO] [stderr] Compiling conrod_derive v0.1.2 [INFO] [stderr] Compiling piston2d-opengl_graphics v0.53.0 [INFO] [stderr] Compiling pistoncore-input v0.21.0 [INFO] [stderr] Compiling pistoncore-window v0.32.0 [INFO] [stderr] Compiling conrod v0.60.0 [INFO] [stderr] Compiling pistoncore-event_loop v0.37.0 [INFO] [stderr] Compiling pistoncore-glutin_window v0.47.0 [INFO] [stderr] Compiling piston v0.37.0 [INFO] [stderr] Compiling gfx v0.17.1 [INFO] [stderr] Compiling gfx_device_gl v0.15.3 [INFO] [stderr] Compiling piston-gfx_texture v0.32.0 [INFO] [stderr] Compiling piston2d-gfx_graphics v0.51.0 [INFO] [stderr] Compiling piston_window v0.80.0 [INFO] [stderr] Compiling chemboy v0.0.1 (/opt/rustwide/workdir) [INFO] [stderr] warning: unused import: `gameboy::interconnect::Interconnect` [INFO] [stderr] --> src/gameboy/cartridge.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use gameboy::interconnect::Interconnect; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `gameboy::Memory` [INFO] [stderr] --> src/gameboy/cartridge.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use gameboy::Memory; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | pub mbc: Box, [INFO] [stderr] | ^^^ help: use `dyn`: `dyn MBC` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:44:49 [INFO] [stderr] | [INFO] [stderr] 44 | fn get_controller(b: u8, rom: &[u8]) -> Box { [INFO] [stderr] | ^^^ help: use `dyn`: `dyn MBC` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | 0x01...0x03 => Box::new(MBC1::new(rom)), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:54:23 [INFO] [stderr] | [INFO] [stderr] 54 | type Target = Box; [INFO] [stderr] | ^^^ help: use `dyn`: `dyn MBC` [INFO] [stderr] [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Interconnect` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | use gameboy::{Interconnect, Interrupt, Irq, Memory}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:150:25 [INFO] [stderr] | [INFO] [stderr] 150 | 0x04...0x07 => self.timer.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:152:25 [INFO] [stderr] | [INFO] [stderr] 152 | 0x10...0x26 => (), // println!("err: write to sound driver not supported"), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:153:25 [INFO] [stderr] | [INFO] [stderr] 153 | 0x30...0x3F => (), // println!("err: write to wave pattern RAM not supported"), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:154:25 [INFO] [stderr] | [INFO] [stderr] 154 | 0x40...0x45 => self.gpu.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:155:25 [INFO] [stderr] | [INFO] [stderr] 155 | 0x47...0x49 => self.gpu.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:164:25 [INFO] [stderr] | [INFO] [stderr] 164 | 0x4A...0x4B => self.gpu.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:201:25 [INFO] [stderr] | [INFO] [stderr] 201 | 0x04...0x07 => self.timer.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:203:25 [INFO] [stderr] | [INFO] [stderr] 203 | 0x10...0x26 => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:207:25 [INFO] [stderr] | [INFO] [stderr] 207 | 0x30...0x3F => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:211:25 [INFO] [stderr] | [INFO] [stderr] 211 | 0x40...0x45 => self.gpu.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:212:25 [INFO] [stderr] | [INFO] [stderr] 212 | 0x47...0x49 => self.gpu.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:213:25 [INFO] [stderr] | [INFO] [stderr] 213 | 0x4A...0x4B => self.gpu.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Range` [INFO] [stderr] --> src/gameboy/mbc/mbc.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ops::Range; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Range` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::ops::Range; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Range` [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ops::Range; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:93:19 [INFO] [stderr] | [INFO] [stderr] 93 | 0x0000...0x1FFF => self.ram_enabled = (b & 0x0F) == 0x0A, // lower 4 bits only [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:94:19 [INFO] [stderr] | [INFO] [stderr] 94 | 0x2000...0x3FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:98:19 [INFO] [stderr] | [INFO] [stderr] 98 | 0x4000...0x5FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:103:37 [INFO] [stderr] | [INFO] [stderr] 103 | self.ram_bank = (b as usize & 0x03); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:106:19 [INFO] [stderr] | [INFO] [stderr] 106 | 0x6000...0x7FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:56:23 [INFO] [stderr] | [INFO] [stderr] 56 | CART_ROM_START...CART_ROM_END => Address::CartRom(virtual_address - CART_ROM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:57:23 [INFO] [stderr] | [INFO] [stderr] 57 | CART_RAM_START...CART_RAM_END => Address::CartRam(virtual_address - CART_RAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:58:22 [INFO] [stderr] | [INFO] [stderr] 58 | GFX_RAM_START...GFX_RAM_END => Address::Gfx(virtual_address - GFX_RAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:59:18 [INFO] [stderr] | [INFO] [stderr] 59 | RAM_START...RAM_END => Address::Ram(virtual_address - RAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:60:25 [INFO] [stderr] | [INFO] [stderr] 60 | RAM_SHADOW_START...RAM_SHADOW_END => Address::RamShadow(virtual_address - RAM_SHADOW_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | IO_START...IO_END => Address::Io(virtual_address - IO_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:62:19 [INFO] [stderr] | [INFO] [stderr] 62 | ZRAM_START...ZRAM_END => Address::ZRam(virtual_address - ZRAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:63:30 [INFO] [stderr] | [INFO] [stderr] 63 | GFX_SPRITE_INFO_START...GFX_SPRITE_INFO_END => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:66:28 [INFO] [stderr] | [INFO] [stderr] 66 | UNUSED_MEMORY_START...UNUSED_MEMORY_END => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:78:23 [INFO] [stderr] | [INFO] [stderr] 78 | CART_RAM_START...CART_RAM_END => virtual_address - CART_RAM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:79:23 [INFO] [stderr] | [INFO] [stderr] 79 | CART_ROM_START...CART_ROM_END => virtual_address - CART_ROM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:80:22 [INFO] [stderr] | [INFO] [stderr] 80 | GFX_RAM_START...GFX_RAM_END => virtual_address - GFX_RAM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | RAM_START...RAM_END => virtual_address - RAM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:82:25 [INFO] [stderr] | [INFO] [stderr] 82 | RAM_SHADOW_START...RAM_SHADOW_END => virtual_address - RAM_SHADOW_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | IO_START...IO_END => (virtual_address - IO_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:84:19 [INFO] [stderr] | [INFO] [stderr] 84 | ZRAM_START...ZRAM_END => (virtual_address - ZRAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:85:30 [INFO] [stderr] | [INFO] [stderr] 85 | GFX_SPRITE_INFO_START...GFX_SPRITE_INFO_END => virtual_address - GFX_SPRITE_INFO_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:86:28 [INFO] [stderr] | [INFO] [stderr] 86 | UNUSED_MEMORY_START...UNUSED_MEMORY_END => virtual_address - UNUSED_MEMORY_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unnecessary trailing semicolon [INFO] [stderr] --> src/gameboy/registers.rs:88:47 [INFO] [stderr] | [INFO] [stderr] 88 | println!("DE: {:02X}", self.get_de());; [INFO] [stderr] | ^ help: remove this semicolon [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary trailing semicolon [INFO] [stderr] --> src/gameboy/registers.rs:89:47 [INFO] [stderr] | [INFO] [stderr] 89 | println!("HL: {:02X}", self.get_hl());; [INFO] [stderr] | ^ help: remove this semicolon [INFO] [stderr] [INFO] [stderr] warning: unused import: `Interconnect` [INFO] [stderr] --> src/gameboy/timer.rs:1:31 [INFO] [stderr] | [INFO] [stderr] 1 | use gameboy::{MAX_CPU_CYCLES, Interconnect, Irq, Interrupt}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::marker::PhantomData` [INFO] [stderr] --> src/gameboy/ui/ui.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::marker::PhantomData; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `UiCell` [INFO] [stderr] --> src/gameboy/ui/ui.rs:5:68 [INFO] [stderr] | [INFO] [stderr] 5 | use conrod::{widget, Colorable, Labelable, Positionable, Sizeable, UiCell, Widget}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `gfx_core::factory::Factory` [INFO] [stderr] --> src/gameboy/ui/ui.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use gfx_core::factory::Factory; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `PistonWindow`, `WindowSettings`, `Window` [INFO] [stderr] --> src/gameboy/ui/ui.rs:12:21 [INFO] [stderr] | [INFO] [stderr] 12 | use piston_window::{PistonWindow, UpdateEvent, Window, WindowSettings}; [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Flip` [INFO] [stderr] --> src/gameboy/ui/ui.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | use piston_window::{Flip, G2d, G2dTexture, Texture, TextureSettings}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `gameboy::ui::theme::Theme` [INFO] [stderr] --> src/gameboy/ui/ui.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use gameboy::ui::theme::Theme; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the item `Align` is imported redundantly [INFO] [stderr] --> src/gameboy/ui/ui.rs:213:32 [INFO] [stderr] | [INFO] [stderr] 6 | use conrod::position::{Align, Relative}; [INFO] [stderr] | ----- the item `Align` is already imported here [INFO] [stderr] ... [INFO] [stderr] 213 | use conrod::position::{Align, Direction, Padding, Position, Relative}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the item `Relative` is imported redundantly [INFO] [stderr] --> src/gameboy/ui/ui.rs:213:69 [INFO] [stderr] | [INFO] [stderr] 6 | use conrod::position::{Align, Relative}; [INFO] [stderr] | -------- the item `Relative` is already imported here [INFO] [stderr] ... [INFO] [stderr] 213 | use conrod::position::{Align, Direction, Padding, Position, Relative}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/gameboy/interconnect.rs:225:9 [INFO] [stderr] | [INFO] [stderr] 224 | panic!("CALLED, APPARENTLY"); [INFO] [stderr] | ----------------------------- any code following this expression is unreachable [INFO] [stderr] 225 | let cart = self.cart.as_ref().expect("Cartridge is empty"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable statement [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gameboy/cpu.rs:715:17 [INFO] [stderr] | [INFO] [stderr] 715 | _ => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gameboy/memory_map.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | _ => panic!("Address {:#X} outside valid memory.", virtual_address), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gameboy/memory_map.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | _ => panic!("Address {:#X} outside valid memory.", virtual_address), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `operand` [INFO] [stderr] --> src/gameboy/cpu.rs:451:17 [INFO] [stderr] | [INFO] [stderr] 451 | let operand = self.get_operand_from_opcode(interconnect, &opcode); [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_operand` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `above_background` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:232:21 [INFO] [stderr] | [INFO] [stderr] 232 | let above_background = attributes & 0x80 == 0x00; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_above_background` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `flip_y` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:233:21 [INFO] [stderr] | [INFO] [stderr] 233 | let flip_y = attributes & 0x40 == 0x40; [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_flip_y` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:169:46 [INFO] [stderr] | [INFO] [stderr] 169 | Address::InterruptEnableRegister(a) => self.irq.enable_flag = byte, [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:218:46 [INFO] [stderr] | [INFO] [stderr] 218 | Address::InterruptEnableRegister(a) => self.irq.enable_flag, [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cart` [INFO] [stderr] --> src/gameboy/interconnect.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | let cart = self.cart.as_ref().expect("Cartridge is empty"); [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_cart` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:229:27 [INFO] [stderr] | [INFO] [stderr] 229 | Address::ZRam(a) => self.zram.read_bytes(r), [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:230:25 [INFO] [stderr] | [INFO] [stderr] 230 | Address::Io(a) => self.mmap_io.read_bytes(r), [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r` [INFO] [stderr] --> src/gameboy/interconnect.rs:223:30 [INFO] [stderr] | [INFO] [stderr] 223 | pub fn read_bytes(&self, r: Range) -> &[u8] { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_r` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cart` [INFO] [stderr] --> src/gameboy/interconnect.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | let cart = self.cart.as_mut().expect("Cartridge is empty"); [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_cart` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bytes` [INFO] [stderr] --> src/gameboy/interconnect.rs:273:46 [INFO] [stderr] | [INFO] [stderr] 273 | pub fn write_bytes(&mut self, addr: u16, bytes: &[u8]) { [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_bytes` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:44:32 [INFO] [stderr] | [INFO] [stderr] 44 | fn write_ram_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:44:43 [INFO] [stderr] | [INFO] [stderr] 44 | fn write_ram_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:48:32 [INFO] [stderr] | [INFO] [stderr] 48 | fn write_rom_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:48:43 [INFO] [stderr] | [INFO] [stderr] 48 | fn write_rom_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bg_color` [INFO] [stderr] --> src/gameboy/ui/ui.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | let mut bg_color = conrod::color::LIGHT_BLUE; [INFO] [stderr] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_bg_color` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v` [INFO] [stderr] --> src/gameboy/ui/ui.rs:169:21 [INFO] [stderr] | [INFO] [stderr] 169 | for v in item.set(toggle, &mut ui) { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:64:14 [INFO] [stderr] | [INFO] [stderr] 64 | let (mut glyph_cache, mut text_texture_cache) = { [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:64:31 [INFO] [stderr] | [INFO] [stderr] 64 | let (mut glyph_cache, mut text_texture_cache) = { [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | let mut bg_color = conrod::color::LIGHT_BLUE; [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | let mut result = UIEvent::None; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_MEM_SIZE` [INFO] [stderr] --> src/gameboy/cartridge.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | const CART_MEM_SIZE: usize = 0x200000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_RAM_SIZE` [INFO] [stderr] --> src/gameboy/cartridge.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | const CART_RAM_SIZE: usize = 0x8000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `rom_code_size` [INFO] [stderr] --> src/gameboy/cartridge.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | rom_code_size: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `DisassembledLine` [INFO] [stderr] --> src/gameboy/disassembler/disassembled_line.rs:4:12 [INFO] [stderr] | [INFO] [stderr] 4 | pub struct DisassembledLine { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `counter` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | counter: u8, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `BIOS_START` [INFO] [stderr] --> src/gameboy/memory_map.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | const BIOS_START: u16 = 0x0000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `BIOS_END` [INFO] [stderr] --> src/gameboy/memory_map.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | const BIOS_END: u16 = 0x00FF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_HEADER_START` [INFO] [stderr] --> src/gameboy/memory_map.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | const CART_HEADER_START: u16 = 0x0100; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_HEADER_END` [INFO] [stderr] --> src/gameboy/memory_map.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | const CART_HEADER_END: u16 = 0x014F; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Bios` [INFO] [stderr] --> src/gameboy/memory_map.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | Bios(u8), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CartHeader` [INFO] [stderr] --> src/gameboy/memory_map.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | CartHeader(u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CartRomOtherBank` [INFO] [stderr] --> src/gameboy/memory_map.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | CartRomOtherBank(u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ExternalRam` [INFO] [stderr] --> src/gameboy/memory_map.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | ExternalRam(u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `map_address_unwrap` [INFO] [stderr] --> src/gameboy/memory_map.rs:76:8 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn map_address_unwrap(virtual_address: u16) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `text_vertex_data` [INFO] [stderr] --> src/gameboy/ui/ui.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | text_vertex_data: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `selected_theme` [INFO] [stderr] --> src/gameboy/ui/ui.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | selected_theme: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `OAM_interrupt_enabled` should have a snake case name [INFO] [stderr] --> src/gameboy/gfx/stat.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | pub OAM_interrupt_enabled: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `oam_interrupt_enabled` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `VBlank_interrupt_enabled` should have a snake case name [INFO] [stderr] --> src/gameboy/gfx/stat.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | pub VBlank_interrupt_enabled: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `vblank_interrupt_enabled` [INFO] [stderr] [INFO] [stderr] warning: structure field `HBlank_interrupt_enabled` should have a snake case name [INFO] [stderr] --> src/gameboy/gfx/stat.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | pub HBlank_interrupt_enabled: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `hblank_interrupt_enabled` [INFO] [stderr] [INFO] [stderr] warning: unused return value of `core::num::::wrapping_add` that must be used [INFO] [stderr] --> src/gameboy/timer.rs:78:17 [INFO] [stderr] | [INFO] [stderr] 78 | self.tima.wrapping_add(0x01); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_must_use)]` on by default [INFO] [stderr] = note: this returns the result of the operation, without modifying the original [INFO] [stderr] [INFO] [stderr] warning: 102 warnings emitted [INFO] [stderr] [INFO] [stderr] warning: unused import: `gameboy::interconnect::Interconnect` [INFO] [stderr] --> src/gameboy/cartridge.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use gameboy::interconnect::Interconnect; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `gameboy::Memory` [INFO] [stderr] --> src/gameboy/cartridge.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use gameboy::Memory; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | pub mbc: Box, [INFO] [stderr] | ^^^ help: use `dyn`: `dyn MBC` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:44:49 [INFO] [stderr] | [INFO] [stderr] 44 | fn get_controller(b: u8, rom: &[u8]) -> Box { [INFO] [stderr] | ^^^ help: use `dyn`: `dyn MBC` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | 0x01...0x03 => Box::new(MBC1::new(rom)), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:54:23 [INFO] [stderr] | [INFO] [stderr] 54 | type Target = Box; [INFO] [stderr] | ^^^ help: use `dyn`: `dyn MBC` [INFO] [stderr] [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Interconnect` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | use gameboy::{Interconnect, Interrupt, Irq, Memory}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:150:25 [INFO] [stderr] | [INFO] [stderr] 150 | 0x04...0x07 => self.timer.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:152:25 [INFO] [stderr] | [INFO] [stderr] 152 | 0x10...0x26 => (), // println!("err: write to sound driver not supported"), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:153:25 [INFO] [stderr] | [INFO] [stderr] 153 | 0x30...0x3F => (), // println!("err: write to wave pattern RAM not supported"), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:154:25 [INFO] [stderr] | [INFO] [stderr] 154 | 0x40...0x45 => self.gpu.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:155:25 [INFO] [stderr] | [INFO] [stderr] 155 | 0x47...0x49 => self.gpu.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:164:25 [INFO] [stderr] | [INFO] [stderr] 164 | 0x4A...0x4B => self.gpu.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:201:25 [INFO] [stderr] | [INFO] [stderr] 201 | 0x04...0x07 => self.timer.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:203:25 [INFO] [stderr] | [INFO] [stderr] 203 | 0x10...0x26 => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:207:25 [INFO] [stderr] | [INFO] [stderr] 207 | 0x30...0x3F => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:211:25 [INFO] [stderr] | [INFO] [stderr] 211 | 0x40...0x45 => self.gpu.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:212:25 [INFO] [stderr] | [INFO] [stderr] 212 | 0x47...0x49 => self.gpu.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:213:25 [INFO] [stderr] | [INFO] [stderr] 213 | 0x4A...0x4B => self.gpu.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Range` [INFO] [stderr] --> src/gameboy/mbc/mbc.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ops::Range; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Range` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::ops::Range; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Range` [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ops::Range; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:93:19 [INFO] [stderr] | [INFO] [stderr] 93 | 0x0000...0x1FFF => self.ram_enabled = (b & 0x0F) == 0x0A, // lower 4 bits only [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:94:19 [INFO] [stderr] | [INFO] [stderr] 94 | 0x2000...0x3FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:98:19 [INFO] [stderr] | [INFO] [stderr] 98 | 0x4000...0x5FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:103:37 [INFO] [stderr] | [INFO] [stderr] 103 | self.ram_bank = (b as usize & 0x03); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:106:19 [INFO] [stderr] | [INFO] [stderr] 106 | 0x6000...0x7FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:56:23 [INFO] [stderr] | [INFO] [stderr] 56 | CART_ROM_START...CART_ROM_END => Address::CartRom(virtual_address - CART_ROM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:57:23 [INFO] [stderr] | [INFO] [stderr] 57 | CART_RAM_START...CART_RAM_END => Address::CartRam(virtual_address - CART_RAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:58:22 [INFO] [stderr] | [INFO] [stderr] 58 | GFX_RAM_START...GFX_RAM_END => Address::Gfx(virtual_address - GFX_RAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:59:18 [INFO] [stderr] | [INFO] [stderr] 59 | RAM_START...RAM_END => Address::Ram(virtual_address - RAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:60:25 [INFO] [stderr] | [INFO] [stderr] 60 | RAM_SHADOW_START...RAM_SHADOW_END => Address::RamShadow(virtual_address - RAM_SHADOW_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | IO_START...IO_END => Address::Io(virtual_address - IO_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:62:19 [INFO] [stderr] | [INFO] [stderr] 62 | ZRAM_START...ZRAM_END => Address::ZRam(virtual_address - ZRAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:63:30 [INFO] [stderr] | [INFO] [stderr] 63 | GFX_SPRITE_INFO_START...GFX_SPRITE_INFO_END => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:66:28 [INFO] [stderr] | [INFO] [stderr] 66 | UNUSED_MEMORY_START...UNUSED_MEMORY_END => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:78:23 [INFO] [stderr] | [INFO] [stderr] 78 | CART_RAM_START...CART_RAM_END => virtual_address - CART_RAM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:79:23 [INFO] [stderr] | [INFO] [stderr] 79 | CART_ROM_START...CART_ROM_END => virtual_address - CART_ROM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:80:22 [INFO] [stderr] | [INFO] [stderr] 80 | GFX_RAM_START...GFX_RAM_END => virtual_address - GFX_RAM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | RAM_START...RAM_END => virtual_address - RAM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:82:25 [INFO] [stderr] | [INFO] [stderr] 82 | RAM_SHADOW_START...RAM_SHADOW_END => virtual_address - RAM_SHADOW_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | IO_START...IO_END => (virtual_address - IO_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:84:19 [INFO] [stderr] | [INFO] [stderr] 84 | ZRAM_START...ZRAM_END => (virtual_address - ZRAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:85:30 [INFO] [stderr] | [INFO] [stderr] 85 | GFX_SPRITE_INFO_START...GFX_SPRITE_INFO_END => virtual_address - GFX_SPRITE_INFO_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:86:28 [INFO] [stderr] | [INFO] [stderr] 86 | UNUSED_MEMORY_START...UNUSED_MEMORY_END => virtual_address - UNUSED_MEMORY_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unnecessary trailing semicolon [INFO] [stderr] --> src/gameboy/registers.rs:88:47 [INFO] [stderr] | [INFO] [stderr] 88 | println!("DE: {:02X}", self.get_de());; [INFO] [stderr] | ^ help: remove this semicolon [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary trailing semicolon [INFO] [stderr] --> src/gameboy/registers.rs:89:47 [INFO] [stderr] | [INFO] [stderr] 89 | println!("HL: {:02X}", self.get_hl());; [INFO] [stderr] | ^ help: remove this semicolon [INFO] [stderr] [INFO] [stderr] warning: unused import: `Interconnect` [INFO] [stderr] --> src/gameboy/timer.rs:1:31 [INFO] [stderr] | [INFO] [stderr] 1 | use gameboy::{MAX_CPU_CYCLES, Interconnect, Irq, Interrupt}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::marker::PhantomData` [INFO] [stderr] --> src/gameboy/ui/ui.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::marker::PhantomData; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `UiCell` [INFO] [stderr] --> src/gameboy/ui/ui.rs:5:68 [INFO] [stderr] | [INFO] [stderr] 5 | use conrod::{widget, Colorable, Labelable, Positionable, Sizeable, UiCell, Widget}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `gfx_core::factory::Factory` [INFO] [stderr] --> src/gameboy/ui/ui.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use gfx_core::factory::Factory; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `PistonWindow`, `WindowSettings`, `Window` [INFO] [stderr] --> src/gameboy/ui/ui.rs:12:21 [INFO] [stderr] | [INFO] [stderr] 12 | use piston_window::{PistonWindow, UpdateEvent, Window, WindowSettings}; [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Flip` [INFO] [stderr] --> src/gameboy/ui/ui.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | use piston_window::{Flip, G2d, G2dTexture, Texture, TextureSettings}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `gameboy::ui::theme::Theme` [INFO] [stderr] --> src/gameboy/ui/ui.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use gameboy::ui::theme::Theme; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the item `Align` is imported redundantly [INFO] [stderr] --> src/gameboy/ui/ui.rs:213:32 [INFO] [stderr] | [INFO] [stderr] 6 | use conrod::position::{Align, Relative}; [INFO] [stderr] | ----- the item `Align` is already imported here [INFO] [stderr] ... [INFO] [stderr] 213 | use conrod::position::{Align, Direction, Padding, Position, Relative}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the item `Relative` is imported redundantly [INFO] [stderr] --> src/gameboy/ui/ui.rs:213:69 [INFO] [stderr] | [INFO] [stderr] 6 | use conrod::position::{Align, Relative}; [INFO] [stderr] | -------- the item `Relative` is already imported here [INFO] [stderr] ... [INFO] [stderr] 213 | use conrod::position::{Align, Direction, Padding, Position, Relative}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Ui` [INFO] [stderr] --> src/main.rs:25:57 [INFO] [stderr] | [INFO] [stderr] 25 | use gameboy::{Cartridge, CpuSpeed, Frame, JoypadButton, Ui}; [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: unused label [INFO] [stderr] --> src/main.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | 'start: while let Some(e) = window.next() { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_labels)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/gameboy/interconnect.rs:225:9 [INFO] [stderr] | [INFO] [stderr] 224 | panic!("CALLED, APPARENTLY"); [INFO] [stderr] | ----------------------------- any code following this expression is unreachable [INFO] [stderr] 225 | let cart = self.cart.as_ref().expect("Cartridge is empty"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable statement [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gameboy/cpu.rs:715:17 [INFO] [stderr] | [INFO] [stderr] 715 | _ => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gameboy/memory_map.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | _ => panic!("Address {:#X} outside valid memory.", virtual_address), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gameboy/memory_map.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | _ => panic!("Address {:#X} outside valid memory.", virtual_address), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `debugger_enabled` [INFO] [stderr] --> src/main.rs:150:31 [INFO] [stderr] | [INFO] [stderr] 150 | fn create_window(title: S, debugger_enabled: bool) -> PistonWindow [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_debugger_enabled` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `operand` [INFO] [stderr] --> src/gameboy/cpu.rs:451:17 [INFO] [stderr] | [INFO] [stderr] 451 | let operand = self.get_operand_from_opcode(interconnect, &opcode); [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_operand` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `above_background` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:232:21 [INFO] [stderr] | [INFO] [stderr] 232 | let above_background = attributes & 0x80 == 0x00; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_above_background` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `flip_y` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:233:21 [INFO] [stderr] | [INFO] [stderr] 233 | let flip_y = attributes & 0x40 == 0x40; [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_flip_y` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:169:46 [INFO] [stderr] | [INFO] [stderr] 169 | Address::InterruptEnableRegister(a) => self.irq.enable_flag = byte, [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:218:46 [INFO] [stderr] | [INFO] [stderr] 218 | Address::InterruptEnableRegister(a) => self.irq.enable_flag, [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cart` [INFO] [stderr] --> src/gameboy/interconnect.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | let cart = self.cart.as_ref().expect("Cartridge is empty"); [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_cart` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:229:27 [INFO] [stderr] | [INFO] [stderr] 229 | Address::ZRam(a) => self.zram.read_bytes(r), [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:230:25 [INFO] [stderr] | [INFO] [stderr] 230 | Address::Io(a) => self.mmap_io.read_bytes(r), [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r` [INFO] [stderr] --> src/gameboy/interconnect.rs:223:30 [INFO] [stderr] | [INFO] [stderr] 223 | pub fn read_bytes(&self, r: Range) -> &[u8] { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_r` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cart` [INFO] [stderr] --> src/gameboy/interconnect.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | let cart = self.cart.as_mut().expect("Cartridge is empty"); [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_cart` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bytes` [INFO] [stderr] --> src/gameboy/interconnect.rs:273:46 [INFO] [stderr] | [INFO] [stderr] 273 | pub fn write_bytes(&mut self, addr: u16, bytes: &[u8]) { [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_bytes` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:44:32 [INFO] [stderr] | [INFO] [stderr] 44 | fn write_ram_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:44:43 [INFO] [stderr] | [INFO] [stderr] 44 | fn write_ram_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:48:32 [INFO] [stderr] | [INFO] [stderr] 48 | fn write_rom_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:48:43 [INFO] [stderr] | [INFO] [stderr] 48 | fn write_rom_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bg_color` [INFO] [stderr] --> src/gameboy/ui/ui.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | let mut bg_color = conrod::color::LIGHT_BLUE; [INFO] [stderr] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_bg_color` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v` [INFO] [stderr] --> src/gameboy/ui/ui.rs:169:21 [INFO] [stderr] | [INFO] [stderr] 169 | for v in item.set(toggle, &mut ui) { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:64:14 [INFO] [stderr] | [INFO] [stderr] 64 | let (mut glyph_cache, mut text_texture_cache) = { [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:64:31 [INFO] [stderr] | [INFO] [stderr] 64 | let (mut glyph_cache, mut text_texture_cache) = { [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | let mut bg_color = conrod::color::LIGHT_BLUE; [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | let mut result = UIEvent::None; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_MEM_SIZE` [INFO] [stderr] --> src/gameboy/cartridge.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | const CART_MEM_SIZE: usize = 0x200000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_RAM_SIZE` [INFO] [stderr] --> src/gameboy/cartridge.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | const CART_RAM_SIZE: usize = 0x8000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `rom_code_size` [INFO] [stderr] --> src/gameboy/cartridge.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | rom_code_size: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `DisassembledLine` [INFO] [stderr] --> src/gameboy/disassembler/disassembled_line.rs:4:12 [INFO] [stderr] | [INFO] [stderr] 4 | pub struct DisassembledLine { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `counter` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | counter: u8, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `BIOS_START` [INFO] [stderr] --> src/gameboy/memory_map.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | const BIOS_START: u16 = 0x0000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `BIOS_END` [INFO] [stderr] --> src/gameboy/memory_map.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | const BIOS_END: u16 = 0x00FF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_HEADER_START` [INFO] [stderr] --> src/gameboy/memory_map.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | const CART_HEADER_START: u16 = 0x0100; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_HEADER_END` [INFO] [stderr] --> src/gameboy/memory_map.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | const CART_HEADER_END: u16 = 0x014F; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Bios` [INFO] [stderr] --> src/gameboy/memory_map.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | Bios(u8), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CartHeader` [INFO] [stderr] --> src/gameboy/memory_map.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | CartHeader(u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CartRomOtherBank` [INFO] [stderr] --> src/gameboy/memory_map.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | CartRomOtherBank(u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ExternalRam` [INFO] [stderr] --> src/gameboy/memory_map.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | ExternalRam(u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `map_address_unwrap` [INFO] [stderr] --> src/gameboy/memory_map.rs:76:8 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn map_address_unwrap(virtual_address: u16) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `text_vertex_data` [INFO] [stderr] --> src/gameboy/ui/ui.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | text_vertex_data: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `selected_theme` [INFO] [stderr] --> src/gameboy/ui/ui.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | selected_theme: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | texture.update(&mut window.encoder, &imgbuf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_must_use)]` on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | gameboy.run(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: structure field `OAM_interrupt_enabled` should have a snake case name [INFO] [stderr] --> src/gameboy/gfx/stat.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | pub OAM_interrupt_enabled: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `oam_interrupt_enabled` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `VBlank_interrupt_enabled` should have a snake case name [INFO] [stderr] --> src/gameboy/gfx/stat.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | pub VBlank_interrupt_enabled: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `vblank_interrupt_enabled` [INFO] [stderr] [INFO] [stderr] warning: structure field `HBlank_interrupt_enabled` should have a snake case name [INFO] [stderr] --> src/gameboy/gfx/stat.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | pub HBlank_interrupt_enabled: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `hblank_interrupt_enabled` [INFO] [stderr] [INFO] [stderr] warning: unused return value of `core::num::::wrapping_add` that must be used [INFO] [stderr] --> src/gameboy/timer.rs:78:17 [INFO] [stderr] | [INFO] [stderr] 78 | self.tima.wrapping_add(0x01); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this returns the result of the operation, without modifying the original [INFO] [stderr] [INFO] [stderr] warning: 107 warnings emitted [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3m 06s [INFO] running `"docker" "inspect" "7b5c674770a5acf8c20f045138048ea2bd981095d91ff69c92ce53df9aa26570"` [INFO] running `"docker" "rm" "-f" "7b5c674770a5acf8c20f045138048ea2bd981095d91ff69c92ce53df9aa26570"` [INFO] [stdout] 7b5c674770a5acf8c20f045138048ea2bd981095d91ff69c92ce53df9aa26570 [INFO] running `"docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "MAP_USER_ID=0" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--network" "none" "rustops/crates-build-env" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2020-06-03" "test" "--frozen" "--no-run"` [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] [stdout] 565ecebd1705e3f8b46cd456c97146d7ec9c04bb778dedfc2fe31a1e7fee6a5d [INFO] running `"docker" "start" "-a" "565ecebd1705e3f8b46cd456c97146d7ec9c04bb778dedfc2fe31a1e7fee6a5d"` [INFO] [stderr] sudo: setrlimit(RLIMIT_CORE): Operation not permitted [INFO] [stderr] Compiling chemboy v0.0.1 (/opt/rustwide/workdir) [INFO] [stderr] warning: unused import: `gameboy::interconnect::Interconnect` [INFO] [stderr] --> src/gameboy/cartridge.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use gameboy::interconnect::Interconnect; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `gameboy::Memory` [INFO] [stderr] --> src/gameboy/cartridge.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use gameboy::Memory; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | pub mbc: Box, [INFO] [stderr] | ^^^ help: use `dyn`: `dyn MBC` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:44:49 [INFO] [stderr] | [INFO] [stderr] 44 | fn get_controller(b: u8, rom: &[u8]) -> Box { [INFO] [stderr] | ^^^ help: use `dyn`: `dyn MBC` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | 0x01...0x03 => Box::new(MBC1::new(rom)), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:54:23 [INFO] [stderr] | [INFO] [stderr] 54 | type Target = Box; [INFO] [stderr] | ^^^ help: use `dyn`: `dyn MBC` [INFO] [stderr] [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Interconnect` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | use gameboy::{Interconnect, Interrupt, Irq, Memory}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:150:25 [INFO] [stderr] | [INFO] [stderr] 150 | 0x04...0x07 => self.timer.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:152:25 [INFO] [stderr] | [INFO] [stderr] 152 | 0x10...0x26 => (), // println!("err: write to sound driver not supported"), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:153:25 [INFO] [stderr] | [INFO] [stderr] 153 | 0x30...0x3F => (), // println!("err: write to wave pattern RAM not supported"), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:154:25 [INFO] [stderr] | [INFO] [stderr] 154 | 0x40...0x45 => self.gpu.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:155:25 [INFO] [stderr] | [INFO] [stderr] 155 | 0x47...0x49 => self.gpu.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:164:25 [INFO] [stderr] | [INFO] [stderr] 164 | 0x4A...0x4B => self.gpu.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:201:25 [INFO] [stderr] | [INFO] [stderr] 201 | 0x04...0x07 => self.timer.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:203:25 [INFO] [stderr] | [INFO] [stderr] 203 | 0x10...0x26 => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:207:25 [INFO] [stderr] | [INFO] [stderr] 207 | 0x30...0x3F => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:211:25 [INFO] [stderr] | [INFO] [stderr] 211 | 0x40...0x45 => self.gpu.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:212:25 [INFO] [stderr] | [INFO] [stderr] 212 | 0x47...0x49 => self.gpu.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:213:25 [INFO] [stderr] | [INFO] [stderr] 213 | 0x4A...0x4B => self.gpu.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Range` [INFO] [stderr] --> src/gameboy/mbc/mbc.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ops::Range; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Range` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::ops::Range; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Range` [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ops::Range; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:93:19 [INFO] [stderr] | [INFO] [stderr] 93 | 0x0000...0x1FFF => self.ram_enabled = (b & 0x0F) == 0x0A, // lower 4 bits only [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:94:19 [INFO] [stderr] | [INFO] [stderr] 94 | 0x2000...0x3FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:98:19 [INFO] [stderr] | [INFO] [stderr] 98 | 0x4000...0x5FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:103:37 [INFO] [stderr] | [INFO] [stderr] 103 | self.ram_bank = (b as usize & 0x03); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:106:19 [INFO] [stderr] | [INFO] [stderr] 106 | 0x6000...0x7FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:56:23 [INFO] [stderr] | [INFO] [stderr] 56 | CART_ROM_START...CART_ROM_END => Address::CartRom(virtual_address - CART_ROM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:57:23 [INFO] [stderr] | [INFO] [stderr] 57 | CART_RAM_START...CART_RAM_END => Address::CartRam(virtual_address - CART_RAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:58:22 [INFO] [stderr] | [INFO] [stderr] 58 | GFX_RAM_START...GFX_RAM_END => Address::Gfx(virtual_address - GFX_RAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:59:18 [INFO] [stderr] | [INFO] [stderr] 59 | RAM_START...RAM_END => Address::Ram(virtual_address - RAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:60:25 [INFO] [stderr] | [INFO] [stderr] 60 | RAM_SHADOW_START...RAM_SHADOW_END => Address::RamShadow(virtual_address - RAM_SHADOW_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | IO_START...IO_END => Address::Io(virtual_address - IO_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:62:19 [INFO] [stderr] | [INFO] [stderr] 62 | ZRAM_START...ZRAM_END => Address::ZRam(virtual_address - ZRAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:63:30 [INFO] [stderr] | [INFO] [stderr] 63 | GFX_SPRITE_INFO_START...GFX_SPRITE_INFO_END => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:66:28 [INFO] [stderr] | [INFO] [stderr] 66 | UNUSED_MEMORY_START...UNUSED_MEMORY_END => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:78:23 [INFO] [stderr] | [INFO] [stderr] 78 | CART_RAM_START...CART_RAM_END => virtual_address - CART_RAM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:79:23 [INFO] [stderr] | [INFO] [stderr] 79 | CART_ROM_START...CART_ROM_END => virtual_address - CART_ROM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:80:22 [INFO] [stderr] | [INFO] [stderr] 80 | GFX_RAM_START...GFX_RAM_END => virtual_address - GFX_RAM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | RAM_START...RAM_END => virtual_address - RAM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:82:25 [INFO] [stderr] | [INFO] [stderr] 82 | RAM_SHADOW_START...RAM_SHADOW_END => virtual_address - RAM_SHADOW_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | IO_START...IO_END => (virtual_address - IO_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:84:19 [INFO] [stderr] | [INFO] [stderr] 84 | ZRAM_START...ZRAM_END => (virtual_address - ZRAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:85:30 [INFO] [stderr] | [INFO] [stderr] 85 | GFX_SPRITE_INFO_START...GFX_SPRITE_INFO_END => virtual_address - GFX_SPRITE_INFO_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:86:28 [INFO] [stderr] | [INFO] [stderr] 86 | UNUSED_MEMORY_START...UNUSED_MEMORY_END => virtual_address - UNUSED_MEMORY_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unnecessary trailing semicolon [INFO] [stderr] --> src/gameboy/registers.rs:88:47 [INFO] [stderr] | [INFO] [stderr] 88 | println!("DE: {:02X}", self.get_de());; [INFO] [stderr] | ^ help: remove this semicolon [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary trailing semicolon [INFO] [stderr] --> src/gameboy/registers.rs:89:47 [INFO] [stderr] | [INFO] [stderr] 89 | println!("HL: {:02X}", self.get_hl());; [INFO] [stderr] | ^ help: remove this semicolon [INFO] [stderr] [INFO] [stderr] warning: unused import: `Interconnect` [INFO] [stderr] --> src/gameboy/timer.rs:1:31 [INFO] [stderr] | [INFO] [stderr] 1 | use gameboy::{MAX_CPU_CYCLES, Interconnect, Irq, Interrupt}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::marker::PhantomData` [INFO] [stderr] --> src/gameboy/ui/ui.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::marker::PhantomData; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `UiCell` [INFO] [stderr] --> src/gameboy/ui/ui.rs:5:68 [INFO] [stderr] | [INFO] [stderr] 5 | use conrod::{widget, Colorable, Labelable, Positionable, Sizeable, UiCell, Widget}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `gfx_core::factory::Factory` [INFO] [stderr] --> src/gameboy/ui/ui.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use gfx_core::factory::Factory; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `PistonWindow`, `WindowSettings`, `Window` [INFO] [stderr] --> src/gameboy/ui/ui.rs:12:21 [INFO] [stderr] | [INFO] [stderr] 12 | use piston_window::{PistonWindow, UpdateEvent, Window, WindowSettings}; [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Flip` [INFO] [stderr] --> src/gameboy/ui/ui.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | use piston_window::{Flip, G2d, G2dTexture, Texture, TextureSettings}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `gameboy::ui::theme::Theme` [INFO] [stderr] --> src/gameboy/ui/ui.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use gameboy::ui::theme::Theme; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the item `Align` is imported redundantly [INFO] [stderr] --> src/gameboy/ui/ui.rs:213:32 [INFO] [stderr] | [INFO] [stderr] 6 | use conrod::position::{Align, Relative}; [INFO] [stderr] | ----- the item `Align` is already imported here [INFO] [stderr] ... [INFO] [stderr] 213 | use conrod::position::{Align, Direction, Padding, Position, Relative}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the item `Relative` is imported redundantly [INFO] [stderr] --> src/gameboy/ui/ui.rs:213:69 [INFO] [stderr] | [INFO] [stderr] 6 | use conrod::position::{Align, Relative}; [INFO] [stderr] | -------- the item `Relative` is already imported here [INFO] [stderr] ... [INFO] [stderr] 213 | use conrod::position::{Align, Direction, Padding, Position, Relative}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/gameboy/interconnect.rs:225:9 [INFO] [stderr] | [INFO] [stderr] 224 | panic!("CALLED, APPARENTLY"); [INFO] [stderr] | ----------------------------- any code following this expression is unreachable [INFO] [stderr] 225 | let cart = self.cart.as_ref().expect("Cartridge is empty"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable statement [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gameboy/cpu.rs:715:17 [INFO] [stderr] | [INFO] [stderr] 715 | _ => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gameboy/memory_map.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | _ => panic!("Address {:#X} outside valid memory.", virtual_address), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gameboy/memory_map.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | _ => panic!("Address {:#X} outside valid memory.", virtual_address), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `operand` [INFO] [stderr] --> src/gameboy/cpu.rs:451:17 [INFO] [stderr] | [INFO] [stderr] 451 | let operand = self.get_operand_from_opcode(interconnect, &opcode); [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_operand` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `above_background` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:232:21 [INFO] [stderr] | [INFO] [stderr] 232 | let above_background = attributes & 0x80 == 0x00; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_above_background` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `flip_y` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:233:21 [INFO] [stderr] | [INFO] [stderr] 233 | let flip_y = attributes & 0x40 == 0x40; [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_flip_y` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:169:46 [INFO] [stderr] | [INFO] [stderr] 169 | Address::InterruptEnableRegister(a) => self.irq.enable_flag = byte, [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:218:46 [INFO] [stderr] | [INFO] [stderr] 218 | Address::InterruptEnableRegister(a) => self.irq.enable_flag, [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cart` [INFO] [stderr] --> src/gameboy/interconnect.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | let cart = self.cart.as_ref().expect("Cartridge is empty"); [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_cart` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:229:27 [INFO] [stderr] | [INFO] [stderr] 229 | Address::ZRam(a) => self.zram.read_bytes(r), [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:230:25 [INFO] [stderr] | [INFO] [stderr] 230 | Address::Io(a) => self.mmap_io.read_bytes(r), [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r` [INFO] [stderr] --> src/gameboy/interconnect.rs:223:30 [INFO] [stderr] | [INFO] [stderr] 223 | pub fn read_bytes(&self, r: Range) -> &[u8] { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_r` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cart` [INFO] [stderr] --> src/gameboy/interconnect.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | let cart = self.cart.as_mut().expect("Cartridge is empty"); [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_cart` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bytes` [INFO] [stderr] --> src/gameboy/interconnect.rs:273:46 [INFO] [stderr] | [INFO] [stderr] 273 | pub fn write_bytes(&mut self, addr: u16, bytes: &[u8]) { [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_bytes` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:44:32 [INFO] [stderr] | [INFO] [stderr] 44 | fn write_ram_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:44:43 [INFO] [stderr] | [INFO] [stderr] 44 | fn write_ram_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:48:32 [INFO] [stderr] | [INFO] [stderr] 48 | fn write_rom_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:48:43 [INFO] [stderr] | [INFO] [stderr] 48 | fn write_rom_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bg_color` [INFO] [stderr] --> src/gameboy/ui/ui.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | let mut bg_color = conrod::color::LIGHT_BLUE; [INFO] [stderr] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_bg_color` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v` [INFO] [stderr] --> src/gameboy/ui/ui.rs:169:21 [INFO] [stderr] | [INFO] [stderr] 169 | for v in item.set(toggle, &mut ui) { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:64:14 [INFO] [stderr] | [INFO] [stderr] 64 | let (mut glyph_cache, mut text_texture_cache) = { [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:64:31 [INFO] [stderr] | [INFO] [stderr] 64 | let (mut glyph_cache, mut text_texture_cache) = { [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | let mut bg_color = conrod::color::LIGHT_BLUE; [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | let mut result = UIEvent::None; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_MEM_SIZE` [INFO] [stderr] --> src/gameboy/cartridge.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | const CART_MEM_SIZE: usize = 0x200000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_RAM_SIZE` [INFO] [stderr] --> src/gameboy/cartridge.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | const CART_RAM_SIZE: usize = 0x8000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `rom_code_size` [INFO] [stderr] --> src/gameboy/cartridge.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | rom_code_size: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `DisassembledLine` [INFO] [stderr] --> src/gameboy/disassembler/disassembled_line.rs:4:12 [INFO] [stderr] | [INFO] [stderr] 4 | pub struct DisassembledLine { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `counter` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | counter: u8, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `BIOS_START` [INFO] [stderr] --> src/gameboy/memory_map.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | const BIOS_START: u16 = 0x0000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `BIOS_END` [INFO] [stderr] --> src/gameboy/memory_map.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | const BIOS_END: u16 = 0x00FF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_HEADER_START` [INFO] [stderr] --> src/gameboy/memory_map.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | const CART_HEADER_START: u16 = 0x0100; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_HEADER_END` [INFO] [stderr] --> src/gameboy/memory_map.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | const CART_HEADER_END: u16 = 0x014F; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Bios` [INFO] [stderr] --> src/gameboy/memory_map.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | Bios(u8), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CartHeader` [INFO] [stderr] --> src/gameboy/memory_map.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | CartHeader(u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CartRomOtherBank` [INFO] [stderr] --> src/gameboy/memory_map.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | CartRomOtherBank(u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ExternalRam` [INFO] [stderr] --> src/gameboy/memory_map.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | ExternalRam(u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `map_address_unwrap` [INFO] [stderr] --> src/gameboy/memory_map.rs:76:8 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn map_address_unwrap(virtual_address: u16) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `text_vertex_data` [INFO] [stderr] --> src/gameboy/ui/ui.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | text_vertex_data: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `selected_theme` [INFO] [stderr] --> src/gameboy/ui/ui.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | selected_theme: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `OAM_interrupt_enabled` should have a snake case name [INFO] [stderr] --> src/gameboy/gfx/stat.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | pub OAM_interrupt_enabled: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `oam_interrupt_enabled` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `VBlank_interrupt_enabled` should have a snake case name [INFO] [stderr] --> src/gameboy/gfx/stat.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | pub VBlank_interrupt_enabled: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `vblank_interrupt_enabled` [INFO] [stderr] [INFO] [stderr] warning: structure field `HBlank_interrupt_enabled` should have a snake case name [INFO] [stderr] --> src/gameboy/gfx/stat.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | pub HBlank_interrupt_enabled: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `hblank_interrupt_enabled` [INFO] [stderr] [INFO] [stderr] warning: unused return value of `core::num::::wrapping_add` that must be used [INFO] [stderr] --> src/gameboy/timer.rs:78:17 [INFO] [stderr] | [INFO] [stderr] 78 | self.tima.wrapping_add(0x01); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_must_use)]` on by default [INFO] [stderr] = note: this returns the result of the operation, without modifying the original [INFO] [stderr] [INFO] [stderr] warning: 102 warnings emitted [INFO] [stderr] [INFO] [stderr] warning: unused import: `gameboy::interconnect::Interconnect` [INFO] [stderr] --> src/gameboy/cartridge.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use gameboy::interconnect::Interconnect; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `gameboy::Memory` [INFO] [stderr] --> src/gameboy/cartridge.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use gameboy::Memory; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | pub mbc: Box, [INFO] [stderr] | ^^^ help: use `dyn`: `dyn MBC` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:44:49 [INFO] [stderr] | [INFO] [stderr] 44 | fn get_controller(b: u8, rom: &[u8]) -> Box { [INFO] [stderr] | ^^^ help: use `dyn`: `dyn MBC` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | 0x01...0x03 => Box::new(MBC1::new(rom)), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:54:23 [INFO] [stderr] | [INFO] [stderr] 54 | type Target = Box; [INFO] [stderr] | ^^^ help: use `dyn`: `dyn MBC` [INFO] [stderr] [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Interconnect` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | use gameboy::{Interconnect, Interrupt, Irq, Memory}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:150:25 [INFO] [stderr] | [INFO] [stderr] 150 | 0x04...0x07 => self.timer.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:152:25 [INFO] [stderr] | [INFO] [stderr] 152 | 0x10...0x26 => (), // println!("err: write to sound driver not supported"), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:153:25 [INFO] [stderr] | [INFO] [stderr] 153 | 0x30...0x3F => (), // println!("err: write to wave pattern RAM not supported"), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:154:25 [INFO] [stderr] | [INFO] [stderr] 154 | 0x40...0x45 => self.gpu.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:155:25 [INFO] [stderr] | [INFO] [stderr] 155 | 0x47...0x49 => self.gpu.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:164:25 [INFO] [stderr] | [INFO] [stderr] 164 | 0x4A...0x4B => self.gpu.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:201:25 [INFO] [stderr] | [INFO] [stderr] 201 | 0x04...0x07 => self.timer.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:203:25 [INFO] [stderr] | [INFO] [stderr] 203 | 0x10...0x26 => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:207:25 [INFO] [stderr] | [INFO] [stderr] 207 | 0x30...0x3F => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:211:25 [INFO] [stderr] | [INFO] [stderr] 211 | 0x40...0x45 => self.gpu.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:212:25 [INFO] [stderr] | [INFO] [stderr] 212 | 0x47...0x49 => self.gpu.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:213:25 [INFO] [stderr] | [INFO] [stderr] 213 | 0x4A...0x4B => self.gpu.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Range` [INFO] [stderr] --> src/gameboy/mbc/mbc.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ops::Range; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Range` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::ops::Range; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Range` [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ops::Range; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:93:19 [INFO] [stderr] | [INFO] [stderr] 93 | 0x0000...0x1FFF => self.ram_enabled = (b & 0x0F) == 0x0A, // lower 4 bits only [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:94:19 [INFO] [stderr] | [INFO] [stderr] 94 | 0x2000...0x3FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:98:19 [INFO] [stderr] | [INFO] [stderr] 98 | 0x4000...0x5FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:103:37 [INFO] [stderr] | [INFO] [stderr] 103 | self.ram_bank = (b as usize & 0x03); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:106:19 [INFO] [stderr] | [INFO] [stderr] 106 | 0x6000...0x7FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:56:23 [INFO] [stderr] | [INFO] [stderr] 56 | CART_ROM_START...CART_ROM_END => Address::CartRom(virtual_address - CART_ROM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:57:23 [INFO] [stderr] | [INFO] [stderr] 57 | CART_RAM_START...CART_RAM_END => Address::CartRam(virtual_address - CART_RAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:58:22 [INFO] [stderr] | [INFO] [stderr] 58 | GFX_RAM_START...GFX_RAM_END => Address::Gfx(virtual_address - GFX_RAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:59:18 [INFO] [stderr] | [INFO] [stderr] 59 | RAM_START...RAM_END => Address::Ram(virtual_address - RAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:60:25 [INFO] [stderr] | [INFO] [stderr] 60 | RAM_SHADOW_START...RAM_SHADOW_END => Address::RamShadow(virtual_address - RAM_SHADOW_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | IO_START...IO_END => Address::Io(virtual_address - IO_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:62:19 [INFO] [stderr] | [INFO] [stderr] 62 | ZRAM_START...ZRAM_END => Address::ZRam(virtual_address - ZRAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:63:30 [INFO] [stderr] | [INFO] [stderr] 63 | GFX_SPRITE_INFO_START...GFX_SPRITE_INFO_END => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:66:28 [INFO] [stderr] | [INFO] [stderr] 66 | UNUSED_MEMORY_START...UNUSED_MEMORY_END => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:78:23 [INFO] [stderr] | [INFO] [stderr] 78 | CART_RAM_START...CART_RAM_END => virtual_address - CART_RAM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:79:23 [INFO] [stderr] | [INFO] [stderr] 79 | CART_ROM_START...CART_ROM_END => virtual_address - CART_ROM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:80:22 [INFO] [stderr] | [INFO] [stderr] 80 | GFX_RAM_START...GFX_RAM_END => virtual_address - GFX_RAM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | RAM_START...RAM_END => virtual_address - RAM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:82:25 [INFO] [stderr] | [INFO] [stderr] 82 | RAM_SHADOW_START...RAM_SHADOW_END => virtual_address - RAM_SHADOW_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | IO_START...IO_END => (virtual_address - IO_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:84:19 [INFO] [stderr] | [INFO] [stderr] 84 | ZRAM_START...ZRAM_END => (virtual_address - ZRAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:85:30 [INFO] [stderr] | [INFO] [stderr] 85 | GFX_SPRITE_INFO_START...GFX_SPRITE_INFO_END => virtual_address - GFX_SPRITE_INFO_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:86:28 [INFO] [stderr] | [INFO] [stderr] 86 | UNUSED_MEMORY_START...UNUSED_MEMORY_END => virtual_address - UNUSED_MEMORY_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unnecessary trailing semicolon [INFO] [stderr] --> src/gameboy/registers.rs:88:47 [INFO] [stderr] | [INFO] [stderr] 88 | println!("DE: {:02X}", self.get_de());; [INFO] [stderr] | ^ help: remove this semicolon [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary trailing semicolon [INFO] [stderr] --> src/gameboy/registers.rs:89:47 [INFO] [stderr] | [INFO] [stderr] 89 | println!("HL: {:02X}", self.get_hl());; [INFO] [stderr] | ^ help: remove this semicolon [INFO] [stderr] [INFO] [stderr] warning: unused import: `Interconnect` [INFO] [stderr] --> src/gameboy/timer.rs:1:31 [INFO] [stderr] | [INFO] [stderr] 1 | use gameboy::{MAX_CPU_CYCLES, Interconnect, Irq, Interrupt}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::marker::PhantomData` [INFO] [stderr] --> src/gameboy/ui/ui.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::marker::PhantomData; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `UiCell` [INFO] [stderr] --> src/gameboy/ui/ui.rs:5:68 [INFO] [stderr] | [INFO] [stderr] 5 | use conrod::{widget, Colorable, Labelable, Positionable, Sizeable, UiCell, Widget}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `gfx_core::factory::Factory` [INFO] [stderr] --> src/gameboy/ui/ui.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use gfx_core::factory::Factory; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `PistonWindow`, `WindowSettings`, `Window` [INFO] [stderr] --> src/gameboy/ui/ui.rs:12:21 [INFO] [stderr] | [INFO] [stderr] 12 | use piston_window::{PistonWindow, UpdateEvent, Window, WindowSettings}; [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Flip` [INFO] [stderr] --> src/gameboy/ui/ui.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | use piston_window::{Flip, G2d, G2dTexture, Texture, TextureSettings}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `gameboy::ui::theme::Theme` [INFO] [stderr] --> src/gameboy/ui/ui.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use gameboy::ui::theme::Theme; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the item `Align` is imported redundantly [INFO] [stderr] --> src/gameboy/ui/ui.rs:213:32 [INFO] [stderr] | [INFO] [stderr] 6 | use conrod::position::{Align, Relative}; [INFO] [stderr] | ----- the item `Align` is already imported here [INFO] [stderr] ... [INFO] [stderr] 213 | use conrod::position::{Align, Direction, Padding, Position, Relative}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the item `Relative` is imported redundantly [INFO] [stderr] --> src/gameboy/ui/ui.rs:213:69 [INFO] [stderr] | [INFO] [stderr] 6 | use conrod::position::{Align, Relative}; [INFO] [stderr] | -------- the item `Relative` is already imported here [INFO] [stderr] ... [INFO] [stderr] 213 | use conrod::position::{Align, Direction, Padding, Position, Relative}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Ui` [INFO] [stderr] --> src/main.rs:25:57 [INFO] [stderr] | [INFO] [stderr] 25 | use gameboy::{Cartridge, CpuSpeed, Frame, JoypadButton, Ui}; [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: unused label [INFO] [stderr] --> src/main.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | 'start: while let Some(e) = window.next() { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_labels)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `gameboy::interconnect::Interconnect` [INFO] [stderr] --> src/gameboy/cartridge.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use gameboy::interconnect::Interconnect; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `gameboy::Memory` [INFO] [stderr] --> src/gameboy/cartridge.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use gameboy::Memory; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | pub mbc: Box, [INFO] [stderr] | ^^^ help: use `dyn`: `dyn MBC` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:44:49 [INFO] [stderr] | [INFO] [stderr] 44 | fn get_controller(b: u8, rom: &[u8]) -> Box { [INFO] [stderr] | ^^^ help: use `dyn`: `dyn MBC` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | 0x01...0x03 => Box::new(MBC1::new(rom)), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:54:23 [INFO] [stderr] | [INFO] [stderr] 54 | type Target = Box; [INFO] [stderr] | ^^^ help: use `dyn`: `dyn MBC` [INFO] [stderr] [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Interconnect` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | use gameboy::{Interconnect, Interrupt, Irq, Memory}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:150:25 [INFO] [stderr] | [INFO] [stderr] 150 | 0x04...0x07 => self.timer.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:152:25 [INFO] [stderr] | [INFO] [stderr] 152 | 0x10...0x26 => (), // println!("err: write to sound driver not supported"), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:153:25 [INFO] [stderr] | [INFO] [stderr] 153 | 0x30...0x3F => (), // println!("err: write to wave pattern RAM not supported"), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:154:25 [INFO] [stderr] | [INFO] [stderr] 154 | 0x40...0x45 => self.gpu.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:155:25 [INFO] [stderr] | [INFO] [stderr] 155 | 0x47...0x49 => self.gpu.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:164:25 [INFO] [stderr] | [INFO] [stderr] 164 | 0x4A...0x4B => self.gpu.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:201:25 [INFO] [stderr] | [INFO] [stderr] 201 | 0x04...0x07 => self.timer.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:203:25 [INFO] [stderr] | [INFO] [stderr] 203 | 0x10...0x26 => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:207:25 [INFO] [stderr] | [INFO] [stderr] 207 | 0x30...0x3F => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:211:25 [INFO] [stderr] | [INFO] [stderr] 211 | 0x40...0x45 => self.gpu.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:212:25 [INFO] [stderr] | [INFO] [stderr] 212 | 0x47...0x49 => self.gpu.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:213:25 [INFO] [stderr] | [INFO] [stderr] 213 | 0x4A...0x4B => self.gpu.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Range` [INFO] [stderr] --> src/gameboy/mbc/mbc.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ops::Range; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Range` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::ops::Range; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Range` [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ops::Range; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:93:19 [INFO] [stderr] | [INFO] [stderr] 93 | 0x0000...0x1FFF => self.ram_enabled = (b & 0x0F) == 0x0A, // lower 4 bits only [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:94:19 [INFO] [stderr] | [INFO] [stderr] 94 | 0x2000...0x3FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:98:19 [INFO] [stderr] | [INFO] [stderr] 98 | 0x4000...0x5FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:103:37 [INFO] [stderr] | [INFO] [stderr] 103 | self.ram_bank = (b as usize & 0x03); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:106:19 [INFO] [stderr] | [INFO] [stderr] 106 | 0x6000...0x7FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:56:23 [INFO] [stderr] | [INFO] [stderr] 56 | CART_ROM_START...CART_ROM_END => Address::CartRom(virtual_address - CART_ROM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:57:23 [INFO] [stderr] | [INFO] [stderr] 57 | CART_RAM_START...CART_RAM_END => Address::CartRam(virtual_address - CART_RAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:58:22 [INFO] [stderr] | [INFO] [stderr] 58 | GFX_RAM_START...GFX_RAM_END => Address::Gfx(virtual_address - GFX_RAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:59:18 [INFO] [stderr] | [INFO] [stderr] 59 | RAM_START...RAM_END => Address::Ram(virtual_address - RAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:60:25 [INFO] [stderr] | [INFO] [stderr] 60 | RAM_SHADOW_START...RAM_SHADOW_END => Address::RamShadow(virtual_address - RAM_SHADOW_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | IO_START...IO_END => Address::Io(virtual_address - IO_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:62:19 [INFO] [stderr] | [INFO] [stderr] 62 | ZRAM_START...ZRAM_END => Address::ZRam(virtual_address - ZRAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:63:30 [INFO] [stderr] | [INFO] [stderr] 63 | GFX_SPRITE_INFO_START...GFX_SPRITE_INFO_END => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:66:28 [INFO] [stderr] | [INFO] [stderr] 66 | UNUSED_MEMORY_START...UNUSED_MEMORY_END => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:78:23 [INFO] [stderr] | [INFO] [stderr] 78 | CART_RAM_START...CART_RAM_END => virtual_address - CART_RAM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:79:23 [INFO] [stderr] | [INFO] [stderr] 79 | CART_ROM_START...CART_ROM_END => virtual_address - CART_ROM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:80:22 [INFO] [stderr] | [INFO] [stderr] 80 | GFX_RAM_START...GFX_RAM_END => virtual_address - GFX_RAM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | RAM_START...RAM_END => virtual_address - RAM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:82:25 [INFO] [stderr] | [INFO] [stderr] 82 | RAM_SHADOW_START...RAM_SHADOW_END => virtual_address - RAM_SHADOW_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | IO_START...IO_END => (virtual_address - IO_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:84:19 [INFO] [stderr] | [INFO] [stderr] 84 | ZRAM_START...ZRAM_END => (virtual_address - ZRAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:85:30 [INFO] [stderr] | [INFO] [stderr] 85 | GFX_SPRITE_INFO_START...GFX_SPRITE_INFO_END => virtual_address - GFX_SPRITE_INFO_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:86:28 [INFO] [stderr] | [INFO] [stderr] 86 | UNUSED_MEMORY_START...UNUSED_MEMORY_END => virtual_address - UNUSED_MEMORY_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unnecessary trailing semicolon [INFO] [stderr] --> src/gameboy/registers.rs:88:47 [INFO] [stderr] | [INFO] [stderr] 88 | println!("DE: {:02X}", self.get_de());; [INFO] [stderr] | ^ help: remove this semicolon [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary trailing semicolon [INFO] [stderr] --> src/gameboy/registers.rs:89:47 [INFO] [stderr] | [INFO] [stderr] 89 | println!("HL: {:02X}", self.get_hl());; [INFO] [stderr] | ^ help: remove this semicolon [INFO] [stderr] [INFO] [stderr] warning: unused import: `Interconnect` [INFO] [stderr] --> src/gameboy/timer.rs:1:31 [INFO] [stderr] | [INFO] [stderr] 1 | use gameboy::{MAX_CPU_CYCLES, Interconnect, Irq, Interrupt}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::marker::PhantomData` [INFO] [stderr] --> src/gameboy/ui/ui.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::marker::PhantomData; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `UiCell` [INFO] [stderr] --> src/gameboy/ui/ui.rs:5:68 [INFO] [stderr] | [INFO] [stderr] 5 | use conrod::{widget, Colorable, Labelable, Positionable, Sizeable, UiCell, Widget}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `gfx_core::factory::Factory` [INFO] [stderr] --> src/gameboy/ui/ui.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use gfx_core::factory::Factory; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `PistonWindow`, `WindowSettings`, `Window` [INFO] [stderr] --> src/gameboy/ui/ui.rs:12:21 [INFO] [stderr] | [INFO] [stderr] 12 | use piston_window::{PistonWindow, UpdateEvent, Window, WindowSettings}; [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Flip` [INFO] [stderr] --> src/gameboy/ui/ui.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | use piston_window::{Flip, G2d, G2dTexture, Texture, TextureSettings}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `gameboy::ui::theme::Theme` [INFO] [stderr] --> src/gameboy/ui/ui.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use gameboy::ui::theme::Theme; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the item `Align` is imported redundantly [INFO] [stderr] --> src/gameboy/ui/ui.rs:213:32 [INFO] [stderr] | [INFO] [stderr] 6 | use conrod::position::{Align, Relative}; [INFO] [stderr] | ----- the item `Align` is already imported here [INFO] [stderr] ... [INFO] [stderr] 213 | use conrod::position::{Align, Direction, Padding, Position, Relative}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the item `Relative` is imported redundantly [INFO] [stderr] --> src/gameboy/ui/ui.rs:213:69 [INFO] [stderr] | [INFO] [stderr] 6 | use conrod::position::{Align, Relative}; [INFO] [stderr] | -------- the item `Relative` is already imported here [INFO] [stderr] ... [INFO] [stderr] 213 | use conrod::position::{Align, Direction, Padding, Position, Relative}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/gameboy/interconnect.rs:225:9 [INFO] [stderr] | [INFO] [stderr] 224 | panic!("CALLED, APPARENTLY"); [INFO] [stderr] | ----------------------------- any code following this expression is unreachable [INFO] [stderr] 225 | let cart = self.cart.as_ref().expect("Cartridge is empty"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable statement [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/gameboy/interconnect.rs:225:9 [INFO] [stderr] | [INFO] [stderr] 224 | panic!("CALLED, APPARENTLY"); [INFO] [stderr] | ----------------------------- any code following this expression is unreachable [INFO] [stderr] 225 | let cart = self.cart.as_ref().expect("Cartridge is empty"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable statement [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gameboy/cpu.rs:715:17 [INFO] [stderr] | [INFO] [stderr] 715 | _ => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gameboy/cpu.rs:715:17 [INFO] [stderr] | [INFO] [stderr] 715 | _ => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gameboy/memory_map.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | _ => panic!("Address {:#X} outside valid memory.", virtual_address), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gameboy/memory_map.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | _ => panic!("Address {:#X} outside valid memory.", virtual_address), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gameboy/memory_map.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | _ => panic!("Address {:#X} outside valid memory.", virtual_address), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gameboy/memory_map.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | _ => panic!("Address {:#X} outside valid memory.", virtual_address), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `operand` [INFO] [stderr] --> src/gameboy/cpu.rs:451:17 [INFO] [stderr] | [INFO] [stderr] 451 | let operand = self.get_operand_from_opcode(interconnect, &opcode); [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_operand` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `above_background` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:232:21 [INFO] [stderr] | [INFO] [stderr] 232 | let above_background = attributes & 0x80 == 0x00; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_above_background` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `flip_y` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:233:21 [INFO] [stderr] | [INFO] [stderr] 233 | let flip_y = attributes & 0x40 == 0x40; [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_flip_y` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:169:46 [INFO] [stderr] | [INFO] [stderr] 169 | Address::InterruptEnableRegister(a) => self.irq.enable_flag = byte, [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:218:46 [INFO] [stderr] | [INFO] [stderr] 218 | Address::InterruptEnableRegister(a) => self.irq.enable_flag, [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cart` [INFO] [stderr] --> src/gameboy/interconnect.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | let cart = self.cart.as_ref().expect("Cartridge is empty"); [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_cart` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:229:27 [INFO] [stderr] | [INFO] [stderr] 229 | Address::ZRam(a) => self.zram.read_bytes(r), [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:230:25 [INFO] [stderr] | [INFO] [stderr] 230 | Address::Io(a) => self.mmap_io.read_bytes(r), [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r` [INFO] [stderr] --> src/gameboy/interconnect.rs:223:30 [INFO] [stderr] | [INFO] [stderr] 223 | pub fn read_bytes(&self, r: Range) -> &[u8] { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_r` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cart` [INFO] [stderr] --> src/gameboy/interconnect.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | let cart = self.cart.as_mut().expect("Cartridge is empty"); [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_cart` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bytes` [INFO] [stderr] --> src/gameboy/interconnect.rs:273:46 [INFO] [stderr] | [INFO] [stderr] 273 | pub fn write_bytes(&mut self, addr: u16, bytes: &[u8]) { [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_bytes` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:44:32 [INFO] [stderr] | [INFO] [stderr] 44 | fn write_ram_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:44:43 [INFO] [stderr] | [INFO] [stderr] 44 | fn write_ram_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:48:32 [INFO] [stderr] | [INFO] [stderr] 48 | fn write_rom_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:48:43 [INFO] [stderr] | [INFO] [stderr] 48 | fn write_rom_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `debugger_enabled` [INFO] [stderr] --> src/main.rs:150:31 [INFO] [stderr] | [INFO] [stderr] 150 | fn create_window(title: S, debugger_enabled: bool) -> PistonWindow [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_debugger_enabled` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `operand` [INFO] [stderr] --> src/gameboy/cpu.rs:451:17 [INFO] [stderr] | [INFO] [stderr] 451 | let operand = self.get_operand_from_opcode(interconnect, &opcode); [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_operand` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bg_color` [INFO] [stderr] --> src/gameboy/ui/ui.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | let mut bg_color = conrod::color::LIGHT_BLUE; [INFO] [stderr] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_bg_color` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v` [INFO] [stderr] --> src/gameboy/ui/ui.rs:169:21 [INFO] [stderr] | [INFO] [stderr] 169 | for v in item.set(toggle, &mut ui) { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `above_background` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:232:21 [INFO] [stderr] | [INFO] [stderr] 232 | let above_background = attributes & 0x80 == 0x00; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_above_background` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `flip_y` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:233:21 [INFO] [stderr] | [INFO] [stderr] 233 | let flip_y = attributes & 0x40 == 0x40; [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_flip_y` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:169:46 [INFO] [stderr] | [INFO] [stderr] 169 | Address::InterruptEnableRegister(a) => self.irq.enable_flag = byte, [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:218:46 [INFO] [stderr] | [INFO] [stderr] 218 | Address::InterruptEnableRegister(a) => self.irq.enable_flag, [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cart` [INFO] [stderr] --> src/gameboy/interconnect.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | let cart = self.cart.as_ref().expect("Cartridge is empty"); [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_cart` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:229:27 [INFO] [stderr] | [INFO] [stderr] 229 | Address::ZRam(a) => self.zram.read_bytes(r), [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:230:25 [INFO] [stderr] | [INFO] [stderr] 230 | Address::Io(a) => self.mmap_io.read_bytes(r), [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r` [INFO] [stderr] --> src/gameboy/interconnect.rs:223:30 [INFO] [stderr] | [INFO] [stderr] 223 | pub fn read_bytes(&self, r: Range) -> &[u8] { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_r` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cart` [INFO] [stderr] --> src/gameboy/interconnect.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | let cart = self.cart.as_mut().expect("Cartridge is empty"); [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_cart` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bytes` [INFO] [stderr] --> src/gameboy/interconnect.rs:273:46 [INFO] [stderr] | [INFO] [stderr] 273 | pub fn write_bytes(&mut self, addr: u16, bytes: &[u8]) { [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_bytes` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:44:32 [INFO] [stderr] | [INFO] [stderr] 44 | fn write_ram_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:44:43 [INFO] [stderr] | [INFO] [stderr] 44 | fn write_ram_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:48:32 [INFO] [stderr] | [INFO] [stderr] 48 | fn write_rom_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:48:43 [INFO] [stderr] | [INFO] [stderr] 48 | fn write_rom_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bg_color` [INFO] [stderr] --> src/gameboy/ui/ui.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | let mut bg_color = conrod::color::LIGHT_BLUE; [INFO] [stderr] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_bg_color` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v` [INFO] [stderr] --> src/gameboy/ui/ui.rs:169:21 [INFO] [stderr] | [INFO] [stderr] 169 | for v in item.set(toggle, &mut ui) { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:64:14 [INFO] [stderr] | [INFO] [stderr] 64 | let (mut glyph_cache, mut text_texture_cache) = { [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:64:31 [INFO] [stderr] | [INFO] [stderr] 64 | let (mut glyph_cache, mut text_texture_cache) = { [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | let mut bg_color = conrod::color::LIGHT_BLUE; [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | let mut result = UIEvent::None; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_MEM_SIZE` [INFO] [stderr] --> src/gameboy/cartridge.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | const CART_MEM_SIZE: usize = 0x200000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_RAM_SIZE` [INFO] [stderr] --> src/gameboy/cartridge.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | const CART_RAM_SIZE: usize = 0x8000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `rom_code_size` [INFO] [stderr] --> src/gameboy/cartridge.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | rom_code_size: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `DisassembledLine` [INFO] [stderr] --> src/gameboy/disassembler/disassembled_line.rs:4:12 [INFO] [stderr] | [INFO] [stderr] 4 | pub struct DisassembledLine { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `counter` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | counter: u8, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `BIOS_START` [INFO] [stderr] --> src/gameboy/memory_map.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | const BIOS_START: u16 = 0x0000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `BIOS_END` [INFO] [stderr] --> src/gameboy/memory_map.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | const BIOS_END: u16 = 0x00FF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_HEADER_START` [INFO] [stderr] --> src/gameboy/memory_map.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | const CART_HEADER_START: u16 = 0x0100; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_HEADER_END` [INFO] [stderr] --> src/gameboy/memory_map.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | const CART_HEADER_END: u16 = 0x014F; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Bios` [INFO] [stderr] --> src/gameboy/memory_map.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | Bios(u8), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CartHeader` [INFO] [stderr] --> src/gameboy/memory_map.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | CartHeader(u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CartRomOtherBank` [INFO] [stderr] --> src/gameboy/memory_map.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | CartRomOtherBank(u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ExternalRam` [INFO] [stderr] --> src/gameboy/memory_map.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | ExternalRam(u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `map_address_unwrap` [INFO] [stderr] --> src/gameboy/memory_map.rs:76:8 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn map_address_unwrap(virtual_address: u16) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `text_vertex_data` [INFO] [stderr] --> src/gameboy/ui/ui.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | text_vertex_data: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `selected_theme` [INFO] [stderr] --> src/gameboy/ui/ui.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | selected_theme: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `OAM_interrupt_enabled` should have a snake case name [INFO] [stderr] --> src/gameboy/gfx/stat.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | pub OAM_interrupt_enabled: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `oam_interrupt_enabled` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `VBlank_interrupt_enabled` should have a snake case name [INFO] [stderr] --> src/gameboy/gfx/stat.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | pub VBlank_interrupt_enabled: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `vblank_interrupt_enabled` [INFO] [stderr] [INFO] [stderr] warning: structure field `HBlank_interrupt_enabled` should have a snake case name [INFO] [stderr] --> src/gameboy/gfx/stat.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | pub HBlank_interrupt_enabled: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `hblank_interrupt_enabled` [INFO] [stderr] [INFO] [stderr] warning: unused return value of `core::num::::wrapping_add` that must be used [INFO] [stderr] --> src/gameboy/timer.rs:78:17 [INFO] [stderr] | [INFO] [stderr] 78 | self.tima.wrapping_add(0x01); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_must_use)]` on by default [INFO] [stderr] = note: this returns the result of the operation, without modifying the original [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:64:14 [INFO] [stderr] | [INFO] [stderr] 64 | let (mut glyph_cache, mut text_texture_cache) = { [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:64:31 [INFO] [stderr] | [INFO] [stderr] 64 | let (mut glyph_cache, mut text_texture_cache) = { [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | let mut bg_color = conrod::color::LIGHT_BLUE; [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | let mut result = UIEvent::None; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_MEM_SIZE` [INFO] [stderr] --> src/gameboy/cartridge.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | const CART_MEM_SIZE: usize = 0x200000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_RAM_SIZE` [INFO] [stderr] --> src/gameboy/cartridge.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | const CART_RAM_SIZE: usize = 0x8000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `rom_code_size` [INFO] [stderr] --> src/gameboy/cartridge.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | rom_code_size: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `DisassembledLine` [INFO] [stderr] --> src/gameboy/disassembler/disassembled_line.rs:4:12 [INFO] [stderr] | [INFO] [stderr] 4 | pub struct DisassembledLine { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `counter` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | counter: u8, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `BIOS_START` [INFO] [stderr] --> src/gameboy/memory_map.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | const BIOS_START: u16 = 0x0000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `BIOS_END` [INFO] [stderr] --> src/gameboy/memory_map.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | const BIOS_END: u16 = 0x00FF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_HEADER_START` [INFO] [stderr] --> src/gameboy/memory_map.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | const CART_HEADER_START: u16 = 0x0100; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_HEADER_END` [INFO] [stderr] --> src/gameboy/memory_map.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | const CART_HEADER_END: u16 = 0x014F; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Bios` [INFO] [stderr] --> src/gameboy/memory_map.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | Bios(u8), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CartHeader` [INFO] [stderr] --> src/gameboy/memory_map.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | CartHeader(u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CartRomOtherBank` [INFO] [stderr] --> src/gameboy/memory_map.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | CartRomOtherBank(u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ExternalRam` [INFO] [stderr] --> src/gameboy/memory_map.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | ExternalRam(u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `map_address_unwrap` [INFO] [stderr] --> src/gameboy/memory_map.rs:76:8 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn map_address_unwrap(virtual_address: u16) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `text_vertex_data` [INFO] [stderr] --> src/gameboy/ui/ui.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | text_vertex_data: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `selected_theme` [INFO] [stderr] --> src/gameboy/ui/ui.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | selected_theme: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | texture.update(&mut window.encoder, &imgbuf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_must_use)]` on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | gameboy.run(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: structure field `OAM_interrupt_enabled` should have a snake case name [INFO] [stderr] --> src/gameboy/gfx/stat.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | pub OAM_interrupt_enabled: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `oam_interrupt_enabled` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `VBlank_interrupt_enabled` should have a snake case name [INFO] [stderr] --> src/gameboy/gfx/stat.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | pub VBlank_interrupt_enabled: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `vblank_interrupt_enabled` [INFO] [stderr] [INFO] [stderr] warning: structure field `HBlank_interrupt_enabled` should have a snake case name [INFO] [stderr] --> src/gameboy/gfx/stat.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | pub HBlank_interrupt_enabled: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `hblank_interrupt_enabled` [INFO] [stderr] [INFO] [stderr] warning: unused return value of `core::num::::wrapping_add` that must be used [INFO] [stderr] --> src/gameboy/timer.rs:78:17 [INFO] [stderr] | [INFO] [stderr] 78 | self.tima.wrapping_add(0x01); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this returns the result of the operation, without modifying the original [INFO] [stderr] [INFO] [stderr] warning: 102 warnings emitted [INFO] [stderr] [INFO] [stderr] warning: 107 warnings emitted [INFO] [stderr] [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 3.19s [INFO] running `"docker" "inspect" "565ecebd1705e3f8b46cd456c97146d7ec9c04bb778dedfc2fe31a1e7fee6a5d"` [INFO] running `"docker" "rm" "-f" "565ecebd1705e3f8b46cd456c97146d7ec9c04bb778dedfc2fe31a1e7fee6a5d"` [INFO] [stdout] 565ecebd1705e3f8b46cd456c97146d7ec9c04bb778dedfc2fe31a1e7fee6a5d [INFO] running `"docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "MAP_USER_ID=0" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--network" "none" "rustops/crates-build-env" "/opt/rustwide/cargo-home/bin/cargo" "+beta-2020-06-03" "test" "--frozen"` [INFO] [stdout] d8ba6c3e282938810a28021e006e24e3ce91e5742ee817c41c25fbb0e946bec8 [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] running `"docker" "start" "-a" "d8ba6c3e282938810a28021e006e24e3ce91e5742ee817c41c25fbb0e946bec8"` [INFO] [stderr] sudo: setrlimit(RLIMIT_CORE): Operation not permitted [INFO] [stderr] warning: unused import: `gameboy::interconnect::Interconnect` [INFO] [stderr] --> src/gameboy/cartridge.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use gameboy::interconnect::Interconnect; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `gameboy::Memory` [INFO] [stderr] --> src/gameboy/cartridge.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use gameboy::Memory; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | pub mbc: Box, [INFO] [stderr] | ^^^ help: use `dyn`: `dyn MBC` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:44:49 [INFO] [stderr] | [INFO] [stderr] 44 | fn get_controller(b: u8, rom: &[u8]) -> Box { [INFO] [stderr] | ^^^ help: use `dyn`: `dyn MBC` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | 0x01...0x03 => Box::new(MBC1::new(rom)), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:54:23 [INFO] [stderr] | [INFO] [stderr] 54 | type Target = Box; [INFO] [stderr] | ^^^ help: use `dyn`: `dyn MBC` [INFO] [stderr] [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Interconnect` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | use gameboy::{Interconnect, Interrupt, Irq, Memory}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:150:25 [INFO] [stderr] | [INFO] [stderr] 150 | 0x04...0x07 => self.timer.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:152:25 [INFO] [stderr] | [INFO] [stderr] 152 | 0x10...0x26 => (), // println!("err: write to sound driver not supported"), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:153:25 [INFO] [stderr] | [INFO] [stderr] 153 | 0x30...0x3F => (), // println!("err: write to wave pattern RAM not supported"), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:154:25 [INFO] [stderr] | [INFO] [stderr] 154 | 0x40...0x45 => self.gpu.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:155:25 [INFO] [stderr] | [INFO] [stderr] 155 | 0x47...0x49 => self.gpu.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:164:25 [INFO] [stderr] | [INFO] [stderr] 164 | 0x4A...0x4B => self.gpu.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:201:25 [INFO] [stderr] | [INFO] [stderr] 201 | 0x04...0x07 => self.timer.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:203:25 [INFO] [stderr] | [INFO] [stderr] 203 | 0x10...0x26 => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:207:25 [INFO] [stderr] | [INFO] [stderr] 207 | 0x30...0x3F => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:211:25 [INFO] [stderr] | [INFO] [stderr] 211 | 0x40...0x45 => self.gpu.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:212:25 [INFO] [stderr] | [INFO] [stderr] 212 | 0x47...0x49 => self.gpu.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:213:25 [INFO] [stderr] | [INFO] [stderr] 213 | 0x4A...0x4B => self.gpu.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Range` [INFO] [stderr] --> src/gameboy/mbc/mbc.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ops::Range; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Range` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::ops::Range; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Range` [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ops::Range; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:93:19 [INFO] [stderr] | [INFO] [stderr] 93 | 0x0000...0x1FFF => self.ram_enabled = (b & 0x0F) == 0x0A, // lower 4 bits only [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:94:19 [INFO] [stderr] | [INFO] [stderr] 94 | 0x2000...0x3FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:98:19 [INFO] [stderr] | [INFO] [stderr] 98 | 0x4000...0x5FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:103:37 [INFO] [stderr] | [INFO] [stderr] 103 | self.ram_bank = (b as usize & 0x03); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:106:19 [INFO] [stderr] | [INFO] [stderr] 106 | 0x6000...0x7FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:56:23 [INFO] [stderr] | [INFO] [stderr] 56 | CART_ROM_START...CART_ROM_END => Address::CartRom(virtual_address - CART_ROM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:57:23 [INFO] [stderr] | [INFO] [stderr] 57 | CART_RAM_START...CART_RAM_END => Address::CartRam(virtual_address - CART_RAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:58:22 [INFO] [stderr] | [INFO] [stderr] 58 | GFX_RAM_START...GFX_RAM_END => Address::Gfx(virtual_address - GFX_RAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:59:18 [INFO] [stderr] | [INFO] [stderr] 59 | RAM_START...RAM_END => Address::Ram(virtual_address - RAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:60:25 [INFO] [stderr] | [INFO] [stderr] 60 | RAM_SHADOW_START...RAM_SHADOW_END => Address::RamShadow(virtual_address - RAM_SHADOW_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | IO_START...IO_END => Address::Io(virtual_address - IO_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:62:19 [INFO] [stderr] | [INFO] [stderr] 62 | ZRAM_START...ZRAM_END => Address::ZRam(virtual_address - ZRAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:63:30 [INFO] [stderr] | [INFO] [stderr] 63 | GFX_SPRITE_INFO_START...GFX_SPRITE_INFO_END => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:66:28 [INFO] [stderr] | [INFO] [stderr] 66 | UNUSED_MEMORY_START...UNUSED_MEMORY_END => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:78:23 [INFO] [stderr] | [INFO] [stderr] 78 | CART_RAM_START...CART_RAM_END => virtual_address - CART_RAM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:79:23 [INFO] [stderr] | [INFO] [stderr] 79 | CART_ROM_START...CART_ROM_END => virtual_address - CART_ROM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:80:22 [INFO] [stderr] | [INFO] [stderr] 80 | GFX_RAM_START...GFX_RAM_END => virtual_address - GFX_RAM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | RAM_START...RAM_END => virtual_address - RAM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:82:25 [INFO] [stderr] | [INFO] [stderr] 82 | RAM_SHADOW_START...RAM_SHADOW_END => virtual_address - RAM_SHADOW_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | IO_START...IO_END => (virtual_address - IO_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:84:19 [INFO] [stderr] | [INFO] [stderr] 84 | ZRAM_START...ZRAM_END => (virtual_address - ZRAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:85:30 [INFO] [stderr] | [INFO] [stderr] 85 | GFX_SPRITE_INFO_START...GFX_SPRITE_INFO_END => virtual_address - GFX_SPRITE_INFO_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:86:28 [INFO] [stderr] | [INFO] [stderr] 86 | UNUSED_MEMORY_START...UNUSED_MEMORY_END => virtual_address - UNUSED_MEMORY_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unnecessary trailing semicolon [INFO] [stderr] --> src/gameboy/registers.rs:88:47 [INFO] [stderr] | [INFO] [stderr] 88 | println!("DE: {:02X}", self.get_de());; [INFO] [stderr] | ^ help: remove this semicolon [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary trailing semicolon [INFO] [stderr] --> src/gameboy/registers.rs:89:47 [INFO] [stderr] | [INFO] [stderr] 89 | println!("HL: {:02X}", self.get_hl());; [INFO] [stderr] | ^ help: remove this semicolon [INFO] [stderr] [INFO] [stderr] warning: unused import: `Interconnect` [INFO] [stderr] --> src/gameboy/timer.rs:1:31 [INFO] [stderr] | [INFO] [stderr] 1 | use gameboy::{MAX_CPU_CYCLES, Interconnect, Irq, Interrupt}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::marker::PhantomData` [INFO] [stderr] --> src/gameboy/ui/ui.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::marker::PhantomData; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `UiCell` [INFO] [stderr] --> src/gameboy/ui/ui.rs:5:68 [INFO] [stderr] | [INFO] [stderr] 5 | use conrod::{widget, Colorable, Labelable, Positionable, Sizeable, UiCell, Widget}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `gfx_core::factory::Factory` [INFO] [stderr] --> src/gameboy/ui/ui.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use gfx_core::factory::Factory; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `PistonWindow`, `WindowSettings`, `Window` [INFO] [stderr] --> src/gameboy/ui/ui.rs:12:21 [INFO] [stderr] | [INFO] [stderr] 12 | use piston_window::{PistonWindow, UpdateEvent, Window, WindowSettings}; [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `gameboy::interconnect::Interconnect` [INFO] [stderr] --> src/gameboy/cartridge.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use gameboy::interconnect::Interconnect; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Flip` [INFO] [stderr] --> src/gameboy/ui/ui.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | use piston_window::{Flip, G2d, G2dTexture, Texture, TextureSettings}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `gameboy::Memory` [INFO] [stderr] --> src/gameboy/cartridge.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use gameboy::Memory; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `gameboy::ui::theme::Theme` [INFO] [stderr] --> src/gameboy/ui/ui.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use gameboy::ui::theme::Theme; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | pub mbc: Box, [INFO] [stderr] | ^^^ help: use `dyn`: `dyn MBC` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stderr] [INFO] [stderr] warning: the item `Align` is imported redundantly [INFO] [stderr] --> src/gameboy/ui/ui.rs:213:32 [INFO] [stderr] | [INFO] [stderr] 6 | use conrod::position::{Align, Relative}; [INFO] [stderr] | ----- the item `Align` is already imported here [INFO] [stderr] ... [INFO] [stderr] 213 | use conrod::position::{Align, Direction, Padding, Position, Relative}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:44:49 [INFO] [stderr] | [INFO] [stderr] 44 | fn get_controller(b: u8, rom: &[u8]) -> Box { [INFO] [stderr] | ^^^ help: use `dyn`: `dyn MBC` [INFO] [stderr] [INFO] [stderr] warning: the item `Relative` is imported redundantly [INFO] [stderr] --> src/gameboy/ui/ui.rs:213:69 [INFO] [stderr] | [INFO] [stderr] 6 | use conrod::position::{Align, Relative}; [INFO] [stderr] | -------- the item `Relative` is already imported here [INFO] [stderr] ... [INFO] [stderr] 213 | use conrod::position::{Align, Direction, Padding, Position, Relative}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | 0x01...0x03 => Box::new(MBC1::new(rom)), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:54:23 [INFO] [stderr] | [INFO] [stderr] 54 | type Target = Box; [INFO] [stderr] | ^^^ help: use `dyn`: `dyn MBC` [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/gameboy/interconnect.rs:225:9 [INFO] [stderr] | [INFO] [stderr] 224 | panic!("CALLED, APPARENTLY"); [INFO] [stderr] | ----------------------------- any code following this expression is unreachable [INFO] [stderr] 225 | let cart = self.cart.as_ref().expect("Cartridge is empty"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable statement [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gameboy/cpu.rs:715:17 [INFO] [stderr] | [INFO] [stderr] 715 | _ => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Interconnect` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | use gameboy::{Interconnect, Interrupt, Irq, Memory}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gameboy/memory_map.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | _ => panic!("Address {:#X} outside valid memory.", virtual_address), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:150:25 [INFO] [stderr] | [INFO] [stderr] 150 | 0x04...0x07 => self.timer.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gameboy/memory_map.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | _ => panic!("Address {:#X} outside valid memory.", virtual_address), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:152:25 [INFO] [stderr] | [INFO] [stderr] 152 | 0x10...0x26 => (), // println!("err: write to sound driver not supported"), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused variable: `operand` [INFO] [stderr] --> src/gameboy/cpu.rs:451:17 [INFO] [stderr] | [INFO] [stderr] 451 | let operand = self.get_operand_from_opcode(interconnect, &opcode); [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_operand` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:153:25 [INFO] [stderr] | [INFO] [stderr] 153 | 0x30...0x3F => (), // println!("err: write to wave pattern RAM not supported"), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused variable: `above_background` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:232:21 [INFO] [stderr] | [INFO] [stderr] 232 | let above_background = attributes & 0x80 == 0x00; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_above_background` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:154:25 [INFO] [stderr] | [INFO] [stderr] 154 | 0x40...0x45 => self.gpu.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused variable: `flip_y` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:233:21 [INFO] [stderr] | [INFO] [stderr] 233 | let flip_y = attributes & 0x40 == 0x40; [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_flip_y` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:155:25 [INFO] [stderr] | [INFO] [stderr] 155 | 0x47...0x49 => self.gpu.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:169:46 [INFO] [stderr] | [INFO] [stderr] 169 | Address::InterruptEnableRegister(a) => self.irq.enable_flag = byte, [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:164:25 [INFO] [stderr] | [INFO] [stderr] 164 | 0x4A...0x4B => self.gpu.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:218:46 [INFO] [stderr] | [INFO] [stderr] 218 | Address::InterruptEnableRegister(a) => self.irq.enable_flag, [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:201:25 [INFO] [stderr] | [INFO] [stderr] 201 | 0x04...0x07 => self.timer.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cart` [INFO] [stderr] --> src/gameboy/interconnect.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | let cart = self.cart.as_ref().expect("Cartridge is empty"); [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_cart` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:203:25 [INFO] [stderr] | [INFO] [stderr] 203 | 0x10...0x26 => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:229:27 [INFO] [stderr] | [INFO] [stderr] 229 | Address::ZRam(a) => self.zram.read_bytes(r), [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:207:25 [INFO] [stderr] | [INFO] [stderr] 207 | 0x30...0x3F => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:230:25 [INFO] [stderr] | [INFO] [stderr] 230 | Address::Io(a) => self.mmap_io.read_bytes(r), [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:211:25 [INFO] [stderr] | [INFO] [stderr] 211 | 0x40...0x45 => self.gpu.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r` [INFO] [stderr] --> src/gameboy/interconnect.rs:223:30 [INFO] [stderr] | [INFO] [stderr] 223 | pub fn read_bytes(&self, r: Range) -> &[u8] { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_r` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:212:25 [INFO] [stderr] | [INFO] [stderr] 212 | 0x47...0x49 => self.gpu.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cart` [INFO] [stderr] --> src/gameboy/interconnect.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | let cart = self.cart.as_mut().expect("Cartridge is empty"); [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_cart` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:213:25 [INFO] [stderr] | [INFO] [stderr] 213 | 0x4A...0x4B => self.gpu.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bytes` [INFO] [stderr] --> src/gameboy/interconnect.rs:273:46 [INFO] [stderr] | [INFO] [stderr] 273 | pub fn write_bytes(&mut self, addr: u16, bytes: &[u8]) { [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_bytes` [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Range` [INFO] [stderr] --> src/gameboy/mbc/mbc.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ops::Range; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:44:32 [INFO] [stderr] | [INFO] [stderr] 44 | fn write_ram_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Range` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::ops::Range; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Range` [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ops::Range; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:44:43 [INFO] [stderr] | [INFO] [stderr] 44 | fn write_ram_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:93:19 [INFO] [stderr] | [INFO] [stderr] 93 | 0x0000...0x1FFF => self.ram_enabled = (b & 0x0F) == 0x0A, // lower 4 bits only [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:48:32 [INFO] [stderr] | [INFO] [stderr] 48 | fn write_rom_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:94:19 [INFO] [stderr] | [INFO] [stderr] 94 | 0x2000...0x3FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:48:43 [INFO] [stderr] | [INFO] [stderr] 48 | fn write_rom_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:98:19 [INFO] [stderr] | [INFO] [stderr] 98 | 0x4000...0x5FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bg_color` [INFO] [stderr] --> src/gameboy/ui/ui.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | let mut bg_color = conrod::color::LIGHT_BLUE; [INFO] [stderr] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_bg_color` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v` [INFO] [stderr] --> src/gameboy/ui/ui.rs:169:21 [INFO] [stderr] | [INFO] [stderr] 169 | for v in item.set(toggle, &mut ui) { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:64:14 [INFO] [stderr] | [INFO] [stderr] 64 | let (mut glyph_cache, mut text_texture_cache) = { [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:64:31 [INFO] [stderr] | [INFO] [stderr] 64 | let (mut glyph_cache, mut text_texture_cache) = { [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | let mut bg_color = conrod::color::LIGHT_BLUE; [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | let mut result = UIEvent::None; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_MEM_SIZE` [INFO] [stderr] --> src/gameboy/cartridge.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | const CART_MEM_SIZE: usize = 0x200000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_RAM_SIZE` [INFO] [stderr] --> src/gameboy/cartridge.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | const CART_RAM_SIZE: usize = 0x8000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `rom_code_size` [INFO] [stderr] --> src/gameboy/cartridge.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | rom_code_size: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `DisassembledLine` [INFO] [stderr] --> src/gameboy/disassembler/disassembled_line.rs:4:12 [INFO] [stderr] | [INFO] [stderr] 4 | pub struct DisassembledLine { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `counter` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | counter: u8, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `BIOS_START` [INFO] [stderr] --> src/gameboy/memory_map.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | const BIOS_START: u16 = 0x0000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `BIOS_END` [INFO] [stderr] --> src/gameboy/memory_map.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | const BIOS_END: u16 = 0x00FF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_HEADER_START` [INFO] [stderr] --> src/gameboy/memory_map.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | const CART_HEADER_START: u16 = 0x0100; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_HEADER_END` [INFO] [stderr] --> src/gameboy/memory_map.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | const CART_HEADER_END: u16 = 0x014F; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Bios` [INFO] [stderr] --> src/gameboy/memory_map.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | Bios(u8), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CartHeader` [INFO] [stderr] --> src/gameboy/memory_map.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | CartHeader(u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CartRomOtherBank` [INFO] [stderr] --> src/gameboy/memory_map.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | CartRomOtherBank(u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ExternalRam` [INFO] [stderr] --> src/gameboy/memory_map.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | ExternalRam(u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `map_address_unwrap` [INFO] [stderr] --> src/gameboy/memory_map.rs:76:8 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn map_address_unwrap(virtual_address: u16) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `text_vertex_data` [INFO] [stderr] --> src/gameboy/ui/ui.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | text_vertex_data: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `selected_theme` [INFO] [stderr] --> src/gameboy/ui/ui.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | selected_theme: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `OAM_interrupt_enabled` should have a snake case name [INFO] [stderr] --> src/gameboy/gfx/stat.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | pub OAM_interrupt_enabled: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `oam_interrupt_enabled` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `VBlank_interrupt_enabled` should have a snake case name [INFO] [stderr] --> src/gameboy/gfx/stat.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | pub VBlank_interrupt_enabled: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `vblank_interrupt_enabled` [INFO] [stderr] [INFO] [stderr] warning: structure field `HBlank_interrupt_enabled` should have a snake case name [INFO] [stderr] --> src/gameboy/gfx/stat.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | pub HBlank_interrupt_enabled: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `hblank_interrupt_enabled` [INFO] [stderr] [INFO] [stderr] warning: unused return value of `core::num::::wrapping_add` that must be used [INFO] [stderr] --> src/gameboy/timer.rs:78:17 [INFO] [stderr] | [INFO] [stderr] 78 | self.tima.wrapping_add(0x01); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_must_use)]` on by default [INFO] [stderr] = note: this returns the result of the operation, without modifying the original [INFO] [stderr] [INFO] [stderr] warning: 102 warnings emitted [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:103:37 [INFO] [stderr] | [INFO] [stderr] 103 | self.ram_bank = (b as usize & 0x03); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:106:19 [INFO] [stderr] | [INFO] [stderr] 106 | 0x6000...0x7FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:56:23 [INFO] [stderr] | [INFO] [stderr] 56 | CART_ROM_START...CART_ROM_END => Address::CartRom(virtual_address - CART_ROM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:57:23 [INFO] [stderr] | [INFO] [stderr] 57 | CART_RAM_START...CART_RAM_END => Address::CartRam(virtual_address - CART_RAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:58:22 [INFO] [stderr] | [INFO] [stderr] 58 | GFX_RAM_START...GFX_RAM_END => Address::Gfx(virtual_address - GFX_RAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:59:18 [INFO] [stderr] | [INFO] [stderr] 59 | RAM_START...RAM_END => Address::Ram(virtual_address - RAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:60:25 [INFO] [stderr] | [INFO] [stderr] 60 | RAM_SHADOW_START...RAM_SHADOW_END => Address::RamShadow(virtual_address - RAM_SHADOW_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | IO_START...IO_END => Address::Io(virtual_address - IO_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:62:19 [INFO] [stderr] | [INFO] [stderr] 62 | ZRAM_START...ZRAM_END => Address::ZRam(virtual_address - ZRAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:63:30 [INFO] [stderr] | [INFO] [stderr] 63 | GFX_SPRITE_INFO_START...GFX_SPRITE_INFO_END => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:66:28 [INFO] [stderr] | [INFO] [stderr] 66 | UNUSED_MEMORY_START...UNUSED_MEMORY_END => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:78:23 [INFO] [stderr] | [INFO] [stderr] 78 | CART_RAM_START...CART_RAM_END => virtual_address - CART_RAM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:79:23 [INFO] [stderr] | [INFO] [stderr] 79 | CART_ROM_START...CART_ROM_END => virtual_address - CART_ROM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:80:22 [INFO] [stderr] | [INFO] [stderr] 80 | GFX_RAM_START...GFX_RAM_END => virtual_address - GFX_RAM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | RAM_START...RAM_END => virtual_address - RAM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:82:25 [INFO] [stderr] | [INFO] [stderr] 82 | RAM_SHADOW_START...RAM_SHADOW_END => virtual_address - RAM_SHADOW_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | IO_START...IO_END => (virtual_address - IO_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:84:19 [INFO] [stderr] | [INFO] [stderr] 84 | ZRAM_START...ZRAM_END => (virtual_address - ZRAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:85:30 [INFO] [stderr] | [INFO] [stderr] 85 | GFX_SPRITE_INFO_START...GFX_SPRITE_INFO_END => virtual_address - GFX_SPRITE_INFO_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:86:28 [INFO] [stderr] | [INFO] [stderr] 86 | UNUSED_MEMORY_START...UNUSED_MEMORY_END => virtual_address - UNUSED_MEMORY_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unnecessary trailing semicolon [INFO] [stderr] --> src/gameboy/registers.rs:88:47 [INFO] [stderr] | [INFO] [stderr] 88 | println!("DE: {:02X}", self.get_de());; [INFO] [stderr] | ^ help: remove this semicolon [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary trailing semicolon [INFO] [stderr] --> src/gameboy/registers.rs:89:47 [INFO] [stderr] | [INFO] [stderr] 89 | println!("HL: {:02X}", self.get_hl());; [INFO] [stderr] | ^ help: remove this semicolon [INFO] [stderr] [INFO] [stderr] warning: unused import: `Interconnect` [INFO] [stderr] --> src/gameboy/timer.rs:1:31 [INFO] [stderr] | [INFO] [stderr] 1 | use gameboy::{MAX_CPU_CYCLES, Interconnect, Irq, Interrupt}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::marker::PhantomData` [INFO] [stderr] --> src/gameboy/ui/ui.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::marker::PhantomData; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `UiCell` [INFO] [stderr] --> src/gameboy/ui/ui.rs:5:68 [INFO] [stderr] | [INFO] [stderr] 5 | use conrod::{widget, Colorable, Labelable, Positionable, Sizeable, UiCell, Widget}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `gfx_core::factory::Factory` [INFO] [stderr] --> src/gameboy/ui/ui.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use gfx_core::factory::Factory; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `PistonWindow`, `WindowSettings`, `Window` [INFO] [stderr] --> src/gameboy/ui/ui.rs:12:21 [INFO] [stderr] | [INFO] [stderr] 12 | use piston_window::{PistonWindow, UpdateEvent, Window, WindowSettings}; [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Flip` [INFO] [stderr] --> src/gameboy/ui/ui.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | use piston_window::{Flip, G2d, G2dTexture, Texture, TextureSettings}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `gameboy::ui::theme::Theme` [INFO] [stderr] --> src/gameboy/ui/ui.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use gameboy::ui::theme::Theme; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the item `Align` is imported redundantly [INFO] [stderr] --> src/gameboy/ui/ui.rs:213:32 [INFO] [stderr] | [INFO] [stderr] 6 | use conrod::position::{Align, Relative}; [INFO] [stderr] | ----- the item `Align` is already imported here [INFO] [stderr] ... [INFO] [stderr] 213 | use conrod::position::{Align, Direction, Padding, Position, Relative}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the item `Relative` is imported redundantly [INFO] [stderr] --> src/gameboy/ui/ui.rs:213:69 [INFO] [stderr] | [INFO] [stderr] 6 | use conrod::position::{Align, Relative}; [INFO] [stderr] | -------- the item `Relative` is already imported here [INFO] [stderr] ... [INFO] [stderr] 213 | use conrod::position::{Align, Direction, Padding, Position, Relative}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/gameboy/interconnect.rs:225:9 [INFO] [stderr] | [INFO] [stderr] 224 | panic!("CALLED, APPARENTLY"); [INFO] [stderr] | ----------------------------- any code following this expression is unreachable [INFO] [stderr] 225 | let cart = self.cart.as_ref().expect("Cartridge is empty"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable statement [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gameboy/cpu.rs:715:17 [INFO] [stderr] | [INFO] [stderr] 715 | _ => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gameboy/memory_map.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | _ => panic!("Address {:#X} outside valid memory.", virtual_address), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gameboy/memory_map.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | _ => panic!("Address {:#X} outside valid memory.", virtual_address), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `operand` [INFO] [stderr] --> src/gameboy/cpu.rs:451:17 [INFO] [stderr] | [INFO] [stderr] 451 | let operand = self.get_operand_from_opcode(interconnect, &opcode); [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_operand` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `above_background` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:232:21 [INFO] [stderr] | [INFO] [stderr] 232 | let above_background = attributes & 0x80 == 0x00; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_above_background` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `flip_y` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:233:21 [INFO] [stderr] | [INFO] [stderr] 233 | let flip_y = attributes & 0x40 == 0x40; [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_flip_y` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:169:46 [INFO] [stderr] | [INFO] [stderr] 169 | Address::InterruptEnableRegister(a) => self.irq.enable_flag = byte, [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:218:46 [INFO] [stderr] | [INFO] [stderr] 218 | Address::InterruptEnableRegister(a) => self.irq.enable_flag, [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cart` [INFO] [stderr] --> src/gameboy/interconnect.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | let cart = self.cart.as_ref().expect("Cartridge is empty"); [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_cart` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:229:27 [INFO] [stderr] | [INFO] [stderr] 229 | Address::ZRam(a) => self.zram.read_bytes(r), [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:230:25 [INFO] [stderr] | [INFO] [stderr] 230 | Address::Io(a) => self.mmap_io.read_bytes(r), [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r` [INFO] [stderr] --> src/gameboy/interconnect.rs:223:30 [INFO] [stderr] | [INFO] [stderr] 223 | pub fn read_bytes(&self, r: Range) -> &[u8] { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_r` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cart` [INFO] [stderr] --> src/gameboy/interconnect.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | let cart = self.cart.as_mut().expect("Cartridge is empty"); [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_cart` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bytes` [INFO] [stderr] --> src/gameboy/interconnect.rs:273:46 [INFO] [stderr] | [INFO] [stderr] 273 | pub fn write_bytes(&mut self, addr: u16, bytes: &[u8]) { [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_bytes` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:44:32 [INFO] [stderr] | [INFO] [stderr] 44 | fn write_ram_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:44:43 [INFO] [stderr] | [INFO] [stderr] 44 | fn write_ram_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:48:32 [INFO] [stderr] | [INFO] [stderr] 48 | fn write_rom_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:48:43 [INFO] [stderr] | [INFO] [stderr] 48 | fn write_rom_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bg_color` [INFO] [stderr] --> src/gameboy/ui/ui.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | let mut bg_color = conrod::color::LIGHT_BLUE; [INFO] [stderr] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_bg_color` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v` [INFO] [stderr] --> src/gameboy/ui/ui.rs:169:21 [INFO] [stderr] | [INFO] [stderr] 169 | for v in item.set(toggle, &mut ui) { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:64:14 [INFO] [stderr] | [INFO] [stderr] 64 | let (mut glyph_cache, mut text_texture_cache) = { [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:64:31 [INFO] [stderr] | [INFO] [stderr] 64 | let (mut glyph_cache, mut text_texture_cache) = { [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | let mut bg_color = conrod::color::LIGHT_BLUE; [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | let mut result = UIEvent::None; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_MEM_SIZE` [INFO] [stderr] --> src/gameboy/cartridge.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | const CART_MEM_SIZE: usize = 0x200000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_RAM_SIZE` [INFO] [stderr] --> src/gameboy/cartridge.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | const CART_RAM_SIZE: usize = 0x8000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `rom_code_size` [INFO] [stderr] --> src/gameboy/cartridge.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | rom_code_size: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `DisassembledLine` [INFO] [stderr] --> src/gameboy/disassembler/disassembled_line.rs:4:12 [INFO] [stderr] | [INFO] [stderr] 4 | pub struct DisassembledLine { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `counter` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | counter: u8, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `BIOS_START` [INFO] [stderr] --> src/gameboy/memory_map.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | const BIOS_START: u16 = 0x0000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `BIOS_END` [INFO] [stderr] --> src/gameboy/memory_map.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | const BIOS_END: u16 = 0x00FF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_HEADER_START` [INFO] [stderr] --> src/gameboy/memory_map.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | const CART_HEADER_START: u16 = 0x0100; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_HEADER_END` [INFO] [stderr] --> src/gameboy/memory_map.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | const CART_HEADER_END: u16 = 0x014F; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Bios` [INFO] [stderr] --> src/gameboy/memory_map.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | Bios(u8), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CartHeader` [INFO] [stderr] --> src/gameboy/memory_map.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | CartHeader(u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CartRomOtherBank` [INFO] [stderr] --> src/gameboy/memory_map.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | CartRomOtherBank(u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ExternalRam` [INFO] [stderr] --> src/gameboy/memory_map.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | ExternalRam(u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `map_address_unwrap` [INFO] [stderr] --> src/gameboy/memory_map.rs:76:8 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn map_address_unwrap(virtual_address: u16) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `text_vertex_data` [INFO] [stderr] --> src/gameboy/ui/ui.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | text_vertex_data: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `selected_theme` [INFO] [stderr] --> src/gameboy/ui/ui.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | selected_theme: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `OAM_interrupt_enabled` should have a snake case name [INFO] [stderr] --> src/gameboy/gfx/stat.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | pub OAM_interrupt_enabled: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `oam_interrupt_enabled` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `VBlank_interrupt_enabled` should have a snake case name [INFO] [stderr] --> src/gameboy/gfx/stat.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | pub VBlank_interrupt_enabled: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `vblank_interrupt_enabled` [INFO] [stderr] [INFO] [stderr] warning: structure field `HBlank_interrupt_enabled` should have a snake case name [INFO] [stderr] --> src/gameboy/gfx/stat.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | pub HBlank_interrupt_enabled: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `hblank_interrupt_enabled` [INFO] [stderr] [INFO] [stderr] warning: unused return value of `core::num::::wrapping_add` that must be used [INFO] [stderr] --> src/gameboy/timer.rs:78:17 [INFO] [stderr] | [INFO] [stderr] 78 | self.tima.wrapping_add(0x01); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_must_use)]` on by default [INFO] [stderr] = note: this returns the result of the operation, without modifying the original [INFO] [stderr] [INFO] [stderr] warning: 102 warnings emitted [INFO] [stderr] [INFO] [stderr] warning: unused import: `gameboy::interconnect::Interconnect` [INFO] [stderr] --> src/gameboy/cartridge.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use gameboy::interconnect::Interconnect; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `gameboy::Memory` [INFO] [stderr] --> src/gameboy/cartridge.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use gameboy::Memory; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | pub mbc: Box, [INFO] [stderr] | ^^^ help: use `dyn`: `dyn MBC` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:44:49 [INFO] [stderr] | [INFO] [stderr] 44 | fn get_controller(b: u8, rom: &[u8]) -> Box { [INFO] [stderr] | ^^^ help: use `dyn`: `dyn MBC` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | 0x01...0x03 => Box::new(MBC1::new(rom)), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/gameboy/cartridge.rs:54:23 [INFO] [stderr] | [INFO] [stderr] 54 | type Target = Box; [INFO] [stderr] | ^^^ help: use `dyn`: `dyn MBC` [INFO] [stderr] [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Interconnect` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | use gameboy::{Interconnect, Interrupt, Irq, Memory}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:150:25 [INFO] [stderr] | [INFO] [stderr] 150 | 0x04...0x07 => self.timer.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:152:25 [INFO] [stderr] | [INFO] [stderr] 152 | 0x10...0x26 => (), // println!("err: write to sound driver not supported"), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:153:25 [INFO] [stderr] | [INFO] [stderr] 153 | 0x30...0x3F => (), // println!("err: write to wave pattern RAM not supported"), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:154:25 [INFO] [stderr] | [INFO] [stderr] 154 | 0x40...0x45 => self.gpu.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:155:25 [INFO] [stderr] | [INFO] [stderr] 155 | 0x47...0x49 => self.gpu.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:164:25 [INFO] [stderr] | [INFO] [stderr] 164 | 0x4A...0x4B => self.gpu.write_u8(a, byte), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:201:25 [INFO] [stderr] | [INFO] [stderr] 201 | 0x04...0x07 => self.timer.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:203:25 [INFO] [stderr] | [INFO] [stderr] 203 | 0x10...0x26 => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:207:25 [INFO] [stderr] | [INFO] [stderr] 207 | 0x30...0x3F => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:211:25 [INFO] [stderr] | [INFO] [stderr] 211 | 0x40...0x45 => self.gpu.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:212:25 [INFO] [stderr] | [INFO] [stderr] 212 | 0x47...0x49 => self.gpu.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/interconnect.rs:213:25 [INFO] [stderr] | [INFO] [stderr] 213 | 0x4A...0x4B => self.gpu.read_u8(a), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Range` [INFO] [stderr] --> src/gameboy/mbc/mbc.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ops::Range; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Range` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::ops::Range; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Range` [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ops::Range; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:93:19 [INFO] [stderr] | [INFO] [stderr] 93 | 0x0000...0x1FFF => self.ram_enabled = (b & 0x0F) == 0x0A, // lower 4 bits only [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:94:19 [INFO] [stderr] | [INFO] [stderr] 94 | 0x2000...0x3FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:98:19 [INFO] [stderr] | [INFO] [stderr] 98 | 0x4000...0x5FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:103:37 [INFO] [stderr] | [INFO] [stderr] 103 | self.ram_bank = (b as usize & 0x03); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/mbc/mbc1.rs:106:19 [INFO] [stderr] | [INFO] [stderr] 106 | 0x6000...0x7FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:56:23 [INFO] [stderr] | [INFO] [stderr] 56 | CART_ROM_START...CART_ROM_END => Address::CartRom(virtual_address - CART_ROM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:57:23 [INFO] [stderr] | [INFO] [stderr] 57 | CART_RAM_START...CART_RAM_END => Address::CartRam(virtual_address - CART_RAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:58:22 [INFO] [stderr] | [INFO] [stderr] 58 | GFX_RAM_START...GFX_RAM_END => Address::Gfx(virtual_address - GFX_RAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:59:18 [INFO] [stderr] | [INFO] [stderr] 59 | RAM_START...RAM_END => Address::Ram(virtual_address - RAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:60:25 [INFO] [stderr] | [INFO] [stderr] 60 | RAM_SHADOW_START...RAM_SHADOW_END => Address::RamShadow(virtual_address - RAM_SHADOW_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | IO_START...IO_END => Address::Io(virtual_address - IO_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:62:19 [INFO] [stderr] | [INFO] [stderr] 62 | ZRAM_START...ZRAM_END => Address::ZRam(virtual_address - ZRAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:63:30 [INFO] [stderr] | [INFO] [stderr] 63 | GFX_SPRITE_INFO_START...GFX_SPRITE_INFO_END => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:66:28 [INFO] [stderr] | [INFO] [stderr] 66 | UNUSED_MEMORY_START...UNUSED_MEMORY_END => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:78:23 [INFO] [stderr] | [INFO] [stderr] 78 | CART_RAM_START...CART_RAM_END => virtual_address - CART_RAM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:79:23 [INFO] [stderr] | [INFO] [stderr] 79 | CART_ROM_START...CART_ROM_END => virtual_address - CART_ROM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:80:22 [INFO] [stderr] | [INFO] [stderr] 80 | GFX_RAM_START...GFX_RAM_END => virtual_address - GFX_RAM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | RAM_START...RAM_END => virtual_address - RAM_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:82:25 [INFO] [stderr] | [INFO] [stderr] 82 | RAM_SHADOW_START...RAM_SHADOW_END => virtual_address - RAM_SHADOW_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | IO_START...IO_END => (virtual_address - IO_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:84:19 [INFO] [stderr] | [INFO] [stderr] 84 | ZRAM_START...ZRAM_END => (virtual_address - ZRAM_START), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:85:30 [INFO] [stderr] | [INFO] [stderr] 85 | GFX_SPRITE_INFO_START...GFX_SPRITE_INFO_END => virtual_address - GFX_SPRITE_INFO_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gameboy/memory_map.rs:86:28 [INFO] [stderr] | [INFO] [stderr] 86 | UNUSED_MEMORY_START...UNUSED_MEMORY_END => virtual_address - UNUSED_MEMORY_START, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unnecessary trailing semicolon [INFO] [stderr] --> src/gameboy/registers.rs:88:47 [INFO] [stderr] | [INFO] [stderr] 88 | println!("DE: {:02X}", self.get_de());; [INFO] [stderr] | ^ help: remove this semicolon [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary trailing semicolon [INFO] [stderr] --> src/gameboy/registers.rs:89:47 [INFO] [stderr] | [INFO] [stderr] 89 | println!("HL: {:02X}", self.get_hl());; [INFO] [stderr] | ^ help: remove this semicolon [INFO] [stderr] [INFO] [stderr] warning: unused import: `Interconnect` [INFO] [stderr] --> src/gameboy/timer.rs:1:31 [INFO] [stderr] | [INFO] [stderr] 1 | use gameboy::{MAX_CPU_CYCLES, Interconnect, Irq, Interrupt}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::marker::PhantomData` [INFO] [stderr] --> src/gameboy/ui/ui.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::marker::PhantomData; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `UiCell` [INFO] [stderr] --> src/gameboy/ui/ui.rs:5:68 [INFO] [stderr] | [INFO] [stderr] 5 | use conrod::{widget, Colorable, Labelable, Positionable, Sizeable, UiCell, Widget}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `gfx_core::factory::Factory` [INFO] [stderr] --> src/gameboy/ui/ui.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use gfx_core::factory::Factory; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `PistonWindow`, `WindowSettings`, `Window` [INFO] [stderr] --> src/gameboy/ui/ui.rs:12:21 [INFO] [stderr] | [INFO] [stderr] 12 | use piston_window::{PistonWindow, UpdateEvent, Window, WindowSettings}; [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Flip` [INFO] [stderr] --> src/gameboy/ui/ui.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | use piston_window::{Flip, G2d, G2dTexture, Texture, TextureSettings}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `gameboy::ui::theme::Theme` [INFO] [stderr] --> src/gameboy/ui/ui.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use gameboy::ui::theme::Theme; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the item `Align` is imported redundantly [INFO] [stderr] --> src/gameboy/ui/ui.rs:213:32 [INFO] [stderr] | [INFO] [stderr] 6 | use conrod::position::{Align, Relative}; [INFO] [stderr] | ----- the item `Align` is already imported here [INFO] [stderr] ... [INFO] [stderr] 213 | use conrod::position::{Align, Direction, Padding, Position, Relative}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the item `Relative` is imported redundantly [INFO] [stderr] --> src/gameboy/ui/ui.rs:213:69 [INFO] [stderr] | [INFO] [stderr] 6 | use conrod::position::{Align, Relative}; [INFO] [stderr] | -------- the item `Relative` is already imported here [INFO] [stderr] ... [INFO] [stderr] 213 | use conrod::position::{Align, Direction, Padding, Position, Relative}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Ui` [INFO] [stderr] --> src/main.rs:25:57 [INFO] [stderr] | [INFO] [stderr] 25 | use gameboy::{Cartridge, CpuSpeed, Frame, JoypadButton, Ui}; [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: unused label [INFO] [stderr] --> src/main.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | 'start: while let Some(e) = window.next() { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_labels)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/gameboy/interconnect.rs:225:9 [INFO] [stderr] | [INFO] [stderr] 224 | panic!("CALLED, APPARENTLY"); [INFO] [stderr] | ----------------------------- any code following this expression is unreachable [INFO] [stderr] 225 | let cart = self.cart.as_ref().expect("Cartridge is empty"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable statement [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gameboy/cpu.rs:715:17 [INFO] [stderr] | [INFO] [stderr] 715 | _ => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gameboy/memory_map.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | _ => panic!("Address {:#X} outside valid memory.", virtual_address), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gameboy/memory_map.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | _ => panic!("Address {:#X} outside valid memory.", virtual_address), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `debugger_enabled` [INFO] [stderr] --> src/main.rs:150:31 [INFO] [stderr] | [INFO] [stderr] 150 | fn create_window(title: S, debugger_enabled: bool) -> PistonWindow [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_debugger_enabled` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `operand` [INFO] [stderr] --> src/gameboy/cpu.rs:451:17 [INFO] [stderr] | [INFO] [stderr] 451 | let operand = self.get_operand_from_opcode(interconnect, &opcode); [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_operand` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `above_background` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:232:21 [INFO] [stderr] | [INFO] [stderr] 232 | let above_background = attributes & 0x80 == 0x00; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_above_background` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `flip_y` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:233:21 [INFO] [stderr] | [INFO] [stderr] 233 | let flip_y = attributes & 0x40 == 0x40; [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_flip_y` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:169:46 [INFO] [stderr] | [INFO] [stderr] 169 | Address::InterruptEnableRegister(a) => self.irq.enable_flag = byte, [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:218:46 [INFO] [stderr] | [INFO] [stderr] 218 | Address::InterruptEnableRegister(a) => self.irq.enable_flag, [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cart` [INFO] [stderr] --> src/gameboy/interconnect.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | let cart = self.cart.as_ref().expect("Cartridge is empty"); [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_cart` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:229:27 [INFO] [stderr] | [INFO] [stderr] 229 | Address::ZRam(a) => self.zram.read_bytes(r), [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/gameboy/interconnect.rs:230:25 [INFO] [stderr] | [INFO] [stderr] 230 | Address::Io(a) => self.mmap_io.read_bytes(r), [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r` [INFO] [stderr] --> src/gameboy/interconnect.rs:223:30 [INFO] [stderr] | [INFO] [stderr] 223 | pub fn read_bytes(&self, r: Range) -> &[u8] { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_r` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cart` [INFO] [stderr] --> src/gameboy/interconnect.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | let cart = self.cart.as_mut().expect("Cartridge is empty"); [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_cart` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bytes` [INFO] [stderr] --> src/gameboy/interconnect.rs:273:46 [INFO] [stderr] | [INFO] [stderr] 273 | pub fn write_bytes(&mut self, addr: u16, bytes: &[u8]) { [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_bytes` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:44:32 [INFO] [stderr] | [INFO] [stderr] 44 | fn write_ram_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:44:43 [INFO] [stderr] | [INFO] [stderr] 44 | fn write_ram_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:48:32 [INFO] [stderr] | [INFO] [stderr] 48 | fn write_rom_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/gameboy/mbc/mbc0.rs:48:43 [INFO] [stderr] | [INFO] [stderr] 48 | fn write_rom_u8(&mut self, addr: u16, b: u8) { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bg_color` [INFO] [stderr] --> src/gameboy/ui/ui.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | let mut bg_color = conrod::color::LIGHT_BLUE; [INFO] [stderr] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_bg_color` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v` [INFO] [stderr] --> src/gameboy/ui/ui.rs:169:21 [INFO] [stderr] | [INFO] [stderr] 169 | for v in item.set(toggle, &mut ui) { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:64:14 [INFO] [stderr] | [INFO] [stderr] 64 | let (mut glyph_cache, mut text_texture_cache) = { [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:64:31 [INFO] [stderr] | [INFO] [stderr] 64 | let (mut glyph_cache, mut text_texture_cache) = { [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | let mut bg_color = conrod::color::LIGHT_BLUE; [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gameboy/ui/ui.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | let mut result = UIEvent::None; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_MEM_SIZE` [INFO] [stderr] --> src/gameboy/cartridge.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | const CART_MEM_SIZE: usize = 0x200000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_RAM_SIZE` [INFO] [stderr] --> src/gameboy/cartridge.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | const CART_RAM_SIZE: usize = 0x8000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `rom_code_size` [INFO] [stderr] --> src/gameboy/cartridge.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | rom_code_size: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `DisassembledLine` [INFO] [stderr] --> src/gameboy/disassembler/disassembled_line.rs:4:12 [INFO] [stderr] | [INFO] [stderr] 4 | pub struct DisassembledLine { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `counter` [INFO] [stderr] --> src/gameboy/gfx/gpu.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | counter: u8, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `BIOS_START` [INFO] [stderr] --> src/gameboy/memory_map.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | const BIOS_START: u16 = 0x0000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `BIOS_END` [INFO] [stderr] --> src/gameboy/memory_map.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | const BIOS_END: u16 = 0x00FF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_HEADER_START` [INFO] [stderr] --> src/gameboy/memory_map.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | const CART_HEADER_START: u16 = 0x0100; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `CART_HEADER_END` [INFO] [stderr] --> src/gameboy/memory_map.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | const CART_HEADER_END: u16 = 0x014F; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Bios` [INFO] [stderr] --> src/gameboy/memory_map.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | Bios(u8), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CartHeader` [INFO] [stderr] --> src/gameboy/memory_map.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | CartHeader(u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CartRomOtherBank` [INFO] [stderr] --> src/gameboy/memory_map.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | CartRomOtherBank(u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ExternalRam` [INFO] [stderr] --> src/gameboy/memory_map.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | ExternalRam(u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `map_address_unwrap` [INFO] [stderr] --> src/gameboy/memory_map.rs:76:8 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn map_address_unwrap(virtual_address: u16) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `text_vertex_data` [INFO] [stderr] --> src/gameboy/ui/ui.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | text_vertex_data: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `selected_theme` [INFO] [stderr] --> src/gameboy/ui/ui.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | selected_theme: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | texture.update(&mut window.encoder, &imgbuf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_must_use)]` on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | gameboy.run(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: structure field `OAM_interrupt_enabled` should have a snake case name [INFO] [stderr] --> src/gameboy/gfx/stat.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | pub OAM_interrupt_enabled: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `oam_interrupt_enabled` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `VBlank_interrupt_enabled` should have a snake case name [INFO] [stderr] --> src/gameboy/gfx/stat.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | pub VBlank_interrupt_enabled: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `vblank_interrupt_enabled` [INFO] [stderr] [INFO] [stderr] warning: structure field `HBlank_interrupt_enabled` should have a snake case name [INFO] [stderr] --> src/gameboy/gfx/stat.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | pub HBlank_interrupt_enabled: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `hblank_interrupt_enabled` [INFO] [stderr] [INFO] [stderr] warning: unused return value of `core::num::::wrapping_add` that must be used [INFO] [stderr] --> src/gameboy/timer.rs:78:17 [INFO] [stderr] | [INFO] [stderr] 78 | self.tima.wrapping_add(0x01); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this returns the result of the operation, without modifying the original [INFO] [stderr] [INFO] [stderr] warning: 107 warnings emitted [INFO] [stderr] [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 0.30s [INFO] [stderr] Running /opt/rustwide/target/debug/deps/chemboy-94c8095413917fed [INFO] [stderr] Running /opt/rustwide/target/debug/deps/chemboy-e08446ebbc7bc16c [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out [INFO] [stdout] [INFO] [stderr] Doc-tests chemboy [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out [INFO] [stdout] [INFO] running `"docker" "inspect" "d8ba6c3e282938810a28021e006e24e3ce91e5742ee817c41c25fbb0e946bec8"` [INFO] running `"docker" "rm" "-f" "d8ba6c3e282938810a28021e006e24e3ce91e5742ee817c41c25fbb0e946bec8"` [INFO] [stdout] d8ba6c3e282938810a28021e006e24e3ce91e5742ee817c41c25fbb0e946bec8