[INFO] updating cached repository https://github.com/synlestidae/webnes [INFO] running `"git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune"` [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b33eaa14e63ac420c871b982988d968529885b32 [INFO] testing synlestidae/webnes against 1.44.0 for beta-1.45-1 [INFO] running `"git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsynlestidae%2Fwebnes" "/workspace/builds/worker-4/source"` [INFO] [stderr] Cloning into '/workspace/builds/worker-4/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/synlestidae/webnes on toolchain 1.44.0 [INFO] running `"/workspace/cargo-home/bin/cargo" "+1.44.0" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started tweaking git repo https://github.com/synlestidae/webnes [INFO] finished tweaking git repo https://github.com/synlestidae/webnes [INFO] tweaked toml for git repo https://github.com/synlestidae/webnes written to /workspace/builds/worker-4/source/Cargo.toml [INFO] running `"/workspace/cargo-home/bin/cargo" "+1.44.0" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/workspace/cargo-home/bin/cargo" "+1.44.0" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "MAP_USER_ID=0" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--network" "none" "rustops/crates-build-env" "/opt/rustwide/cargo-home/bin/cargo" "+1.44.0" "build" "--frozen"` [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] [stdout] 72f614866051838a4ef570fda4b0c20774a33ae840977a3185372b23be7c86cb [INFO] running `"docker" "start" "-a" "72f614866051838a4ef570fda4b0c20774a33ae840977a3185372b23be7c86cb"` [INFO] [stderr] sudo: setrlimit(RLIMIT_CORE): Operation not permitted [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.63 [INFO] [stderr] Compiling syn v1.0.30 [INFO] [stderr] Compiling bumpalo v3.4.0 [INFO] [stderr] Compiling wasm-bindgen v0.2.63 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.63 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.63 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.63 [INFO] [stderr] Compiling js-sys v0.3.40 [INFO] [stderr] Compiling web-sys v0.3.40 [INFO] [stderr] Compiling nes v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stderr] --> src/util.rs:12:21 [INFO] [stderr] | [INFO] [stderr] 12 | let count = try!(rd.read(&mut buf[total..])); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(deprecated)]` on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stderr] --> src/rom.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | try!(util::read_to_buf(&mut header, r)); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stderr] --> src/rom.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | try!(util::read_to_buf(&mut prg_rom, r)); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stderr] --> src/rom.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | try!(util::read_to_buf(&mut chr_rom, r)); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Result` [INFO] [stderr] --> src/util.rs:6:34 [INFO] [stderr] | [INFO] [stderr] 6 | use std::io::{self, Read, Write, Result}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/util.rs:9:49 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn read_to_buf(mut buf: &mut [u8], rd: &mut Read) -> io::Result<()> { [INFO] [stderr] | ^^^^ help: use `dyn`: `dyn Read` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `OutputBuffer`, `self` [INFO] [stderr] --> src/apu.rs:7:13 [INFO] [stderr] | [INFO] [stderr] 7 | use audio::{self, OutputBuffer}; [INFO] [stderr] | ^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `resampler::Resampler` [INFO] [stderr] --> src/apu.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use resampler::Resampler; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/apu.rs:430:20 [INFO] [stderr] | [INFO] [stderr] 430 | 0x4000 ... 0x4003 => self.update_pulse(addr, val, 0), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/apu.rs:431:20 [INFO] [stderr] | [INFO] [stderr] 431 | 0x4004 ... 0x4007 => self.update_pulse(addr, val, 1), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/apu.rs:432:20 [INFO] [stderr] | [INFO] [stderr] 432 | 0x4008 ... 0x400b => self.regs.triangle.storeb(addr, val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/apu.rs:433:20 [INFO] [stderr] | [INFO] [stderr] 433 | 0x400c ... 0x400f => self.update_noise(addr, val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp` [INFO] [stderr] --> src/audio.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::cmp; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::slice::from_raw_parts_mut` [INFO] [stderr] --> src/audio.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use std::slice::from_raw_parts_mut; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/mapper.rs:26:44 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn create_mapper(rom: Box) -> Box { [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/mapper.rs:31:23 [INFO] [stderr] | [INFO] [stderr] 31 | }) as Box [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/mapper.rs:33:47 [INFO] [stderr] | [INFO] [stderr] 33 | 1 => Box::new(SxRom::new(rom)) as Box, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/mapper.rs:34:47 [INFO] [stderr] | [INFO] [stderr] 34 | 4 => Box::new(TxRom::new(rom)) as Box, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:341:23 [INFO] [stderr] | [INFO] [stderr] 341 | 0 ... 1 => self.chr_banks_2k[bank_update_select] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:342:23 [INFO] [stderr] | [INFO] [stderr] 342 | 2 ... 5 => self.chr_banks_1k[bank_update_select - 2] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:343:23 [INFO] [stderr] | [INFO] [stderr] 343 | 6 ... 7 => self.prg_banks[bank_update_select - 6] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:365:21 [INFO] [stderr] | [INFO] [stderr] 365 | (0x0000 ... 0x07ff, false) | (0x1000 ... 0x17ff, true) => (self.chr_banks_2k[0], true), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:365:50 [INFO] [stderr] | [INFO] [stderr] 365 | (0x0000 ... 0x07ff, false) | (0x1000 ... 0x17ff, true) => (self.chr_banks_2k[0], true), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:366:21 [INFO] [stderr] | [INFO] [stderr] 366 | (0x0800 ... 0x0fff, false) | (0x1800 ... 0x1fff, true) => (self.chr_banks_2k[1], true), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:366:50 [INFO] [stderr] | [INFO] [stderr] 366 | (0x0800 ... 0x0fff, false) | (0x1800 ... 0x1fff, true) => (self.chr_banks_2k[1], true), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:367:21 [INFO] [stderr] | [INFO] [stderr] 367 | (0x1000 ... 0x13ff, false) | (0x0000 ... 0x03ff, true) => (self.chr_banks_1k[0], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:367:50 [INFO] [stderr] | [INFO] [stderr] 367 | (0x1000 ... 0x13ff, false) | (0x0000 ... 0x03ff, true) => (self.chr_banks_1k[0], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:368:21 [INFO] [stderr] | [INFO] [stderr] 368 | (0x1400 ... 0x17ff, false) | (0x0400 ... 0x07ff, true) => (self.chr_banks_1k[1], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:368:50 [INFO] [stderr] | [INFO] [stderr] 368 | (0x1400 ... 0x17ff, false) | (0x0400 ... 0x07ff, true) => (self.chr_banks_1k[1], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:369:21 [INFO] [stderr] | [INFO] [stderr] 369 | (0x1800 ... 0x1bff, false) | (0x0800 ... 0x0bff, true) => (self.chr_banks_1k[2], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:369:50 [INFO] [stderr] | [INFO] [stderr] 369 | (0x1800 ... 0x1bff, false) | (0x0800 ... 0x0bff, true) => (self.chr_banks_1k[2], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:370:21 [INFO] [stderr] | [INFO] [stderr] 370 | (0x1c00 ... 0x1fff, false) | (0x0c00 ... 0x0fff, true) => (self.chr_banks_1k[3], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:370:50 [INFO] [stderr] | [INFO] [stderr] 370 | (0x1c00 ... 0x1fff, false) | (0x0c00 ... 0x0fff, true) => (self.chr_banks_1k[3], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/mem.rs:82:32 [INFO] [stderr] | [INFO] [stderr] 82 | pub mapper: Rc>>, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/mem.rs:89:39 [INFO] [stderr] | [INFO] [stderr] 89 | mapper: Rc>>, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ppu.rs:207:32 [INFO] [stderr] | [INFO] [stderr] 207 | pub mapper: Rc>>, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ppu.rs:213:39 [INFO] [stderr] | [INFO] [stderr] 213 | pub fn new(mapper: Rc>>) -> Vram { [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/rom.rs:37:25 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn load(r: &mut Read) -> Result { [INFO] [stderr] | ^^^^ help: use `dyn`: `dyn Read` [INFO] [stderr] [INFO] [stderr] warning: unused import: `apu::Apu` [INFO] [stderr] --> src/lib.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | use apu::Apu; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `cpu::Cpu` [INFO] [stderr] --> src/lib.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | use cpu::Cpu; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Gfx` [INFO] [stderr] --> src/lib.rs:33:11 [INFO] [stderr] | [INFO] [stderr] 33 | use gfx::{Gfx, Scale}; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `InputResult`, `Input` [INFO] [stderr] --> src/lib.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | use input::{Input, InputResult}; [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `mapper::Mapper` [INFO] [stderr] --> src/lib.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | use mapper::Mapper; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `mem::MemMap` [INFO] [stderr] --> src/lib.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | use mem::MemMap; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Oam`, `Ppu`, `Vram` [INFO] [stderr] --> src/lib.rs:37:11 [INFO] [stderr] | [INFO] [stderr] 37 | use ppu::{Oam, Ppu, Vram}; [INFO] [stderr] | ^^^ ^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `util::Save` [INFO] [stderr] --> src/lib.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | use util::Save; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::thread` [INFO] [stderr] --> src/lib.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | use std::thread; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `input_source::*` [INFO] [stderr] --> src/lib.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | use input_source::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `emulator::Emulator` [INFO] [stderr] --> src/lib.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | use emulator::Emulator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cell::RefCell` [INFO] [stderr] --> src/lib.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | use std::cell::RefCell; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/lib.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path::Path` [INFO] [stderr] --> src/lib.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | use std::path::Path; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::rc::Rc` [INFO] [stderr] --> src/lib.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | use std::rc::Rc; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::mpsc::channel` [INFO] [stderr] --> src/lib.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | use std::sync::mpsc::channel; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/lib.rs:54:1 [INFO] [stderr] | [INFO] [stderr] 54 | / macro_rules! log { [INFO] [stderr] 55 | | ( $( $t:tt )* ) => { [INFO] [stderr] 56 | | web_sys::console::log_1(&format!( $( $t )* ).into()); [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_macros)]` on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::sync::ONCE_INIT': the `new` function is now preferred [INFO] [stderr] --> src/audio.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / lazy_static! { [INFO] [stderr] 26 | | pub static ref AUDIO_MUTEX: Mutex<()> = Mutex::new(()); [INFO] [stderr] 27 | | pub static ref AUDIO_CONDVAR: Condvar = Condvar::new(); [INFO] [stderr] 28 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::sync::ONCE_INIT': the `new` function is now preferred [INFO] [stderr] --> src/audio.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / lazy_static! { [INFO] [stderr] 26 | | pub static ref AUDIO_MUTEX: Mutex<()> = Mutex::new(()); [INFO] [stderr] 27 | | pub static ref AUDIO_CONDVAR: Condvar = Condvar::new(); [INFO] [stderr] 28 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::sync::ONCE_INIT': the `new` function is now preferred [INFO] [stderr] --> src/audio.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / lazy_static! { [INFO] [stderr] 26 | | pub static ref AUDIO_MUTEX: Mutex<()> = Mutex::new(()); [INFO] [stderr] 27 | | pub static ref AUDIO_CONDVAR: Condvar = Condvar::new(); [INFO] [stderr] 28 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::sync::ONCE_INIT': the `new` function is now preferred [INFO] [stderr] --> src/audio.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / lazy_static! { [INFO] [stderr] 26 | | pub static ref AUDIO_MUTEX: Mutex<()> = Mutex::new(()); [INFO] [stderr] 27 | | pub static ref AUDIO_CONDVAR: Condvar = Condvar::new(); [INFO] [stderr] 28 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rom` [INFO] [stderr] --> src/lib.rs:80:23 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn start_emulator(rom: Rom, scale: Scale) { [INFO] [stderr] | ^^^ help: if this is intentional, prefix it with an underscore: `_rom` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `scale` [INFO] [stderr] --> src/lib.rs:80:33 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn start_emulator(rom: Rom, scale: Scale) { [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_scale` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pulse_number` [INFO] [stderr] --> src/apu.rs:600:30 [INFO] [stderr] | [INFO] [stderr] 600 | fn play_pulse(&mut self, pulse_number: usize, channel: usize) { [INFO] [stderr] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pulse_number` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `channel` [INFO] [stderr] --> src/apu.rs:600:51 [INFO] [stderr] | [INFO] [stderr] 600 | fn play_pulse(&mut self, pulse_number: usize, channel: usize) { [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_channel` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `channel` [INFO] [stderr] --> src/apu.rs:637:33 [INFO] [stderr] | [INFO] [stderr] 637 | fn play_triangle(&mut self, channel: usize) { [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_channel` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `channel` [INFO] [stderr] --> src/apu.rs:666:30 [INFO] [stderr] | [INFO] [stderr] 666 | fn play_noise(&mut self, channel: usize) { [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_channel` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `nes_sample_rate` [INFO] [stderr] --> src/resampler.rs:7:16 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn new(nes_sample_rate: u32, output_sample_rate: u32) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_nes_sample_rate` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `output_sample_rate` [INFO] [stderr] --> src/resampler.rs:7:38 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn new(nes_sample_rate: u32, output_sample_rate: u32) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_output_sample_rate` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `input` [INFO] [stderr] --> src/resampler.rs:14:27 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn process(&self, input: &mut [i16], output: &mut [u8]) { [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `output` [INFO] [stderr] --> src/resampler.rs:14:46 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn process(&self, input: &mut [i16], output: &mut [u8]) { [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_output` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ppu_screen` [INFO] [stderr] --> src/gfx.rs:327:24 [INFO] [stderr] | [INFO] [stderr] 327 | fn blit(&mut self, ppu_screen: &[u8; SCREEN_SIZE]) { [INFO] [stderr] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_ppu_screen` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/util.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn read_to_buf(mut buf: &mut [u8], rd: &mut Read) -> io::Result<()> { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/audio.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | unsafe { [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_unsafe)]` on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NES_SAMPLE_RATE` [INFO] [stderr] --> src/apu.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | const NES_SAMPLE_RATE: u32 = 1789920; // Actual is 1789800, but this is divisible by 240. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `OUTPUT_SAMPLE_RATE` [INFO] [stderr] --> src/apu.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | const OUTPUT_SAMPLE_RATE: u32 = 44100; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `TICK_FREQUENCY` [INFO] [stderr] --> src/apu.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | const TICK_FREQUENCY: u32 = 240; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NES_SAMPLES_PER_TICK` [INFO] [stderr] --> src/apu.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | const NES_SAMPLES_PER_TICK: u32 = NES_SAMPLE_RATE / TICK_FREQUENCY; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PULSE_WAVEFORMS` [INFO] [stderr] --> src/apu.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | const PULSE_WAVEFORMS: [u8; 4] = [ 0b01000000, 0b01100000, 0b01111000, 0b10011111 ]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `TRIANGLE_WAVEFORM` [INFO] [stderr] --> src/apu.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | / const TRIANGLE_WAVEFORM: [u8; 32] = [ [INFO] [stderr] 32 | | 15, 14, 13, 12, 11, 10, 9, 8, 7, 6, 5, 4, 3, 2, 1, 0, [INFO] [stderr] 33 | | 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, [INFO] [stderr] 34 | | ]; [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `audible` [INFO] [stderr] --> src/apu.rs:155:5 [INFO] [stderr] | [INFO] [stderr] 155 | fn audible(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `sample_volume` [INFO] [stderr] --> src/apu.rs:159:5 [INFO] [stderr] | [INFO] [stderr] 159 | fn sample_volume(&self) -> i16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `audible` [INFO] [stderr] --> src/apu.rs:193:5 [INFO] [stderr] | [INFO] [stderr] 193 | fn audible(&self) -> bool { self.value > 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `wavelen` [INFO] [stderr] --> src/apu.rs:194:5 [INFO] [stderr] | [INFO] [stderr] 194 | fn wavelen(&self) -> u64 { (self.value as u64 + 1) * 2 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `waveform_index` [INFO] [stderr] --> src/apu.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | waveform_index: u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `audible` [INFO] [stderr] --> src/apu.rs:308:5 [INFO] [stderr] | [INFO] [stderr] 308 | fn audible(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `rng` [INFO] [stderr] --> src/apu.rs:322:5 [INFO] [stderr] | [INFO] [stderr] 322 | rng: Xorshift, // FIXME: This is inaccurate. [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `SAMPLE_COUNT` [INFO] [stderr] --> src/apu.rs:400:1 [INFO] [stderr] | [INFO] [stderr] 400 | const SAMPLE_COUNT: usize = 178992; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `SampleBuffer` [INFO] [stderr] --> src/apu.rs:402:8 [INFO] [stderr] | [INFO] [stderr] 402 | struct SampleBuffer { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_or_zero_sample_buffer` [INFO] [stderr] --> src/apu.rs:587:5 [INFO] [stderr] | [INFO] [stderr] 587 | / fn get_or_zero_sample_buffer(buffer: &mut [i16], offset: usize, audible: bool) [INFO] [stderr] 588 | | -> Option<&mut [i16]> { [INFO] [stderr] 589 | | let buffer = &mut buffer[offset..offset + NES_SAMPLES_PER_TICK as usize]; [INFO] [stderr] 590 | | if audible { [INFO] [stderr] ... | [INFO] [stderr] 597 | | None [INFO] [stderr] 598 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `play_pulse` [INFO] [stderr] --> src/apu.rs:600:5 [INFO] [stderr] | [INFO] [stderr] 600 | fn play_pulse(&mut self, pulse_number: usize, channel: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `play_triangle` [INFO] [stderr] --> src/apu.rs:637:5 [INFO] [stderr] | [INFO] [stderr] 637 | fn play_triangle(&mut self, channel: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `play_noise` [INFO] [stderr] --> src/apu.rs:666:5 [INFO] [stderr] | [INFO] [stderr] 666 | fn play_noise(&mut self, channel: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `g_output_buffer` [INFO] [stderr] --> src/audio.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | static mut g_output_buffer: Option<*mut OutputBuffer> = None; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `factor` [INFO] [stderr] --> src/gfx.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | fn factor(self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static variable `g_output_buffer` should have an upper case name [INFO] [stderr] --> src/audio.rs:23:12 [INFO] [stderr] | [INFO] [stderr] 23 | static mut g_output_buffer: Option<*mut OutputBuffer> = None; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `G_OUTPUT_BUFFER` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stderr] [INFO] [stderr] warning: 94 warnings emitted [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 40.89s [INFO] running `"docker" "inspect" "72f614866051838a4ef570fda4b0c20774a33ae840977a3185372b23be7c86cb"` [INFO] running `"docker" "rm" "-f" "72f614866051838a4ef570fda4b0c20774a33ae840977a3185372b23be7c86cb"` [INFO] [stdout] 72f614866051838a4ef570fda4b0c20774a33ae840977a3185372b23be7c86cb [INFO] running `"docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "MAP_USER_ID=0" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--network" "none" "rustops/crates-build-env" "/opt/rustwide/cargo-home/bin/cargo" "+1.44.0" "test" "--frozen" "--no-run"` [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] [stdout] b3702d8a17126dd67524889164d89675e610f37e69d55ffdc6e4fc66ec6224a7 [INFO] running `"docker" "start" "-a" "b3702d8a17126dd67524889164d89675e610f37e69d55ffdc6e4fc66ec6224a7"` [INFO] [stderr] sudo: setrlimit(RLIMIT_CORE): Operation not permitted [INFO] [stderr] Compiling nes v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stderr] --> src/util.rs:12:21 [INFO] [stderr] | [INFO] [stderr] 12 | let count = try!(rd.read(&mut buf[total..])); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(deprecated)]` on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stderr] --> src/rom.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | try!(util::read_to_buf(&mut header, r)); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stderr] --> src/rom.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | try!(util::read_to_buf(&mut prg_rom, r)); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stderr] --> src/rom.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | try!(util::read_to_buf(&mut chr_rom, r)); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Result` [INFO] [stderr] --> src/util.rs:6:34 [INFO] [stderr] | [INFO] [stderr] 6 | use std::io::{self, Read, Write, Result}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/util.rs:9:49 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn read_to_buf(mut buf: &mut [u8], rd: &mut Read) -> io::Result<()> { [INFO] [stderr] | ^^^^ help: use `dyn`: `dyn Read` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `OutputBuffer`, `self` [INFO] [stderr] --> src/apu.rs:7:13 [INFO] [stderr] | [INFO] [stderr] 7 | use audio::{self, OutputBuffer}; [INFO] [stderr] | ^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `resampler::Resampler` [INFO] [stderr] --> src/apu.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use resampler::Resampler; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/apu.rs:430:20 [INFO] [stderr] | [INFO] [stderr] 430 | 0x4000 ... 0x4003 => self.update_pulse(addr, val, 0), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/apu.rs:431:20 [INFO] [stderr] | [INFO] [stderr] 431 | 0x4004 ... 0x4007 => self.update_pulse(addr, val, 1), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/apu.rs:432:20 [INFO] [stderr] | [INFO] [stderr] 432 | 0x4008 ... 0x400b => self.regs.triangle.storeb(addr, val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/apu.rs:433:20 [INFO] [stderr] | [INFO] [stderr] 433 | 0x400c ... 0x400f => self.update_noise(addr, val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp` [INFO] [stderr] --> src/audio.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::cmp; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::slice::from_raw_parts_mut` [INFO] [stderr] --> src/audio.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use std::slice::from_raw_parts_mut; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/mapper.rs:26:44 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn create_mapper(rom: Box) -> Box { [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/mapper.rs:31:23 [INFO] [stderr] | [INFO] [stderr] 31 | }) as Box [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/mapper.rs:33:47 [INFO] [stderr] | [INFO] [stderr] 33 | 1 => Box::new(SxRom::new(rom)) as Box, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/mapper.rs:34:47 [INFO] [stderr] | [INFO] [stderr] 34 | 4 => Box::new(TxRom::new(rom)) as Box, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:341:23 [INFO] [stderr] | [INFO] [stderr] 341 | 0 ... 1 => self.chr_banks_2k[bank_update_select] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:342:23 [INFO] [stderr] | [INFO] [stderr] 342 | 2 ... 5 => self.chr_banks_1k[bank_update_select - 2] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:343:23 [INFO] [stderr] | [INFO] [stderr] 343 | 6 ... 7 => self.prg_banks[bank_update_select - 6] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:365:21 [INFO] [stderr] | [INFO] [stderr] 365 | (0x0000 ... 0x07ff, false) | (0x1000 ... 0x17ff, true) => (self.chr_banks_2k[0], true), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:365:50 [INFO] [stderr] | [INFO] [stderr] 365 | (0x0000 ... 0x07ff, false) | (0x1000 ... 0x17ff, true) => (self.chr_banks_2k[0], true), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:366:21 [INFO] [stderr] | [INFO] [stderr] 366 | (0x0800 ... 0x0fff, false) | (0x1800 ... 0x1fff, true) => (self.chr_banks_2k[1], true), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:366:50 [INFO] [stderr] | [INFO] [stderr] 366 | (0x0800 ... 0x0fff, false) | (0x1800 ... 0x1fff, true) => (self.chr_banks_2k[1], true), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:367:21 [INFO] [stderr] | [INFO] [stderr] 367 | (0x1000 ... 0x13ff, false) | (0x0000 ... 0x03ff, true) => (self.chr_banks_1k[0], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:367:50 [INFO] [stderr] | [INFO] [stderr] 367 | (0x1000 ... 0x13ff, false) | (0x0000 ... 0x03ff, true) => (self.chr_banks_1k[0], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:368:21 [INFO] [stderr] | [INFO] [stderr] 368 | (0x1400 ... 0x17ff, false) | (0x0400 ... 0x07ff, true) => (self.chr_banks_1k[1], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:368:50 [INFO] [stderr] | [INFO] [stderr] 368 | (0x1400 ... 0x17ff, false) | (0x0400 ... 0x07ff, true) => (self.chr_banks_1k[1], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:369:21 [INFO] [stderr] | [INFO] [stderr] 369 | (0x1800 ... 0x1bff, false) | (0x0800 ... 0x0bff, true) => (self.chr_banks_1k[2], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:369:50 [INFO] [stderr] | [INFO] [stderr] 369 | (0x1800 ... 0x1bff, false) | (0x0800 ... 0x0bff, true) => (self.chr_banks_1k[2], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:370:21 [INFO] [stderr] | [INFO] [stderr] 370 | (0x1c00 ... 0x1fff, false) | (0x0c00 ... 0x0fff, true) => (self.chr_banks_1k[3], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:370:50 [INFO] [stderr] | [INFO] [stderr] 370 | (0x1c00 ... 0x1fff, false) | (0x0c00 ... 0x0fff, true) => (self.chr_banks_1k[3], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/mem.rs:82:32 [INFO] [stderr] | [INFO] [stderr] 82 | pub mapper: Rc>>, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/mem.rs:89:39 [INFO] [stderr] | [INFO] [stderr] 89 | mapper: Rc>>, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ppu.rs:207:32 [INFO] [stderr] | [INFO] [stderr] 207 | pub mapper: Rc>>, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ppu.rs:213:39 [INFO] [stderr] | [INFO] [stderr] 213 | pub fn new(mapper: Rc>>) -> Vram { [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/rom.rs:37:25 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn load(r: &mut Read) -> Result { [INFO] [stderr] | ^^^^ help: use `dyn`: `dyn Read` [INFO] [stderr] [INFO] [stderr] warning: unused import: `apu::Apu` [INFO] [stderr] --> src/lib.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | use apu::Apu; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `cpu::Cpu` [INFO] [stderr] --> src/lib.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | use cpu::Cpu; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Gfx` [INFO] [stderr] --> src/lib.rs:33:11 [INFO] [stderr] | [INFO] [stderr] 33 | use gfx::{Gfx, Scale}; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `InputResult`, `Input` [INFO] [stderr] --> src/lib.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | use input::{Input, InputResult}; [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `mapper::Mapper` [INFO] [stderr] --> src/lib.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | use mapper::Mapper; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `mem::MemMap` [INFO] [stderr] --> src/lib.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | use mem::MemMap; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Oam`, `Ppu`, `Vram` [INFO] [stderr] --> src/lib.rs:37:11 [INFO] [stderr] | [INFO] [stderr] 37 | use ppu::{Oam, Ppu, Vram}; [INFO] [stderr] | ^^^ ^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `util::Save` [INFO] [stderr] --> src/lib.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | use util::Save; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::thread` [INFO] [stderr] --> src/lib.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | use std::thread; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `input_source::*` [INFO] [stderr] --> src/lib.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | use input_source::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `emulator::Emulator` [INFO] [stderr] --> src/lib.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | use emulator::Emulator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cell::RefCell` [INFO] [stderr] --> src/lib.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | use std::cell::RefCell; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/lib.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path::Path` [INFO] [stderr] --> src/lib.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | use std::path::Path; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::rc::Rc` [INFO] [stderr] --> src/lib.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | use std::rc::Rc; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::mpsc::channel` [INFO] [stderr] --> src/lib.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | use std::sync::mpsc::channel; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/lib.rs:54:1 [INFO] [stderr] | [INFO] [stderr] 54 | / macro_rules! log { [INFO] [stderr] 55 | | ( $( $t:tt )* ) => { [INFO] [stderr] 56 | | web_sys::console::log_1(&format!( $( $t )* ).into()); [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_macros)]` on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::sync::ONCE_INIT': the `new` function is now preferred [INFO] [stderr] --> src/audio.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / lazy_static! { [INFO] [stderr] 26 | | pub static ref AUDIO_MUTEX: Mutex<()> = Mutex::new(()); [INFO] [stderr] 27 | | pub static ref AUDIO_CONDVAR: Condvar = Condvar::new(); [INFO] [stderr] 28 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::sync::ONCE_INIT': the `new` function is now preferred [INFO] [stderr] --> src/audio.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / lazy_static! { [INFO] [stderr] 26 | | pub static ref AUDIO_MUTEX: Mutex<()> = Mutex::new(()); [INFO] [stderr] 27 | | pub static ref AUDIO_CONDVAR: Condvar = Condvar::new(); [INFO] [stderr] 28 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::sync::ONCE_INIT': the `new` function is now preferred [INFO] [stderr] --> src/audio.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / lazy_static! { [INFO] [stderr] 26 | | pub static ref AUDIO_MUTEX: Mutex<()> = Mutex::new(()); [INFO] [stderr] 27 | | pub static ref AUDIO_CONDVAR: Condvar = Condvar::new(); [INFO] [stderr] 28 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::sync::ONCE_INIT': the `new` function is now preferred [INFO] [stderr] --> src/audio.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / lazy_static! { [INFO] [stderr] 26 | | pub static ref AUDIO_MUTEX: Mutex<()> = Mutex::new(()); [INFO] [stderr] 27 | | pub static ref AUDIO_CONDVAR: Condvar = Condvar::new(); [INFO] [stderr] 28 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rom` [INFO] [stderr] --> src/lib.rs:80:23 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn start_emulator(rom: Rom, scale: Scale) { [INFO] [stderr] | ^^^ help: if this is intentional, prefix it with an underscore: `_rom` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `scale` [INFO] [stderr] --> src/lib.rs:80:33 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn start_emulator(rom: Rom, scale: Scale) { [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_scale` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pulse_number` [INFO] [stderr] --> src/apu.rs:600:30 [INFO] [stderr] | [INFO] [stderr] 600 | fn play_pulse(&mut self, pulse_number: usize, channel: usize) { [INFO] [stderr] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pulse_number` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `channel` [INFO] [stderr] --> src/apu.rs:600:51 [INFO] [stderr] | [INFO] [stderr] 600 | fn play_pulse(&mut self, pulse_number: usize, channel: usize) { [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_channel` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `channel` [INFO] [stderr] --> src/apu.rs:637:33 [INFO] [stderr] | [INFO] [stderr] 637 | fn play_triangle(&mut self, channel: usize) { [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_channel` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `channel` [INFO] [stderr] --> src/apu.rs:666:30 [INFO] [stderr] | [INFO] [stderr] 666 | fn play_noise(&mut self, channel: usize) { [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_channel` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `nes_sample_rate` [INFO] [stderr] --> src/resampler.rs:7:16 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn new(nes_sample_rate: u32, output_sample_rate: u32) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_nes_sample_rate` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `output_sample_rate` [INFO] [stderr] --> src/resampler.rs:7:38 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn new(nes_sample_rate: u32, output_sample_rate: u32) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_output_sample_rate` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `input` [INFO] [stderr] --> src/resampler.rs:14:27 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn process(&self, input: &mut [i16], output: &mut [u8]) { [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `output` [INFO] [stderr] --> src/resampler.rs:14:46 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn process(&self, input: &mut [i16], output: &mut [u8]) { [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_output` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ppu_screen` [INFO] [stderr] --> src/gfx.rs:327:24 [INFO] [stderr] | [INFO] [stderr] 327 | fn blit(&mut self, ppu_screen: &[u8; SCREEN_SIZE]) { [INFO] [stderr] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_ppu_screen` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/util.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn read_to_buf(mut buf: &mut [u8], rd: &mut Read) -> io::Result<()> { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/audio.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | unsafe { [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_unsafe)]` on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NES_SAMPLE_RATE` [INFO] [stderr] --> src/apu.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | const NES_SAMPLE_RATE: u32 = 1789920; // Actual is 1789800, but this is divisible by 240. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `OUTPUT_SAMPLE_RATE` [INFO] [stderr] --> src/apu.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | const OUTPUT_SAMPLE_RATE: u32 = 44100; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `TICK_FREQUENCY` [INFO] [stderr] --> src/apu.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | const TICK_FREQUENCY: u32 = 240; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NES_SAMPLES_PER_TICK` [INFO] [stderr] --> src/apu.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | const NES_SAMPLES_PER_TICK: u32 = NES_SAMPLE_RATE / TICK_FREQUENCY; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PULSE_WAVEFORMS` [INFO] [stderr] --> src/apu.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | const PULSE_WAVEFORMS: [u8; 4] = [ 0b01000000, 0b01100000, 0b01111000, 0b10011111 ]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `TRIANGLE_WAVEFORM` [INFO] [stderr] --> src/apu.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | / const TRIANGLE_WAVEFORM: [u8; 32] = [ [INFO] [stderr] 32 | | 15, 14, 13, 12, 11, 10, 9, 8, 7, 6, 5, 4, 3, 2, 1, 0, [INFO] [stderr] 33 | | 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, [INFO] [stderr] 34 | | ]; [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `audible` [INFO] [stderr] --> src/apu.rs:155:5 [INFO] [stderr] | [INFO] [stderr] 155 | fn audible(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `sample_volume` [INFO] [stderr] --> src/apu.rs:159:5 [INFO] [stderr] | [INFO] [stderr] 159 | fn sample_volume(&self) -> i16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `audible` [INFO] [stderr] --> src/apu.rs:193:5 [INFO] [stderr] | [INFO] [stderr] 193 | fn audible(&self) -> bool { self.value > 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `wavelen` [INFO] [stderr] --> src/apu.rs:194:5 [INFO] [stderr] | [INFO] [stderr] 194 | fn wavelen(&self) -> u64 { (self.value as u64 + 1) * 2 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `waveform_index` [INFO] [stderr] --> src/apu.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | waveform_index: u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `audible` [INFO] [stderr] --> src/apu.rs:308:5 [INFO] [stderr] | [INFO] [stderr] 308 | fn audible(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `rng` [INFO] [stderr] --> src/apu.rs:322:5 [INFO] [stderr] | [INFO] [stderr] 322 | rng: Xorshift, // FIXME: This is inaccurate. [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `SAMPLE_COUNT` [INFO] [stderr] --> src/apu.rs:400:1 [INFO] [stderr] | [INFO] [stderr] 400 | const SAMPLE_COUNT: usize = 178992; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `SampleBuffer` [INFO] [stderr] --> src/apu.rs:402:8 [INFO] [stderr] | [INFO] [stderr] 402 | struct SampleBuffer { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_or_zero_sample_buffer` [INFO] [stderr] --> src/apu.rs:587:5 [INFO] [stderr] | [INFO] [stderr] 587 | / fn get_or_zero_sample_buffer(buffer: &mut [i16], offset: usize, audible: bool) [INFO] [stderr] 588 | | -> Option<&mut [i16]> { [INFO] [stderr] 589 | | let buffer = &mut buffer[offset..offset + NES_SAMPLES_PER_TICK as usize]; [INFO] [stderr] 590 | | if audible { [INFO] [stderr] ... | [INFO] [stderr] 597 | | None [INFO] [stderr] 598 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `play_pulse` [INFO] [stderr] --> src/apu.rs:600:5 [INFO] [stderr] | [INFO] [stderr] 600 | fn play_pulse(&mut self, pulse_number: usize, channel: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `play_triangle` [INFO] [stderr] --> src/apu.rs:637:5 [INFO] [stderr] | [INFO] [stderr] 637 | fn play_triangle(&mut self, channel: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `play_noise` [INFO] [stderr] --> src/apu.rs:666:5 [INFO] [stderr] | [INFO] [stderr] 666 | fn play_noise(&mut self, channel: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `g_output_buffer` [INFO] [stderr] --> src/audio.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | static mut g_output_buffer: Option<*mut OutputBuffer> = None; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `factor` [INFO] [stderr] --> src/gfx.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | fn factor(self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static variable `g_output_buffer` should have an upper case name [INFO] [stderr] --> src/audio.rs:23:12 [INFO] [stderr] | [INFO] [stderr] 23 | static mut g_output_buffer: Option<*mut OutputBuffer> = None; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `G_OUTPUT_BUFFER` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stderr] [INFO] [stderr] warning: 94 warnings emitted [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stderr] --> src/util.rs:12:21 [INFO] [stderr] | [INFO] [stderr] 12 | let count = try!(rd.read(&mut buf[total..])); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(deprecated)]` on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stderr] --> src/rom.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | try!(util::read_to_buf(&mut header, r)); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stderr] --> src/rom.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | try!(util::read_to_buf(&mut prg_rom, r)); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stderr] --> src/rom.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | try!(util::read_to_buf(&mut chr_rom, r)); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Result` [INFO] [stderr] --> src/util.rs:6:34 [INFO] [stderr] | [INFO] [stderr] 6 | use std::io::{self, Read, Write, Result}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/util.rs:9:49 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn read_to_buf(mut buf: &mut [u8], rd: &mut Read) -> io::Result<()> { [INFO] [stderr] | ^^^^ help: use `dyn`: `dyn Read` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `OutputBuffer`, `self` [INFO] [stderr] --> src/apu.rs:7:13 [INFO] [stderr] | [INFO] [stderr] 7 | use audio::{self, OutputBuffer}; [INFO] [stderr] | ^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `resampler::Resampler` [INFO] [stderr] --> src/apu.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use resampler::Resampler; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/apu.rs:430:20 [INFO] [stderr] | [INFO] [stderr] 430 | 0x4000 ... 0x4003 => self.update_pulse(addr, val, 0), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/apu.rs:431:20 [INFO] [stderr] | [INFO] [stderr] 431 | 0x4004 ... 0x4007 => self.update_pulse(addr, val, 1), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/apu.rs:432:20 [INFO] [stderr] | [INFO] [stderr] 432 | 0x4008 ... 0x400b => self.regs.triangle.storeb(addr, val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/apu.rs:433:20 [INFO] [stderr] | [INFO] [stderr] 433 | 0x400c ... 0x400f => self.update_noise(addr, val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp` [INFO] [stderr] --> src/audio.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::cmp; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::slice::from_raw_parts_mut` [INFO] [stderr] --> src/audio.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use std::slice::from_raw_parts_mut; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/mapper.rs:26:44 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn create_mapper(rom: Box) -> Box { [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/mapper.rs:31:23 [INFO] [stderr] | [INFO] [stderr] 31 | }) as Box [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/mapper.rs:33:47 [INFO] [stderr] | [INFO] [stderr] 33 | 1 => Box::new(SxRom::new(rom)) as Box, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/mapper.rs:34:47 [INFO] [stderr] | [INFO] [stderr] 34 | 4 => Box::new(TxRom::new(rom)) as Box, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:341:23 [INFO] [stderr] | [INFO] [stderr] 341 | 0 ... 1 => self.chr_banks_2k[bank_update_select] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:342:23 [INFO] [stderr] | [INFO] [stderr] 342 | 2 ... 5 => self.chr_banks_1k[bank_update_select - 2] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:343:23 [INFO] [stderr] | [INFO] [stderr] 343 | 6 ... 7 => self.prg_banks[bank_update_select - 6] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:365:21 [INFO] [stderr] | [INFO] [stderr] 365 | (0x0000 ... 0x07ff, false) | (0x1000 ... 0x17ff, true) => (self.chr_banks_2k[0], true), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:365:50 [INFO] [stderr] | [INFO] [stderr] 365 | (0x0000 ... 0x07ff, false) | (0x1000 ... 0x17ff, true) => (self.chr_banks_2k[0], true), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:366:21 [INFO] [stderr] | [INFO] [stderr] 366 | (0x0800 ... 0x0fff, false) | (0x1800 ... 0x1fff, true) => (self.chr_banks_2k[1], true), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:366:50 [INFO] [stderr] | [INFO] [stderr] 366 | (0x0800 ... 0x0fff, false) | (0x1800 ... 0x1fff, true) => (self.chr_banks_2k[1], true), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:367:21 [INFO] [stderr] | [INFO] [stderr] 367 | (0x1000 ... 0x13ff, false) | (0x0000 ... 0x03ff, true) => (self.chr_banks_1k[0], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:367:50 [INFO] [stderr] | [INFO] [stderr] 367 | (0x1000 ... 0x13ff, false) | (0x0000 ... 0x03ff, true) => (self.chr_banks_1k[0], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:368:21 [INFO] [stderr] | [INFO] [stderr] 368 | (0x1400 ... 0x17ff, false) | (0x0400 ... 0x07ff, true) => (self.chr_banks_1k[1], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:368:50 [INFO] [stderr] | [INFO] [stderr] 368 | (0x1400 ... 0x17ff, false) | (0x0400 ... 0x07ff, true) => (self.chr_banks_1k[1], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:369:21 [INFO] [stderr] | [INFO] [stderr] 369 | (0x1800 ... 0x1bff, false) | (0x0800 ... 0x0bff, true) => (self.chr_banks_1k[2], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:369:50 [INFO] [stderr] | [INFO] [stderr] 369 | (0x1800 ... 0x1bff, false) | (0x0800 ... 0x0bff, true) => (self.chr_banks_1k[2], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:370:21 [INFO] [stderr] | [INFO] [stderr] 370 | (0x1c00 ... 0x1fff, false) | (0x0c00 ... 0x0fff, true) => (self.chr_banks_1k[3], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:370:50 [INFO] [stderr] | [INFO] [stderr] 370 | (0x1c00 ... 0x1fff, false) | (0x0c00 ... 0x0fff, true) => (self.chr_banks_1k[3], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/mem.rs:82:32 [INFO] [stderr] | [INFO] [stderr] 82 | pub mapper: Rc>>, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/mem.rs:89:39 [INFO] [stderr] | [INFO] [stderr] 89 | mapper: Rc>>, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ppu.rs:207:32 [INFO] [stderr] | [INFO] [stderr] 207 | pub mapper: Rc>>, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ppu.rs:213:39 [INFO] [stderr] | [INFO] [stderr] 213 | pub fn new(mapper: Rc>>) -> Vram { [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/rom.rs:37:25 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn load(r: &mut Read) -> Result { [INFO] [stderr] | ^^^^ help: use `dyn`: `dyn Read` [INFO] [stderr] [INFO] [stderr] warning: unused import: `apu::Apu` [INFO] [stderr] --> src/lib.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | use apu::Apu; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `cpu::Cpu` [INFO] [stderr] --> src/lib.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | use cpu::Cpu; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Gfx` [INFO] [stderr] --> src/lib.rs:33:11 [INFO] [stderr] | [INFO] [stderr] 33 | use gfx::{Gfx, Scale}; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `InputResult`, `Input` [INFO] [stderr] --> src/lib.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | use input::{Input, InputResult}; [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `mapper::Mapper` [INFO] [stderr] --> src/lib.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | use mapper::Mapper; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `mem::MemMap` [INFO] [stderr] --> src/lib.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | use mem::MemMap; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Oam`, `Ppu`, `Vram` [INFO] [stderr] --> src/lib.rs:37:11 [INFO] [stderr] | [INFO] [stderr] 37 | use ppu::{Oam, Ppu, Vram}; [INFO] [stderr] | ^^^ ^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `util::Save` [INFO] [stderr] --> src/lib.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | use util::Save; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::thread` [INFO] [stderr] --> src/lib.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | use std::thread; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `input_source::*` [INFO] [stderr] --> src/lib.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | use input_source::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `emulator::Emulator` [INFO] [stderr] --> src/lib.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | use emulator::Emulator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cell::RefCell` [INFO] [stderr] --> src/lib.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | use std::cell::RefCell; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/lib.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path::Path` [INFO] [stderr] --> src/lib.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | use std::path::Path; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::rc::Rc` [INFO] [stderr] --> src/lib.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | use std::rc::Rc; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::mpsc::channel` [INFO] [stderr] --> src/lib.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | use std::sync::mpsc::channel; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/lib.rs:54:1 [INFO] [stderr] | [INFO] [stderr] 54 | / macro_rules! log { [INFO] [stderr] 55 | | ( $( $t:tt )* ) => { [INFO] [stderr] 56 | | web_sys::console::log_1(&format!( $( $t )* ).into()); [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_macros)]` on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::sync::ONCE_INIT': the `new` function is now preferred [INFO] [stderr] --> src/audio.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / lazy_static! { [INFO] [stderr] 26 | | pub static ref AUDIO_MUTEX: Mutex<()> = Mutex::new(()); [INFO] [stderr] 27 | | pub static ref AUDIO_CONDVAR: Condvar = Condvar::new(); [INFO] [stderr] 28 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::sync::ONCE_INIT': the `new` function is now preferred [INFO] [stderr] --> src/audio.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / lazy_static! { [INFO] [stderr] 26 | | pub static ref AUDIO_MUTEX: Mutex<()> = Mutex::new(()); [INFO] [stderr] 27 | | pub static ref AUDIO_CONDVAR: Condvar = Condvar::new(); [INFO] [stderr] 28 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::sync::ONCE_INIT': the `new` function is now preferred [INFO] [stderr] --> src/audio.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / lazy_static! { [INFO] [stderr] 26 | | pub static ref AUDIO_MUTEX: Mutex<()> = Mutex::new(()); [INFO] [stderr] 27 | | pub static ref AUDIO_CONDVAR: Condvar = Condvar::new(); [INFO] [stderr] 28 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::sync::ONCE_INIT': the `new` function is now preferred [INFO] [stderr] --> src/audio.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / lazy_static! { [INFO] [stderr] 26 | | pub static ref AUDIO_MUTEX: Mutex<()> = Mutex::new(()); [INFO] [stderr] 27 | | pub static ref AUDIO_CONDVAR: Condvar = Condvar::new(); [INFO] [stderr] 28 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rom` [INFO] [stderr] --> src/lib.rs:80:23 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn start_emulator(rom: Rom, scale: Scale) { [INFO] [stderr] | ^^^ help: if this is intentional, prefix it with an underscore: `_rom` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `scale` [INFO] [stderr] --> src/lib.rs:80:33 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn start_emulator(rom: Rom, scale: Scale) { [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_scale` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pulse_number` [INFO] [stderr] --> src/apu.rs:600:30 [INFO] [stderr] | [INFO] [stderr] 600 | fn play_pulse(&mut self, pulse_number: usize, channel: usize) { [INFO] [stderr] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pulse_number` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `channel` [INFO] [stderr] --> src/apu.rs:600:51 [INFO] [stderr] | [INFO] [stderr] 600 | fn play_pulse(&mut self, pulse_number: usize, channel: usize) { [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_channel` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `channel` [INFO] [stderr] --> src/apu.rs:637:33 [INFO] [stderr] | [INFO] [stderr] 637 | fn play_triangle(&mut self, channel: usize) { [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_channel` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `channel` [INFO] [stderr] --> src/apu.rs:666:30 [INFO] [stderr] | [INFO] [stderr] 666 | fn play_noise(&mut self, channel: usize) { [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_channel` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `nes_sample_rate` [INFO] [stderr] --> src/resampler.rs:7:16 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn new(nes_sample_rate: u32, output_sample_rate: u32) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_nes_sample_rate` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `output_sample_rate` [INFO] [stderr] --> src/resampler.rs:7:38 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn new(nes_sample_rate: u32, output_sample_rate: u32) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_output_sample_rate` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `input` [INFO] [stderr] --> src/resampler.rs:14:27 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn process(&self, input: &mut [i16], output: &mut [u8]) { [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `output` [INFO] [stderr] --> src/resampler.rs:14:46 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn process(&self, input: &mut [i16], output: &mut [u8]) { [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_output` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ppu_screen` [INFO] [stderr] --> src/gfx.rs:327:24 [INFO] [stderr] | [INFO] [stderr] 327 | fn blit(&mut self, ppu_screen: &[u8; SCREEN_SIZE]) { [INFO] [stderr] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_ppu_screen` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/util.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn read_to_buf(mut buf: &mut [u8], rd: &mut Read) -> io::Result<()> { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/audio.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | unsafe { [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_unsafe)]` on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NES_SAMPLE_RATE` [INFO] [stderr] --> src/apu.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | const NES_SAMPLE_RATE: u32 = 1789920; // Actual is 1789800, but this is divisible by 240. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `OUTPUT_SAMPLE_RATE` [INFO] [stderr] --> src/apu.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | const OUTPUT_SAMPLE_RATE: u32 = 44100; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `TICK_FREQUENCY` [INFO] [stderr] --> src/apu.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | const TICK_FREQUENCY: u32 = 240; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NES_SAMPLES_PER_TICK` [INFO] [stderr] --> src/apu.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | const NES_SAMPLES_PER_TICK: u32 = NES_SAMPLE_RATE / TICK_FREQUENCY; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PULSE_WAVEFORMS` [INFO] [stderr] --> src/apu.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | const PULSE_WAVEFORMS: [u8; 4] = [ 0b01000000, 0b01100000, 0b01111000, 0b10011111 ]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `TRIANGLE_WAVEFORM` [INFO] [stderr] --> src/apu.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | / const TRIANGLE_WAVEFORM: [u8; 32] = [ [INFO] [stderr] 32 | | 15, 14, 13, 12, 11, 10, 9, 8, 7, 6, 5, 4, 3, 2, 1, 0, [INFO] [stderr] 33 | | 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, [INFO] [stderr] 34 | | ]; [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `audible` [INFO] [stderr] --> src/apu.rs:155:5 [INFO] [stderr] | [INFO] [stderr] 155 | fn audible(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `sample_volume` [INFO] [stderr] --> src/apu.rs:159:5 [INFO] [stderr] | [INFO] [stderr] 159 | fn sample_volume(&self) -> i16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `audible` [INFO] [stderr] --> src/apu.rs:193:5 [INFO] [stderr] | [INFO] [stderr] 193 | fn audible(&self) -> bool { self.value > 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `wavelen` [INFO] [stderr] --> src/apu.rs:194:5 [INFO] [stderr] | [INFO] [stderr] 194 | fn wavelen(&self) -> u64 { (self.value as u64 + 1) * 2 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `waveform_index` [INFO] [stderr] --> src/apu.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | waveform_index: u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `audible` [INFO] [stderr] --> src/apu.rs:308:5 [INFO] [stderr] | [INFO] [stderr] 308 | fn audible(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `rng` [INFO] [stderr] --> src/apu.rs:322:5 [INFO] [stderr] | [INFO] [stderr] 322 | rng: Xorshift, // FIXME: This is inaccurate. [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `SAMPLE_COUNT` [INFO] [stderr] --> src/apu.rs:400:1 [INFO] [stderr] | [INFO] [stderr] 400 | const SAMPLE_COUNT: usize = 178992; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `SampleBuffer` [INFO] [stderr] --> src/apu.rs:402:8 [INFO] [stderr] | [INFO] [stderr] 402 | struct SampleBuffer { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_or_zero_sample_buffer` [INFO] [stderr] --> src/apu.rs:587:5 [INFO] [stderr] | [INFO] [stderr] 587 | / fn get_or_zero_sample_buffer(buffer: &mut [i16], offset: usize, audible: bool) [INFO] [stderr] 588 | | -> Option<&mut [i16]> { [INFO] [stderr] 589 | | let buffer = &mut buffer[offset..offset + NES_SAMPLES_PER_TICK as usize]; [INFO] [stderr] 590 | | if audible { [INFO] [stderr] ... | [INFO] [stderr] 597 | | None [INFO] [stderr] 598 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `play_pulse` [INFO] [stderr] --> src/apu.rs:600:5 [INFO] [stderr] | [INFO] [stderr] 600 | fn play_pulse(&mut self, pulse_number: usize, channel: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `play_triangle` [INFO] [stderr] --> src/apu.rs:637:5 [INFO] [stderr] | [INFO] [stderr] 637 | fn play_triangle(&mut self, channel: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `play_noise` [INFO] [stderr] --> src/apu.rs:666:5 [INFO] [stderr] | [INFO] [stderr] 666 | fn play_noise(&mut self, channel: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `g_output_buffer` [INFO] [stderr] --> src/audio.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | static mut g_output_buffer: Option<*mut OutputBuffer> = None; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `factor` [INFO] [stderr] --> src/gfx.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | fn factor(self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static variable `g_output_buffer` should have an upper case name [INFO] [stderr] --> src/audio.rs:23:12 [INFO] [stderr] | [INFO] [stderr] 23 | static mut g_output_buffer: Option<*mut OutputBuffer> = None; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `G_OUTPUT_BUFFER` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stderr] [INFO] [stderr] warning: 94 warnings emitted [INFO] [stderr] [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 2.08s [INFO] running `"docker" "inspect" "b3702d8a17126dd67524889164d89675e610f37e69d55ffdc6e4fc66ec6224a7"` [INFO] running `"docker" "rm" "-f" "b3702d8a17126dd67524889164d89675e610f37e69d55ffdc6e4fc66ec6224a7"` [INFO] [stdout] b3702d8a17126dd67524889164d89675e610f37e69d55ffdc6e4fc66ec6224a7 [INFO] running `"docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "MAP_USER_ID=0" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--network" "none" "rustops/crates-build-env" "/opt/rustwide/cargo-home/bin/cargo" "+1.44.0" "test" "--frozen"` [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] [stdout] 248ab03cf19ec74c045c392aeafbd9014093cb615c3489a37a89f6fafcedd02d [INFO] running `"docker" "start" "-a" "248ab03cf19ec74c045c392aeafbd9014093cb615c3489a37a89f6fafcedd02d"` [INFO] [stderr] sudo: setrlimit(RLIMIT_CORE): Operation not permitted [INFO] [stderr] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stderr] --> src/util.rs:12:21 [INFO] [stderr] | [INFO] [stderr] 12 | let count = try!(rd.read(&mut buf[total..])); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(deprecated)]` on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stderr] --> src/rom.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | try!(util::read_to_buf(&mut header, r)); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stderr] --> src/rom.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | try!(util::read_to_buf(&mut prg_rom, r)); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stderr] --> src/rom.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | try!(util::read_to_buf(&mut chr_rom, r)); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Result` [INFO] [stderr] --> src/util.rs:6:34 [INFO] [stderr] | [INFO] [stderr] 6 | use std::io::{self, Read, Write, Result}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/util.rs:9:49 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn read_to_buf(mut buf: &mut [u8], rd: &mut Read) -> io::Result<()> { [INFO] [stderr] | ^^^^ help: use `dyn`: `dyn Read` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `OutputBuffer`, `self` [INFO] [stderr] --> src/apu.rs:7:13 [INFO] [stderr] | [INFO] [stderr] 7 | use audio::{self, OutputBuffer}; [INFO] [stderr] | ^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `resampler::Resampler` [INFO] [stderr] --> src/apu.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use resampler::Resampler; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/apu.rs:430:20 [INFO] [stderr] | [INFO] [stderr] 430 | 0x4000 ... 0x4003 => self.update_pulse(addr, val, 0), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/apu.rs:431:20 [INFO] [stderr] | [INFO] [stderr] 431 | 0x4004 ... 0x4007 => self.update_pulse(addr, val, 1), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/apu.rs:432:20 [INFO] [stderr] | [INFO] [stderr] 432 | 0x4008 ... 0x400b => self.regs.triangle.storeb(addr, val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/apu.rs:433:20 [INFO] [stderr] | [INFO] [stderr] 433 | 0x400c ... 0x400f => self.update_noise(addr, val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp` [INFO] [stderr] --> src/audio.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::cmp; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::slice::from_raw_parts_mut` [INFO] [stderr] --> src/audio.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use std::slice::from_raw_parts_mut; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/mapper.rs:26:44 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn create_mapper(rom: Box) -> Box { [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/mapper.rs:31:23 [INFO] [stderr] | [INFO] [stderr] 31 | }) as Box [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/mapper.rs:33:47 [INFO] [stderr] | [INFO] [stderr] 33 | 1 => Box::new(SxRom::new(rom)) as Box, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/mapper.rs:34:47 [INFO] [stderr] | [INFO] [stderr] 34 | 4 => Box::new(TxRom::new(rom)) as Box, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:341:23 [INFO] [stderr] | [INFO] [stderr] 341 | 0 ... 1 => self.chr_banks_2k[bank_update_select] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:342:23 [INFO] [stderr] | [INFO] [stderr] 342 | 2 ... 5 => self.chr_banks_1k[bank_update_select - 2] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:343:23 [INFO] [stderr] | [INFO] [stderr] 343 | 6 ... 7 => self.prg_banks[bank_update_select - 6] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:365:21 [INFO] [stderr] | [INFO] [stderr] 365 | (0x0000 ... 0x07ff, false) | (0x1000 ... 0x17ff, true) => (self.chr_banks_2k[0], true), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:365:50 [INFO] [stderr] | [INFO] [stderr] 365 | (0x0000 ... 0x07ff, false) | (0x1000 ... 0x17ff, true) => (self.chr_banks_2k[0], true), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:366:21 [INFO] [stderr] | [INFO] [stderr] 366 | (0x0800 ... 0x0fff, false) | (0x1800 ... 0x1fff, true) => (self.chr_banks_2k[1], true), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:366:50 [INFO] [stderr] | [INFO] [stderr] 366 | (0x0800 ... 0x0fff, false) | (0x1800 ... 0x1fff, true) => (self.chr_banks_2k[1], true), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:367:21 [INFO] [stderr] | [INFO] [stderr] 367 | (0x1000 ... 0x13ff, false) | (0x0000 ... 0x03ff, true) => (self.chr_banks_1k[0], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:367:50 [INFO] [stderr] | [INFO] [stderr] 367 | (0x1000 ... 0x13ff, false) | (0x0000 ... 0x03ff, true) => (self.chr_banks_1k[0], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:368:21 [INFO] [stderr] | [INFO] [stderr] 368 | (0x1400 ... 0x17ff, false) | (0x0400 ... 0x07ff, true) => (self.chr_banks_1k[1], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:368:50 [INFO] [stderr] | [INFO] [stderr] 368 | (0x1400 ... 0x17ff, false) | (0x0400 ... 0x07ff, true) => (self.chr_banks_1k[1], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:369:21 [INFO] [stderr] | [INFO] [stderr] 369 | (0x1800 ... 0x1bff, false) | (0x0800 ... 0x0bff, true) => (self.chr_banks_1k[2], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:369:50 [INFO] [stderr] | [INFO] [stderr] 369 | (0x1800 ... 0x1bff, false) | (0x0800 ... 0x0bff, true) => (self.chr_banks_1k[2], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:370:21 [INFO] [stderr] | [INFO] [stderr] 370 | (0x1c00 ... 0x1fff, false) | (0x0c00 ... 0x0fff, true) => (self.chr_banks_1k[3], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:370:50 [INFO] [stderr] | [INFO] [stderr] 370 | (0x1c00 ... 0x1fff, false) | (0x0c00 ... 0x0fff, true) => (self.chr_banks_1k[3], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/mem.rs:82:32 [INFO] [stderr] | [INFO] [stderr] 82 | pub mapper: Rc>>, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/mem.rs:89:39 [INFO] [stderr] | [INFO] [stderr] 89 | mapper: Rc>>, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ppu.rs:207:32 [INFO] [stderr] | [INFO] [stderr] 207 | pub mapper: Rc>>, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ppu.rs:213:39 [INFO] [stderr] | [INFO] [stderr] 213 | pub fn new(mapper: Rc>>) -> Vram { [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/rom.rs:37:25 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn load(r: &mut Read) -> Result { [INFO] [stderr] | ^^^^ help: use `dyn`: `dyn Read` [INFO] [stderr] [INFO] [stderr] warning: unused import: `apu::Apu` [INFO] [stderr] --> src/lib.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | use apu::Apu; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `cpu::Cpu` [INFO] [stderr] --> src/lib.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | use cpu::Cpu; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Gfx` [INFO] [stderr] --> src/lib.rs:33:11 [INFO] [stderr] | [INFO] [stderr] 33 | use gfx::{Gfx, Scale}; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `InputResult`, `Input` [INFO] [stderr] --> src/lib.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | use input::{Input, InputResult}; [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `mapper::Mapper` [INFO] [stderr] --> src/lib.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | use mapper::Mapper; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `mem::MemMap` [INFO] [stderr] --> src/lib.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | use mem::MemMap; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Oam`, `Ppu`, `Vram` [INFO] [stderr] --> src/lib.rs:37:11 [INFO] [stderr] | [INFO] [stderr] 37 | use ppu::{Oam, Ppu, Vram}; [INFO] [stderr] | ^^^ ^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `util::Save` [INFO] [stderr] --> src/lib.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | use util::Save; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::thread` [INFO] [stderr] --> src/lib.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | use std::thread; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `input_source::*` [INFO] [stderr] --> src/lib.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | use input_source::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `emulator::Emulator` [INFO] [stderr] --> src/lib.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | use emulator::Emulator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cell::RefCell` [INFO] [stderr] --> src/lib.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | use std::cell::RefCell; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/lib.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path::Path` [INFO] [stderr] --> src/lib.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | use std::path::Path; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::rc::Rc` [INFO] [stderr] --> src/lib.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | use std::rc::Rc; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::mpsc::channel` [INFO] [stderr] --> src/lib.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | use std::sync::mpsc::channel; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/lib.rs:54:1 [INFO] [stderr] | [INFO] [stderr] 54 | / macro_rules! log { [INFO] [stderr] 55 | | ( $( $t:tt )* ) => { [INFO] [stderr] 56 | | web_sys::console::log_1(&format!( $( $t )* ).into()); [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_macros)]` on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::sync::ONCE_INIT': the `new` function is now preferred [INFO] [stderr] --> src/audio.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / lazy_static! { [INFO] [stderr] 26 | | pub static ref AUDIO_MUTEX: Mutex<()> = Mutex::new(()); [INFO] [stderr] 27 | | pub static ref AUDIO_CONDVAR: Condvar = Condvar::new(); [INFO] [stderr] 28 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::sync::ONCE_INIT': the `new` function is now preferred [INFO] [stderr] --> src/audio.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / lazy_static! { [INFO] [stderr] 26 | | pub static ref AUDIO_MUTEX: Mutex<()> = Mutex::new(()); [INFO] [stderr] 27 | | pub static ref AUDIO_CONDVAR: Condvar = Condvar::new(); [INFO] [stderr] 28 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::sync::ONCE_INIT': the `new` function is now preferred [INFO] [stderr] --> src/audio.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / lazy_static! { [INFO] [stderr] 26 | | pub static ref AUDIO_MUTEX: Mutex<()> = Mutex::new(()); [INFO] [stderr] 27 | | pub static ref AUDIO_CONDVAR: Condvar = Condvar::new(); [INFO] [stderr] 28 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::sync::ONCE_INIT': the `new` function is now preferred [INFO] [stderr] --> src/audio.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / lazy_static! { [INFO] [stderr] 26 | | pub static ref AUDIO_MUTEX: Mutex<()> = Mutex::new(()); [INFO] [stderr] 27 | | pub static ref AUDIO_CONDVAR: Condvar = Condvar::new(); [INFO] [stderr] 28 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rom` [INFO] [stderr] --> src/lib.rs:80:23 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn start_emulator(rom: Rom, scale: Scale) { [INFO] [stderr] | ^^^ help: if this is intentional, prefix it with an underscore: `_rom` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `scale` [INFO] [stderr] --> src/lib.rs:80:33 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn start_emulator(rom: Rom, scale: Scale) { [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_scale` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pulse_number` [INFO] [stderr] --> src/apu.rs:600:30 [INFO] [stderr] | [INFO] [stderr] 600 | fn play_pulse(&mut self, pulse_number: usize, channel: usize) { [INFO] [stderr] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pulse_number` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `channel` [INFO] [stderr] --> src/apu.rs:600:51 [INFO] [stderr] | [INFO] [stderr] 600 | fn play_pulse(&mut self, pulse_number: usize, channel: usize) { [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_channel` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `channel` [INFO] [stderr] --> src/apu.rs:637:33 [INFO] [stderr] | [INFO] [stderr] 637 | fn play_triangle(&mut self, channel: usize) { [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_channel` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `channel` [INFO] [stderr] --> src/apu.rs:666:30 [INFO] [stderr] | [INFO] [stderr] 666 | fn play_noise(&mut self, channel: usize) { [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_channel` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `nes_sample_rate` [INFO] [stderr] --> src/resampler.rs:7:16 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn new(nes_sample_rate: u32, output_sample_rate: u32) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_nes_sample_rate` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `output_sample_rate` [INFO] [stderr] --> src/resampler.rs:7:38 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn new(nes_sample_rate: u32, output_sample_rate: u32) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_output_sample_rate` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `input` [INFO] [stderr] --> src/resampler.rs:14:27 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn process(&self, input: &mut [i16], output: &mut [u8]) { [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `output` [INFO] [stderr] --> src/resampler.rs:14:46 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn process(&self, input: &mut [i16], output: &mut [u8]) { [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_output` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ppu_screen` [INFO] [stderr] --> src/gfx.rs:327:24 [INFO] [stderr] | [INFO] [stderr] 327 | fn blit(&mut self, ppu_screen: &[u8; SCREEN_SIZE]) { [INFO] [stderr] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_ppu_screen` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/util.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn read_to_buf(mut buf: &mut [u8], rd: &mut Read) -> io::Result<()> { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/audio.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | unsafe { [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_unsafe)]` on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NES_SAMPLE_RATE` [INFO] [stderr] --> src/apu.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | const NES_SAMPLE_RATE: u32 = 1789920; // Actual is 1789800, but this is divisible by 240. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `OUTPUT_SAMPLE_RATE` [INFO] [stderr] --> src/apu.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | const OUTPUT_SAMPLE_RATE: u32 = 44100; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `TICK_FREQUENCY` [INFO] [stderr] --> src/apu.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | const TICK_FREQUENCY: u32 = 240; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NES_SAMPLES_PER_TICK` [INFO] [stderr] --> src/apu.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | const NES_SAMPLES_PER_TICK: u32 = NES_SAMPLE_RATE / TICK_FREQUENCY; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PULSE_WAVEFORMS` [INFO] [stderr] --> src/apu.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | const PULSE_WAVEFORMS: [u8; 4] = [ 0b01000000, 0b01100000, 0b01111000, 0b10011111 ]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `TRIANGLE_WAVEFORM` [INFO] [stderr] --> src/apu.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | / const TRIANGLE_WAVEFORM: [u8; 32] = [ [INFO] [stderr] 32 | | 15, 14, 13, 12, 11, 10, 9, 8, 7, 6, 5, 4, 3, 2, 1, 0, [INFO] [stderr] 33 | | 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, [INFO] [stderr] 34 | | ]; [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `audible` [INFO] [stderr] --> src/apu.rs:155:5 [INFO] [stderr] | [INFO] [stderr] 155 | fn audible(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `sample_volume` [INFO] [stderr] --> src/apu.rs:159:5 [INFO] [stderr] | [INFO] [stderr] 159 | fn sample_volume(&self) -> i16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `audible` [INFO] [stderr] --> src/apu.rs:193:5 [INFO] [stderr] | [INFO] [stderr] 193 | fn audible(&self) -> bool { self.value > 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `wavelen` [INFO] [stderr] --> src/apu.rs:194:5 [INFO] [stderr] | [INFO] [stderr] 194 | fn wavelen(&self) -> u64 { (self.value as u64 + 1) * 2 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `waveform_index` [INFO] [stderr] --> src/apu.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | waveform_index: u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `audible` [INFO] [stderr] --> src/apu.rs:308:5 [INFO] [stderr] | [INFO] [stderr] 308 | fn audible(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `rng` [INFO] [stderr] --> src/apu.rs:322:5 [INFO] [stderr] | [INFO] [stderr] 322 | rng: Xorshift, // FIXME: This is inaccurate. [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `SAMPLE_COUNT` [INFO] [stderr] --> src/apu.rs:400:1 [INFO] [stderr] | [INFO] [stderr] 400 | const SAMPLE_COUNT: usize = 178992; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `SampleBuffer` [INFO] [stderr] --> src/apu.rs:402:8 [INFO] [stderr] | [INFO] [stderr] 402 | struct SampleBuffer { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_or_zero_sample_buffer` [INFO] [stderr] --> src/apu.rs:587:5 [INFO] [stderr] | [INFO] [stderr] 587 | / fn get_or_zero_sample_buffer(buffer: &mut [i16], offset: usize, audible: bool) [INFO] [stderr] 588 | | -> Option<&mut [i16]> { [INFO] [stderr] 589 | | let buffer = &mut buffer[offset..offset + NES_SAMPLES_PER_TICK as usize]; [INFO] [stderr] 590 | | if audible { [INFO] [stderr] ... | [INFO] [stderr] 597 | | None [INFO] [stderr] 598 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `play_pulse` [INFO] [stderr] --> src/apu.rs:600:5 [INFO] [stderr] | [INFO] [stderr] 600 | fn play_pulse(&mut self, pulse_number: usize, channel: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `play_triangle` [INFO] [stderr] --> src/apu.rs:637:5 [INFO] [stderr] | [INFO] [stderr] 637 | fn play_triangle(&mut self, channel: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `play_noise` [INFO] [stderr] --> src/apu.rs:666:5 [INFO] [stderr] | [INFO] [stderr] 666 | fn play_noise(&mut self, channel: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `g_output_buffer` [INFO] [stderr] --> src/audio.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | static mut g_output_buffer: Option<*mut OutputBuffer> = None; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `factor` [INFO] [stderr] --> src/gfx.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | fn factor(self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static variable `g_output_buffer` should have an upper case name [INFO] [stderr] --> src/audio.rs:23:12 [INFO] [stderr] | [INFO] [stderr] 23 | static mut g_output_buffer: Option<*mut OutputBuffer> = None; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `G_OUTPUT_BUFFER` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stderr] [INFO] [stderr] warning: 94 warnings emitted [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stderr] --> src/util.rs:12:21 [INFO] [stderr] | [INFO] [stderr] 12 | let count = try!(rd.read(&mut buf[total..])); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(deprecated)]` on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stderr] --> src/rom.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | try!(util::read_to_buf(&mut header, r)); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stderr] --> src/rom.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | try!(util::read_to_buf(&mut prg_rom, r)); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stderr] --> src/rom.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | try!(util::read_to_buf(&mut chr_rom, r)); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Result` [INFO] [stderr] --> src/util.rs:6:34 [INFO] [stderr] | [INFO] [stderr] 6 | use std::io::{self, Read, Write, Result}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/util.rs:9:49 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn read_to_buf(mut buf: &mut [u8], rd: &mut Read) -> io::Result<()> { [INFO] [stderr] | ^^^^ help: use `dyn`: `dyn Read` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `OutputBuffer`, `self` [INFO] [stderr] --> src/apu.rs:7:13 [INFO] [stderr] | [INFO] [stderr] 7 | use audio::{self, OutputBuffer}; [INFO] [stderr] | ^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `resampler::Resampler` [INFO] [stderr] --> src/apu.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use resampler::Resampler; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/apu.rs:430:20 [INFO] [stderr] | [INFO] [stderr] 430 | 0x4000 ... 0x4003 => self.update_pulse(addr, val, 0), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/apu.rs:431:20 [INFO] [stderr] | [INFO] [stderr] 431 | 0x4004 ... 0x4007 => self.update_pulse(addr, val, 1), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/apu.rs:432:20 [INFO] [stderr] | [INFO] [stderr] 432 | 0x4008 ... 0x400b => self.regs.triangle.storeb(addr, val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/apu.rs:433:20 [INFO] [stderr] | [INFO] [stderr] 433 | 0x400c ... 0x400f => self.update_noise(addr, val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp` [INFO] [stderr] --> src/audio.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::cmp; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::slice::from_raw_parts_mut` [INFO] [stderr] --> src/audio.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use std::slice::from_raw_parts_mut; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/mapper.rs:26:44 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn create_mapper(rom: Box) -> Box { [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/mapper.rs:31:23 [INFO] [stderr] | [INFO] [stderr] 31 | }) as Box [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/mapper.rs:33:47 [INFO] [stderr] | [INFO] [stderr] 33 | 1 => Box::new(SxRom::new(rom)) as Box, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/mapper.rs:34:47 [INFO] [stderr] | [INFO] [stderr] 34 | 4 => Box::new(TxRom::new(rom)) as Box, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:341:23 [INFO] [stderr] | [INFO] [stderr] 341 | 0 ... 1 => self.chr_banks_2k[bank_update_select] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:342:23 [INFO] [stderr] | [INFO] [stderr] 342 | 2 ... 5 => self.chr_banks_1k[bank_update_select - 2] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:343:23 [INFO] [stderr] | [INFO] [stderr] 343 | 6 ... 7 => self.prg_banks[bank_update_select - 6] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:365:21 [INFO] [stderr] | [INFO] [stderr] 365 | (0x0000 ... 0x07ff, false) | (0x1000 ... 0x17ff, true) => (self.chr_banks_2k[0], true), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:365:50 [INFO] [stderr] | [INFO] [stderr] 365 | (0x0000 ... 0x07ff, false) | (0x1000 ... 0x17ff, true) => (self.chr_banks_2k[0], true), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:366:21 [INFO] [stderr] | [INFO] [stderr] 366 | (0x0800 ... 0x0fff, false) | (0x1800 ... 0x1fff, true) => (self.chr_banks_2k[1], true), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:366:50 [INFO] [stderr] | [INFO] [stderr] 366 | (0x0800 ... 0x0fff, false) | (0x1800 ... 0x1fff, true) => (self.chr_banks_2k[1], true), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:367:21 [INFO] [stderr] | [INFO] [stderr] 367 | (0x1000 ... 0x13ff, false) | (0x0000 ... 0x03ff, true) => (self.chr_banks_1k[0], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:367:50 [INFO] [stderr] | [INFO] [stderr] 367 | (0x1000 ... 0x13ff, false) | (0x0000 ... 0x03ff, true) => (self.chr_banks_1k[0], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:368:21 [INFO] [stderr] | [INFO] [stderr] 368 | (0x1400 ... 0x17ff, false) | (0x0400 ... 0x07ff, true) => (self.chr_banks_1k[1], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:368:50 [INFO] [stderr] | [INFO] [stderr] 368 | (0x1400 ... 0x17ff, false) | (0x0400 ... 0x07ff, true) => (self.chr_banks_1k[1], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:369:21 [INFO] [stderr] | [INFO] [stderr] 369 | (0x1800 ... 0x1bff, false) | (0x0800 ... 0x0bff, true) => (self.chr_banks_1k[2], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:369:50 [INFO] [stderr] | [INFO] [stderr] 369 | (0x1800 ... 0x1bff, false) | (0x0800 ... 0x0bff, true) => (self.chr_banks_1k[2], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:370:21 [INFO] [stderr] | [INFO] [stderr] 370 | (0x1c00 ... 0x1fff, false) | (0x0c00 ... 0x0fff, true) => (self.chr_banks_1k[3], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/mapper.rs:370:50 [INFO] [stderr] | [INFO] [stderr] 370 | (0x1c00 ... 0x1fff, false) | (0x0c00 ... 0x0fff, true) => (self.chr_banks_1k[3], false), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/mem.rs:82:32 [INFO] [stderr] | [INFO] [stderr] 82 | pub mapper: Rc>>, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/mem.rs:89:39 [INFO] [stderr] | [INFO] [stderr] 89 | mapper: Rc>>, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ppu.rs:207:32 [INFO] [stderr] | [INFO] [stderr] 207 | pub mapper: Rc>>, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ppu.rs:213:39 [INFO] [stderr] | [INFO] [stderr] 213 | pub fn new(mapper: Rc>>) -> Vram { [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn Mapper+Send` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/rom.rs:37:25 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn load(r: &mut Read) -> Result { [INFO] [stderr] | ^^^^ help: use `dyn`: `dyn Read` [INFO] [stderr] [INFO] [stderr] warning: unused import: `apu::Apu` [INFO] [stderr] --> src/lib.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | use apu::Apu; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `cpu::Cpu` [INFO] [stderr] --> src/lib.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | use cpu::Cpu; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Gfx` [INFO] [stderr] --> src/lib.rs:33:11 [INFO] [stderr] | [INFO] [stderr] 33 | use gfx::{Gfx, Scale}; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `InputResult`, `Input` [INFO] [stderr] --> src/lib.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | use input::{Input, InputResult}; [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `mapper::Mapper` [INFO] [stderr] --> src/lib.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | use mapper::Mapper; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `mem::MemMap` [INFO] [stderr] --> src/lib.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | use mem::MemMap; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Oam`, `Ppu`, `Vram` [INFO] [stderr] --> src/lib.rs:37:11 [INFO] [stderr] | [INFO] [stderr] 37 | use ppu::{Oam, Ppu, Vram}; [INFO] [stderr] | ^^^ ^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `util::Save` [INFO] [stderr] --> src/lib.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | use util::Save; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::thread` [INFO] [stderr] --> src/lib.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | use std::thread; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `input_source::*` [INFO] [stderr] --> src/lib.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | use input_source::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `emulator::Emulator` [INFO] [stderr] --> src/lib.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | use emulator::Emulator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cell::RefCell` [INFO] [stderr] --> src/lib.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | use std::cell::RefCell; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/lib.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path::Path` [INFO] [stderr] --> src/lib.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | use std::path::Path; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::rc::Rc` [INFO] [stderr] --> src/lib.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | use std::rc::Rc; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::mpsc::channel` [INFO] [stderr] --> src/lib.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | use std::sync::mpsc::channel; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/lib.rs:54:1 [INFO] [stderr] | [INFO] [stderr] 54 | / macro_rules! log { [INFO] [stderr] 55 | | ( $( $t:tt )* ) => { [INFO] [stderr] 56 | | web_sys::console::log_1(&format!( $( $t )* ).into()); [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_macros)]` on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::sync::ONCE_INIT': the `new` function is now preferred [INFO] [stderr] --> src/audio.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / lazy_static! { [INFO] [stderr] 26 | | pub static ref AUDIO_MUTEX: Mutex<()> = Mutex::new(()); [INFO] [stderr] 27 | | pub static ref AUDIO_CONDVAR: Condvar = Condvar::new(); [INFO] [stderr] 28 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::sync::ONCE_INIT': the `new` function is now preferred [INFO] [stderr] --> src/audio.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / lazy_static! { [INFO] [stderr] 26 | | pub static ref AUDIO_MUTEX: Mutex<()> = Mutex::new(()); [INFO] [stderr] 27 | | pub static ref AUDIO_CONDVAR: Condvar = Condvar::new(); [INFO] [stderr] 28 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::sync::ONCE_INIT': the `new` function is now preferred [INFO] [stderr] --> src/audio.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / lazy_static! { [INFO] [stderr] 26 | | pub static ref AUDIO_MUTEX: Mutex<()> = Mutex::new(()); [INFO] [stderr] 27 | | pub static ref AUDIO_CONDVAR: Condvar = Condvar::new(); [INFO] [stderr] 28 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::sync::ONCE_INIT': the `new` function is now preferred [INFO] [stderr] --> src/audio.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / lazy_static! { [INFO] [stderr] 26 | | pub static ref AUDIO_MUTEX: Mutex<()> = Mutex::new(()); [INFO] [stderr] 27 | | pub static ref AUDIO_CONDVAR: Condvar = Condvar::new(); [INFO] [stderr] 28 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rom` [INFO] [stderr] --> src/lib.rs:80:23 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn start_emulator(rom: Rom, scale: Scale) { [INFO] [stderr] | ^^^ help: if this is intentional, prefix it with an underscore: `_rom` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `scale` [INFO] [stderr] --> src/lib.rs:80:33 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn start_emulator(rom: Rom, scale: Scale) { [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_scale` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pulse_number` [INFO] [stderr] --> src/apu.rs:600:30 [INFO] [stderr] | [INFO] [stderr] 600 | fn play_pulse(&mut self, pulse_number: usize, channel: usize) { [INFO] [stderr] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pulse_number` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `channel` [INFO] [stderr] --> src/apu.rs:600:51 [INFO] [stderr] | [INFO] [stderr] 600 | fn play_pulse(&mut self, pulse_number: usize, channel: usize) { [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_channel` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `channel` [INFO] [stderr] --> src/apu.rs:637:33 [INFO] [stderr] | [INFO] [stderr] 637 | fn play_triangle(&mut self, channel: usize) { [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_channel` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `channel` [INFO] [stderr] --> src/apu.rs:666:30 [INFO] [stderr] | [INFO] [stderr] 666 | fn play_noise(&mut self, channel: usize) { [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_channel` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `nes_sample_rate` [INFO] [stderr] --> src/resampler.rs:7:16 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn new(nes_sample_rate: u32, output_sample_rate: u32) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_nes_sample_rate` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `output_sample_rate` [INFO] [stderr] --> src/resampler.rs:7:38 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn new(nes_sample_rate: u32, output_sample_rate: u32) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_output_sample_rate` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `input` [INFO] [stderr] --> src/resampler.rs:14:27 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn process(&self, input: &mut [i16], output: &mut [u8]) { [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `output` [INFO] [stderr] --> src/resampler.rs:14:46 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn process(&self, input: &mut [i16], output: &mut [u8]) { [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_output` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ppu_screen` [INFO] [stderr] --> src/gfx.rs:327:24 [INFO] [stderr] | [INFO] [stderr] 327 | fn blit(&mut self, ppu_screen: &[u8; SCREEN_SIZE]) { [INFO] [stderr] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_ppu_screen` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/util.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn read_to_buf(mut buf: &mut [u8], rd: &mut Read) -> io::Result<()> { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/audio.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | unsafe { [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_unsafe)]` on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NES_SAMPLE_RATE` [INFO] [stderr] --> src/apu.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | const NES_SAMPLE_RATE: u32 = 1789920; // Actual is 1789800, but this is divisible by 240. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `OUTPUT_SAMPLE_RATE` [INFO] [stderr] --> src/apu.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | const OUTPUT_SAMPLE_RATE: u32 = 44100; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `TICK_FREQUENCY` [INFO] [stderr] --> src/apu.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | const TICK_FREQUENCY: u32 = 240; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NES_SAMPLES_PER_TICK` [INFO] [stderr] --> src/apu.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | const NES_SAMPLES_PER_TICK: u32 = NES_SAMPLE_RATE / TICK_FREQUENCY; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PULSE_WAVEFORMS` [INFO] [stderr] --> src/apu.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | const PULSE_WAVEFORMS: [u8; 4] = [ 0b01000000, 0b01100000, 0b01111000, 0b10011111 ]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `TRIANGLE_WAVEFORM` [INFO] [stderr] --> src/apu.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | / const TRIANGLE_WAVEFORM: [u8; 32] = [ [INFO] [stderr] 32 | | 15, 14, 13, 12, 11, 10, 9, 8, 7, 6, 5, 4, 3, 2, 1, 0, [INFO] [stderr] 33 | | 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, [INFO] [stderr] 34 | | ]; [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `audible` [INFO] [stderr] --> src/apu.rs:155:5 [INFO] [stderr] | [INFO] [stderr] 155 | fn audible(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `sample_volume` [INFO] [stderr] --> src/apu.rs:159:5 [INFO] [stderr] | [INFO] [stderr] 159 | fn sample_volume(&self) -> i16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `audible` [INFO] [stderr] --> src/apu.rs:193:5 [INFO] [stderr] | [INFO] [stderr] 193 | fn audible(&self) -> bool { self.value > 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `wavelen` [INFO] [stderr] --> src/apu.rs:194:5 [INFO] [stderr] | [INFO] [stderr] 194 | fn wavelen(&self) -> u64 { (self.value as u64 + 1) * 2 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `waveform_index` [INFO] [stderr] --> src/apu.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | waveform_index: u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `audible` [INFO] [stderr] --> src/apu.rs:308:5 [INFO] [stderr] | [INFO] [stderr] 308 | fn audible(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `rng` [INFO] [stderr] --> src/apu.rs:322:5 [INFO] [stderr] | [INFO] [stderr] 322 | rng: Xorshift, // FIXME: This is inaccurate. [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `SAMPLE_COUNT` [INFO] [stderr] --> src/apu.rs:400:1 [INFO] [stderr] | [INFO] [stderr] 400 | const SAMPLE_COUNT: usize = 178992; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `SampleBuffer` [INFO] [stderr] --> src/apu.rs:402:8 [INFO] [stderr] | [INFO] [stderr] 402 | struct SampleBuffer { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_or_zero_sample_buffer` [INFO] [stderr] --> src/apu.rs:587:5 [INFO] [stderr] | [INFO] [stderr] 587 | / fn get_or_zero_sample_buffer(buffer: &mut [i16], offset: usize, audible: bool) [INFO] [stderr] 588 | | -> Option<&mut [i16]> { [INFO] [stderr] 589 | | let buffer = &mut buffer[offset..offset + NES_SAMPLES_PER_TICK as usize]; [INFO] [stderr] 590 | | if audible { [INFO] [stderr] ... | [INFO] [stderr] 597 | | None [INFO] [stderr] 598 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `play_pulse` [INFO] [stderr] --> src/apu.rs:600:5 [INFO] [stderr] | [INFO] [stderr] 600 | fn play_pulse(&mut self, pulse_number: usize, channel: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `play_triangle` [INFO] [stderr] --> src/apu.rs:637:5 [INFO] [stderr] | [INFO] [stderr] 637 | fn play_triangle(&mut self, channel: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `play_noise` [INFO] [stderr] --> src/apu.rs:666:5 [INFO] [stderr] | [INFO] [stderr] 666 | fn play_noise(&mut self, channel: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `g_output_buffer` [INFO] [stderr] --> src/audio.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | static mut g_output_buffer: Option<*mut OutputBuffer> = None; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `factor` [INFO] [stderr] --> src/gfx.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | fn factor(self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static variable `g_output_buffer` should have an upper case name [INFO] [stderr] --> src/audio.rs:23:12 [INFO] [stderr] | [INFO] [stderr] 23 | static mut g_output_buffer: Option<*mut OutputBuffer> = None; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `G_OUTPUT_BUFFER` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stderr] [INFO] [stderr] warning: 94 warnings emitted [INFO] [stderr] [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 0.14s [INFO] [stderr] Running /opt/rustwide/target/debug/deps/nes-a4cd9151bcfc57f8 [INFO] [stderr] Running /opt/rustwide/target/debug/deps/nes-c538932b8c5a1373 [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Doc-tests nes [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out [INFO] [stdout] [INFO] running `"docker" "inspect" "248ab03cf19ec74c045c392aeafbd9014093cb615c3489a37a89f6fafcedd02d"` [INFO] running `"docker" "rm" "-f" "248ab03cf19ec74c045c392aeafbd9014093cb615c3489a37a89f6fafcedd02d"` [INFO] [stdout] 248ab03cf19ec74c045c392aeafbd9014093cb615c3489a37a89f6fafcedd02d