[INFO] updating cached repository theonly112/rsgb [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/theonly112/rsgb [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/theonly112/rsgb" "work/ex/beta-1.38-1/sources/1.37.0/gh/theonly112/rsgb"` [INFO] [stderr] Cloning into 'work/ex/beta-1.38-1/sources/1.37.0/gh/theonly112/rsgb'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/theonly112/rsgb" "work/ex/beta-1.38-1/sources/beta-2019-08-13/gh/theonly112/rsgb"` [INFO] [stderr] Cloning into 'work/ex/beta-1.38-1/sources/beta-2019-08-13/gh/theonly112/rsgb'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4007f54dad15eef80ddfbb22f8fad724ced578a8 [INFO] sha for GitHub repo theonly112/rsgb: 4007f54dad15eef80ddfbb22f8fad724ced578a8 [INFO] validating manifest of theonly112/rsgb on toolchain 1.37.0 [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+1.37.0" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of theonly112/rsgb on toolchain beta-2019-08-13 [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+beta-2019-08-13" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing theonly112/rsgb [INFO] finished frobbing theonly112/rsgb [INFO] frobbed toml for theonly112/rsgb written to work/ex/beta-1.38-1/sources/1.37.0/gh/theonly112/rsgb/Cargo.toml [INFO] started frobbing theonly112/rsgb [INFO] finished frobbing theonly112/rsgb [INFO] frobbed toml for theonly112/rsgb written to work/ex/beta-1.38-1/sources/beta-2019-08-13/gh/theonly112/rsgb/Cargo.toml [INFO] crate theonly112/rsgb already has a lockfile, it will not be regenerated [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+1.37.0" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+beta-2019-08-13" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] testing theonly112/rsgb against beta-2019-08-13 for beta-1.38-1 [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/beta-1.38-1/worker-3/beta-2019-08-13:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/beta-1.38-1/sources/beta-2019-08-13/gh/theonly112/rsgb:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+beta-2019-08-13" "build" "--frozen"` [INFO] [stdout] 07ebb6917783405049dcc3c785f62969f5cc817e6c43e3caffbfef2f016a8fb9 [INFO] running `"docker" "start" "-a" "07ebb6917783405049dcc3c785f62969f5cc817e6c43e3caffbfef2f016a8fb9"` [INFO] [stderr] Compiling libc v0.2.19 [INFO] [stderr] Compiling sdl2-sys v0.27.2 [INFO] [stderr] Compiling rand v0.3.15 [INFO] [stderr] Compiling time v0.1.36 [INFO] [stderr] Compiling sdl2 v0.27.3 [INFO] [stderr] Compiling rsgb v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/gb/cpu.rs:1586:27 [INFO] [stderr] | [INFO] [stderr] 1586 | self.zero_flag_u8((value & bit)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/gb/cpu.rs:1614:18 [INFO] [stderr] | [INFO] [stderr] 1614 | self.bit((1 << bit), val); [INFO] [stderr] | ^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/gb/mmu.rs:22:14 [INFO] [stderr] | [INFO] [stderr] 22 | mbc: Box, [INFO] [stderr] | ^^^ help: use `dyn`: `dyn Mbc` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/gb/mmu.rs:27:22 [INFO] [stderr] | [INFO] [stderr] 27 | let mbc: Box = match cart.cartirge_type { [INFO] [stderr] | ^^^ help: use `dyn`: `dyn Mbc` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:130:19 [INFO] [stderr] | [INFO] [stderr] 130 | 0x0000...0x7FFF => self.mbc.read_u8(addr), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:131:19 [INFO] [stderr] | [INFO] [stderr] 131 | 0xA000...0xBFFF => self.mbc.read_u8(addr), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:132:19 [INFO] [stderr] | [INFO] [stderr] 132 | 0x8000...0x9FFF => self.vram[(addr - 0x8000) as usize], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:133:19 [INFO] [stderr] | [INFO] [stderr] 133 | 0xC000...0xDFFF => self.wram[(addr - 0xC000) as usize], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:134:19 [INFO] [stderr] | [INFO] [stderr] 134 | 0xE000...0xFDFF => self.wram[(addr - 0xE000) as usize], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:135:19 [INFO] [stderr] | [INFO] [stderr] 135 | 0xFE00...0xFEFF => self.oam[(addr - 0xFE00) as usize], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:144:19 [INFO] [stderr] | [INFO] [stderr] 144 | 0xFF80...0xFFFE => self.hram[(addr - 0xff80) as usize], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:145:19 [INFO] [stderr] | [INFO] [stderr] 145 | 0xFF00...0xFF7F => self.io[(addr - 0xff00) as usize], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:156:19 [INFO] [stderr] | [INFO] [stderr] 156 | 0x0000...0x7FFF => self.mbc.write_u8(addr, val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:157:19 [INFO] [stderr] | [INFO] [stderr] 157 | 0x8000...0x9FFF => self.vram_write(addr, val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:158:19 [INFO] [stderr] | [INFO] [stderr] 158 | 0xA000...0xBFFF => self.mbc.write_u8(addr, val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:159:19 [INFO] [stderr] | [INFO] [stderr] 159 | 0xC000...0xDFFF => self.wram[(addr - 0xC000) as usize] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:160:19 [INFO] [stderr] | [INFO] [stderr] 160 | 0xE000...0xFDFF => self.wram[(addr - 0xE000) as usize] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:161:19 [INFO] [stderr] | [INFO] [stderr] 161 | 0xFE00...0xFEFF => self.oam[(addr - 0xfe00) as usize] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:162:19 [INFO] [stderr] | [INFO] [stderr] 162 | 0xFF80...0xFFFE => self.hram[(addr - 0xff80) as usize] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:172:19 [INFO] [stderr] | [INFO] [stderr] 172 | 0xFF00...0xFF7F => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:204:19 [INFO] [stderr] | [INFO] [stderr] 204 | 0x0000...0x3fff => self.cart.rom[addr as usize], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:205:19 [INFO] [stderr] | [INFO] [stderr] 205 | 0x4000...0x7fff => self.cart.rom[((addr - 0x4000) as usize + 0x4000 * self.rom_bank)], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:206:19 [INFO] [stderr] | [INFO] [stderr] 206 | 0xA000...0xbfff => self.ram[self.ram_bank][(addr - 0xa000) as usize], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:212:19 [INFO] [stderr] | [INFO] [stderr] 212 | 0x2000...0x3fff => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:215:19 [INFO] [stderr] | [INFO] [stderr] 215 | 0x4000...0x5fff => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:223:19 [INFO] [stderr] | [INFO] [stderr] 223 | 0x6000...0x7fff => self.ram_mode = value == 1, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:224:19 [INFO] [stderr] | [INFO] [stderr] 224 | 0xa000...0xbfff => self.ram[self.ram_bank][(addr - 0xa000) as usize] = value, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:249:19 [INFO] [stderr] | [INFO] [stderr] 249 | 0x0000...0x7fff => self.cart.rom[addr as usize], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:250:19 [INFO] [stderr] | [INFO] [stderr] 250 | 0xa000...0xbfff => self.ram[(addr - 0xa000) as usize], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:256:19 [INFO] [stderr] | [INFO] [stderr] 256 | 0xA000...0xBFFF => self.ram[(addr - 0xA000) as usize] = value, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gb/cpu.rs:294:13 [INFO] [stderr] | [INFO] [stderr] 294 | _ => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gb/cpu.rs:1554:13 [INFO] [stderr] | [INFO] [stderr] 1554 | _ => { [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gb/mmu.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | _ => panic!("invalid addr"), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gb/mmu.rs:179:13 [INFO] [stderr] | [INFO] [stderr] 179 | _ => panic!("Not implemented"), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `mmu` [INFO] [stderr] --> src/gb/gpu.rs:219:17 [INFO] [stderr] | [INFO] [stderr] 219 | let ref mmu = self.mmu.as_ref().unwrap().borrow_mut(); [INFO] [stderr] | ^^^ help: consider prefixing with an underscore: `_mmu` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tiles` [INFO] [stderr] --> src/gb/gpu.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | let tiles = self.status.window_tilemap(); [INFO] [stderr] | ^^^^^ help: consider prefixing with an underscore: `_tiles` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `map` [INFO] [stderr] --> src/gb/gpu.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | let map = self.status.bg_tilemap(); [INFO] [stderr] | ^^^ help: consider prefixing with an underscore: `_map` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tileY` [INFO] [stderr] --> src/gb/gpu.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | let tileY = self.status.wy / 8; [INFO] [stderr] | ^^^^^ help: consider prefixing with an underscore: `_tileY` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tileYOffset` [INFO] [stderr] --> src/gb/gpu.rs:224:13 [INFO] [stderr] | [INFO] [stderr] 224 | let tileYOffset = self.status.wy % 8; [INFO] [stderr] | ^^^^^^^^^^^ help: consider prefixing with an underscore: `_tileYOffset` [INFO] [stderr] [INFO] [stderr] warning: value assigned to `tile` is never read [INFO] [stderr] --> src/gb/gpu.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | let mut tile: u8 = 0; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_assignments)]` on by default [INFO] [stderr] = help: maybe it is overwritten before being read? [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gb/interrupts.rs:100:37 [INFO] [stderr] | [INFO] [stderr] 100 | pub fn handle_vblank(&mut self, mut display: &mut SdlDisplay) { [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable `tileY` should have a snake case name [INFO] [stderr] --> src/gb/gpu.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | let tileY = self.status.wy / 8; [INFO] [stderr] | ^^^^^ help: convert the identifier to snake case: `tile_y` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable `tileYOffset` should have a snake case name [INFO] [stderr] --> src/gb/gpu.rs:224:13 [INFO] [stderr] | [INFO] [stderr] 224 | let tileYOffset = self.status.wy % 8; [INFO] [stderr] | ^^^^^^^^^^^ help: convert the identifier to snake case: `tile_yoffset` [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.25s [INFO] running `"docker" "inspect" "07ebb6917783405049dcc3c785f62969f5cc817e6c43e3caffbfef2f016a8fb9"` [INFO] running `"docker" "rm" "-f" "07ebb6917783405049dcc3c785f62969f5cc817e6c43e3caffbfef2f016a8fb9"` [INFO] [stdout] 07ebb6917783405049dcc3c785f62969f5cc817e6c43e3caffbfef2f016a8fb9 [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/beta-1.38-1/worker-3/beta-2019-08-13:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/beta-1.38-1/sources/beta-2019-08-13/gh/theonly112/rsgb:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+beta-2019-08-13" "test" "--frozen" "--no-run"` [INFO] [stdout] ee37af8580ac03a73e3d0470fd74b4affedda5f081ac7f22e1542f2605f58b25 [INFO] running `"docker" "start" "-a" "ee37af8580ac03a73e3d0470fd74b4affedda5f081ac7f22e1542f2605f58b25"` [INFO] [stderr] Compiling rsgb v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/gb/cpu.rs:1586:27 [INFO] [stderr] | [INFO] [stderr] 1586 | self.zero_flag_u8((value & bit)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/gb/cpu.rs:1614:18 [INFO] [stderr] | [INFO] [stderr] 1614 | self.bit((1 << bit), val); [INFO] [stderr] | ^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/gb/mmu.rs:22:14 [INFO] [stderr] | [INFO] [stderr] 22 | mbc: Box, [INFO] [stderr] | ^^^ help: use `dyn`: `dyn Mbc` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/gb/mmu.rs:27:22 [INFO] [stderr] | [INFO] [stderr] 27 | let mbc: Box = match cart.cartirge_type { [INFO] [stderr] | ^^^ help: use `dyn`: `dyn Mbc` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:130:19 [INFO] [stderr] | [INFO] [stderr] 130 | 0x0000...0x7FFF => self.mbc.read_u8(addr), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:131:19 [INFO] [stderr] | [INFO] [stderr] 131 | 0xA000...0xBFFF => self.mbc.read_u8(addr), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:132:19 [INFO] [stderr] | [INFO] [stderr] 132 | 0x8000...0x9FFF => self.vram[(addr - 0x8000) as usize], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:133:19 [INFO] [stderr] | [INFO] [stderr] 133 | 0xC000...0xDFFF => self.wram[(addr - 0xC000) as usize], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:134:19 [INFO] [stderr] | [INFO] [stderr] 134 | 0xE000...0xFDFF => self.wram[(addr - 0xE000) as usize], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:135:19 [INFO] [stderr] | [INFO] [stderr] 135 | 0xFE00...0xFEFF => self.oam[(addr - 0xFE00) as usize], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:144:19 [INFO] [stderr] | [INFO] [stderr] 144 | 0xFF80...0xFFFE => self.hram[(addr - 0xff80) as usize], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:145:19 [INFO] [stderr] | [INFO] [stderr] 145 | 0xFF00...0xFF7F => self.io[(addr - 0xff00) as usize], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:156:19 [INFO] [stderr] | [INFO] [stderr] 156 | 0x0000...0x7FFF => self.mbc.write_u8(addr, val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:157:19 [INFO] [stderr] | [INFO] [stderr] 157 | 0x8000...0x9FFF => self.vram_write(addr, val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:158:19 [INFO] [stderr] | [INFO] [stderr] 158 | 0xA000...0xBFFF => self.mbc.write_u8(addr, val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:159:19 [INFO] [stderr] | [INFO] [stderr] 159 | 0xC000...0xDFFF => self.wram[(addr - 0xC000) as usize] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:160:19 [INFO] [stderr] | [INFO] [stderr] 160 | 0xE000...0xFDFF => self.wram[(addr - 0xE000) as usize] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:161:19 [INFO] [stderr] | [INFO] [stderr] 161 | 0xFE00...0xFEFF => self.oam[(addr - 0xfe00) as usize] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:162:19 [INFO] [stderr] | [INFO] [stderr] 162 | 0xFF80...0xFFFE => self.hram[(addr - 0xff80) as usize] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:172:19 [INFO] [stderr] | [INFO] [stderr] 172 | 0xFF00...0xFF7F => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:204:19 [INFO] [stderr] | [INFO] [stderr] 204 | 0x0000...0x3fff => self.cart.rom[addr as usize], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:205:19 [INFO] [stderr] | [INFO] [stderr] 205 | 0x4000...0x7fff => self.cart.rom[((addr - 0x4000) as usize + 0x4000 * self.rom_bank)], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:206:19 [INFO] [stderr] | [INFO] [stderr] 206 | 0xA000...0xbfff => self.ram[self.ram_bank][(addr - 0xa000) as usize], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:212:19 [INFO] [stderr] | [INFO] [stderr] 212 | 0x2000...0x3fff => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:215:19 [INFO] [stderr] | [INFO] [stderr] 215 | 0x4000...0x5fff => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:223:19 [INFO] [stderr] | [INFO] [stderr] 223 | 0x6000...0x7fff => self.ram_mode = value == 1, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:224:19 [INFO] [stderr] | [INFO] [stderr] 224 | 0xa000...0xbfff => self.ram[self.ram_bank][(addr - 0xa000) as usize] = value, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:249:19 [INFO] [stderr] | [INFO] [stderr] 249 | 0x0000...0x7fff => self.cart.rom[addr as usize], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:250:19 [INFO] [stderr] | [INFO] [stderr] 250 | 0xa000...0xbfff => self.ram[(addr - 0xa000) as usize], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/gb/mmu.rs:256:19 [INFO] [stderr] | [INFO] [stderr] 256 | 0xA000...0xBFFF => self.ram[(addr - 0xA000) as usize] = value, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gb/cpu.rs:294:13 [INFO] [stderr] | [INFO] [stderr] 294 | _ => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gb/cpu.rs:1554:13 [INFO] [stderr] | [INFO] [stderr] 1554 | _ => { [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gb/mmu.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | _ => panic!("invalid addr"), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/gb/mmu.rs:179:13 [INFO] [stderr] | [INFO] [stderr] 179 | _ => panic!("Not implemented"), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `mmu` [INFO] [stderr] --> src/gb/gpu.rs:219:17 [INFO] [stderr] | [INFO] [stderr] 219 | let ref mmu = self.mmu.as_ref().unwrap().borrow_mut(); [INFO] [stderr] | ^^^ help: consider prefixing with an underscore: `_mmu` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tiles` [INFO] [stderr] --> src/gb/gpu.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | let tiles = self.status.window_tilemap(); [INFO] [stderr] | ^^^^^ help: consider prefixing with an underscore: `_tiles` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `map` [INFO] [stderr] --> src/gb/gpu.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | let map = self.status.bg_tilemap(); [INFO] [stderr] | ^^^ help: consider prefixing with an underscore: `_map` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tileY` [INFO] [stderr] --> src/gb/gpu.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | let tileY = self.status.wy / 8; [INFO] [stderr] | ^^^^^ help: consider prefixing with an underscore: `_tileY` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tileYOffset` [INFO] [stderr] --> src/gb/gpu.rs:224:13 [INFO] [stderr] | [INFO] [stderr] 224 | let tileYOffset = self.status.wy % 8; [INFO] [stderr] | ^^^^^^^^^^^ help: consider prefixing with an underscore: `_tileYOffset` [INFO] [stderr] [INFO] [stderr] warning: value assigned to `tile` is never read [INFO] [stderr] --> src/gb/gpu.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | let mut tile: u8 = 0; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_assignments)]` on by default [INFO] [stderr] = help: maybe it is overwritten before being read? [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/gb/interrupts.rs:100:37 [INFO] [stderr] | [INFO] [stderr] 100 | pub fn handle_vblank(&mut self, mut display: &mut SdlDisplay) { [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable `tileY` should have a snake case name [INFO] [stderr] --> src/gb/gpu.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | let tileY = self.status.wy / 8; [INFO] [stderr] | ^^^^^ help: convert the identifier to snake case: `tile_y` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable `tileYOffset` should have a snake case name [INFO] [stderr] --> src/gb/gpu.rs:224:13 [INFO] [stderr] | [INFO] [stderr] 224 | let tileYOffset = self.status.wy % 8; [INFO] [stderr] | ^^^^^^^^^^^ help: convert the identifier to snake case: `tile_yoffset` [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.79s [INFO] running `"docker" "inspect" "ee37af8580ac03a73e3d0470fd74b4affedda5f081ac7f22e1542f2605f58b25"` [INFO] running `"docker" "rm" "-f" "ee37af8580ac03a73e3d0470fd74b4affedda5f081ac7f22e1542f2605f58b25"` [INFO] [stdout] ee37af8580ac03a73e3d0470fd74b4affedda5f081ac7f22e1542f2605f58b25 [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/beta-1.38-1/worker-3/beta-2019-08-13:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/beta-1.38-1/sources/beta-2019-08-13/gh/theonly112/rsgb:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+beta-2019-08-13" "test" "--frozen"` [INFO] [stdout] 74f1e1f7d05cf643e6b1a715b8faa03bc735adce2ef8831471d674a046038664 [INFO] running `"docker" "start" "-a" "74f1e1f7d05cf643e6b1a715b8faa03bc735adce2ef8831471d674a046038664"` [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.02s [INFO] [stderr] Running /opt/crater/target/debug/deps/rsgb-f912cc428b629800 [INFO] [stdout] [INFO] [stdout] running 1 test [INFO] [stdout] test gb::catridge::cartrige_from_u8 ... ok [INFO] [stdout] [INFO] [stdout] test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out [INFO] [stdout] [INFO] running `"docker" "inspect" "74f1e1f7d05cf643e6b1a715b8faa03bc735adce2ef8831471d674a046038664"` [INFO] running `"docker" "rm" "-f" "74f1e1f7d05cf643e6b1a715b8faa03bc735adce2ef8831471d674a046038664"` [INFO] [stdout] 74f1e1f7d05cf643e6b1a715b8faa03bc735adce2ef8831471d674a046038664