[INFO] updating cached repository christopherjmedlin/hackman [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/christopherjmedlin/hackman [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/christopherjmedlin/hackman" "work/ex/beta-1.38-1/sources/1.37.0/gh/christopherjmedlin/hackman"` [INFO] [stderr] Cloning into 'work/ex/beta-1.38-1/sources/1.37.0/gh/christopherjmedlin/hackman'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/christopherjmedlin/hackman" "work/ex/beta-1.38-1/sources/beta-2019-08-13/gh/christopherjmedlin/hackman"` [INFO] [stderr] Cloning into 'work/ex/beta-1.38-1/sources/beta-2019-08-13/gh/christopherjmedlin/hackman'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 116a625552d35f2f8a7bd06f69005ef7283238b0 [INFO] sha for GitHub repo christopherjmedlin/hackman: 116a625552d35f2f8a7bd06f69005ef7283238b0 [INFO] validating manifest of christopherjmedlin/hackman on toolchain 1.37.0 [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+1.37.0" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of christopherjmedlin/hackman on toolchain beta-2019-08-13 [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+beta-2019-08-13" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing christopherjmedlin/hackman [INFO] finished frobbing christopherjmedlin/hackman [INFO] frobbed toml for christopherjmedlin/hackman written to work/ex/beta-1.38-1/sources/1.37.0/gh/christopherjmedlin/hackman/Cargo.toml [INFO] started frobbing christopherjmedlin/hackman [INFO] finished frobbing christopherjmedlin/hackman [INFO] frobbed toml for christopherjmedlin/hackman written to work/ex/beta-1.38-1/sources/beta-2019-08-13/gh/christopherjmedlin/hackman/Cargo.toml [INFO] crate christopherjmedlin/hackman already has a lockfile, it will not be regenerated [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+1.37.0" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+beta-2019-08-13" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] testing christopherjmedlin/hackman against beta-2019-08-13 for beta-1.38-1 [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/beta-1.38-1/worker-7/beta-2019-08-13:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/beta-1.38-1/sources/beta-2019-08-13/gh/christopherjmedlin/hackman:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+beta-2019-08-13" "build" "--frozen"` [INFO] [stdout] b91a6a026ae8f9aeb45ab7402b856f8a2403b2f1138a9dc456b75f0f778a3803 [INFO] running `"docker" "start" "-a" "b91a6a026ae8f9aeb45ab7402b856f8a2403b2f1138a9dc456b75f0f778a3803"` [INFO] [stderr] Compiling sdl2-sys v0.31.0 [INFO] [stderr] Compiling sdl2 v0.31.0 [INFO] [stderr] Compiling pacman v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:49:22 [INFO] [stderr] | [INFO] [stderr] 49 | memory: &mut Memory, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:50:18 [INFO] [stderr] | [INFO] [stderr] 50 | io: &mut InputOutput, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:73:22 [INFO] [stderr] | [INFO] [stderr] 73 | memory: &mut Memory, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:74:18 [INFO] [stderr] | [INFO] [stderr] 74 | io: &mut InputOutput, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mod.rs:134:18 [INFO] [stderr] | [INFO] [stderr] 134 | (0, 4...7, 0) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:539:46 [INFO] [stderr] | [INFO] [stderr] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:539:63 [INFO] [stderr] | [INFO] [stderr] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:626:58 [INFO] [stderr] | [INFO] [stderr] 626 | fn run_ed_opcode(&mut self, opcode: u8, memory: &mut Memory, io: &mut InputOutput) -> usize { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:626:75 [INFO] [stderr] | [INFO] [stderr] 626 | fn run_ed_opcode(&mut self, opcode: u8, memory: &mut Memory, io: &mut InputOutput) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mod.rs:782:21 [INFO] [stderr] | [INFO] [stderr] 782 | (2, _, 0...3) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:792:42 [INFO] [stderr] | [INFO] [stderr] 792 | fn r(&mut self, index: u8, mem: &mut Memory) -> u8 { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:800:58 [INFO] [stderr] | [INFO] [stderr] 800 | fn write_r(&mut self, index: u8, byte: u8, mem: &mut Memory) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:808:47 [INFO] [stderr] | [INFO] [stderr] 808 | fn bli(&mut self, a: u8, b: u8, mem: &mut Memory, io: &mut InputOutput) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:808:64 [INFO] [stderr] | [INFO] [stderr] 808 | fn bli(&mut self, a: u8, b: u8, mem: &mut Memory, io: &mut InputOutput) { [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:952:42 [INFO] [stderr] | [INFO] [stderr] 952 | fn load_inc_dec(&mut self, mem: &mut Memory, inc: bool) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:974:42 [INFO] [stderr] | [INFO] [stderr] 974 | fn comp_inc_dec(&mut self, mem: &mut Memory, inc: bool) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1274:42 [INFO] [stderr] | [INFO] [stderr] 1274 | fn dec_8(&mut self, y: u8, mem: &mut Memory) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1288:42 [INFO] [stderr] | [INFO] [stderr] 1288 | fn inc_8(&mut self, y: u8, mem: &mut Memory) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1303:34 [INFO] [stderr] | [INFO] [stderr] 1303 | fn call(&mut self, mem: &mut Memory, addr: u16) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1310:33 [INFO] [stderr] | [INFO] [stderr] 1310 | fn ret(&mut self, mem: &mut Memory) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1316:39 [INFO] [stderr] | [INFO] [stderr] 1316 | fn pop_stack(&mut self, mem: &mut Memory) -> u8 { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1324:40 [INFO] [stderr] | [INFO] [stderr] 1324 | fn push_stack(&mut self, mem: &mut Memory, byte: u8) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1333:43 [INFO] [stderr] | [INFO] [stderr] 1333 | fn push_stack_16(&mut self, mem: &mut Memory, word: u16) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1338:42 [INFO] [stderr] | [INFO] [stderr] 1338 | fn pop_stack_16(&mut self, mem: &mut Memory) -> u16 { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:74:24 [INFO] [stderr] | [INFO] [stderr] 74 | (GAME_ROM_START...GAME_ROM_END, false) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:78:24 [INFO] [stderr] | [INFO] [stderr] 78 | (GAME_ROM_START...GAME_ROM_END, true) => Err("Cannot write to ROM."), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:80:26 [INFO] [stderr] | [INFO] [stderr] 80 | (VRAM_TILES_START...VRAM_TILES_END, _) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:84:29 [INFO] [stderr] | [INFO] [stderr] 84 | (VRAM_PALETTES_START...VRAM_PALETTES_END, _) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:88:19 [INFO] [stderr] | [INFO] [stderr] 88 | (RAM_START...RAM_END, _) => Ok(Address::Ram((addr - RAM_START) as usize)), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:90:28 [INFO] [stderr] | [INFO] [stderr] 90 | (VRAM_SPRITES_START...VRAM_SPRITES_END, _) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:94:28 [INFO] [stderr] | [INFO] [stderr] 94 | (IN0_REGISTER_START...IN0_REGISTER_END, false) => Ok(Address::IN0Register), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:105:28 [INFO] [stderr] | [INFO] [stderr] 105 | (IN1_REGISTER_START...IN1_REGISTER_END, false) => Ok(Address::IN1Register), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:107:21 [INFO] [stderr] | [INFO] [stderr] 107 | (SOUND_START...SOUND_END, true) => Ok(Address::Sound((addr - SOUND_START) as usize)), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:109:25 [INFO] [stderr] | [INFO] [stderr] 109 | (SPRITE_XY_START...SPRITE_XY_END, true) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:113:26 [INFO] [stderr] | [INFO] [stderr] 113 | (DIP_SWITCH_START...DIP_SWITCH_END, _) => Ok(Address::DipSwitchRegister), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:115:24 [INFO] [stderr] | [INFO] [stderr] 115 | (WATCHDOG_START...WATCHDOG_END, _) => Ok(Address::WatchdogTimerReset), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::*` [INFO] [stderr] --> src/memory_mapper.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | use super::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::boxed::Box` [INFO] [stderr] --> src/memory_mapper.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | use std::boxed::Box; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: denote infinite loops with `loop { ... }` [INFO] [stderr] --> src/pacman.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | while true { [INFO] [stderr] | ^^^^^^^^^^ help: use `loop` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(while_true)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | #[macro_use(matches)] [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/cpu/mod.rs:912:13 [INFO] [stderr] | [INFO] [stderr] 912 | (5, 2) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/cpu/mod.rs:919:13 [INFO] [stderr] | [INFO] [stderr] 919 | (6, 2) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/cpu/mod.rs:933:13 [INFO] [stderr] | [INFO] [stderr] 933 | (7, 2) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/cpu/mod.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | for i in 0..iters { [INFO] [stderr] | ^ help: consider prefixing with an underscore: `_i` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `io` [INFO] [stderr] --> src/cpu/mod.rs:539:54 [INFO] [stderr] | [INFO] [stderr] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stderr] | ^^ help: consider prefixing with an underscore: `_io` [INFO] [stderr] [INFO] [stderr] warning: variable `number_of_ones` is assigned to, but never used [INFO] [stderr] --> src/cpu/mod.rs:1381:17 [INFO] [stderr] | [INFO] [stderr] 1381 | let mut number_of_ones = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_number_of_ones` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `port` [INFO] [stderr] --> src/cpu/io.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | fn input(&self, port: u8) -> u8 { [INFO] [stderr] | ^^^^ help: consider prefixing with an underscore: `_port` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `port` [INFO] [stderr] --> src/cpu/io.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | fn output(&mut self, port: u8, byte: u8) { [INFO] [stderr] | ^^^^ help: consider prefixing with an underscore: `_port` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `result` [INFO] [stderr] --> src/display.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | let result = canvas.fill_rect(Rect::new(x_coord, y_coord, 2, 2)); [INFO] [stderr] | ^^^^^^ help: consider prefixing with an underscore: `_result` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x_flip` [INFO] [stderr] --> src/display.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | x_flip: bool, [INFO] [stderr] | ^^^^^^ help: consider prefixing with an underscore: `_x_flip` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y_flip` [INFO] [stderr] --> src/display.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | y_flip: bool, [INFO] [stderr] | ^^^^^^ help: consider prefixing with an underscore: `_y_flip` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `port` [INFO] [stderr] --> src/interrupt_vector.rs:14:21 [INFO] [stderr] | [INFO] [stderr] 14 | fn input(&self, port: u8) -> u8 { [INFO] [stderr] | ^^^^ help: consider prefixing with an underscore: `_port` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `port` [INFO] [stderr] --> src/interrupt_vector.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | fn output(&mut self, port: u8, byte: u8) { [INFO] [stderr] | ^^^^ help: consider prefixing with an underscore: `_port` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `color` [INFO] [stderr] --> src/rom.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | let color = self.color_rom[*byte as usize]; [INFO] [stderr] | ^^^^^ help: consider prefixing with an underscore: `_color` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `why` [INFO] [stderr] --> src/rom.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | Err(why) => panic!("Missing ROMs"), [INFO] [stderr] | ^^^ help: consider prefixing with an underscore: `_why` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `why` [INFO] [stderr] --> src/rom.rs:142:17 [INFO] [stderr] | [INFO] [stderr] 142 | Err(why) => panic!("Error reading ROM"), [INFO] [stderr] | ^^^ help: consider prefixing with an underscore: `_why` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu/mod.rs:1145:13 [INFO] [stderr] | [INFO] [stderr] 1145 | let mut result = left.wrapping_sub(right); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu/mod.rs:1347:13 [INFO] [stderr] | [INFO] [stderr] 1347 | let mut left = left + (carry as u8); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu/mod.rs:1354:13 [INFO] [stderr] | [INFO] [stderr] 1354 | let mut left = left - (carry as u8); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `TestIO` [INFO] [stderr] --> src/cpu/io.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub struct TestIO { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/cpu/io.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn new() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `TestMemory` [INFO] [stderr] --> src/cpu/mem.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | pub struct TestMemory { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/cpu/mem.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn new() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `draw_sprite` [INFO] [stderr] --> src/display.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn draw_sprite(&mut self, x: usize, y: usize, sprite: usize, palette: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `VramPalettes` [INFO] [stderr] --> src/memory_map.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | VramPalettes(usize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `roms` [INFO] [stderr] --> src/pacman.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | roms: &'a Box, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.20s [INFO] running `"docker" "inspect" "b91a6a026ae8f9aeb45ab7402b856f8a2403b2f1138a9dc456b75f0f778a3803"` [INFO] running `"docker" "rm" "-f" "b91a6a026ae8f9aeb45ab7402b856f8a2403b2f1138a9dc456b75f0f778a3803"` [INFO] [stdout] b91a6a026ae8f9aeb45ab7402b856f8a2403b2f1138a9dc456b75f0f778a3803 [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/beta-1.38-1/worker-7/beta-2019-08-13:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/beta-1.38-1/sources/beta-2019-08-13/gh/christopherjmedlin/hackman:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+beta-2019-08-13" "test" "--frozen" "--no-run"` [INFO] [stdout] e2cb6c3231f9c3f94defcf2bb230c8a3155b78c24437daa43f8d3c7eef7305f6 [INFO] running `"docker" "start" "-a" "e2cb6c3231f9c3f94defcf2bb230c8a3155b78c24437daa43f8d3c7eef7305f6"` [INFO] [stderr] Compiling pacman v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:49:22 [INFO] [stderr] | [INFO] [stderr] 49 | memory: &mut Memory, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:50:18 [INFO] [stderr] | [INFO] [stderr] 50 | io: &mut InputOutput, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:73:22 [INFO] [stderr] | [INFO] [stderr] 73 | memory: &mut Memory, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:74:18 [INFO] [stderr] | [INFO] [stderr] 74 | io: &mut InputOutput, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mod.rs:134:18 [INFO] [stderr] | [INFO] [stderr] 134 | (0, 4...7, 0) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:539:46 [INFO] [stderr] | [INFO] [stderr] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:539:63 [INFO] [stderr] | [INFO] [stderr] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:626:58 [INFO] [stderr] | [INFO] [stderr] 626 | fn run_ed_opcode(&mut self, opcode: u8, memory: &mut Memory, io: &mut InputOutput) -> usize { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:626:75 [INFO] [stderr] | [INFO] [stderr] 626 | fn run_ed_opcode(&mut self, opcode: u8, memory: &mut Memory, io: &mut InputOutput) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mod.rs:782:21 [INFO] [stderr] | [INFO] [stderr] 782 | (2, _, 0...3) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:792:42 [INFO] [stderr] | [INFO] [stderr] 792 | fn r(&mut self, index: u8, mem: &mut Memory) -> u8 { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:800:58 [INFO] [stderr] | [INFO] [stderr] 800 | fn write_r(&mut self, index: u8, byte: u8, mem: &mut Memory) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:808:47 [INFO] [stderr] | [INFO] [stderr] 808 | fn bli(&mut self, a: u8, b: u8, mem: &mut Memory, io: &mut InputOutput) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:808:64 [INFO] [stderr] | [INFO] [stderr] 808 | fn bli(&mut self, a: u8, b: u8, mem: &mut Memory, io: &mut InputOutput) { [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:952:42 [INFO] [stderr] | [INFO] [stderr] 952 | fn load_inc_dec(&mut self, mem: &mut Memory, inc: bool) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:974:42 [INFO] [stderr] | [INFO] [stderr] 974 | fn comp_inc_dec(&mut self, mem: &mut Memory, inc: bool) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1274:42 [INFO] [stderr] | [INFO] [stderr] 1274 | fn dec_8(&mut self, y: u8, mem: &mut Memory) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1288:42 [INFO] [stderr] | [INFO] [stderr] 1288 | fn inc_8(&mut self, y: u8, mem: &mut Memory) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1303:34 [INFO] [stderr] | [INFO] [stderr] 1303 | fn call(&mut self, mem: &mut Memory, addr: u16) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1310:33 [INFO] [stderr] | [INFO] [stderr] 1310 | fn ret(&mut self, mem: &mut Memory) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1316:39 [INFO] [stderr] | [INFO] [stderr] 1316 | fn pop_stack(&mut self, mem: &mut Memory) -> u8 { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1324:40 [INFO] [stderr] | [INFO] [stderr] 1324 | fn push_stack(&mut self, mem: &mut Memory, byte: u8) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1333:43 [INFO] [stderr] | [INFO] [stderr] 1333 | fn push_stack_16(&mut self, mem: &mut Memory, word: u16) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1338:42 [INFO] [stderr] | [INFO] [stderr] 1338 | fn pop_stack_16(&mut self, mem: &mut Memory) -> u16 { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:74:24 [INFO] [stderr] | [INFO] [stderr] 74 | (GAME_ROM_START...GAME_ROM_END, false) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:78:24 [INFO] [stderr] | [INFO] [stderr] 78 | (GAME_ROM_START...GAME_ROM_END, true) => Err("Cannot write to ROM."), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:80:26 [INFO] [stderr] | [INFO] [stderr] 80 | (VRAM_TILES_START...VRAM_TILES_END, _) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:84:29 [INFO] [stderr] | [INFO] [stderr] 84 | (VRAM_PALETTES_START...VRAM_PALETTES_END, _) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:88:19 [INFO] [stderr] | [INFO] [stderr] 88 | (RAM_START...RAM_END, _) => Ok(Address::Ram((addr - RAM_START) as usize)), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:90:28 [INFO] [stderr] | [INFO] [stderr] 90 | (VRAM_SPRITES_START...VRAM_SPRITES_END, _) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:94:28 [INFO] [stderr] | [INFO] [stderr] 94 | (IN0_REGISTER_START...IN0_REGISTER_END, false) => Ok(Address::IN0Register), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:105:28 [INFO] [stderr] | [INFO] [stderr] 105 | (IN1_REGISTER_START...IN1_REGISTER_END, false) => Ok(Address::IN1Register), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:107:21 [INFO] [stderr] | [INFO] [stderr] 107 | (SOUND_START...SOUND_END, true) => Ok(Address::Sound((addr - SOUND_START) as usize)), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:109:25 [INFO] [stderr] | [INFO] [stderr] 109 | (SPRITE_XY_START...SPRITE_XY_END, true) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:113:26 [INFO] [stderr] | [INFO] [stderr] 113 | (DIP_SWITCH_START...DIP_SWITCH_END, _) => Ok(Address::DipSwitchRegister), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:115:24 [INFO] [stderr] | [INFO] [stderr] 115 | (WATCHDOG_START...WATCHDOG_END, _) => Ok(Address::WatchdogTimerReset), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: denote infinite loops with `loop { ... }` [INFO] [stderr] --> src/pacman.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | while true { [INFO] [stderr] | ^^^^^^^^^^ help: use `loop` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(while_true)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/cpu/mod.rs:912:13 [INFO] [stderr] | [INFO] [stderr] 912 | (5, 2) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/cpu/mod.rs:919:13 [INFO] [stderr] | [INFO] [stderr] 919 | (6, 2) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/cpu/mod.rs:933:13 [INFO] [stderr] | [INFO] [stderr] 933 | (7, 2) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/cpu/mod.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | for i in 0..iters { [INFO] [stderr] | ^ help: consider prefixing with an underscore: `_i` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `io` [INFO] [stderr] --> src/cpu/mod.rs:539:54 [INFO] [stderr] | [INFO] [stderr] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stderr] | ^^ help: consider prefixing with an underscore: `_io` [INFO] [stderr] [INFO] [stderr] warning: variable `number_of_ones` is assigned to, but never used [INFO] [stderr] --> src/cpu/mod.rs:1381:17 [INFO] [stderr] | [INFO] [stderr] 1381 | let mut number_of_ones = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_number_of_ones` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `port` [INFO] [stderr] --> src/cpu/io.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | fn input(&self, port: u8) -> u8 { [INFO] [stderr] | ^^^^ help: consider prefixing with an underscore: `_port` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `port` [INFO] [stderr] --> src/cpu/io.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | fn output(&mut self, port: u8, byte: u8) { [INFO] [stderr] | ^^^^ help: consider prefixing with an underscore: `_port` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `mem` [INFO] [stderr] --> src/cpu/tests.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | let mut mem = &mut TestMemory::new(); [INFO] [stderr] | ^^^ help: consider prefixing with an underscore: `_mem` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `result` [INFO] [stderr] --> src/display.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | let result = canvas.fill_rect(Rect::new(x_coord, y_coord, 2, 2)); [INFO] [stderr] | ^^^^^^ help: consider prefixing with an underscore: `_result` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x_flip` [INFO] [stderr] --> src/display.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | x_flip: bool, [INFO] [stderr] | ^^^^^^ help: consider prefixing with an underscore: `_x_flip` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y_flip` [INFO] [stderr] --> src/display.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | y_flip: bool, [INFO] [stderr] | ^^^^^^ help: consider prefixing with an underscore: `_y_flip` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `port` [INFO] [stderr] --> src/interrupt_vector.rs:14:21 [INFO] [stderr] | [INFO] [stderr] 14 | fn input(&self, port: u8) -> u8 { [INFO] [stderr] | ^^^^ help: consider prefixing with an underscore: `_port` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `port` [INFO] [stderr] --> src/interrupt_vector.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | fn output(&mut self, port: u8, byte: u8) { [INFO] [stderr] | ^^^^ help: consider prefixing with an underscore: `_port` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `color` [INFO] [stderr] --> src/rom.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | let color = self.color_rom[*byte as usize]; [INFO] [stderr] | ^^^^^ help: consider prefixing with an underscore: `_color` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `why` [INFO] [stderr] --> src/rom.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | Err(why) => panic!("Missing ROMs"), [INFO] [stderr] | ^^^ help: consider prefixing with an underscore: `_why` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `why` [INFO] [stderr] --> src/rom.rs:142:17 [INFO] [stderr] | [INFO] [stderr] 142 | Err(why) => panic!("Error reading ROM"), [INFO] [stderr] | ^^^ help: consider prefixing with an underscore: `_why` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu/mod.rs:1145:13 [INFO] [stderr] | [INFO] [stderr] 1145 | let mut result = left.wrapping_sub(right); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu/mod.rs:1347:13 [INFO] [stderr] | [INFO] [stderr] 1347 | let mut left = left + (carry as u8); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu/mod.rs:1354:13 [INFO] [stderr] | [INFO] [stderr] 1354 | let mut left = left - (carry as u8); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu/tests.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | let mut mem = &mut TestMemory::new(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: method is never used: `draw_sprite` [INFO] [stderr] --> src/display.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn draw_sprite(&mut self, x: usize, y: usize, sprite: usize, palette: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `VramPalettes` [INFO] [stderr] --> src/memory_map.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | VramPalettes(usize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `roms` [INFO] [stderr] --> src/pacman.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | roms: &'a Box, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.51s [INFO] running `"docker" "inspect" "e2cb6c3231f9c3f94defcf2bb230c8a3155b78c24437daa43f8d3c7eef7305f6"` [INFO] running `"docker" "rm" "-f" "e2cb6c3231f9c3f94defcf2bb230c8a3155b78c24437daa43f8d3c7eef7305f6"` [INFO] [stdout] e2cb6c3231f9c3f94defcf2bb230c8a3155b78c24437daa43f8d3c7eef7305f6 [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/beta-1.38-1/worker-7/beta-2019-08-13:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/beta-1.38-1/sources/beta-2019-08-13/gh/christopherjmedlin/hackman:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+beta-2019-08-13" "test" "--frozen"` [INFO] [stdout] 84b80b97f35b210f49a0e6adbe56c1ac3aa199bfea1f53b7cf44fb9b83804677 [INFO] running `"docker" "start" "-a" "84b80b97f35b210f49a0e6adbe56c1ac3aa199bfea1f53b7cf44fb9b83804677"` [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.02s [INFO] [stderr] Running /opt/crater/target/debug/deps/pacman-f088bc140ba3b5f3 [INFO] [stdout] [INFO] [stdout] running 28 tests [INFO] [stdout] test cpu::reg::tests::test_16bit_registers ... ok [INFO] [stdout] test cpu::reg::tests::test_cc ... ok [INFO] [stdout] test cpu::reg::tests::test_write_16bit_r ... ok [INFO] [stdout] test cpu::tests::test_8bit_inc_dec ... ok [INFO] [stdout] test cpu::tests::test_8bit_loading ... ok [INFO] [stdout] test cpu::tests::test_16bit_ld ... ok [INFO] [stdout] test cpu::tests::test_add ... ok [INFO] [stdout] test cpu::tests::test_16bit_inc_dec ... ok [INFO] [stdout] test cpu::tests::test_bit_test ... ok [INFO] [stdout] test cpu::tests::test_detect_overflow ... ok [INFO] [stdout] test cpu::tests::test_indirect_loads ... ok [INFO] [stdout] test cpu::tests::test_io ... ok [INFO] [stdout] test cpu::tests::test_interrupt ... ok [INFO] [stdout] test cpu::tests::test_ix_iy_bit_operations ... ok [INFO] [stdout] test cpu::tests::test_ix_operations ... ok [INFO] [stdout] test cpu::tests::test_neg ... ok [INFO] [stdout] test cpu::tests::test_run_opcodes ... ok [INFO] [stdout] test cpu::tests::test_jr ... ok [INFO] [stdout] test cpu::tests::test_shift ... ok [INFO] [stdout] test cpu::tests::test_stack ... ok [INFO] [stdout] test cpu::tests::test_return ... ok [INFO] [stdout] test memory_map::tests::test_memory_map ... ok [INFO] [stdout] test memory_mapper::tests::test_read ... ok [INFO] [stdout] test memory_mapper::tests::test_inital_state ... ok [INFO] [stdout] test cpu::tests::test_sub ... ok [INFO] [stdout] test memory_mapper::tests::test_valid_write ... ok [INFO] [stdout] test cpu::tests::test_halt ... FAILED [INFO] [stdout] test memory_mapper::tests::test_invalid_write ... ok [INFO] [stderr] error: test failed, to rerun pass '--bin pacman' [INFO] [stdout] [INFO] [stdout] failures: [INFO] [stdout] [INFO] [stdout] ---- cpu::tests::test_halt stdout ---- [INFO] [stdout] thread 'cpu::tests::test_halt' panicked at 'assertion failed: `(left == right)` [INFO] [stdout] left: `4`, [INFO] [stdout] right: `0`', src/cpu/tests.rs:123:5 [INFO] [stdout] stack backtrace: [INFO] [stdout] 0: 0x55f5fa8e9eab - backtrace::backtrace::libunwind::trace::h23ae608c8b906c69 [INFO] [stdout] at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.34/src/backtrace/libunwind.rs:88 [INFO] [stdout] 1: 0x55f5fa8e9eab - backtrace::backtrace::trace_unsynchronized::h65b3ea295a85fd48 [INFO] [stdout] at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.34/src/backtrace/mod.rs:66 [INFO] [stdout] 2: 0x55f5fa8e9eab - std::sys_common::backtrace::_print::h24f527b44b6cfc06 [INFO] [stdout] at src/libstd/sys_common/backtrace.rs:47 [INFO] [stdout] 3: 0x55f5fa8e9eab - std::sys_common::backtrace::print::h712608e4347fd64a [INFO] [stdout] at src/libstd/sys_common/backtrace.rs:36 [INFO] [stdout] 4: 0x55f5fa8e9eab - std::panicking::default_hook::{{closure}}::h6c3d570c2b500048 [INFO] [stdout] at src/libstd/panicking.rs:200 [INFO] [stdout] 5: 0x55f5fa8e9b1c - std::panicking::default_hook::hb29963fb4747e0dd [INFO] [stdout] at src/libstd/panicking.rs:211 [INFO] [stdout] 6: 0x55f5fa8ea61d - std::panicking::rust_panic_with_hook::hd1236c3083de823a [INFO] [stdout] at src/libstd/panicking.rs:477 [INFO] [stdout] 7: 0x55f5fa8ea1a2 - std::panicking::continue_panic_fmt::he38ad41d6304a12c [INFO] [stdout] at src/libstd/panicking.rs:384 [INFO] [stdout] 8: 0x55f5fa8ea0ef - std::panicking::begin_panic_fmt::h4b478f1ed53f4521 [INFO] [stdout] at src/libstd/panicking.rs:339 [INFO] [stdout] 9: 0x55f5fa88f9d4 - pacman::cpu::tests::test_halt::h9546a4136e9f448b [INFO] [stdout] at src/cpu/tests.rs:123 [INFO] [stdout] 10: 0x55f5fa88f75a - pacman::cpu::tests::test_halt::{{closure}}::ha43886a1176846d3 [INFO] [stdout] at src/cpu/tests.rs:117 [INFO] [stdout] 11: 0x55f5fa89b33e - core::ops::function::FnOnce::call_once::h88620196d87c1906 [INFO] [stdout] at /rustc/e450539c2a8d7f791268d699cbe45ab3e57d43a1/src/libcore/ops/function.rs:235 [INFO] [stdout] 12: 0x55f5fa8aa73f - as core::ops::function::FnOnce>::call_once::h355e655b04400826 [INFO] [stdout] at /rustc/e450539c2a8d7f791268d699cbe45ab3e57d43a1/src/liballoc/boxed.rs:787 [INFO] [stdout] 13: 0x55f5fa8ecefa - __rust_maybe_catch_panic [INFO] [stdout] at src/libpanic_unwind/lib.rs:80 [INFO] [stdout] 14: 0x55f5fa8c4d2e - std::panicking::try::h5890cbed5d1d8df0 [INFO] [stdout] at /rustc/e450539c2a8d7f791268d699cbe45ab3e57d43a1/src/libstd/panicking.rs:275 [INFO] [stdout] 15: 0x55f5fa8c4d2e - std::panic::catch_unwind::hf93cc71fc6442fdf [INFO] [stdout] at /rustc/e450539c2a8d7f791268d699cbe45ab3e57d43a1/src/libstd/panic.rs:394 [INFO] [stdout] 16: 0x55f5fa8c4d2e - test::run_test::run_test_inner::{{closure}}::ha399a28a3066698d [INFO] [stdout] at src/libtest/lib.rs:1408 [INFO] [stdout] 17: 0x55f5fa8a0165 - std::sys_common::backtrace::__rust_begin_short_backtrace::h089859c639046955 [INFO] [stdout] at /rustc/e450539c2a8d7f791268d699cbe45ab3e57d43a1/src/libstd/sys_common/backtrace.rs:77 [INFO] [stdout] 18: 0x55f5fa8a4375 - std::thread::Builder::spawn_unchecked::{{closure}}::{{closure}}::h8d489100862c3e01 [INFO] [stdout] at /rustc/e450539c2a8d7f791268d699cbe45ab3e57d43a1/src/libstd/thread/mod.rs:470 [INFO] [stdout] 19: 0x55f5fa8a4375 - as core::ops::function::FnOnce<()>>::call_once::h5746c9e2571824d0 [INFO] [stdout] at /rustc/e450539c2a8d7f791268d699cbe45ab3e57d43a1/src/libstd/panic.rs:315 [INFO] [stdout] 20: 0x55f5fa8a4375 - std::panicking::try::do_call::hfd443b32b22f72a6 [INFO] [stdout] at /rustc/e450539c2a8d7f791268d699cbe45ab3e57d43a1/src/libstd/panicking.rs:296 [INFO] [stdout] 21: 0x55f5fa8ecefa - __rust_maybe_catch_panic [INFO] [stdout] at src/libpanic_unwind/lib.rs:80 [INFO] [stdout] 22: 0x55f5fa8a4972 - std::panicking::try::h332f368ed7d9b7d1 [INFO] [stdout] at /rustc/e450539c2a8d7f791268d699cbe45ab3e57d43a1/src/libstd/panicking.rs:275 [INFO] [stdout] 23: 0x55f5fa8a4972 - std::panic::catch_unwind::h316b7be8b4198222 [INFO] [stdout] at /rustc/e450539c2a8d7f791268d699cbe45ab3e57d43a1/src/libstd/panic.rs:394 [INFO] [stdout] 24: 0x55f5fa8a4972 - std::thread::Builder::spawn_unchecked::{{closure}}::h916aed08bc6e5276 [INFO] [stdout] at /rustc/e450539c2a8d7f791268d699cbe45ab3e57d43a1/src/libstd/thread/mod.rs:469 [INFO] [stdout] 25: 0x55f5fa8a4972 - core::ops::function::FnOnce::call_once{{vtable.shim}}::h9091646be5c55ea6 [INFO] [stdout] at /rustc/e450539c2a8d7f791268d699cbe45ab3e57d43a1/src/libcore/ops/function.rs:235 [INFO] [stdout] 26: 0x55f5fa8dfdcf - as core::ops::function::FnOnce>::call_once::hb5396a93648ae250 [INFO] [stdout] at /rustc/e450539c2a8d7f791268d699cbe45ab3e57d43a1/src/liballoc/boxed.rs:787 [INFO] [stdout] 27: 0x55f5fa8ec630 - as core::ops::function::FnOnce>::call_once::h92593001847bb63e [INFO] [stdout] at /rustc/e450539c2a8d7f791268d699cbe45ab3e57d43a1/src/liballoc/boxed.rs:787 [INFO] [stdout] 28: 0x55f5fa8ec630 - std::sys_common::thread::start_thread::h569f3ccc0d5dcd83 [INFO] [stdout] at src/libstd/sys_common/thread.rs:13 [INFO] [stdout] 29: 0x55f5fa8ec630 - std::sys::unix::thread::Thread::new::thread_start::hd9ff46fad032d886 [INFO] [stdout] at src/libstd/sys/unix/thread.rs:79 [INFO] [stdout] 30: 0x7fa07e3d84a4 - start_thread [INFO] [stdout] 31: 0x7fa07df03d0f - __clone [INFO] [stdout] 32: 0x0 - [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] failures: [INFO] [stdout] cpu::tests::test_halt [INFO] [stdout] [INFO] [stdout] test result: FAILED. 27 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out [INFO] [stdout] [INFO] running `"docker" "inspect" "84b80b97f35b210f49a0e6adbe56c1ac3aa199bfea1f53b7cf44fb9b83804677"` [INFO] running `"docker" "rm" "-f" "84b80b97f35b210f49a0e6adbe56c1ac3aa199bfea1f53b7cf44fb9b83804677"` [INFO] [stdout] 84b80b97f35b210f49a0e6adbe56c1ac3aa199bfea1f53b7cf44fb9b83804677