[INFO] updating cached repository EleanorWhite/goFish [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/EleanorWhite/goFish [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/EleanorWhite/goFish" "work/ex/beta-1.38-1/sources/1.37.0/gh/EleanorWhite/goFish"` [INFO] [stderr] Cloning into 'work/ex/beta-1.38-1/sources/1.37.0/gh/EleanorWhite/goFish'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/EleanorWhite/goFish" "work/ex/beta-1.38-1/sources/beta-2019-08-13/gh/EleanorWhite/goFish"` [INFO] [stderr] Cloning into 'work/ex/beta-1.38-1/sources/beta-2019-08-13/gh/EleanorWhite/goFish'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cc95edb4e675f768bcfa0cd6288e0e9faca9639d [INFO] sha for GitHub repo EleanorWhite/goFish: cc95edb4e675f768bcfa0cd6288e0e9faca9639d [INFO] validating manifest of EleanorWhite/goFish on toolchain 1.37.0 [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+1.37.0" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of EleanorWhite/goFish on toolchain beta-2019-08-13 [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+beta-2019-08-13" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing EleanorWhite/goFish [INFO] finished frobbing EleanorWhite/goFish [INFO] frobbed toml for EleanorWhite/goFish written to work/ex/beta-1.38-1/sources/1.37.0/gh/EleanorWhite/goFish/Cargo.toml [INFO] started frobbing EleanorWhite/goFish [INFO] finished frobbing EleanorWhite/goFish [INFO] frobbed toml for EleanorWhite/goFish written to work/ex/beta-1.38-1/sources/beta-2019-08-13/gh/EleanorWhite/goFish/Cargo.toml [INFO] crate EleanorWhite/goFish already has a lockfile, it will not be regenerated [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+1.37.0" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+beta-2019-08-13" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] testing EleanorWhite/goFish against beta-2019-08-13 for beta-1.38-1 [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/beta-1.38-1/worker-2/beta-2019-08-13:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/beta-1.38-1/sources/beta-2019-08-13/gh/EleanorWhite/goFish:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+beta-2019-08-13" "build" "--frozen"` [INFO] [stdout] efed5fc56ab08afbf1be4c30d638a7707e0f269672412dc87ae44733e4e4ceb2 [INFO] running `"docker" "start" "-a" "efed5fc56ab08afbf1be4c30d638a7707e0f269672412dc87ae44733e4e4ceb2"` [INFO] [stderr] Compiling autocfg v0.1.4 [INFO] [stderr] Compiling libc v0.2.53 [INFO] [stderr] Compiling numtoa v0.1.0 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling rand_os v0.1.3 [INFO] [stderr] Compiling termion v1.5.2 [INFO] [stderr] Compiling new_rust_project v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused imports: `Write`, `stdin`, `stdout` [INFO] [stderr] --> src/main.rs:7:15 [INFO] [stderr] | [INFO] [stderr] 7 | use std::io::{Write, stdout, stdin}; [INFO] [stderr] | ^^^^^ ^^^^^^ ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:59:6 [INFO] [stderr] | [INFO] [stderr] 59 | if (ranks[i] == card) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:80:7 [INFO] [stderr] | [INFO] [stderr] 80 | if (new < min_val) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | if (playing_hand.is_empty()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:124:6 [INFO] [stderr] | [INFO] [stderr] 124 | if (deck.is_empty()) { // game is over [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `while` condition [INFO] [stderr] --> src/main.rs:137:8 [INFO] [stderr] | [INFO] [stderr] 137 | while (!card_in(playing_hand, &guess)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | if (correct) { [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:157:5 [INFO] [stderr] | [INFO] [stderr] 157 | if (comp_hand.is_empty()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:158:6 [INFO] [stderr] | [INFO] [stderr] 158 | if (deck.is_empty()) { // game is over [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:183:5 [INFO] [stderr] | [INFO] [stderr] 183 | if (correct) { [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:191:6 [INFO] [stderr] | [INFO] [stderr] 191 | if (c == card) { [INFO] [stderr] | ^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:202:5 [INFO] [stderr] | [INFO] [stderr] 202 | if (card_in(other_hand, &guess)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:208:7 [INFO] [stderr] | [INFO] [stderr] 208 | if (c == &guess) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:230:10 [INFO] [stderr] | [INFO] [stderr] 230 | if (is_player) { println!("Drew {}", &x); } [INFO] [stderr] | ^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:239:7 [INFO] [stderr] | [INFO] [stderr] 239 | if (c == guess) { [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:243:6 [INFO] [stderr] | [INFO] [stderr] 243 | if (count == 4) { [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:250:5 [INFO] [stderr] | [INFO] [stderr] 250 | if (comp_finished.len() > player_finished.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: denote infinite loops with `loop { ... }` [INFO] [stderr] --> src/main.rs:271:2 [INFO] [stderr] | [INFO] [stderr] 271 | while true { [INFO] [stderr] | ^^^^^^^^^^ help: use `loop` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(while_true)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:272:6 [INFO] [stderr] | [INFO] [stderr] 272 | if (deck.is_empty() && player_hand.is_empty()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::trim_right': superseded by `trim_end` [INFO] [stderr] --> src/main.rs:135:25 [INFO] [stderr] | [INFO] [stderr] 135 | let mut guess = buffer.trim_right().to_string(); [INFO] [stderr] | ^^^^^^^^^^ help: replace the use of the deprecated item: `trim_end` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(deprecated)]` on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::trim_right': superseded by `trim_end` [INFO] [stderr] --> src/main.rs:143:18 [INFO] [stderr] | [INFO] [stderr] 143 | guess = buffer.trim_right().to_string(); [INFO] [stderr] | ^^^^^^^^^^ help: replace the use of the deprecated item: `trim_end` [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::trim_right': superseded by `trim_end` [INFO] [stderr] --> src/main.rs:146:21 [INFO] [stderr] | [INFO] [stderr] 146 | &mut deck, guess.trim_right().to_string(), true); [INFO] [stderr] | ^^^^^^^^^^ help: replace the use of the deprecated item: `trim_end` [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::trim_right': superseded by `trim_end` [INFO] [stderr] --> src/main.rs:181:21 [INFO] [stderr] | [INFO] [stderr] 181 | &mut deck, guess.trim_right().to_string(), false); [INFO] [stderr] | ^^^^^^^^^^ help: replace the use of the deprecated item: `trim_end` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `suite` [INFO] [stderr] --> src/main.rs:50:7 [INFO] [stderr] | [INFO] [stderr] 50 | for suite in 0..NUM_SUITES { [INFO] [stderr] | ^^^^^ help: consider prefixing with an underscore: `_suite` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/main.rs:95:6 [INFO] [stderr] | [INFO] [stderr] 95 | for i in 0..NUM_HAND { [INFO] [stderr] | ^ help: consider prefixing with an underscore: `_i` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:35:12 [INFO] [stderr] | [INFO] [stderr] 35 | fn shuffle(mut cards: &mut Vec) { [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:133:6 [INFO] [stderr] | [INFO] [stderr] 133 | let mut buffer = &mut String::new(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:199:2 [INFO] [stderr] | [INFO] [stderr] 199 | mut other_hand: &mut Vec, mut deck: &mut Vec, guess: String, is_player: bool) -> bool { [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: constant `ranks` should have an upper case name [INFO] [stderr] --> src/main.rs:28:7 [INFO] [stderr] | [INFO] [stderr] 28 | const ranks: [&'static str; NUM_RANKS as usize] = ["ace", "one", "two", "three", "four", "five", "six", [INFO] [stderr] | ^^^^^ help: convert the identifier to upper case: `RANKS` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:134:2 [INFO] [stderr] | [INFO] [stderr] 134 | std::io::stdin().read_line(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_must_use)]` on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:142:6 [INFO] [stderr] | [INFO] [stderr] 142 | std::io::stdin().read_line(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.64s [INFO] running `"docker" "inspect" "efed5fc56ab08afbf1be4c30d638a7707e0f269672412dc87ae44733e4e4ceb2"` [INFO] running `"docker" "rm" "-f" "efed5fc56ab08afbf1be4c30d638a7707e0f269672412dc87ae44733e4e4ceb2"` [INFO] [stdout] efed5fc56ab08afbf1be4c30d638a7707e0f269672412dc87ae44733e4e4ceb2 [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/beta-1.38-1/worker-2/beta-2019-08-13:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/beta-1.38-1/sources/beta-2019-08-13/gh/EleanorWhite/goFish:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+beta-2019-08-13" "test" "--frozen" "--no-run"` [INFO] [stdout] 759a49d9986c5df8aab8c278af94414bb707a027983b806d2a3f82671df349ed [INFO] running `"docker" "start" "-a" "759a49d9986c5df8aab8c278af94414bb707a027983b806d2a3f82671df349ed"` [INFO] [stderr] Compiling new_rust_project v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused imports: `Write`, `stdin`, `stdout` [INFO] [stderr] --> src/main.rs:7:15 [INFO] [stderr] | [INFO] [stderr] 7 | use std::io::{Write, stdout, stdin}; [INFO] [stderr] | ^^^^^ ^^^^^^ ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:59:6 [INFO] [stderr] | [INFO] [stderr] 59 | if (ranks[i] == card) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:80:7 [INFO] [stderr] | [INFO] [stderr] 80 | if (new < min_val) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | if (playing_hand.is_empty()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:124:6 [INFO] [stderr] | [INFO] [stderr] 124 | if (deck.is_empty()) { // game is over [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `while` condition [INFO] [stderr] --> src/main.rs:137:8 [INFO] [stderr] | [INFO] [stderr] 137 | while (!card_in(playing_hand, &guess)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | if (correct) { [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:157:5 [INFO] [stderr] | [INFO] [stderr] 157 | if (comp_hand.is_empty()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:158:6 [INFO] [stderr] | [INFO] [stderr] 158 | if (deck.is_empty()) { // game is over [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:183:5 [INFO] [stderr] | [INFO] [stderr] 183 | if (correct) { [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:191:6 [INFO] [stderr] | [INFO] [stderr] 191 | if (c == card) { [INFO] [stderr] | ^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:202:5 [INFO] [stderr] | [INFO] [stderr] 202 | if (card_in(other_hand, &guess)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:208:7 [INFO] [stderr] | [INFO] [stderr] 208 | if (c == &guess) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:230:10 [INFO] [stderr] | [INFO] [stderr] 230 | if (is_player) { println!("Drew {}", &x); } [INFO] [stderr] | ^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:239:7 [INFO] [stderr] | [INFO] [stderr] 239 | if (c == guess) { [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:243:6 [INFO] [stderr] | [INFO] [stderr] 243 | if (count == 4) { [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:250:5 [INFO] [stderr] | [INFO] [stderr] 250 | if (comp_finished.len() > player_finished.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: denote infinite loops with `loop { ... }` [INFO] [stderr] --> src/main.rs:271:2 [INFO] [stderr] | [INFO] [stderr] 271 | while true { [INFO] [stderr] | ^^^^^^^^^^ help: use `loop` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(while_true)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:272:6 [INFO] [stderr] | [INFO] [stderr] 272 | if (deck.is_empty() && player_hand.is_empty()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::trim_right': superseded by `trim_end` [INFO] [stderr] --> src/main.rs:135:25 [INFO] [stderr] | [INFO] [stderr] 135 | let mut guess = buffer.trim_right().to_string(); [INFO] [stderr] | ^^^^^^^^^^ help: replace the use of the deprecated item: `trim_end` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(deprecated)]` on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::trim_right': superseded by `trim_end` [INFO] [stderr] --> src/main.rs:143:18 [INFO] [stderr] | [INFO] [stderr] 143 | guess = buffer.trim_right().to_string(); [INFO] [stderr] | ^^^^^^^^^^ help: replace the use of the deprecated item: `trim_end` [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::trim_right': superseded by `trim_end` [INFO] [stderr] --> src/main.rs:146:21 [INFO] [stderr] | [INFO] [stderr] 146 | &mut deck, guess.trim_right().to_string(), true); [INFO] [stderr] | ^^^^^^^^^^ help: replace the use of the deprecated item: `trim_end` [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::trim_right': superseded by `trim_end` [INFO] [stderr] --> src/main.rs:181:21 [INFO] [stderr] | [INFO] [stderr] 181 | &mut deck, guess.trim_right().to_string(), false); [INFO] [stderr] | ^^^^^^^^^^ help: replace the use of the deprecated item: `trim_end` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `suite` [INFO] [stderr] --> src/main.rs:50:7 [INFO] [stderr] | [INFO] [stderr] 50 | for suite in 0..NUM_SUITES { [INFO] [stderr] | ^^^^^ help: consider prefixing with an underscore: `_suite` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/main.rs:95:6 [INFO] [stderr] | [INFO] [stderr] 95 | for i in 0..NUM_HAND { [INFO] [stderr] | ^ help: consider prefixing with an underscore: `_i` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:35:12 [INFO] [stderr] | [INFO] [stderr] 35 | fn shuffle(mut cards: &mut Vec) { [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:133:6 [INFO] [stderr] | [INFO] [stderr] 133 | let mut buffer = &mut String::new(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:199:2 [INFO] [stderr] | [INFO] [stderr] 199 | mut other_hand: &mut Vec, mut deck: &mut Vec, guess: String, is_player: bool) -> bool { [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: constant `ranks` should have an upper case name [INFO] [stderr] --> src/main.rs:28:7 [INFO] [stderr] | [INFO] [stderr] 28 | const ranks: [&'static str; NUM_RANKS as usize] = ["ace", "one", "two", "three", "four", "five", "six", [INFO] [stderr] | ^^^^^ help: convert the identifier to upper case: `RANKS` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:134:2 [INFO] [stderr] | [INFO] [stderr] 134 | std::io::stdin().read_line(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_must_use)]` on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:142:6 [INFO] [stderr] | [INFO] [stderr] 142 | std::io::stdin().read_line(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.95s [INFO] running `"docker" "inspect" "759a49d9986c5df8aab8c278af94414bb707a027983b806d2a3f82671df349ed"` [INFO] running `"docker" "rm" "-f" "759a49d9986c5df8aab8c278af94414bb707a027983b806d2a3f82671df349ed"` [INFO] [stdout] 759a49d9986c5df8aab8c278af94414bb707a027983b806d2a3f82671df349ed [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/beta-1.38-1/worker-2/beta-2019-08-13:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/beta-1.38-1/sources/beta-2019-08-13/gh/EleanorWhite/goFish:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+beta-2019-08-13" "test" "--frozen"` [INFO] [stdout] 6562dc0f1e462bc3d2220643efd31c820070d9f3770cc4bb0f0fdd60fed59601 [INFO] running `"docker" "start" "-a" "6562dc0f1e462bc3d2220643efd31c820070d9f3770cc4bb0f0fdd60fed59601"` [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.09s [INFO] [stderr] Running /opt/crater/target/debug/deps/new_rust_project-adab01fb7fac4c78 [INFO] [stderr] Running /opt/crater/target/debug/deps/new_rust_project-ec04fc88c253e48c [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Doc-tests new_rust_project [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out [INFO] [stdout] [INFO] running `"docker" "inspect" "6562dc0f1e462bc3d2220643efd31c820070d9f3770cc4bb0f0fdd60fed59601"` [INFO] running `"docker" "rm" "-f" "6562dc0f1e462bc3d2220643efd31c820070d9f3770cc4bb0f0fdd60fed59601"` [INFO] [stdout] 6562dc0f1e462bc3d2220643efd31c820070d9f3770cc4bb0f0fdd60fed59601