[INFO] updating cached repository emmnm/dmgr [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/emmnm/dmgr [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/emmnm/dmgr" "work/ex/beta-1.38-1/sources/1.37.0/gh/emmnm/dmgr"` [INFO] [stderr] Cloning into 'work/ex/beta-1.38-1/sources/1.37.0/gh/emmnm/dmgr'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/emmnm/dmgr" "work/ex/beta-1.38-1/sources/beta-2019-08-13/gh/emmnm/dmgr"` [INFO] [stderr] Cloning into 'work/ex/beta-1.38-1/sources/beta-2019-08-13/gh/emmnm/dmgr'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 32da678f01eef30657fe3d0ca0ed81daac715153 [INFO] sha for GitHub repo emmnm/dmgr: 32da678f01eef30657fe3d0ca0ed81daac715153 [INFO] validating manifest of emmnm/dmgr on toolchain 1.37.0 [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+1.37.0" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of emmnm/dmgr on toolchain beta-2019-08-13 [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+beta-2019-08-13" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing emmnm/dmgr [INFO] finished frobbing emmnm/dmgr [INFO] frobbed toml for emmnm/dmgr written to work/ex/beta-1.38-1/sources/1.37.0/gh/emmnm/dmgr/Cargo.toml [INFO] started frobbing emmnm/dmgr [INFO] finished frobbing emmnm/dmgr [INFO] frobbed toml for emmnm/dmgr written to work/ex/beta-1.38-1/sources/beta-2019-08-13/gh/emmnm/dmgr/Cargo.toml [INFO] crate emmnm/dmgr already has a lockfile, it will not be regenerated [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+1.37.0" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] error: the lock file /mnt/big/crater/work/ex/beta-1.38-1/sources/1.37.0/gh/emmnm/dmgr/Cargo.lock needs to be updated but --locked was passed to prevent this [INFO] the lockfile is outdated, regenerating it [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+1.37.0" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+beta-2019-08-13" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+1.37.0" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+beta-2019-08-13" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] testing emmnm/dmgr against 1.37.0 for beta-1.38-1 [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/beta-1.38-1/worker-4/1.37.0:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/beta-1.38-1/sources/1.37.0/gh/emmnm/dmgr:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+1.37.0" "build" "--frozen"` [INFO] [stdout] 3f6a2b5dc9cefb10b9b2dc36194541a3ca110cb86a641b3d2ecb66ba01549931 [INFO] running `"docker" "start" "-a" "3f6a2b5dc9cefb10b9b2dc36194541a3ca110cb86a641b3d2ecb66ba01549931"` [INFO] [stderr] Compiling sdl2-sys v0.27.3 [INFO] [stderr] Compiling num v0.1.42 [INFO] [stderr] Compiling sdl2 v0.29.1 [INFO] [stderr] Compiling dmgr v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `sdl2::render::Texture` [INFO] [stderr] --> src/main.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use sdl2::render::Texture; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::rc::Rc` [INFO] [stderr] --> src/cart/mod.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::rc::Rc; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/rom_only.rs:18:19 [INFO] [stderr] | [INFO] [stderr] 18 | 0x0000...0x7FFF => self.bytes[idx], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = note: #[warn(ellipsis_inclusive_range_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc1.rs:39:19 [INFO] [stderr] | [INFO] [stderr] 39 | 0x0000...0x3FFF => { self.bytes[idx]}, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc1.rs:40:19 [INFO] [stderr] | [INFO] [stderr] 40 | 0x4000...0x7FFF => { self.bytes[(idx - 0x4000) + 0x4000 * self.rom_bank] }, // here! [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc1.rs:41:19 [INFO] [stderr] | [INFO] [stderr] 41 | 0xA000...0xBFFF => { self.ram[(idx-0xA000) + 0x2000 * self.ram_bank] }, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc1.rs:49:19 [INFO] [stderr] | [INFO] [stderr] 49 | 0x0000...0x1FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc1.rs:52:19 [INFO] [stderr] | [INFO] [stderr] 52 | 0x2000...0x3FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc1.rs:58:19 [INFO] [stderr] | [INFO] [stderr] 58 | 0xA000...0xBFFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc1.rs:61:19 [INFO] [stderr] | [INFO] [stderr] 61 | 0x4000...0x5FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc1.rs:70:19 [INFO] [stderr] | [INFO] [stderr] 70 | 0x6000...0x7FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc3.rs:38:19 [INFO] [stderr] | [INFO] [stderr] 38 | 0x0000...0x3FFF => {self.bytes[idx]}, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc3.rs:39:19 [INFO] [stderr] | [INFO] [stderr] 39 | 0x4000...0x7FFF => {self.bytes[(idx - 0x4000) + 0x4000 * self.rom_bank] }, // here! [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc3.rs:40:19 [INFO] [stderr] | [INFO] [stderr] 40 | 0xA000...0xBFFF => { self.ram[(idx-0xA000) + 0x2000 * self.ram_bank] }, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc3.rs:48:19 [INFO] [stderr] | [INFO] [stderr] 48 | 0x0000...0x1FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc3.rs:51:19 [INFO] [stderr] | [INFO] [stderr] 51 | 0x2000...0x3FFF => { //use 7 bits. [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc3.rs:61:19 [INFO] [stderr] | [INFO] [stderr] 61 | 0xA000...0xBFFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc3.rs:64:19 [INFO] [stderr] | [INFO] [stderr] 64 | 0x4000...0x5FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc3.rs:71:19 [INFO] [stderr] | [INFO] [stderr] 71 | 0x6000...0x7FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cart/mod.rs:28:14 [INFO] [stderr] | [INFO] [stderr] 28 | mbc: Box, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn ByteIO` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(bare_trait_objects)] on by default [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mod.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | 0x01...0x03 => "MBC1", [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mod.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | 0x05...0x06 => "MBC2", [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mod.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | 0x0F...0x13 => "MBC3", [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mod.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | 0x19...0x1E => "MBC5", [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mod.rs:59:21 [INFO] [stderr] | [INFO] [stderr] 59 | 0x01...0x03 => Box::new(Mbc1::new(bytes)), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mod.rs:61:21 [INFO] [stderr] | [INFO] [stderr] 61 | 0x0F...0x13 => Box::new(Mbc3::new(bytes)), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused import: `cpu::registers::FlagType::*` [INFO] [stderr] --> src/cpu/cb.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use cpu::registers::FlagType::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/cb.rs:8:34 [INFO] [stderr] | [INFO] [stderr] 8 | pub const CBOPS:[(usize,&'static Fn(&mut Context) -> usize); 256] = [ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Fn(&mut Context) -> usize` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/instructions.rs:8:32 [INFO] [stderr] | [INFO] [stderr] 8 | pub const OPS:[(usize,&'static Fn(&mut Context) -> usize); 256] = [ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Fn(&mut Context) -> usize` [INFO] [stderr] [INFO] [stderr] warning: unused import: `A` [INFO] [stderr] --> src/cpu/registers.rs:5:26 [INFO] [stderr] | [INFO] [stderr] 5 | use self::ByteRegister::{A,C,IMM}; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variant `MEM_FF00_C` should have an upper camel case name [INFO] [stderr] --> src/cpu/registers.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | MEM_FF00_C, [INFO] [stderr] | ^^^^^^^^^^ help: convert the identifier to upper camel case: `MemFf00C` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant `MEM_FF00_IMM` should have an upper camel case name [INFO] [stderr] --> src/cpu/registers.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | MEM_FF00_IMM, [INFO] [stderr] | ^^^^^^^^^^^^ help: convert the identifier to upper camel case: `MemFf00Imm` [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/cpu/z80.rs:249:17 [INFO] [stderr] | [INFO] [stderr] 249 | setf(ctx,Hf,((0x0F & av) - (0x0F & rv) - cv < 0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Gpu`, `Joypad`, `Lcd`, `Sound`, `Timer` [INFO] [stderr] --> src/cpu/mmu.rs:2:10 [INFO] [stderr] | [INFO] [stderr] 2 | use io::{Lcd,Gpu,Timer,Joypad,Sound}; [INFO] [stderr] | ^^^ ^^^ ^^^^^ ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:8:15 [INFO] [stderr] | [INFO] [stderr] 8 | 0x0000...0x7FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:15:15 [INFO] [stderr] | [INFO] [stderr] 15 | 0x8000...0x9FFF => ctx.gpu().read_byte(addr), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:16:15 [INFO] [stderr] | [INFO] [stderr] 16 | 0xA000...0xBFFF => ctx.cart().read_byte(addr), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:17:15 [INFO] [stderr] | [INFO] [stderr] 17 | 0xC000...0xCFFF => ctx.wb0()[idx-0xC000], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:18:15 [INFO] [stderr] | [INFO] [stderr] 18 | 0xD000...0xDFFF => ctx.wb1()[idx-0xD000], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:19:15 [INFO] [stderr] | [INFO] [stderr] 19 | 0xE000...0xEFFF => ctx.wb0()[idx-0xE000], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:20:15 [INFO] [stderr] | [INFO] [stderr] 20 | 0xF000...0xFDFF => ctx.wb1()[idx-0xF000], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:21:15 [INFO] [stderr] | [INFO] [stderr] 21 | 0xFE00...0xFE9F => ctx.gpu().read_byte(addr), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:23:15 [INFO] [stderr] | [INFO] [stderr] 23 | 0xFF01...0xFF02 => ctx.serial().read_byte(addr), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:24:15 [INFO] [stderr] | [INFO] [stderr] 24 | 0xFF04...0xFF07 => ctx.timer().read_byte(addr), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:26:15 [INFO] [stderr] | [INFO] [stderr] 26 | 0xFF10...0xFF3F => ctx.sound().read_byte(addr), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:27:15 [INFO] [stderr] | [INFO] [stderr] 27 | 0xFEA0...0xFEFF => {panic!("Unusable memory")}, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:29:15 [INFO] [stderr] | [INFO] [stderr] 29 | 0xFF40...0xFF4B => ctx.gpu().read_byte(addr), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:30:15 [INFO] [stderr] | [INFO] [stderr] 30 | 0xFF80...0xFFFE => ctx.hram()[idx-0xFF80], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:45:15 [INFO] [stderr] | [INFO] [stderr] 45 | 0x0000...0x7FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:52:15 [INFO] [stderr] | [INFO] [stderr] 52 | 0x8000...0x9FFF => ctx.gpu().write_byte(addr,val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:53:15 [INFO] [stderr] | [INFO] [stderr] 53 | 0xA000...0xBFFF => ctx.cart().write_byte(addr,val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:54:15 [INFO] [stderr] | [INFO] [stderr] 54 | 0xC000...0xCFFF => ctx.wb0()[idx-0xC000] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:55:15 [INFO] [stderr] | [INFO] [stderr] 55 | 0xD000...0xDFFF => ctx.wb1()[idx-0xD000] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:56:15 [INFO] [stderr] | [INFO] [stderr] 56 | 0xE000...0xEFFF => ctx.wb0()[idx-0xE000] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:57:15 [INFO] [stderr] | [INFO] [stderr] 57 | 0xF000...0xFDFF => ctx.wb1()[idx-0xF000] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:58:15 [INFO] [stderr] | [INFO] [stderr] 58 | 0xFE00...0xFE9F => ctx.gpu().write_byte(addr,val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:59:15 [INFO] [stderr] | [INFO] [stderr] 59 | 0xFEA0...0xFEFF => {}, //unusable [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:61:15 [INFO] [stderr] | [INFO] [stderr] 61 | 0xFF01...0xFF02 => ctx.serial().write_byte(addr,val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:62:15 [INFO] [stderr] | [INFO] [stderr] 62 | 0xFF04...0xFF07 => ctx.timer().write_byte(addr,val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:64:15 [INFO] [stderr] | [INFO] [stderr] 64 | 0xFF10...0xFF3F => ctx.sound().write_byte(addr,val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:71:15 [INFO] [stderr] | [INFO] [stderr] 71 | 0xFF40...0xFF4B => ctx.gpu().write_byte(addr,val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:73:15 [INFO] [stderr] | [INFO] [stderr] 73 | 0xFF4C...0xFF7F => {}, //empty io [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:74:15 [INFO] [stderr] | [INFO] [stderr] 74 | 0xFF80...0xFFFE => ctx.hram()[idx-0xFF80] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/io/joypad.rs:75:20 [INFO] [stderr] | [INFO] [stderr] 75 | if (self.selection & 0x10 > 0) { //direction keys [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/io/joypad.rs:77:27 [INFO] [stderr] | [INFO] [stderr] 77 | } else if ( self.selection & 0x20 > 0) { //button keys. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/io/gpu.rs:73:19 [INFO] [stderr] | [INFO] [stderr] 73 | 0x8000...0x9FFF => self.vram[idx-0x8000], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/io/gpu.rs:74:19 [INFO] [stderr] | [INFO] [stderr] 74 | 0xFE00...0xFE9F => self.oam[idx-0xFE00], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/io/gpu.rs:99:19 [INFO] [stderr] | [INFO] [stderr] 99 | 0x8000...0x9FFF => self.vram[idx-0x8000] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/io/gpu.rs:100:19 [INFO] [stderr] | [INFO] [stderr] 100 | 0xFE00...0xFE9F => self.oam[idx-0xFE00] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused imports: `BLACK`, `DARK_GRAY`, `LIGHT_GRAY` [INFO] [stderr] --> src/io/lcd.rs:4:23 [INFO] [stderr] | [INFO] [stderr] 4 | use constants::{WHITE,LIGHT_GRAY,DARK_GRAY,BLACK,COLORS}; [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/io/lcd.rs:170:43 [INFO] [stderr] | [INFO] [stderr] 170 | pixel_mem_addr += (tile_pixel_y << 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/io/lcd.rs:208:43 [INFO] [stderr] | [INFO] [stderr] 208 | pixel_mem_addr += (tile_pixel_y << 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused import: `getb` [INFO] [stderr] --> src/main.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | use cpu::registers::{getb,getw}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/cart/rom_only.rs:23:30 [INFO] [stderr] | [INFO] [stderr] 23 | fn write_byte(&mut self, addr:u16, val:u8) { [INFO] [stderr] | ^^^^ help: consider prefixing with an underscore: `_addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/cart/rom_only.rs:23:40 [INFO] [stderr] | [INFO] [stderr] 23 | fn write_byte(&mut self, addr:u16, val:u8) { [INFO] [stderr] | ^^^ help: consider prefixing with an underscore: `_val` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/cpu/instructions.rs:239:11 [INFO] [stderr] | [INFO] [stderr] 239 | (1, &|ctx| {panic!("CB Prefix!")}), // XB [INFO] [stderr] | ^^^ help: consider prefixing with an underscore: `_ctx` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/cpu/z80.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn fail(ctx: &mut Context) -> usize { [INFO] [stderr] | ^^^ help: consider prefixing with an underscore: `_ctx` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/cpu/z80.rs:76:16 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn invalid(ctx: &mut Context) -> usize { [INFO] [stderr] | ^^^ help: consider prefixing with an underscore: `_ctx` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/cpu/z80.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn stop(ctx: &mut Context) -> usize { [INFO] [stderr] | ^^^ help: consider prefixing with an underscore: `_ctx` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/cpu/z80.rs:89:12 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn nop(ctx: &mut Context) -> usize { [INFO] [stderr] | ^^^ help: consider prefixing with an underscore: `_ctx` [INFO] [stderr] [INFO] [stderr] warning: variable `newflags` is assigned to, but never used [INFO] [stderr] --> src/cpu/z80.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | let mut newflags = !(0x80 | 0x20); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_newflags` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `newflags` is never read [INFO] [stderr] --> src/cpu/z80.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | newflags |= 0x10; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] = help: maybe it is overwritten before being read? [INFO] [stderr] [INFO] [stderr] warning: unused variable: `num_cycles` [INFO] [stderr] --> src/io/joypad.rs:31:57 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn step(ctx:&mut Context, pump: &mut EventPump, num_cycles: usize) { [INFO] [stderr] | ^^^^^^^^^^ help: consider prefixing with an underscore: `_num_cycles` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/io/lcd.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | fn read_byte(&self, addr:u16) -> u8 { [INFO] [stderr] | ^^^^ help: consider prefixing with an underscore: `_addr` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/io/lcd.rs:58:40 [INFO] [stderr] | [INFO] [stderr] 58 | fn write_byte(&mut self, addr:u16, val:u8) { [INFO] [stderr] | ^^^ help: consider prefixing with an underscore: `_val` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t` [INFO] [stderr] --> src/io/lcd.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | for t in 0..0x180 { //more than 255 of them. [INFO] [stderr] | ^ help: consider prefixing with an underscore: `_t` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/io/lcd.rs:120:18 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn flush(ctx:&mut Context, renderer:&mut Renderer, texture:&mut Texture) { [INFO] [stderr] | ^^^ help: consider prefixing with an underscore: `_ctx` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `renderer` [INFO] [stderr] --> src/io/lcd.rs:127:48 [INFO] [stderr] | [INFO] [stderr] 127 | pub fn render_to_texture(ctx:&mut Context, renderer:&mut Renderer, texture:&mut Texture) { [INFO] [stderr] | ^^^^^^^^ help: consider prefixing with an underscore: `_renderer` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/io/sound.rs:15:25 [INFO] [stderr] | [INFO] [stderr] 15 | fn read_byte(&self, addr:u16) -> u8 { [INFO] [stderr] | ^^^^ help: consider prefixing with an underscore: `_addr` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/io/sound.rs:18:30 [INFO] [stderr] | [INFO] [stderr] 18 | fn write_byte(&mut self, addr:u16, val:u8) { [INFO] [stderr] | ^^^^ help: consider prefixing with an underscore: `_addr` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/io/sound.rs:18:40 [INFO] [stderr] | [INFO] [stderr] 18 | fn write_byte(&mut self, addr:u16, val:u8) { [INFO] [stderr] | ^^^ help: consider prefixing with an underscore: `_val` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/io/sound.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn step(ctx:&mut Context, cycles: usize) { [INFO] [stderr] | ^^^ help: consider prefixing with an underscore: `_ctx` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cycles` [INFO] [stderr] --> src/io/sound.rs:25:35 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn step(ctx:&mut Context, cycles: usize) { [INFO] [stderr] | ^^^^^^ help: consider prefixing with an underscore: `_cycles` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu/z80.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | let mut pc = getw(ctx,PC); [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/io/gpu.rs:121:30 [INFO] [stderr] | [INFO] [stderr] 121 | let (mut req_vblank, mut req_lcdstat) = (false,false); [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/io/lcd.rs:161:29 [INFO] [stderr] | [INFO] [stderr] 161 | let mut tile = ctx.gpu().read_byte(tile_mem_addr as u16) as usize; [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/io/lcd.rs:203:29 [INFO] [stderr] | [INFO] [stderr] 203 | let mut tile = ctx.gpu().read_byte(tile_mem_addr as u16) as usize; [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `CYCLES_PER_SECOND` [INFO] [stderr] --> src/constants.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub const CYCLES_PER_SECOND: usize = 4194304 >> 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `fail` [INFO] [stderr] --> src/cpu/z80.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn fail(ctx: &mut Context) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_scanline` [INFO] [stderr] --> src/io/gpu.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn get_scanline(&self) -> u8 { self.scanline } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `tiles` [INFO] [stderr] --> src/io/lcd.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | tiles: Vec>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `background_palette` [INFO] [stderr] --> src/io/lcd.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | background_palette: [usize;4], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `foreground_palette` [INFO] [stderr] --> src/io/lcd.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | foreground_palette: [[usize;4];2], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `step` [INFO] [stderr] --> src/io/lcd.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn step(ctx:&mut Context, renderer:&mut Renderer, texture:&mut Texture) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `step` [INFO] [stderr] --> src/io/sound.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn step(ctx:&mut Context, cycles: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/constants.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | file.read_to_end(&mut result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: comparison is useless due to type limits [INFO] [stderr] --> src/io/lcd.rs:257:45 [INFO] [stderr] | [INFO] [stderr] 257 | assert!(col >= 0); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_comparisons)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.69s [INFO] running `"docker" "inspect" "3f6a2b5dc9cefb10b9b2dc36194541a3ca110cb86a641b3d2ecb66ba01549931"` [INFO] running `"docker" "rm" "-f" "3f6a2b5dc9cefb10b9b2dc36194541a3ca110cb86a641b3d2ecb66ba01549931"` [INFO] [stdout] 3f6a2b5dc9cefb10b9b2dc36194541a3ca110cb86a641b3d2ecb66ba01549931 [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/beta-1.38-1/worker-4/1.37.0:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/beta-1.38-1/sources/1.37.0/gh/emmnm/dmgr:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+1.37.0" "test" "--frozen" "--no-run"` [INFO] [stdout] 5439998bcb931a6af1b2e8d743a3cd01c5c4be2ebdbcdaf70b71f7294525e0f1 [INFO] running `"docker" "start" "-a" "5439998bcb931a6af1b2e8d743a3cd01c5c4be2ebdbcdaf70b71f7294525e0f1"` [INFO] [stderr] Compiling dmgr v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `sdl2::render::Texture` [INFO] [stderr] --> src/main.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use sdl2::render::Texture; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::rc::Rc` [INFO] [stderr] --> src/cart/mod.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::rc::Rc; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/rom_only.rs:18:19 [INFO] [stderr] | [INFO] [stderr] 18 | 0x0000...0x7FFF => self.bytes[idx], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = note: #[warn(ellipsis_inclusive_range_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc1.rs:39:19 [INFO] [stderr] | [INFO] [stderr] 39 | 0x0000...0x3FFF => { self.bytes[idx]}, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc1.rs:40:19 [INFO] [stderr] | [INFO] [stderr] 40 | 0x4000...0x7FFF => { self.bytes[(idx - 0x4000) + 0x4000 * self.rom_bank] }, // here! [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc1.rs:41:19 [INFO] [stderr] | [INFO] [stderr] 41 | 0xA000...0xBFFF => { self.ram[(idx-0xA000) + 0x2000 * self.ram_bank] }, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc1.rs:49:19 [INFO] [stderr] | [INFO] [stderr] 49 | 0x0000...0x1FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc1.rs:52:19 [INFO] [stderr] | [INFO] [stderr] 52 | 0x2000...0x3FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc1.rs:58:19 [INFO] [stderr] | [INFO] [stderr] 58 | 0xA000...0xBFFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc1.rs:61:19 [INFO] [stderr] | [INFO] [stderr] 61 | 0x4000...0x5FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc1.rs:70:19 [INFO] [stderr] | [INFO] [stderr] 70 | 0x6000...0x7FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc3.rs:38:19 [INFO] [stderr] | [INFO] [stderr] 38 | 0x0000...0x3FFF => {self.bytes[idx]}, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc3.rs:39:19 [INFO] [stderr] | [INFO] [stderr] 39 | 0x4000...0x7FFF => {self.bytes[(idx - 0x4000) + 0x4000 * self.rom_bank] }, // here! [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc3.rs:40:19 [INFO] [stderr] | [INFO] [stderr] 40 | 0xA000...0xBFFF => { self.ram[(idx-0xA000) + 0x2000 * self.ram_bank] }, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc3.rs:48:19 [INFO] [stderr] | [INFO] [stderr] 48 | 0x0000...0x1FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc3.rs:51:19 [INFO] [stderr] | [INFO] [stderr] 51 | 0x2000...0x3FFF => { //use 7 bits. [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc3.rs:61:19 [INFO] [stderr] | [INFO] [stderr] 61 | 0xA000...0xBFFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc3.rs:64:19 [INFO] [stderr] | [INFO] [stderr] 64 | 0x4000...0x5FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mbc3.rs:71:19 [INFO] [stderr] | [INFO] [stderr] 71 | 0x6000...0x7FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cart/mod.rs:28:14 [INFO] [stderr] | [INFO] [stderr] 28 | mbc: Box, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn ByteIO` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(bare_trait_objects)] on by default [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mod.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | 0x01...0x03 => "MBC1", [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mod.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | 0x05...0x06 => "MBC2", [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mod.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | 0x0F...0x13 => "MBC3", [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mod.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | 0x19...0x1E => "MBC5", [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mod.rs:59:21 [INFO] [stderr] | [INFO] [stderr] 59 | 0x01...0x03 => Box::new(Mbc1::new(bytes)), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cart/mod.rs:61:21 [INFO] [stderr] | [INFO] [stderr] 61 | 0x0F...0x13 => Box::new(Mbc3::new(bytes)), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused import: `cpu::registers::FlagType::*` [INFO] [stderr] --> src/cpu/cb.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use cpu::registers::FlagType::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/cb.rs:8:34 [INFO] [stderr] | [INFO] [stderr] 8 | pub const CBOPS:[(usize,&'static Fn(&mut Context) -> usize); 256] = [ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Fn(&mut Context) -> usize` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/instructions.rs:8:32 [INFO] [stderr] | [INFO] [stderr] 8 | pub const OPS:[(usize,&'static Fn(&mut Context) -> usize); 256] = [ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Fn(&mut Context) -> usize` [INFO] [stderr] [INFO] [stderr] warning: unused import: `A` [INFO] [stderr] --> src/cpu/registers.rs:5:26 [INFO] [stderr] | [INFO] [stderr] 5 | use self::ByteRegister::{A,C,IMM}; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variant `MEM_FF00_C` should have an upper camel case name [INFO] [stderr] --> src/cpu/registers.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | MEM_FF00_C, [INFO] [stderr] | ^^^^^^^^^^ help: convert the identifier to upper camel case: `MemFf00C` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant `MEM_FF00_IMM` should have an upper camel case name [INFO] [stderr] --> src/cpu/registers.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | MEM_FF00_IMM, [INFO] [stderr] | ^^^^^^^^^^^^ help: convert the identifier to upper camel case: `MemFf00Imm` [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/cpu/z80.rs:249:17 [INFO] [stderr] | [INFO] [stderr] 249 | setf(ctx,Hf,((0x0F & av) - (0x0F & rv) - cv < 0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Gpu`, `Joypad`, `Lcd`, `Sound`, `Timer` [INFO] [stderr] --> src/cpu/mmu.rs:2:10 [INFO] [stderr] | [INFO] [stderr] 2 | use io::{Lcd,Gpu,Timer,Joypad,Sound}; [INFO] [stderr] | ^^^ ^^^ ^^^^^ ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:8:15 [INFO] [stderr] | [INFO] [stderr] 8 | 0x0000...0x7FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:15:15 [INFO] [stderr] | [INFO] [stderr] 15 | 0x8000...0x9FFF => ctx.gpu().read_byte(addr), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:16:15 [INFO] [stderr] | [INFO] [stderr] 16 | 0xA000...0xBFFF => ctx.cart().read_byte(addr), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:17:15 [INFO] [stderr] | [INFO] [stderr] 17 | 0xC000...0xCFFF => ctx.wb0()[idx-0xC000], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:18:15 [INFO] [stderr] | [INFO] [stderr] 18 | 0xD000...0xDFFF => ctx.wb1()[idx-0xD000], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:19:15 [INFO] [stderr] | [INFO] [stderr] 19 | 0xE000...0xEFFF => ctx.wb0()[idx-0xE000], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:20:15 [INFO] [stderr] | [INFO] [stderr] 20 | 0xF000...0xFDFF => ctx.wb1()[idx-0xF000], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:21:15 [INFO] [stderr] | [INFO] [stderr] 21 | 0xFE00...0xFE9F => ctx.gpu().read_byte(addr), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:23:15 [INFO] [stderr] | [INFO] [stderr] 23 | 0xFF01...0xFF02 => ctx.serial().read_byte(addr), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:24:15 [INFO] [stderr] | [INFO] [stderr] 24 | 0xFF04...0xFF07 => ctx.timer().read_byte(addr), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:26:15 [INFO] [stderr] | [INFO] [stderr] 26 | 0xFF10...0xFF3F => ctx.sound().read_byte(addr), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:27:15 [INFO] [stderr] | [INFO] [stderr] 27 | 0xFEA0...0xFEFF => {panic!("Unusable memory")}, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:29:15 [INFO] [stderr] | [INFO] [stderr] 29 | 0xFF40...0xFF4B => ctx.gpu().read_byte(addr), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:30:15 [INFO] [stderr] | [INFO] [stderr] 30 | 0xFF80...0xFFFE => ctx.hram()[idx-0xFF80], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:45:15 [INFO] [stderr] | [INFO] [stderr] 45 | 0x0000...0x7FFF => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:52:15 [INFO] [stderr] | [INFO] [stderr] 52 | 0x8000...0x9FFF => ctx.gpu().write_byte(addr,val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:53:15 [INFO] [stderr] | [INFO] [stderr] 53 | 0xA000...0xBFFF => ctx.cart().write_byte(addr,val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:54:15 [INFO] [stderr] | [INFO] [stderr] 54 | 0xC000...0xCFFF => ctx.wb0()[idx-0xC000] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:55:15 [INFO] [stderr] | [INFO] [stderr] 55 | 0xD000...0xDFFF => ctx.wb1()[idx-0xD000] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:56:15 [INFO] [stderr] | [INFO] [stderr] 56 | 0xE000...0xEFFF => ctx.wb0()[idx-0xE000] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:57:15 [INFO] [stderr] | [INFO] [stderr] 57 | 0xF000...0xFDFF => ctx.wb1()[idx-0xF000] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:58:15 [INFO] [stderr] | [INFO] [stderr] 58 | 0xFE00...0xFE9F => ctx.gpu().write_byte(addr,val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:59:15 [INFO] [stderr] | [INFO] [stderr] 59 | 0xFEA0...0xFEFF => {}, //unusable [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:61:15 [INFO] [stderr] | [INFO] [stderr] 61 | 0xFF01...0xFF02 => ctx.serial().write_byte(addr,val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:62:15 [INFO] [stderr] | [INFO] [stderr] 62 | 0xFF04...0xFF07 => ctx.timer().write_byte(addr,val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:64:15 [INFO] [stderr] | [INFO] [stderr] 64 | 0xFF10...0xFF3F => ctx.sound().write_byte(addr,val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:71:15 [INFO] [stderr] | [INFO] [stderr] 71 | 0xFF40...0xFF4B => ctx.gpu().write_byte(addr,val), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:73:15 [INFO] [stderr] | [INFO] [stderr] 73 | 0xFF4C...0xFF7F => {}, //empty io [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mmu.rs:74:15 [INFO] [stderr] | [INFO] [stderr] 74 | 0xFF80...0xFFFE => ctx.hram()[idx-0xFF80] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/io/joypad.rs:75:20 [INFO] [stderr] | [INFO] [stderr] 75 | if (self.selection & 0x10 > 0) { //direction keys [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/io/joypad.rs:77:27 [INFO] [stderr] | [INFO] [stderr] 77 | } else if ( self.selection & 0x20 > 0) { //button keys. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/io/gpu.rs:73:19 [INFO] [stderr] | [INFO] [stderr] 73 | 0x8000...0x9FFF => self.vram[idx-0x8000], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/io/gpu.rs:74:19 [INFO] [stderr] | [INFO] [stderr] 74 | 0xFE00...0xFE9F => self.oam[idx-0xFE00], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/io/gpu.rs:99:19 [INFO] [stderr] | [INFO] [stderr] 99 | 0x8000...0x9FFF => self.vram[idx-0x8000] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/io/gpu.rs:100:19 [INFO] [stderr] | [INFO] [stderr] 100 | 0xFE00...0xFE9F => self.oam[idx-0xFE00] = val, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused imports: `BLACK`, `DARK_GRAY`, `LIGHT_GRAY` [INFO] [stderr] --> src/io/lcd.rs:4:23 [INFO] [stderr] | [INFO] [stderr] 4 | use constants::{WHITE,LIGHT_GRAY,DARK_GRAY,BLACK,COLORS}; [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/io/lcd.rs:170:43 [INFO] [stderr] | [INFO] [stderr] 170 | pixel_mem_addr += (tile_pixel_y << 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/io/lcd.rs:208:43 [INFO] [stderr] | [INFO] [stderr] 208 | pixel_mem_addr += (tile_pixel_y << 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused import: `getb` [INFO] [stderr] --> src/main.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | use cpu::registers::{getb,getw}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/cart/rom_only.rs:23:30 [INFO] [stderr] | [INFO] [stderr] 23 | fn write_byte(&mut self, addr:u16, val:u8) { [INFO] [stderr] | ^^^^ help: consider prefixing with an underscore: `_addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/cart/rom_only.rs:23:40 [INFO] [stderr] | [INFO] [stderr] 23 | fn write_byte(&mut self, addr:u16, val:u8) { [INFO] [stderr] | ^^^ help: consider prefixing with an underscore: `_val` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/cpu/instructions.rs:239:11 [INFO] [stderr] | [INFO] [stderr] 239 | (1, &|ctx| {panic!("CB Prefix!")}), // XB [INFO] [stderr] | ^^^ help: consider prefixing with an underscore: `_ctx` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/cpu/z80.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn fail(ctx: &mut Context) -> usize { [INFO] [stderr] | ^^^ help: consider prefixing with an underscore: `_ctx` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/cpu/z80.rs:76:16 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn invalid(ctx: &mut Context) -> usize { [INFO] [stderr] | ^^^ help: consider prefixing with an underscore: `_ctx` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/cpu/z80.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn stop(ctx: &mut Context) -> usize { [INFO] [stderr] | ^^^ help: consider prefixing with an underscore: `_ctx` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/cpu/z80.rs:89:12 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn nop(ctx: &mut Context) -> usize { [INFO] [stderr] | ^^^ help: consider prefixing with an underscore: `_ctx` [INFO] [stderr] [INFO] [stderr] warning: variable `newflags` is assigned to, but never used [INFO] [stderr] --> src/cpu/z80.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | let mut newflags = !(0x80 | 0x20); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_newflags` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `newflags` is never read [INFO] [stderr] --> src/cpu/z80.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | newflags |= 0x10; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] = help: maybe it is overwritten before being read? [INFO] [stderr] [INFO] [stderr] warning: unused variable: `num_cycles` [INFO] [stderr] --> src/io/joypad.rs:31:57 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn step(ctx:&mut Context, pump: &mut EventPump, num_cycles: usize) { [INFO] [stderr] | ^^^^^^^^^^ help: consider prefixing with an underscore: `_num_cycles` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/io/lcd.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | fn read_byte(&self, addr:u16) -> u8 { [INFO] [stderr] | ^^^^ help: consider prefixing with an underscore: `_addr` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/io/lcd.rs:58:40 [INFO] [stderr] | [INFO] [stderr] 58 | fn write_byte(&mut self, addr:u16, val:u8) { [INFO] [stderr] | ^^^ help: consider prefixing with an underscore: `_val` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t` [INFO] [stderr] --> src/io/lcd.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | for t in 0..0x180 { //more than 255 of them. [INFO] [stderr] | ^ help: consider prefixing with an underscore: `_t` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/io/lcd.rs:120:18 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn flush(ctx:&mut Context, renderer:&mut Renderer, texture:&mut Texture) { [INFO] [stderr] | ^^^ help: consider prefixing with an underscore: `_ctx` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `renderer` [INFO] [stderr] --> src/io/lcd.rs:127:48 [INFO] [stderr] | [INFO] [stderr] 127 | pub fn render_to_texture(ctx:&mut Context, renderer:&mut Renderer, texture:&mut Texture) { [INFO] [stderr] | ^^^^^^^^ help: consider prefixing with an underscore: `_renderer` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/io/sound.rs:15:25 [INFO] [stderr] | [INFO] [stderr] 15 | fn read_byte(&self, addr:u16) -> u8 { [INFO] [stderr] | ^^^^ help: consider prefixing with an underscore: `_addr` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/io/sound.rs:18:30 [INFO] [stderr] | [INFO] [stderr] 18 | fn write_byte(&mut self, addr:u16, val:u8) { [INFO] [stderr] | ^^^^ help: consider prefixing with an underscore: `_addr` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/io/sound.rs:18:40 [INFO] [stderr] | [INFO] [stderr] 18 | fn write_byte(&mut self, addr:u16, val:u8) { [INFO] [stderr] | ^^^ help: consider prefixing with an underscore: `_val` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/io/sound.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn step(ctx:&mut Context, cycles: usize) { [INFO] [stderr] | ^^^ help: consider prefixing with an underscore: `_ctx` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cycles` [INFO] [stderr] --> src/io/sound.rs:25:35 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn step(ctx:&mut Context, cycles: usize) { [INFO] [stderr] | ^^^^^^ help: consider prefixing with an underscore: `_cycles` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu/z80.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | let mut pc = getw(ctx,PC); [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/io/gpu.rs:121:30 [INFO] [stderr] | [INFO] [stderr] 121 | let (mut req_vblank, mut req_lcdstat) = (false,false); [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/io/lcd.rs:161:29 [INFO] [stderr] | [INFO] [stderr] 161 | let mut tile = ctx.gpu().read_byte(tile_mem_addr as u16) as usize; [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/io/lcd.rs:203:29 [INFO] [stderr] | [INFO] [stderr] 203 | let mut tile = ctx.gpu().read_byte(tile_mem_addr as u16) as usize; [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `CYCLES_PER_SECOND` [INFO] [stderr] --> src/constants.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub const CYCLES_PER_SECOND: usize = 4194304 >> 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `fail` [INFO] [stderr] --> src/cpu/z80.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn fail(ctx: &mut Context) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_scanline` [INFO] [stderr] --> src/io/gpu.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn get_scanline(&self) -> u8 { self.scanline } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `tiles` [INFO] [stderr] --> src/io/lcd.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | tiles: Vec>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `background_palette` [INFO] [stderr] --> src/io/lcd.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | background_palette: [usize;4], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `foreground_palette` [INFO] [stderr] --> src/io/lcd.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | foreground_palette: [[usize;4];2], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `step` [INFO] [stderr] --> src/io/lcd.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn step(ctx:&mut Context, renderer:&mut Renderer, texture:&mut Texture) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `step` [INFO] [stderr] --> src/io/sound.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn step(ctx:&mut Context, cycles: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/constants.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | file.read_to_end(&mut result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: comparison is useless due to type limits [INFO] [stderr] --> src/io/lcd.rs:257:45 [INFO] [stderr] | [INFO] [stderr] 257 | assert!(col >= 0); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_comparisons)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.08s [INFO] running `"docker" "inspect" "5439998bcb931a6af1b2e8d743a3cd01c5c4be2ebdbcdaf70b71f7294525e0f1"` [INFO] running `"docker" "rm" "-f" "5439998bcb931a6af1b2e8d743a3cd01c5c4be2ebdbcdaf70b71f7294525e0f1"` [INFO] [stdout] 5439998bcb931a6af1b2e8d743a3cd01c5c4be2ebdbcdaf70b71f7294525e0f1 [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/beta-1.38-1/worker-4/1.37.0:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/beta-1.38-1/sources/1.37.0/gh/emmnm/dmgr:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+1.37.0" "test" "--frozen"` [INFO] [stdout] 686c460bce8be6eb0f20cc3b3d986ecde6993a4953ad2d34de36cd4fde449673 [INFO] running `"docker" "start" "-a" "686c460bce8be6eb0f20cc3b3d986ecde6993a4953ad2d34de36cd4fde449673"` [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.03s [INFO] [stderr] Running /opt/crater/target/debug/deps/dmgr-54e745b002a81bae [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out [INFO] [stdout] [INFO] running `"docker" "inspect" "686c460bce8be6eb0f20cc3b3d986ecde6993a4953ad2d34de36cd4fde449673"` [INFO] running `"docker" "rm" "-f" "686c460bce8be6eb0f20cc3b3d986ecde6993a4953ad2d34de36cd4fde449673"` [INFO] [stdout] 686c460bce8be6eb0f20cc3b3d986ecde6993a4953ad2d34de36cd4fde449673