[INFO] updating cached repository saterus/gilded-rose-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/saterus/gilded-rose-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/saterus/gilded-rose-rust" "work/ex/beta-1.37-6/sources/1.36.0/gh/saterus/gilded-rose-rust"` [INFO] [stderr] Cloning into 'work/ex/beta-1.37-6/sources/1.36.0/gh/saterus/gilded-rose-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/saterus/gilded-rose-rust" "work/ex/beta-1.37-6/sources/beta-2019-07-23/gh/saterus/gilded-rose-rust"` [INFO] [stderr] Cloning into 'work/ex/beta-1.37-6/sources/beta-2019-07-23/gh/saterus/gilded-rose-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8a8ec0b54b71eb6cfc764dda770b60843d95b73e [INFO] sha for GitHub repo saterus/gilded-rose-rust: 8a8ec0b54b71eb6cfc764dda770b60843d95b73e [INFO] validating manifest of saterus/gilded-rose-rust on toolchain 1.36.0 [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+1.36.0" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of saterus/gilded-rose-rust on toolchain beta-2019-07-23 [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+beta-2019-07-23" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing saterus/gilded-rose-rust [INFO] finished frobbing saterus/gilded-rose-rust [INFO] frobbed toml for saterus/gilded-rose-rust written to work/ex/beta-1.37-6/sources/1.36.0/gh/saterus/gilded-rose-rust/Cargo.toml [INFO] started frobbing saterus/gilded-rose-rust [INFO] finished frobbing saterus/gilded-rose-rust [INFO] frobbed toml for saterus/gilded-rose-rust written to work/ex/beta-1.37-6/sources/beta-2019-07-23/gh/saterus/gilded-rose-rust/Cargo.toml [INFO] crate saterus/gilded-rose-rust already has a lockfile, it will not be regenerated [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+1.36.0" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+beta-2019-07-23" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] testing saterus/gilded-rose-rust against 1.36.0 for beta-1.37-6 [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/beta-1.37-6/worker-6/1.36.0:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/beta-1.37-6/sources/1.36.0/gh/saterus/gilded-rose-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+1.36.0" "build" "--frozen"` [INFO] [stdout] 47ef947af3a642ef7c9055506524c472dd8750600f32dec1692e4b788e91c706 [INFO] running `"docker" "start" "-a" "47ef947af3a642ef7c9055506524c472dd8750600f32dec1692e4b788e91c706"` [INFO] [stderr] Compiling gilded_rose v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:32:12 [INFO] [stderr] | [INFO] [stderr] 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:34:16 [INFO] [stderr] | [INFO] [stderr] 34 | if (items[i].quality > 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:36:20 [INFO] [stderr] | [INFO] [stderr] 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:44:16 [INFO] [stderr] | [INFO] [stderr] 44 | if (items[i].quality < 50) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:48:20 [INFO] [stderr] | [INFO] [stderr] 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:50:24 [INFO] [stderr] | [INFO] [stderr] 50 | if (items[i].sell_in < 11) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:52:28 [INFO] [stderr] | [INFO] [stderr] 52 | if (items[i].quality < 50) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:58:24 [INFO] [stderr] | [INFO] [stderr] 58 | if (items[i].sell_in < 6) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:60:28 [INFO] [stderr] | [INFO] [stderr] 60 | if (items[i].quality < 50) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:69:12 [INFO] [stderr] | [INFO] [stderr] 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:74:12 [INFO] [stderr] | [INFO] [stderr] 74 | if (items[i].sell_in < 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:76:16 [INFO] [stderr] | [INFO] [stderr] 76 | if (items[i].name != "Aged Brie") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:78:20 [INFO] [stderr] | [INFO] [stderr] 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:80:24 [INFO] [stderr] | [INFO] [stderr] 80 | if (items[i].quality > 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:82:28 [INFO] [stderr] | [INFO] [stderr] 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:95:20 [INFO] [stderr] | [INFO] [stderr] 95 | if (items[i].quality < 50) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: function `UpdateQuality` should have a snake case name [INFO] [stderr] --> src/main.rs:28:4 [INFO] [stderr] | [INFO] [stderr] 28 | fn UpdateQuality(items: &mut [Item]) [INFO] [stderr] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `update_quality` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.24s [INFO] running `"docker" "inspect" "47ef947af3a642ef7c9055506524c472dd8750600f32dec1692e4b788e91c706"` [INFO] running `"docker" "rm" "-f" "47ef947af3a642ef7c9055506524c472dd8750600f32dec1692e4b788e91c706"` [INFO] [stdout] 47ef947af3a642ef7c9055506524c472dd8750600f32dec1692e4b788e91c706 [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/beta-1.37-6/worker-6/1.36.0:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/beta-1.37-6/sources/1.36.0/gh/saterus/gilded-rose-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+1.36.0" "test" "--frozen" "--no-run"` [INFO] [stdout] 0ab67c46faf788b527972ed62c0603dd00724859d5c33d6ebf4507920637e5ed [INFO] running `"docker" "start" "-a" "0ab67c46faf788b527972ed62c0603dd00724859d5c33d6ebf4507920637e5ed"` [INFO] [stderr] Compiling gilded_rose v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:32:12 [INFO] [stderr] | [INFO] [stderr] 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:34:16 [INFO] [stderr] | [INFO] [stderr] 34 | if (items[i].quality > 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:36:20 [INFO] [stderr] | [INFO] [stderr] 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:44:16 [INFO] [stderr] | [INFO] [stderr] 44 | if (items[i].quality < 50) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:48:20 [INFO] [stderr] | [INFO] [stderr] 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:50:24 [INFO] [stderr] | [INFO] [stderr] 50 | if (items[i].sell_in < 11) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:52:28 [INFO] [stderr] | [INFO] [stderr] 52 | if (items[i].quality < 50) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:58:24 [INFO] [stderr] | [INFO] [stderr] 58 | if (items[i].sell_in < 6) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:60:28 [INFO] [stderr] | [INFO] [stderr] 60 | if (items[i].quality < 50) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:69:12 [INFO] [stderr] | [INFO] [stderr] 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:74:12 [INFO] [stderr] | [INFO] [stderr] 74 | if (items[i].sell_in < 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:76:16 [INFO] [stderr] | [INFO] [stderr] 76 | if (items[i].name != "Aged Brie") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:78:20 [INFO] [stderr] | [INFO] [stderr] 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:80:24 [INFO] [stderr] | [INFO] [stderr] 80 | if (items[i].quality > 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:82:28 [INFO] [stderr] | [INFO] [stderr] 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:95:20 [INFO] [stderr] | [INFO] [stderr] 95 | if (items[i].quality < 50) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: function `UpdateQuality` should have a snake case name [INFO] [stderr] --> src/main.rs:28:4 [INFO] [stderr] | [INFO] [stderr] 28 | fn UpdateQuality(items: &mut [Item]) [INFO] [stderr] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `update_quality` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.47s [INFO] running `"docker" "inspect" "0ab67c46faf788b527972ed62c0603dd00724859d5c33d6ebf4507920637e5ed"` [INFO] running `"docker" "rm" "-f" "0ab67c46faf788b527972ed62c0603dd00724859d5c33d6ebf4507920637e5ed"` [INFO] [stdout] 0ab67c46faf788b527972ed62c0603dd00724859d5c33d6ebf4507920637e5ed [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/beta-1.37-6/worker-6/1.36.0:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/beta-1.37-6/sources/1.36.0/gh/saterus/gilded-rose-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+1.36.0" "test" "--frozen"` [INFO] [stdout] 0f45e416a6f1bcb4019cad170e30bf298c1d094e3e2c41306339d953a2aa93e1 [INFO] running `"docker" "start" "-a" "0f45e416a6f1bcb4019cad170e30bf298c1d094e3e2c41306339d953a2aa93e1"` [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.02s [INFO] [stderr] Running /opt/crater/target/debug/deps/gilded_rose-46145c7ed3f18cd6 [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out [INFO] [stdout] [INFO] [stderr] Running /opt/crater/target/debug/deps/gilded_rose-e26c9f3d82c653a6 [INFO] [stdout] [INFO] [stdout] running 1 test [INFO] [stdout] test normal_items_decrease_quality ... ok [INFO] [stdout] [INFO] [stdout] test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out [INFO] [stdout] [INFO] [stderr] Doc-tests gilded_rose [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out [INFO] [stdout] [INFO] running `"docker" "inspect" "0f45e416a6f1bcb4019cad170e30bf298c1d094e3e2c41306339d953a2aa93e1"` [INFO] running `"docker" "rm" "-f" "0f45e416a6f1bcb4019cad170e30bf298c1d094e3e2c41306339d953a2aa93e1"` [INFO] [stdout] 0f45e416a6f1bcb4019cad170e30bf298c1d094e3e2c41306339d953a2aa93e1