[INFO] fetching crate curve25519-dalek-ng 4.1.1... [INFO] checking curve25519-dalek-ng-4.1.1 against master#385fa9d845dd326c6bbfd58c22244215e431948a for absurd-question-mark-desugar [INFO] extracting crate curve25519-dalek-ng 4.1.1 into /workspace/builds/worker-2-tc1/source [INFO] validating manifest of crates.io crate curve25519-dalek-ng 4.1.1 on toolchain 385fa9d845dd326c6bbfd58c22244215e431948a [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+385fa9d845dd326c6bbfd58c22244215e431948a" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate curve25519-dalek-ng 4.1.1 [INFO] finished tweaking crates.io crate curve25519-dalek-ng 4.1.1 [INFO] tweaked toml for crates.io crate curve25519-dalek-ng 4.1.1 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+385fa9d845dd326c6bbfd58c22244215e431948a" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 81 packages [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.5.0) [INFO] [stderr] Adding block-buffer v0.9.0 (latest: v0.10.4) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.4) [INFO] [stderr] Adding criterion v0.3.6 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (latest: v0.5.0) [INFO] [stderr] Adding digest v0.9.0 (latest: v0.10.7) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.0.0) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.3.9) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.12.1) [INFO] [stderr] Adding libm v0.1.4 (latest: v0.2.8) [INFO] [stderr] Adding sha2 v0.9.9 (latest: v0.10.8) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.0+wasi-0.2.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+385fa9d845dd326c6bbfd58c22244215e431948a" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded subtle-ng v2.5.0 [INFO] [stderr] Downloaded packed_simd_2 v0.3.8 [INFO] [stderr] Downloaded libm v0.1.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+385fa9d845dd326c6bbfd58c22244215e431948a" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 685653d447b9a486946057e4cd33bdfa6bda540a47f771fa8bfc32080ec3ac9a [INFO] running `Command { std: "docker" "start" "-a" "685653d447b9a486946057e4cd33bdfa6bda540a47f771fa8bfc32080ec3ac9a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "685653d447b9a486946057e4cd33bdfa6bda540a47f771fa8bfc32080ec3ac9a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "685653d447b9a486946057e4cd33bdfa6bda540a47f771fa8bfc32080ec3ac9a", kill_on_drop: false }` [INFO] [stdout] 685653d447b9a486946057e4cd33bdfa6bda540a47f771fa8bfc32080ec3ac9a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+385fa9d845dd326c6bbfd58c22244215e431948a" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 543858be9ca498dd68911f5da06fbc2fd8141d9fa6c1385a5c5c5c98fc1fb971 [INFO] running `Command { std: "docker" "start" "-a" "543858be9ca498dd68911f5da06fbc2fd8141d9fa6c1385a5c5c5c98fc1fb971", kill_on_drop: false }` [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking subtle-ng v2.5.0 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking curve25519-dalek-ng v4.1.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stdout] warning: the item `Eq` is imported redundantly [INFO] [stdout] --> src/scalar.rs:142:17 [INFO] [stdout] | [INFO] [stdout] 142 | use core::cmp::{Eq, PartialEq}; [INFO] [stdout] | ^^ [INFO] [stdout] --> /rustc/385fa9d845dd326c6bbfd58c22244215e431948a/library/core/src/prelude/mod.rs:37:13 [INFO] [stdout] | [INFO] [stdout] = note: the item `Eq` is already defined here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `PartialEq` is imported redundantly [INFO] [stdout] --> src/scalar.rs:142:21 [INFO] [stdout] | [INFO] [stdout] 142 | use core::cmp::{Eq, PartialEq}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] --> /rustc/385fa9d845dd326c6bbfd58c22244215e431948a/library/core/src/prelude/mod.rs:37:13 [INFO] [stdout] | [INFO] [stdout] = note: the item `PartialEq` is already defined here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Iterator` is imported redundantly [INFO] [stdout] --> src/edwards.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 97 | use core::iter::Iterator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] --> /rustc/385fa9d845dd326c6bbfd58c22244215e431948a/library/core/src/prelude/mod.rs:37:13 [INFO] [stdout] | [INFO] [stdout] = note: the item `Iterator` is already defined here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `subtle` is imported redundantly [INFO] [stdout] --> src/traits.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | use subtle; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/lib.rs:39:1 [INFO] [stdout] | [INFO] [stdout] 39 | extern crate subtle; [INFO] [stdout] | -------------------- the item `subtle` is already imported here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Eq` is imported redundantly [INFO] [stdout] --> src/field.rs:25:17 [INFO] [stdout] | [INFO] [stdout] 25 | use core::cmp::{Eq, PartialEq}; [INFO] [stdout] | ^^ [INFO] [stdout] --> /rustc/385fa9d845dd326c6bbfd58c22244215e431948a/library/core/src/prelude/mod.rs:37:13 [INFO] [stdout] | [INFO] [stdout] = note: the item `Eq` is already defined here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `PartialEq` is imported redundantly [INFO] [stdout] --> src/field.rs:25:21 [INFO] [stdout] | [INFO] [stdout] 25 | use core::cmp::{Eq, PartialEq}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] --> /rustc/385fa9d845dd326c6bbfd58c22244215e431948a/library/core/src/prelude/mod.rs:37:13 [INFO] [stdout] | [INFO] [stdout] = note: the item `PartialEq` is already defined here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `backend::serial::u64::field::*` [INFO] [stdout] --> src/field.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | pub use backend::serial::u64::field::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ProjectivePoint` [INFO] [stdout] --> src/backend/serial/scalar_mul/variable_base.rs:6:59 [INFO] [stdout] | [INFO] [stdout] 6 | use backend::serial::curve_models::{ProjectiveNielsPoint, ProjectivePoint}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ValidityCheck` is never used [INFO] [stdout] --> src/traits.rs:375:18 [INFO] [stdout] | [INFO] [stdout] 375 | pub(crate) trait ValidityCheck { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/ristretto.rs:913:77 [INFO] [stdout] | [INFO] [stdout] 913 | let extended_points = points.into_iter().map(|opt_P| opt_P.map(|P| P.borrow().0)); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `RistrettoPoint` does not implement `Borrow`, so calling `borrow` on `&RistrettoPoint` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 913 - let extended_points = points.into_iter().map(|opt_P| opt_P.map(|P| P.borrow().0)); [INFO] [stdout] 913 + let extended_points = points.into_iter().map(|opt_P| opt_P.map(|P| P.0)); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `RistrettoPoint`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 438 + #[derive(Clone)] [INFO] [stdout] 439 | pub struct RistrettoPoint(pub(crate) EdwardsPoint); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking criterion v0.3.6 [INFO] [stdout] warning: use of deprecated method `criterion::Criterion::::bench_function_over_inputs`: Please use BenchmarkGroups instead. [INFO] [stdout] --> benches/dalek_benchmarks.rs:105:11 [INFO] [stdout] | [INFO] [stdout] 105 | c.bench_function_over_inputs( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `criterion::Criterion::::bench_function_over_inputs`: Please use BenchmarkGroups instead. [INFO] [stdout] --> benches/dalek_benchmarks.rs:122:11 [INFO] [stdout] | [INFO] [stdout] 122 | c.bench_function_over_inputs( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `criterion::Criterion::::bench_function_over_inputs`: Please use BenchmarkGroups instead. [INFO] [stdout] --> benches/dalek_benchmarks.rs:141:11 [INFO] [stdout] | [INFO] [stdout] 141 | c.bench_function_over_inputs( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `criterion::Criterion::::bench_function_over_inputs`: Please use BenchmarkGroups instead. [INFO] [stdout] --> benches/dalek_benchmarks.rs:167:11 [INFO] [stdout] | [INFO] [stdout] 167 | c.bench_function_over_inputs( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `criterion::Criterion::::bench_function_over_inputs`: Please use BenchmarkGroups instead. [INFO] [stdout] --> benches/dalek_benchmarks.rs:248:11 [INFO] [stdout] | [INFO] [stdout] 248 | c.bench_function_over_inputs( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `criterion::Criterion::::bench_function_over_inputs`: Please use BenchmarkGroups instead. [INFO] [stdout] --> benches/dalek_benchmarks.rs:300:11 [INFO] [stdout] | [INFO] [stdout] 300 | c.bench_function_over_inputs( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `construct` is never used [INFO] [stdout] --> benches/dalek_benchmarks.rs:100:8 [INFO] [stdout] | [INFO] [stdout] 100 | fn construct(n: usize) -> (Vec, Vec) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Eq` is imported redundantly [INFO] [stdout] --> src/scalar.rs:142:17 [INFO] [stdout] | [INFO] [stdout] 142 | use core::cmp::{Eq, PartialEq}; [INFO] [stdout] | ^^ [INFO] [stdout] --> /rustc/385fa9d845dd326c6bbfd58c22244215e431948a/library/core/src/prelude/mod.rs:37:13 [INFO] [stdout] | [INFO] [stdout] = note: the item `Eq` is already defined here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `PartialEq` is imported redundantly [INFO] [stdout] --> src/scalar.rs:142:21 [INFO] [stdout] | [INFO] [stdout] 142 | use core::cmp::{Eq, PartialEq}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] --> /rustc/385fa9d845dd326c6bbfd58c22244215e431948a/library/core/src/prelude/mod.rs:37:13 [INFO] [stdout] | [INFO] [stdout] = note: the item `PartialEq` is already defined here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `constants` is imported redundantly [INFO] [stdout] --> src/scalar.rs:1190:9 [INFO] [stdout] | [INFO] [stdout] 1189 | use super::*; [INFO] [stdout] | -------- the item `constants` is already imported here [INFO] [stdout] 1190 | use constants; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Iterator` is imported redundantly [INFO] [stdout] --> src/edwards.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 97 | use core::iter::Iterator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] --> /rustc/385fa9d845dd326c6bbfd58c22244215e431948a/library/core/src/prelude/mod.rs:37:13 [INFO] [stdout] | [INFO] [stdout] = note: the item `Iterator` is already defined here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `FieldElement` is imported redundantly [INFO] [stdout] --> src/edwards.rs:949:9 [INFO] [stdout] | [INFO] [stdout] 949 | use field::FieldElement; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 953 | use super::*; [INFO] [stdout] | -------- the item `FieldElement` is already imported here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Scalar` is imported redundantly [INFO] [stdout] --> src/edwards.rs:950:9 [INFO] [stdout] | [INFO] [stdout] 950 | use scalar::Scalar; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 953 | use super::*; [INFO] [stdout] | -------- the item `Scalar` is already imported here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `ConditionallySelectable` is imported redundantly [INFO] [stdout] --> src/edwards.rs:951:9 [INFO] [stdout] | [INFO] [stdout] 951 | use subtle::ConditionallySelectable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 952 | use constants; [INFO] [stdout] 953 | use super::*; [INFO] [stdout] | -------- the item `ConditionallySelectable` is already imported here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `constants` is imported redundantly [INFO] [stdout] --> src/edwards.rs:952:9 [INFO] [stdout] | [INFO] [stdout] 952 | use constants; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 953 | use super::*; [INFO] [stdout] | -------- the item `constants` is already imported here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Scalar` is imported redundantly [INFO] [stdout] --> src/ristretto.rs:1089:9 [INFO] [stdout] | [INFO] [stdout] 1089 | use scalar::Scalar; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1093 | use super::*; [INFO] [stdout] | -------- the item `Scalar` is already imported here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `constants` is imported redundantly [INFO] [stdout] --> src/ristretto.rs:1090:9 [INFO] [stdout] | [INFO] [stdout] 1090 | use constants; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1093 | use super::*; [INFO] [stdout] | -------- the item `constants` is already imported here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Identity` is imported redundantly [INFO] [stdout] --> src/ristretto.rs:1092:18 [INFO] [stdout] | [INFO] [stdout] 1092 | use traits::{Identity}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 1093 | use super::*; [INFO] [stdout] | -------- the item `Identity` is already imported here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `subtle` is imported redundantly [INFO] [stdout] --> src/traits.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | use subtle; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/lib.rs:39:1 [INFO] [stdout] | [INFO] [stdout] 39 | extern crate subtle; [INFO] [stdout] | -------------------- the item `subtle` is already imported here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Eq` is imported redundantly [INFO] [stdout] --> src/field.rs:25:17 [INFO] [stdout] | [INFO] [stdout] 25 | use core::cmp::{Eq, PartialEq}; [INFO] [stdout] | ^^ [INFO] [stdout] --> /rustc/385fa9d845dd326c6bbfd58c22244215e431948a/library/core/src/prelude/mod.rs:37:13 [INFO] [stdout] | [INFO] [stdout] = note: the item `Eq` is already defined here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `PartialEq` is imported redundantly [INFO] [stdout] --> src/field.rs:25:21 [INFO] [stdout] | [INFO] [stdout] 25 | use core::cmp::{Eq, PartialEq}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] --> /rustc/385fa9d845dd326c6bbfd58c22244215e431948a/library/core/src/prelude/mod.rs:37:13 [INFO] [stdout] | [INFO] [stdout] = note: the item `PartialEq` is already defined here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `backend::serial::u64::field::*` [INFO] [stdout] --> src/field.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | pub use backend::serial::u64::field::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `ConditionallyNegatable` is imported redundantly [INFO] [stdout] --> src/field.rs:281:9 [INFO] [stdout] | [INFO] [stdout] 280 | use field::*; [INFO] [stdout] | -------- the item `ConditionallyNegatable` is already imported here [INFO] [stdout] 281 | use subtle::ConditionallyNegatable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ProjectivePoint` [INFO] [stdout] --> src/backend/serial/scalar_mul/variable_base.rs:6:59 [INFO] [stdout] | [INFO] [stdout] 6 | use backend::serial::curve_models::{ProjectiveNielsPoint, ProjectivePoint}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Scalar` is imported redundantly [INFO] [stdout] --> src/backend/serial/scalar_mul/pippenger.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 167 | use super::*; [INFO] [stdout] | -------- the item `Scalar` is already imported here [INFO] [stdout] 168 | use constants; [INFO] [stdout] 169 | use scalar::Scalar; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/ristretto.rs:913:77 [INFO] [stdout] | [INFO] [stdout] 913 | let extended_points = points.into_iter().map(|opt_P| opt_P.map(|P| P.borrow().0)); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ristretto::RistrettoPoint` does not implement `Borrow`, so calling `borrow` on `&ristretto::RistrettoPoint` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 913 - let extended_points = points.into_iter().map(|opt_P| opt_P.map(|P| P.borrow().0)); [INFO] [stdout] 913 + let extended_points = points.into_iter().map(|opt_P| opt_P.map(|P| P.0)); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ristretto::RistrettoPoint`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 438 + #[derive(Clone)] [INFO] [stdout] 439 | pub struct RistrettoPoint(pub(crate) EdwardsPoint); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 19 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.30s [INFO] running `Command { std: "docker" "inspect" "543858be9ca498dd68911f5da06fbc2fd8141d9fa6c1385a5c5c5c98fc1fb971", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "543858be9ca498dd68911f5da06fbc2fd8141d9fa6c1385a5c5c5c98fc1fb971", kill_on_drop: false }` [INFO] [stdout] 543858be9ca498dd68911f5da06fbc2fd8141d9fa6c1385a5c5c5c98fc1fb971 [INFO] checking curve25519-dalek-ng-4.1.1 against try#645bb72776a6a56a1a8f52631a44bd082b2ba509 for absurd-question-mark-desugar [INFO] extracting crate curve25519-dalek-ng 4.1.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate curve25519-dalek-ng 4.1.1 on toolchain 645bb72776a6a56a1a8f52631a44bd082b2ba509 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+645bb72776a6a56a1a8f52631a44bd082b2ba509" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate curve25519-dalek-ng 4.1.1 [INFO] finished tweaking crates.io crate curve25519-dalek-ng 4.1.1 [INFO] tweaked toml for crates.io crate curve25519-dalek-ng 4.1.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+645bb72776a6a56a1a8f52631a44bd082b2ba509" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+645bb72776a6a56a1a8f52631a44bd082b2ba509" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+645bb72776a6a56a1a8f52631a44bd082b2ba509" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1ae8f84e3ba9c42f901cd789fe1ed212bde6930bbf5d1923f1eba28065209508 [INFO] running `Command { std: "docker" "start" "-a" "1ae8f84e3ba9c42f901cd789fe1ed212bde6930bbf5d1923f1eba28065209508", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1ae8f84e3ba9c42f901cd789fe1ed212bde6930bbf5d1923f1eba28065209508", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ae8f84e3ba9c42f901cd789fe1ed212bde6930bbf5d1923f1eba28065209508", kill_on_drop: false }` [INFO] [stdout] 1ae8f84e3ba9c42f901cd789fe1ed212bde6930bbf5d1923f1eba28065209508 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+645bb72776a6a56a1a8f52631a44bd082b2ba509" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f5a44dffc0dcc1d2969e932e4ce6359b1f61efe3d30fb44bffc7b42a725bd7ad [INFO] running `Command { std: "docker" "start" "-a" "f5a44dffc0dcc1d2969e932e4ce6359b1f61efe3d30fb44bffc7b42a725bd7ad", kill_on_drop: false }` [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking subtle-ng v2.5.0 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking curve25519-dalek-ng v4.1.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stdout] warning: the item `Eq` is imported redundantly [INFO] [stdout] --> src/scalar.rs:142:17 [INFO] [stdout] | [INFO] [stdout] 142 | use core::cmp::{Eq, PartialEq}; [INFO] [stdout] | ^^ [INFO] [stdout] --> /rustc/645bb72776a6a56a1a8f52631a44bd082b2ba509/library/core/src/prelude/mod.rs:37:13 [INFO] [stdout] | [INFO] [stdout] = note: the item `Eq` is already defined here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `PartialEq` is imported redundantly [INFO] [stdout] --> src/scalar.rs:142:21 [INFO] [stdout] | [INFO] [stdout] 142 | use core::cmp::{Eq, PartialEq}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] --> /rustc/645bb72776a6a56a1a8f52631a44bd082b2ba509/library/core/src/prelude/mod.rs:37:13 [INFO] [stdout] | [INFO] [stdout] = note: the item `PartialEq` is already defined here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Iterator` is imported redundantly [INFO] [stdout] --> src/edwards.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 97 | use core::iter::Iterator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] --> /rustc/645bb72776a6a56a1a8f52631a44bd082b2ba509/library/core/src/prelude/mod.rs:37:13 [INFO] [stdout] | [INFO] [stdout] = note: the item `Iterator` is already defined here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `subtle` is imported redundantly [INFO] [stdout] --> src/traits.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | use subtle; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/lib.rs:39:1 [INFO] [stdout] | [INFO] [stdout] 39 | extern crate subtle; [INFO] [stdout] | -------------------- the item `subtle` is already imported here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Eq` is imported redundantly [INFO] [stdout] --> src/field.rs:25:17 [INFO] [stdout] | [INFO] [stdout] 25 | use core::cmp::{Eq, PartialEq}; [INFO] [stdout] | ^^ [INFO] [stdout] --> /rustc/645bb72776a6a56a1a8f52631a44bd082b2ba509/library/core/src/prelude/mod.rs:37:13 [INFO] [stdout] | [INFO] [stdout] = note: the item `Eq` is already defined here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `PartialEq` is imported redundantly [INFO] [stdout] --> src/field.rs:25:21 [INFO] [stdout] | [INFO] [stdout] 25 | use core::cmp::{Eq, PartialEq}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] --> /rustc/645bb72776a6a56a1a8f52631a44bd082b2ba509/library/core/src/prelude/mod.rs:37:13 [INFO] [stdout] | [INFO] [stdout] = note: the item `PartialEq` is already defined here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `backend::serial::u64::field::*` [INFO] [stdout] --> src/field.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | pub use backend::serial::u64::field::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ProjectivePoint` [INFO] [stdout] --> src/backend/serial/scalar_mul/variable_base.rs:6:59 [INFO] [stdout] | [INFO] [stdout] 6 | use backend::serial::curve_models::{ProjectiveNielsPoint, ProjectivePoint}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stdout] warning: trait `ValidityCheck` is never used [INFO] [stdout] --> src/traits.rs:375:18 [INFO] [stdout] | [INFO] [stdout] 375 | pub(crate) trait ValidityCheck { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/ristretto.rs:913:77 [INFO] [stdout] | [INFO] [stdout] 913 | let extended_points = points.into_iter().map(|opt_P| opt_P.map(|P| P.borrow().0)); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `RistrettoPoint` does not implement `Borrow`, so calling `borrow` on `&RistrettoPoint` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 913 - let extended_points = points.into_iter().map(|opt_P| opt_P.map(|P| P.borrow().0)); [INFO] [stdout] 913 + let extended_points = points.into_iter().map(|opt_P| opt_P.map(|P| P.0)); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `RistrettoPoint`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 438 + #[derive(Clone)] [INFO] [stdout] 439 | pub struct RistrettoPoint(pub(crate) EdwardsPoint); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking criterion v0.3.6 [INFO] [stdout] warning: use of deprecated method `criterion::Criterion::::bench_function_over_inputs`: Please use BenchmarkGroups instead. [INFO] [stdout] --> benches/dalek_benchmarks.rs:105:11 [INFO] [stdout] | [INFO] [stdout] 105 | c.bench_function_over_inputs( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `criterion::Criterion::::bench_function_over_inputs`: Please use BenchmarkGroups instead. [INFO] [stdout] --> benches/dalek_benchmarks.rs:122:11 [INFO] [stdout] | [INFO] [stdout] 122 | c.bench_function_over_inputs( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `criterion::Criterion::::bench_function_over_inputs`: Please use BenchmarkGroups instead. [INFO] [stdout] --> benches/dalek_benchmarks.rs:141:11 [INFO] [stdout] | [INFO] [stdout] 141 | c.bench_function_over_inputs( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `criterion::Criterion::::bench_function_over_inputs`: Please use BenchmarkGroups instead. [INFO] [stdout] --> benches/dalek_benchmarks.rs:167:11 [INFO] [stdout] | [INFO] [stdout] 167 | c.bench_function_over_inputs( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `criterion::Criterion::::bench_function_over_inputs`: Please use BenchmarkGroups instead. [INFO] [stdout] --> benches/dalek_benchmarks.rs:248:11 [INFO] [stdout] | [INFO] [stdout] 248 | c.bench_function_over_inputs( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `criterion::Criterion::::bench_function_over_inputs`: Please use BenchmarkGroups instead. [INFO] [stdout] --> benches/dalek_benchmarks.rs:300:11 [INFO] [stdout] | [INFO] [stdout] 300 | c.bench_function_over_inputs( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `construct` is never used [INFO] [stdout] --> benches/dalek_benchmarks.rs:100:8 [INFO] [stdout] | [INFO] [stdout] 100 | fn construct(n: usize) -> (Vec, Vec) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Eq` is imported redundantly [INFO] [stdout] --> src/scalar.rs:142:17 [INFO] [stdout] | [INFO] [stdout] 142 | use core::cmp::{Eq, PartialEq}; [INFO] [stdout] | ^^ [INFO] [stdout] --> /rustc/645bb72776a6a56a1a8f52631a44bd082b2ba509/library/core/src/prelude/mod.rs:37:13 [INFO] [stdout] | [INFO] [stdout] = note: the item `Eq` is already defined here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `PartialEq` is imported redundantly [INFO] [stdout] --> src/scalar.rs:142:21 [INFO] [stdout] | [INFO] [stdout] 142 | use core::cmp::{Eq, PartialEq}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] --> /rustc/645bb72776a6a56a1a8f52631a44bd082b2ba509/library/core/src/prelude/mod.rs:37:13 [INFO] [stdout] | [INFO] [stdout] = note: the item `PartialEq` is already defined here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `constants` is imported redundantly [INFO] [stdout] --> src/scalar.rs:1190:9 [INFO] [stdout] | [INFO] [stdout] 1189 | use super::*; [INFO] [stdout] | -------- the item `constants` is already imported here [INFO] [stdout] 1190 | use constants; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Iterator` is imported redundantly [INFO] [stdout] --> src/edwards.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 97 | use core::iter::Iterator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] --> /rustc/645bb72776a6a56a1a8f52631a44bd082b2ba509/library/core/src/prelude/mod.rs:37:13 [INFO] [stdout] | [INFO] [stdout] = note: the item `Iterator` is already defined here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `FieldElement` is imported redundantly [INFO] [stdout] --> src/edwards.rs:949:9 [INFO] [stdout] | [INFO] [stdout] 949 | use field::FieldElement; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 953 | use super::*; [INFO] [stdout] | -------- the item `FieldElement` is already imported here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Scalar` is imported redundantly [INFO] [stdout] --> src/edwards.rs:950:9 [INFO] [stdout] | [INFO] [stdout] 950 | use scalar::Scalar; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 953 | use super::*; [INFO] [stdout] | -------- the item `Scalar` is already imported here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `ConditionallySelectable` is imported redundantly [INFO] [stdout] --> src/edwards.rs:951:9 [INFO] [stdout] | [INFO] [stdout] 951 | use subtle::ConditionallySelectable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 952 | use constants; [INFO] [stdout] 953 | use super::*; [INFO] [stdout] | -------- the item `ConditionallySelectable` is already imported here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `constants` is imported redundantly [INFO] [stdout] --> src/edwards.rs:952:9 [INFO] [stdout] | [INFO] [stdout] 952 | use constants; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 953 | use super::*; [INFO] [stdout] | -------- the item `constants` is already imported here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Scalar` is imported redundantly [INFO] [stdout] --> src/ristretto.rs:1089:9 [INFO] [stdout] | [INFO] [stdout] 1089 | use scalar::Scalar; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1093 | use super::*; [INFO] [stdout] | -------- the item `Scalar` is already imported here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `constants` is imported redundantly [INFO] [stdout] --> src/ristretto.rs:1090:9 [INFO] [stdout] | [INFO] [stdout] 1090 | use constants; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1093 | use super::*; [INFO] [stdout] | -------- the item `constants` is already imported here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Identity` is imported redundantly [INFO] [stdout] --> src/ristretto.rs:1092:18 [INFO] [stdout] | [INFO] [stdout] 1092 | use traits::{Identity}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 1093 | use super::*; [INFO] [stdout] | -------- the item `Identity` is already imported here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `subtle` is imported redundantly [INFO] [stdout] --> src/traits.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | use subtle; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/lib.rs:39:1 [INFO] [stdout] | [INFO] [stdout] 39 | extern crate subtle; [INFO] [stdout] | -------------------- the item `subtle` is already imported here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Eq` is imported redundantly [INFO] [stdout] --> src/field.rs:25:17 [INFO] [stdout] | [INFO] [stdout] 25 | use core::cmp::{Eq, PartialEq}; [INFO] [stdout] | ^^ [INFO] [stdout] --> /rustc/645bb72776a6a56a1a8f52631a44bd082b2ba509/library/core/src/prelude/mod.rs:37:13 [INFO] [stdout] | [INFO] [stdout] = note: the item `Eq` is already defined here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `PartialEq` is imported redundantly [INFO] [stdout] --> src/field.rs:25:21 [INFO] [stdout] | [INFO] [stdout] 25 | use core::cmp::{Eq, PartialEq}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] --> /rustc/645bb72776a6a56a1a8f52631a44bd082b2ba509/library/core/src/prelude/mod.rs:37:13 [INFO] [stdout] | [INFO] [stdout] = note: the item `PartialEq` is already defined here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `backend::serial::u64::field::*` [INFO] [stdout] --> src/field.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | pub use backend::serial::u64::field::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `ConditionallyNegatable` is imported redundantly [INFO] [stdout] --> src/field.rs:281:9 [INFO] [stdout] | [INFO] [stdout] 280 | use field::*; [INFO] [stdout] | -------- the item `ConditionallyNegatable` is already imported here [INFO] [stdout] 281 | use subtle::ConditionallyNegatable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ProjectivePoint` [INFO] [stdout] --> src/backend/serial/scalar_mul/variable_base.rs:6:59 [INFO] [stdout] | [INFO] [stdout] 6 | use backend::serial::curve_models::{ProjectiveNielsPoint, ProjectivePoint}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Scalar` is imported redundantly [INFO] [stdout] --> src/backend/serial/scalar_mul/pippenger.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 167 | use super::*; [INFO] [stdout] | -------- the item `Scalar` is already imported here [INFO] [stdout] 168 | use constants; [INFO] [stdout] 169 | use scalar::Scalar; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/ristretto.rs:913:77 [INFO] [stdout] | [INFO] [stdout] 913 | let extended_points = points.into_iter().map(|opt_P| opt_P.map(|P| P.borrow().0)); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ristretto::RistrettoPoint` does not implement `Borrow`, so calling `borrow` on `&ristretto::RistrettoPoint` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 913 - let extended_points = points.into_iter().map(|opt_P| opt_P.map(|P| P.borrow().0)); [INFO] [stdout] 913 + let extended_points = points.into_iter().map(|opt_P| opt_P.map(|P| P.0)); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ristretto::RistrettoPoint`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 438 + #[derive(Clone)] [INFO] [stdout] 439 | pub struct RistrettoPoint(pub(crate) EdwardsPoint); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 19 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.16s [INFO] running `Command { std: "docker" "inspect" "f5a44dffc0dcc1d2969e932e4ce6359b1f61efe3d30fb44bffc7b42a725bd7ad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f5a44dffc0dcc1d2969e932e4ce6359b1f61efe3d30fb44bffc7b42a725bd7ad", kill_on_drop: false }` [INFO] [stdout] f5a44dffc0dcc1d2969e932e4ce6359b1f61efe3d30fb44bffc7b42a725bd7ad