[INFO] cloning repository https://github.com/DarkMatter-999/LC3-vm [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DarkMatter-999/LC3-vm" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDarkMatter-999%2FLC3-vm", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDarkMatter-999%2FLC3-vm'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 217dff8a5a439cafd9d31d9009e04844834f6eb7 [INFO] checking DarkMatter-999/LC3-vm against master#385fa9d845dd326c6bbfd58c22244215e431948a for absurd-question-mark-desugar [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDarkMatter-999%2FLC3-vm" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/DarkMatter-999/LC3-vm on toolchain 385fa9d845dd326c6bbfd58c22244215e431948a [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+385fa9d845dd326c6bbfd58c22244215e431948a" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/DarkMatter-999/LC3-vm [INFO] finished tweaking git repo https://github.com/DarkMatter-999/LC3-vm [INFO] tweaked toml for git repo https://github.com/DarkMatter-999/LC3-vm written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/DarkMatter-999/LC3-vm already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+385fa9d845dd326c6bbfd58c22244215e431948a" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+385fa9d845dd326c6bbfd58c22244215e431948a" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a324f6daf6e5ef00c725b5e0c6e97f675f14a453ac474c73cf1b4878c1bd7273 [INFO] running `Command { std: "docker" "start" "-a" "a324f6daf6e5ef00c725b5e0c6e97f675f14a453ac474c73cf1b4878c1bd7273", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a324f6daf6e5ef00c725b5e0c6e97f675f14a453ac474c73cf1b4878c1bd7273", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a324f6daf6e5ef00c725b5e0c6e97f675f14a453ac474c73cf1b4878c1bd7273", kill_on_drop: false }` [INFO] [stdout] a324f6daf6e5ef00c725b5e0c6e97f675f14a453ac474c73cf1b4878c1bd7273 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+385fa9d845dd326c6bbfd58c22244215e431948a" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e02f09ccf175bd358b20c45cfce9fc3348feb589fabe99ee32328cc2c71fb958 [INFO] running `Command { std: "docker" "start" "-a" "e02f09ccf175bd358b20c45cfce9fc3348feb589fabe99ee32328cc2c71fb958", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.82 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling serde_derive v1.0.143 [INFO] [stderr] Compiling bumpalo v3.10.0 [INFO] [stderr] Compiling once_cell v1.13.0 [INFO] [stderr] Compiling serde v1.0.143 [INFO] [stderr] Compiling serde_json v1.0.83 [INFO] [stderr] Compiling wasm-bindgen v0.2.82 [INFO] [stderr] Checking itoa v1.0.3 [INFO] [stderr] Checking ryu v1.0.11 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.82 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.82 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.82 [INFO] [stderr] Checking lc3_core v0.1.0 (/opt/rustwide/workdir/lc3_core) [INFO] [stdout] warning: variant `kbsr` should have an upper camel case name [INFO] [stdout] --> lc3_core/src/memory.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | kbsr = 0xFE00, [INFO] [stdout] | ^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Kbsr` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `kbdr` should have an upper camel case name [INFO] [stdout] --> lc3_core/src/memory.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | kbdr = 0xFE02, [INFO] [stdout] | ^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Kbdr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> lc3_core/src/cpu.rs:5:26 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::memory::{Mem, self}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> lc3_core/src/cpu.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> lc3_core/src/cpu.rs:50:14 [INFO] [stdout] | [INFO] [stdout] 50 | while(self.running) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 50 - while(self.running) { [INFO] [stdout] 50 + while self.running { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `match` scrutinee expression [INFO] [stdout] --> lc3_core/src/cpu.rs:60:18 [INFO] [stdout] | [INFO] [stdout] 60 | match(OPCodes::from(op)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 60 - match(OPCodes::from(op)) { [INFO] [stdout] 60 + match OPCodes::from(op) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> lc3_core/src/cpu.rs:96:14 [INFO] [stdout] | [INFO] [stdout] 96 | while(i lc3_core/src/cpu.rs:112:18 [INFO] [stdout] | [INFO] [stdout] 112 | x |= (0xFFFF << bit_count); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 112 - x |= (0xFFFF << bit_count); [INFO] [stdout] 112 + x |= 0xFFFF << bit_count; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> lc3_core/src/cpu.rs:153:12 [INFO] [stdout] | [INFO] [stdout] 153 | if (*self.get_reg(r) == 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 153 - if (*self.get_reg(r) == 0) { [INFO] [stdout] 153 + if *self.get_reg(r) == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> lc3_core/src/cpu.rs:155:19 [INFO] [stdout] | [INFO] [stdout] 155 | } else if ((*self.get_reg(r) >> 15) != 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 155 - } else if ((*self.get_reg(r) >> 15) != 0) { [INFO] [stdout] 155 + } else if (*self.get_reg(r) >> 15) != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> lc3_core/src/cpu.rs:167:12 [INFO] [stdout] | [INFO] [stdout] 167 | if ((cond_flag & self.rcond) != 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 167 - if ((cond_flag & self.rcond) != 0) { [INFO] [stdout] 167 + if (cond_flag & self.rcond) != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> lc3_core/src/cpu.rs:182:12 [INFO] [stdout] | [INFO] [stdout] 182 | if (imm_flag != 0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 182 - if (imm_flag != 0) [INFO] [stdout] 182 + if imm_flag != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> lc3_core/src/cpu.rs:222:12 [INFO] [stdout] | [INFO] [stdout] 222 | if (long_flag != 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 222 - if (long_flag != 0) { [INFO] [stdout] 222 + if long_flag != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> lc3_core/src/cpu.rs:236:12 [INFO] [stdout] | [INFO] [stdout] 236 | if (imm_flag != 0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 236 - if (imm_flag != 0) [INFO] [stdout] 236 + if imm_flag != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> lc3_core/src/cpu.rs:361:16 [INFO] [stdout] | [INFO] [stdout] 361 | if (chr == 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 361 - if (chr == 0) { [INFO] [stdout] 361 + if chr == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> lc3_core/src/cpu.rs:393:16 [INFO] [stdout] | [INFO] [stdout] 393 | if (chr == 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 393 - if (chr == 0) { [INFO] [stdout] 393 + if chr == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> lc3_core/src/cpu.rs:397:22 [INFO] [stdout] | [INFO] [stdout] 397 | let c1 = ((chr & 0xFF) as u8); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 397 - let c1 = ((chr & 0xFF) as u8); [INFO] [stdout] 397 + let c1 = (chr & 0xFF) as u8; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> lc3_core/src/cpu.rs:399:22 [INFO] [stdout] | [INFO] [stdout] 399 | let c2 = ((chr >> 8) as u8); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 399 - let c2 = ((chr >> 8) as u8); [INFO] [stdout] 399 + let c2 = (chr >> 8) as u8; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> lc3_core/src/disassembler.rs:23:14 [INFO] [stdout] | [INFO] [stdout] 23 | x |= (0xFFFF << bit_count); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 23 - x |= (0xFFFF << bit_count); [INFO] [stdout] 23 + x |= 0xFFFF << bit_count; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> lc3_core/src/disassembler.rs:67:16 [INFO] [stdout] | [INFO] [stdout] 67 | if (long_flag != 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 67 - if (long_flag != 0) { [INFO] [stdout] 67 + if long_flag != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `inst` [INFO] [stdout] --> lc3_core/src/cpu.rs:277:23 [INFO] [stdout] | [INFO] [stdout] 277 | fn rti(&mut self, inst: u16) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_inst` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `inst` [INFO] [stdout] --> lc3_core/src/cpu.rs:320:23 [INFO] [stdout] | [INFO] [stdout] 320 | fn res(&mut self, inst: u16) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_inst` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `memory_max` should have an upper case name [INFO] [stdout] --> lc3_core/src/memory.rs:3:7 [INFO] [stdout] | [INFO] [stdout] 3 | const memory_max: usize = 1 << 16; [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper case: `MEMORY_MAX` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 23 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking LC3 v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.20s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: wasm-bindgen v0.2.82 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 3` [INFO] running `Command { std: "docker" "inspect" "e02f09ccf175bd358b20c45cfce9fc3348feb589fabe99ee32328cc2c71fb958", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e02f09ccf175bd358b20c45cfce9fc3348feb589fabe99ee32328cc2c71fb958", kill_on_drop: false }` [INFO] [stdout] e02f09ccf175bd358b20c45cfce9fc3348feb589fabe99ee32328cc2c71fb958